profile
viewpoint
Queeny queenypingcap PingCAP On my way to be a hacker

pingcap/website 4

The website of PingCAP. Powered by Gatsby ⚛️ and Rocket 🚀.

queenypingcap/angular-translate 0

Translating your AngularJS 1.x apps

queenypingcap/asynq 0

Python library for asynchronous programming

queenypingcap/awesome-database-learning 0

A list of learning materials to understand databases internals

queenypingcap/awesome-for-beginners 0

A list of awesome beginners-friendly projects.

queenypingcap/awesome-kubernetes 0

A curated list for awesome kubernetes sources :ship::tada:

queenypingcap/awesome-remote-job 0

A curated list of awesome remote jobs and resources. Inspired by https://github.com/vinta/awesome-python

queenypingcap/awesome-rust 0

A curated list of Rust code and resources.

queenypingcap/awesome-wasm 0

😎 Curated list of awesome things regarding WebAssembly (wasm) ecosystem.

fork spacejam/ed25519-dalek

Fast and efficient ed25519 signing and verification in Rust.

fork in 19 minutes

pull request commentpingcap/tidb-operator

Refine basic examples about "max-open-files" for TiKV

Codecov Report

Merging #3523 (8a1d087) into master (2ef7128) will decrease coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3523      +/-   ##
==========================================
- Coverage   60.32%   60.30%   -0.02%     
==========================================
  Files         162      162              
  Lines       16725    16725              
==========================================
- Hits        10089    10086       -3     
- Misses       5675     5677       +2     
- Partials      961      962       +1     
Flag Coverage Δ
unittest 60.30% <ø> (?)
csuzhangxc

comment created time in an hour

pull request commentpingcap/tidb-operator

Refine basic examples about "max-open-files" for TiKV

CLA assistant check <br/>Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.<br/><sub>You have signed the CLA already but the status is still pending? Let us recheck it.</sub>

csuzhangxc

comment created time in an hour

PR opened pingcap/tidb-operator

Refine basic examples about "max-open-files" for TiKV

<!-- Thank you for contributing to TiDB Operator! Please read TiDB Operator's CONTRIBUTING document BEFORE filing this PR. -->

What problem does this PR solve? <!--add and issue link with summary if exists-->

run basic examples in some K8s cluster may got the maximum number of open file descriptors is too small, got 1024, expect greater or equal to 82920 for TiKV.

What is changed and how does it work?

add max-open-files: 256 config item for rocksdb and raftdb.

Check List <!--REMOVE the items that are not applicable-->

Tests <!-- At least one of them must be included. -->

  • No code

Code changes

  • None

Side effects

  • None

Related changes

  • None

Does this PR introduce a user-facing change?:

<!-- If no, just leave the release note block below as is. If yes, a release note is required: Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". Please refer to Release Notes Language Style Guide before writing the release note. -->

NONE
+12 -0

0 comment

2 changed files

pr created time in an hour

push eventpingcap/pingcap.github.io

gaohailang ci

commit sha 503c5865963fdfeafea7252f1f927deec6ffec8c

Update gh-pages [ci skip]

view details

push time in an hour

Pull request review commentpingcap/tidb-operator

improve codegen for golang code

 go mod vendor  CODEGEN_PKG=${CODEGEN_PKG:-$(ls -d -1 ./vendor/k8s.io/code-generator 2>/dev/null || echo ../code-generator)} +# `--output-base $SCRIPT_ROOT` will output generated code to current dir bash "${CODEGEN_PKG}"/generate-groups.sh "deepcopy,client,informer,lister" \     github.com/pingcap/tidb-operator/pkg/client \     github.com/pingcap/tidb-operator/pkg/apis \     pingcap:v1alpha1 \+    --output-base $SCRIPT_ROOT \     --go-header-file ./hack/boilerplate/boilerplate.generatego.txt+# then we merge generated code with our code base and clean up+cp -r github.com/pingcap/tidb-operator/pkg $SCRIPT_ROOT && rm -rf github.com

Could you please also help update the CONTRIBUTING.md to make it clear that if contributors update the CRD related types definition, they should run the hack/update-all.sh?

dragonly

comment created time in an hour

Pull request review commentpingcap/tidb-operator

improve codegen for golang code

 go mod vendor  CODEGEN_PKG=${CODEGEN_PKG:-$(ls -d -1 ./vendor/k8s.io/code-generator 2>/dev/null || echo ../code-generator)} +# `--output-base $SCRIPT_ROOT` will output generated code to current dir bash "${CODEGEN_PKG}"/generate-groups.sh "deepcopy,client,informer,lister" \     github.com/pingcap/tidb-operator/pkg/client \     github.com/pingcap/tidb-operator/pkg/apis \     pingcap:v1alpha1 \+    --output-base $SCRIPT_ROOT \     --go-header-file ./hack/boilerplate/boilerplate.generatego.txt+# then we merge generated code with our code base and clean up+cp -r github.com/pingcap/tidb-operator/pkg $SCRIPT_ROOT && rm -rf github.com

Does this work for both the cases where the code base is under $GOPATH or not?

dragonly

comment created time in an hour

Pull request review commentpingcap/tidb-operator

Fix PD failover when multi-cluster enabled

 func (m *pdMemberManager) shouldRecover(tc *v1alpha1.TidbCluster) bool { 		if !podutil.IsPodReady(pod) { 			return false 		}-		status, ok := tc.Status.PD.Members[pod.Name]-		if !ok || !status.Health {-			return false+		for pdName, pdMember := range tc.Status.PD.Members {

What if there is no member of this Pod?

handlerww

comment created time in 2 hours

issue commentpingcap/tidb-operator

Support failover for across Kubernetes clusters deployment

Upgrading and scaling should work as expected, we just need to verify them.

For the failover function, including PD, TiDB, TiFlash and TiKV, the current implementation is based on the failureMembers (PD/TiDB) or failureStores (TiKV/TiFlash), but since the multiple TidbClusters in the different Kubernetes clusters now are a whole one TiDB Cluster, if one Pod in one TidbCluster fails, the other TidbClusters may also know it and will record it in their status, which will cause failover happening for all of the TidbClusters for the same Pod, so we have to update the logic to record the failed Pods only in this cluster, maybe add the cluster domain to the match pattern here https://github.com/pingcap/tidb-operator/blob/master/pkg/manager/member/tikv_member_manager.go#L52 for TiKV and do similar filters for other components.

It works normally. The info about failureMembers is gathered from tc.Status.PD.Members. It's in-cluster operations.

DanielZhangQD

comment created time in 2 hours

push eventpingcap/pingcap.github.io

gaohailang ci

commit sha 9d6a20ef201cf6beafbd235356af20e2c3f67a69

Update gh-pages [ci skip]

view details

push time in 2 hours

push eventpingcap/pingcap.github.io

Yini Xu

commit sha 6b629397cb1ae2ab12c0e27cd34d06aa720b6be5

Update list.html chore: add a space around number

view details

push time in 2 hours

issue closedpingcap/tidb-operator

TLS Support for across Kubernetes deployment

Feature Request

Is your feature request related to a problem? Please describe: <!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] --> TLS should be fully supported for the across Kubernetes deployment

Describe the feature you'd like: <!-- A clear and concise description of what you want to happen. -->

Describe alternatives you've considered: <!-- A clear and concise description of any alternative solutions or features you've considered. -->

Teachability, Documentation, Adoption, Migration Strategy: <!-- If you can, explain some scenarios how users might use this, situations it would be helpful in. Any API designs, mockups, or diagrams are also helpful. -->

closed time in 2 hours

DanielZhangQD

issue commentpingcap/tidb-operator

TLS Support for across Kubernetes deployment

TLS is supported.

DanielZhangQD

comment created time in 2 hours

pull request commentpingcap/tidb-operator

Remove unreachable code

/test-pull-e2e-kind

hi-rustin

comment created time in 3 hours

push eventpingcap/pingcap.github.io

gaohailang ci

commit sha 8e91d9497cd6fbee545d4cec87dadc700435b8fb

Update gh-pages [ci skip]

view details

push time in 3 hours

pull request commentpingcap/tidb-operator

Remove unreachable code

test-pull-e2e-kind

hi-rustin

comment created time in 3 hours

delete branch pingcap/pingcap.github.io

delete branch : yini/updateDownloadPkg

delete time in 3 hours

push eventpingcap/pingcap.github.io

Yini Xu

commit sha 51fd083722a8a521b4214b5906a1841d00c1b78a

chore: extract tidb download package versions into json file (#523)

view details

push time in 3 hours

issue closedpingcap/pingcap.github.io

Update TiDB community download packages automatically

  • create a json file to store versions of TiDB download packages.
  • trigger pr to append new version to the json file.
  • trigger website to build

closed time in 3 hours

YiniXu9506

Pull request review commentpingcap/tidb-operator

add local volume support for Backup/Restore using BR

 const ( 	S3StorageProviderTypeAWS S3StorageProviderType = "aws" ) -// +k8s:openapi-gen=true // StorageProvider defines the configuration for storing a backup in backend storage.+// +k8s:openapi-gen=true type StorageProvider struct {-	S3  *S3StorageProvider  `json:"s3,omitempty"`-	Gcs *GcsStorageProvider `json:"gcs,omitempty"`+	S3    *S3StorageProvider    `json:"s3,omitempty"`+	Gcs   *GcsStorageProvider   `json:"gcs,omitempty"`+	Local *LocalStorageProvider `json:"local,omitempty"`+}++// LocalStorageProvider defines local storage options, which can be any k8s supported mounted volume+type LocalStorageProvider struct {+	Volume      *corev1.Volume      `json:"volume"`+	VolumeMount *corev1.VolumeMount `json:"volumeMount"`

done

dragonly

comment created time in 4 hours

Pull request review commentpingcap/tidb-operator

add local volume support for Backup/Restore using BR

 func GetRemotePath(backup *v1alpha1.Backup) (string, error) { 			path = fmt.Sprintf("gcs://%s/%s", bucket, prefix) 		} 		return path, nil+	case v1alpha1.BackupStorageTypeLocal:+		path = fmt.Sprintf("local://%s", backup.Spec.StorageProvider.Local.VolumeMount.MountPath)

done

dragonly

comment created time in 4 hours

Pull request review commentpingcap/tidb-operator

add local volume support for Backup/Restore using BR

 type gcsQuery struct { 	prefix       string } -// NewRemoteStorage creates new remote storage+// NewRemoteStorage creates new remote storage, now supports S3/GCS/Local func NewRemoteStorage(provider v1alpha1.StorageProvider) (*blob.Bucket, error) {

maybe NewStorageBackend is better, because this function returns a *blob.Bucket which actually represents a storage backend.

dragonly

comment created time in 4 hours

pull request commentpingcap/tidb-operator

Update examples for multi-cluster

/test pull-e2e-kind

handlerww

comment created time in 4 hours

Pull request review commentpingcap/tidb-operator

add local volume support for Backup/Restore using BR

 func getRemoteStorage(provider v1alpha1.StorageProvider) ([]string, error) { 		qs := checkGcsConfig(provider.Gcs, false) 		s := newGcsStorageOption(qs) 		return s, nil+	case v1alpha1.BackupStorageTypeLocal:+		cmdOpts, err := newLocalStorageOption(provider.Local.VolumeMount.MountPath)+		if err != nil {+			return nil, err+		}+		return cmdOpts, nil 	default:-		return nil, fmt.Errorf("storage %s not support yet", st)+		return nil, fmt.Errorf("storage %s not supported yet", st)+	}+}++// newLocalStorageOption constructs `--storage local://$PATH` arg for br+func newLocalStorageOption(mountPath string) ([]string, error) {+	if len(mountPath) == 0 {

confirmed that this will be detected by Job controller which tries to create the backup job, so this code is actually unreachable.

dragonly

comment created time in 4 hours

issue openedpingcap/pingcap.github.io

Update TiDB community download packages automatically

  • create a json file to store versions of TiDB download packages.
  • trigger pr to append new version to the json file.
  • trigger website to build

created time in 5 hours

create barnchpingcap/pingcap.github.io

branch : yini/updateDownloadPkg

created branch time in 5 hours

pull request commentpingcap/tidb-operator

Remove unreachable code

@handlerww: adding LGTM is restricted to reviewers in list.

<details>

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/ti-community-prow repository. </details>

hi-rustin

comment created time in 5 hours

pull request commentpingcap/tidb-operator

Remove unreachable code

/lgtm

hi-rustin

comment created time in 5 hours

more