Parsa Ghadimi qti3e 17 yo / High schooler

Pull request review commentgithub/linguist

Update list of TypeScript/JavaScript interpreters

-#!/usr/bin/env node+#!/usr/bin/env deno

This file is not valid in Deno. (mostly due to imports)

  1. Deno is not Node so you can not import packages like 'fs'
  2. The file extension is important (./x.ts is valid but ./x is not)
  3. Deno does not use NPM, so import * as tsickle from 'tsickle'; is not right etc...
Alhadis

comment created time in 13 days

PR closed Cloud-CV/Origami

Set CORS headers in webpack dev server

<!--- Provide a general, concise summary of your changes in the Title above The title should start with Fix #issue: (if applicable) followed by a one-line summary.--> This PR sets CORS headers in webpack dev server. (I'm from GCI)

Description

Currently, the webpack server is on port 3000 but the website is on port 8000, so a developer might see an error like this one:

Failed to load http://localhost:3000/static/bundles/fa6053e0dce6ca37f04f.hot-update.json: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:8000' is therefore not allowed access.

Types of changes

<!--- What types of changes does your code introduce? Put an x in all the boxes that apply: -->

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Other

Screenshots (if appropriate):

image

Checklist:

<!--- Go over all the following points, and put an x in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [x] My code follows the code style (modified PEP8) of this project.
  • [ ] I have updated the documentation accordingly.
  • [x] The code has been tested locally.
+587 -657

0 comment

22 changed files

qti3e

pr closed time in 17 days

more