profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/popomore/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Haoliang Gao popomore Alipay Co. Hangzhou China chuo.me Node Developer

hexojs/hexo 32740

A fast, simple & powerful blog framework, powered by Node.js.

mozilla/nunjucks 7287

A powerful templating engine with inheritance, asynchronous control, and more (jinja2 inspired)

macacajs/macaca-cli 457

Macaca command-line interface

macacajs/macaca-datahub 373

Continuous data provider for development, testing, staging and production. Just enjoy the data out-of-the-box.📦

lepture/nico 280

MAINTAINER WANTED!

macacajs/reliable 268

⌛Testing management suite with continuous delivery support.

blakeembrey/co-mocha 216

Enable support for generators in Mocha tests

node-modules/coffee 88

Test command line on Node.js

macacajs/awesome-macaca 86

A curated list of awesome things regarding Macaca ecosystem.

lepture/markit 72

A markdown parser and compiler with custom rendering. Forked from marked.

issue commentnodejs/node

display node.js version (process.version) at the end of stacktraces

My stance on this has changed. Print that stuff. Not that i have any say here, but hey. (Also, unsubscribing.)

ORESoftware

comment created time in 4 minutes

PR opened nodejs/node

typings: add JSDoc typings for events

Added JSDoc typings for the events lib module.

<!-- Before submitting a pull request, please read https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md.

Commit message formatting guidelines: https://github.com/nodejs/node/blob/HEAD/doc/guides/contributing/pull-requests.md#commit-message-guidelines

For code changes:

  1. Include tests for any bug fixes or new features.
  2. Update documentation if relevant.
  3. Ensure that make -j4 test (UNIX), or vcbuild test (Windows) passes.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+119 -3

0 comment

1 changed file

pr created time in an hour

push eventtc39/agendas

Michael Saboff

commit sha 7d271f18d8a5c74ee852b9618679ef5ed1f5a628

Update 05.md MLS schedule constraints.

view details

push time in an hour

issue openednodejs/node

Better diagnostics of leaks caused by objects which manage non-memory resources

Is your feature request related to a problem? Please describe. There are many relevant search results when one searches for terms "EMFILE" and "nodejs". These leaks are hard to detect because it could take a really long time until EMFILE happens.

Describe the solution you'd like Maybe for example nodejs could detect that stream was garbage collected without closing the file handle and print some warning about that. But maybe this would not be worth much. Maybe better would be to have some possibility to get a list of streams (or objects which manage non-memory resources in general) which were created but not destroyed yet. (There are some npm modules which provide heap dumps but these dumps contain too much "garbage").

Describe alternatives you've considered

created time in 3 hours

pull request commentnodejs/node

deps: update V8 to 9.1

@targos

v16.0.0: https://gist.github.com/targos/cd5fb0448ce9d62401bc24913b2511ff#file-v16-0-0-txt V8 9.1: https://gist.github.com/targos/cd5fb0448ce9d62401bc24913b2511ff#file-v8-9-1-txt

Are you sure those are the right files? I ask because they seem to have the same instances of functionOne and they also both have v8-91 in the paths reported.

targos

comment created time in 3 hours

push eventcncf/tag-app-delivery

jennifer

commit sha 5f32cbd7f818c4bea9036988e7b98b1ff2bd201d

narrative-voice: Frameworks

view details

jennifer

commit sha a6db29e08a628f048c81c4a46e72611ae32a5eb5

change cloud-native to cloud native Inspired by the Security whitepaper. It seems to be written that way consistently.

view details

push time in 3 hours

issue commentnodejs/node

Stream finished does not always work with http incoming message

This is exactly what I recommend not to do. Don't do anything after you have sent a response to the user (minus observability requirements/logging etc).

I think this is rather a question of practicality - maybe there are not many practical things which one could do after a response is sent but I do not see any reason why one could not do anything he/she wants. For example there could be an api call where the user sends some data and the server stores it in db and responds "ok" then starts some long lasting background job which does some processing of this data and there can be another api call which queries whether this job is done and retrieves results. Why would be this a bad idea?

misos1

comment created time in 3 hours

issue commentnodejs/node

Rename default branch from "master" to "main" or something similar

@bnb, not sure how I missed that it had already been done, thanks.

trivikr

comment created time in 3 hours

push eventcncf/tag-app-delivery

jennifer

commit sha 058c3a299e93dabdc01c06a49b98d7bd3608a213

narrative-voice: Security

view details

push time in 3 hours

startedVictoriaMetrics/VictoriaMetrics

started time in 3 hours

pull request commentopen-telemetry/opentelemetry-js

chore: add versioning proposal

image

image

Yikes. I'm in the middle of something at the moment but I actually have this mostly done. Just need to make a final pass and i'll update.

dyladan

comment created time in 4 hours

pull request commentopen-telemetry/opentelemetry-js

chore: add versioning proposal

@dyladan ping

dyladan

comment created time in 4 hours

issue openednodejs/node

WHATWG URL spec change: Make hostname setter no-op if a port is given

See https://github.com/whatwg/url/pull/604. We should align our "hostname state" accordingly: https://github.com/nodejs/node/blob/3b1a9936a8d193c7cb314f243fafea1ef7682738/src/node_url.cc#L1765-L1778

created time in 4 hours

issue commentnodejs/node

url.pathToFileURL should not dedup '/' in path

This issue seems to characterize the bug as related to the spec, but this is not true. new URL('file:///a//b').pathname gives /a//b as expected. The real trouble is the fact that we use path.resolve to sanitize inputs to url.pathToFileURL, and path.resolve deletes empty path parts.

We can either stop using path.resolve (the URL constructor resolves .. and . segments anyway), or we can document the limitations of this API.

bmeck

comment created time in 4 hours

Pull request review commentnodejs/node

doc: add node protocol to ESM and CommonJS api examples

 module default import or its corresponding sugar syntax:  <!-- eslint-disable no-duplicate-imports --> ```js-import { default as cjs } from 'cjs';+import { default as cjs } from 'node:cjs';

Thanks I'll be sure to fix this.

jeromecovington

comment created time in 4 hours

pull request commentnodejs/node

util: add util/errors

Sorry, I didn't find time to look at this during the long weekend. I'll do it first time tomorrow morning!

jasnell

comment created time in 4 hours

push eventtc39/agendas

Shane F. Carr

commit sha cbbec6ce7fe58c470c13654683ff7d175f718f27

Punt NFv3 to July meeting to allow more time for reviews

view details

push time in 4 hours

push eventtc39/agendas

Frank Yung-Fong Tang

commit sha 5b9fd2abedf137f92a1beacf2b569ba4ef66bc82

Update 05.md

view details

push time in 4 hours

push eventtc39/agendas

Frank Yung-Fong Tang

commit sha ba53008a5f20bf6ed8e4ad12387108ab60ae39a7

Move Intl Enumeration API to update only

view details

push time in 4 hours

push eventcncf/tag-app-delivery

jennifer

commit sha a26779bbbe00177abb5324ae09c07312ce8f985d

narrative-voice: Related Work

view details

push time in 4 hours

push eventcncf/tag-app-delivery

jennifer

commit sha 0a7f63037e9cee2d6bd508d2abd0facb0df79b8c

narrative-voice: Designing Operators

view details

push time in 4 hours

issue commentnodejs/node

Rename default branch from "master" to "main" or something similar

@mhdawson I already did education, apparently clicking the checkbox didn't take

trivikr

comment created time in 4 hours

pull request commentnodejs/node

deps: update V8 to 9.1

It seems to also break these recently added inspector tests on all platforms:

test.inspector-cli/test-inspector-cli-address
test.inspector-cli/test-inspector-cli-pid

https://ci.nodejs.org/job/node-test-commit-linuxone/27295/testReport/

/cc @nodejs/inspector @Trott

targos

comment created time in 4 hours

push eventcncf/tag-app-delivery

jennifer

commit sha e427dd190f873ec6226110b9db750f67acc17148

narrative-voice: Best Practices

view details

push time in 5 hours

startedgritzko/ron

started time in 5 hours

push eventcncf/tag-app-delivery

jennifer

commit sha 2aa3d83c1bd6120a2ac95c50c84f408cae9c2c91

narrative-voice: Use cases

view details

push time in 5 hours

push eventnodejs/node

Tobias Nießen

commit sha 3b1a9936a8d193c7cb314f243fafea1ef7682738

doc: document buffer.kStringMaxLength PR-URL: https://github.com/nodejs/node/pull/38688 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

push time in 5 hours

PR closed nodejs/node

doc: document buffer.kStringMaxLength author ready buffer doc

buffer.kMaxLength and buffer.kStringMaxLength are both legacy APIs, but neither is officially deprecated.

<!-- Before submitting a pull request, please read https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md.

Commit message formatting guidelines: https://github.com/nodejs/node/blob/HEAD/doc/guides/contributing/pull-requests.md#commit-message-guidelines

For code changes:

  1. Include tests for any bug fixes or new features.
  2. Update documentation if relevant.
  3. Ensure that make -j4 test (UNIX), or vcbuild test (Windows) passes.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+9 -0

1 comment

1 changed file

tniessen

pr closed time in 5 hours

pull request commentnodejs/node

doc: document buffer.kStringMaxLength

Landed in 3b1a9936a8d1

tniessen

comment created time in 5 hours

pull request commentnodejs/node

test: improve coverage of stream.Readable

CI: https://ci.nodejs.org/job/node-test-pull-request/38171/

pd4d10

comment created time in 5 hours