profile
viewpoint

poojaj-tech/sourcegraph-codecov 0

See code coverage information from Codecov on GitHub, Sourcegraph, and other tools.

issue commentsourcegraph/sourcegraph

Make every line of code as link following to usages (references)

Could you confirm that "Find references" is the popup and not the References pane below? Screen Shot 2020-08-12 at 1 40 22 PM

poojaj-tech

comment created time in 9 hours

issue openedsourcegraph/sourcegraph

Make every line of code as link following to usages (references)

Feature request description

Make every line as link following to usages

Is your feature request related to a problem? If so, please describe.

Customer feedback:

A lot of issues with UI. Find references windows pists me off because it is completely useless and appears every time. Search bar sometimes keeps unfolded

Customer: https://app.hubspot.com/contacts/2762526/contact/16241401/ Company: https://app.hubspot.com/contacts/2762526/company/732945850/

created time in 9 hours

pull request commentsourcegraph/sourcegraph

Update Sourcegraph cloud repopages

in favor of #12951

poojaj-tech

comment created time in 11 hours

PR closed sourcegraph/sourcegraph

Update Sourcegraph cloud repopages

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+108 -15

0 comment

8 changed files

poojaj-tech

pr closed time in 11 hours

PR opened sourcegraph/sourcegraph

Test updating repo names to cover languages, not just specific topics

Two quick updates:

  1. Rename Python2-to-3 to Python, /Python will SEO better
  2. Rename React Hooks to Javascript (considered React, but starting with JS since it's broader and we already have top 100 repos in site config)

Updates to site config to rename repogroups is require before landing this.

+22 -20

0 comment

4 changed files

pr created time in 11 hours

create barnchsourcegraph/sourcegraph

branch : updateRepogroups

created branch time in 11 hours

issue openedsourcegraph/sourcegraph

Give new users option to explore Sourcegraph Cloud during installation

Installation results show a huge drop-off at login screen, and another drop-off point when asked to add repositories. Capture and encourage Sourcegraph usage by directing them to Sourcegraph cloud! https://docs.google.com/document/d/1vx4veLKDM5p3VSzxIVnCKkt2fTHmwusfHYabCWWmbUU/edit#heading=h.l6y86qxbnm0l

created time in 13 hours

issue commentsourcegraph/sourcegraph

Update Repgroups on Cloud homepage

Add #2900 after renaming update #1 is complete. Additional repogroups or placeholder ones can be added the sitemap afterwards.

poojaj-tech

comment created time in 2 days

issue openedsourcegraph/sourcegraph

Update Repgroups on Cloud homepage

https://docs.google.com/document/d/1xwAMEsf31JAqvQyibAASplG4IhJ_l5hvyVcFVYn4M5Y/edit#heading=h.gqg72tglv2ah

Updates

  1. Update and test renaming repogroups for broader audiences -> react-hooks to react and python-2-to-3
  2. Add Java and Javascript placeholder repogroups
  3. Test topic repogroups like "artifical intelligence"

created time in 2 days

issue commentsourcegraph/sourcegraph

Documentation for configuring campaigns (scope for tokens)

(another issue filed by the customer: #259

poojaj-tech

comment created time in 2 days

PR opened sourcegraph/sourcegraph

Update Sourcegraph cloud repopages

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+108 -15

0 comment

8 changed files

pr created time in 2 days

create barnchsourcegraph/sourcegraph

branch : updateRepoNames

created branch time in 2 days

issue commentsourcegraph/sourcegraph

Update campaigns documentation for new workflow

@mrnugget heads up, I created a separate issue 12888 for a customer request for documentation. (I'm assuming this documentation request is for the old workflow)

mrnugget

comment created time in 2 days

issue openedsourcegraph/sourcegraph

Documentation for configuring campaigns (scope for tokens)

Customer feedback

better documentation on setting up/ configuring campaigns. For example I'd like to know what scope I need for tokens before I try to create/ import them. In secure environments where I don't have ownership of the organization it means that I have to request token form the owner, wait, try, get error, wait try....

Hubspot: https://app.hubspot.com/contacts/2762526/contact/16469101/

created time in 2 days

delete branch sourcegraph/about

delete branch : rolloutProcess

delete time in 5 days

push eventsourcegraph/about

Pooja Jain

commit sha d45d97182a50e7974d0f2f211f6b00f6155d53bf

Add Rollout Process (#1178) * Add Rollout Process * copy updates * format fix and updates * typo and updates * update description * Update rollout_process.md * Update rollout_process.md * Update rollout_process.md * Update rollout_process.md * Update rollout_process.md * Update rollout_process.md * Update rollout_process.md Add link to document with some details for deploying to internal users. It needs to be updated. * Update handbook/product/rollout_process.md Felix's update on turning on org settings. Co-authored-by: Felix Becker <felix.b@outlook.com> * Update rollout_process.md * Update handbook/product/rollout_process.md Co-authored-by: Christina Forney <christina@sourcegraph.com> * Update handbook/product/rollout_process.md Co-authored-by: Christina Forney <christina@sourcegraph.com> * before merge and after merge suggestions Co-authored-by: Christina Forney <christina@sourcegraph.com> * Post-launch suggestions Co-authored-by: Christina Forney <christina@sourcegraph.com> * Launch doc Co-authored-by: Christina Forney <christina@sourcegraph.com> * Update handbook/product/rollout_process.md Co-authored-by: Christina Forney <christina@sourcegraph.com> * Update handbook/product/rollout_process.md Co-authored-by: Christina Forney <christina@sourcegraph.com> * Fix typo * Add link to page in handbook Co-authored-by: Pooja Jsin <poojajain@poojas-mbp.attlocal.net> Co-authored-by: Felix Becker <felix.b@outlook.com> Co-authored-by: Christina Forney <christina@sourcegraph.com>

view details

push time in 5 days

PR merged sourcegraph/about

Add Rollout Process

Add based on learnings from Search Homepage + Repo Group Page launch.

+45 -0

2 comments

2 changed files

poojaj-tech

pr closed time in 5 days

pull request commentsourcegraph/sourcegraph

search: document -content and NOT

cc: @kghopson is who is collaborating with us to improve these docs!

stefanhengl

comment created time in 5 days

Pull request review commentsourcegraph/sourcegraph

search: document -content and NOT

 Returns results for files containing matches on the left _and_ right side of the  Returns file content matching either on the left or right side, or both (set union). The number of results reports the number of matches of both strings. +| Operator | Example |+| --- | --- |+| `not`, `NOT` | [`panic not file:main.go lang:go`](https://sourcegraph.com/search?q=panic+not+file:main.go+lang:go&patternType=literal),++`NOT <keyword>:` is equivalent to `-<keyword>:`. `NOT` can only stand before negatable keywords, such as `file`, `content`, `lang`, `repohasfile`, and `repo`. +

ah, I've used Java's Lucene library but I'm not familiar with the syntax. The explanation makes it a bit more clearer! It sounds like it's file content search (pattern-types literal, regex, structural and content:) versus all other navigation based searches (repo:, revision;, revision:). Is this correct? Sidenote: The term pattern is used through the docs but it's definition is a bit unclear to me. This is probably a longer clarification and outside the scope of this PR.

stefanhengl

comment created time in 5 days

push eventsourcegraph/about

Pooja Jsin

commit sha c4835e2efac787c1b55f2e98870f273717df8c3b

Add link to page in handbook

view details

push time in 5 days

Pull request review commentsourcegraph/sourcegraph

search: document -content and NOT

 Click the <img src=../img/brackets.png> toggle to activate structural search. St  Note: It is not possible to perform case-insensitive matching with structural search. -## Keywords (all searches)+## Keywords  -The following keywords can be used on all searches (using [RE2 syntax](https://golang.org/s/re2syntax) any place a regex is accepted):+Unless stated otherwise, the following keywords can be used on all searches (using [RE2 syntax](https://golang.org/s/re2syntax) any place a regex is accepted):

Makes sense to me to add -content to the table with all the other keywords. The description for _content in the table could link to the #Limitations explained below the table.

stefanhengl

comment created time in 5 days

push eventsourcegraph/about

Quinn Keast

commit sha 689435a2cdd4a2654b89af82e9f408dd8916748a

Update link to new version of Dan's example sales video with caption track (#1368)

view details

Dan Adler

commit sha 6a05ef014380bfea72574a079399e4a1e44218b8

Add information security policy acknowledgement to onboarding (#1366)

view details

Dan Adler

commit sha b6349aff0951ba22c0fb969e555b1f37971539e4

Update security page (#1365) * Update security page * email -> e-mail * Modified the language for Dan's PR, and contributed some security specific detail (i.e 24x7x365). * Update security.md Minor copy edits. * Final tweaks * Typo Co-authored-by: Chayim I. Kirshen <chayim@gnupower.net> Co-authored-by: aileenrose <aileenrose@users.noreply.github.com>

view details

Pooja Jsin

commit sha f5d6b662cd92e22351bdd4dddf06008a3a74e31b

Add Rollout Process

view details

Pooja Jsin

commit sha 24cb722ab4c934991dcf08c5e04cb01b0c434720

copy updates

view details

Pooja Jsin

commit sha fae22ff346c47b3a0e815927ce3e8c75a73d04c0

format fix and updates

view details

Pooja Jsin

commit sha ea4bee4934e463591bfd5e942f889c0c075b5b68

typo and updates

view details

Pooja Jsin

commit sha 7fe966add34a5ce69ea494f18ef94363c9008922

update description

view details

Pooja Jain

commit sha 9c5eb9783b5ad06387e0dd4869f17cb3c3bdcf25

Update rollout_process.md

view details

Pooja Jain

commit sha 620ee5b622beadb599e65d1a648b2bd90fdf14e3

Update rollout_process.md

view details

Pooja Jain

commit sha 3ed9355dd8e683d8ea8b30053a7414d058f17840

Update rollout_process.md

view details

Pooja Jain

commit sha af1926f408b79a2db0a3f1f67edd2fccde42743b

Update rollout_process.md

view details

Pooja Jain

commit sha ec081350a317eb040987f152d961da977556f243

Update rollout_process.md

view details

Pooja Jain

commit sha d0a781e4b20c33ae9cedc62f6e46a30b670a98c0

Update rollout_process.md

view details

Pooja Jain

commit sha 43747dace11884b190337dafeebd3ba310f800f1

Update rollout_process.md Add link to document with some details for deploying to internal users. It needs to be updated.

view details

Pooja Jain

commit sha 758585ef5737a7ec8be0e5d91058c2be876435ea

Update handbook/product/rollout_process.md Felix's update on turning on org settings. Co-authored-by: Felix Becker <felix.b@outlook.com>

view details

Pooja Jain

commit sha 13a5e28cddaf81fc98706a381985646a2a9493e1

Update rollout_process.md

view details

Pooja Jain

commit sha c895c6d90d147f459c69150e0b3df0c24800179d

Update handbook/product/rollout_process.md Co-authored-by: Christina Forney <christina@sourcegraph.com>

view details

Pooja Jain

commit sha 316e1a7a512d9c2c98ce488d1ef46a13174daeba

Update handbook/product/rollout_process.md Co-authored-by: Christina Forney <christina@sourcegraph.com>

view details

Pooja Jain

commit sha d62300cff3a26b0a09b51c8d7d7e15dbfc71c0c3

before merge and after merge suggestions Co-authored-by: Christina Forney <christina@sourcegraph.com>

view details

push time in 5 days

push eventsourcegraph/about

AlicjaSuska

commit sha 0e104629fb274063d43c0f2fea6be2db5ae531a8

Added: Alicja to the Team page

view details

Quinn Slack

commit sha 6c65491a3e8ac9dbdfce402a324aad4f91d6b46f

add campaigns new flow doc pages

view details

Beyang Liu

commit sha c5e3a5b917f6b7509276bcf4c02a62ff5e2ed53e

Revert "blog: unpublish posts for now, until cleanup and rerelease" This reverts commit 3d4c35f018cfe4a4a6f27ad63f81b1241322f3ae.

view details

Nick Snyder

commit sha c5e4020b9bcc849b543cde2b53b6cd88d332c887

fix formatting

view details

Eric Fritz

commit sha f6f6507cebb3bab4ec5ce17a999bb9e01ac4a489

Mark Eric Fritz as code intelligence project lead (#1132)

view details

Stephen Gutekanst

commit sha ee90a612f508036ff2992f4472c5faee05d0624f

document how to set up Zoom recordings to go to Slack automatically (#1133) * entry * document how to setup Zoom recordings to go to Slack automatically

view details

LaureenH

commit sha 31d92189b7c5ceb48f8a26c04a2ad44d87052dba

major editorial changes to the guide, addition of RFC 184 terminology to the term usage guide, added headings, rearranged content for easier reference and grouping of like items.

view details

LaureenH

commit sha 0d6b27e8807f6ebe3c4b881fdacada3377559d84

Merge branch 'master' of github.com:sourcegraph/about

view details

Loïc Guychard

commit sha fb4c2071b21c11dc1146e2de69f946f620c91269

Document desired team structure for web (#1108) Document that the web team is a transitional team, designed to be split into mission teams each with a narrower, well-defined scope.

view details

ᴜɴᴋɴᴡᴏɴ

commit sha 12fe6c5f3793f7f7225bf765e59189ba731c83d5

Add 2020-Q2 OKR to reflect work of RFC 142 (#1136)

view details

Gonzalo Peci

commit sha dd1f91f6a4f3365a8333f569591594419a7ccdf4

Add Gonzalo Peci to Team page (#1107) Co-authored-by: Tomás Senart <tomas@sourcegraph.com> Co-authored-by: Thorsten Ball <mrnugget@gmail.com>

view details

LaureenH

commit sha d9ba393fc957044e97d28fb8904e249009acf5fd

fixed spacing, removed TOC

view details

LaureenH

commit sha dee29569fad6ffa258878b7f775e420e0fc3a112

space fix

view details

LaureenH

commit sha d103db741c588490b5a9c57e47fc7af5e5197e1d

render issue

view details

LaureenH

commit sha 1ead630445d7ec44937cfec5a47f7fa6fb71de07

example fixes, capitalization, refrigerated parens

view details

Beyang Liu

commit sha cd5be00d9f8186aef6367ff0b76230a919cce8c0

podcast: do not preload files to avoid polluting stats

view details

adamfrankl2015

commit sha a755a40ddd634c41def3f26bf9499f1cdd080eff

Update index.md

view details

Beyang Liu

commit sha 9545d907d2a3c9b2296151cef84edbd0eda8d61b

fix build

view details

Nick Snyder

commit sha 80ac9ef77b5cae9f0afe281b8f68282b2082c6ee

Innovation time (#1135)

view details

Nick Snyder

commit sha 62e77f86e1910150bb3ea77a5f05a1d439cd082c

How to transfer teams (#1129)

view details

push time in 6 days

Pull request review commentsourcegraph/about

Add Rollout Process

+# Feature rollout process++Features come in many different sizes and shapes, and the process for introducing new functionality ranges with these differences. For large or significantly impactful changes or changes that simply need a bit more time to bake, it is encouraged that the following rollout process is followed.++## Sourcegraph Cloud++Sourcegraph Cloud is continuously deployed with all new updates to master. We maintain a [releasability contract](../engineering/continuous_releasability.md) and require all new features to be released behind a feature flag to ensure that functionality can be turned off if a problem arises.

@attfarhan, curious why think it shouldn't be feature flagged. Is it because it's primarily a UI change that can be fixed easily (instead of reverted?). I can add exceptions we decide on to the releasability contract in a follow-up PR for feedback. Private code CTA was behind a master feature (showRepogroupHomepage) with one non-ideal way to turn it off if a problem arises. To your point, we don't have a section for how incremental changes should be rolled out. Would that be helpful in this doc?

poojaj-tech

comment created time in 6 days

Pull request review commentsourcegraph/sourcegraph

search: document -content and NOT

 The following keywords can be used on all searches (using [RE2 syntax](https://g | **repogroup:group-name** <br> _alias: g_ | Only include results from the named group of repositories (defined by the server admin). Same as using a repo: keyword that matches all of the group's repositories. Use repo: unless you know that the group exists. | | | **file:regexp-pattern** <br> _alias: f_ | Only include results in files whose full path matches the regexp. | [`file:\.js$ httptest`](https://sourcegraph.com/search?q=file:%5C.js%24+httptest) <br> [`file:internal/ httptest`](https://sourcegraph.com/search?q=file:internal/+httptest) | | **-file:regexp-pattern** <br> _alias: -f_ | Exclude results from files whose full path matches the regexp. | [`file:\.js$ -file:test http`](https://sourcegraph.com/search?q=file:%5C.js%24+-file:test+http) |-| **content:"pattern"** | Explicitly override the [search pattern](#search-pattern-syntax). Useful for explicitly delineating the pattern to search for if it clashes with other parts of the query. | [`repo:sourcegraph content:"repo:sourcegraph"`](https://sourcegraph.com/search?q=repo:sourcegraph+content:"repo:sourcegraph"&patternType=literal) |+| **content:"pattern"** | Set the search pattern with a dedicated parameter. Useful when searching literally for a string that may conflict with the [search pattern syntax](#search-pattern-syntax). | [`repo:sourcegraph content:"repo:sourcegraph"`](https://sourcegraph.com/search?q=repo:sourcegraph+content:"repo:sourcegraph"&patternType=literal) |+| **-content:"pattern"** | Exclude results from files whose content matches the pattern. Note: `-content` is currently only supported for literal and regexp patterns on indexed repositories. | [`file:Dockerfile alpine -content:alpine:latest`](https://sourcegraph.com/search?q=file:Dockerfile+alpine+-content:alpine:latest&patternType=literal) |

Thanks for making the content: example clearer. #search-pattern-syntax link doesn't open as expected in rich diff mode, it opens a weirdly formatted page but that might just because this is a PR.

stefanhengl

comment created time in 6 days

Pull request review commentsourcegraph/sourcegraph

search: document -content and NOT

 Returns results for files containing matches on the left _and_ right side of the  Returns file content matching either on the left or right side, or both (set union). The number of results reports the number of matches of both strings. +| Operator | Example |+| --- | --- |+| `not`, `NOT` | [`panic not file:main.go lang:go`](https://sourcegraph.com/search?q=panic+not+file:main.go+lang:go&patternType=literal),++`NOT <keyword>:` is equivalent to `-<keyword>:`. `NOT` can only stand before negatable keywords, such as `file`, `content`, `lang`, `repohasfile`, and `repo`. +

I think NOT is exactly equivalent to -, in that is also doesn't support file, content, lang, repohasfile, and repo? Is it's value in being another convenient syntax, would be helpful to mention this? Can we also stress on the exactness. I checked - operator usages in the table above to confirm.

stefanhengl

comment created time in 6 days

Pull request review commentsourcegraph/sourcegraph

search: document -content and NOT

 Click the <img src=../img/brackets.png> toggle to activate structural search. St  Note: It is not possible to perform case-insensitive matching with structural search. -## Keywords (all searches)+## Keywords  -The following keywords can be used on all searches (using [RE2 syntax](https://golang.org/s/re2syntax) any place a regex is accepted):+Unless stated otherwise, the following keywords can be used on all searches (using [RE2 syntax](https://golang.org/s/re2syntax) any place a regex is accepted):

Unsure why this was added and how it relates to changes introduced in the PRs (NOT, negation, highlighting, etc). What are the exceptions?

stefanhengl

comment created time in 6 days

pull request commentsourcegraph/about

Add Rollout Process

@sqs will merge it tomorrow. Have one more update to make based on the feedback related to releasability.

poojaj-tech

comment created time in 7 days

issue commentsourcegraph/sourcegraph

Enable globbing for Sourcegraph org members

Was just testing IDE/other tools, they don't delineate "exact" versus "other matches" with section headers, so not completely sure if we need to do either. A good UX to test. @stefanhengl pulled data for file: filter usages on Sourcegraph cloud for June and July in this doc. There's a few more expressive regex use cases, will separate them out. Perhaps the new and/or syntax will help with expressing these.

rvantonder

comment created time in 8 days

issue commentsourcegraph/sourcegraph

Hovering on a specific class sometimes takes a while to load all the references

thanks for the additional information @ekss1121!

poojaj-tech

comment created time in 8 days

issue closedsourcegraph/sourcegraph

Feedback for Custom Search Pages and new Homepage Design

High priority bugs

  • [x] 404 bug: #11961
  • [x] Dark theme Kubernetes icon fix
    • Issue: #11956
    • PR: #12038
  • [x] Remove fancy quotes in message
  • [x] Lots of content fixes! #11939
  • [x] Fix responsiveness for sections below list of repository groups
    • Issue: #12040
    • PR: #12080
    • Context:
  • [x] Indexing repos #11962
  • [x] Border-radius on repogroup page #11955
  • [x] Fix contrast in dark theme, headings, links
  • [x] Repogroup page copy feedback: #12057
    • PR: #12084
  • [x] Repogroup page search bar should be populated with the repogroup #12083
  • [x] RepogroupPage should wrap responsively
  • [x] Distinguish code and non-code text by font
  • Issue: #12057(bullet 2)
  • PR: https://github.com/sourcegraph/sourcegraph/pull/12078/

Original PR feedback

Feature Suggestions

  1. count:xxx or lang:xxx is repeated often, too busy visually?
  2. Copy-paste ability for search syntax on page
    • feedback: "might be nice to have this text be accompanied by a copy button and/or have it prefilled in the search box :mag:" image (3)
  3. Hide/Collapse suggestions on the /search homepage if it feels busy

closed time in 8 days

poojaj-tech

issue commentsourcegraph/sourcegraph

Feedback for Custom Search Pages and new Homepage Design

yep, closing. @attfarhan please re-open if you think otherwise.

poojaj-tech

comment created time in 8 days

issue commentsourcegraph/sourcegraph

Enable globbing for Sourcegraph org members

Since there can only be only one exact match, knowing we don't rank results in frontend today, would it still be possible just in this case to return the following: search box: file:foo.go

Exact match ——— All other matches ——— ——— ....

Return both results instead of a banner with syntax suggestions - the exact match first if one exists for foo.go (globbing file:foo.go), then the list of all other matches (globbing file:foo.go). I might not even mention the syntax difference for each. If this is such a common search, we would want to offer them a more convenient syntax that gets them all the results by typing just foo.go. Thoughts?

rvantonder

comment created time in 8 days

issue openedsourcegraph/about

Learnings for release process and for launching on Sourcegraph Cloud

Stephen wrote a great doc here about pushing to Sourcegraph cloud. https://about.sourcegraph.com/handbook/engineering/distribution/update_sourcegraph_website

A few things to document about the process on the product side:

  1. Testing for internal users though internal org settings (could belong in Stephen's doc)
  2. QA and design checklist to run through (eg. light theme vs dark theme)
  3. Getting approval from design, PR reviewers.

created time in 9 days

issue commentsourcegraph/sourcegraph

Ability to select code from search results page

Click target area can be increased significantly by making the line of code implicitly clickable (like Opengrok does), this may make it feel like less big of a change.

ijsnow

comment created time in 9 days

issue commentsourcegraph/sourcegraph

Enable globbing for Sourcegraph org members

thanks! this is really helpful context.

rvantonder

comment created time in 13 days

issue closedsourcegraph/sourcegraph

Result link for revisions with globbing opens to 404

Results look off and clicking on link from results page opens to 404 repo:github.com/sourcegraph/sourcegraph@3.1*

closed time in 13 days

poojaj-tech

issue commentsourcegraph/sourcegraph

Result link for revisions with globbing opens to 404

Got it — will close this in favor of #10571 then. (references these docs for revision syntax)

poojaj-tech

comment created time in 13 days

issue openedsourcegraph/sourcegraph

Filter "content:" docs aren't clear

From docs content:“pattern” | Explicitly override the search pattern. Useful for explicitly delineating the pattern to search for if it clashes with other parts of the query.

What's confusing

  • Parts of the query mean avoiding conflicts with existing syntax keywords field names, :, etc
  • Use case isn't immediately obvious without examples

created time in 13 days

issue commentsourcegraph/sourcegraph

Enable globbing for Sourcegraph org members

Linking an error @stefanhengl and I ran into: #12575

rvantonder

comment created time in 13 days

issue openedsourcegraph/sourcegraph

Sometimes hovering on a specific class takes a while to load all the references

Sourcegraph.com: Customer feedback: https://app.hubspot.com/contacts/2762526/contact/24612301/

Hover my mouse on a specific class, sometimes it will take a while to load all the references.

created time in 13 days

issue openedsourcegraph/sourcegraph

View evolution of line of code: prior git blames, code blocks that are similar across repositories

Feature request description

Customer feedback from NPS

Feature request: more context on code evolution -- often when reviewing or reading code, I want to see how a particular line changed over time.

Is your feature request related to a problem? If so, please describe.

Thread

would showing not just the most recent Git blame but all prior blames (author + commit message + date) be helpful?

Yeah, seeing prior blames would be great with the ability to jump back to them quickly.

Another far out idea: seeing other code blocks that are similar or the same across repositories if they exist. I see a lot of code that is more or less copied from one place to another when reviewing and it would be fantastic to see where the work originated or was derived from.

Additional context

Company: https://app.hubspot.com/contacts/2762526/company/814799425 Customer: https://app.hubspot.com/contacts/2762526/contact/16031951/

created time in 15 days

issue openedsourcegraph/sourcegraph

Banner messaging is confusing, for example: "Unindexed repositories with structural search"

Audit all banner messaging where confusing See if we can link search syntax examples instead

Expected behavior:

Understand that they can reach out to admins to this is on for repositories

Actual behavior:

Thought search was broken for them

109431530_315982736225866_314350281374927002_n

created time in 16 days

Pull request review commentsourcegraph/about

Add items to the Product onboarding

 Welcome to Sourcegraph! As a member of the product team, it is your job to be th ## Product team member checklist  - Get to know our team and learn about Sourcegraph (company and product)+  - Schedule 30-min 1:1s with your manager for the first three days at Sourcegraph to keep up with your onboarding and ask all the questions you might have

I'd suggest something less specific: "Schedule 1:1s with your manager for your first week to keep up with your onboarding..." My first 3 1:1s were MWF, I think it might look a bit different for different people.

AlicjaSuska

comment created time in 17 days

Pull request review commentsourcegraph/about

Add items to the Product onboarding

 Welcome to Sourcegraph! As a member of the product team, it is your job to be th ## Product team member checklist  - Get to know our team and learn about Sourcegraph (company and product)+  - Schedule 30-min 1:1s with your manager for the first three days at Sourcegraph to keep up with your onboarding and ask all the questions you might have - Finish [general onboarding tasks](../../people-ops/onboarding/index.md#for-all-new-teammates)   - Set up your email filters, especially for GitHub and feedback - Get to know the product   - Complete of the [Engineering onboarding tasks](../../engineering/onboarding/index.md). Almost all of these are relevant to you.     - You will need to run Sourcegraph locally to test/validate work that engineering is doing, to provide early/often feedback.   - Review [product resources](../index.md#resources)   - [Products](https://about.sourcegraph.com/product)+  - Watch this [demo video](https://drive.google.com/file/d/1idbCnce5MIvtAV0GOOwgB68zQJB2WmZ9/view)

Perhaps add "Product Demo from Customer Engineering" for more context.

AlicjaSuska

comment created time in 17 days

Pull request review commentsourcegraph/about

Add items to the Product onboarding

 Welcome to Sourcegraph! As a member of the product team, it is your job to be th ## Product team member checklist  - Get to know our team and learn about Sourcegraph (company and product)+  - Schedule 30-min 1:1s with your manager for the first three days at Sourcegraph to keep up with your onboarding and ask all the questions you might have - Finish [general onboarding tasks](../../people-ops/onboarding/index.md#for-all-new-teammates)   - Set up your email filters, especially for GitHub and feedback - Get to know the product   - Complete of the [Engineering onboarding tasks](../../engineering/onboarding/index.md). Almost all of these are relevant to you.     - You will need to run Sourcegraph locally to test/validate work that engineering is doing, to provide early/often feedback.   - Review [product resources](../index.md#resources)   - [Products](https://about.sourcegraph.com/product)+  - Watch this [demo video](https://drive.google.com/file/d/1idbCnce5MIvtAV0GOOwgB68zQJB2WmZ9/view)+  - Read about [search queries](https://docs.sourcegraph.com/user/search) and perform your first searches+  - Answer all the questions from the [Sales Onboarding Quiz](https://about.sourcegraph.com/handbook/sales/onboarding/quiz) and discuss the answers with your manager

Nice, didn't know we had this :)

AlicjaSuska

comment created time in 17 days

issue commentsourcegraph/sourcegraph

Branch names not showing up on search results

Thanks for filing @dadlerj. Revisions can specified as a branch, commit hash or a tag. Git refs can vary based on the configuration set up. This will be an interesting consideration to think through. cc: @christinaforney

dadlerj

comment created time in 20 days

pull request commentsourcegraph/sourcegraph

Add link to saved searches page in email

🎉

dadlerj

comment created time in 20 days

issue openedsourcegraph/sourcegraph

Browser extension not working with Codecov Token

Customer feedback through Extension Uninstall Feedback form

Doesn't work with codecov token.

Company: https://app.hubspot.com/contacts/2762526/company/4188342284 Customer: https://app.hubspot.com/contacts/2762526/contact/24406751/

created time in 20 days

Pull request review commentsourcegraph/sourcegraph

Log click events on search homepage and repogroup page

 export const RepogroupPage: React.FunctionComponent<RepogroupPageProps> = (props     ) } +const RepoLinkClicked = (): void => eventLogger.log('RepogroupPageRepoLinkClicked')

+1, would be great if we could pass through the link clicked on: RepogroupPageRepoLinkClicked -> Repo name or search url ExampleSearchClicked -> search url ExampleLanguageSearchClicked -> Language or search url

attfarhan

comment created time in 21 days

pull request commentsourcegraph/sourcegraph

Add link to saved searches page in email

@dadlerj were you still planning on landing this?

dadlerj

comment created time in 22 days

issue openedsourcegraph/sourcegraph

NPS feedback pop up doesn't interrupt workflow

Feature request

  • allowing users to opt out in the future
  • moving from a popup to an inline display
  • focus on learning from users

Is your feature request related to a problem? If so, please describe.

Customer feedback

Never popup. Certainly not for ratings. I come to source graph for work, not to give feedback.

Screen Shot 2020-07-21 at 10 27 47 AM

https://app.hubspot.com/contacts/2762526/company/464956351/

created time in 22 days

issue openedsourcegraph/sourcegraph

Log 3 click events for new features on Search Homepage and Repo Page

Feature request description

Add logging to measure usefulness of new features added to Search Home Page and Repo Group Page

  1. Homepage (Done) Repogroups section: click + repogroup title + search link (New) Example Searches list section: Item click + search link (New) Search a language list section: Item click + search link
  2. Repogroup (Done) Search Examples -> Search button: click + search link (New) Repositories List: click + repo link

Once we add this data, we can also segment users by new feature usage for other analytics like retention and # of searches. See Search Homepage Data (1. Usage) for more details.

created time in 23 days

issue commentsourcegraph/sourcegraph

Unindexed repositories for Structural Search

+1 also curious why an admin would choose to not index. If we want to encourage all repos to be indexed, we could upsell that in our messaging here (eg. submit request to admin to index).

poojaj-tech

comment created time in 23 days

issue commentsourcegraph/sourcegraph

Unindexed repositories for Structural Search

Update: Searching in their Go monorepo showed the same message as well.

poojaj-tech

comment created time in 23 days

issue openedsourcegraph/sourcegraph

Unindexed repositories for Structural Search

Configuration: Multiple mono repos

Steps to reproduce:

For any structural search he tried (not language specific), he got this message: Uploading 109431530_315982736225866_314350281374927002_n.png…

Expected behavior:

Should all repos be indexed on an enterprise instance?

https://app.hubspot.com/contacts/2762526/company/732945930/

created time in 23 days

push eventsourcegraph/sourcegraph

Pooja Jain

commit sha 22dfa7cbd08d25676ad184b001d9e21d518fb50c

Update slow lang:python example with repogroup:python example (#12343) Co-authored-by: Pooja Jsin <poojajain@poojas-mbp.attlocal.net>

view details

push time in 23 days

delete branch sourcegraph/sourcegraph

delete branch : updateSlowEg

delete time in 23 days

PR merged sourcegraph/sourcegraph

Reviewers
Update slow lang:python example with repogroup:python example

The example lang:python from \B\.\w+ import \w+ consistently takes > 10 seconds. Replace it with a much quicker example.

+3 -3

0 comment

1 changed file

poojaj-tech

pr closed time in 23 days

PR opened sourcegraph/sourcegraph

Update slow lang:python example with repogroup:python example

The example lang:python from \B\.\w+ import \w+ consistently takes > 10 seconds. Replace it with a much quicker example.

+3 -3

0 comment

1 changed file

pr created time in 23 days

create barnchsourcegraph/sourcegraph

branch : updateSlowEg

created branch time in 23 days

issue commentsourcegraph/sourcegraph

Border-radius wrong in repogroup page search query input groups

Screen Shot 2020-07-19 at 9 36 04 PM This was on the repogroup page. Verified that it doesn't repo anymore.

felixfbecker

comment created time in 24 days

issue closedsourcegraph/sourcegraph

Border-radius wrong in repogroup page search query input groups

Screen Shot 2020-07-06 at 12 57 40

These should use input groups

cc @poojaj-tech @christinaforney

closed time in 24 days

felixfbecker

issue commentsourcegraph/sourcegraph

Index repos for search page repogroups on sourcegraph.com

These repos weren't indexed because they are from repogroups: "cncf", "experimental-deeplearning-ml" and "experimental-reacthooks-short" which don't have repo pages on the homepage yet. Now that they're indexed, this unblocks us from adding new pages for them 🎉

rvantonder

comment created time in 24 days

Pull request review commentsourcegraph/about

Formatting and adding final review section

 While asynchronous communication is a core attribute of remote work, key moments  ## Process segments -- Ideation-  - This is generally represented by a kickoff meeting with interested parties. Kickoff meetings should generally include representatives of the following parties:-      - The product manager-      - Developers working on the project-      - Designers-      - Sales, ops and customer engineering staff who have insight into how this affects users-      - Customers if available-      - Stakeholders as required-  - Tools-      - We are experimenting with [miro.com](https://miro.com/) as an ideation tool-      - Figma.com can be used to generate mood boards+### Ideation++- This is generally represented by a kickoff meeting with interested parties. Kickoff meetings should generally include representatives of the following parties:+    - The product manager+    - Developers working on the project+    - Designers+    - Sales, ops and customer engineering staff who have insight into how this affects users+    - Customers if available+    - Stakeholders as required+- Tools+    - We are experimenting with [miro.com](https://miro.com/) as an ideation tool+    - Figma.com can be used to generate mood boards - Research-  - Interview internal users-      - As our users are developers, Sourcegraph developers make great interview subjects. However, we need to acknowledge that they do have biases about features and this research must be augmented-  - Interview external users-      - Where the project requires and time permits, conduct research with these users to inform your designs-  - Customer requests and support tickets-      - Our users are passionate and provide excellent feedback. Each project should utilize our collections of this feedback in [Productboard](https://sourcegraph.productboard.com/)-  - Analogous designs-  - Competitive designs-  - Usability tests-    - When updating existing product features, first conduct usability tests to inform redesign decisions-  - Process-      - A GitHub issue should be created to track the work-      - Research is conducted according to requirements-      - Findings publishing and review-        - Findings should be detailed in a Google doc and announced in the corresponding team channel or #product on Slack-        - Findings should contain a clear summary, links to resources and supporting data-        - Conduct a synchronous review meeting with key stakeholders based on the size of project or importance of findings-      - Schedule and conduct a presentation meeting with stakeholders where necessary-  - Tools-      - Google Docs-      - Google Forms for polls-      - UserTesting.com-      - Maze.design-- Wireframes-  - Wireframes should utilize the Sourcegraph Figma component system-  - Wireframes should generally utilize realistic data and text for each element. In cases where many elements are required, ‘lorem epsum’ placeholder text will suffice if the initial or prominent elements are real data.-  - Process-      - A GitHub issue should be created to track the work-          - Label the issue with the design and/or ux label-          - TBD - how do we replicate pull request reviewers?-      - Wireframes are produced in Figma-      - Wireframes are announced in Slack and linked in the GitHub issue well before they are complete for review-      - Wireframes are hallway tested with internal users and product managers-      - Schedule and conduct a presentation meeting-      - Stakeholders will approve the GitHub issue indicating the designs are ready for the next phase-  - Checklist-      - Ensure designs meet Jacob Nielsen's [ten usability heuristics](https://www.nngroup.com/articles/ten-usability-heuristics/)+- Interview internal users+    - As our users are developers, Sourcegraph developers make great interview subjects. However, we need to acknowledge that they do have biases about features and this research must be augmented+- Interview external users+    - Where the project requires and time permits, conduct research with these users to inform your designs+- Customer requests and support tickets+    - Our users are passionate and provide excellent feedback. Each project should utilize our collections of this feedback in [Productboard](https://sourcegraph.productboard.com/)+- Analogous designs+- Competitive designs+- Usability tests+  - When updating existing product features, first conduct usability tests to inform redesign decisions+- Process+    - A GitHub issue should be created to track the work+    - Research is conducted according to requirements+    - Findings publishing and review+      - Findings should be detailed in a Google doc and announced in the corresponding team channel or #product on Slack+      - Findings should contain a clear summary, links to resources and supporting data+      - Conduct a synchronous review meeting with key stakeholders based on the size of project or importance of findings+    - Schedule and conduct a presentation meeting with stakeholders where necessary+- Tools+    - Google Docs+    - Google Forms for polls+    - UserTesting.com+    - Maze.design++### Wireframes++- Wireframes should utilize the Sourcegraph Figma component system+- Wireframes should generally utilize realistic data and text for each element. In cases where many elements are required, ‘lorem epsum’ placeholder text will suffice if the initial or prominent elements are real data.+- Process+    - A GitHub issue should be created to track the work+        - Label the issue with the design and/or ux label+        - TBD - how do we replicate pull request reviewers?+    - Wireframes are produced in Figma+    - Wireframes are announced in Slack and linked in the GitHub issue well before they are complete for review+    - Wireframes are hallway tested with internal users and product managers+    - Schedule and conduct a presentation meeting+    - Stakeholders will approve the GitHub issue indicating the designs are ready for the next phase+- Checklist+    - Ensure designs meet Jacob Nielsen's [ten usability heuristics](https://www.nngroup.com/articles/ten-usability-heuristics/)+    - Has the change’s effect on the CLI been considered?+        - Does the language in the UI map to the language in the CLI?+    - Enterprise / Cloud+    - Signed in vs. anonymous user+    - User permissions+    - Interactive mode / plain text mode+    - TBD - add a standard UX checklist+- Tools+    - Figma++### Testing++- Process+    - A GitHub issue should be created to track the work+    - Testing is conducted according to requirements+    - Publish testing results summary to google drive+    - Announce results in slack+    - Create a GitHub issue to address items in the test results+- Tools+    - Maze.design+    - UserTesting.org++### Visual design++- Visual design should utilize the Sourcegraph’s Figma based component system+- Dark compositions will be created for each major design+- If new components are required, components will be created in the file itself, not the component system+- Improvements to the Sourcegraph user experience should consider the following in every change:       - Has the change’s effect on the CLI been considered?-          - Does the language in the UI map to the language in the CLI?+      - Does the language in the UI map to the language in the CLI?+      - Does the documentation reflect the change?+      - Light mode / Dark mode       - Enterprise / Cloud       - Signed in vs. anonymous user       - User permissions       - Interactive mode / plain text mode-      - TBD - add a standard UX checklist-  - Tools-      - Figma-- Testing-  - Process-      - A GitHub issue should be created to track the work-      - Testing is conducted according to requirements-      - Publish testing results summary to google drive-      - Announce results in slack-      - Create a GitHub issue to address items in the test results-  - Tools-      - Maze.design-      - UserTesting.org-- Visual design-  - Visual design should utilize the Sourcegraph’s Figma based component system-  - Dark compositions will be created for each major design-  - If new components are required, components will be created in the file itself, not the component system-  - Improvements to the Sourcegraph user experience should consider the following in every change:-        - Has the change’s effect on the CLI been considered?-        - Does the language in the UI map to the language in the CLI?-        - Does the documentation reflect the change?-        - Light mode / Dark mode-        - Enterprise / Cloud-        - Signed in vs. anonymous user-        - User permissions-        - Interactive mode / plain text mode-  - Process-      - A GitHub issue should be created to track the work-      - Designs are produced in Figma-      - Designs will be announced in Slack and linked in the GitHub issue well before they are complete for review-      - Ensure designs meet the visual design checklist:-        - Ensure spacing is consistent and matches the 8pt grid system-        - Ensure text, colors and other sytles match existing styles, if possible. -          - Introduce new text styles only if really necessary.-          - If adding new styles, ensure that they meet the accessibility standards and add them to the design system -        - Review designs for accessability:-          - Color blind check-          - Contrast check should meet AA standard for small text-      - Schedule and conduct a design presentation meeting if the size of the project requires-      - Receive signoff from stakeholders-      - If components were created in the visual design process, when the designs are signed off on, those components will be moved to the Sourcegraph component system-      - Prepare redlines or an interaction delivery writeup for the engineers. Consider the following:-          - Margin and padding-          - Animation-          - Links and hover states-      - Describe expected behavior of layout for tablet and moble screensizes-        - Due to the low number of mobile and table visitors (< 3%) design comps for these sizes are generally not required -      - Schedule a meeting with engineers to discuss the interaction-  - Tools-      - Figma-- Metrics collection:-  - In the RFC process, the definition of success will include items which can be measured and evaluated-  - Involve the business operations team in determining what metrics to track and how they are tracked-  - Work with engineers to add the required eventLog tracking-  - Tools-      - Looker-      - Google analytics-- Refinement-  - Designers will review metrics and determine if their designs are meeting objectives set for them.-  - If areas for improvement are found, tickets will be created to document the change required to improve the issue+- Process+    - A GitHub issue should be created to track the work+    - Designs are produced in Figma+    - Designs will be announced in Slack and linked in the GitHub issue well before they are complete for review+    - Ensure designs meet the visual design checklist:+      - Ensure spacing is consistent and matches the 8pt grid system+      - Ensure text, colors and other sytles match existing styles, if possible. +        - Introduce new text styles only if really necessary.+        - If adding new styles, ensure that they meet the accessibility standards and add them to the design system +      - Review designs for accessability:+        - Color blind check+        - Contrast check should meet AA standard for small text+    - Schedule and conduct a design presentation meeting if the size of the project requires+    - Receive signoff from stakeholders+    - If components were created in the visual design process, when the designs are signed off on, those components will be moved to the Sourcegraph component system+    - Prepare redlines or an interaction delivery writeup for the engineers. Consider the following:+        - Margin and padding+        - Animation+        - Links and hover states+    - Describe expected behavior of layout for tablet and moble screensizes+      - Due to the low number of mobile and table visitors (< 3%) design comps for these sizes are generally not required +    - Schedule a meeting with engineers to discuss the interaction+- Tools+    - Figma++### Metrics collection++- In the RFC process, the definition of success will include items which can be measured and evaluated+- Involve the business operations team in determining what metrics to track and how they are tracked+- Work with engineers to add the required eventLog tracking+- Tools+    - Looker+    - Google analytics

Metrics impact many stages of product development. This should probably live under product/analytics once fleshed out a bit more.

christinaforney

comment created time in 24 days

push eventsourcegraph/about

Pooja Jain

commit sha 915792ceb13cf0d0c74e47fb14e6cacab9dd522a

Fix typo

view details

push time in 24 days

push eventsourcegraph/about

Pooja Jain

commit sha 76a7bdba3c638d43d5a37df27dd45c292f7b4d58

Update handbook/product/rollout_process.md Co-authored-by: Christina Forney <christina@sourcegraph.com>

view details

push time in 24 days

push eventsourcegraph/about

Pooja Jain

commit sha 85b6ba389b95819e662f7a0db14d567ae36e0808

Update handbook/product/rollout_process.md Co-authored-by: Christina Forney <christina@sourcegraph.com>

view details

push time in 24 days

push eventsourcegraph/about

Pooja Jain

commit sha 74cf0557ad5d54a8f620dc167298ed2df7dca65a

Launch doc Co-authored-by: Christina Forney <christina@sourcegraph.com>

view details

push time in 24 days

push eventsourcegraph/about

Pooja Jain

commit sha 8f8ac1998adfb11c60cf00bd2934eb99f0d68dab

Post-launch suggestions Co-authored-by: Christina Forney <christina@sourcegraph.com>

view details

push time in 24 days

push eventsourcegraph/about

Pooja Jain

commit sha 7b1558d0e12659a250769708fa421fcaccf97cb6

before merge and after merge suggestions Co-authored-by: Christina Forney <christina@sourcegraph.com>

view details

push time in 24 days

push eventsourcegraph/about

Pooja Jain

commit sha 7784ae29d73a501a74288072a0062fb718cf3a09

Update handbook/product/rollout_process.md Co-authored-by: Christina Forney <christina@sourcegraph.com>

view details

push time in 24 days

push eventsourcegraph/about

Pooja Jain

commit sha a8b04ac612f7ac6ca0c711f8001176a02caef2f4

Update handbook/product/rollout_process.md Co-authored-by: Christina Forney <christina@sourcegraph.com>

view details

push time in 24 days

issue commentsourcegraph/sourcegraph

Bazel support roadmap

@iangudger, I’m curious if you are using Bazel in open source or would this be helpful in your work environment for Go?

sqs

comment created time in a month

issue commentsourcegraph/sourcegraph

Index repos for search page repogroups on sourcegraph.com

Closing as @attfarhan indexed the remaining repos for android, kubernetes, react-hooks!

rvantonder

comment created time in a month

push eventpoojaj-tech/sourcegraph-codecov

Pooja Jain

commit sha e42c8df329013b03c978a8a751898032ac877f60

Update Sourcegraph Codecov extension example with a file that has code coverage 1. This example feels reliable/stable as it is pinned to a file in a commit. 2. It sometimes takes a few seconds for code coverage to load.

view details

Pooja Jain

commit sha 05aa7441c73d58507f9c07afc799393666904ad0

Merge pull request #1 from poojaj-tech/poojaj-tech-patch-1 Update Sourcegraph Codecov extension example with a file that has cod…

view details

push time in a month

PR merged poojaj-tech/sourcegraph-codecov

Update Sourcegraph Codecov extension example with a file that has cod…
  1. This example feels reliable/stable as it is pinned to a file in a commit.
  2. It sometimes takes a few seconds for code coverage to load.
+1 -1

0 comment

1 changed file

poojaj-tech

pr closed time in a month

PR opened poojaj-tech/sourcegraph-codecov

Update Sourcegraph Codecov extension example with a file that has cod…

…e coverage

  1. This example feels reliable/stable as it is pinned to a file in a commit.
  2. It sometimes takes a few seconds for code coverage to load.
+1 -1

0 comment

1 changed file

pr created time in a month

create barnchpoojaj-tech/sourcegraph-codecov

branch : poojaj-tech-patch-1

created branch time in a month

issue commentsourcegraph/sourcegraph

Firefox extension: Customer unable to authenticate to Sourcegraph private instance

@alexmgr glad to hear you were able to login, thank you for sharing your steps to debug this in detail here and for letting us know! This will help us in tracking down this problem. Linking a possible related open issue here as well.

poojaj-tech

comment created time in a month

push eventsourcegraph/about

Pooja Jain

commit sha 0c5d2a8c9cf9742428278e8552b23cc4861a852c

Update rollout_process.md

view details

push time in a month

push eventsourcegraph/about

Pooja Jain

commit sha e9e55426c2a77631a54cebfd961af324da80b410

Update handbook/product/rollout_process.md Felix's update on turning on org settings. Co-authored-by: Felix Becker <felix.b@outlook.com>

view details

push time in a month

Pull request review commentsourcegraph/about

Add Rollout Process

+# Rollout Process++The rollout process consists of *Pre-Launch* phase and *Deployment* phase. We can push changes to Sourcegraph.com when we+want as we own the deployment process. For enterprise instances of Sourcegraph.com, we push a new release monthly and our+clients decide to upgrade to the latest release when they want.++## Sourcegraph.com++### Pre-Launch+**User Testing** +- Hallway test with internal users.+- Open the feature to internal users by turning it on for the Sourcegraph organization. Make sure it's opened with enough+time left before planned launch date to receive and address all the feedback received.  Follow this [document](https://about.sourcegraph.com/handbook/engineering/distribution/update_sourcegraph_website) to enable your feature in site settings and turn it on only for internal users in the Sourcegraph organization. TODO: Update doc linked above to add a bit more content for new teammates

Added a test search scope to test this quickly myself too. Thanks for fixing this!

poojaj-tech

comment created time in a month

Pull request review commentsourcegraph/about

Add Rollout Process

+# Rollout Process++The rollout process consists of *Pre-Launch* phase and *Deployment* phase. We can push changes to Sourcegraph.com when we+want as we own the deployment process. For enterprise instances of Sourcegraph.com, we push a new release monthly and our+clients decide to upgrade to the latest release when they want.++## Sourcegraph.com++### Pre-Launch+**User Testing** +- Hallway test with internal users.+- Open the feature to internal users by turning it on for the Sourcegraph organization. Make sure it's opened with enough+time left before planned launch date to receive and address all the feedback received.  Follow this [document](https://about.sourcegraph.com/handbook/engineering/distribution/update_sourcegraph_website) to enable your feature in site settings and turn it on only for internal users in the Sourcegraph organization. TODO: Update doc linked above to add a bit more content for new teammates++**Design** +(skip if it doesn't apply)+- Test the feature for both themes, Light and Dark. Check for icon consistency across themes.+* Test on small, medium, large and extra-large screen sizes.+  * Small screens are important to consider for a good experience when the window is resized or in side-by-side mode.+* Code examples in design+  * Font should be "code font" or monospace.+  * Easy to copy and paste (no fancy quotes).

Agree, I'd like to link to a style guide here eventually. I see this style guide living in /design.

poojaj-tech

comment created time in a month

fork poojaj-tech/sourcegraph-codecov

See code coverage information from Codecov on GitHub, Sourcegraph, and other tools.

fork in a month

issue openedsourcegraph/sourcegraph

Firefox extension: Customer unable to authenticate to Sourcegraph private instance

Browser: Firefox 78.0.2 They have tested with all other addons disabled.

https://app.hubspot.com/contacts/2762526/company/1749029033/

created time in a month

issue openedsourcegraph/sourcegraph

Citrix customer is unable to authenticate to Sourcegraph private instance

They have tested with all other addons disabled.

https://app.hubspot.com/contacts/2762526/contact/24199551/

created time in a month

Pull request review commentsourcegraph/about

Add Rollout Process

+# Rollout Process++The rollout process consists of *Pre-Launch* phase and *Deployment* phase. We can push changes to Sourcegraph.com when we+want as we own the deployment process. For enterprise instances of Sourcegraph.com, we push a new release monthly and our+clients decode to upgrade to the latest release when they want.++### Sourcegraph.com++#### Pre-Launch+1. User testing+- Hallway test with internal users.+- Open the feature to internal users by turning it on for the Sourcegraph organization. Make sure it's opened with enough

I linked @slimsag's doc which includes information on how to update both the site settings and global settings. It needs to be updated to add a bit more context for new teammates.

poojaj-tech

comment created time in a month

Pull request review commentsourcegraph/about

Add Rollout Process

+# Rollout Process++The rollout process consists of *Pre-Launch* phase and *Deployment* phase. We can push changes to Sourcegraph.com when we+want as we own the deployment process. For enterprise instances of Sourcegraph.com, we push a new release monthly and our+clients decide to upgrade to the latest release when they want.++### Sourcegraph.com++#### Pre-Launch+1. User Testing +- Hallway test with internal users.+- Open the feature to internal users by turning it on for the Sourcegraph organization. Make sure it's opened with enough+time left before planned launch date to receive and address all the feedback received. +2. Design +- Test the feature for both themes, Light and Dark. Check for icon consistency across themes.+* Test on small, medium, large and extra-large screen sizes.+  * Small screens are important to consider for a good experience when the window is resized or in side-by-side mode.+* Code examples in design+  * Font should be "code font" or monospace.+  * Easy to copy and paste (no fancy quotes).

I don't know what rolling out backend changes would look like. For now, followed your above comment and added a line to skip if not applicable.

poojaj-tech

comment created time in a month

push eventsourcegraph/about

Pooja Jain

commit sha d89d3cb10924255c9fbb7ccf8e9d50ed8c3a95cb

Update rollout_process.md Add link to document with some details for deploying to internal users. It needs to be updated.

view details

push time in a month

push eventsourcegraph/about

Pooja Jain

commit sha afdc9d7f79ab619c3b16b75e81600985aced7b3c

Update rollout_process.md

view details

push time in a month

issue closedsourcegraph/sourcegraph

Build initial set of MVP repository group pages

Build the content for repository group pages from #11539 using the template from #11537

closed time in a month

christinaforney

issue commentsourcegraph/sourcegraph

Build initial set of MVP repository group pages

Closing with pages live on search homepage now.

christinaforney

comment created time in a month

issue openedsourcegraph/sourcegraph

Show when code coverage is not supported through Codecov's Sourcegraph extension.

Show when code coverage isn't available for the Codecov extension enabled for use inside of Sourcegraph. Today if code coverage is available, we show coverage: N% and we show nothing if it isn't available. Add a UI affordance for the user to check if coverage is available or not. Question: Can this happen for other extensions too? This can be an icon to show that just Codecov coverage is not available (even though the extension is enabled) or an icon that opens a list of extensions enabled but not supported for a file. For example disable-512 Would open to a list with "Extension Name: Error Message"

  1. Codecov: Not supported for this file
  2. Other extension: Not available right now

Is your feature request related to a problem? If so, please describe.

We fail silently when there is no coverage report today. There's no visual cue to know that the integration I've enabled for Codecov is not supported for the file I'm viewing. See screenshot. image (1)

Describe alternatives you've considered.

I checked many files until Dan shared one which had code coverage. I went to the Codecov integration page to see if I hadn't enabled it correctly or something was wrong with my configuration.

created time in a month

pull request commentsourcegraph/sourcegraph

search: register repogroup routes in frontend

Yes, @keegancsmith thank you for pushing up this fix! @attfarhan now that you are back could you help land this PR. I haven't heard from Keegan and we should get this fix out soon.

keegancsmith

comment created time in a month

issue commentsourcegraph/sourcegraph

Color and Font related manual overrides and inconsistencies

closing as included in #11922 as Original PR feedback, will be fixed as part of longer term technical solution.

poojaj-tech

comment created time in a month

push eventsourcegraph/about

Pooja Jain

commit sha dad06bafc40dfac7a387a02fd4503ef3c3cbff62

Update rollout_process.md

view details

push time in a month

more