profile
viewpoint

startedrustwasm/team

started time in a day

delete branch piscisaureus/deno

delete branch : derive_feature

delete time in 2 days

PR merged denoland/deno

build: enable 'derive' feature of 'serde' crate

For #2799

+13 -1

0 comment

3 changed files

piscisaureus

pr closed time in 2 days

push eventdenoland/deno

Bert Belder

commit sha 47c216317f8eb5bf277663a732a79f6b07ba79ef

build: enable 'derive' feature of 'serde' crate

view details

push time in 2 days

push eventpiscisaureus/deno

Bert Belder

commit sha 7d03a63dedac6c0509655248107dcfb8b3142442

Revert "Fix permissions for dial and listen (#2373)" This reverts commit 7219787894f13b1920b3b6b49203cdcb8f672c00.

view details

champ

commit sha 1386b6ead586da15d0285941f2d980acc1d75eee

Fix examples in manual (#2396)

view details

Ryan Dahl

commit sha 2952fb5405eabbb9e603e90fe2e972e9bddfcadd

Rename --allow-high-precision to --allow-hrtime (#2398)

view details

Ryan Dahl

commit sha 583a646be7764a686b757418f31ab4d8e0e6a17a

Fix concurrent accepts (#2403)

view details

Ryan Dahl

commit sha f92af3576afe9567d829aed3cf78836cb587c944

Improve CLI help (#2388)

view details

Bartek Iwańczuk

commit sha 1105982586d9554a5e7bf54fd4dc25c8724cd130

re-fix permissions for dial and listen (#2400) Closes #2397

view details

Steven

commit sha ccdab617081b8f12e6c4a498ef4b387f8c5cc772

Remove prefix $ and > from manual (#2404)

view details

ztplz

commit sha 86684799c4b98a61c5845a7ef1d2e743b0e4851e

typo (#2366)

view details

Andy Hayden

commit sha 62c377fc19ac49138da5c3b3ee3b9d3854a44474

Add brew install deno to manual (#2407)

view details

Bartek Iwańczuk

commit sha 73ac5f89f022a3965c68705cef284386a9365419

add module and line no for Rust logger (#2409)

view details

Adam Conrad

commit sha 9fd4096235a308a0d405888ef808d6c665bef355

add EventTarget implementation (#2377)

view details

Bartek Iwańczuk

commit sha 824542e61e1dbef09ca9388deca0c595a3e3e1df

chore: Port Python tests to unittest (#2408)

view details

Ryan Dahl

commit sha 3c355c2b3296cb930c37de44634b479cd7230ed6

Add 'brew install deno' to homepage (#2412)

view details

Ryan Dahl

commit sha 53b6356ec5eac1c84610c2d2e75b527485c47f3c

Correct tokio_util::block_on() and op_fetch_module_meta_data op_fetch_module_meta_data is an op that is used by the TypeScript compiler. TypeScript requires this op to be sync. However the implementation of the op does things on the event loop (like fetching HTTP resources). In certain situations this can lead to deadlocks. The runtime's thread pool can be filled with ops waiting on the result of op_fetch_module_meta_data. The runtime has a maximum number of threads it can use (the number of logical CPUs on the system). This patch changes tokio_util::block_on to launch a new Tokio runtime for evaluating the future, thus bipassing the max-thread problem. This is only an issue in op_fetch_module_meta_data. Other synchronous ops are truly synchornous, not interacting with the event loop. TODO comments are added to direct future development.

view details

Ryan Dahl

commit sha 64d2b7bc90cf6fdba661d6d3fe243fe332c076ee

Change tools/fmt_test.py to always download prettier This is to ensure a more fair test. Also we were already downloading from the internet since we changed the URL to use std@v0.5.0. This change exposes an OOM bug, which is then fixed in the upcoming compiler refactor by changing checkJs compiler option to false.

view details

Ryan Dahl

commit sha 856c44213b7faf507d4b481cfc170b2fd08f971a

TS compiler refactor * Compiler no longer has its own Tokio runtime. Compiler handles one message and then exits. * Uses the simpler ts.CompilerHost interface instead of ts.LanguageServiceHost. * avoids recompiling the same module by introducing a hacky but simple `hashset<string>` that stores the module names that have been already compiled. * Removes the CompilerConfig op. * Removes a lot of the mocking stuff in compiler.ts like `this._ts`. It is not useful as we don't even have tests. * Turns off checkJs because it causes fmt_test to die with OOM.

view details

Ryan Dahl

commit sha 5265bd7cb1f86af99b01d73c537d52a50df95fe2

v0.7.0

view details

Axetroy

commit sha 4c80394f54bf68e8e961fbc6275cd536717bc7f6

bump std/prettier@0.5.0 to std/prettier@0.7.0 (#2425)

view details

Christian Moritz

commit sha 15dadf812c95c3dd2b93b1ba41ef488baeeac0c1

tools/third_party: add DENO_GN_PATH and DENO_NINJA_PATH env vars

view details

Christian Moritz

commit sha 0e780e894854cada1244aa3f465c226593187edc

tools/setup: don't download sccache if --no-binary-download is passed

view details

push time in 2 days

Pull request review commentdenoland/deno

Start porting flatbuffer ops to JSON

 regex = "1.2.1" remove_dir_all = "0.5.2" ring = "~0.14.6" rustyline = "5.0.2"-serde = "1.0.99"+serde = { version = "1.0.99", features = ["derive"] }

#2808

ry

comment created time in 2 days

PR opened denoland/deno

Reviewers
build: enable 'derive' feature of 'serde' crate

For #2799

+13 -1

0 comment

3 changed files

pr created time in 2 days

create barnchpiscisaureus/deno

branch : derive_feature

created branch time in 2 days

Pull request review commentdenoland/deno

Start porting flatbuffer ops to JSON

 regex = "1.2.1" remove_dir_all = "0.5.2" ring = "~0.14.6" rustyline = "5.0.2"-serde = "1.0.99"+serde = { version = "1.0.99", features = ["derive"] }

Preferrably do this as a separate PR, so we can keep the cargo an gn builds in sync.

ry

comment created time in 2 days

Pull request review commentdenoland/deno

Start porting flatbuffer ops to JSON

 export function utimeSync(   atime: number | Date,   mtime: number | Date ): void {-  sendSync(...req(filename, atime, mtime));+  sendSync(OP_UTIME, {+    filename,+    atime: toSecondsFromEpoch(atime),

I realize this might not be a regression, but to avoid a future addition of a nanosecond-precision API, maybe split this in a [seconds, nanoseconds] tuple.

ry

comment created time in 2 days

created tagdenoland/deno

tagv0.16.0

A secure JavaScript/TypeScript runtime built with V8, Rust, and Tokio

created time in 2 days

push eventdenoland/deno

Ryan Dahl

commit sha 0809b06a3938868f364f1343b0de4d5d9686495d

v0.16.0

view details

push time in 2 days

PR merged denoland/deno

v0.16.0

<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

+32 -6

0 comment

4 changed files

ry

pr closed time in 2 days

push eventpiscisaureus/gnargo

Bert Belder

commit sha e276e6eedaef0d8e003140906cc1981ff110dded

Avoid crash when override matches no targets

view details

Bert Belder

commit sha 540a91e504db89cd9934c55b028552e8df91b196

Adapt for changes in how the 'cc' crate invokes 'lib.exe' and 'cl.exe'

view details

Bert Belder

commit sha ef076c2526b648f99f72c0141c9379a7fd3b0e05

Use specialized 'cap_lints' gn flag rather than the generic 'args' list

view details

Bert Belder

commit sha 752a6fa4b5de40239f51d1db8b6537614adf592a

Add additional overrides

view details

push time in 2 days

delete branch piscisaureus/deno

delete branch : upgrade_crates

delete time in 2 days

push eventdenoland/deno_third_party

Bert Belder

commit sha ad1117a3448408d7c008b680c770c6ea26f07820

Upgrade rust crates

view details

push time in 2 days

PR merged denoland/deno

Upgrade rust crates

<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

+425 -843

0 comment

7 changed files

piscisaureus

pr closed time in 2 days

push eventdenoland/deno

Bert Belder

commit sha 31aa7c1a5d8a27c720b6255dc3eceda3707b1826

build: support rust crates that generate sources in their build script

view details

Bert Belder

commit sha e0c1ed96e22dc9a94cb5457c8b3eb2f2cd1af831

build: remove per-crate 'treat_warnings_as_errors' gn flag

view details

Bert Belder

commit sha 7a902fed04e23c2be6133024f7ad8fdebb641c60

build: add 'cap_lints' flag for rust crates Using a specialized flag rather than the generic 'args' option makes build_extra/rust/BUILD.gn shorter and more readable.

view details

Bert Belder

commit sha 7f9c6decc8982dc9dec762d6f2cc77c6bdd3f817

third_party: upgrade rust crates

view details

push time in 2 days

Pull request review commentdenoland/deno

Upgrade rust crates

 env["GN_OUT_DIR"] = os.path.abspath(".") assert os.path.isdir(env["GN_OUT_DIR"]) +# Some crates (e.g. 'typenum') generate source files and place them in the+# directory indicated by the 'OUT_DIR' environment variable, which is normally+# set by Cargo. We pre-generate these files and store them in the source repo.+# Therefore, set 'OUT_DIR' so these crates can find their generated sources.

Actually:

./registry/src/github.com-1ecc6299db9ec823/arrayvec-0.4.11/build.rs
./registry/src/github.com-1ecc6299db9ec823/bitflags-1.1.0/build.rs
./registry/src/github.com-1ecc6299db9ec823/byteorder-1.3.2/build.rs
./registry/src/github.com-1ecc6299db9ec823/httparse-1.3.4/build.rs
./registry/src/github.com-1ecc6299db9ec823/hyper-0.12.33/build.rs
./registry/src/github.com-1ecc6299db9ec823/kernel32-sys-0.2.2/build.rs
./registry/src/github.com-1ecc6299db9ec823/libc-0.2.62/build.rs
./registry/src/github.com-1ecc6299db9ec823/log-0.4.8/build.rs
./registry/src/github.com-1ecc6299db9ec823/memchr-2.2.1/build.rs
./registry/src/github.com-1ecc6299db9ec823/memoffset-0.5.1/build.rs
./registry/src/github.com-1ecc6299db9ec823/nix-0.14.1/build.rs
./registry/src/github.com-1ecc6299db9ec823/parking_lot_core-0.4.0/build.rs
./registry/src/github.com-1ecc6299db9ec823/proc-macro2-1.0.1/build.rs
./registry/src/github.com-1ecc6299db9ec823/rand-0.6.5/build.rs
./registry/src/github.com-1ecc6299db9ec823/rand_chacha-0.1.1/build.rs
./registry/src/github.com-1ecc6299db9ec823/rand_pcg-0.1.2/build.rs
./registry/src/github.com-1ecc6299db9ec823/ring-0.14.6/build.rs
./registry/src/github.com-1ecc6299db9ec823/ryu-1.0.0/build.rs
./registry/src/github.com-1ecc6299db9ec823/serde-1.0.99/build.rs
./registry/src/github.com-1ecc6299db9ec823/syn-1.0.3/build.rs
./registry/src/github.com-1ecc6299db9ec823/winapi-0.3.7/build.rs
./registry/src/github.com-1ecc6299db9ec823/ws2_32-sys-0.2.1/build.rs
piscisaureus

comment created time in 2 days

Pull request review commentdenoland/deno

Upgrade rust crates

 env["GN_OUT_DIR"] = os.path.abspath(".") assert os.path.isdir(env["GN_OUT_DIR"]) +# Some crates (e.g. 'typenum') generate source files and place them in the+# directory indicated by the 'OUT_DIR' environment variable, which is normally+# set by Cargo. We pre-generate these files and store them in the source repo.+# Therefore, set 'OUT_DIR' so these crates can find their generated sources.

Maybe I'm confused... is there an example third-party crate which executes its own build.rs ?

I don't understand what you mean maybe. Build.rs gets executed when I run gnargo. It doesn't participate in the ninja build. There are dozens (probably >50) crates that use build.rs so please don't ask me to name all of them :) 'ring' is one example.

piscisaureus

comment created time in 2 days

Pull request review commentdenoland/deno

Upgrade rust crates

 env["GN_OUT_DIR"] = os.path.abspath(".") assert os.path.isdir(env["GN_OUT_DIR"]) +# Some crates (e.g. 'typenum') generate source files and place them in the+# directory indicated by the 'OUT_DIR' environment variable, which is normally+# set by Cargo. We pre-generate these files and store them in the source repo.+# Therefore, set 'OUT_DIR' so these crates can find their generated sources.

I was hoping this was general purpose support for build.rs files, but I guess not.

What do you mean? Build.rs files have been supported for the entire time; we just never captured any generated source files from the OUR_DIR.

piscisaureus

comment created time in 2 days

PR opened denoland/deno

Upgrade rust crates

<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

+425 -843

0 comment

7 changed files

pr created time in 2 days

push eventpiscisaureus/deno

Bert Belder

commit sha 7f9c6decc8982dc9dec762d6f2cc77c6bdd3f817

third_party: upgrade rust crates

view details

push time in 2 days

create barnchpiscisaureus/deno

branch : upgrade_crates

created branch time in 2 days

create barnchdenoland/deno_third_party

branch : 20190822_upgrade_crates

created branch time in 2 days

pull request commentdenoland/deno

Remove flatbuffers compile support

Any guidance on how to run flatbuffers manually should it be needed? Or are JSON messages close enough for this to never be needed?

ry

comment created time in 3 days

push eventpiscisaureus/deno

Bert Belder

commit sha b7d06f232dc9c65c9e679e7ab681d7afd4472d19

wip

view details

Bert Belder

commit sha 3b9d2593c5f837aa8837ee634cd72d7fd593fbae

x

view details

push time in 7 days

push eventpiscisaureus/deno

Bert Belder

commit sha de679ba2646f1438cc6164619f785b04dc3d706f

progress

view details

push time in 7 days

push eventpiscisaureus/deno

Bert Belder

commit sha 980deb027972b427ce1cef21da74afa53d157f05

progress

view details

push time in 9 days

push eventpiscisaureus/deno

Bert Belder

commit sha 3495cbe406fddcd4ca28d7e8aa212dd636e7d025

going somewhere

view details

push time in 9 days

push eventpiscisaureus/deno

Bert Belder

commit sha 19da6fe9451f9977324ed6b4a52cca0cf7b4424d

in progress

view details

push time in 9 days

push eventpiscisaureus/deno

Bert Belder

commit sha e9c6fbdf44d35a6bdcf8337858027ec68fd945aa

another attempt

view details

push time in 9 days

pull request commentdenoland/deno

DRAFT: Add experimental inspector support

The ASAN build is reporting plenty of leaks with this branch. I suspect this is due to some thread never exiting cleanly.

mtharrison

comment created time in 11 days

Pull request review commentdenoland/deno

Dynamic import should respect permissions

 impl ThreadSafeState {     self.permissions.check_run()   } +  pub fn check_dyn_import(+    self: &Self,+    module_specifier: &ModuleSpecifier,+  ) -> Result<(), ErrBox> {+    let u = module_specifier.as_url();+    match u.scheme() {+      "http" | "https" => {+        self.check_net_url(u)?;+        Ok(())+      }+      "file" => {+        let filename = u+          .to_file_path()+          .unwrap()+          .into_os_string()+          .into_string()+          .unwrap();+        self.check_read(&filename)?;+        Ok(())+      }+      _ => Err(permission_denied()),

A "unsupported import url" or something error would be more appropriate here.

ry

comment created time in 11 days

push eventdenoland/deno

Bert Belder

commit sha c3afa557515c64610b23ee460f8c6251de421f1a

Propagate Url::to_file_path() errors instead of panicking (#2771) * Propagate Url::to_file_path() errors instead of panicking

view details

push time in 12 days

PR merged denoland/deno

Propagate Url::to_file_path() errors instead of panicking

<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

+20 -1

0 comment

1 changed file

piscisaureus

pr closed time in 12 days

push eventpiscisaureus/deno

Bert Belder

commit sha a5b89bc8ca30a112cd8ae397d5673b35790f4f2b

Improve test

view details

push time in 12 days

PR opened denoland/deno

Propagate Url::to_file_path() errors instead of panicking

<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

+6 -1

0 comment

1 changed file

pr created time in 12 days

create barnchpiscisaureus/deno

branch : to_file_path_no_panic

created branch time in 12 days

pull request commentdenoland/deno

Dynamic import should respect permissions

But what about indirect dynamic imports?

I think I can still bypass the --allow-read check:

await import('http://bert.is.evil/import_local.js');

And then I host import_local.js on bert.is.evil:

export * from 'file:///home/bert/juicy_secret.json';

That's because only the top-level dynamic import is checked for permissions, and its submodules don't go through the normal import machinery.

ry

comment created time in 13 days

push eventdenoland/deno

Bartek Iwańczuk

commit sha 54982e948e882fbf413e06319f711d85b232026b

fix: cache paths on Windows are broken (#2760)

view details

push time in 13 days

PR merged denoland/deno

fix: cache paths on Windows are broken

Cache paths are not properly generated on Windows.

It's broken since v0.13.0.

Ref: denoland/deno_std#552 denoland/deno_std#556

Example:

file:///C:/deno/js/unit_test_runner.ts
// for above URL this cache path should be generated 
file\c\deno\js\unit_test_runner.ts
// this is produced (probably)
C:/deno/js/unit_test_runner.ts
+77 -23

5 comments

1 changed file

bartlomieju

pr closed time in 13 days

pull request commentdenoland/deno

fix: cache paths on Windows are broken

Haven't thought about it, but I believe Url won't return them from path_segments method. That inherently means that http://example.com/a.js?foo would be cached as http/example.com/a.js.

That doesn't seem right either. Only the part after # can be safely discarded.

bartlomieju

comment created time in 13 days

pull request commentdenoland/deno

fix: cache paths on Windows are broken

This fixes a very acute problem, so I'm all for landing this. However, we have similar problems with other path components, which can also contain illegal characters (e.g. ? and &).

Tangentially related, there's also a correctness issue w.r.t. case sensitivity. In URLs the path and query component are case sensitive, while the protocol and host are not. When deno_dir lives on a case insensitive file system it won't be able to handle that properly.

bartlomieju

comment created time in 13 days

Pull request review commentdenoland/deno

fix: cache paths on Windows are broken

 impl DiskCache {           None => host.to_string(),         };         out.push(host_port);++        for path_seg in url.path_segments().unwrap() {+          out.push(path_seg);+        }+      }+      "file" => {+        let path = url.to_file_path().unwrap();+        let mut path_components = path.components();++        if cfg!(target_os = "windows") {+          if let Some(Component::Prefix(prefix_component)) =+            path_components.next()+          {+            // Windows doesn't support ":" in filenames, so we need to extract disk prefix+            // Example: file:///C:/deno/js/unit_test_runner.ts+            // it should produce: file\c\deno\js\unit_test_runner.ts+            match prefix_component.kind() {+              Prefix::Disk(disk_byte) | Prefix::VerbatimDisk(disk_byte) => {+                let disk = (disk_byte as char).to_string();+                out.push(disk);+              }+              _ => {}

Add an unreachable() here. Let's not silently discard part components.

bartlomieju

comment created time in 13 days

push eventpiscisaureus/gnargo

Bert Belder

commit sha 175bec8db586b0249ddea916ca324cfd305ceab3

Fix typo

view details

push time in 15 days

Pull request review commentdenoland/deno

Fix dynamic import base path problem for REPL and eval

 impl fmt::Display for ModuleResolutionError { pub struct ModuleSpecifier(Url);  impl ModuleSpecifier {+  fn is_dummy_specifier(specifier: &str) -> bool {+    specifier == "<unknown>"

I think this is good as a short term fix.

Longer term, we should make ModuleSpecifier an enum , something like enum ModuleSpecifier { Url(Url), Repl(PathBuf) }, and stop converting between String/Url/ModuleSpecifier all the time, and change the resolve_import signature to pub fn resolve_import( specifier: &str, base: ModuleSpecifier ) -> Result<ModuleSpecifier, ModuleResolutionError>.

kevinkassimo

comment created time in 15 days

push eventpiscisaureus/gnargo

Bert Belder

commit sha 58d41392bb0dca4396fe251745befab50e22613e

Format generated source files for easier inspection/diffing

view details

Bert Belder

commit sha e34450539c92364beaba6411fbde847cc1a63f59

Small clean-up

view details

push time in 15 days

push eventpiscisaureus/deno

Bert Belder

commit sha d7d6f1294b27dd0baabcabb22b506c1ef7ae1802

third_party: add rust crates 'warp' and 'enclose'

view details

push time in 15 days

push eventdenoland/deno_third_party

Bert Belder

commit sha dbf33ca89612704c9b7f0de67b49ed2d605e663c

Add rust crates 'warp' and 'enclose'

view details

push time in 15 days

Pull request review commentdenoland/deno

Add rust crates 'warp' and 'enclose'

 template("_rust_crate") {       "--color=always",     ] +    if (defined(generated_source_dir)) {+      args += [+        # Some crates (e.g. 'typenum') generate source files and place them in+        # the directory indicated by the 'OUT_DIR' environment variable, which+        # is normally set by Cargo. This flag tells run.py to set 'OUT_DIR' to+        # the path where the current crate can find its generated sources.+        "--generated-source-dir=" +

I'm wondering if it would be better to rename this to "--build-script-out-dir"

piscisaureus

comment created time in 16 days

pull request commentdenoland/deno

Add rust crates 'warp' and 'enclose'

I think we should land this in the inspector branch (#2696) rather than preemptively in master.

I agree, although I'd suggest to keep the PRs separate for now. The people working on #2696 can merge this branch for the time being; when it is close to landing we can land this PR first. (Reason is that it is relatively difficult to work with two repos in tandem; if it needs a rebase there's a good chance I can do it with this standalone branch, but not when intermingled with unrelated PRs).

piscisaureus

comment created time in 16 days

pull request commentdenoland/deno

DRAFT: Add experimental inspector support

I managed to get 'warp' to build with gn/ninja after all. See #2707.

mtharrison

comment created time in 16 days

push eventpiscisaureus/gnargo

Bert Belder

commit sha 0630aa2234b1144eb2f2c012ef41e2ef5659ec8b

Handle custom build scripts that are not named 'build.rs'

view details

Bert Belder

commit sha dcb9483940c22d87aa0a3f60d8c173feca4cfc80

Support generated source files produced by custom-build scripts

view details

Bert Belder

commit sha 7e20b2bdd62a8a17ce38fa2d9e73013ba7c1e9ef

Use 'semver' npm package instead of custom implementation

view details

Bert Belder

commit sha bc566b4bc4498d16222698f6d359dffd21f6918b

Add additional overrides

view details

push time in 16 days

push eventpiscisaureus/deno

Kevin (Kun) "Kassimo" Qian

commit sha 52c13fb3ed94e41d90bbe08d1bc299ca90505755

Enforce env permission on homeDir() and execPath (#2714)

view details

Bartek Iwańczuk

commit sha aaa7a3eac4df0de9a93dc8fc4717d38212a3de5b

use BTreeMap for ResourceTable (#2721)

view details

Kevin (Kun) "Kassimo" Qian

commit sha ddee2dff14772ade16e282ad18eda6f5054ce94e

Provide option to delete Deno namespace in worker (#2717)

view details

Ryan Dahl

commit sha a517513182221aa351528cf15d28c449b49fea13

Remove Deno.build.args feature (#2728) This is a minor feature which complicates the build signifigantly. Removing to ease refactoring the build system: https://github.com/denoland/deno/issues/2608

view details

Ryan Dahl

commit sha 046cccfe1768837fcd5b4c1fd7d52fb2d98c0b11

Remove dispatch optimization (#2732) Deno.core.dispatch() used to push the "control" buf onto the shared array buffer before calling into V8, with the idea that it was one less argument to parse. Turns out there is no more overhead passing the control ArrayBuffer directly over. Furthermore this optimization was making the refactors outlined in #2730 more complex. Therefore it is being removed.

view details

Nayeem Rahman

commit sha 11c850af423f07769f054c494a76cbd9efb8806c

Enforce permissions on kill(), homeDir() and execPath (#2723)

view details

Kevin (Kun) "Kassimo" Qian

commit sha ccee2f01ba2f6304720ab17e99dee17bf6687bd8

Implement Blob url support for worker (#2729)

view details

Kevin (Kun) "Kassimo" Qian

commit sha 4519f9a50db8852c5b70ff47481f0fc9d0fbe2f2

Make Deno.execPath a function (#2743) And throws without allow-env

view details

Kevin (Kun) "Kassimo" Qian

commit sha 77d0d1e45ccfd33a8a98e2f5fa4ba618759b5dd3

Fix small execPath issues (#2744)

view details

Ryan Dahl

commit sha 43d099c0275878f6c6358eb0e9a0094d076d7c29

Fix incremental 'cargo build' (#2740) Tip: RUSTC_WRAPPER should be unset for incremental builds to work.

view details

Bartek Iwańczuk

commit sha 5350abbc7ffdba6d17166fa00ad89e86979a43f7

manual: Edit note about V8 profiling (#2742)

view details

Ryan Dahl

commit sha e438ac2c74c823882dc9c9ecde2a9e9ed7bcfb4b

Add op_id throughout op API (#2734) Removes the magic number hack to switch between flatbuffers and the minimal dispatcher. Adds machinery to pass the op_id through the shared_queue.

view details

Daniel Buckmaster

commit sha 520bdb6c31dd08b6f4e52de5116fd23d6d57fdda

Fix repl crash when deno dir doesn't exist (#2727)

view details

andy finch

commit sha 56a82e72d9867a9b5f8a10bc8e4b81b86cd815c9

Resolve worker specifiers relative to main module of host. (#2751)

view details

Bert Belder

commit sha 6fbf2e96243e6b79c1fb03c17b376b028e442694

Dynamic import (#2516)

view details

Bert Belder

commit sha 83d5362f1d7d8589b862de57912135067a8278c7

v0.14.0

view details

Bert Belder

commit sha 43a02da284d06fbafc8aeffe419ea7ad64882190

build: support crates that generate source files in their build script

view details

Bert Belder

commit sha d0f6e39af4cb888d5c2c5638b525736e7943e5bd

third_party: add rust crates 'warp' and 'enclose'

view details

push time in 16 days

push eventdenoland/deno_third_party

Bert Belder

commit sha afa9d5ed32e39df58617bb88be3412aca9af4ed5

Add rust crates 'warp' and 'enclose'

view details

push time in 16 days

create barnchdenoland/deno_third_party

branch : 20190809_add_warp_and_enclose

created branch time in 16 days

delete branch denoland/deno

delete branch : release_0_14_0

delete time in 16 days

delete branch piscisaureus/deno

delete branch : loader_refactor

delete time in 16 days

created tagdenoland/deno

tagv0.14.0

A secure JavaScript/TypeScript runtime built with V8, Rust, and Tokio

created time in 16 days

push eventdenoland/deno

Bert Belder

commit sha 83d5362f1d7d8589b862de57912135067a8278c7

v0.14.0

view details

push time in 16 days

PR merged denoland/deno

v0.14.0

v0.14.0 / 2019.08.09

In deno:

  • feat: remove Deno.build.args (#2728)
  • feat: support native line ending conversion in the Blob constructor (#2695)
  • feat: add option to delete the Deno namespace in a worker (#2717)
  • feat: support starting workers using a blob: URL (#2729)
  • feat: make Deno.execPath() a function (#2743, #2744)
  • feat: support await import(...) syntax for dynamic module imports (#2516)
  • fix: enforce permissions on Deno.kill(), Deno.homeDir() and Deno.execPath() (#2714, #2723)
  • fix: cargo build now builds incrementally (#2740)
  • fix: avoid REPL crash when DENO_DIR doesn't exist (#2727)
  • fix: resolve worker module URLs relative to the host main module URL (#2751)
  • doc: improve documentation on using the V8 profiler (#2742)

In deno_std:

  • fix: make the 'ws' module (websockets) work again (denoland/deno_std#550)
+29 -8

0 comment

4 changed files

piscisaureus

pr closed time in 16 days

push eventdenoland/deno

Bert Belder

commit sha 83d5362f1d7d8589b862de57912135067a8278c7

v0.14.0

view details

push time in 16 days

push eventdenoland/deno

Bert Belder

commit sha 1332c9a8038850771e9ab70324235c7ce47e4e15

v0.14.0

view details

push time in 16 days

PR opened denoland/deno

v0.14.0

v0.14.0 / 2019.08.09

In deno:

  • feat: remove Deno.build.args (#2728)
  • feat: support native line ending conversion in the Blob constructor (#2695)
  • feat: add option to delete the Deno namespace in a worker (#2717)
  • feat: support starting workers using a blob: URL (#2729)
  • feat: make Deno.execPath() a function (#2743, #2744)
  • feat: support await import(...) syntax for dynamic module imports (#2516)
  • fix: enforce permissions on Deno.kill(), Deno.homeDir() and Deno.execPath() (#2714, #2723)
  • fix: cargo build now builds incrementally (#2740)
  • fix: avoid REPL crash when DENO_DIR doesn't exist (#2727)
  • fix: resolve worker module URLs relative to the host main module URL (#2751)
  • doc: improve documentation on using the V8 profiler (#2742)

In deno_std:

  • fix: make the 'ws' module (websockets) work again (deno_std#550)
+26 -5

0 comment

4 changed files

pr created time in 16 days

create barnchdenoland/deno

branch : release_0_14_0

created branch time in 16 days

push eventdenoland/deno

Bert Belder

commit sha 6fbf2e96243e6b79c1fb03c17b376b028e442694

Dynamic import (#2516)

view details

push time in 16 days

PR merged denoland/deno

Dynamic import

My attempt at fixing #2510. The scope went a little overboard. cc @ry

+723 -425

6 comments

16 changed files

piscisaureus

pr closed time in 16 days

push eventpiscisaureus/deno

Bert Belder

commit sha 6fbf2e96243e6b79c1fb03c17b376b028e442694

Dynamic import (#2516)

view details

push time in 16 days

push eventpiscisaureus/deno

Daniel Buckmaster

commit sha 520bdb6c31dd08b6f4e52de5116fd23d6d57fdda

Fix repl crash when deno dir doesn't exist (#2727)

view details

andy finch

commit sha 56a82e72d9867a9b5f8a10bc8e4b81b86cd815c9

Resolve worker specifiers relative to main module of host. (#2751)

view details

Bert Belder

commit sha 2857ebe2041b1accb4d5241297ab4272618ac47f

Dynamic import

view details

Ryan Dahl

commit sha 4cb357053de37e256cc72f4b33d3eae9676ee9df

remove dependency of isolate on modules

view details

Ryan Dahl

commit sha 93951bd3e7b9680228f5fd0dcabf3c625b31c771

fixing tests

view details

Ryan Dahl

commit sha 5437fea79914df1bca33fc30d8220386fe2268ad

fix tests/015_duplicate_parallel_import

view details

Ryan Dahl

commit sha 812e3b7948cf9a5457d5fdebaaf4a4a2693d74c4

fix dyn_import_ok test

view details

Ryan Dahl

commit sha 12d5da204a4dab130fdb1d883403d062e0861adf

disable tests/error_014_catch_dynamic_import_error

view details

Ryan Dahl

commit sha 3d9f7e213d612c80b82bb8bef86dfef2192bc3ad

cleanup

view details

Ryan Dahl

commit sha 853eca95219cc5d6bd669fd1316cd095cb9f1cd8

review comment

view details

Ryan Dahl

commit sha d032340f5473e960649f7848b0ba0c463c6ebbd3

review comment

view details

Ryan Dahl

commit sha a9593f7c9a4ff0c0896227241750e98756594173

cleanup

view details

Ryan Dahl

commit sha 9a6ee94574885ecd1fe6bf714a6813b95d134ac3

review comments regarding is_main

view details

Ryan Dahl

commit sha 628212d994b9f52775bd4f9fd5cbf719c075a75d

cleanup

view details

Ryan Dahl

commit sha ace32e2729d89e76e7f10bdcd5401c4f53bdc8b1

fix test slow_never_ready_modules

view details

Bert Belder

commit sha b896e7f4c953f4884f73010819a4bbe2469122bd

fix comment

view details

Bert Belder

commit sha 4b95453b1218a59b02ba8baaf771fbfe31ad7e8a

Don't exit while there are pending dyn imports

view details

Bert Belder

commit sha 17c34523f73a55511920f2ceb1099e72537dbd26

Ensure non-js dyn import error strings are null terminated

view details

Bert Belder

commit sha dc3e298dda469e1bd804e4b15279c81191df3f98

Properly handle dynamic-import errors from deno_mod_new()

view details

Bert Belder

commit sha 0a563265c829b3ce5bd8ac6104fcb99b1d6087bf

Enable test

view details

push time in 16 days

issue commenttokio-rs/mio

Merging Registry and Poll (again)

@Thomasdezeeuw my read (which we probably should verify) is not the # of concurrent polls, but the # of threads that can be associated with the IOCP port at the same time. Read the above section and it describes how a thread becomes associated / unassociated with an IOCP port. My guess is that, once a thread is associated with the IOCP port, it will block another thread even if it is not currently polling.

I also don't think we can just set a very high number as my guess is internal memory is allocated / reserved proportionally to the number.

Maybe @piscisaureus knows more than I do, either way we probably should verify this.

TL;DR: MSDN explains poorly how this works, and the default behavior (setting NumberOfConcurrentThreads to 0) is reasonable behavior.

Longer explanation: windows will not pre-empt a thread that's been woken up by GetQueuedCompletionStatus in order to wake up another thread blocked on the same completion port. However, once the the woken thread blocks on something else, then it is no longer treated as "associated with the completion port", and other threads will wake up. So practically speaking there is no problem; you can use as many threads as you like to poll a completion port, and they will all receive completions; the only consideration is that if threads do CPU-only work in response to a completion, the number of threads running concurrently will be limited to the number of CPUs in the system.

Tangentially related: https://devblogs.microsoft.com/oldnewthing/20181123-00/?p=100305

Thomasdezeeuw

comment created time in 16 days

issue commenttokio-rs/mio

Remaining `wepoll` items.

I would like to add: the current locking scheme is too granular.

It makes little sense to use separate locks for the update_queue and the iocp HANDLE; it's likely to hurt performance and introduce subtle bugs. One example I could find:

https://github.com/tokio-rs/mio/blob/211223e92865e5ae276333cc91673d764bbc386d/src/sys/windows/selector.rs#L368-L370

        self.update_sockets_events()?;

        self.active_poll_count.fetch_add(1, Ordering::SeqCst);

^-- By calling update_socket_events() before incrementing active_poll_count, it's possible that another thread doesn't call update_socket_events() (because it looks like there are no active polls) when it should (because there actually is another thread that's about to block).

This is just an example, which could be easily fixed by reversing the two operations. But in general I think it'd be better to use a single lock to protect both the completion port and the associated state. Then you release this lock just before calling GetQueuedCompletionStatusEx() and immediately acquire it again right after GetQueuedCompletionStatusEx() returns.

This might require integrating parts of miow into mio, which seems like a good idea either way.

carllerche

comment created time in 16 days

pull request commentdenoland/deno

Dynamic import

https://github.com/denoland/deno/pull/2516/files#diff-e42bc8cc82b66eecdca76f5c6069e716?

piscisaureus

comment created time in 17 days

push eventpiscisaureus/deno

Bert Belder

commit sha 39d6eb614590bc2cc4effcb7808107caa2d5ff07

Dynamic import

view details

push time in 18 days

Pull request review commentdenoland/deno

Add op_id throughout op API

 impl Isolate {         // return value.         // TODO(ry) check that if JSError thrown during respond(), that it will be         // picked up.-        let _ = isolate.respond(Some(&buf));+        let op_id = 0; // Sync messages ignore op_id.+        let _ = isolate.respond(Some((op_id, &buf)));

Maybe panic here if respond() errors?

ry

comment created time in 18 days

push eventpiscisaureus/deno

Ryan Dahl

commit sha 1fde15c0bc77e0c5cc6f7cbf27b4e072e1ad6c46

Fix REPL when it receives EOF (#2638)

view details

Ryan Dahl

commit sha bd6ebb32df11641e148fd0adca41e7188f16afce

hyper_hello should be in its own crate (#2641) So that "cargo build" will build it when the gn frontend is eventually removed.

view details

Yoshiya Hinosawa

commit sha 9c454998646ef49f652bc919f53503ed07a1c55c

Support window.onload (#2643)

view details

Ryan Dahl

commit sha 4e248ecda9bb31478c6db7f5e76fa12b64b516a9

v0.12.0

view details

迷渡

commit sha 181cfc9fb5bd2cbb7cd0a994a845e1901d256770

Adjust console constructor (#2649) https://github.com/denoland/deno/pull/2073#discussion_r303401539

view details

Ryan Dahl

commit sha 481a82c983e40201589e105e28be4ce809e46a60

Edits to manual (#2646)

view details

Bartek Iwańczuk

commit sha 8214b686cea3f6ad57d7da49a44d33185fdeb098

Refactor DenoDir (#2636) * rename `ModuleMetaData` to `SourceFile` and remove TS specific functionality * add `TsCompiler` struct encapsulating processing of TypeScript files * move `SourceMapGetter` trait implementation to `//cli/compiler.rs` * add low-level `DiskCache` API for general purpose caches and use it in `DenoDir` and `TsCompiler` for filesystem access * don't use hash-like filenames for compiled modules, instead use metadata file for storing compilation hash * add `SourceFileCache` for in-process caching of loaded files for fast subsequent access * define `SourceFileFetcher` trait encapsulating loading of local and remote files and implement it for `DenoDir` * define `use_cache` and `no_fetch` flags on `DenoDir` instead of using in fetch methods

view details

迷渡

commit sha a0b8f13f18b24924d050e196baf6132b27a6011f

Rename powershell highlighting to shell (#2654)

view details

迷渡

commit sha ac98bd8a7ce13e6aaf35d13b8743281df24806d7

fix timer's params length (#2655)

view details

Ryan Dahl

commit sha bc12a3ba56b39ba8dd3f5afcccebca177361eab2

Reorder tools/format.py so slowest are last (#2661)

view details

Ryan Dahl

commit sha 55ca0f09cb50f8bc6b0590a9a88febc41f91e51b

REPL shouldn't panic when it gets SIGINT (#2662)

view details

Ryan Dahl

commit sha a37bc0088f9de76108fe0bd9243c794b413d73cf

Remove hacky normalize_path (#2660)

view details

andy finch

commit sha 056c14617565291cb00df9fec6f9779a3669089f

Fix expected dyn before AnyError trait (#2663)

view details

andy finch

commit sha 042484d45afe129f0c08d387870e4c6de019c34b

remove v8::Locker from deno_respond (#2664)

view details

andy finch

commit sha 621af21e6eab9b0f736d5b6e8acc48dbad4a68d2

only use Locker when calling into js (#2665)

view details

Ryan Dahl

commit sha a00d087b39da7894276c2292335d2709a6cebd8c

Improve example on homepage (#2667)

view details

Bartek Iwańczuk

commit sha 34f212f257af3ccce4a1cb8e9b75b9cb5cb1c13b

fix: bring back --no-fetch flag (#2671)

view details

andy finch

commit sha c98d9bf7097575ec9832864f0e0d076a4763717c

removed unnecessary implementation from SourceFileFetcher (#2670)

view details

Yoshiya Hinosawa

commit sha 9c22961b6a06a75dad68bad87328857a9f7a55dc

feat(website/benchmark): enable zoom of charts (#2668)

view details

Bartek Iwańczuk

commit sha 70de8dd51d465ea2016d6bb7c0728111f4493668

save headers for all intermediate redirects (#2677)

view details

push time in 18 days

pull request commentdenoland/deno

Add op_id throughout op API

I don't really understand what the purpose of moving the op_id out of the control buffer while leaving the other fields, (e.g. promise_id) in there. Would it not be better to shed the control buffer entirely then?

ry

comment created time in 18 days

Pull request review commentdenoland/deno

[NEED TESTS] Initial implementation of general user land signal handling (unix only)

 pub fn dispatch_all_legacy(       );       Op::Async(result_fut)     }+    Ok(Op::AsyncOptional(fut)) => {

What's the purpose of this extra variant? To make sure the process will exit even when the future is not ready? I'd suggest to use just Op::Async() and have a separate pending-op count rather than using pending_ops.len().

kevinkassimo

comment created time in 19 days

push eventdenoland/deno_std

Bartek Iwańczuk

commit sha 3e17815c7e61cfd2e4c46a12649811543509d563

Revert "http: delete conn parameter in readRequest" (#550) This reverts commit 209183e24812095a40e48e60484f80a5a254b1c3. Fixes: #441

view details

push time in 19 days

PR merged denoland/deno_std

Revert "http: delete conn parameter in readRequest (#430)"

Opening new PR instead of #443 cause I can't push there.

Fixes #441

Merged master and fixed other conflicts.

+36 -3

1 comment

2 changed files

bartlomieju

pr closed time in 19 days

issue closeddenoland/deno_std

ws module broken

https://github.com/denoland/deno_std/pull/430 removed the conn property from ServerRequest "because it's not used anymore". However, this property is still used in acceptWebSocket (see: https://github.com/denoland/deno_std/blob/master/ws/mod.ts#L368). So the ws module is broken now.

closed time in 19 days

MarkTiedemann

push eventpiscisaureus/deno

Bert Belder

commit sha ea721b3bc4a1e856005f64fd795251e63f543288

wip

view details

push time in 20 days

push eventpiscisaureus/deno

Bert Belder

commit sha 2237ec0711157a3ea9a9c666e3ee1b386d3357cf

wip

view details

push time in 20 days

push eventpiscisaureus/deno

Bert Belder

commit sha 406bfd88ba3de6afdf364246374d2b03749deb81

wip

view details

Bert Belder

commit sha e7534f67b6a70eae1e5f45ec987f26686a6acc4c

wip

view details

push time in 20 days

push eventpiscisaureus/deno

Bert Belder

commit sha aa784d084bbc190ceaa11283e8131bf6778d1d22

improve

view details

push time in 20 days

push eventpiscisaureus/deno

Bert Belder

commit sha c5bd7ae968669431e57f524af8a4668d1a2d1d3a

wow

view details

push time in 22 days

push eventpiscisaureus/deno

Bert Belder

commit sha b1d3074e31344f2f192c7f9fe0e7029eaf2a8fdd

bak

view details

push time in 22 days

push eventpiscisaureus/deno

Bert Belder

commit sha c6861b537ead4bba21817610664d68ffbe7daad5

third_party: upgrade rust crates

view details

Bert Belder

commit sha 528fa8b904f8bb76d51820da8cab817eb9c9b14b

third_party: add rust crates 'warp' and 'enclose'

view details

push time in 22 days

push eventdenoland/deno_third_party

Ryan Dahl

commit sha ce150f96ea9dddfcceb1830ea85810d778796afe

Remove rustfmt binary

view details

Bert Belder

commit sha ddb37d7734154c3c07e7c14deaf6523a635e52d8

upgrade rust crates

view details

Bert Belder

commit sha cf61505d0f45a3614ad93b41ec2a8811c23ecd2a

Add rust crates 'warp' and 'enclose'

view details

push time in 22 days

push eventpiscisaureus/gnargo

Bert Belder

commit sha af0505c810ded46ceebe7064a0a2f1b365ad72ae

Remove debug output

view details

Bert Belder

commit sha 8877cc69868068adc1fd09b06faca4f74f1e5217

Remove comment cruft

view details

Bert Belder

commit sha ba354f397e64d7ecec52417d57ba4587f5144528

Remove overrides that are no longer necessary

view details

Bert Belder

commit sha ada2052e91ee9857ef5cdcdbd28bac3a1cd4d350

Support --extern imports that use an alias different from the crate name

view details

Bert Belder

commit sha 0353c93f40595c6b7da7b896a7464dd092802ef7

Rework override hooks to allow downgrading 'rand'

view details

Bert Belder

commit sha 1c1042d94d5bd812130fe322b897a1c694ab3a2a

Move overrides to the end of gen.js

view details

Bert Belder

commit sha b0f2df4b1763d6ee26195ca29d897af35bd66532

Redefine 'latest version' as 'canonical version'

view details

Bert Belder

commit sha fe4106748e24a75e2cebee9a3af65b966d595e3d

Add canonical_version override to help with downgrading rand

view details

Bert Belder

commit sha 9cd13ba5d6557d26f64f7e350a44502cdcfa5f95

Bring back the 'use_canonical_version()' helper function

view details

Bert Belder

commit sha b72fb2b0eb3531c97cef9215d04b8e8e7d51fe2f

Add some new overrides that are now necessary

view details

push time in 22 days

delete branch piscisaureus/deno

delete branch : upgrade_crates

delete time in 22 days

push eventdenoland/deno_third_party

Bert Belder

commit sha ddb37d7734154c3c07e7c14deaf6523a635e52d8

upgrade rust crates

view details

push time in 22 days

push eventdenoland/deno

Bert Belder

commit sha 5bca001f9703940e693d6a55944ef1ee7fc67f58

build: support crate imports using an alias name A crate can assign an alternative name, different from the crate name, when importing another crate. On the command line this looks like: rustc ... --extern foo_crate=path/to/bar_crate.rlib We need to support this so we can eventually upgrade to rand-0.7.x.

view details

Bert Belder

commit sha c6861b537ead4bba21817610664d68ffbe7daad5

third_party: upgrade rust crates

view details

push time in 22 days

PR merged denoland/deno

Upgrade rust crates

<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

+792 -535

0 comment

9 changed files

piscisaureus

pr closed time in 22 days

push eventpiscisaureus/deno

Bert Belder

commit sha c6861b537ead4bba21817610664d68ffbe7daad5

third_party: upgrade rust crates

view details

push time in 23 days

push eventdenoland/deno_third_party

Bert Belder

commit sha ddb37d7734154c3c07e7c14deaf6523a635e52d8

upgrade rust crates

view details

push time in 23 days

push eventpiscisaureus/deno

Bert Belder

commit sha bcc3acc4539242359400d379a110fe9368ad75a1

third_party: upgrade rust crates

view details

push time in 23 days

push eventpiscisaureus/deno

Bert Belder

commit sha eb4307b5fe83d7e73ac72866f58dc84dacd7a789

third_party: add rust crates 'warp' and 'enclose'

view details

push time in 23 days

push eventpiscisaureus/deno

Ryan Dahl

commit sha 3971dcfe10b94e901a224b5328a9dafd1e2ecc08

Use system rustfmt instead of fixed binary (#2701)

view details

Tomohito Nakayama

commit sha deec1b9b97011d1a0ef7312c0a3efde21186b82d

Implement function convertLineEndingsToNative in blob.ts (#2695) based on https://w3c.github.io/FileAPI/#convert-line-endings-to-native

view details

Bert Belder

commit sha 5bca001f9703940e693d6a55944ef1ee7fc67f58

build: support crate imports using an alias name A crate can assign an alternative name, different from the crate name, when importing another crate. On the command line this looks like: rustc ... --extern foo_crate=path/to/bar_crate.rlib We need to support this so we can eventually upgrade to rand-0.7.x.

view details

Bert Belder

commit sha c33f21c4d780628b7eb1728f10d95b26e7ee7e8a

third_party: upgrade rust crates

view details

Bert Belder

commit sha ebc9f50be71aa726bd7a8d0133b25ab2b267b5c6

third_party: add rust crates 'warp' and 'enclose'

view details

Bert Belder

commit sha a0ac5c3dca18499fc5696cef001f0371d30334b4

third_party: add rust crates 'warp' and 'enclose' (not working)

view details

push time in 23 days

create barnchdenoland/deno_third_party

branch : 20190802_add_warp_and_enclose

created branch time in 23 days

more