profile
viewpoint
Pietro Albini pietroalbini Italy https://www.pietroalbini.org @rust-lang infra, docs.rs, web presence lead • @rust-lang core, release, crates.io, security response

integer32llc/rust-playground 514

The Rust Playground

pietroalbini/reddit-place-2017 36

Archive of Reddit's r/place data, history and images

pietroalbini/areweawaityet 12

Track Rust's await bikeshedding

pietroalbini/lektor-minify 12

Minify build artifacts in a Lektor project

pietroalbini/fisher 11

Simple yet powerful webhooks catcher

pietroalbini/buildthedocs 7

A Sphinx documentation building tool on steroids.

pietroalbini/crater-tree 4

Generate a dependency tree from crater failures

pietroalbini/persuade 4

Simple presenter console for your PDFs, in your web browser.

pietroalbini/civ5-wallpapers 1

Dynamic linux wallpapers from Civilization V

pietroalbini/dotfiles 1

My own configuration files

push eventrust-lang-nursery/rust-toolstate

Rust Toolstate Update

commit sha 9c89de24e0789b5288e1ad7f8da99c44ee6f6df9

(windows CI update)

view details

push time in an hour

PR opened rust-lang/www.rust-lang.org

Fix alignements of blocks on several pages

On Community, “Get in contact” section is more to the left than its button underneath.

<details><summary>Screenshots</summary>

Before

bildo

After

bildo

</details>

On Networking, the right code block is not exactly the same size as the right code block because its height is set with a hackish padding-bottom: 3.8em;.

<details><summary>Screenshots</summary>

Before

bildo

After

bildo </details>

On Command-line apps, same code was applied to make look a bit better, and to make the code between the two components almost same.

<details><summary>Screenshots</summary>

Before

bildo

After

bildo </details>

+11 -14

0 comment

4 changed files

pr created time in 2 hours

push eventrust-lang-nursery/rust-toolstate

Rust Toolstate Update

commit sha a89014d225566acd8f81e9929d5d0802721c46e3

(linux CI update)

view details

push time in 2 hours

PullRequestEvent

pull request commentrust-lang/crates-build-env

Add libmilter-dev for milter-sys

Ok, makes sense - then crater will be able to build milter-sys too.

glts

comment created time in 3 hours

PR opened rust-lang/www.rust-lang.org

Clean css

The changes are pretty straightforward. I checked carefully if I didn’t break anything.

+9 -146

0 comment

3 changed files

pr created time in 3 hours

pull request commentrust-lang/crates-build-env

Add libmilter-dev for milter-sys

@jyn514 Hang on, we still need this. I do apologise for all the confusion, today is not my best day. Yes, cargo doc doesn't need to link the library, but the build.rs will look for pkg-config metadata, once the build hack there is removed. You were right all along, sorry.

I would prefer if we could add libmilter-dev here, and I can remove the build hack to have a clean build in milter-sys. Let me know if you could agree to this.

glts

comment created time in 3 hours

PR closed rust-lang/crates-build-env

Add libmilter-dev for milter-sys linux package-request

This adds package libmilter-dev for the milter-sys crate.

Thank you!

+1 -0

8 comments

1 changed file

glts

pr closed time in 3 hours

pull request commentrust-lang/crates-build-env

Add libmilter-dev for milter-sys

Right, cargo doc doesn't need to link the library at all and just type checks the code. Glad we figured it out! :)

glts

comment created time in 3 hours

pull request commentrust-lang/crates-build-env

Add libmilter-dev for milter-sys

Sorry to bother you again, do you know if for building the docs, Cargo checks if a library links properly? I think it doesn’t (nor does it run any tests, of course). So in that case the C library is indeed not needed at all for the milter-sys docs, I misunderstood the purpose of packages.txt and should close this pull request!

glts

comment created time in 3 hours

push eventrust-lang-nursery/rust-toolstate

Rust Toolstate Update

commit sha 7eb60cc1395ef44514c55be617b45d16fd5d9b98

(windows CI update)

view details

push time in 4 hours

push eventrust-lang-nursery/rust-toolstate

Rust Toolstate Update

commit sha c675f1d794b1b8fd02755f3fe4e3b276e48aa8fd

(linux CI update)

view details

push time in 4 hours

pull request commentrust-lang/crates-build-env

Add libmilter-dev for milter-sys

Thanks, that really is curious. On any Ubuntu 20.04 or Debian Testing I’ve tried cargo build or cargo doc fails for milter-sys – until I apt install libmilter-dev. I will try to find out why it is working on docs.rs.

glts

comment created time in 4 hours

pull request commentrust-lang/crates-build-env

Add libmilter-dev for milter-sys

It’s true that milter-sys docs can be built on docs.rs today, but it is unclear why. I would guess that there is some other library in the docs.rs build env that installs libmilter as a dependency. But such a hidden dependency may disappear and break in the future. I think it is better to be explicit about the libmilter-dev requirement, t

Ok, this is the bit I was missing, thanks :) but I'm still confused what's going on, because it's not installed in the build environment:

$ docker run -it rustops/crates-build-env bash
root@d85ecfbe8395:/# apt list --installed | grep milter  # no output

I have trouble understanding how this library is different from other -sys libraries to you.

The difference is that your crate is building successfully without this library installed, and the build image is already very large, so I'd like to avoid adding new libraries unless they're necessary.

glts

comment created time in 5 hours

pull request commentrust-lang/crates-build-env

Add libmilter-dev for milter-sys

@jyn514 hm … I have trouble understanding how this library is different from other -sys libraries to you. milter-sys is simply the low-level FFI bindings crate for libmilter. It cannot be built or doc’ed without libmilter-dev.

My motive for opening this pull request is to make it explicit that libmilter-dev must be installed in the docs.rs build env. It’s true that milter-sys docs can be built on docs.rs today, but it is unclear why. I would guess that there is some other library in the docs.rs build env that installs libmilter as a dependency. But such a hidden dependency may disappear and break in the future. I think it is better to be explicit about the libmilter-dev requirement, that’s all – please tell me if you think otherwise.

I do hope to also get rid of the build hack you mentioned, soon, but that is an independent change that is not affected by this pull request.

glts

comment created time in 5 hours

pull request commentrust-lang/crates-build-env

Add libmilter-dev for milter-sys

I think we had this discussion a while ago :laughing: You ended up special casing docs.rs WRT the pkg-config file. https://github.com/rust-lang/docs.rs/issues/191#issuecomment-582381485

Is the idea here to let you get rid of the hack in the build.rs? I'm ok with adding it in that case, there should just be some reason.

glts

comment created time in 6 hours

pull request commentrust-lang/crates-build-env

Add libmilter-dev for milter-sys

Thanks for looking.

libmilter-dev is strictly required for building milter-sys under any circumstances. Why it did build on docs.rs I do not know, it is possible that libmilter was installed as a transitive dependency of something else.

glts

comment created time in 6 hours

pull request commentrust-lang/crates-build-env

Add libmilter-dev for milter-sys

@glts it looks like that crate built successfully - is there a reason you're adding the new package? https://docs.rs/milter-sys/0.2.0/milter_sys/

glts

comment created time in 6 hours

push eventrust-lang-nursery/rust-toolstate

Rust Toolstate Update

commit sha 3079b7f144f6306babb659f07ea3c1d737163b9c

(windows CI update)

view details

push time in 6 hours

push eventrust-lang-nursery/rust-toolstate

Rust Toolstate Update

commit sha 26d243544cb643d42cf25fda78cb422b303de670

(linux CI update)

view details

push time in 7 hours

PR opened rust-lang/crates-build-env

Add libmilter-dev for milter-sys

This adds package libmilter-dev for the milter-sys crate.

Thank you!

+1 -0

0 comment

1 changed file

pr created time in 8 hours

push eventrust-lang-nursery/rust-toolstate

Rust Toolstate Update

commit sha 3cebd98a5852024ac6b00a4541d58accd31af540

(windows CI update)

view details

push time in 9 hours

push eventrust-lang-nursery/rust-toolstate

Rust Toolstate Update

commit sha c1e32c1c6b76c41162424da062d4c9d4f878fb8b

(linux CI update)

view details

push time in 9 hours

push eventrust-lang-nursery/rust-toolstate

Rust Toolstate Update

commit sha 8cab75487493e2df97585cc77010631bca28e552

(windows CI update)

view details

push time in 11 hours

push eventrust-lang-nursery/rust-toolstate

Rust Toolstate Update

commit sha 9a358e7455cc5989384bc90ea637a89381d1aab6

(linux CI update)

view details

push time in 11 hours

push eventrust-lang-nursery/rust-toolstate

Rust Toolstate Update

commit sha 935555c6fe525ca6d30a6080f3c59aedcc7692c9

(windows CI update)

view details

push time in 13 hours

push eventrust-lang-nursery/rust-toolstate

Rust Toolstate Update

commit sha eac69bda1174ce2e9a54665a6fab3d79bc4397ed

(linux CI update)

view details

push time in 13 hours

push eventrust-lang-nursery/rust-toolstate

Rust Toolstate Update

commit sha 29bb3452b0caae2cefacc05bb9e69af9a14a7b70

(windows CI update)

view details

push time in 15 hours

push eventrust-lang-nursery/rust-toolstate

Rust Toolstate Update

commit sha e085ddc7b34c4983e96fa4dffad3af57f29a4216

(linux CI update)

view details

push time in 16 hours

push eventrust-lang-nursery/rust-toolstate

Rust Toolstate Update

commit sha 34f569da0f1e375a17f1d91d98c510b5a12a422c

(windows CI update)

view details

push time in 16 hours

more