profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/pieh/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Michal Piechowiak pieh Wroclaw, Poland Twitter: @mipiechowiak

push eventgatsbyjs/gatsby

Michal Piechowiak

commit sha f9c648f41763bc65c7af86ba25ea72faba31fd20

don't mark anything as external other than Node.js builtin modules (using node preset) when building page renderer

view details

push time in 9 hours

PullRequestReviewEvent
PullRequestReviewEvent

push eventgatsbyjs/gatsby

Michal Piechowiak

commit sha a9345555290be3edf10e0bb3b0fd78ebc3ec441e

drop obsolete snapshot file - we inline those now

view details

push time in 12 hours

push eventgatsbyjs/gatsby

Michal Piechowiak

commit sha c174c392c6d7e9b83cfb204c8ee31b0c7844dc20

update snapshots

view details

push time in 14 hours

push eventgatsbyjs/gatsby

Michal Piechowiak

commit sha b078296e9fb6f413774efd9dc3437b4745277327

add a flag for engines

view details

push time in 14 hours

PullRequestReviewEvent

Pull request review commentgatsbyjs/gatsby

chore: add release-cli for next major

     "publish-preminor": "node scripts/check-publish-access && node scripts/clear-package-dir preminor --verbose && lerna publish preminor --pre-dist-tag=next --preid=next --force-publish --allow-branch=master --message=\"chore(release): Publish next pre-minor\"",     "publish-rc": "node scripts/check-publish-access && node scripts/clear-package-dir prerelease --verbose && lerna publish prerelease --pre-dist-tag=rc --preid=rc --message=\"chore(release): Publish rc\"",     "publish-release": "node scripts/check-publish-access && node scripts/clear-package-dir patch --verbose && lerna publish patch",+    "publish-v4": "node scripts/release-cli.js publish v4",
    "publish-v4": "node scripts/release-cli.js publish",

No longer needed after https://github.com/gatsbyjs/gatsby/pull/32694/commits/ab545b322e198fbd3faa78a170b9d8697e272c81

wardpeet

comment created time in 15 hours

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentgatsbyjs/gatsby

feat: enable lmdb by default and update node

     "cross-env": "^7.0.3",     "documentation": "^13.1.0",     "enhanced-resolve": "^4.2.0",-    "lmdb-store": "~1.5.5",

as per walkthrough call - we need to revert this change

wardpeet

comment created time in 16 hours

PullRequestReviewEvent

Pull request review commentgatsbyjs/gatsby

chore: add release-cli for next major

+/**+ * Release of next major+ * ===+ *+ * What does this file do?+ * - it checks if you have publish access+ * - it checks if we have any uncommited files -- if so, we exit+ * - it cleans all non git files to make sure we have clean directory+ * - run patches in patches/v4+ * - commits the patches so lerna can publish+ * - run full boostrap+ * - Publish premajor+ * - cleanup patch commit+ */+const path = require(`path`)+const { spawn, execSync } = require(`child_process`)+const yargs = require(`yargs`)+const glob = require(`glob`)++const argv = yargs+  .command(`publish v4`, `Publishes a v4 alpha release`)+  .option(`registry`, {+    default: `https://registry.npmjs.org`,+    describe: `The NPM registry to publish to`,+    type: `string`,+  }).argv++function promiseSpawn(command, args, options) {+  return new Promise((resolve, reject) => {+    const proc = spawn(command, args, options)++    let error+    proc.on(`error`, err => {+      error = err+    })++    if (proc.stdout) {+      proc.stdout.on(`data`, data => {+        console.log(data.toString())+      })+    }+    if (proc.stderr) {+      proc.stderr.on(`data`, data => {+        console.log(`${data.toString()}`)+      })+    }++    proc.on(`close`, code => {+      if (code === 0) {+        resolve()+      } else {+        reject(error)+      }+    })+  })+}++const patchFiles = glob.sync(`patches/v4/*.patch`, {+  cwd: path.join(__dirname, `..`),+})+let commitCreated = false++;(async () => {+  try {+    // check access+    await promiseSpawn(+      process.execPath,+      [`./scripts/check-publish-access/index.js`],+      {+        cwd: path.resolve(__dirname, `../`),+      }+    )++    const bumpType = `major`+    const tagName = `alpha-v4`+    const preId = `alpha-v4`++    try {+      await Promise.all([+        promiseSpawn(`git`, [`diff`, `--quiet`]),+        promiseSpawn(`git`, [`diff`, `--quiet`, `--cached`]),+      ])+    } catch (err) {+      throw new Error(+        `Make sure to commit all your changes, before running a release`+      )+    }++    // Remove all dist files so we can recompile cleanly+    await promiseSpawn(+      process.execPath,+      [`./scripts/clear-package-dir.js`, bumpType],+      {+        cwd: path.resolve(__dirname, `../`),+        stdio: [`inherit`, `inherit`, `inherit`],+      }+    )++    console.log(` `)+    console.log(`=== APPLYING GIT PATCHES ===`)++    patchFiles.forEach(file => {+      console.log(`Applying patch ${file}`)+      try {+        execSync(`git apply ${file}`, {+          cwd: path.join(__dirname, `..`),+          stdio: `pipe`,+        })+      } catch (err) {+        console.log(err.stderr.toString())+        // eslint-disable-next-line+        throw ``+      }+    })++    console.log(`=== COMMITING PATCH FILES ===`)+    try {+      await promiseSpawn(+        `git`,+        [`commit`, `-am`, `Comitting patch files changes`],+        {+          cwd: path.resolve(__dirname, `../`),+          stdio: [`inherit`, `inherit`, `inherit`],+        }+      )+      commitCreated = true+    } catch (err) {+      // no catch+    }++    const COMPILER_OPTIONS = `GATSBY_MAJOR=4`++    console.log(` `)+    console.log(`=== BUILDING V4 ALPHA ===`)+    await promiseSpawn(`yarn`, [`bootstrap`], {+      shell: true,+      env: {+        COMPILER_OPTIONS,+      },+      stdio: [`inherit`, `inherit`, `inherit`],+    })++    console.log(` `)+    console.log(`=== PUBLISHING V4 ALPHA ===`)+    await promiseSpawn(+      process.execPath,+      [+        `./node_modules/lerna/cli.js`,+        `publish`,+        `--canary`,+        `premajor`,+        `--ignore-scripts`,+        `--exact`,+        `--preid`,+        preId,+        `--pre-dist-tag`,+        tagName,+        `--force-publish`, // publish all+        `--registry`,+        argv.registry,+      ],+      {+        cwd: path.resolve(__dirname, `../`),+        stdio: [`inherit`, `inherit`, `inherit`],+      }+    )+  } catch (err) {+    if (err) {+      console.log(err)+    }+  } finally {+    console.log(` `)+    console.log(`=== CLEANING UP ===`)+    if (commitCreated) {+      console.log(`REMOVING PATCH COMMIT`)+      try {+        await promiseSpawn(`git`, [`reset`, `--hard`, `HEAD~1`], {

whenever we use HEAD~1 type of resets we often run into problems with script resetting to weird stuff in some cases (<cough> problems with assert-changed-files script) - if it would be easy to do, maybe we could just get current commit sha (before applying patch) and reset to that sha instead of that relative HEAD stuff?

wardpeet

comment created time in 16 hours

PullRequestReviewEvent

Pull request review commentgatsbyjs/gatsby

chore: add release-cli for next major

     "publish-preminor": "node scripts/check-publish-access && node scripts/clear-package-dir preminor --verbose && lerna publish preminor --pre-dist-tag=next --preid=next --force-publish --allow-branch=master --message=\"chore(release): Publish next pre-minor\"",     "publish-rc": "node scripts/check-publish-access && node scripts/clear-package-dir prerelease --verbose && lerna publish prerelease --pre-dist-tag=rc --preid=rc --message=\"chore(release): Publish rc\"",     "publish-release": "node scripts/check-publish-access && node scripts/clear-package-dir patch --verbose && lerna publish patch",+    "publish-v4": "node scripts/release-cli.js publish v4",

If this script sole purpose is for next major releases NIT comment I have is maybe include v4 or next-major in script file name to avoid potential confusion?

wardpeet

comment created time in 16 hours

PullRequestReviewEvent

Pull request review commentgatsbyjs/gatsby

feat(babel-preset-gatsby-package): add conditional compilation plugin

 function preset(context, options = {}) {       r(`@babel/plugin-transform-runtime`),       r(`@babel/plugin-syntax-dynamic-import`),       IS_TEST && r(`babel-plugin-dynamic-import-node`),+      availableCompilerFlags.length && [+        r(`./babel-transform-compiler-flags`),+        {+          flags: parsedCompilerOptions,+          availableFlags: availableCompilerFlags,+        },+      ],

Custom plugin is fine but wouldn't https://github.com/FormidableLabs/babel-plugin-transform-define achieve same thing without us having to maintain custom babel plugin/trasnform?

wardpeet

comment created time in 16 hours

PullRequestReviewEvent

Pull request review commentgatsbyjs/gatsby

feat(gatsby): allow sites to disable the dev 404 page

 class Dev404Page extends React.Component {      this.state = {       hasMounted: false,-      showCustom404: false,+      showCustom404: process.env.GATSBY_DISABLE_CUSTOM_404 || false,

Jarmo added this helper to handle true/false strings and usual potential values for "boolean" env vars - https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-core-utils/src/is-truthy.ts

KyleAMathews

comment created time in 2 days

PullRequestReviewEvent

push eventgatsbyjs/gatsby

Michal Piechowiak

commit sha df79a79b5cd8812b4f680057f3d07cf3921cddd6

don't dedupe @hapi/topo with rollup (depending on node_modules structure it might bundle incompatible version ;/)

view details

push time in 2 days

push eventgatsbyjs/gatsby

Michal Piechowiak

commit sha 082587b2fd843316895e43f2fae75832b1c1986a

fix graphql-compose case for webpack

view details

push time in 2 days

create barnchpieh/gatsby

branch : feat/de183d-serve

created branch time in 2 days

PR opened gatsbyjs/gatsby

fix(gatsby-core-utils): avoid circular imports

Description

This just breaks circular imports happening right now - index re-exports from ./create-content-digest and create-content-digest imports from index.

+1 -1

0 comment

1 changed file

pr created time in 3 days

create barnchgatsbyjs/gatsby

branch : fix/gatsby-core-utils/circular-dep

created branch time in 3 days

create barnchgatsbyjs/gatsby

branch : feat/de183d

created branch time in 3 days

delete branch gatsbyjs/gatsby

delete branch : pqr/set-components-once-per-worker

delete time in 4 days

PR merged gatsbyjs/gatsby

fix(gatsby): load page and static queries texts in PQR only once per worker

Description

I noticed that we load components and staticQueryComponents (to get access to extracted queries) for each batch, but really we only need to do this once

+21 -20

0 comment

3 changed files

pieh

pr closed time in 4 days

push eventpieh/gatsby

Michal Piechowiak

commit sha 640cb289bb48d4e9d89feb77d241e10804d13133

fix TS (or use ts-ignore where it make some sense)

view details

Michal Piechowiak

commit sha e64923d59e56576248f9fb1c14c4c36b7ef84bf0

fix eslint (?)

view details

Michal Piechowiak

commit sha 0f50cca3b85258956afc7a341e1aa87922233083

don't use latest version selector

view details

Michal Piechowiak

commit sha c08314f57b9819adb699bb2301948d601766e2d6

ensure page-ssr dir exist before copying render-page

view details

Michal Piechowiak

commit sha e9d6d6a33246432dc220e0dcada34b35099203f6

streamline public interfaces

view details

Michal Piechowiak

commit sha f1ced5fcf2883e8029ed041a88860c66abfedfb6

provide standalone typings for generated modules to make integratation DX smoother

view details

Michal Piechowiak

commit sha 96295b92e6ac26bc60f3de7d2b138029e2f79172

adjust import path after moving file to dir

view details

push time in 4 days

PR opened gatsbyjs/gatsby

test: pin graphl-config

Description

There was a breaking change in minor graphql-config release ( see https://github.com/kamilkisiela/graphql-config/pull/699#issuecomment-889831229 ). We can't really fix it as it's transitional dependency, so trying to pin it just for e2e tests (hopefully graphql-config will handle that in some way, because right now users on Node <12.20 using yarn will get engines not satisfied errors.

+5 -1

0 comment

2 changed files

pr created time in 4 days