profile
viewpoint

odrotbohm/moduliths 427

Building modular, monolithic applications using Spring Boot

joshlong/the-spring-rest-stack 357

the deck to my talk on building more powerful REST APIs

joshlong/spring-doge 55

a look at the application development tour-de-force that is Spring Boot

joshlong/javaconfig-ftw 3

Attached to a talk that Phill Webb and I will give at SpringOne2GX 2013 in Santa Clara, California ([Building Your Java Configuration Muscle Memory](https://springone2gx.com/conference/santa_clara/2013/09/springone/event_schedule)).

philwebb/artifactory-resource 1

Artifactory Concouse Resource

issue commentspring-projects/spring-boot

Use HttpSessionOAuth2AuthorizedClientRepository instead of AuthenticatedPrincipalOAuth2AuthorizedClientRepository as bean.

@philwebb

How about create a new class HttpSessionOAuth2AuthorizedClientService, use it to replace InMemoryOAuth2AuthorizedClientService?

If you agree, I'm willing to create another PR.

chenrujun

comment created time in 18 minutes

issue commentspring-projects/spring-boot

Use HttpSessionOAuth2AuthorizedClientRepository instead of AuthenticatedPrincipalOAuth2AuthorizedClientRepository as bean.

@philwebb

Current logic is like this:

If one user login, saved some authorizedClients in InMemoryOAuth2AuthorizedClientService, then left. The the authorizedClient will never be deleted automically.

If the web application have billions of users, it will cause OOM.


IMU, with HttpSessionOAuth2AuthorizedClientRepository, when session expired, the authorizedClients will be cleaned automically.

chenrujun

comment created time in 22 minutes

issue commentspring-projects/spring-boot

Use HttpSessionOAuth2AuthorizedClientRepository instead of AuthenticatedPrincipalOAuth2AuthorizedClientRepository as bean.

Hi, @philwebb , Thank you for your response.

InMemoryOAuth2AuthorizedClientService will save all authorizedClients in memory, it may cause OOM in some case.

I created a draft PR: https://github.com/spring-projects/spring-boot/pull/24303/files

chenrujun

comment created time in 6 hours

startedoracle/coherence-visualvm

started time in 9 hours

pull request commentspring-io/artifactory-resource

Added support for HTTP proxy in the source configuration

@gabipetrovay Could you split the PR so that the documentation fix is in a separate PR, please? We'd like to keep just changes related to this change in this commit.

gabipetrovay

comment created time in 9 hours

issue commentspring-io/spring-javaformat

Automatic publishing to Gradle's Plugin repository isn't working

Will the publishing be attempted with the 0.0.26 release? If so, could you assign this issue to the milestone so that it's easier to track?

wilkinsona

comment created time in 10 hours

issue commentspring-io/spring-javaformat

Automatic publishing to Gradle's Plugin repository isn't working

I think configuring the bintray credentials should do it. If not, we'll need to investigate further.

wilkinsona

comment created time in 10 hours

push eventspring-io/spring-javaformat

Madhura Bhave

commit sha 0a04146052971323ec67281eb4800d25bd9299e8

Configure promote with bintray credentials The bintray username and api key are required when adding the attributes for the gradle plugin. Fixes gh-173

view details

push time in 10 hours

issue closedspring-io/spring-javaformat

Automatic publishing to Gradle's Plugin repository isn't working

The fix for #150 does not seem to have worked. The plugin isn't in the Portal and the attribute isn't set in Bintray.

closed time in 10 hours

wilkinsona

issue commentspring-projects/spring-boot

Document server.error properties

The server.error properties are documented in the Common Application Properties appendix: https://docs.spring.io/spring-boot/docs/current/reference/html/appendix-application-properties.html#server-properties. It would be useful to link to these properties from the Error Handling section.

cdalexndr

comment created time in 11 hours

issue commentspring-projects/spring-boot

Maven plugin build-image creator step fails in Bitbucket pipelines

@andrey-bushik Is the error you are getting exactly the same as shown in the original issue? Can you show the output from the bitbucket docker logs and the Spring Boot plugin?

michalrames

comment created time in 11 hours

issue commentspring-projects/spring-boot

bootBuildImage to support DOCKER_HOST with ssh://

You are correct @ruXlab, the SSH protocol is not currently supported for communicating with a Docker host using the Gradle or Maven plugin. When a URL is provided by DOCKER_HOST only the host and port fields of the address are used, and the transport is always assumed to be TCP.

Supporting SSH requires an additional layer on top of the TCP transport as well as some additional configuration to provide a private authentication key. We can consider adding this support in a future Spring Boot release.

ruXlab

comment created time in 11 hours

issue commentspring-projects/spring-boot

tomcat ssl jks keystore password not longer works after upgrade to 2.3.6

Up to 2.3.5 version either key-password or key-store-password settings can be used for both store and key password, and It still works the same way in Netty.

The Netty connection setup in Spring Boot uses the server.ssl.key-store-password property as-is, allowing it to be null if not set. server.ssl.key-password is not used for the store password. The inverse is true though - if server.ssl.key-password is not set then server.ssl.key-store-password is used for the key password.

The difference in 2.3.6 is that a value of null for server.ssl.key-store-password will result in the Tomcat code using changeit for the key store password instead of using null as the default. After some further team discussion, we believe this is the correct behavior for Spring Boot.

Right now, just replacing the key-password with key-store-password (in a couple hundred yaml files) solves our issue.

Another option is to implement your own TomcatConnectorCustomizer and set any keystore fields in code, if that's easier than changing yaml files.

	@Configuration
	public class TomcatConfiguration {
		@Bean
		public TomcatConnectorCustomizer customizer() {
			return connector -> {
				AbstractHttp11JsseProtocol<?> protocol = (AbstractHttp11JsseProtocol<?>) connector.getProtocolHandler();
				protocol.setKeystorePass(/* password value */);
				protocol.setKeyPass(/* password value */);
			};
		}
	}
alexmond

comment created time in 12 hours

issue commentspring-projects/spring-boot

Enhance Artemis jms auto configuration

FYI, I just sent #24302 to implement this functionality.

pax95

comment created time in 12 hours

issue commentspring-io/artifactory-resource

Provide an option to skip ssl for connections to the artifactory server

I've created a new issue for that. We can keep this one for adding the option to skip ssl.

gberche-orange

comment created time in 12 hours

push eventspring-io/artifactory-resource

Madhura Bhave

commit sha 6a9a155a97cb7687bd5adc2c412d3ff47b933ccb

Upgrade to JUnit 5 Closes gh-59

view details

push time in 12 hours

pull request commentspring-projects/spring-boot

Implement URL support for ActiveMQ Artemis

@jbertram Thank you for signing the Contributor License Agreement!

jbertram

comment created time in 12 hours

pull request commentspring-projects/spring-boot

Implement URL support for ActiveMQ Artemis

@jbertram Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

jbertram

comment created time in 12 hours

PR opened spring-projects/spring-boot

Implement URL support for ActiveMQ Artemis

See gh-10739

<!-- Thanks for contributing to Spring Boot. Please review the following notes before submitting you pull request.

Please submit only genuine pull-requests. Do not use this repository as a GitHub playground.

Security Vulnerabilities

STOP! If your contribution fixes a security vulnerability, please do not submit it. Instead, please head over to https://pivotal.io/security to learn how to disclose a vulnerability responsibly.

Dependency Upgrades

Please do not open a pull request for a straightforward dependency upgrade (one that only updates the version property). We have a semi-automated process for such upgrades that we prefer to use. However, if the upgrade is more involved (such as requiring changes for removed or deprecated API) your pull request is most welcome.

Describing Your Changes

If, having reviewed the notes above, you're ready to submit your pull request, please provide a brief description of the proposed changes. If they fix a bug, please describe the broken behaviour and how the changes fix it. If they make an enhancement, please describe the new functionality and why you believe it's useful. If your pull request relates to any existing issues, please reference them by using the issue number prefixed with #. -->

+80 -17

0 comment

4 changed files

pr created time in 12 hours

issue closedspring-projects/spring-boot

Contributing and unit tests

The "Code Conventions and Housekeeping" section of CONTRIBUTING.adoc says, "A few unit tests would help a lot as well -- someone has to do it."

Is there a standardized way of running such unit tests, for example, the ones in the org.springframework.boot.actuate.endpoint.EndpointIdTests class?

I think there would be value in addressing that question right there in CONTRIBUTING.adoc.

If I can wish, I wish for something as convenient as ./gradlew test --tests EndpointIdTests.

Thank you for your thought and consideration. Spring Boot is a great help to all the world.

closed time in 12 hours

JimStockwell

issue commentspring-projects/spring-boot

Contributing and unit tests

This issue is now superseded by #24301.

JimStockwell

comment created time in 12 hours

PR opened spring-projects/spring-boot

Document how to run unit tests

Explicitly show how to run unit tests and checkstyle.

+6 -0

0 comment

1 changed file

pr created time in 12 hours

issue commentspring-projects/spring-boot

.env file support for `spring.config.import`

@scottfrederick I mad a mistake about .env file format, and key should be uppercase like following:

KEY=xxx
DATABASE_URL=xxxxx

Some frameworks use multi .env files like Spring Boot profile, for example Vue.js CLI.

.env               
.env.local         
.env.[mode]   

I'm not sure some developers use following style or not.

.env
local.env
xxxx.env

Maybe Spring Boot should support to load .env.dev or dev.env styles by profile name.

linux-china

comment created time in 14 hours

issue commentspring-projects/spring-boot

Contributing and unit tests

Thank you @snicoll , that's just what I'm looking for. But now I discover that although the right way is simple, it doesn't work for me. (Or I'm missing something else.)

Sorry to turn this into a debugging session. Can you help me here? When I try the following:

./gradlew check test --tests EndpointIdTests

I get back:

Execution failed for task ':spring-boot-project:spring-boot:test'.
> No tests found for given includes: [EndpointIdTests](--tests filter)

I'm not familiar with Gradle, so I won't be surprised if that's a big part of my problem. Is there an obvious thing I'm doing wrong? EndpointIdTests seems like a valid unit test to me. It's in spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/endpoint/EndpointIdTests.java.

Thanks again.

JimStockwell

comment created time in 14 hours

IssuesEvent

issue commentspring-projects/spring-boot

Configure memory leak detection for Netty

@JamesChenX Thanks for the comment, we'll reconsider this. This is indeed a good use case.

@violetagg I'm wondering if this is enough, or if we should make this feature more general. When dealing with memory leak issues with Netty, are there other options to enable? Typically, when working on a memory leak report - what would you ask developers to enable in their applications to collect useful information? Are specific logs enabled?

I'm trying to figure out if changing the Netty flag is enough or if we can do something more here. Thanks!

bclozel

comment created time in 14 hours

issue closedspring-projects/spring-boot

Support configuring 2 ports for HTTP(S) with WebFlux and Reactor Netty

It is documented how to use 2 ports for e.g. HTTP and HTTPS with Spring WebMVC. It would be fine also to have an according section for Spring WebFlux.

closed time in 14 hours

juergenzimmermann
more