profile
viewpoint
Phil Hansch phansch @esanum Berlin https://phansch.net Rust @rust-lang (Clippy) & Ruby @esanum

esanum/excel_column_diff 2

Quickly get a diff of columns in two excel documents

beatontherat/HIT 1

to be added

esanum/eventbrite 1

eventbrite ruby gem for v3 API.

esanum/ajax-datatables-rails 0

A wrapper around DataTable's ajax methods that allow synchronization with server-side pagination in a Rails app

esanum/base64image 0

Base64Image Plugin for CKEditor 4 - Adds images from local client as base64 string into the source without server side processing. You can also add external image urls into the source.

esanum/docker-alpine-pgloader 0

Builds pgloader on alpine

esanum/docker-elk 0

The ELK stack powered by Docker and Compose.

esanum/docker-ruby-mysql 0

Basic Docker container for running our Rails apps

esanum/shared_ruby_config 0

Dangerfile and base .rubocop.yml for all our ruby projects

delete branch phansch/rust-clippy

delete branch : remove-symbol-reexport

delete time in 10 hours

pull request commentrust-lang/rust-clippy

Remove old Symbol reexport

@flip1995 Hm, I can. In fact it has been happening for a couple of months.. I just ignored it because CI was always passing and I never had the time to investigate properly :neutral_face:

Maybe running cargo update will make it reproducible? I think it has something to with compiletest_rs switching from the test crate to the tester crate some time ago.

phansch

comment created time in 2 days

push eventphansch/rust-clippy

Philipp Hansch

commit sha bb6e857980748b000ba3b88d125c6b29aced0693

fmt

view details

push time in 2 days

PR opened rust-lang/rust-clippy

Remove old Symbol reexport

I couldn't really tell what it was meant to improve. It seems more clear without the renaming to Name?

changelog: none

+28 -36

0 comment

6 changed files

pr created time in 3 days

create barnchphansch/rust-clippy

branch : remove-symbol-reexport

created branch time in 3 days

issue commentrust-lang/rust-clippy

Run clippy panic

It's possible that this was fixed in Rust 1.45.1. It seems to have been a rustc issue? https://github.com/rust-lang/rust/issues/68730

@emacsist Could you upgrade to Rust 1.45.1 and check if the panic still happens?

emacsist

comment created time in 3 days

Pull request review commentrust-lang/rust-clippy

WIP needless_collect: catch x: Vec<_> = iter.collect(); x.into_iter() ...

 fn check_needless_collect<'tcx>(expr: &'tcx Expr<'_>, cx: &LateContext<'tcx>) {     } } +fn check_needless_collect_indirect_usage<'tcx>(expr: &'tcx Expr<'_>, cx: &LateContext<'tcx>) {+    if let ExprKind::Block(ref block, _) = expr.kind {+        for ref stmt in block.stmts {+            if_chain! {+                if let StmtKind::Local(+                    Local { pat: Pat { kind: PatKind::Binding(_, _, ident, .. ), .. },+                    init: Some(ref init_expr), .. }+                ) = stmt.kind;+                if let ExprKind::MethodCall(ref method_name, _, &[ref iter_source], ..) = init_expr.kind;+                if method_name.ident.name == sym!(collect) && match_trait_method(cx, &init_expr, &paths::ITERATOR);+                if let Some(ref generic_args) = method_name.args;+                if let Some(GenericArg::Type(ref ty)) = generic_args.args.get(0);+                if let ty = cx.typeck_results().node_type(ty.hir_id);+                if is_type_diagnostic_item(cx, ty, sym!(vec_type)) ||+                    is_type_diagnostic_item(cx, ty, sym!(vecdeque_type)) ||+                    match_type(cx, ty, &paths::LINKED_LIST);+                if let Some(iter_calls) = detect_iter_and_into_iters(block, *ident);+                if iter_calls.len() == 1;+                then {+                    // Suggest replacing iter_call with iter_replacement, and removing stmt+                    let iter_call = &iter_calls[0];+                    span_lint_and_then(+                        cx,+                        NEEDLESS_COLLECT,+                        stmt.span.until(iter_call.span),+                        NEEDLESS_COLLECT_MSG,+                        |diag| {+                            let iter_replacement = format!("{}{}", Sugg::hir(cx, iter_source, ".."), iter_call.get_iter_method(cx));+                            diag.multipart_suggestion(+                                iter_call.get_suggestion_text(),+                                vec![+                                    (stmt.span, String::new()),+                                    (iter_call.span, iter_replacement)+                                ],+                                Applicability::MachineApplicable,// MaybeIncorrect,+                            ).emit();+                        },+                    );+                }+            }+        }+    }+}++struct IterFunction {+    func: IterFunctionKind,+    span: Span,+}+impl IterFunction {+    fn get_iter_method(&self, cx: &LateContext<'_>) -> String {+        match &self.func {+            IterFunctionKind::IntoIter => String::new(),+            IterFunctionKind::Len => String::from(".count()"),+            IterFunctionKind::IsEmpty => String::from(".next().is_none()"),+            IterFunctionKind::Contains(span) => format!(".any(|x| x == {})", snippet(cx, *span, "..")),+        }+    }+    fn get_suggestion_text(&self) -> &'static str {+        match &self.func {+            IterFunctionKind::IntoIter => {+                "Use the original Iterator instead of collecting it and then producing a new one"+            },+            IterFunctionKind::Len => {+                "Take the original Iterator's count instead of collecting it and finding the length"+            },+            IterFunctionKind::IsEmpty => {+                "Check if the original Iterator has anything instead of collecting it and seeing if it's empty"+            },+            IterFunctionKind::Contains(_) => {+                "Check if the original Iterator contains an element instead of collecting then checking"+            },+        }+    }+}+enum IterFunctionKind {+    IntoIter,+    Len,+    IsEmpty,+    Contains(Span),+}++struct IterFunctionVisitor {+    uses: Vec<IterFunction>,+    seen_other: bool,+    target: Ident,+}+impl<'tcx> Visitor<'tcx> for IterFunctionVisitor {+    fn visit_expr(&mut self, expr: &'tcx Expr<'tcx>) {+        // Check function calls on our collection+        if_chain! {+            if let ExprKind::MethodCall(method_name, _, ref args, _) = &expr.kind;+            if let Some(Expr { kind: ExprKind::Path(QPath::Resolved(_, ref path)), .. }) = args.get(0);+            if let &[name] = &path.segments;+            if name.ident == self.target;+            then {+                let into_iter = sym!(into_iter);+                let len = sym!(len);+                let is_empty = sym!(is_empty);+                let contains = sym!(contains);+                match method_name.ident.name {+                    name if name == into_iter => self.uses.push(

Ah.. function calls are not allowed in patterns. At least for into_iter we can use the pre-interned symbol from rustc (will need a use rustc_span::symbol::sym):

https://github.com/rust-lang/rust/blob/46cf80dc1a75ad27f67e79f73fec371a16762494/src/librustc_span/symbol.rs#L594

                    sym::into_iter => self.uses.push(
JarredAllen

comment created time in 3 days

Pull request review commentrust-lang/rust-clippy

WIP needless_collect: catch x: Vec<_> = iter.collect(); x.into_iter() ...

 fn check_needless_collect<'tcx>(expr: &'tcx Expr<'_>, cx: &LateContext<'tcx>) {     } } +fn check_needless_collect_indirect_usage<'tcx>(expr: &'tcx Expr<'_>, cx: &LateContext<'tcx>) {+    if let ExprKind::Block(ref block, _) = expr.kind {+        for ref stmt in block.stmts {+            if_chain! {+                if let StmtKind::Local(+                    Local { pat: Pat { kind: PatKind::Binding(_, _, ident, .. ), .. },+                    init: Some(ref init_expr), .. }+                ) = stmt.kind;+                if let ExprKind::MethodCall(ref method_name, _, &[ref iter_source], ..) = init_expr.kind;+                if method_name.ident.name == sym!(collect) && match_trait_method(cx, &init_expr, &paths::ITERATOR);+                if let Some(ref generic_args) = method_name.args;+                if let Some(GenericArg::Type(ref ty)) = generic_args.args.get(0);+                if let ty = cx.typeck_results().node_type(ty.hir_id);+                if is_type_diagnostic_item(cx, ty, sym!(vec_type)) ||
                if is_type_diagnostic_item(cx, ty, sym::vec_type) ||
JarredAllen

comment created time in 3 days

Pull request review commentrust-lang/rust-clippy

WIP needless_collect: catch x: Vec<_> = iter.collect(); x.into_iter() ...

+// run-rustfix++#[allow(unused)]

Did you mean this to be #![allow(unused)]?

JarredAllen

comment created time in 3 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 0a104c49b4e1586d0c03b0cf36ce48a71b23e535

[setup] Install latest stable git via ppa

view details

push time in 6 days

startedgithub/renaming

started time in 6 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 73864132bab98cce0a5a6e91eb8c32a4ba7d94cc

[git] Make `main` the default branch for new repos

view details

push time in 6 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 73a85bffc68d35048ab272a33ab1a0d4e906dfb9

Fix incorrect xrandr config for work setup

view details

push time in 6 days

pull request commentrust-lang/rust-clippy

Stable sort primitive

Sorry again for the silence, got some IRL stuff to deal with, so I'm handing this off to someone else :blue_heart:

r? @Manishearth

JarredAllen

comment created time in 7 days

pull request commentrust-lang/rust-clippy

Add suggestion for `iter_skip_next` lint

@bors r+ thanks!

dima74

comment created time in 7 days

pull request commentrust-lang/rust-clippy

Basic instruction for new contributors

LGTM, thanks!

@bors r+

flip1995

comment created time in 7 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 7bad3e7ea63af72ec761d7daae446a723697395b

Add gpg-agent comments

view details

push time in 7 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 9f0f202053a6d7311f29c5bd61f1cb8b843908e4

[ansible] procrastination: Make sure hosts_base is created

view details

push time in 11 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 5d8180c92b8eaa42b89587dfe5a0e828e51c2b65

Startup: Also start mpd

view details

push time in 11 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 7c4a4737bb7109f715973fe5e0b32452fde66616

Fix setting of wallpaper

view details

push time in 13 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 2fffa006f8a8ff244628792efbc8ff38cb4aca04

Add startup script to replace xinitrc This script is executed from i3. The stuff was originally in xinitrc because I thought it would be nice to have it independent from the window manager. However, I've been using i3 for a couple years now and have no plans of replacing it. Additionally, one could argue that a shell script is even more independent from the window manager that xinitrc.

view details

Philipp Hansch

commit sha 4861d74daee13437ef805354579f9ec54bfb1dab

Update gitignore

view details

push time in 14 days

push eventphansch/dotfiles

Philipp Hansch

commit sha c6441ad4c749f8cdf2cd9dcb1938a1cc750a893c

off script: Don't run suspend from script anymore For some reason slock and suspend don't work together anymore in Ubuntu 20. When I lock first, it doesn't suspend. When I suspend first, it doesn't lock.

view details

push time in 14 days

pull request commentrust-lang/rust-clippy

Stable sort primitive

Sorry for the silence and thanks for your PR - I'll get back to reviewing by tomorrow =)

JarredAllen

comment created time in 15 days

startedNerdyPepper/dijo

started time in 16 days

pull request commentrust-lang/rust-clippy

Panic multiple args

LGTM, thanks!

@bors r+

JarredAllen

comment created time in 19 days

pull request commentrust-lang/rust-clippy

Fix deploy script for beta deployment

@bors r+

flip1995

comment created time in 19 days

Pull request review commentrust-lang/rust-clippy

Fix deploy script for beta deployment

 git config user.name "GHA CI" git config user.email "gha@ci.invalid"  if [[ -n $TAG_NAME ]]; then+  # track files, so that the following check works+  git add --intent-to-add "$TAG_NAME"

til about --intent-to-add :exploding_head:

flip1995

comment created time in 19 days

push eventphansch/rust-clippy

flip1995

commit sha f7acea2683c6124854bfe20e7127e4dfba344d3e

Register redundant_field_names and non_expressive_names as early passes

view details

flip1995

commit sha 485229c4a3d6a2fbe40f5a6976a33144a27497c6

Fix fallout in redundant_field_names

view details

flip1995

commit sha efd3dcff97f67f376e354c047133ce9044c52991

Fix fallout in similar_names

view details

Eduardo Broto

commit sha bb37a0f948b02e6434dbe3ea615960052d37f784

Avoid triggering similar names on code from expansion

view details

flip1995

commit sha 6f25adbd5a1600653e8edf8de7135c397d73c07a

Merge commit '2ca58e7dda4a9eb142599638c59dc04d15961175' into clippyup

view details

Nicholas Nethercote

commit sha f2f99be2ff619aeb67259b73b51992d026fc11fe

Remove lots of `Symbol::as_str()` calls. In various ways, such as changing functions to take a `Symbol` instead of a `&str`.

view details

Bastian Kauschke

commit sha 29de25b8a26aae3d37d935c437f5afb69f7ccbb2

const_eval_resolve

view details

Bastian Kauschke

commit sha c5b9463d266a084f40ccec85a7587a8c375c179b

improve naming

view details

Bastian Kauschke

commit sha bf3104ec24f788538fd1db84bf3b8819c303418c

WithOptConstParam::dummy -> WithOptConstParam::unknown

view details

Leo Meira Vital

commit sha a0640457a912720a5473d7feff40576a2f97df1e

Removing snippet from SHADOW_UNRELATED message.

view details

flip1995

commit sha d9bf74e2f284ccf0f2a49d5d4784c2f74d58d210

Merge remote-tracking branch 'upstream/master' into rustup

view details

bors

commit sha b3614b42d506d1707379cc978f41931f1872273f

Auto merge of #5802 - flip1995:rustup, r=flip1995 Rustup r? @ghost changelog: none

view details

bors

commit sha 934944186366959b53df5948b25b1cfabd6c71d3

Auto merge of #5788 - Leulz:shadow-unrelated-fix-rhs, r=flip1995 Removing RHS snippet from SHADOW_UNRELATED message. Fixes #5703 I am not sure if I reinvented the wheel here, but I could not really find a snippet function that did this truncation, so I created the function. Please tell me if there was a more obvious way to do this, I am new here. :smile: changelog: Truncates multi-line RHS in shadow_unrelated message if it has more than 5 lines.

view details

flip1995

commit sha 9aa343594f102d0ba93d0b5880429c3bc07e6542

Merge remote-tracking branch 'upstream/rust-1.44.1' into backport_remerge

view details

bors

commit sha bb67423577de689256483881ee9a8a0df34f7cd7

Auto merge of #5804 - flip1995:backport_remerge, r=flip1995 Backport remerge rust-1.44.1 r? @ghost changelog: none

view details

push time in 19 days

push eventphansch/dotfiles

Philipp Hansch

commit sha f8a00f533b62ba3153821d09ec1c2b0256b894eb

[tmux] Make config work with tmux >= 3.0

view details

push time in 19 days

push eventphansch/dotfiles

Philipp Hansch

commit sha f330dedf8c496c6f8d3c7d323941189da1f81295

Use correct gpg binary on Ubuntu 20.04

view details

push time in 19 days

pull request commentrust-lang/rust-clippy

Fix deploy script for beta deployment

This doesn't have to wait for anything on the rustc side, correct? If so, then r=me

flip1995

comment created time in 19 days

push eventphansch/dotfiles

Philipp Hansch

commit sha e1a9d363a1036181295e0ca6ececabf1f6b44e3a

Disable zsh-autosuggestions for now

view details

push time in 20 days

issue openedphansch/dotfiles

Move xinit startup stuff to a script that is called from i3config

By default on Ubuntu 20.04, my local xinitrc doesn't seem to get executed anymore, so I'm going to move most of the things to a script that is called via i3config.

created time in 20 days

push eventphansch/dotfiles

Philipp Hansch

commit sha ee600f14f2f5e42de74667cdddc0ff4f7b549a58

[screenlayout] add home_with_ext

view details

push time in 20 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 4d1da76bbdc5c87dc2f2c9d966e29f5ac10dc523

Add mpd/ncmpcpp config Used to use this a few years ago, starting to use it again.

view details

push time in 20 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 056b73b5c970881373555398277ce0292c6b6b93

Ansible: Install krita

view details

push time in 20 days

delete branch phansch/pomo-break

delete branch : add-release-workflow

delete time in 21 days

push eventphansch/pomo-break

Philipp Hansch

commit sha 555393049ae319c5419edfea7d7ffc3fafe86d2d

Add release workflow

view details

Phil Hansch

commit sha 0b9858a3f84e642778de18bf3e296a498b541503

Merge pull request #19 from phansch/add-release-workflow Add release workflow

view details

push time in 21 days

PR merged phansch/pomo-break

Add release workflow

Closes #18

+28 -0

0 comment

1 changed file

phansch

pr closed time in 21 days

issue closedphansch/pomo-break

Set up release process

When I publish a new release with cargo release, it should create a new GH release, but no crates.io release. When the tag is pushed, it should build a release version of the crate and strip the binary as well.

closed time in 21 days

phansch

PR opened phansch/pomo-break

Add release workflow

Closes #18

+28 -0

0 comment

1 changed file

pr created time in 21 days

create barnchphansch/pomo-break

branch : add-release-workflow

created branch time in 21 days

release phansch/pomo-break

v0.1.0

released time in 21 days

created tagphansch/pomo-break

tagv0.1.0

A cross platform pomodoro and break timer

created time in 21 days

push eventphansch/pomo-break

Philipp Hansch

commit sha ad17425e399215e5c241626295c438400a48fc1e

(cargo-release) start next development iteration 0.1.1-alpha.0

view details

push time in 21 days

issue closedesanum/excel_column_diff

Setup travis slack notifications properly

Since this repo is public we need to add the encrypted slack token to the travis secret environment variables

closed time in 21 days

phansch

push eventphansch/rust-clippy

Azhng

commit sha dfecaef91478e1b529962bad3c8dffe0a95f9450

typeck: adding type information to projection This commit modifies the Place as follow: * remove 'ty' from ProjectionKind * add type information into to Projection * replace 'ty' in Place with 'base_ty' * introduce 'ty()' in `Place` to return the final type of the `Place` * introduce `ty_before_projection()` in `Place` to return the type of a `Place` before i'th projection is applied Closes https://github.com/rust-lang/project-rfc-2229/issues/5

view details

JarredAllen

commit sha bf48a2d50d82cccac58d7c4c73700eaf66926aee

Lint for if let Some(x) = ... instead of Option::map_or

view details

JarredAllen

commit sha 82f8d4d6f1645dd08b107c3ead9155412637739b

Stop linting on macros and correctly use braces for constructs

view details

JarredAllen

commit sha b85796fe3613e20a4af21933783a3d993bb8d7ad

Properly parenthesize to avoid operator precedence errors

view details

JarredAllen

commit sha 88c8afdddff07adeff4c87431cbe8bc630a36d68

Handle ref, mut, &, and &mut on the option

view details

JarredAllen

commit sha f73b455b99694fbc5ddec38317f705f546729db2

Refactoring

view details

JarredAllen

commit sha 7c4de9d3dee3a7e16118df5c1cd2080af7350d98

Refactoring pt. 2

view details

JarredAllen

commit sha 5e20475e47d3db1d32a7649a7c3a107caba32a14

Don't lint if contains a macro

view details

JarredAllen

commit sha 5150277a4f765bb113e163adc7eb495dcbb57129

Used clippy to clean itself

view details

JarredAllen

commit sha 93f0f5d37b45c648aebf87fe7e7379599ba3e726

Last few tweaks

view details

JarredAllen

commit sha ccb999851aaa4d3e9cd97110bd6523a6c3df46fd

Fix compile error from library change

view details

JarredAllen

commit sha 6ce981225b73d6c3514b0abb759a5282521a17d9

Clean existing lint code to match new lint

view details

JarredAllen

commit sha 6e2d55c8db04a80f9c217f2089066b29302f62a9

Update compile-test to follow new lint

view details

JarredAllen

commit sha 1c32263176d95ae47928d1955e44a4315ffcea2d

Formatted updates to lints

view details

JarredAllen

commit sha c8f700ea697f74ef8f86891b050c859cf457e3ab

Fixed compile errors

view details

Mark Rousskov

commit sha 3503247c11d80f0f17a36083878e6df114004d10

Shrink ParamEnv to 16 bytes

view details

bors

commit sha ac856922f80e9ef8cd95c3004699e4bc8fa0c978

Auto merge of #5301 - JarredAllen:option_if_let_else, r=flip1995 Suggest `Option::map_or`(_else) for `if let Some { y } else { x }` Fixes #5203 There are two issues with this code that I have noticed: - Use of `Option::map_or` causes it to always evaluate the code in the else block. If that block is computationally expensive or if it updates some state (such as getting the next value from an iterator), then this change would cause the code to behave differently. In either of those circumstances, it should suggest Option::map_or_else, which takes both cases as a closure and runs one. However, I don't know how to check if the expression would change some state, so I left the lint's applicability as MaybeIncorrect. - There are lints which can trigger on specific sub-cases of this lint (`if_let_some_result`, `question_mark`, and `while_let_loop`) and suggest different changes (usually better ones because they're more specific). Is this acceptable for clippy to give multiple suggestions, or should I have the code check if those other lints trigger and then not trigger this lint if they do? changelog: Add lint [`option_if_let_else`]

view details

Thiago Arrais

commit sha a6f1af75d71fcf8e029b78142370e7563798c503

Lint for x.powi(2) => x * x

view details

Thiago Arrais

commit sha f62798454c8a7f9f2c3e87e0a913b3bd79b6d2ed

Lint (x * x + y * y).sqrt() => x.hypot(y)

view details

robojumper

commit sha 2e8a1be444afc6a9b5137d3e7e4fdcfcb1f89e0d

new lint: match_like_matches_macro

view details

push time in 21 days

startedkettle11/kApp

started time in 21 days

push eventphansch/dotfiles

Philipp Hansch

commit sha f85578921a2e9ec3944520acd68a76a57927bac3

Fix shellcheck warning

view details

push time in 21 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 7d684a9325eae99c8ed3d863585e528ee1ebb836

Setup: Really make sure that git stash pop always returns 0

view details

push time in 21 days

push eventphansch/dotfiles

Philipp Hansch

commit sha ef411ccf396f2dcc11626c60119aa8b89d75890f

Setup: Don't abort script if `git stash pop` fails

view details

push time in 21 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 9b0378949679849cf70252dbbe68f13f62fb021b

Ansible: Add missing become

view details

push time in 21 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 00cc74ba4a841a1860e8f9f392bf2005e170ea40

Ansible: Add missing `state: present`

view details

push time in 21 days

push eventphansch/dotfiles

Philipp Hansch

commit sha d9861ed402eeca6bd96addbcb29958589782989c

[setup] Fix conditional

view details

push time in 21 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 4485049833d3033794045467aa3d0ee40ef8e1fc

Another setup script fix

view details

push time in 21 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 0289eee1927ebaf4f23a44aa27d3229258b4d0ce

Fix setup script

view details

push time in 21 days

delete branch phansch/dotfiles

delete branch : ubuntu20

delete time in 21 days

issue closedphansch/dotfiles

Make CI pass under Ubuntu 20.04

CI is currently failing because the Docker container is using the ubuntu:latest tag. Eventually I want to upgrade as well, so it would be good to have CI working before that.

closed time in 21 days

phansch

push eventphansch/dotfiles

Philipp Hansch

commit sha 566134874df4a110848461fc51ba1203da966ed7

Make CI work under Ubuntu 20

view details

Phil Hansch

commit sha 8431152e8c09e634051252227e95903935c7bf33

Merge pull request #134 from phansch/ubuntu20 Make CI work under Ubuntu 20

view details

push time in 21 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 566134874df4a110848461fc51ba1203da966ed7

Make CI work under Ubuntu 20

view details

push time in 21 days

push eventphansch/dotfiles

Philipp Hansch

commit sha be65ee22196382cce449792c92810289ca855c62

Replace shutter with xfce4-screenshooter

view details

Philipp Hansch

commit sha 29c9dd92353bf0f0291f75845b554f0e134c572f

s/master/main

view details

Philipp Hansch

commit sha 7744efa83c5e657ef83bf187bdf9330c2f545e96

Enforce python3 usage by ansible

view details

Philipp Hansch

commit sha 2575bba6a61af55540380115a13630003cb59aa6

Set CI env variable

view details

Philipp Hansch

commit sha fbc92beeaa605b64e1bd0b4bf54e2914e72263a8

Install vint in container

view details

Philipp Hansch

commit sha bdd46a150ed9d37fb83b61aa7b4c13434ae5d8b4

Remove again

view details

Philipp Hansch

commit sha caf3ead5446df460148fb1411017ff614b6a180a

try

view details

Philipp Hansch

commit sha 8d0de4f5e2d5fdb64d0da8a9da4906e5f325ec09

Fix yamllint

view details

Philipp Hansch

commit sha 127cb8b7a5b5205808980ba28a73b4b214aa0fec

Fix shellcheck

view details

Philipp Hansch

commit sha 75e258987402e0be69c39ac1056ff2d19e7ec476

Disable vagrant for now

view details

Philipp Hansch

commit sha f9e6b1432ba72e7f6d683a348d565dc3e60d32da

Don't hardcode user

view details

Philipp Hansch

commit sha 1f5df53aee03bb3a99808398aa1ac8d533cfbdbb

Disable ruby playbook properly

view details

Philipp Hansch

commit sha 0586240679e9be5c484b6ef35ee2b25c86beeb47

Try fixing test/ansible

view details

Philipp Hansch

commit sha d47664ac01823fc8d636dbca44472532f2364eb8

Remove ruby playbooks

view details

Philipp Hansch

commit sha 9ac1705796e81e0ac49b885b1eb7606d421d349a

Only run Ansible syntax check on yml files?

view details

Phil Hansch

commit sha dc411c37115b53638903f875345e8a97274da537

Merge pull request #135 from phansch/shutter

view details

Philipp Hansch

commit sha ef214d352a82c36f9bd88a36ffea40db8c3926ba

Make CI work under Ubuntu 20

view details

Philipp Hansch

commit sha 4d7704c5c6805f6e5afba8755cdf9eba2ff1ee3b

Avoid readline prompts on CI

view details

Philipp Hansch

commit sha 7edfb199772454bcfedf602ebc55275fe032c530

try

view details

Philipp Hansch

commit sha 4283a5f6477d7b7b8324e214b30919c533c512c6

Fix backup cron

view details

push time in 21 days

delete branch phansch/dotfiles

delete branch : shutter

delete time in 21 days

push eventphansch/dotfiles

Philipp Hansch

commit sha be65ee22196382cce449792c92810289ca855c62

Replace shutter with xfce4-screenshooter

view details

Philipp Hansch

commit sha 29c9dd92353bf0f0291f75845b554f0e134c572f

s/master/main

view details

Philipp Hansch

commit sha 7744efa83c5e657ef83bf187bdf9330c2f545e96

Enforce python3 usage by ansible

view details

Philipp Hansch

commit sha 2575bba6a61af55540380115a13630003cb59aa6

Set CI env variable

view details

Philipp Hansch

commit sha fbc92beeaa605b64e1bd0b4bf54e2914e72263a8

Install vint in container

view details

Philipp Hansch

commit sha bdd46a150ed9d37fb83b61aa7b4c13434ae5d8b4

Remove again

view details

Philipp Hansch

commit sha caf3ead5446df460148fb1411017ff614b6a180a

try

view details

Philipp Hansch

commit sha 8d0de4f5e2d5fdb64d0da8a9da4906e5f325ec09

Fix yamllint

view details

Philipp Hansch

commit sha 127cb8b7a5b5205808980ba28a73b4b214aa0fec

Fix shellcheck

view details

Philipp Hansch

commit sha 75e258987402e0be69c39ac1056ff2d19e7ec476

Disable vagrant for now

view details

Philipp Hansch

commit sha f9e6b1432ba72e7f6d683a348d565dc3e60d32da

Don't hardcode user

view details

Philipp Hansch

commit sha 1f5df53aee03bb3a99808398aa1ac8d533cfbdbb

Disable ruby playbook properly

view details

Philipp Hansch

commit sha 0586240679e9be5c484b6ef35ee2b25c86beeb47

Try fixing test/ansible

view details

Philipp Hansch

commit sha d47664ac01823fc8d636dbca44472532f2364eb8

Remove ruby playbooks

view details

Philipp Hansch

commit sha 9ac1705796e81e0ac49b885b1eb7606d421d349a

Only run Ansible syntax check on yml files?

view details

Phil Hansch

commit sha dc411c37115b53638903f875345e8a97274da537

Merge pull request #135 from phansch/shutter

view details

push time in 21 days

PR merged phansch/dotfiles

Replace shutter with xfce4-screenshooter

Shutter is not included in Ubuntu 20 anymore.

cc #134, #125

+29 -19

0 comment

11 changed files

phansch

pr closed time in 21 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 9ac1705796e81e0ac49b885b1eb7606d421d349a

Only run Ansible syntax check on yml files?

view details

push time in 21 days

push eventphansch/dotfiles

Philipp Hansch

commit sha d47664ac01823fc8d636dbca44472532f2364eb8

Remove ruby playbooks

view details

push time in 22 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 0586240679e9be5c484b6ef35ee2b25c86beeb47

Try fixing test/ansible

view details

push time in 22 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 1f5df53aee03bb3a99808398aa1ac8d533cfbdbb

Disable ruby playbook properly

view details

push time in 22 days

push eventphansch/dotfiles

Philipp Hansch

commit sha f9e6b1432ba72e7f6d683a348d565dc3e60d32da

Don't hardcode user

view details

push time in 22 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 75e258987402e0be69c39ac1056ff2d19e7ec476

Disable vagrant for now

view details

push time in 22 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 127cb8b7a5b5205808980ba28a73b4b214aa0fec

Fix shellcheck

view details

push time in 22 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 8d0de4f5e2d5fdb64d0da8a9da4906e5f325ec09

Fix yamllint

view details

push time in 22 days

push eventphansch/dotfiles

Philipp Hansch

commit sha c6009372457bfcc1fa1716972747a8a9a3be8738

Fix yamllint

view details

push time in 22 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 4947135e9002b5a66d719814f9ff325f62ab3aef

Fix yamllint

view details

push time in 22 days

push eventphansch/dotfiles

Philipp Hansch

commit sha caf3ead5446df460148fb1411017ff614b6a180a

try

view details

push time in 22 days

push eventphansch/dotfiles

Philipp Hansch

commit sha bdd46a150ed9d37fb83b61aa7b4c13434ae5d8b4

Remove again

view details

push time in 22 days

push eventphansch/dotfiles

Philipp Hansch

commit sha fbc92beeaa605b64e1bd0b4bf54e2914e72263a8

Install vint in container

view details

push time in 22 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 04c2296c03b9b6a8f480f41dd27dc1a471504a1c

Install vint in container

view details

push time in 22 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 2575bba6a61af55540380115a13630003cb59aa6

Set CI env variable

view details

push time in 22 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 7744efa83c5e657ef83bf187bdf9330c2f545e96

Enforce python3 usage by ansible

view details

push time in 22 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 29c9dd92353bf0f0291f75845b554f0e134c572f

s/master/main

view details

push time in 22 days

PR opened phansch/dotfiles

Replace shutter with xfce4-screenshooter
+9 -2

0 comment

2 changed files

pr created time in 22 days

create barnchphansch/dotfiles

branch : shutter

created branch time in 22 days

pull request commentphansch/dotfiles

Make CI work under Ubuntu 20

Next error: fatal: [localhost]: FAILED! => {"changed": false, "msg": "crontab: userphansch' unknown\n"}}

phansch

comment created time in 22 days

pull request commentphansch/dotfiles

Make CI work under Ubuntu 20

Getting a weird failure with cron:

TASK [Backup cron] *************************************************************

fatal: [localhost]: FAILED! => {"changed": false, "msg": "Failed to find required executable crontab in paths: /code/.venv/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"}

But crontab should be installed with 43f7d83?

phansch

comment created time in 22 days

push eventphansch/dotfiles

Philipp Hansch

commit sha e417c17490258024aba362227ae7f35d2a643502

debug cron issue

view details

push time in 22 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 43f7d83f6b058d709895aebfb6179d57ebca90cd

Fix backup cron

view details

push time in 22 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 7a43824a4059ef03cca92886311a074675fdba5c

Replace shutter with xfce4-screenshooter

view details

push time in 22 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 21bec0f55d040e70f5b4a0235180564333cc1d12

Replace shutter with xfce4-screenshooter

view details

push time in 22 days

pull request commentphansch/dotfiles

Make CI work under Ubuntu 20

Disabled the ansible-vagrant installation for now.

Next up: shutter is not available in the ubuntu repos anymore.

phansch

comment created time in 22 days

push eventphansch/dotfiles

Philipp Hansch

commit sha c051132138d0bff700206cc9bf64c8f2a94abf33

Skip vagrant installation for now

view details

push time in 22 days

pull request commentphansch/dotfiles

Make CI work under Ubuntu 20

https://github.com/FGtatsuro/ansible-virtualbox fails to install because it attempts to install a python-pip package which doesn't exist in Ubuntu 20.04

phansch

comment created time in 22 days

push eventphansch/dotfiles

Philipp Hansch

commit sha b04ba778d664767a17b2af1011a0232519a06ebe

Enforce python3 usage by ansible

view details

push time in 22 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 5b3eb8fccf351cf7cc93ca8e809ccc029031d812

Enfore python3 usage by ansible

view details

push time in 22 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 907514df20d224800e8adfb583d79df87064b573

try

view details

push time in 22 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 9c32d2db2a4db65d19ad37641175c4fc9fb485e7

Avoid readline prompts on CI

view details

push time in 22 days

startedetra0/taskmgr-video

started time in 22 days

push eventphansch/dotfiles

Philipp Hansch

commit sha 79329dee6ee4d1ca70434f4e1a1604b69280b992

s/master/main

view details

push time in 22 days

issue closedphansch/dotfiles

Ergodox layout: Find new key positions for left shift and ctrl

Currently using my pinky finger which is getting painful

closed time in 22 days

phansch

PR opened phansch/dotfiles

Make CI work under Ubuntu 20
+1 -1

0 comment

1 changed file

pr created time in 22 days

more