profile
viewpoint

apache/nano 1129

Nano is now part of Apache CouchDB. Repo moved to https://GitHub.com/apache/couchdb-nano

chriseppstein/sass-recipes 379

Sass mixin examples and recipes that you can use or modify to suit your needs. Send a request for commit access to add your own. Most of these mixins are now part of my Compass project

adamstac/grid-coordinates 109

Sass and Compass highly-configurable CSS grid framework

riemann/riemann-nodejs-client 58

node.js client for Riemann. Because you should be monitoring all of those non-blocking buffet plates.

perezd/node-murmurhash 42

A Node.js module for the optimized JavaScript implementation of the MurmurHash algorithms.

bazelbuild/rules_sass 38

Sass rules for Bazel

perezd/smart_month 30

A Rails plugin that is making months smarter in Ruby (and Rails).

perezd/streamable 11

Super simple streaming responses for Connect/Express.

perezd/protopoet 10

Code generation library for Protocol Buffers (proto3) written in Java.

chriseppstein/cells 5

Components for Rails. This fork maintains controller like syntax with a render method, layouts, etc.

issue commentprotocolbuffers/protobuf

protobuf-test:IoTest.LargeOutput test fails

There were no recent (post-3.14.0) changes in src/google/protobuf/io/zero_copy_stream_unittest.cc. How much memory this test actually needs (on 64-bit system)?

Arfrever

comment created time in an hour

issue openedprotocolbuffers/protobuf

Implement string_view setter on string fields in generated code.

What language does this apply to? proto2 C++

Describe the problem you are trying to solve.

I'm using std::string_view liberally. I'm having to do this everywhere, it's driving me crazy:

   message->set_field(value.data(), value.size();

Describe the solution you'd like

Just... please add an overload to the setters accepting the new pretty much ubiquitous std::string_view.

Describe alternatives you've considered

Macros. (Ugly.)

created time in an hour

issue openedprotocolbuffers/protobuf

Allow ArenaOptions.block_alloc return memory size greater than required size.

Allow ArenaOptions.block_alloc return actual allocated memory size which may be greater than required size.

What language does this apply to? proto2 and proto3 c++

Describe the solution you'd like void* block_alloc(size_t required_size, size_t* out_size) out_size is actual allocated memory size.

created time in 7 hours

pull request commentprotocolbuffers/protobuf

Update param type for PHP Internal Mapfield::offsetGet

Thanks for the approval, the failing merge check doesn't look like something related to this work but not sure how to resolve that?

M1ke

comment created time in 9 hours

issue commentprotocolbuffers/protobuf

protobuf 3.6.0 build with error: undefined reference

Issue is likely still relevant, something happened to my build and now it doesn't work with basically every protobuf symbol undefined.

lxl910915

comment created time in 12 hours

issue openedprotocolbuffers/protobuf

It seems UBSAN is being overzealous here. As far as I know, there is no section in the standard that explicitly disallows writing out of bounds if there is sufficient storage.

It seems UBSAN is being overzealous here. As far as I know, there is no section in the standard that explicitly disallows writing out of bounds if there is sufficient storage.

Originally posted by @seishun in https://github.com/protocolbuffers/protobuf/issues/2073#issuecomment-245885390

created time in 17 hours

issue openedprotocolbuffers/protobuf

Add null as wire type.

Describe the problem you are trying to solve. Protobuf as tagged protocol has field presence but not nullability. All proposed nullability approaches like message boxing or oneof have various disadvantages. Explicit nullability could be useful for mapping Json merge patches (https://tools.ietf.org/html/rfc7396) to gRPC.

Describe the solution you'd like I guess it would be convenient to have explicit nullability at wire protocol level. Null value can be expressed as a new wire type, i.e. 7. Null encoding is empty, no data followed. Fields can be marked as nullable with some attribute in proto definition. Nullable field can be present on wire as tag with null wire type or field wire type. Like in json, fields will have three possible states: none/null/value.

created time in 17 hours

issue commentprotocolbuffers/protobuf

Add support for type alias

@dlj-NaN personally, I would suggest falling back to the native types, in this case, string. These aliases are useful in maintaining the protobuf definitions.

I am not sure if there would be useful to generate aliases for the generated types since it depends on programming languages implementation if I am not mistaken.

yordis

comment created time in 21 hours

pull request commentprotocolbuffers/protobuf

deps: update to Guava 30

We can't look because the output has expired and isn't there any more. :-( If you rerun the build, we'll take a look; or if you grant us permissions on the repo, we can run it ourselves.

elharo

comment created time in a day

issue commentprotocolbuffers/protobuf

js/{closure,commonjs}: create a new js_module option

@BSBandme could you shed some light on this matter please?

Our building script is now a little monster that is really hard to maintain and is breaking every time we add new dependencies.

This feature would make things much easier for us.

Thanks in advance

glerchundi

comment created time in a day

issue commentprotocolbuffers/protobuf

Submodule googletest will not update

It looks like googletest is broken for us at google/googletest@6b8c13815 and later.

bobhancock

comment created time in 2 days

issue commentprotocolbuffers/protobuf

Add support for type alias

@yordis: what would be the expectation for the generated types?

yordis

comment created time in 2 days

push eventprotocolbuffers/protobuf

Jorg Brown

commit sha 3f91c10f0daf8bfce21bb8a80bf3ecd20f83f625

Work around -Werror=type-limits under gcc 10.2 (#8092) * Work around `-Werror=type-limits` under gcc 10.2 This is an error when tag is greater than 128 under gcc 10.2: `if (tag < 128) return *ptr == tag;` It's an error even though the comparison occurs in a branch of code we know won't be taken. See https://godbolt.org/z/1eaP86 This works around the problem by casting `tag` to the same type as `*ptr`.

view details

push time in 2 days

PR merged protocolbuffers/protobuf

Work around -Werror=type-limits under gcc 10.2 c++ cla: yes release notes: no

This is an error when tag is greater than 128 under gcc 10.2: if (tag < 128) return *ptr == tag; It's an error even though the comparison occurs in a branch of code we know won't be taken. See https://godbolt.org/z/1eaP86 This works around the problem by clipping tag to within bounds.

+1 -1

0 comment

1 changed file

jorgbrown

pr closed time in 2 days

Pull request review commentprotocolbuffers/protobuf

Work around -Werror=type-limits under gcc 10.2

 class PROTOBUF_EXPORT ParseContext : public EpsCopyInputStream { template <uint32 tag> bool ExpectTag(const char* ptr) {   if (tag < 128) {-    return *ptr == tag;+    return *ptr == tag % 128;

Sure, whatever.

jorgbrown

comment created time in 2 days

Pull request review commentprotocolbuffers/protobuf

Work around -Werror=type-limits under gcc 10.2

 class PROTOBUF_EXPORT ParseContext : public EpsCopyInputStream { template <uint32 tag> bool ExpectTag(const char* ptr) {   if (tag < 128) {-    return *ptr == tag;+    return *ptr == tag % 128;

This seems a bit over-subtle... how about just a static_cast<char>(tag)?

jorgbrown

comment created time in 2 days

pull request commentprotocolbuffers/protobuf

Fill out JRuby support

@rdubya That is a good point about the JRuby gem needing to have the same name, and I don't know of any good solution to that.

rdubya

comment created time in 2 days

issue closedprotocolbuffers/protobuf

Security vulnerability

Veracode scan found this security vulnerability in map_entry_lite.h:275

Integer Overflow or Wraparound (CWE ID 190)(3 flaws) Description An integer overflow condition exists when an integer that has not been properly sanity checked is used in the determination of an offset or size for memory allocation, copying, concatenation, or similarly. If the integer in question is incremented past the maximum possible value, it may wrap to become a very small, negative number, therefore providing an unintended value. This occurs most commonly in arithmetic operations or loop iterations. Integer overflows can often result in buffer overflows or data corruption, both of which may be potentially exploited to execute arbitrary code. Effort to Fix: 2 - Implementation error. Fix is approx. 6-50 lines of code. 1 day to fix. Recommendations Perform bounds checking to ensure that integers do not exceed the maximum possible value.

273 int GetCachedSize() const override { 274 int size = 0; 275 size += has_key() ? static_cast<int>(kTagSize) + 276 KeyTypeHandler::GetCachedSize(key()) 277 : 0; 278 size += has_value() ? static_cast<int>(kTagSize) + 279 ValueTypeHandler::GetCachedSize(value()) 280 : 0; 281 return size; 282 }

closed time in 2 days

eugrin

issue commentprotocolbuffers/protobuf

Security vulnerability

GetCachedSize is always called after ByteSizeLong, which ensures the size doesn't exceed 2G.

eugrin

comment created time in 2 days

PR opened protocolbuffers/protobuf

Work around -Werror=type-limits under gcc 10.2

This is an error when tag is greater than 128 under gcc 10.2: if (tag < 128) return *ptr == tag; It's an error even though the comparison occurs in a branch of code we know won't be taken. See https://godbolt.org/z/1eaP86 This works around the problem by clipping tag to within bounds.

+1 -1

0 comment

1 changed file

pr created time in 2 days

pull request commentprotocolbuffers/protobuf

deps: update to Guava 30

@suztomo could you help take a look of the failure in the linkage test?

elharo

comment created time in 2 days

issue commentprotocolbuffers/protobuf

Makefile dependencies appear to be incompletely specified for conformance/

https://github.com/protocolbuffers/protobuf/blame/master/conformance/Makefile.am#L221-L224

Is this issue related to this?

thomasvl

comment created time in 2 days

pull request commentprotocolbuffers/protobuf

deps: update to Guava 30

Details is not showing me any info. Did it expire?

elharo

comment created time in 2 days

issue commentprotocolbuffers/protobuf

protobuf-test:IoTest.LargeOutput test fails

Can that be related to the memory size on your machine?

Arfrever

comment created time in 2 days

issue commentprotocolbuffers/protobuf

protobuf-test:IoTest.LargeOutput test fails

I don't see it on master. Could you try master branch?

Arfrever

comment created time in 2 days

PR closed protocolbuffers/protobuf

Add support for new compilers when generating c++ message classes cla: yes release notes: no

This pull request includes fixes for generated c++ message classes that refer to:

  • mark methods that override functionality from base class as "override"
  • fix of pedantic warnings generated by declaring of arrays with 0 length - there is a language extension for this but having the pedantic warnings enabled together with -Werror will result in compilation errors in projects that depend on this library & the generated code
+418 -395

0 comment

6 changed files

vesavlad

pr closed time in 2 days

issue commentprotocolbuffers/protobuf

mergeFromJsonString dumps core for a valid RFC3339 timestamp

Can you try with the newest version of protobuf? The protobuf-PHP library has changed a lot since version 3.10.

vishal-wadhwa

comment created time in 2 days

issue commentprotocolbuffers/protobuf

Submodule googletest will not update

I tried the following anf works:

git clone https://github.com/protocolbuffers/protobuf.git
cd protobuf
git submodule update --init --recursive
./autogen.sh
./configure
make -j4
make dist
bobhancock

comment created time in 2 days

issue commentprotocolbuffers/protobuf

Submodule googletest will not update

Where was fust_gmock_files.py fixed? Do you have a link?

bobhancock

comment created time in 2 days

pull request commentprotocolbuffers/protobuf

Ruby File Generation Frozen String Literals

It improves memory performance of strings by making them immutable by default, more can be read here.

noahmatisoff

comment created time in 2 days

more