profile
viewpoint

paulbovbel/frontier_exploration 103

ROS Node and Costmap 2D plugin layer for frontier exploration

locusrobotics/actionlib 0

Provides a standardized interface for interfacing with preemptable tasks. Examples of this include moving the base to a target location, performing a laser scan and returning the resulting point cloud, detecting the handle of a door, etc.

locusrobotics/bloom 0

A release automation tool which makes releasing catkin (http://ros.org/wiki/catkin) packages easier.

locusrobotics/realsense-ros 0

Intel(R) RealSense(TM) ROS Wrapper for D400 series and SR300 Camera

locusrobotics/ros 0

Core ROS packages

locusrobotics/roslint 0

Lint macros for ROS packages

locusrobotics/ros_comm 0

ROS communications-related packages, including core client libraries (roscpp, rospy, roslisp) and graph introspection tools (rostopic, rosnode, rosservice, rosparam).

locusrobotics/royale_ros 0

ROS package for pmd-based ToF cameras based on the Royale SDK

issue commentpaulbovbel/frontier_exploration

memory leak melodic release

It's not a memory leak, but an error on shutdown in terms of destruction order.

scifiswapnil

comment created time in 3 days

issue commentpaulbovbel/frontier_exploration

Any plan for Melodic update?

I don't have any immediate plans - PRs to integrate the melodic-devel frontier_exploration with turtlebot3, or the existing demo in https://github.com/husky/husky/blob/melodic-devel/husky_navigation/launch/exploration_demo.launch are welcome!

ROBOTIS-Will

comment created time in 3 days

issue commentpaulbovbel/frontier_exploration

Release for Noetic / ROS2

I hadn't had the chance to clean up melodic-devel and the https://github.com/husky/husky/blob/melodic-devel/husky_navigation/launch/exploration_demo.launch demo for a Melodic release. Help with either is greatly appreciated!

benjaminchristie

comment created time in 3 days

push eventpaulbovbel/frontier_exploration

Paul Bovbel

commit sha 2f6b060f866aeddbb7ec30fbe350aa1b2f7a690d

Remove stray prefix

view details

push time in 3 days

issue commentpaulbovbel/frontier_exploration

melodic failed to request goal

Hi folks, I apologise, I haven't had the time to bring the melodic branch up to snuff after a sizeable refactor - and hence never cut a melodic releaser. PRs are welcome and appreciated!

JuliusSustarevas

comment created time in 3 days

issue commentlocusrobotics/aiorospy

Release for Noetic

I don't see why not. I haven't actually used noetic yet, so I'd appreciate some confirmation that this package 'works', but otherwise I should be able to just run the pre-release suite and cut a release.

PymZoR

comment created time in 15 days

issue closedlocusrobotics/aiorospy

Release for melodic

This requires figuring out how to handle the python3.7 dependency.

We can swap asyncio.create_task for ensure_future, and drop back down to 3.6

We also need to use the new package.xml conditional dependency feature to put python3.x behind a flag that's ignored on ROS buildfarm.

closed time in 15 days

paulbovbel

PR merged locusrobotics/aiorospy

Missing return
+1 -1

0 comment

1 changed file

paulbovbel

pr closed time in 18 days

push eventlocusrobotics/aiorospy

Paul Bovbel

commit sha 41a920c7ada06dcbcd288fe495e5a2c4b69901da

Missing return (#33)

view details

push time in 18 days

PR opened locusrobotics/aiorospy

Missing return
+1 -1

0 comment

1 changed file

pr created time in 23 days

create barnchlocusrobotics/aiorospy

branch : missing-return

created branch time in 23 days

pull request commentros/rosdistro

catkin_virtualenv: 0.6.0-1 in 'noetic/distribution.yaml' [bloom]

holding for the upcoming Noetic sync

missed that before requesting review, my bad.

paulbovbel

comment created time in 24 days

issue closedros-perception/pointcloud_to_laserscan

Foxy release

Is it possible to make a foxy release of pointcloud_to_laserscan?

closed time in 25 days

mdtoom

issue commentros-perception/pointcloud_to_laserscan

Foxy release

Thanks!

mdtoom

comment created time in 25 days

pull request commentros/rosdistro

catkin_virtualenv: 0.6.0-1 in 'noetic/distribution.yaml' [bloom]

@sloretz it is intentional - catkin_virtualenv allows a package to bundle either a python2 or python3 virtualenv, hence depending on both trees.

paulbovbel

comment created time in a month

issue commentros-perception/pointcloud_to_laserscan

Foxy release

Tagging @hidmic since he did the ROS2 port and is a maintainer - would he be willing to cut the Foxy (and probably Rolling) release?

mdtoom

comment created time in a month

create barnchpaulbovbel/rosdistro

branch : bloom-catkin_virtualenv-20

created branch time in a month

issue closedlocusrobotics/catkin_virtualenv

Release catkin_virtualenv into ROS Noetic?

Would you mind releasing catkin_virtualenv to ROS Noetic? It looks like all of its dependencies have been released, and recursively 13 repos need it.

I'm not sure how much work it will need. The Noetic Migration Guide or the guide about transitioning ROS packages to Python 3 may be useful.

closed time in a month

sloretz

issue commentlocusrobotics/catkin_virtualenv

Release catkin_virtualenv into ROS Noetic?

Done! https://github.com/ros/rosdistro/pull/25807

sloretz

comment created time in a month

PR opened ros/rosdistro

Reviewers
catkin_virtualenv: 0.6.0-1 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository catkin_virtualenv to 0.6.0-1:

  • upstream repository: https://github.com/locusrobotics/catkin_virtualenv.git
  • release repository: https://github.com/locusrobotics/catkin_virtualenv-release.git
  • distro file: noetic/distribution.yaml
  • bloom version: 0.9.7
  • previous version for package: null

catkin_virtualenv

* Don't require catkin_package to be called before catkin_generate_virtualenv (#67 <https://github.com/locusrobotics/catkin_virtualenv/issues/67>)
* Revert "Downgrade docutils so that boto works (#66 <https://github.com/locusrobotics/catkin_virtualenv/issues/66>)"
  This reverts commit 998cd6add2e43e12036d0db15a7c4d58fe3411cf.
* Downgrade docutils so that boto works (#66 <https://github.com/locusrobotics/catkin_virtualenv/issues/66>)
  See https://github.com/boto/botocore/issues/1942 and related threads.
* Make regex for Python bytecode more selective (#65 <https://github.com/locusrobotics/catkin_virtualenv/issues/65>)
  Fix regex to match only files ending in ".py[co]" and not files ending
  in "py[co]".
* Remove user specific paths (#63 <https://github.com/locusrobotics/catkin_virtualenv/issues/63>)
  * Remove user specific paths
  * Change working directory of venv_lock command
  * Lock catkin_virtualenv base requirements
  Co-authored-by: Paul Bovbel <mailto:paul@bovbel.com>
* RST-3172 Check that requirements file is locked (#62 <https://github.com/locusrobotics/catkin_virtualenv/issues/62>)
* Two helpful hints (#61 <https://github.com/locusrobotics/catkin_virtualenv/issues/61>)
* Fix input requirements warning (#58 <https://github.com/locusrobotics/catkin_virtualenv/issues/58>)
  * Only warn about INPUT_REQUIREMENTS if a package exports requirements to begin with
  * Update catkin_virtualenv/cmake/catkin_generate_virtualenv.cmake
  Co-authored-by: Andrew Blakey <mailto:ablakey@gmail.com>
  Co-authored-by: Andrew Blakey <mailto:ablakey@gmail.com>
* Preserve symlinks during copy (#57 <https://github.com/locusrobotics/catkin_virtualenv/issues/57>)
* Don't ignore unknown args
* RST-3172 Refactor catkin_virtualenv to allow locking dependencies (#55 <https://github.com/locusrobotics/catkin_virtualenv/issues/55>)
  * Remove unused options
  * Fix regex for comments
  * Migrate scripts
  * Remove old code
  * Move common requirements to an export file
  * Minor cleanup
  * Remove requirement-parsing unit tests
  * Fix logging config
  * Fix test builds
  * Generate lock files
  * Fix tests
  * Move dh-virtualenv functions into separate file
  * Fix roslint
  * Update docs
  * Update requirements
  * CMake comments
  * Fix pip-args
  * README fixup
  * Correct ARG_LOCK_FILE handling
  * Remove headers
  * Use set comprehension
  * Add migration doc
  * Respin
* Use exec to dive into python (#51 <https://github.com/locusrobotics/catkin_virtualenv/issues/51>)
* First python2 issue of 2020 (#49 <https://github.com/locusrobotics/catkin_virtualenv/issues/49>)
  * Clean up options, virtualenv installs setuptools by default
  * Make sure we install a compatible setuptools version for py2 venv
* catkin-pkg-modules has disappeared off pypi (#46 <https://github.com/locusrobotics/catkin_virtualenv/issues/46>)
  * catkin-pkg-modules has disappeared off pypi, but catkin-pkg is still there
  * Version all requirements
* Contributors: David V. Lu!!, Michael Johnson, Paul Bovbel, abencz
+16 -0

0 comment

1 changed file

pr created time in a month

push eventlocusrobotics/catkin_virtualenv-release

Paul Bovbel

commit sha f64ce03b7c25ee498a4ba21422401d186ffc8781

Modified tracks.yaml

view details

Paul Bovbel

commit sha 09ec1d13710595a299dd1bc1baf2dfc1a872551a

Modified tracks.yaml

view details

Paul Bovbel

commit sha 1d813bc1095fe5ef8f3927dd428a137a69181144

Updating release inc to: 1

view details

Paul Bovbel

commit sha 4201680b503536c477f49a6265cdcae920bc5cea

Updating README.md

view details

push time in a month

push eventlocusrobotics/catkin_virtualenv-release

Paul Bovbel

commit sha 5740fc364db67c3c543473564d1ddac85f2a6838

Imported upstream version '0.6.0' of 'upstream'

view details

push time in a month

push eventlocusrobotics/catkin_virtualenv-release

Paul Bovbel

commit sha 58f1ad993ded0c94d9126d5c13f7d6aa1e477a59

Create noetic.ignored

view details

push time in a month

created taglocusrobotics/catkin_virtualenv

tag0.6.0

Bundle python requirements in a catkin package via virtualenv

created time in a month

push eventlocusrobotics/catkin_virtualenv

Paul Bovbel

commit sha 1b56b7e59e47c26875c540982be6ed88e3aae809

Add changelogs

view details

Paul Bovbel

commit sha d223d22e6bafca2a7b0d4d04d229110b58a5778f

0.6.0

view details

push time in a month

push eventlocusrobotics/catkin_virtualenv

Paul Bovbel

commit sha 1eb95b6519f8e5f279f70c45cfbeb98faeee0183

Don't require catkin_package to be called before catkin_generate_virtualenv (#67)

view details

push time in a month

push eventlocusrobotics/catkin_virtualenv

Paul Bovbel

commit sha 3fb1ca03a7c4c591df7b9f9b1066fb017d6ad3de

Update catkin_generate_virtualenv.cmake

view details

push time in a month

push eventpaulbovbel/frontier_exploration

Paul Bovbel

commit sha bda92059171ccb0bd5a4ab34d016df3ad9d6ed26

Create README.md

view details

push time in a month

issue commentlocusrobotics/catkin_virtualenv

Usage with overlay workspaces

Overlays are supported, the virtualenv is stored with the build artifacts of your package.

kunaltyagi

comment created time in a month

CommitCommentEvent

push eventlocusrobotics/catkin_virtualenv

Paul Bovbel

commit sha 1c93e8242dc858c6c31fbb2ae6ad98492a5d4c65

Don't require catkin_package to be called before catkin_generate_virtualenv

view details

push time in a month

create barnchlocusrobotics/catkin_virtualenv

branch : no-catkin-package

created branch time in a month

push eventlocusrobotics/catkin_virtualenv

Paul Bovbel

commit sha 3f5948b7a97e77e78b48290d5a46bb8393c8264d

Revert "Downgrade docutils so that boto works (#66)" This reverts commit 998cd6add2e43e12036d0db15a7c4d58fe3411cf.

view details

push time in a month

pull request commentros-drivers/vrpn_client_ros

Foxy devel

Thanks! Yeah, when the time comes to release this, I'll figure out how to get vrpn included. I think it's actually gotten easier with colcon direct support for cmake packages.

zeroos

comment created time in 2 months

create barnchros-drivers/vrpn_client_ros

branch : foxy-devel

created branch time in 2 months

issue commentros-drivers/vrpn_client_ros

Porting to ROS2?

For sure, please do make a PR, and then when it's good to go, I'll merge it into a foxy-devel.

mathsten

comment created time in 2 months

issue commentros-perception/perception_pcl

PCLNodelet: The tf listener doesn't use the nodelet nodehandles.

AFAIK it's totally normal to remap /tf* topics, e.g. for partitioning tf trees as @peci1 calls out. Transport topics are completely distinct from frame ids, and nothing prevents, or advises against, remapping the former.

peci1

comment created time in 2 months

issue commentros-perception/perception_pcl

PCLNodelet: The tf listener doesn't use the nodelet nodehandles.

AFAIK it's totally normal to remap /tf* topics, e.g. for partitioning tf trees for multi-robot setups. Transport topics are completely distinct from frame ids, and nothing prevents, or advises against, remapping the former.

peci1

comment created time in 2 months

issue commentros-perception/perception_pcl

PCLNodelet: The tf listener doesn't use the nodelet nodehandles.

It's totally normal to remap /tf* topics, such as for segregating multiple tf trees for multi-robot setups. Transport topics are completely distinct from frame ids.

peci1

comment created time in 2 months

issue closedros-perception/pointcloud_to_laserscan

Noetic release

Can we get a Noetic release :)?

closed time in 2 months

reinzor

issue commentros-perception/pointcloud_to_laserscan

Noetic release

Way ahead of you! https://github.com/ros-perception/pointcloud_to_laserscan/issues/38

reinzor

comment created time in 2 months

issue commentros-perception/perception_pcl

ROS2 Port

oh wow, i'm just completely misinformed, thanks!

LucidOne

comment created time in 2 months

issue closedros-perception/perception_pcl

ROS2 Port

Is there a central place where we are tracking architectural issues for a ROS2 interface to PCL?

The big one I recall is handling pipelined pcl operations with nodelets. Zero copy is great until an old point cloud gets over written by a new one before you are done with it.

closed time in 2 months

LucidOne

issue commentros-perception/perception_pcl

ROS2 Port

perception_pcl has been ported to ROS2, https://github.com/ros-perception/perception_pcl/tree/foxy-devel

LucidOne

comment created time in 2 months

Pull request review commentlocusrobotics/catkin_virtualenv

Make regex for Python bytecode more selective

 from . import run_command, relocate from .collect_requirements import collect_requirements -_BYTECODE_REGEX = re.compile('.*.py[co]')+_BYTECODE_REGEX = re.compile('.*\.py[co]')

Missed that escape, rookie mistake, thanks!

abencz

comment created time in 2 months

pull request commenttmewett/BrogueCE

Added snap packaging

Maybe you could map /opt/brogue into $SNAP/opt/brogue

I hadn't seen https://snapcraft.io/docs/snap-layouts at all. Seems reasonable.

paulbovbel

comment created time in 2 months

Pull request review commenttmewett/BrogueCE

Added snap packaging

+name: brogue-ce+summary: Welcome to the Dungeons of Doom!+description: Brogue is a single-player strategy game set in the halls of a mysterious and randomly-generated dungeon.+license: AGPL-3.0++adopt-info: brogue-ce+confinement: strict+base: core18++parts:+  brogue-ce:+    source: .+    plugin: make++    override-pull: |+      snapcraftctl pull+      version="$(git describe --always | sed -e 's/-/+git/;y/-/./')"+      [ -n "$(echo $version | grep "+git")" ] && grade=devel || grade=stable+      snapcraftctl set-version "$version"+      snapcraftctl set-grade "$grade"++    override-build: |+      # Build and install brogue - no install target provided+      make clean && make DATADIR='\$$SNAP/usr/share' &&+      cp bin/brogue $SNAPCRAFT_PART_INSTALL/usr/bin/ &&+      cp -r bin/assets $SNAPCRAFT_PART_INSTALL/usr/share/ && chmod -R +rX $SNAPCRAFT_PART_INSTALL/usr/share/assets++      # Configure wrapper to run brogue from user data directory+      echo 'cd $SNAP_USER_DATA && brogue "$@"' >> $SNAPCRAFT_PART_INSTALL/usr/bin/brogue-wrapper &&

SNAP_USER_DATA is copied between updates - I think the intent is that if a new release does something interesting like, changing the save format, rolling back to an old release will also roll back the saves.

paulbovbel

comment created time in 2 months

Pull request review commenttmewett/BrogueCE

Added snap packaging

 name: "Build" on:   push:-    tags:

In that case edge snaps won't be built from commits to master, so I can remove all the set-grade stuff and assume they're only built off tagged releases.

Is that your intent? I'm not sure why one wouldn't want CI builds for every commit, but I'll defer to your preference.

paulbovbel

comment created time in 2 months

Pull request review commentlocusrobotics/rosbridge_suite

Rst 3396 rosbridge failures

 cmake_minimum_required(VERSION 2.8.3) project(rosbridge_server) -find_package(catkin REQUIRED)--catkin_python_setup()+find_package(catkin REQUIRED COMPONENTS+  catkin_virtualenv+)  catkin_package() +catkin_generate_virtualenv(+  INPUT_REQUIREMENTS requirements.in

can probably set USE_SYSTEM_PACKAGES FALSE as well to make sure none of the system deps are used

ablakey

comment created time in 2 months

create barnchpaulbovbel/rosdistro

branch : bloom-pointcloud_to_laserscan-7

created branch time in 2 months

issue closedros-perception/pointcloud_to_laserscan

Noetic release

Would you mind releasing this package also for the newest distribution ROS Noetic? :)

closed time in 2 months

Timple

issue commentros-perception/pointcloud_to_laserscan

Noetic release

Done! https://github.com/ros/rosdistro/pull/25342

Timple

comment created time in 2 months

PR opened ros/rosdistro

Reviewers
pointcloud_to_laserscan: 1.4.1-1 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository pointcloud_to_laserscan to 1.4.1-1:

  • upstream repository: https://github.com/ros-perception/pointcloud_to_laserscan.git
  • release repository: https://github.com/ros-gbp/pointcloud_to_laserscan-release.git
  • distro file: noetic/distribution.yaml
  • bloom version: 0.9.7
  • previous version for package: null

pointcloud_to_laserscan

* LaserScan to PointCloud node + nodelet (#28 <https://github.com/ros-perception/pointcloud_to_laserscan/issues/28>)
* fix roslint (#29 <https://github.com/ros-perception/pointcloud_to_laserscan/issues/29>)
* Merge pull request #20 <https://github.com/ros-perception/pointcloud_to_laserscan/issues/20> from ros-perception/range_max_check
  Add check for range_max
* Add check for range_max
* Contributors: Paul Bovbel, Rein Appeldoorn
+16 -0

0 comment

1 changed file

pr created time in 2 months

push eventros-gbp/pointcloud_to_laserscan-release

Paul Bovbel

commit sha d70a336a0cf88df34ebe63e3f4cf5e6f6c06b840

Modified tracks.yaml

view details

Paul Bovbel

commit sha 7bf727c1beedd40f4d91ac4a4153857277890fb3

Modified tracks.yaml

view details

Paul Bovbel

commit sha 9b369533d3641d9ff8677aacd48f4a7f0a60fc73

Updating release inc to: 1

view details

Paul Bovbel

commit sha e767ac29de8a10c3faf9e0948e49a0f10d5e9fee

Updating README.md

view details

push time in 2 months

issue closedros-perception/pointcloud_to_laserscan

Getting a curved point cloud and no laserscan for flat wall

Hi, I am getting a curved point cloud for some reason for some scenes even though there are no curved objects. I used the exact same parameters as shown in the pointcloud_to_laserscan_node.cpp. I am using a RealSense camera. Also, when pointed to a wall, it does not show any laserscan. The wall might be at a distance of a meter. Kindly help me...

Thank you..

Regards, Karan Manghi

closed time in 2 months

KaranManghi

issue commentros-perception/pointcloud_to_laserscan

Getting a curved point cloud and no laserscan for flat wall

Hi @KaranManghi, this kind of thing might be better suited for answers.ros.org, since it's not a bug. You should post your configuration there. Feel free to link to the question here, but I'll close the issue in the meantime.

KaranManghi

comment created time in 2 months

push eventpaulbovbel/BrogueCE

Paul Bovbel

commit sha 6e4608c643b8f9c38e1a287a91889014ff27231c

Revert "Add install target" This reverts commit c0794992b728a7c02aecf0eecadbacd5e3b4b142.

view details

push time in 2 months

pull request commenttmewett/BrogueCE

Added snap packaging

I tried the Snap release from the store and Brogue segfaults when i click "new game"

The snap in the store is outdated - the github actions only push from a master branch or release tagged with v. I pushed a build manually.

paulbovbel

comment created time in 2 months

pull request commenttmewett/BrogueCE

Added snap packaging

Great, thanks!

I'm not sure I want to maintain the actual Snap store release but I'm perfectly fine with merging the required changes and metadata file to ease building

Sure, can I give you a snapcraft_token to stick in the repository secrets, so the action works?

paulbovbel

comment created time in 3 months

Pull request review commenttmewett/BrogueCE

Added snap packaging

 bin/brogue.exe: $(objects) windows/icon.o clean: 	$(RM) src/brogue/*.o src/platform/*.o bin/brogue{,.exe} +install:+	install -m 557 bin/brogue $(DESTDIR)/usr/bin+	install -d $(DESTDIR)/usr/share/assets+	install bin/assets/* -t $(DESTDIR)/usr/share/assets

sure, I can basically revert https://github.com/tmewett/BrogueCE/pull/87/commits/c0794992b728a7c02aecf0eecadbacd5e3b4b142 and put the 'install' back in the packaging directives. I was surprised there was no install directive, but I don't have a bone to pick.

paulbovbel

comment created time in 3 months

Pull request review commenttmewett/BrogueCE

Added snap packaging

+name: brogue-ce+summary: Welcome to the Dungeons of Doom!+description: Brogue is a single-player strategy game set in the halls of a mysterious and randomly-generated dungeon.+license: AGPL-3.0++adopt-info: brogue-ce+confinement: strict+base: core18++parts:+  brogue-ce:+    source: .+    plugin: make++    override-pull: |+      snapcraftctl pull+      version="$(git describe --always | sed -e 's/-/+git/;y/-/./')"+      [ -n "$(echo $version | grep "+git")" ] && grade=devel || grade=stable+      snapcraftctl set-version "$version"+      snapcraftctl set-grade "$grade"++    override-build: |+      # Build and install brogue+      make clean && make DATADIR='\$$SNAP/usr/share' && make install DESTDIR=$SNAPCRAFT_PART_INSTALL &&

AFAIK, no, the snap gets installed into a directory containing the install order:

pbovbel@pbovbel-dell:/var/snap/brogue-ce$ ll /var/snap/brogue-ce/
total 20
drwxr-xr-x  5 root root 4096 May 21 18:36 ./
drwxr-xr-x 25 root root 4096 May 21 16:03 ../
drwxr-xr-x  2 root root 4096 May 21 16:03 common/
lrwxrwxrwx  1 root root    3 May 21 18:36 current -> x28/
drwxr-xr-x  2 root root 4096 May 21 16:03 x27/
drwxr-xr-x  2 root root 4096 May 21 16:03 x28/

I suppose it was a toss-up between implementing environment expansion for datadir, or just allowing it to be passed in as an argument to brogue. I went with the former.

paulbovbel

comment created time in 3 months

issue commentlocusrobotics/catkin_virtualenv

Release catkin_virtualenv into ROS Noetic?

Thanks @k-okada, but I fixed it elsewhere. The code currently on master should work fine in python3. I'll try to setup a focal/noetic environment and give it a whirl sometime soon, but if you're anxious for a binary release, I'll take your word for confirmation and bloom!

sloretz

comment created time in 3 months

Pull request review commentlocusrobotics/multimaster_fkie

Only update state if service calls are successful

 def updateState(self, clear_cache=False):                     threads.append(pidThread)                  master_state.timestamp = now++                # Important things worked. Update local state.+                self.__new_master_state = master_state

should be fine, but then again, one wouldn't expect the threads to have any side-effects on this function, so moving them to spawn at the end should be fine

MJohnson459

comment created time in 3 months

Pull request review commentlocusrobotics/multimaster_fkie

Only update state if service calls are successful

 def updateState(self, clear_cache=False):                     threads.append(pidThread)                  master_state.timestamp = now++                # Important things worked. Update local state.+                self.__new_master_state = master_state

As far as I can tell, this method spins off threads for _getNodePid and _getServiceInfo that expect __new_master_state to have been updated, so this may create a race condition. Would it make sense to feed the new master_state to those as an arg?

MJohnson459

comment created time in 3 months

push eventlocusrobotics/catkin_virtualenv

Paul Bovbel

commit sha d8892a7db8c331db24919141b5b41c3c4cd6ec22

Lock catkin_virtualenv base requirements

view details

push time in 3 months

push eventlocusrobotics/catkin_virtualenv

Paul Bovbel

commit sha ff5fe2614fb64fd45bbcde2e63f6b23c446915fa

Lock catkin_virtualenv base requirements

view details

push time in 3 months

push eventlocusrobotics/catkin_virtualenv

Paul Bovbel

commit sha 6f4f40a3a50715a184e708c6b918dd34c2e80af8

Change working directory of venv_lock command

view details

push time in 3 months

push eventlocusrobotics/catkin_virtualenv

Paul Bovbel

commit sha 5318035f961f2a08ae7f7eda10795c9cc3f63307

Change working directory of venv_lock command

view details

push time in 3 months

push eventlocusrobotics/catkin_virtualenv

push time in 3 months

push eventlocusrobotics/catkin_virtualenv

Paul Bovbel

commit sha 43296ede7dff0d56906bdacd24d7abf7394711b5

Add logical requirements for catkin_virtualenv

view details

push time in 3 months

push eventlocusrobotics/catkin_virtualenv

Paul Bovbel

commit sha d3270a015d1e0741fed264519ff5ca2e5fa481ae

Add logical requirements for catkin_virtualenv

view details

push time in 3 months

push eventlocusrobotics/catkin_virtualenv

Paul Bovbel

commit sha 199e09552f41f674f53faab5a4535f7b24769ad5

Change working directory of venv_lock command

view details

push time in 3 months

pull request commentlocusrobotics/catkin_virtualenv

Remove user specific paths

This is a bit more straightforward - if we change the working directory of the lock command, the paths will be relative to the source

DLu

comment created time in 3 months

push eventlocusrobotics/catkin_virtualenv

Paul Bovbel

commit sha 4298940d7257174a9333b36c25d6cd673c3a81f4

RST-3172 Check that requirements file is locked (#62)

view details

David V. Lu

commit sha 592a1b7262963bfb112026ef98a0b711cd8e8d58

Remove user specific paths

view details

Paul Bovbel

commit sha c70de4619564fee94a693664a7582b48c4fb2ac1

Change working directory of venv_lock command

view details

push time in 3 months

more