profile
viewpoint
Patryk Zawadzki patrys Mirumee Software Wrocław, Poland Head of Technology at Mirumee Software

mirumee/macaw-ui 9

MacawUI: an official UI design kit for Saleor

patrys/django-channels-ariadne 6

An async experiment with Ariadne + Django Channels

patrys/daemontools-ng 4

A modern, compatible, LGPL alternative to daemontools

mirumee/opentracing-asgi 3

ASGI middleware reporting to the OpenTracing API

patrys/django-friends 3

friendship, contact and invitation management for the Django web framework

patrys/babel 2

A GitHub mirror of http://svn.edgewall.org/repos/babel/

patrys/blipy 2

A Python API for blip.pl

AndrewIngram/django-treebeard 1

django-treebeard, modified to support multi-db.

patrys/django-explicit 1

Explicit querysets for Django

push eventpatrys/forbidden-lands-foundry-vtt

Patryk Zawadzki

commit sha 873034a116eb6c2dd02de347b91269881e7e00d6

Show a subtle gradient behind white avatars

view details

push time in 9 hours

push eventpatrys/forbidden-lands-foundry-vtt

Patryk Zawadzki

commit sha 48d8c4031362091ecd17d9549f900ae98b8b0e71

Simplify schema

view details

push time in 9 hours

push eventpatrys/forbidden-lands-foundry-vtt

Patryk Zawadzki

commit sha 69d4cd53c7b0c812d8a77598bb9edc94b8ed57e9

Simplify schema

view details

push time in 9 hours

push eventpatrys/forbidden-lands-foundry-vtt

Patryk Zawadzki

commit sha a4fa4218ac4e388dc53fa55b8ea767a7641ca667

Fix scrolling of combat sections

view details

push time in 10 hours

pull request commentmirumee/saleor

Run pytest as a GitHub action

Tests fail because I've split #5847 into a separate PR

patrys

comment created time in a day

push eventmirumee/saleor

Tomasz Szymański

commit sha c5c84025f126d978d82310d4e29dad224bb61553

Base of plugin hooks, invoice mutation

view details

Tomasz Szymański

commit sha 30aeb186fce6da63182ebae3c25614b6b3ffecda

Cleanups

view details

Tomasz Szymański

commit sha d35ecccc44779adec4a6a1399d4d99f2b47ed0e5

orderId field is now Graphene ID

view details

Marcin Gębala

commit sha 3877189cf3bdba4bd4cafd028b38e5ee697a8c71

Merge pull request #5345 from mirumee/invoice-request-mutation Base of plugin hooks, invoice mutation

view details

Tomasz Szymański

commit sha a3477b5983cde4784a57d9556634c79677411e38

Invoice delete mutation, minor improvements

view details

Tomasz Szymański

commit sha 771f11bf785827a33d396a8d373649d16d0763e1

Invoice request and delete unit tests

view details

Tomasz Szymański

commit sha ada76f96be36c6ed9ec4c9e949084e387f13b2e7

Invoice update mutation - WIP

view details

Tomasz Szymanski

commit sha 247ffbf74779fa85959f87022c35eb4f0831606e

Finish invoice update mutation, unit tests

view details

Tomasz Szymanski

commit sha 711ff6d7750567aa58efd9a104423d1035f395f8

Make sure plugin hooks are called with mutations

view details

Tomasz Szymanski

commit sha 35194f2ded84e6ccb64afd0f27fd235856c4dc07

Merge branch 'invoice-delete-mutation' of github.com:mirumee/saleor into invoice-update-mutation

view details

Marcin Gębala

commit sha d8ddb7ea693ecbe8f69fece46e2f32e6e6905bed

Merge pull request #5366 from mirumee/invoice-delete-mutation Invoice delete mutation

view details

Tomasz Szymanski

commit sha 2e10f4e7e0320e37611d563c8f4b0c7d8ca94374

ValidationError when invoice is incomplete after update

view details

Tomasz Szymanski

commit sha 6c2e111e36569de2af7aa474f958e37d4c718378

Merge branch 'feature/invoices' of github.com:mirumee/saleor into invoice-update-mutation

view details

Tomasz Szymanski

commit sha e5f48a168ae9c1314540ac29ee33073da3ec680b

CreateInvoice mutation, unit tests

view details

Tomasz Szymanski

commit sha 797d8d6184f96fd9d64a86f896a6a04d35761ac3

URL field as non required at start of creation process

view details

Tomasz Szymanski

commit sha 431308c4cf055a77b78bea66f7a80f598d8554d7

Simplify update code, update test improvement

view details

Tomasz Szymanski

commit sha 51c93ec99bcb79e7b1a2e0a082ce3f74811322a8

Merge branch 'invoice-update-mutation' of github.com:mirumee/saleor into invoice-create-mutation

view details

Tomasz Szymanski

commit sha 85d775a5d7887766460c52cf267475cd40b41efd

Add clean_input method to mutation

view details

Tomasz Szymanski

commit sha d1d3071600a75240444bbcf8f8885e26e0cdadfb

clean_input readability improvement

view details

Tomasz Szymanski

commit sha 4c1793d07e21d3c56928435a27fb37a18f68a22e

Remove redundant invoice field

view details

push time in a day

PR opened mirumee/saleor

Fix tests when working with a native extension of maxminddb

To test:

brew install libmaxminddb
pip install maxminddb --force-reinstall

Impact

  • [ ] New migrations
  • [ ] New/Updated API fields or mutations
  • [ ] Deprecated API fields or mutations
  • [ ] Removed API types, fields, or mutations
  • [ ] Documentation needs to be updated

Pull Request Checklist

<!-- Please keep this section. It will make the maintainer's life easier. -->

  • [ ] Privileged queries and mutations are guarded by proper permission checks
  • [ ] Database queries are optimized and the number of queries is constant
  • [ ] Database migration files are up to date
  • [ ] The changes are tested
  • [ ] GraphQL schema and type definitions are up to date
  • [ ] Changes are mentioned in the changelog
+11 -2

0 comment

2 changed files

pr created time in a day

create barnchpatrys/saleor

branch : fix-tests-with-native-maxminddb

created branch time in a day

issue closedmirumee/saleor

Can't load the graphql SCHEMA

Steps to reproduce the problem

  1. open the URL: https://pwa.demo.saleor.rocks/graphql/
  2. Click on Schema tab and white screen load

Screenshots

<!-- If applicable, add screenshots to help explain your problem. --> 2020-07-03_18-32-07

System information Operating system:

closed time in a day

raviitsoft

issue commentmirumee/saleor

Can't load the graphql SCHEMA

Duplicate of #5719

raviitsoft

comment created time in a day

startedscrapinghub/extruct

started time in a day

startederikriver/opengraph

started time in a day

startedcodex-team/editor.js

started time in a day

Pull request review commentmirumee/saleor

Deprecate WebhookEventType.CHECKOUT_QUANTITY_CHANGED

 class WebhookCreateInput(graphene.InputObjectType):     name = graphene.String(description="The name of the webhook.", required=False)     target_url = graphene.String(description="The url to receive the payload.")     events = graphene.List(-        WebhookEventTypeEnum, description="The events that webhook wants to subscribe."+        WebhookEventTypeEnum,+        description=(+            "The events that webhook wants to subscribe. The CHECKOUT_QUANTITY_CHANGED"+            " is depreacted. It will be removed in Saleor 3.0"

Sounds like a plan 😄

korycins

comment created time in 3 days

pull request commentPerfectro/forbidden-lands-foundry-vtt

New sheet design

@Perfectro I have a questio related to code formatting: I have my IDE configured to automatically format files on save, is there a formatting tool (and config) you use or want to use?

patrys

comment created time in 4 days

Pull request review commentmirumee/saleor

Deprecate WebhookEventType.CHECKOUT_QUANTITY_CHANGED

 class WebhookCreateInput(graphene.InputObjectType):     name = graphene.String(description="The name of the webhook.", required=False)     target_url = graphene.String(description="The url to receive the payload.")     events = graphene.List(-        WebhookEventTypeEnum, description="The events that webhook wants to subscribe."+        WebhookEventTypeEnum,+        description=(+            "The events that webhook wants to subscribe. The CHECKOUT_QUANTITY_CHANGED"+            " is depreacted. It will be removed in Saleor 3.0"

I don't have a solution ready, I'm thinking about the implications of this getting deprecated. See my answer above, telling users to poll for abandoned carts is also an option.

korycins

comment created time in 4 days

Pull request review commentmirumee/saleor

Deprecate WebhookEventType.CHECKOUT_QUANTITY_CHANGED

 class WebhookCreateInput(graphene.InputObjectType):     name = graphene.String(description="The name of the webhook.", required=False)     target_url = graphene.String(description="The url to receive the payload.")     events = graphene.List(-        WebhookEventTypeEnum, description="The events that webhook wants to subscribe."+        WebhookEventTypeEnum,+        description=(+            "The events that webhook wants to subscribe. The CHECKOUT_QUANTITY_CHANGED"+            " is depreacted. It will be removed in Saleor 3.0"

A company may want to create a storefront that creates a checkout object as soon as I know the user's email address. It doesn't really matter if our default storefront works differently. We may want to give them a webhook that is called when a checkout object is updated, we may also tell them that the right way to approach this is to periodically poll for data from Saleor (potential downside is the number of checkout objects could be large).

korycins

comment created time in 4 days

Pull request review commentmirumee/saleor

Deprecate WebhookEventType.CHECKOUT_QUANTITY_CHANGED

 class WebhookCreateInput(graphene.InputObjectType):     name = graphene.String(description="The name of the webhook.", required=False)     target_url = graphene.String(description="The url to receive the payload.")     events = graphene.List(-        WebhookEventTypeEnum, description="The events that webhook wants to subscribe."+        WebhookEventTypeEnum,+        description=(+            "The events that webhook wants to subscribe. The CHECKOUT_QUANTITY_CHANGED"+            " is depreacted. It will be removed in Saleor 3.0"

What about abandoned cart handling?

korycins

comment created time in 4 days

Pull request review commentmirumee/saleor

Deprecate WebhookEventType.CHECKOUT_QUANTITY_CHANGED

 class WebhookCreateInput(graphene.InputObjectType):     name = graphene.String(description="The name of the webhook.", required=False)     target_url = graphene.String(description="The url to receive the payload.")     events = graphene.List(-        WebhookEventTypeEnum, description="The events that webhook wants to subscribe."+        WebhookEventTypeEnum,+        description=(+            "The events that webhook wants to subscribe. The CHECKOUT_QUANTITY_CHANGED"+            " is depreacted. It will be removed in Saleor 3.0"

Can we recommend which hook to use instead?

korycins

comment created time in 4 days

Pull request review commentmirumee/saleor

Deprecate WebhookEventType.CHECKOUT_QUANTITY_CHANGED

 class MenuPermissions(BasePermissionEnum):     MANAGE_MENUS = "menu.manage_menus"  +# Depreacted. It will be removed in Saleor 3.0

Typo: "depreacted" -> "deprecated"

korycins

comment created time in 4 days

push eventmirumee/saleor

Patryk Zawadzki

commit sha 9758b1f91476b04523258db63bbe59d6ec51d524

Update SECURITY.md

view details

push time in 4 days

push eventmirumee/saleor-storefront

dominik-zeglen

commit sha 0b0842f25ef88d181d303b7de15099317c6b3ae0

Do not store passwords in localStorage

view details

Patryk Zawadzki

commit sha 7c331e1be805022c9a7be719bd69d050b2577458

Merge pull request from GHSA-4279-h39w-2jqm Do not store passwords in localStorage

view details

push time in 4 days

pull request commentPerfectro/forbidden-lands-foundry-vtt

New sheet design

Thanks for reviewing it, I know item model sheets are weird now, they need a redesign after bonus was split. I'll fix the bugs you found and I'm going to use it in a session and try to get feedback from players too.

patrys

comment created time in 5 days

push eventpatrys/forbidden-lands-foundry-vtt

Patryk Zawadzki

commit sha 8646e446dabc223421f0f46ec0ee152e0b4a6b7c

Fix item model sheet selects

view details

push time in 5 days

push eventpatrys/forbidden-lands-foundry-vtt

Patryk Zawadzki

commit sha b43581a35304a939326608215cef7d12a9c029d0

Fix item model sheet selects

view details

push time in 5 days

push eventpatrys/forbidden-lands-foundry-vtt

Patryk Zawadzki

commit sha 810b84be9a0c9e84620d6b5bf2e1483d627b8abf

Fix missing bonus changes

view details

push time in 5 days

push eventpatrys/forbidden-lands-foundry-vtt

Patryk Zawadzki

commit sha f981431a222dbf154834bed330c0a47ff42e2f2c

Only list gear on gear tab

view details

push time in 5 days

Pull request review commentmirumee/saleor

Feature/add jwt for apps

 class Meta:             (AccountPermissions.MANAGE_STAFF.codename, "Manage staff."),         ) +    def __init__(self, *args, **kwargs):+        super(User, self).__init__(*args, **kwargs)+        self._effective_permissions = None++    @property+    def effective_permissions(self) -> "QuerySet[Permission]":+        if self._effective_permissions is None:+            self._effective_permissions = get_permissions()+            if not self.is_superuser:+                self._effective_permissions = self._effective_permissions.filter(+                    user=self+                )+                self._effective_permissions |= Permission.objects.filter(+                    group__user=self+                )

Shouldn't that be .filter(Q(user=self) | Q(group__user=self))? It would be even better if it used a subquery with exists to eliminate the problem of duplicate permissions.

korycins

comment created time in 5 days

pull request commentPerfectro/forbidden-lands-foundry-vtt

New sheet design

Sure:

  • the paper border image comes from here: https://github.com/Roll20/roll20-character-sheets/blob/master/Forbidden_Lands/images/FBL%20small%20border%20box.png (repository is under MIT, committer did not mention whether it's their original work)
  • IM Fell Great Primer fonts are under SIL Open Font License: https://scripts.sil.org/cms/scripts/page.php?site_id=nrsi&id=OFL
patrys

comment created time in 5 days

PR opened Perfectro/forbidden-lands-foundry-vtt

New sheet design
  • New character sheet design
  • Support for current/max bonus on all items (migration should update existing data)
  • Automatic total armor calculation
  • Support for Calendar/Weather add-on (automatically configured for Forbidden Lands if installed)
  • Support for vtta-tokenizer add-on (clicking on portraits will bring up the token image editor if installed)
  • Support for rollable macros in item fields (example: create a critical wound with healing time set to [[d6]] days and it will roll once dragged onto a character)

The paper frame comes from the Roll 20 character sheet released under MIT.

image

+3437 -2219

0 comment

46 changed files

pr created time in 6 days

push eventpatrys/forbidden-lands-foundry-vtt

Perfectro

commit sha 3bd703960ad65392c8135ce13154e3423111360b

Clean up css files

view details

Perfectro

commit sha 9346aca1ba2e21cb3f0096e117032b9a252bb979

Add stronghold sheet + gear tab to monster sheet

view details

Launay Guillaume

commit sha cf0e917b71bbcb739de4c2d2c67504805ca00f65

Add unofficial stance on README

view details

Patryk Zawadzki

commit sha 957b87c609eb6d87b61a5c52d13ef7a06db85e96

New sheet designs

view details

Patryk Zawadzki

commit sha 7ba6c77e7d13ed29b0bf666ea4fbc59ff769c90d

Migrate data to the new format

view details

Patryk Zawadzki

commit sha 640eb92cf2eb9f381be431e7c4cc4b1027cfa0ad

Update item sheets to include bonus value/max

view details

push time in 6 days

push eventpatrys/forbidden-lands-foundry-vtt

Patryk Zawadzki

commit sha 5880e9d626de91cfe329ac0b6e027d1f8187fd35

New sheet designs

view details

push time in 6 days

push eventpatrys/forbidden-lands-foundry-vtt

Perfectro

commit sha 3bd703960ad65392c8135ce13154e3423111360b

Clean up css files

view details

Perfectro

commit sha 9346aca1ba2e21cb3f0096e117032b9a252bb979

Add stronghold sheet + gear tab to monster sheet

view details

Launay Guillaume

commit sha cf0e917b71bbcb739de4c2d2c67504805ca00f65

Add unofficial stance on README

view details

push time in 6 days

push eventpatrys/forbidden-lands-foundry-vtt

Patryk Zawadzki

commit sha 12cd168d40c85f44ec4c7f072838feb22a40805d

Rework the sheet

view details

push time in 8 days

push eventpatrys/forbidden-lands-foundry-vtt

Patryk Zawadzki

commit sha f205d1e6f8406690d0563acba97020dd2365bc61

Fix disabled sheet

view details

push time in 8 days

Pull request review commentmirumee/saleor-sdk

Do not cache mutation data

 class APIProxy {     };   }; -  signIn = (+  signIn = async (     variables: InferOptions<MUTATIONS["TokenAuth"]>["variables"],     options?: Omit<InferOptions<MUTATIONS["TokenAuth"]>, "variables">-  ) =>-    new Promise<{ data: TokenAuth["tokenCreate"] }>(async (resolve, reject) => {-      try {-        this.client.resetStore();--        const data = await this.fireQuery(-          MUTATIONS.TokenAuth,-          mutationData => mutationData!.tokenCreate-        )(variables, {-          ...options,-          update: (proxy, updateData) => {-            const handledData = handleDataErrors(-              (tokenCreateMutationData: any) =>-                tokenCreateMutationData.tokenCreate,-              updateData.data,-              updateData.errors-            );-            if (!handledData.errors && handledData.data) {-              setAuthToken(handledData.data.token);-              if (window.PasswordCredential && variables) {-                navigator.credentials.store(-                  new window.PasswordCredential({-                    id: variables.email,-                    password: variables.password,-                  })-                );-              }-            }-            if (options && options.update) {-              options.update(proxy, updateData);-            }-          },-        });--        resolve(data);-      } catch (e) {-        reject(e);-      }+  ): Promise<SignIn> => {+    await this.client.resetStore();+    let result: {+      data: TokenAuth_tokenCreate | null;+    } | null = null;++    result = await this.fireQuery(+      MUTATIONS.TokenAuth,+      mutationData => mutationData!.tokenCreate+    )(variables, {+      ...options,+      fetchPolicy: "no-cache",

It seems it's not the default, however we can make it default by passing { defaultOptions: { mutate: { fetchPolicy: "no-cache" } } } to the ApolloClient constructor.

dominik-zeglen

comment created time in 8 days

Pull request review commentmirumee/saleor-sdk

Do not cache mutation data

 class APIProxy {     };   }; -  signIn = (+  signIn = async (     variables: InferOptions<MUTATIONS["TokenAuth"]>["variables"],     options?: Omit<InferOptions<MUTATIONS["TokenAuth"]>, "variables">-  ) =>-    new Promise<{ data: TokenAuth["tokenCreate"] }>(async (resolve, reject) => {-      try {-        this.client.resetStore();--        const data = await this.fireQuery(-          MUTATIONS.TokenAuth,-          mutationData => mutationData!.tokenCreate-        )(variables, {-          ...options,-          update: (proxy, updateData) => {-            const handledData = handleDataErrors(-              (tokenCreateMutationData: any) =>-                tokenCreateMutationData.tokenCreate,-              updateData.data,-              updateData.errors-            );-            if (!handledData.errors && handledData.data) {-              setAuthToken(handledData.data.token);-              if (window.PasswordCredential && variables) {-                navigator.credentials.store(-                  new window.PasswordCredential({-                    id: variables.email,-                    password: variables.password,-                  })-                );-              }-            }-            if (options && options.update) {-              options.update(proxy, updateData);-            }-          },-        });--        resolve(data);-      } catch (e) {-        reject(e);-      }+  ): Promise<SignIn> => {+    await this.client.resetStore();+    let result: {+      data: TokenAuth_tokenCreate | null;+    } | null = null;++    result = await this.fireQuery(+      MUTATIONS.TokenAuth,+      mutationData => mutationData!.tokenCreate+    )(variables, {+      ...options,+      fetchPolicy: "no-cache",

According to Apollo docs, this is the default/only behavior for mutations?

dominik-zeglen

comment created time in 8 days

Pull request review commentmirumee/saleor

Add supported currencies to payment gateways

 class Meta: class Shop(graphene.ObjectType):     available_payment_gateways = graphene.List(         graphene.NonNull(PaymentGateway),+        currency=graphene.Argument(

Shouldn't available payment gateways live under Checkout rather than Shop?

IKarbowiak

comment created time in 8 days

Pull request review commentmirumee/saleor

Add supported currencies to payment gateways

 def gateway_config():     return GatewayConfig(         gateway_name="razorpay",         auto_capture=False,+        supported_currencies="USD",

Is there an easy way to use INR in this test case?

IKarbowiak

comment created time in 8 days

Pull request review commentmirumee/saleor

Add supported currencies to payment gateways

 def list_payment_plugin_names(self, active_only: bool = False) -> List[tuple]:             if payment_method in type(plugin).__dict__         ] -    def list_payment_gateways(self, active_only: bool = True) -> List[dict]:+    def list_payment_gateways(+        self, currency: Optional[str] = None, active_only: bool = True+    ) -> List[dict]:         payment_plugins = self.list_payment_plugin_names(active_only=active_only)+        # if currency is given return only gateways which support given currency+        if currency:

I have a feeling that if "process_payment" in type(plugin).__dict__ should really be an abstract base class so you could just use isinstance(plugin, PaymentPlugin).

IKarbowiak

comment created time in 8 days

delete branch patrys/saleor

delete branch : better-logging

delete time in 8 days

push eventpatrys/saleor

Patryk Zawadzki

commit sha 852ea7393678000d5d30e876242cd02dfa071c71

Update changelog

view details

push time in 9 days

push eventpatrys/forbidden-lands-foundry-vtt

Patryk Zawadzki

commit sha 473289b14677c150ff1c820fd02f17f58b5abb0d

Update gear, combat and monster sheets

view details

push time in 9 days

delete branch patrys/saleor

delete branch : add-watchman

delete time in 9 days

pull request commentmirumee/saleor

Install pywatchman for local development

Rebased on current master (poetry conflict).

patrys

comment created time in 9 days

push eventpatrys/saleor

Damian W

commit sha 1ce497b1ba627004d30420b5c9bd700ff6c2539b

Prevent creating checkout with unpublished product

view details

Damian W

commit sha 9876c1136f8f27b1bd280b56896c6f61efb6f79b

Validation message as a string

view details

Damian W

commit sha 651cadade5aea5bc62717cbb31bbb4b9169ac63c

Add checking code error in tests

view details

Damian W

commit sha 96401ca80d10e12eea9ca92e0d0382c4d8a3cf64

Prevent finalizing draft orders with unpublished product

view details

Damian W

commit sha e18fad792c5f094d200119120a13a8e4f4ceb384

Rename error message

view details

Damian W

commit sha 172b9b1e5c7ec99770f57352b6ca5c1fe833751e

Rename exception message

view details

Damian W

commit sha 024737502dfe74d2880c9dee52847d7a7297fd4f

Update changelog

view details

Marcin Gębala

commit sha db3f0c7aaef6e5f57f88aa34897b4c30d62e07cb

Merge pull request #5682 from mirumee/bugfix/create_checkout_with_unpublished_product Prevent creating checkout with unpublished product

view details

Patryk Zawadzki

commit sha 9e244aced52127031b082bdff066318204ed091b

Automatic plugin discovery

view details

Patryk Zawadzki

commit sha 3612e9cafaaa3dd5ac637f99da08d0d13405b2c8

Add docs to the PR template

view details

Marcin Gębala

commit sha 3bbe65aeade0ba5c23ddfd041a3d144ed8f58b6c

Update changelog and versions

view details

dependabot-preview[bot]

commit sha dc5b41fd61e1411b81ee5bb40f90255a602dce81

Bump boto3 from 1.13.11 to 1.13.16 Bumps [boto3](https://github.com/boto/boto3) from 1.13.11 to 1.13.16. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](https://github.com/boto/boto3/compare/1.13.11...1.13.16) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha 700fbcecaa98be4004be0e72fc9b295b78b05b3c

Bump pytest-cov from 2.8.1 to 2.9.0 Bumps [pytest-cov](https://github.com/pytest-dev/pytest-cov) from 2.8.1 to 2.9.0. - [Release notes](https://github.com/pytest-dev/pytest-cov/releases) - [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst) - [Commits](https://github.com/pytest-dev/pytest-cov/compare/v2.8.1...v2.9.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Marcin Gębala

commit sha d54614df71fc0cc4f51a1211b05546c84f7374b1

Merge pull request #5697 from mirumee/dependabot/pip/pytest-cov-2.9.0 Bump pytest-cov from 2.8.1 to 2.9.0

view details

dependabot-preview[bot]

commit sha 2db1752f6b711bd287dac3ae2720d11b0058cf83

Bump tox from 3.15.0 to 3.15.1 Bumps [tox](https://github.com/tox-dev/tox) from 3.15.0 to 3.15.1. - [Release notes](https://github.com/tox-dev/tox/releases) - [Changelog](https://github.com/tox-dev/tox/blob/master/docs/changelog.rst) - [Commits](https://github.com/tox-dev/tox/compare/3.15.0...3.15.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Marcin Gębala

commit sha 438858cb77811fbd48c2594e68443c010f38ce44

Merge pull request #5696 from mirumee/dependabot/pip/tox-3.15.1 Bump tox from 3.15.0 to 3.15.1

view details

dependabot-preview[bot]

commit sha 0ec3760ee5e67edda2ad80bb0673847195b91415

Bump phonenumberslite from 8.12.3 to 8.12.4 Bumps [phonenumberslite](https://github.com/daviddrysdale/python-phonenumbers) from 8.12.3 to 8.12.4. - [Release notes](https://github.com/daviddrysdale/python-phonenumbers/releases) - [Commits](https://github.com/daviddrysdale/python-phonenumbers/compare/v8.12.3...v8.12.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Marcin Gębala

commit sha 6ee8e0c94c6f09f7285caf0f6b0e3c1bab867584

Merge pull request #5695 from mirumee/dependabot/pip/phonenumberslite-8.12.4 Bump phonenumberslite from 8.12.3 to 8.12.4

view details

dependabot-preview[bot]

commit sha 50f4f6327c1bba5c2ae6307402013f74e0ee4889

Bump graphene-django from 2.10.0 to 2.10.1 Bumps [graphene-django](https://github.com/graphql-python/graphene-django) from 2.10.0 to 2.10.1. - [Release notes](https://github.com/graphql-python/graphene-django/releases) - [Commits](https://github.com/graphql-python/graphene-django/compare/v2.10.0...v2.10.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Marcin Gębala

commit sha 587dde0ee7c639bc2eb4ab165036cc4cee7ffc09

Merge pull request #5694 from mirumee/dependabot/pip/graphene-django-2.10.1 Bump graphene-django from 2.10.0 to 2.10.1

view details

push time in 9 days

push eventmirumee/saleor-docs

IKarbowiak

commit sha dd5bbb2a4d5584ebacd2ebd1f2293ec623153565

Add info about supported currencies to payment gateways section

view details

IKarbowiak

commit sha 812a8773975d5a6600ca5bd1718f82ff3a29368a

Update gateways info in developer checkout section

view details

Iga Karbowiak

commit sha 434ba8cc54cd4915d265528f7d3e5e19d11b5eab

Apply suggestions from code review - grammar changes Co-authored-by: Patryk Zawadzki <81205+patrys@users.noreply.github.com>

view details

Patryk Zawadzki

commit sha 0e5232d9fc4a03cc805e09a5da2ad20a712d1e8e

Merge pull request #145 from mirumee/add-info-about-supported-currencies-in-payment-gateways Add info about supported currencies in payment gateways

view details

push time in 9 days

delete branch mirumee/saleor-docs

delete branch : add-info-about-supported-currencies-in-payment-gateways

delete time in 9 days

PR merged mirumee/saleor-docs

Add info about supported currencies in payment gateways

Add information about supported currencies in gateways.

+15 -10

1 comment

2 changed files

IKarbowiak

pr closed time in 9 days

Pull request review commentmirumee/saleor-docs

Add info about supported currencies in payment gateways

 The resulting `Checkout` object contains the following fields: - `token`: similar to `id`, a unique identifier suitable for inclusion in emails and URLs. - `totalPrice`: the total price of the checkout lines and shipping costs. - `isShippingRequired`: denotes whether shipping is required for this checkout.-- `availablePaymentGateways`: a list of payment gateways that are currently configured on your Saleor server and can be used to pay for the checkout. For each gateway, API returns a ID, name and a config object, which for some gateways may return additional information required to process the payment in the frontend.+- `availablePaymentGateways`: a list of payment gateways that are currently configured on your Saleor server and can be used to pay for the checkout. Only gateways which support checkout currency are returned. For each gateway, API returns a ID, name, and a config object, which for some gateways may return additional information required to process the payment in the frontend.
- `availablePaymentGateways`: a list of payment gateways that are currently configured on your Saleor server and can be used to pay for the checkout. Only gateways which support the checkout currency are returned. For each gateway, API returns an ID, a name, and a config object, which for some gateways may return additional information required to process the payment in the frontend.
IKarbowiak

comment created time in 9 days

Pull request review commentmirumee/saleor-docs

Add info about supported currencies in payment gateways

 For more information on how to configure your plugin, see the [Plugins](dashboar  #### `GatewayConfig` -| Name                | Type   | Description                                                                                              |-| ------------------- | ------ | -------------------------------------------------------------------------------------------------------- |-| `gateway_name`      | `str`  | Define gateway name                                                                                      |-| `auto_capture`      | `bool` | Define if a gateway should also capture funds from the card. If false, payment should be only authorized |-| `connection_params` | `dict` | List of parameters used for connecting to the payment’s gateway                                          |-| `store_customer`    | `bool` | If set to True, the system will save this payment method for this customer                               |-| `require_3d_secure` | `bool` | Determines if gateway should enforce 3D secure verification during payment                               |+| Name                   | Type   | Description                                                                                              |+| ---------------------- | ------ | -------------------------------------------------------------------------------------------------------- |+| `gateway_name`         | `str`  | Define gateway name                                                                                      |+| `auto_capture`         | `bool` | Define if a gateway should also capture funds from the card. If false, payment should be only authorized |+| `supported_currencies` | `str`  | Define currencies which are supported by gateway                                                         |
| `supported_currencies` | `str`  | Define currencies which are supported by the gateway                                                     |
IKarbowiak

comment created time in 9 days

Pull request review commentmirumee/saleor-docs

Add info about supported currencies in payment gateways

 Saleor uses a universal flow that each gateway should implement by providing a c All of the plugins method takes `previous_value` as a second argument. More information about `previous_value` can be found [here](plugins#base-plugin-class). -For more information on the plugin implementation methods, see the `plugin.py` file for an existing payment gateway.+For gateway to work correctly you also need to specified `Supported currencies` in gateway configuration.
For a gateway to work correctly, you also need to specify `supported_currencies` in your gateway configuration.
IKarbowiak

comment created time in 9 days

Pull request review commentmirumee/saleor-docs

Add info about supported currencies in payment gateways

 Depending on the selected payment gateway, you will either use the JavaScript fo The `checkoutPaymentCreate` mutation requires the following input:  - `checkoutId`: the checkout ID.-- `gateway`: the ID of the selected payment gateway (list of the available payment gateways can be fetched from the `Checkout.availablePaymentGateways` field).+- `gateway`: the ID of the selected payment gateway (list of the available payment gateways can be fetched from the `Checkout.availablePaymentGateways` field). The selected gateway must support checkout currency.
- `gateway`: the ID of the selected payment gateway (list of the available payment gateways can be fetched from the `Checkout.availablePaymentGateways` field). The selected gateway must support the checkout currency.
IKarbowiak

comment created time in 9 days

push eventpatrys/saleor

Patryk Zawadzki

commit sha 422267276c6171803ffe9f30e4bf01569361bab6

Remove log duplication, use JSON in production

view details

push time in 10 days

push eventpatrys/saleor

Patryk Zawadzki

commit sha 1678ef1727014b70c401f771b3e9239b8f9f77a4

Remove log duplication, use JSON in production

view details

push time in 10 days

push eventpatrys/saleor

Patryk Zawadzki

commit sha 9e244aced52127031b082bdff066318204ed091b

Automatic plugin discovery

view details

Patryk Zawadzki

commit sha 3612e9cafaaa3dd5ac637f99da08d0d13405b2c8

Add docs to the PR template

view details

dependabot-preview[bot]

commit sha dc5b41fd61e1411b81ee5bb40f90255a602dce81

Bump boto3 from 1.13.11 to 1.13.16 Bumps [boto3](https://github.com/boto/boto3) from 1.13.11 to 1.13.16. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](https://github.com/boto/boto3/compare/1.13.11...1.13.16) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha 700fbcecaa98be4004be0e72fc9b295b78b05b3c

Bump pytest-cov from 2.8.1 to 2.9.0 Bumps [pytest-cov](https://github.com/pytest-dev/pytest-cov) from 2.8.1 to 2.9.0. - [Release notes](https://github.com/pytest-dev/pytest-cov/releases) - [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst) - [Commits](https://github.com/pytest-dev/pytest-cov/compare/v2.8.1...v2.9.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Marcin Gębala

commit sha d54614df71fc0cc4f51a1211b05546c84f7374b1

Merge pull request #5697 from mirumee/dependabot/pip/pytest-cov-2.9.0 Bump pytest-cov from 2.8.1 to 2.9.0

view details

dependabot-preview[bot]

commit sha 2db1752f6b711bd287dac3ae2720d11b0058cf83

Bump tox from 3.15.0 to 3.15.1 Bumps [tox](https://github.com/tox-dev/tox) from 3.15.0 to 3.15.1. - [Release notes](https://github.com/tox-dev/tox/releases) - [Changelog](https://github.com/tox-dev/tox/blob/master/docs/changelog.rst) - [Commits](https://github.com/tox-dev/tox/compare/3.15.0...3.15.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Marcin Gębala

commit sha 438858cb77811fbd48c2594e68443c010f38ce44

Merge pull request #5696 from mirumee/dependabot/pip/tox-3.15.1 Bump tox from 3.15.0 to 3.15.1

view details

dependabot-preview[bot]

commit sha 0ec3760ee5e67edda2ad80bb0673847195b91415

Bump phonenumberslite from 8.12.3 to 8.12.4 Bumps [phonenumberslite](https://github.com/daviddrysdale/python-phonenumbers) from 8.12.3 to 8.12.4. - [Release notes](https://github.com/daviddrysdale/python-phonenumbers/releases) - [Commits](https://github.com/daviddrysdale/python-phonenumbers/compare/v8.12.3...v8.12.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Marcin Gębala

commit sha 6ee8e0c94c6f09f7285caf0f6b0e3c1bab867584

Merge pull request #5695 from mirumee/dependabot/pip/phonenumberslite-8.12.4 Bump phonenumberslite from 8.12.3 to 8.12.4

view details

dependabot-preview[bot]

commit sha 50f4f6327c1bba5c2ae6307402013f74e0ee4889

Bump graphene-django from 2.10.0 to 2.10.1 Bumps [graphene-django](https://github.com/graphql-python/graphene-django) from 2.10.0 to 2.10.1. - [Release notes](https://github.com/graphql-python/graphene-django/releases) - [Commits](https://github.com/graphql-python/graphene-django/compare/v2.10.0...v2.10.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Marcin Gębala

commit sha 587dde0ee7c639bc2eb4ab165036cc4cee7ffc09

Merge pull request #5694 from mirumee/dependabot/pip/graphene-django-2.10.1 Bump graphene-django from 2.10.0 to 2.10.1

view details

Marcin Gębala

commit sha 4e015e23316ed217e43e56dc8b3f9c7362b4884f

Merge pull request #5687 from mirumee/pull-request-template-update Add docs to the PR template

view details

dependabot-preview[bot]

commit sha d02f06a52f2387ef0b0395cd3f95f49ec9224f46

Bump codecov from 2.0.22 to 2.1.3 Bumps [codecov](https://github.com/codecov/codecov-python) from 2.0.22 to 2.1.3. - [Release notes](https://github.com/codecov/codecov-python/releases) - [Changelog](https://github.com/codecov/codecov-python/blob/master/CHANGELOG.md) - [Commits](https://github.com/codecov/codecov-python/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Marcin Gębala

commit sha a75256436e4af4572f6af152558c2e7a2e3d0fbc

Merge pull request #5693 from mirumee/dependabot/pip/codecov-2.1.3 Bump codecov from 2.0.22 to 2.1.3

view details

Marcin Gębala

commit sha 9f3a6de4e1289b6b48cabd2dbbacdafc56e233eb

Merge pull request #5691 from mirumee/dependabot/pip/boto3-1.13.16 Bump boto3 from 1.13.11 to 1.13.16

view details

dependabot-preview[bot]

commit sha e03efe9b20d4eb7e4a73a2ff56c11370abbce56c

Bump flake8 from 3.8.1 to 3.8.2 Bumps [flake8](https://gitlab.com/pycqa/flake8) from 3.8.1 to 3.8.2. - [Release notes](https://gitlab.com/pycqa/flake8/tags) - [Commits](https://gitlab.com/pycqa/flake8/compare/3.8.1...3.8.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Marcin Gębala

commit sha ea8e38c61f92646077320f2b62e598c64c9075bc

Merge pull request #5692 from mirumee/dependabot/pip/flake8-3.8.2 Bump flake8 from 3.8.1 to 3.8.2

view details

Damian W

commit sha 42b375ce77c4e9f21ece3a61b93528225463d111

Remove price field from product/Create price field for product variant

view details

Damian W

commit sha ec636ceac90f054d4b1dc86b1ebf7f670ded12f6

Remove price field from product/Create price field for product variant

view details

Patryk Zawadzki

commit sha ba338a65251d1fc1d877d0fdd35d044325839589

Fix two problems found by LGTM First is incomplatible default values in the PaymentInterface, second is wrong value displayed by shipping models.

view details

push time in 10 days

push eventmirumee/saleor-docs

Maciej Korycinski

commit sha 5852c1607bb4b0b72c3af878aa5e0ea04a35a8c5

Update documentation about jwt token

view details

Maciej Korycinski

commit sha cbc90b29d43c9047844944f5c5903508ca2ac5d0

Clean up before review

view details

Maciej Korycinski

commit sha d7aa507ed7cc0d7bf4841c821f2c8f7aeea893f4

Add section -'Deactivating all user's tokens, add JWT_DONT_EXPIRE definition in configuration

view details

Maciej Korycinski

commit sha b35e847b03e7c43b0772e8b87fc20b08b7c3deec

Add section for REQUEST_EMAIL_CHANGE_TOKEN_EXPIRATION_DELTA

view details

Maciej Korycinski

commit sha ca52e9fb9aaac60ccb5ed0c8a3f1c00208b557a4

Update docs after change the name of the saleor's env

view details

Patryk Zawadzki

commit sha 31d7727c13af095d4083762619a98357afb17e2a

Rephrase TTL descriptions

view details

Patryk Zawadzki

commit sha 63dd72d83d1773dbef3e36295224e9f88a26c773

Update the docs

view details

Maciej Korycinski

commit sha ce10b39628ed71b037788cb5e1f6c1a17980f8e9

Update section about csrf input param

view details

Maciej Korycinski

commit sha 76711e8e943438c6346e4352c38ad3a5791d3054

Remove unneeded space in example of tokenRefresh mutation Co-authored-by: Patryk Zawadzki <81205+patrys@users.noreply.github.com>

view details

Patryk Zawadzki

commit sha a50123371db6c3682b5241704745c79e1f96d1ea

Fix accidental change

view details

Patryk Zawadzki

commit sha 86d36e6fd5a37352cb2e06b37776bc2db6005385

Merge pull request #134 from mirumee/update-jwt-section Update jwt section

view details

push time in 10 days

delete branch mirumee/saleor-docs

delete branch : update-jwt-section

delete time in 10 days

PR merged mirumee/saleor-docs

Update jwt section

Update docs for changes from PR: https://github.com/mirumee/saleor/pull/5734

+114 -20

1 comment

2 changed files

korycins

pr closed time in 10 days

push eventpatrys/forbidden-lands-foundry-vtt

Patryk Zawadzki

commit sha 120678defd8749b97e71af78a0661526ecf7cfba

Improve the combat tab

view details

push time in 10 days

push eventpatrys/forbidden-lands-foundry-vtt

Patryk Zawadzki

commit sha 1402572004e6579551aae7ac9d80ea4168d0b65b

Add some dropdowns to weapon editor

view details

push time in 10 days

push eventpatrys/forbidden-lands-foundry-vtt

Patryk Zawadzki

commit sha 1b819616ce687d1ad143990fcce4fe202c61d6ea

Fix monster rolling

view details

Patryk Zawadzki

commit sha 00fae20344e0d72744fbc8e34f7136a288bf8a7e

Merge branch 'port-style-from-roll20' of github.com:patrys/forbidden-lands-foundry-vtt into port-style-from-roll20

view details

Patryk Zawadzki

commit sha 473fed84c7fc9beffad39806f52cc0a328256bd7

Implement proper gear scrolling

view details

push time in 10 days

push eventpatrys/forbidden-lands-foundry-vtt

Patryk Zawadzki

commit sha 9ec4c965e56c9cd1dfb12d65746f4a57e65bfa9c

Give all items variable bonus, improve gear page

view details

push time in 10 days

Pull request review commentmirumee/saleor

Feature/add jwt for apps

 def get_user_from_access_token(token: str) -> Optional[User]:     payload = jwt_decode(token)     if payload["type"] not in [JWT_ACCESS_TYPE, JWT_THIRDPARTY_ACCESS_TYPE]:         return None-    permission_limits = payload.get(PERMISSION_LIMITS_FIELD, None)+    permissions = payload.get(PERMISSIONS_FIELD, None)     user = get_user_from_payload(payload)-    if permission_limits is not None:-        user.permission_limits = permission_limits  # type: ignore+    if user and permissions is not None:+        user.effective_permissions = get_permissions_from_names(permissions)

Shouldn't we cross-check those with the database permissions? Can a token grant me permission I did not previously hold?

korycins

comment created time in 10 days

MemberEvent
MemberEvent

Pull request review commentmirumee/saleor

Better way of handling token expiration and old type of jwt tokens

 All notable, unreleased changes to this project will be documented in this file. - Fix specific product voucher in draft orders - #5727 by @fowczarek - Explicit country assignment in default shipping zones - #5736 by @maarcingebala - Drop `json_content` field from the `Menu` model - #5761 by @maarcingebala-- Refactor JWT support - #5734 by @korycins+- Refactor JWT support - These changes could require a handling JWT token in the storefront. Storefront needs to handle a case when the backend returns the exception about the invalid token. - #5734, #5816 by @korycins

Or just a large "breaking changes" section at the very top of the changelog? Once Cloud becomes public we will have to withhold any breaking changes until the next major release.

korycins

comment created time in 11 days

push eventpatrys/forbidden-lands-foundry-vtt

Patryk Zawadzki

commit sha 8045ccdfa81bbf3b8ff605be968f461e82a669be

Add support for Calendar/Weather

view details

push time in 11 days

push eventpatrys/forbidden-lands-foundry-vtt

Patryk Zawadzki

commit sha 09ef6d16a617e7296636e4a794cea73d83845f95

Add support for Tokenizer

view details

push time in 11 days

PR opened algolia/docsearch-configs

Update the Saleor config to match Docusaurus 2

Pull request motivation(s)

Since we're using Docusaurus 2 now, I believe the search configs of the two should match.

What is the current behaviour?

Currently, the page is not fully indexed.

What is the expected behaviour?

The page being fully indexed.

NB: Do you want to request a feature or report a bug?

Neither, I'm updating the search config of a project.

NB2: Any other feedback / questions ?

<!-- The CI will check that the configuration is compliant with the JSON schema we have defined, please make sure the check is passed. Let us know if you do not get the issue. -->

+8 -13

0 comment

1 changed file

pr created time in 11 days

push eventpatrys/docsearch-configs

Patryk Zawadzki

commit sha a5fd6ccd980b72db7441f6862b66632d66c2b955

Update the Saleor config to match Docusaurus 2 Since we're using Docusaurus 2 now, I believe the search configs of the two should match.

view details

push time in 11 days

Pull request review commentmirumee/saleor

Better way of handling token expiration and old type of jwt tokens

 def get_token_from_request(request: WSGIRequest) -> Optional[str]:  def get_user_from_payload(payload: Dict[str, Any]) -> Optional[User]:     user = User.objects.filter(email=payload["email"], is_active=True).first()-    if user and user.jwt_token_key == payload["token"]:-        return user-    return None+    user_jwt_token = payload.get("token")+    if not user_jwt_token or not user:+        raise InvalidTokenError(+            "Invalid token. Create new one by using tokenCreate mutation."+        )+    if user.jwt_token_key != user_jwt_token:+        raise ExpiredUserSignatureError(+            "User requested to expire this token. Create new one by using tokenCreate "

I'm with @maarcingebala here but I'm not sure we should be treating this the same as token expired or as an invalid token. Clients will likely attempt to refresh expired tokens which will fail in this case so it's a wasted API call.

korycins

comment created time in 11 days

push eventmirumee/saleor-docs

IKarbowiak

commit sha c5c355f69e508ee6f779d592c9c741e72f00a2fa

Add key concepts for Sorters section

view details

IKarbowiak

commit sha bc387cb4cffcc99980b3ab7bade299a83f049d75

Add info about adding sorter to query

view details

IKarbowiak

commit sha f2f89e5bc08089d38f57254453b59065289ba4c8

Add info how to add custom sorter

view details

IKarbowiak

commit sha 024c7d0964d23b690fa8042ee46021b123b60f5b

Correct the grammar in sorters section

view details

IKarbowiak

commit sha 3634e924dde573920fe0759d5551d31ff52460ed

Add highlights to code parts in sorters section

view details

IKarbowiak

commit sha fd98a4d0c79336f649ccdf56f7994924638097f2

Add notes about field names in sorters section

view details

Patryk Zawadzki

commit sha e8ba71df47ce685d0caa976b700aa188f87ca2e1

Small grammar improvements

view details

Patryk Zawadzki

commit sha 4e4d4b64d7e057eb5f10d9f1cf9ca30eab76c096

Backport docs to 2.10

view details

Patryk Zawadzki

commit sha 53a7d198ab65d2bee3ceccd9f2c4f3046530b8ff

Merge pull request #144 from mirumee/add-sorters-section Add sorters section

view details

push time in 11 days

delete branch mirumee/saleor-docs

delete branch : add-sorters-section

delete time in 11 days

PR merged mirumee/saleor-docs

Add sorters section

Add document how to add sorter to query resolver and how to customize it.

+257 -0

0 comment

4 changed files

IKarbowiak

pr closed time in 11 days

push eventmirumee/saleor-docs

Patryk Zawadzki

commit sha 4e4d4b64d7e057eb5f10d9f1cf9ca30eab76c096

Backport docs to 2.10

view details

push time in 11 days

push eventmirumee/saleor-docs

Patryk Zawadzki

commit sha e8ba71df47ce685d0caa976b700aa188f87ca2e1

Small grammar improvements

view details

push time in 11 days

push eventmirumee/saleor-docs

IKarbowiak

commit sha f50e29aec43dc1aa9edc540f053c8665bb41456b

Update developer payment-gateways section

view details

Patryk Zawadzki

commit sha c6139aa9f041accdda367eceac6c0c3d33190280

Backport changes to 2.10 docs

view details

Patryk Zawadzki

commit sha ae8282b4dc964d095838c08d2dd281344b2ac09a

Small grammar fixes

view details

Patryk Zawadzki

commit sha bfbba45b9f84d206144946fb709bfff3412afe1b

Merge pull request #143 from mirumee/update-payment-gateways-section Update developer payment-gateways section

view details

push time in 12 days

delete branch mirumee/saleor-docs

delete branch : update-payment-gateways-section

delete time in 12 days

PR merged mirumee/saleor-docs

Reviewers
Update developer payment-gateways section

Update developer payment-gateways section - some part of this section was out-of-date.

+54 -20

1 comment

2 changed files

IKarbowiak

pr closed time in 12 days

push eventmirumee/saleor-docs

Patryk Zawadzki

commit sha ae8282b4dc964d095838c08d2dd281344b2ac09a

Small grammar fixes

view details

push time in 12 days

push eventmirumee/saleor-docs

Patryk Zawadzki

commit sha c6139aa9f041accdda367eceac6c0c3d33190280

Backport changes to 2.10 docs

view details

push time in 12 days

pull request commentmirumee/saleor-docs

Update developer payment-gateways section

Should I backport this to 2.10 docs as well?

IKarbowiak

comment created time in 12 days

push eventmirumee/saleor-docs

Patryk Zawadzki

commit sha aefe28cdd2a80095a37971aebe0ef2291579945f

Fix domain and sitemap

view details

push time in 12 days

push eventpatrys/forbidden-lands-foundry-vtt

Patryk Zawadzki

commit sha 09ef4d260c745d69177f431fca36f1c7e2ffb2ed

Rework the header and the gear tab

view details

push time in 12 days

push eventpatrys/forbidden-lands-foundry-vtt

Patryk Zawadzki

commit sha 4c6400f8e2ff5a069c02948d94a0977fb3083ad4

Start rebuilding the gear tab

view details

push time in 12 days

Pull request review commentmirumee/ariadne-website

Update scalars documentation

 from thirdpartylib import json_serialize_money, json_deserialize_money money = ScalarType("Money") money.set_serializer(json_serialize_money) money.set_value_parser(json_deserialize_money)-money.set_literal_parser(json_deserialize_money) ```++> **Note:** the previous versions of this document also introduced the `literal_parser`. However in the light of `literal_parser` [reference documentation being incorrect](https://github.com/graphql/graphql-js/issues/2567) and the very usefulness of custom literal parsers [being discussed](https://github.com/graphql/graphql-js/issues/2657) we've decided to don't document it here anymore.
> **Note:** the previous versions of this document also introduced the `literal_parser`. However in the light of `literal_parser` [reference documentation being incorrect](https://github.com/graphql/graphql-js/issues/2567) and the usefulness of custom literal parsers [being discussed](https://github.com/graphql/graphql-js/issues/2657) we've decided to no longer document it in this section.
rafalp

comment created time in 12 days

pull request commentmirumee/saleor

Add edit channel mutation

fowczarek

comment created time in 13 days

create barnchpatrys/forbidden-lands-foundry-vtt

branch : port-style-from-roll20

created branch time in 13 days

fork patrys/forbidden-lands-foundry-vtt

A system for playing Forbidden Lands on Foundry VTT

fork in 15 days

startedPerfectro/forbidden-lands-foundry-vtt

started time in 15 days

push eventmirumee/saleor-docs

Patryk Zawadzki

commit sha d8f3f01d3a485931dda51663a95d97b29c7d5e5b

Upgrade to latest Docusaurus

view details

push time in 15 days

delete branch mirumee/saleor-docs

delete branch : add-error-reference-to-2.10

delete time in 15 days

push eventmirumee/saleor-docs

Patryk Zawadzki

commit sha f06e2d0a955b912ee63ec87b0b53587566584b49

Backport error documentation to 2.10 docs

view details

Patryk Zawadzki

commit sha b98b08a5abea9295d41b0323f9dfae70d962901a

Merge pull request #142 from mirumee/add-error-reference-to-2.10 Backport error documentation to 2.10 docs

view details

push time in 15 days

Pull request review commentmirumee/saleor

Feature/add jwt for apps

 def get_user_from_payload(payload: Dict[str, Any]) -> Optional[User]:  def get_user_from_access_token(token: str) -> Optional[User]:     payload = jwt_decode(token)-    if payload["type"] != JWT_ACCESS_TYPE:+    if payload["type"] not in [JWT_ACCESS_TYPE, JWT_THIRDPARTY_ACCESS_TYPE]:         return None-    return get_user_from_payload(payload)+    permission_limits = payload.get(PERMISSION_LIMITS_FIELD, None)+    user = get_user_from_payload(payload)+    if permission_limits is not None:+        user.permission_limits = permission_limits  # type: ignore

Or call the field effective_permissions and populate with whatever sits in the database when not set by the token. This way we can only check one place (and we can probably speed up most of the permission-related checks by removing the database queries required to insert the permissions).

korycins

comment created time in 15 days

push eventmirumee/saleor-docs

Patryk Zawadzki

commit sha 4d35a287bfa12bf36f3975e949859d676d560d74

Set the index page

view details

push time in 15 days

Pull request review commentmirumee/saleor

Rebuild jwt token flow to our implementation

+import pytest+from django.core.handlers.base import BaseHandler+from freezegun import freeze_time++from ..jwt import JWT_REFRESH_TOKEN_COOKIE_NAME, create_refresh_token+++@pytest.mark.parametrize("expire", [True, False])

I feel those are two separate test cases disguised to look like one 😄

korycins

comment created time in 16 days

more