profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/otecteng/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

otecteng/weixin-pub 27

weixin公众账号接口

otecteng/repo-fellow 5

Code repo inspector

mingjin/fog 3

The Ruby cloud services library.

otecteng/docker-symphony 2

make dockers play images easily

otecteng/blogs 1

tech blogs

otecteng/bootstrap-datepicker 1

A datepicker for @twitter bootstrap forked from Stefan Petre's (of eyecon.ro), improvements by @eternicode

push eventelastic/kibana

CJ Cenizal

commit sha 9a5efd88877b916cd0a6fabb38e5c8fa014ae8de

Migrate Index Management to new solutions nav (#101548) (#103029) * Migrate index template and component template wizard pages to new nav. * Convert index templates and component templates pages to new nav. * Convert indices and data streams pages to new nav. * Add PageLoading component to es_ui_shared. * Refactor index table component tests. * Add missing error reporting to get all templates API route handler. # Conflicts: # x-pack/plugins/index_management/server/routes/api/templates/register_get_routes.ts

view details

push time in a minute

PR merged elastic/kibana

[7.x] Migrate Index Management to new solutions nav (#101548) backport

Backports the following commits to 7.x:

  • Migrate Index Management to new solutions nav (#101548)
+663 -566

1 comment

34 changed files

cjcenizal

pr closed time in a minute

pull request commentelastic/kibana

[7.x] Migrate Index Management to new solutions nav (#101548)

:green_heart: Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
esUiShared 153 155 +2
indexManagement 519 515 -4
total -2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
esUiShared 88 90 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 1.3MB 1.3MB -2.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
esUiShared 191.8KB 192.5KB +770.0B

<details><summary>Unknown metric groups</summary>

API count

id before after diff
esUiShared 90 92 +2

</details>

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

<!--PIPELINE {"builds":[{"status":"SUCCESS","url":"https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/133396/","number":"133396","commit":"d2bec76b3f932d1e17256fa5727da1507a8cf711"}]} PIPELINE-->

cjcenizal

comment created time in a minute

push eventelastic/kibana

Bhavya RM

commit sha d4019b843b615024e7b7c8181ba2e9b516c7f2d5

Replacing es_archives/reporting/ecommerce_kibana with kbn_archiver/reporting/ecommerce.json as part of migrating to kbn_archiver (#102825) (#103027) # Conflicts: # x-pack/test/functional/es_archives/reporting/ecommerce_kibana/data.json # x-pack/test/functional/es_archives/reporting/ecommerce_kibana/mappings.json

view details

push time in 9 minutes

PR merged elastic/kibana

[7.x] Replacing es_archives/reporting/ecommerce_kibana with kbn_archiver/reporting/ecommerce.json as part of migrating to kbn_archiver (#102825) Feature:Reporting Team:QA backport release_note:skip test_xpack_functional v7.14.0

Backports the following commits to 7.x:

  • Replacing es_archives/reporting/ecommerce_kibana with kbn_archiver/reporting/ecommerce.json as part of migrating to kbn_archiver (#102825)
+709 -3428

2 comments

10 changed files

bhavyarm

pr closed time in 9 minutes

pull request commentelastic/kibana

[7.x] Replacing es_archives/reporting/ecommerce_kibana with kbn_archiver/reporting/ecommerce.json as part of migrating to kbn_archiver (#102825)

:green_heart: Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

cc @bhavyarm

<!--PIPELINE {"builds":[{"status":"SUCCESS","url":"https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/133393/","number":"133393","commit":"6c4b1f7f65702c6dbbab2e12ba2df56c8da12dbc"}]} PIPELINE-->

bhavyarm

comment created time in 9 minutes

issue openedelastic/kibana

Failing test: X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/exception_operators_data_types/keyword·ts - detection engine api security and spaces enabled Detection exceptions data types and operators Rule exception operators for data type keyword "after each" hook for "will return 2 results if we have a list that excludes 2 keyword"

A test failed on a tracked branch

ConnectionError: connect ECONNREFUSED 127.0.0.1:61122
    at ClientRequest.onError (/dev/shm/workspace/parallel/12/kibana/node_modules/@elastic/elasticsearch/lib/Connection.js:115:16)
    at TLSSocket.socketErrorListener (_http_client.js:475:9)
    at emitErrorNT (internal/streams/destroy.js:106:8)
    at emitErrorCloseNT (internal/streams/destroy.js:74:3)
    at processTicksAndRejections (internal/process/task_queues.js:82:21) {
  meta: {
    body: null,
    statusCode: null,
    headers: null,
    meta: {
      context: null,
      request: [Object],
      name: 'elasticsearch-js',
      connection: [Object],
      attempts: 3,
      aborted: false
    }
  }
}

First failure: Jenkins Build

<!-- kibanaCiData = {"failed-test":{"test.class":"X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/exception_operators_data_types/keyword·ts","test.name":"detection engine api security and spaces enabled Detection exceptions data types and operators Rule exception operators for data type keyword "after each" hook for "will return 2 results if we have a list that excludes 2 keyword"","test.failCount":1}} -->

created time in 10 minutes

PR opened elastic/kibana

[Security Solution] Correct linux OS lookup for Endpoint Exceptions

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

+10 -2

0 comment

1 changed file

pr created time in 16 minutes

issue openedelastic/kibana

Failing test: Jest Tests.x-pack/plugins/actions/server/lib - successfully executes

A test failed on a tracked branch

Error: expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `successfully executes 1`

- Snapshot  -  0
+ Received  + 19

@@ -1,9 +1,28 @@
  Array [
    Array [
      Object {
        "event": Object {
+         "action": "execute-start",
+       },
+       "kibana": Object {
+         "saved_objects": Array [
+           Object {
+             "id": "1",
+             "namespace": "some-namespace",
+             "rel": "primary",
+             "type": "action",
+             "type_id": "test",
+           },
+         ],
+       },
+       "message": "action started: test:1: 1",
+     },
+   ],
+   Array [
+     Object {
+       "event": Object {
          "action": "execute",
          "outcome": "success",
        },
        "kibana": Object {
          "saved_objects": Array [
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+master/kibana/x-pack/plugins/actions/server/lib/action_executor.test.ts:112:43)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at _callCircusTest (/var/lib/jenkins/workspace/elastic+kibana+master/kibana/node_modules/jest-circus/build/run.js:212:5)
    at _runTest (/var/lib/jenkins/workspace/elastic+kibana+master/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+master/kibana/node_modules/jest-circus/build/run.js:63:9)
    at run (/var/lib/jenkins/workspace/elastic+kibana+master/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/jenkins/workspace/elastic+kibana+master/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+master/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+master/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+master/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+master/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

First failure: Jenkins Build

<!-- kibanaCiData = {"failed-test":{"test.class":"Jest Tests.x-pack/plugins/actions/server/lib","test.name":"successfully executes","test.failCount":1}} -->

created time in 20 minutes

pull request commentelastic/kibana

[Enterprise Search] Support active nav links that have both subnav & non-subnav child routes

@elasticmachine merge upstream

constancecchen

comment created time in 20 minutes

pull request commentelastic/kibana

[Enterprise Search] Support active nav links that have both subnav & non-subnav child routes

:hourglass_flowing_sand: Build in-progress, with failures

Failed CI Steps

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

<!--PIPELINE {"builds":[{"status":"FAILURE","url":"https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/133404/","number":"133404","commit":"71b36940b78c2621e4494ae4e09dbbaeab9c4116"}]} PIPELINE-->

constancecchen

comment created time in 32 minutes

Pull request review commentelastic/kibana

[Enterprise Search] Support active nav links that have both subnav & non-subnav child routes

 import { setMockValues } from '../../../__mocks__/kea_logic';  jest.mock('../../../shared/layout', () => ({-  generateNavLink: jest.fn(({ to }) => ({ href: to })),+  generateNavLink: jest.fn(({ to, items }) => ({ href: to, items })),

I'm thinking about DRYing out an importable mock for shared/layout/generateNavLink at some point since a few different nav files use it, but might save that for the final page template PR

constancecchen

comment created time in an hour

Pull request review commentelastic/kibana

[Enterprise Search] Support active nav links that have both subnav & non-subnav child routes

 export const ENGINE_REINDEX_JOB_PATH = `${ENGINE_SCHEMA_PATH}/reindex_job/:reind export const ENGINE_CRAWLER_PATH = `${ENGINE_PATH}/crawler`; export const ENGINE_CRAWLER_DOMAIN_PATH = `${ENGINE_CRAWLER_PATH}/domains/:domainId`; -export const META_ENGINE_CREATION_PATH = '/meta_engine_creation';+export const META_ENGINE_CREATION_PATH = `${ENGINES_PATH}/new_meta_engine`; // This is safe from conflicting with an :engineName path because engine names cannot have underscores

[AS] This is not the same route as the old standalone UI - I think it was /meta_engines/new there.

I'm not 100% sold on /engines/new_meta_engine myself - do folks prefer something more like /engines/new/meta_engine?

constancecchen

comment created time in an hour

Pull request review commentelastic/kibana

[Enterprise Search] Support active nav links that have both subnav & non-subnav child routes

 export const CREDENTIALS_PATH = '/credentials'; export const ROLE_MAPPINGS_PATH = '/role_mappings';  export const ENGINES_PATH = '/engines';-export const ENGINE_CREATION_PATH = '/engine_creation';+export const ENGINE_CREATION_PATH = `${ENGINES_PATH}/new`; // This is safe from conflicting with an :engineName path because new is a reserved name

[AS] /engines/new is the same route used in the standalone UI

constancecchen

comment created time in an hour

pull request commentelastic/kibana

[Fleet] Add UI and mappings for agent policy unenroll_timeout

:green_heart: Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1013 1014 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 680.0KB 681.3KB +1.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 439.1KB 439.1KB +13.0B

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id before after diff
ingest-agent-policies 14 15 +1

<details><summary>Unknown metric groups</summary>

API count

id before after diff
fleet 1104 1105 +1

</details>

History

  • :green_heart: Build #133326 succeeded 8c8f29f440e9f76d8160b6c3873d12c130d92ecd
  • :broken_heart: Build #133315 failed 901c0a6a7e54c4255aebb5ed43d493087201915d
  • :green_heart: Build #133262 succeeded 30b1120eccfca4873b6b1c458ddd7baa986190e4

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

cc @jfsiii

<!--PIPELINE {"builds":[{"status":"SUCCESS","url":"https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/133262/","number":"133262","commit":"30b1120eccfca4873b6b1c458ddd7baa986190e4"},{"status":"FAILURE","url":"https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/133315/","number":"133315","commit":"901c0a6a7e54c4255aebb5ed43d493087201915d"},{"status":"SUCCESS","url":"https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/133326/","number":"133326","commit":"8c8f29f440e9f76d8160b6c3873d12c130d92ecd"},{"status":"SUCCESS","url":"https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/133384/","number":"133384","commit":"c36fddaa5e14a6ff81c26c8b428c0cc2ba084ba2"}]} PIPELINE-->

jfsiii

comment created time in an hour

PR opened elastic/kibana

Reviewers
[Enterprise Search] Support active nav links that have both subnav & non-subnav child routes auto-backport release_note:skip v7.14.0

Summary

This functionality was requested by Vadim in https://github.com/elastic/kibana/pull/102592#discussion_r654570694, but it benefits both Workplace Search (Sources) and App Search (Engines).

In the case of both WS Sources and AS Engines, their side nav links have a subnav (the items array) for single Source or single Engine navigation, but it also has a "Create Source"/"Create Engine" link or route of some sort that should not show a subnav, but should still highlight the parent Sources/Engines link as active.

The problem prior to this PR is that we cannot simply throw on an shouldShowActiveForSubroutes flag, because the parent link shouldn't show active for subroutes while its subnav is open/has active links:

Left: Behavior with only shouldShowActiveForSubroutes; Right: how EUI demonstrates active nested links

This PR addresses that problem by passing the items subnav into our generateNavLink helper, which then uses items to determine whether or not the nav link should be shown as active (isSelected) or not.

Screencaps

Workplace Search

Before

After

ws_after

App Search

Before

After

create_engines

Checklist

+84 -27

0 comment

10 changed files

pr created time in an hour

Pull request review commentelastic/kibana

Implement new security solution wrapper

+/*+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one+ * or more contributor license agreements. Licensed under the Elastic License+ * 2.0; you may not use this file except in compliance with the Elastic License+ * 2.0.+ */++import React from 'react';+import { useHistory } from 'react-router-dom';+import { APP_ID } from '../../../../../common/constants';+import { track, METRIC_TYPE, TELEMETRY_EVENT } from '../../../lib/telemetry';+import { getSearch } from '../helpers';+import { PrimaryNavigationItemsProps } from './types';+import { useKibana } from '../../../lib/kibana';+import { SecurityPageName } from '../../../../app/types';+import { useFormatUrl } from '../../link_to';++export const usePrimaryNavigationItems = ({+  filters,+  navTabs,+  query,+  savedQuery,+  selectedTabId,+  sourcerer,+  timeline,+  timerange,+}: PrimaryNavigationItemsProps) => {+  const history = useHistory();+  const { navigateToApp, getUrlForApp } = useKibana().services.application;++  const navItems = Object.values(navTabs).map((tab) => {+    const { id, href, name, disabled, pageId } = tab;+    // Rules of hooks prevents hooks from being called in callbacks as the order of the hooks+    // should be consistent across every render. The primary nav tabs here are from a constants file+    // not dynamically generated, so their order will remain consistent across renders.+    // eslint-disable-next-line react-hooks/rules-of-hooks+    const { formatUrl } = useFormatUrl(((pageId ?? id) as unknown) as SecurityPageName);+    const isSelected = selectedTabId === id;+    const urlSearch = getSearch(tab, {+      filters,+      query,+      savedQuery,+      sourcerer,+      timeline,+      timerange,+    });+    const hrefWithSearch =+      tab.href + getSearch(tab, { filters, query, savedQuery, sourcerer, timeline, timerange });++    const handleClick = (ev: React.MouseEvent) => {+      ev.preventDefault();+      if (id in SecurityPageName && pageId == null) {+        navigateToApp(`${APP_ID}:${id}`, { path: urlSearch });

but all this stuff will be changed in follow up PR with @semd

michaelolo24

comment created time in an hour

Pull request review commentelastic/kibana

Implement new security solution wrapper

+/*+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one+ * or more contributor license agreements. Licensed under the Elastic License+ * 2.0; you may not use this file except in compliance with the Elastic License+ * 2.0.+ */++import React from 'react';+import { useHistory } from 'react-router-dom';+import { APP_ID } from '../../../../../common/constants';+import { track, METRIC_TYPE, TELEMETRY_EVENT } from '../../../lib/telemetry';+import { getSearch } from '../helpers';+import { PrimaryNavigationItemsProps } from './types';+import { useKibana } from '../../../lib/kibana';+import { SecurityPageName } from '../../../../app/types';+import { useFormatUrl } from '../../link_to';++export const usePrimaryNavigationItems = ({+  filters,+  navTabs,+  query,+  savedQuery,+  selectedTabId,+  sourcerer,+  timeline,+  timerange,+}: PrimaryNavigationItemsProps) => {+  const history = useHistory();+  const { navigateToApp, getUrlForApp } = useKibana().services.application;++  const navItems = Object.values(navTabs).map((tab) => {+    const { id, href, name, disabled, pageId } = tab;+    // Rules of hooks prevents hooks from being called in callbacks as the order of the hooks+    // should be consistent across every render. The primary nav tabs here are from a constants file+    // not dynamically generated, so their order will remain consistent across renders.+    // eslint-disable-next-line react-hooks/rules-of-hooks+    const { formatUrl } = useFormatUrl(((pageId ?? id) as unknown) as SecurityPageName);+    const isSelected = selectedTabId === id;+    const urlSearch = getSearch(tab, {+      filters,+      query,+      savedQuery,+      sourcerer,+      timeline,+      timerange,+    });+    const hrefWithSearch =+      tab.href + getSearch(tab, { filters, query, savedQuery, sourcerer, timeline, timerange });++    const handleClick = (ev: React.MouseEvent) => {+      ev.preventDefault();+      if (id in SecurityPageName && pageId == null) {+        navigateToApp(`${APP_ID}:${id}`, { path: urlSearch });

I think the reason was to avoid a mount of the app

michaelolo24

comment created time in an hour

pull request commentelastic/kibana

[7.x] [alerting][actions] add task scheduled date and delay to event log (#102252)

:hourglass_flowing_sand: Build in-progress, with failures

Failed CI Steps

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

<!--PIPELINE {"builds":[{"status":"FAILURE","url":"https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/133402/","number":"133402","commit":"6fb347fe92de29f03aaf626d1a205b6690f72ad5"}]} PIPELINE-->

pmuellr

comment created time in an hour

pull request commentelastic/kibana

Alerting/enable rule export with exclusions

:green_heart: Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
alerting 206 208 +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 37.4KB 37.5KB +64.0B

<details><summary>Unknown metric groups</summary>

API count

id before after diff
alerting 214 216 +2

</details>

History

  • :broken_heart: Build #133324 failed 969dbdbd0cf9fa9a551a874b6515a95c1c80f9e8
  • :broken_heart: Build #133314 failed e7a08e060d009dfec6268a49ed19071f9900701c

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

<!--PIPELINE {"builds":[{"status":"FAILURE","url":"https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/133314/","number":"133314","commit":"e7a08e060d009dfec6268a49ed19071f9900701c"},{"status":"FAILURE","url":"https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/133324/","number":"133324","commit":"969dbdbd0cf9fa9a551a874b6515a95c1c80f9e8"},{"status":"SUCCESS","url":"https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/133383/","number":"133383","commit":"26a945b97a676902cebc63a85c605eed5f0dd7cd"}]} PIPELINE-->

ymao1

comment created time in an hour

pull request commentelastic/kibana

[kbn/optimizer] rewrite theme loader to improve themed scss

:hourglass_flowing_sand: Build in-progress, with failures

Failed CI Steps

History

  • :broken_heart: Build #133388 failed 9dc125fa0b533d3326e333c3d0e6a5600d1417ae

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

<!--PIPELINE {"builds":[{"status":"FAILURE","url":"https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/133388/","number":"133388","commit":"9dc125fa0b533d3326e333c3d0e6a5600d1417ae"},{"status":"FAILURE","url":"https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/133392/","number":"133392","commit":"ccd4422f4dafce8f1386070f8c1e56c9e0692e65"}]} PIPELINE-->

spalger

comment created time in an hour

pull request commentelastic/kibana

[Security Solution] Adds a version and OS check for Host Isolation

:hourglass_flowing_sand: Build in-progress, with failures

Failed CI Steps

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

<!--PIPELINE {"builds":[{"status":"FAILURE","url":"https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/133391/","number":"133391","commit":"961d93002b5eb98626364134e82324b907dc3145"}]} PIPELINE-->

kevinlog

comment created time in an hour

IssuesEvent

pull request commentelastic/kibana

Use new terms enum API for autocomplete value suggestions

:hourglass_flowing_sand: Build in-progress, with failures

Failed CI Steps

History

  • :broken_heart: Build #130788 failed 6812011de0316f5c7b6202033a57faba794f0ad5
  • :broken_heart: Build #130787 failed 9896f5980125027282a1a094fa179f7c97e5e8c9
  • :broken_heart: Build #128722 failed 6634748ad835946b4dff864ef43006653ff8c97f
  • :broken_heart: Build #128536 failed 8e81a0d0e257b95ac174f01710cb54b4ac6a6bed
  • :broken_heart: Build #128440 failed cb0ef5eecf4854a4111c7651830f7ba257bd0f7d

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

<!--PIPELINE {"builds":[{"status":"FAILURE","url":"https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/128440/","number":"128440","commit":"cb0ef5eecf4854a4111c7651830f7ba257bd0f7d"},{"status":"FAILURE","url":"https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/128536/","number":"128536","commit":"8e81a0d0e257b95ac174f01710cb54b4ac6a6bed"},{"status":"FAILURE","url":"https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/128722/","number":"128722","commit":"6634748ad835946b4dff864ef43006653ff8c97f"},{"status":"FAILURE","url":"https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/130787/","number":"130787","commit":"9896f5980125027282a1a094fa179f7c97e5e8c9"},{"status":"FAILURE","url":"https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/130788/","number":"130788","commit":"6812011de0316f5c7b6202033a57faba794f0ad5"},{"status":"FAILURE","url":"https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/133398/","number":"133398","commit":"741add881de767511db2400082851cabfabff2df"}]} PIPELINE-->

lukasolson

comment created time in an hour

pull request commentelastic/kibana

[Fleet] Add UI and mappings for agent policy unenroll_timeout

@jfsiii This would mean including it in the generated agent YAML (Agent Policies > View policy):

image

I think adding it as a top-level field here will work, but you may want to check with @blakerouse to make sure that works with his changes in https://github.com/elastic/fleet-server/pull/472.

jfsiii

comment created time in an hour

pull request commentelastic/kibana

[Uptime] Refactor cert alerts from batched to individual

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

dominiqueclarke

comment created time in an hour

PR opened elastic/kibana

[7.x] [Uptime] Refactor cert alerts from batched to individual (#102138)

Backports the following commits to 7.x:

  • [Uptime] Refactor cert alerts from batched to individual (#102138)
+495 -129

0 comment

13 changed files

pr created time in an hour

issue openedelastic/kibana

[Fleet] Custom component template enhancements

From the discussion in the original implementation of custom component templates for user settings (#101769): there are a few items we should think about further:

  • Whether or not packages should specify if a custom template is installed or not: from discussion with @ruflin and @mostlyjason, it would be rare for a package to not want this (Endpoint seems to be the only case), so we can add an opt-out option later on.
  • Whether or not the custom template should be deleted when a package is uninstalled: let's wait for user feedback on whether deleting it automatically is an annoying UX. In the future we could potentially expose a checkbox/flag to delete custom settings on uninstall.

created time in an hour