profile
viewpoint
Orta Therox orta Microsoft on TypeScript Huddersfield / NYC, US https://orta.io I help people build dev ecosystems. Current: TypeScript. Contributed to: Danger, CocoaPods, GraphQL, RxSwift & Svelte.

danger/danger 4160

🚫 Stop saying "you forgot to …" in code review (in Ruby)

BendingSpoons/tempura-swift 566

A holistic approach to iOS development, inspired by Redux and MVVM

ashfurrow/Nimble-Snapshots 282

Nimble matchers for FBSnapshotTestCase.

dblock/ARTiledImageView 223

Display, pan and deep zoom with tiled images on iOS.

ashfurrow/second_curtain 127

Upload failing iOS snapshot tests cases to S3

dblock/ios-snapshot-test-case-expecta 92

Expecta matchers for ios-snapshot-test-case.

ashfurrow/Forgeries 83

Helper methods for testing iOS code

bamlab/dev-standards 73

https://bamtech.gitbooks.io/dev-standards/

alloy/AxeMode 60

:monkey::wrench: for Xcode

push eventmicrosoft/TypeScript-Website

Anton Gilgur

commit sha ef9b7a8c1c1c8b5ff21c281feb959220d2533dc0

fix: remove importHelpers' erroneous relatedTo self (#1100) - it listed itself relatedTo which would link to itself when clicked

view details

push time in 13 hours

PR merged microsoft/TypeScript-Website

fix: remove importHelpers' erroneous relatedTo self

Description

  • it listed itself relatedTo which would link to itself when clicked

Tags

Found while writing #1099

Screenshot

Here's how it looks before this change 😅 :

Screen Shot 2020-09-17 at 2 03 19 AM

+1 -1

1 comment

1 changed file

agilgur5

pr closed time in 13 hours

pull request commentmicrosoft/TypeScript-Website

fix: remove importHelpers' erroneous relatedTo self

Ha, good spot!

agilgur5

comment created time in 13 hours

push eventmicrosoft/TypeScript-Website

Anton Gilgur

commit sha f30907a92db976efd189728f913a399e03a9c361

fix: add missing inverses in relatedTo (#1099) - one side of the relationship existed but not the other side, ensure both sides of the relationship are relatedTo each other for proper backlinking etc - add a new line after all the strict options for proper grouping same as the other groups

view details

push time in 13 hours

PR merged microsoft/TypeScript-Website

fix: add missing inverses in relatedTo

Description

  • one side of the relationship existed but not the other side, ensure both sides of the relationship are relatedTo each other for proper backlinking etc

  • add a new line after all the strict options for proper grouping same as the other groups

Tags

Found while writing #1095 / #971

Review Notes

I omitted allowJs and checkJs from emitDeclarationOnly's relatedTo because of #1098 , but can add them if that PR is rejected

+14 -0

1 comment

1 changed file

agilgur5

pr closed time in 13 hours

pull request commentmicrosoft/TypeScript-Website

fix: add missing inverses in relatedTo

Great, thanks!

agilgur5

comment created time in 13 hours

push eventmicrosoft/TypeScript-Website

Anton Gilgur

commit sha d1ff226f653969559bb8a65ea570c435979779a0

fix: alphabetize useDefineForClassFields in Compiler Options (#1094) - the rest seem to be alphabetized, but this one was out of place

view details

push time in 13 hours

PR merged microsoft/TypeScript-Website

fix: alphabetize useDefineForClassFields in Compiler Options

Description

  • the rest seem to be alphabetized, but this one was out of place

Tags

Noticed this while checking for discrepancies between Compiler Options and TSConfig Reference after #1092

+1 -1

1 comment

1 changed file

agilgur5

pr closed time in 13 hours

push eventmicrosoft/TypeScript-Website

Anton Gilgur

commit sha 89d0ea97de43e2ebfd37612188f82f0a215ac67b

typo: extraneous word in link to TSConfig Reference (#1093) - seems like one was thinking "Check out the" and "There's also the", which came out as "There's also out the" 😄

view details

push time in 13 hours

PR merged microsoft/TypeScript-Website

typo: extraneous word in link to TSConfig Reference

Description

  • seems like one was thinking "Check out the" and "There's also the", which came out as "There's also out the" 😄

Tags

Discovered while reading through Compiler Options doc for discrepancies like those in #1092

+1 -1

1 comment

1 changed file

agilgur5

pr closed time in 13 hours

pull request commentmicrosoft/TypeScript-Website

typo: extraneous word in link to TSConfig Reference

Ha, thanks!

agilgur5

comment created time in 13 hours

push eventmicrosoft/TypeScript-Website

Anton Gilgur

commit sha cba99d6b985400cbda2dee387609a68b444444be

fix: declaration is actually false by default (#1092) - previously said "True when TS", but that isn't accurate - upon testing, it appears to be false by default - an explicit `declaration: true` is required in `tsconfig.json` for declaration files (`.d.ts`) to be output - the Compiler Options docs also say it's default false too, so not sure why it's different in the TSConfig Reference - c.f. https://github.com/microsoft/TypeScript-Website/blob/46b960968f994968b237060065f651a368e5fc63/packages/documentation/copy/en/project-config/Compiler%20Options.md#L47

view details

push time in 13 hours

PR merged microsoft/TypeScript-Website

fix: declaration is actually false by default

Description

  • previously said "True when TS", but that isn't accurate

    • upon testing, it appears to be false by default
    • an explicit declaration: true is required in tsconfig.json for declaration files (.d.ts) to be output
  • the Compiler Options docs also say it's default false too, so not sure why it's different in the TSConfig Reference

    • c.f. https://github.com/microsoft/TypeScript-Website/blob/46b960968f994968b237060065f651a368e5fc63/packages/documentation/copy/en/project-config/Compiler%20Options.md#L47

Tags

This was discovered in https://github.com/formium/tsdx/pull/823#discussion_r481083608

Review Notes

Is there some way to auto-generate these from TS itself so that these are never incorrect/out-of-date?

I'm not sure what other discrepancies there may still be between the TSConfig Reference and Compiler Options docs

+1 -1

1 comment

1 changed file

agilgur5

pr closed time in 13 hours

pull request commentmicrosoft/TypeScript-Website

fix: declaration is actually false by default

Great - thanks, yeah, there is no way to automate them I'm afraid. The logic is pretty embedded in the compiler.

agilgur5

comment created time in 13 hours

issue commentmicrosoft/TypeScript

Property Decorators last argument is undefined

OK, so, I think I'll need @rbuckton to give this a look over.

The JS version of your code looks like this:

"use strict";
var __decorate = (this && this.__decorate) || function (decorators, target, key, desc) {
    var c = arguments.length, r = c < 3 ? target : desc === null ? desc = Object.getOwnPropertyDescriptor(target, key) : desc, d;
    if (typeof Reflect === "object" && typeof Reflect.decorate === "function")
        r = Reflect.decorate(decorators, target, key, desc);
    else
        for (var i = decorators.length - 1; i >= 0; i--)
            if (d = decorators[i])
                r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
    return c > 3 && r && Object.defineProperty(target, key, r), r;
};
var __metadata = (this && this.__metadata) || function (k, v) {
    if (typeof Reflect === "object" && typeof Reflect.metadata === "function")
        return Reflect.metadata(k, v);
};
function propertyDecorator(...args) {
    debugger;
    console.log(args);
}
class Test {
}
__decorate([
    propertyDecorator,
    __metadata("design:type", String)
], Test.prototype, "name", void 0);

With d(target, key, r) being the call which passes the undefined through as the third arg. This can be switched out with an extra check for the undefined as the r:

-                r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
+                r = (c < 3 ? d(r) : c > 3  && r !== undefined ? d(target, key, r) : d(target, key)) || r;

Then it will give a console log of [ {}, 'name' ].

I'm just not sure of the network effects of such a change.

DanilaFadeev

comment created time in 15 hours

IssuesEvent

pull request commentmicrosoft/TypeScript

Throw types

@typescript-bot pack this

Jack-Works

comment created time in 15 hours

issue closedmicrosoft/TypeScript

Property Decorators last argument is undefined

<!-- 🚨 STOP 🚨 STOP 🚨 STOP 🚨

Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a bug, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!

Please help us by doing the following steps before logging an issue:

  • Search: https://github.com/Microsoft/TypeScript/search?type=Issues
  • Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ

Please fill in the entire template below. -->

<!-- Please try to reproduce the issue with the latest published version. It may have already been fixed. For npm: typescript@next This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly --> TypeScript Version: 4.0.2

<!-- Search terms you tried before logging this (so others can find this issue more easily) --> Search Terms: property decorator undefined the last argument

Code

function propertyDecorator(...args) {
  console.log(args);
}

class Test {
  @propertyDecorator
  name: string;
}

Expected behavior: [ Test {}, 'name' ]

Actual behavior: [LOG]: [ {}, "name", null ]

Playground Link: https://www.typescriptlang.org/play?ts=4.0.2#code/GYVwdgxgLglg9mABABwE52QU1VAngEUwjlQEMoSAKAOltNQHMBnALkVLFwG0BdASkQBvAFCJExMEzgAbTNWlwGlesz4BuYQF9hwiNNJMmiACqYmUIaMQABNBmx5CxMhVRWwpALaY251DDAGDU0gA

Related Issues: Not found

closed time in 16 hours

DanilaFadeev

issue commentmicrosoft/TypeScript

Property Decorators last argument is undefined

Thanks

Seems pretty legit, I've given the whole logging system an overhaul to handle more specific primitives in https://github.com/microsoft/TypeScript-Website/pull/1108

It'll either go live with the next prod website deploy (scheduled every Monday) or sometime before if I need to make a deploy.

DanilaFadeev

comment created time in 16 hours

PR opened microsoft/TypeScript-Website

Improve the logging system

Adds:

  • You can use cmd|ctrl + k to clear the logs
  • You can use console.clear to clear logs
  • More primitives show up as the right thing: undefined, null, strings are shown with quotes, classes display the classname

Screen Shot 2020-09-17 at 3 32 38 PM

fixes https://github.com/microsoft/TypeScript/issues/40577

+69 -12

0 comment

3 changed files

pr created time in 16 hours

push eventmicrosoft/TypeScript-Website

Orta

commit sha ef8852f310907aca2ce10c9b60bcf624bfcd040c

Better naming

view details

push time in 16 hours

create barnchmicrosoft/TypeScript-Website

branch : runtime_log_stuff

created branch time in 16 hours

push eventDefinitelyTyped/dt-mergebot

Orta

commit sha 2a26df6808b08eb214d3f6c050bed0f4579a2f5d

More removals

view details

push time in 17 hours

PR opened DefinitelyTyped/dt-mergebot

Removes some unused code

Tests and yarn tsc pass, so if this breaks - we've failed somewhere 🍡

+0 -24

0 comment

2 changed files

pr created time in 17 hours

create barnchDefinitelyTyped/dt-mergebot

branch : remove_dead_code

created branch time in 17 hours

Pull request review commentmicrosoft/TypeScript

Migrate 'ts.performance' to use native performance hooks when available

 namespace ts.performance {      * @param cb The action to perform for each measure
      */
     export function forEachMeasure(cb: (measureName: string, duration: number) => void) {
-        measures.forEach((measure, key) => {
-            cb(key, measure);
+        perfEntryList?.getEntriesByType("measure").forEach(entry => {
+            cb(entry.name, entry.duration);
         });
     }
 
     /** Enables (and resets) performance measurements for the compiler. */
     export function enable() {
-        counts = new Map<string, number>();
-        marks = new Map<string, number>();
-        measures = new Map<string, number>();
-        enabled = true;
-        profilerStart = timestamp();
+        if (!enabled) {
+            perfHooks ||= tryGetNativePerformanceHooks() || ShimPerformance?.createPerformanceHooksShim(timestamp);

That will definitely set the compiler option in the TSServer in the playground:

Screen Shot 2020-09-17 at 12 11 46 PM

From the looks of caniuse.com for this API, the last browser to add the API was Safari in 2017 - which might fall into Monaco's support window. They basically say "any desktop browser but IE".

It's outside the TS website's support window though (I use this API at the bottom of handbook pages but skip showing it on "ancient" browsers)

So, I don't really have a definitive answer I'm afraid

rbuckton

comment created time in 19 hours

PullRequestReviewEvent

push eventorta/github-activity-writer

Orta

commit sha 19a4077680d06c2075d94e758bf7b52389e50daa

minor polish

view details

push time in 20 hours

pull request commentmicrosoft/TypeScript

Deprecated as warning

/cc @amcasey - I think we've talked about warnings before, and I'm not certain about how that affects VS

Kingwl

comment created time in 20 hours

push eventorta/github-activity-writer

Orta

commit sha f8da53b15fb9538ba8f08567df47d33570917f7d

OG

view details

push time in a day

push eventorta/github-activity-writer

Orta

commit sha c03b5d06c4f17052cee17507997094d7eee6c4a9

Add OG tags

view details

Orta

commit sha a90e70473fc6ac3eb4d3210b36f7642ac7e5e64e

Ship

view details

push time in a day

push eventorta/github-activity-writer

Orta

commit sha 180395639947b5dbfee6a19d2d80c7e9468ba34f

More tools

view details

Orta

commit sha fa4ca46f5ebf826f2dd43f4b9639fd206bc8e1cb

Ship more tools

view details

push time in a day

push eventorta/github-activity-writer

Orta

commit sha 3e7253e9a8eeb605faa50252b2de14a1a624f450

Fix domain

view details

push time in a day

push eventorta/github-activity-writer

Orta

commit sha 05c0f03d18f5ec49c1144a0acf73b42bc8b0c832

Better CSS

view details

Orta

commit sha a5ee25b611308ef7af7e4bf26c3d1feae96bac3e

Merge branch 'master' of https://github.com/orta/github-activity-writer into master

view details

push time in a day

push eventorta/github-activity-writer

Orta Therox

commit sha c3bba2f8c39be214b780654618cfb185a7ef4719

Create CNAME

view details

push time in a day

push eventorta/github-activity-writer

Orta

commit sha 28ea1024c8b15bdb314254070073515b543083c0

Adds day indicators

view details

push time in a day

push eventorta/github-activity-writer

Orta

commit sha 1d89f378e657d03edd1d570c045ab5a0c2949e8d

Deploys faff

view details

Orta

commit sha b38617197886707e4fb357aa56a3e9e500b4f6a4

Merge branch 'master' of https://github.com/orta/github-activity-writer into master

view details

push time in a day

push eventorta/github-activity-writer

Orta Therox

commit sha 1e4f2e6ba16afa956657ec849eee42d2f216c34e

Create CNAME

view details

push time in a day

push eventorta/github-activity-writer

Orta

commit sha 3bebe2f76ce0f2efbe1e05bbdf7f50f620c4174c

Fix link

view details

push time in a day

push eventorta/github-activity-writer

Orta

commit sha e5fb0257b15f31c460f7c236f76ed808d5810591

Fixes

view details

Orta

commit sha 562759b8f467c0242e0452bf91661ec8c34ed0f2

Merge branch 'master' of https://github.com/orta/github-activity-writer into master

view details

push time in a day

push eventorta/github-activity-writer

Orta Therox

commit sha 82b9fb5c90a778be752239d8c90eecfc19ccbef0

Delete CNAME

view details

push time in a day

push eventorta/github-activity-writer

Orta Therox

commit sha 72141e859b7a300f9fedd6c0ecddcee3a3fb2f60

Create CNAME

view details

push time in a day

push eventorta/github-activity-writer

Orta

commit sha 7429f2071b0e0a4161992e84515daec3980e67a6

docs folder, sure

view details

push time in a day

push eventorta/github-activity-writer

Orta

commit sha 027bc3775b0a939a8672a36aee7962d54d1fae36

Add prod deploys

view details

push time in a day

create barnchorta/github-activity-writer

branch : master

created branch time in a day

created repositoryorta/github-activity-writer

created time in a day

push eventorta/azure-static-webapps-stripe-test

Orta

commit sha 44eb0fd1396b018c4b2b6cfff48aa59977636bf3

More logical webhook

view details

push time in 2 days

push eventorta/azure-static-webapps-stripe-test

Orta

commit sha 2d0e1377aaef1e38eafb322c1d5652b1756f7dc7

Faff

view details

push time in 2 days

push eventorta/azure-static-webapps-stripe-test

Orta

commit sha 1b9c1c62c093657bbf3e46e93e854cc2a4bd021f

Try hook up stripe

view details

push time in 2 days

issue commentdanger/danger

Add Dismiss_out_of_range_messages to danger-gitlab

You'd need to implement it, you can probably copy the PR: https://github.com/danger/danger/pull/832

fahmisdk6

comment created time in 2 days

push eventorta/azure-static-webapps-stripe-test

Orta

commit sha d9e7e8801136e9d05556f9804dd97254f42b9cfd

webhook route

view details

push time in 2 days

push eventorta/azure-static-webapps-stripe-test

Orta

commit sha c04b5fc080250d0236491d57d20b6aad1eec0a67

2nd attempt at the functions

view details

push time in 2 days

push eventorta/azure-static-webapps-stripe-test

Orta

commit sha d2805aae37e5469db26d2ada9f726681c3ff0c8d

Adds a function

view details

push time in 2 days

push eventorta/azure-static-webapps-stripe-test

Orta

commit sha 39f2aac1c57ccc0f9c17b0e28f80f79c8cb155d3

Try ship something

view details

push time in 2 days

issue commentshikijs/shiki

RFC: Browser support & API changes

I think all these changes are good ideas 👍🏻

antfu

comment created time in 2 days

push eventorta/azure-static-webapps-stripe-test

Azure Static Web Apps

commit sha a2b75fbc0d21bace5eaa949975247aeb4ceafd80

ci: add Azure Static Web Apps workflow file on-behalf-of: @Azure opensource@microsoft.com

view details

push time in 2 days

create barnchorta/azure-static-webapps-stripe-test

branch : main

created branch time in 2 days

created repositoryorta/azure-static-webapps-stripe-test

created time in 2 days

issue commentmicrosoft/vscode

First run user onboard experience

I love it.

Depending on how much friction you want to offer on the onboarding, that command palette page could require the user to run an action in the command palette. e.g The "Next Step" button could turn to "Unlock via the palette" and be disabled until you run the only possible command in the palette of "Unlock"

misolori

comment created time in 3 days

create barnchorta/github-sponsors-twitter-webhook

branch : master

created branch time in 3 days

created repositoryorta/github-sponsors-twitter-webhook

created time in 3 days

issue commentdanger/danger-js

[BUG] Example Dangerfile does not parse with a vue-cli app

The "easy" answer is to switch the import "xyz" to a require, so that it runs in node without transpilation. Another answer is to find a way to make node support the imports, perhaps there is a flag to enable it?

IMO, you shouldn't really mess with your babel config for Danger here. But, your babel config isn't set up to run in node out of the box, and so Danger re-using it doesn't work for you. Which is why folks using TypeScript work above.

unikitty37

comment created time in 3 days

issue openedmicrosoft/TypeScript-Website

Docs: JSDoc reference doesn't cover the class additions in 3.8

Missing: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#jsdoc-property-modifiers

created time in 3 days

issue commentromefrontend/rome

Logo

Hi @roman-rr - this is pretty toxic behavior, Maggie hasn't ever posted in this thread and you're asking her to respond to your DMs in public:

Screen Shot 2020-09-15 at 8 04 47 AM

sebmck

comment created time in 3 days

issue commentdanger/danger-js

[BUG] Example Dangerfile does not parse with a vue-cli app

Are you expecting to be running danger through node with esmodules enabled? Typically people transpile the import to be a require in their babel setups.

unikitty37

comment created time in 3 days

push eventmicrosoft/TypeScript-Website

Olivia

commit sha cdce0078865e38d5d28b2eeff4ff2038a252a1a0

Update function name (#1086) To be consistent with the rest of the example

view details

push time in 3 days

PR merged microsoft/TypeScript-Website

Update function name

To be consistent with the rest of the example

+1 -1

1 comment

1 changed file

orhanna14

pr closed time in 3 days

pull request commentmicrosoft/TypeScript-Website

Update function name

Thanks

orhanna14

comment created time in 3 days

push eventmicrosoft/TypeScript-Website

Richard Pacheco

commit sha ada6aca446934cda1336620a91a2e6af140027d4

Fix logic on Union and Intersection Types and position of popover on TypeScript with Web (#1088) * Fix logic on Union and Intersection exemple * Fix popover position on TypeScript with Web

view details

push time in 3 days

PR merged microsoft/TypeScript-Website

Fix logic on Union and Intersection Types and position of popover on TypeScript with Web

This PR contains fixes for the following Playground examples:

  • TypeScript with Web
  • Union and Intersection Types

Union and Intersection Types

Currently, type CreateArtistBioRequest is either (CreateArtistBioBase & { html: string }) or just { markdown: string }

I believe the expected type should be (as described on lines 72-73):

CreateArtistBioBase and either { markdown: string } or { html: string }

This PR implements the expected behavior.

TypeScript with Web

Just changes the position of the popover to the left, which is the expected behavior according to lines 68-69:

// If you hit "Run" above, then a popup should appear
// in the bottom left, which you can close by clicking

The current position also renders the popover under the sidebar, hiding it.

Should I also make the changes to the localized versions of these examples?

+2 -2

1 comment

2 changed files

richardspacheco

pr closed time in 3 days

push eventmicrosoft/TypeScript-Website

Ayush

commit sha 3d3d286e3885f0f6ad94fc1f7d91024fb90662d9

Fixed "Is this page helpful?" dark mode (#1089)

view details

push time in 3 days

pull request commentmicrosoft/TypeScript-Website

Fixed "Is this page helpful?" dark mode

Thanks!

heyAyushh

comment created time in 3 days

pull request commentmicrosoft/TypeScript

Push through the flag rename for '--noUncheckedIndexedAccess'

Deprecated by https://github.com/microsoft/TypeScript/pull/40541

DanielRosenwasser

comment created time in 4 days

PR closed microsoft/TypeScript

Reviewers
Push through the flag rename for '--noUncheckedIndexedAccess' For Milestone Bug

Fixes #40531

+186 -51

1 comment

8 changed files

DanielRosenwasser

pr closed time in 4 days

push eventmicrosoft/TypeScript-Website

Orta Therox

commit sha dd463b716e372aa032b6264d7a5cf05e993ecd09

Another A11y issues run (#1085) * Update releases * Handle duplicate TTS in search results in NVDA * Make modals return tab focus

view details

push time in 4 days

PR merged microsoft/TypeScript-Website

Another A11y issues run

These popped up after launch, and I've nt found time to come back to them till the 4.1 beta got shipped.

+1455 -18

0 comment

10 changed files

orta

pr closed time in 4 days

push eventmicrosoft/TypeScript-Website

Orta Therox

commit sha e6141441acea2ecc33e2a733b7ed51c1a52578b4

Make modals return tab focus

view details

push time in 4 days

PR opened microsoft/TypeScript-Website

Another A11y issues run

These popped up after launch, and I've nt found time to come back to them till the 4.1 beta got shipped.

+1432 -3

0 comment

5 changed files

pr created time in 4 days

create barnchmicrosoft/TypeScript-Website

branch : a11y_issues

created branch time in 4 days

issue commentshikijs/shiki

Consider migrating all the shiki-x projects into this monorepo

No strong opinions on monorepo or not, whatever feels like the right fot

orta

comment created time in 4 days

push eventmicrosoft/TypeScript-Website

Koji

commit sha b551ca9e453de7481fc3bb2d10c250135040a2f2

Switch KeyboardEvent attribute from keyCode to key (#1083) * Switch keyCode to key and code In this code base, some places are using `key` and `code` instead of `keyCode`. Keycodes list http://www.javascripter.net/faq/keycodes.htm Did double-check on MDN https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code * removed code Removed code due tu KeybordEvent.code `Warning` https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent * remove KebordEvent.code reomve the left of KebordEvent.code

view details

push time in 4 days

PR merged microsoft/TypeScript-Website

Switch KeyboardEvent attribute from keyCode to key

In this code base, I saw that the code is using key instead of keyCode. I guess unifying could be good.

Keycodes list http://www.javascripter.net/faq/keycodes.htm

Did double-check on MDN https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code

+46 -49

4 comments

5 changed files

koji

pr closed time in 4 days

pull request commentmicrosoft/TypeScript-Website

Switch KeyboardEvent attribute from keyCode to key

Thanks!

koji

comment created time in 4 days

push eventjoarwilk/flowgen

Bogdan Savluk

commit sha 63a2a7810bb8df308b5b3eac10f99cbdb03528b5

dependencies

view details

Bogdan Savluk

commit sha 98c9ef7050ded86ba88b0cd573bdb24cabe39125

flowts: rename

view details

Bogdan Savluk

commit sha 7de29271070a039a1fd33bdc7070f206c723073b

flowts: convert flowts --no-allow-js --interactive-rename ./src

view details

Bogdan Savluk

commit sha ddaf3d423ed51f7f45d6144be94844b6cf27756e

rename snapshots

view details

Bogdan Savluk

commit sha daa869917ddd4c6905f45ba6be98a6a064d02182

babel config

view details

Bogdan Savluk

commit sha c25d1ac8b0c46d571c614a935e8c63d74d834d34

eslint typescript configuration

view details

Bogdan Savluk

commit sha 7ea35bef15d444ec5d6c5fb9dd01f712de2f77e2

eslint '**/*.ts' --fix

view details

Bogdan Savluk

commit sha 50cd65e69ae501299937c655f07b19c4e7742746

manual fixes

view details

Bogdan Savluk

commit sha ecdd2d655502ac4a3d1e2fd79e94e3cf0851c9cf

more manual fixes

view details

Bogdan Savluk

commit sha 0efbc217dba31c61a297fc471cfc958b7ca31440

update dependencies, remove flow

view details

Bogdan Savluk

commit sha 19662b22c3ca51ec31dbed863a6097f22b7738cc

ts compilation

view details

Bogdan Savluk

commit sha bd54b3843eb96127edd5dcc944366f7ec2a70597

more todos, replace ts-ignore with ts-expect-error

view details

Bogdan Savluk

commit sha b28f007523a4606b1e0bd8b09881e91248557543

Merge master into ts

view details

Bogdan Savluk

commit sha a0db30dc805e461da2b02db37e79671b1714e6bf

update dependencies

view details

Orta Therox

commit sha b206a05423f55256c7fae72c9f673656a8b4f2ff

Merge pull request #115 from zxbodya/ts Migrate to TypeScript

view details

push time in 5 days

PR merged joarwilk/flowgen

Migrate to TypeScript

This might look a bit weird, considering this is one of the most important tools in the Flow community…

But, I believe, considering, a large part of flowgen is actually based on TypeScript - this makes a lot of sense.

Some background: did this mostly to make it easier to explore flowgen codebase for me, but I think this might be helpful to move for project in general.

Changes in PR:

  • updated dependencies
  • converted existing source code using https://github.com/zxbodya/flowts
  • did manual fixes, added some @ts-expect-errors with todo comments to make tsc happy (avoided doing much refactor - I think, this is better to be done separately, also I am not yet very familiar with TypeScript compiler API, to see how to better use it)
  • updated configuration for linter and babel to for with TypeScript
+2591 -19835

10 comments

116 changed files

zxbodya

pr closed time in 5 days

pull request commentjoarwilk/flowgen

Migrate to TypeScript

Cool, works for me 👍🏻

zxbodya

comment created time in 5 days

pull request commentmicrosoft/TypeScript-Website

Switch KeyboardEvent attribute from keyCode to key

Nice, looks close!

Just this to handle:

src/components/layout/Sidebar-keyboard.tsx(148,43): error TS2339: Property 'code' does not exist on type 'KeyboardEvent<Element>'.

koji

comment created time in 5 days

push eventmicrosoft/TypeScript-Website

Jeremy

commit sha f032fc7d23d18791320f9c0c0a4af4b90f5e6891

Fix twoslash error caused by incorrect spacing (#1078)

view details

push time in 5 days

PR merged microsoft/TypeScript-Website

Fix twoslash error caused by incorrect spacing

Under the 'Record' section of the Utility Types page there is a twoslash spacing error which results in the error // ^ = Could not get LSP result: bou>t<; being shown:

ts-error

The error is caused by a few errant tabs before the caret.

Issue fixed by removing the tabs.

+1 -1

1 comment

1 changed file

jsrath

pr closed time in 5 days

pull request commentmicrosoft/TypeScript-Website

Fix twoslash error caused by incorrect spacing

Ha, great spot! Thanks

jsrath

comment created time in 5 days

create barnchorta/fresnel

branch : wip_types_2

created branch time in 6 days

fork orta/fresnel

An SSR compatible approach to CSS media query based responsive layouts for React.

https://artsy.github.io/blog/2019/05/24/server-rendering-responsively

fork in 6 days

push eventmicrosoft/TSJS-lib-generator

Orta

commit sha 876b774097a661e6d8e040996e0d49883785acc5

Fixes the verify loop

view details

push time in 6 days

CommitCommentEvent

pull request commentDefinitelyTyped/DefinitelyTyped

[howler] Significant type definition improvements

If it doesn't represent what the JS looks like, I'd recommend adding those back 👍🏻

jun-sheaf

comment created time in 6 days

pull request commentmicrosoft/TypeScript

Package lock auto update

Thanks, but we already have a working setup for updating our package lock on a weekly basis automatically.

IMO we probably don't want it, this repo is busy enough without all the additional noise that dependabot would add.

tjenkinson

comment created time in 7 days

push eventmicrosoft/TypeScript

Orta Therox

commit sha aa2756a5d7f5ed02e6c676e0fd8e4d1a5e0acd13

Updates Dom lib with TSJS changes, adding a new library for webworker iterable (#40500) * Updates Dom lib with TSJS changes, adding a new library for webworker iterable Co-authored-by: Nathan Shively-Sanders <nathansa@microsoft.com> * Fixes tests Co-authored-by: Nathan Shively-Sanders <nathansa@microsoft.com>

view details

push time in 7 days

more