profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/orta/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Orta Therox orta Microsoft on TypeScript Huddersfield / NYC / Dublin https://orta.io I help people build dev ecosystems. Current: TypeScript. Contributed to: Shiki, Shiki Twoslash, Danger, CocoaPods, Jest, GraphQL, RxSwift & Svelte.

danger/danger 4591

🚫 Stop saying "you forgot to …" in code review (in Ruby)

BendingSpoons/tempura-swift 640

A holistic approach to iOS development, inspired by Redux and MVVM

ashfurrow/Nimble-Snapshots 303

Nimble matchers for FBSnapshotTestCase.

dblock/ARTiledImageView 225

Display, pan and deep zoom with tiled images on iOS.

ashfurrow/second_curtain 128

Upload failing iOS snapshot tests cases to S3

dblock/ios-snapshot-test-case-expecta 95

Expecta matchers for ios-snapshot-test-case.

ashfurrow/Forgeries 83

Helper methods for testing iOS code

bamlab/dev-standards 78

https://bamtech.gitbooks.io/dev-standards/

alloy/AxeMode 62

:monkey::wrench: for Xcode

push eventorta/TypeScript-Website

Orta

commit sha cb16d480ec5f3a515ee04af1e127c73fad5a7b2e

Adds the prod URL

view details

push time in an hour

push eventorta/TypeScript-Website

Orta

commit sha cbfcdd345b356c21537a68ef019f5c5f7a684847

Adds the prod URL

view details

push time in an hour

push eventmicrosoft/TypeScript-Playground-Gist-Proxy-API

Orta

commit sha d0564c4e0135cf9219cb09a31d0853539297e013

Don't dig into octokit for types

view details

push time in 2 hours

push eventmicrosoft/TypeScript-Website

Masashi Miyazaki

commit sha 8002736a6e11722d357b3dd7ddaae23bc1a0a5fa

docs: Add a comment to the first example of Keyof Type Operator for beginners

view details

Orta Therox

commit sha fa4d8d29eaa2046a9c68234b3728c9cb69078045

Merge pull request #2030 from mymactive/docs/update-KeyofTypeOperator DOCS: Add a comment to the first example of Keyof Type Operator for beginners

view details

push time in 2 hours

PR merged microsoft/TypeScript-Website

DOCS: Add a comment to the first example of Keyof Type Operator for beginners

It is related to issue #2025. I add a short comment to Keyof type Operator. My mother tongue is not English, so this comment would be unnatural. Would you point out an expression?

+2 -1

1 comment

1 changed file

mymactive

pr closed time in 2 hours

pull request commentmicrosoft/TypeScript-Website

DOCS: Add a comment to the first example of Keyof Type Operator for beginners

Thanks, this is reasonable

mymactive

comment created time in 2 hours

push eventmicrosoft/TypeScript-Website

Rongjian Zhang

commit sha 920a54021725d2412f7963f93ec39fe4daeb37f1

Make it compatible with environments without localStorage

view details

Orta Therox

commit sha 8163e666084e957b5a10e0e51905c57f83f6c029

Merge pull request #2034 from pd4d10/patch-2 Make @typescript/vfs compatible with environments without localStorage

view details

push time in 2 hours

push eventmicrosoft/TypeScript-Playground-Gist-Proxy-API

Orta Therox

commit sha 855e5ee3123c10064d7bc9d85bdf995210c58eeb

Update deploy.yml

view details

push time in 2 hours

pull request commentmicrosoft/TypeScript-Website

Update skipLibCheck.md

I like the general idea, though the tone is definitely off

trusktr

comment created time in 2 hours

push eventmicrosoft/TypeScript-Playground-Gist-Proxy-API

Orta Therox

commit sha 19940cbabeead56a9b96850c7ac33bb7713d18f7

Update deploy.yml

view details

push time in 2 hours

push eventmicrosoft/TypeScript

Orta Therox

commit sha 61d29393594f81fa5032b426c8bfcdbc8bd90c98

Adds more Intl.ResolvedDateTimeFormatOptions, and hooks up Intl for ES2021 (#45905) * Adds more ResolvedDateTimeFormatOptions to the Intl APIs * Fix tests

view details

push time in 13 hours

issue closedmicrosoft/TypeScript

Intl.ResolvedDateTimeFormatOptions is missing properties

lib Update Request

Configuration Check

My compilation target is ES2020 and my lib is the default.

Missing / Incorrect Definition

Intl.ResolvedDateTimeFormatOptions - the type returned by calling DateTimeFormat's resolvedOptions method - appears to be missing the following properties:

  • dateStyle
  • timeStyle
  • dayPeriod
  • hourCycle
  • fractionalSecondDigits

It looks like these items (along with calendar and numberingSystem) were added to es2020.intl.d.ts's DateTimeFormatOptions however they were never added to ResolvedDateTimeFormatOptions.

It seems that calendar and numberingSystem are both present in es5.d.ts's ResolvedDateTimeFormatOptions. Because of this I am unsure if the absent options should be added to ResolvedDateTimeFormatOptions in es5.d.ts or es2020.d.ts.

https://tc39.es/ecma402/#table-datetimeformat-resolvedoptions-properties is the spec table of possible returned properties

Sample Code

Sample TS playground

console.log(new Intl.DateTimeFormat('en-US', { dateStyle: 'short' }).resolvedOptions().dateStyle)
console.log(new Intl.DateTimeFormat('en-US', { timeStyle: 'long' }).resolvedOptions().timeStyle)

console.log(new Intl.DateTimeFormat('en-US', { dayPeriod: 'narrow' }).resolvedOptions().dayPeriod)
console.log(new Intl.DateTimeFormat('en-US', { timeStyle: 'long', hourCycle:'h24' }).resolvedOptions().hourCycle)

console.log(new Intl.DateTimeFormat('en-US', { fractionalSecondDigits: 1 }).resolvedOptions().fractionalSecondDigits)

The above lines throw type errors saying the various properies on resolvedOptions do not exist

Documentation Link

https://tc39.es/ecma402/#table-datetimeformat-resolvedoptions-properties

closed time in 13 hours

BPScott

PR merged microsoft/TypeScript

Reviewers
Adds more Intl.ResolvedDateTimeFormatOptions, and hooks up Intl for ES2021 Author: Team For Backlog Bug
  1. Looks like if you were on target: es2021 the file es2021.intl wasn't added to your globals, so some of #45647 wasn't applied
  2. I added the properties raised in #45420

fixes #45420

+16 -6

1 comment

3 changed files

orta

pr closed time in 13 hours

issue closeddanger/danger

How to Ignore Error in Android project

I got Using 'Log' instead of 'Timber' Danger error.

Cause is that launchdarkly inside itself uses timber logging library.

| | | | | | +--- com.launchdarkly:launchdarkly-android-client-sdk:2.14.2 | | | | | | | +--- com.google.code.gson:gson:2.8.2 -> 2.8.6 | | | | | | | +--- com.launchdarkly:okhttp-eventsource:1.8.0 | | | | | | | | +--- com.squareup.okhttp3:okhttp:3.8.1 -> 3.14.7 () | | | | | | | | +--- org.slf4j:slf4j-api:1.7.22 -> 1.7.25 | | | | | | | | --- com.google.code.findbugs:jsr305:3.0.2 | | | | | | | +--- com.squareup.okhttp3:okhttp:3.12.2 -> 3.14.7 () | | | | | | | +--- com.jakewharton.timber:timber:4.7.1

But when I run Lint check I don't get report about it. Could you please tell me how can I ignore this report in Danger?

• I've tried added ignore to lint file. • I've checked https://danger.systems/guides/faq.html And was trying add // > Danger: Ignore "Using 'Log' instead of 'Timber'" To the files where Danger found these errors but still se these errors in the Dangers report.

Your Environment

  • CI - Jenkins

  • Version danger (8.3.1)

    # ruby 2.6.3p62 (2019-04-16 revision 67580) [universal.x86_64-darwin20]
    

closed time in 15 hours

YevhenTroshchii

issue commentdanger/danger

How to Ignore Error in Android project

You'd probably need to figure out how to make that only apply in your code or the plugin, this isn't an issue with Danger itself 👍🏻

YevhenTroshchii

comment created time in 15 hours

push eventorta/TypeScript-Website

Orta Therox

commit sha 1f00600b1a9bb8571b6f023e0036340927413dc7

More gist polish

view details

push time in 17 hours

push eventmicrosoft/TypeScript-Playground-Gist-Proxy-API

Orta

commit sha c4b76f6062b16f7d1e887bf7a4e22c746f317327

Improve the README

view details

push time in 17 hours

push eventmicrosoft/TypeScript-Website

Rongjian Zhang

commit sha d284e08699675b7ce6bc09a3155b4fbee7888526

update es2021 and esnext lib files

view details

Orta Therox

commit sha 27fbbd3d780a5d7dd946d12daa9b519d93fa5f5e

Merge pull request #2033 from pd4d10/patch-1 Update es2021 and esnext lib files

view details

push time in 17 hours

push eventmicrosoft/TypeScript-Playground-Gist-Proxy-API

Orta

commit sha 3100e0d9b9ac69f15f3c44c95dc08a4f1742e3eb

lockfile faff

view details

push time in 17 hours

push eventmicrosoft/TypeScript-Playground-Gist-Proxy-API

Orta

commit sha 431af8354a39f52200ed01bfbbc392ca39502045

Force types into dep

view details

push time in 17 hours

push eventmicrosoft/TypeScript-Playground-Gist-Proxy-API

Orta

commit sha 85efb02bd8ea715a7eb848e237e3065185eda568

Fix 'security' issue

view details

push time in 17 hours

push eventmicrosoft/TypeScript-Playground-Gist-Proxy-API

Orta

commit sha 1b35f2f0f0d6fa090ebd1ffe0478251461a9477c

Deploy

view details

push time in 17 hours

pull request commentmicrosoft/TypeScript-Website

Update es2021 and esnext lib files

👍🏻

pd4d10

comment created time in 17 hours

pull request commentmicrosoft/TypeScript-Website

Small improvements to website copy

This is good stuff, I'm going to look at merging https://github.com/microsoft/TypeScript-Website/pull/2031 first as it's a bit bigger then will come back for this - thanks!

ivov

comment created time in 17 hours

push eventivov/TypeScript-Website

Orta Therox

commit sha 6e103459d856d343056ed785e8fb428870f2634f

Update packages/documentation/copy/en/handbook-v2/Everyday Types.md

view details

push time in 17 hours

Pull request review commentmicrosoft/TypeScript-Website

Small improvements to website copy

 function printText(s: string, alignment: "left" | "right" | "center") {   // ...
 }
 printText("Hello, world", "left");
-printText("G'day, mate", "centre");
+printText("G'day, mate", "center");
printText("G'day, mate", "centre");

Aussies use the original ;)

ivov

comment created time in 17 hours

PullRequestReviewEvent