profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/orivej/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

orivej/defmemo 8

Memoizing defun

orivej/bash-traps 2

BASH EXIT trap stack manager experiment

orivej/cl-ants 2

AI Challenge: Ants

orivej/cl-librusec 2

Локальная индексация и поиск в архивах lib.rus.ec'а

orivej/asdf-encodings 1

ASDF auxiliary package providing encoding to external format conversion

orivej/ciede2000 1

CIEDE2000 color difference function, Common Lisp implementation

orivej/cl-ogs 1

online-go.com frontend; only notifier at the moment

orivej/clj-ogs 1

online-go.com clojure client

orivej/coursera_resources_downloader 1

Allows for easy download of resources from a Coursera course.

orivej/AppImageKit 0

Using AppImageKit you can package desktop applications as AppImages that run on common Linux-based operating systems, such as RHEL, CentOS, Ubuntu, Fedora, debian and derivatives.

PullRequestReviewEvent

Pull request review commentNixOS/nixpkgs

reaper: 6.29 -> 6.38

  stdenv.mkDerivation rec {   pname = "reaper";-  version = "6.29";+  version = "6.38";    src = fetchurl {-    url = "https://www.reaper.fm/files/${lib.versions.major version}.x/reaper${builtins.replaceStrings ["."] [""] version}_linux_${stdenv.targetPlatform.qemuArch}.tar.xz";-    hash = if stdenv.isx86_64 then "sha256-DOul6J2Y7szy4+Q4SeO0uG6PSuU+MELE7ky8W3mSpTQ="-                              else "sha256-67iTi6bFlbQtyCjnPIjK8K/3aV+zaCsWBRCWmgYonM4=";+    url = "https://www.reaper.fm/files/${lib.versions.major version}.x/reaper${builtins.replaceStrings ["."] [""] version}_linux_${stdenv.hostPlatform.qemuArch}.tar.xz";+    hash = {+      x86_64-linux = "sha256-K5EnrmzP8pyW9dR1fbMzkPzpS6aHm8JF1+m3afnH4rU=";+      aarch64-linux = "sha256-6wNWDXjQNyfU2l9Xi9JtmAuoKtHuIY5cvNMjYkwh2Sk=";+    }.${stdenv.hostPlatform.system};

Do we need to do anything about this as long as meta.platforms matches this mapping? When I remove x86_64-linux from platforms this error is thrown here:

Package ‘reaper-6.38’ in /home/uj/nix/nixpkgs/pkgs/applications/audio/reaper/default.nix:77 is not supported on ‘x86_64-linux’, refusing to evaluate.
orivej

comment created time in 10 hours

pull request commentNixOS/nixpkgs

tonelib-gfx: 4.6.6 -> 4.7.0

It does not matter much; and you can open a new PR from the same branch, without so many reviewers.

orivej

comment created time in 13 hours

pull request commentNixOS/nixpkgs

tonelib-gfx: 4.6.6 -> 4.7.0

I hope that you can recover your original PR with this commands:

git checkout cubocore-pkgs
git reset --hard dda1752

and then try to rebase it again:

git fetch origin
git rebase origin/master
orivej

comment created time in 14 hours

pull request commentNixOS/nixpkgs

tonelib-gfx: 4.6.6 -> 4.7.0

I was actively involved with Nixpkgs development a few years ago — reviewing pull requests, submitting updates, new packages, fixes for existing packages and for some core problems like #25205, #26554, #28799, #32271 — and eventually was given commit access.

orivej

comment created time in 14 hours

pull request commentNixOS/nixpkgs

tonelib-gfx: 4.6.6 -> 4.7.0

Thank you for the review!

orivej

comment created time in 15 hours

Pull request review commentNixOS/nixpkgs

tonelib-gfx: 4.6.6 -> 4.7.0

-{ stdenv-, dpkg-, lib-, autoPatchelfHook+{ lib+, stdenv , fetchurl-, gtk3-, glib-, desktop-file-utils+, autoPatchelfHook+, dpkg , alsa-lib-, libjack2-, harfbuzz-, fribidi-, pango , freetype+, libglvnd , curl+, libXcursor+, libXinerama+, libXrandr+, libXrender+, libjack2 }:  stdenv.mkDerivation rec {   pname = "tonelib-gfx";-  version = "4.6.6";+  version = "4.7.0";    src = fetchurl {-    url = "https://www.tonelib.net/download/0509/ToneLib-GFX-amd64.deb";-    sha256 = "sha256-wdX3SQSr0IZHsTUl+1Y0iETme3gTyryexhZ/9XHkGeo=";+    url = "https://www.tonelib.net/download/0930/ToneLib-GFX-amd64.deb";+    hash = "sha256-BcbX0dz94B4mj6QeQsnuZmwXAaXH+yJjnrUPgEYVqkU=";   }; +  nativeBuildInputs = [ autoPatchelfHook dpkg ];+   buildInputs = [-    dpkg-    gtk3-    glib-    desktop-file-utils+    stdenv.cc.cc.lib     alsa-lib-    libjack2-    harfbuzz-    fribidi-    pango     freetype-  ];--  nativeBuildInputs = [-    autoPatchelfHook+    libglvnd+  ] ++ runtimeDependencies;++  runtimeDependencies = map lib.getLib [+    curl+    libXcursor+    libXinerama+    libXrandr+    libXrender+    libjack2   ];    unpackPhase = ''

unpackCmd = "dpkg -x $src .": will work if we also add sourceRoot = ".";, but it is not how it is meant to be used. unpackCmd is a command which is called by the default unpackPhase on each src to unpack the sources into a single directory, which becomes the sourceRoot. This is why unpackCmd operates on $curSrc and extracts the deb into a new subdirectory source (which is conventional in Nixpkgs, for example fetchgit or fetchFromGitHub also produce source), and lets the default unpackPhase detect that the sourceRoot is source. dpkg -x $src . can be used in unpackPhase, but it should not be used in unpackCmd.

orivej

comment created time in 16 hours

PullRequestReviewEvent

push eventorivej/nixpkgs

Orivej Desh

commit sha 329bcd13d6c045c4aea027ee7176046d8ab2e973

tonelib-gfx: 4.6.6 -> 4.7.0 Fix runtime dependencies: - libjack2 is needed for jack output - libX* are needed to properly render the GUI Missing runtime dependencies were discovered by running: strace -fe open,openat ToneLib-GFX |& grep glibc | grep ENOENT

view details

push time in 17 hours

pull request commentNixOS/nixpkgs

tonelib-gfx: 4.6.6 -> 4.7.0

OK, I've switched to unpackСmd.

I wanted to say that it is not necessary in principle to leave the second binary

Note that bin/tonelib-gfx is not in the .deb: it is created in our installPhase. I can remove it if you are OK with this.

orivej

comment created time in 19 hours

push eventorivej/nixpkgs

Orivej Desh

commit sha ceb7cb5c2a9bf87ae8327c085d2a74a9e0b1cd6f

tonelib-gfx: 4.6.6 -> 4.7.0 Fix runtime dependencies: - libjack2 is needed for jack output - libX* are needed to properly render the GUI Missing runtime dependencies were discovered by running: strace -fe open,openat ToneLib-GFX |& grep glibc | grep ENOENT

view details

push time in 19 hours

pull request commentNixOS/nixpkgs

tonelib-gfx: 4.6.6 -> 4.7.0

Why keep 2 binar

I want to keep the original binary name ToneLib-GFX because we as package maintainers are not supposed to rename programs, and because this name is used in the .desktop file. I am keeping tonelib-gfx because you have added it and because it is easier to type. Note that it's a symlink and not a copy, so it does not take disk space.

I used $TMP to do not fill in the garbage.

What do you mean? What garbage? The build directory (.) is temporary and should be used for temporary files. Many packages in Nixpkg run either dpkg -x $src $out or dpkg -x $src . (or dpkg-deb instead of dpkg).

orivej

comment created time in a day

PR opened NixOS/nixpkgs

tonelib-gfx: 4.6.6 -> 4.7.0
Motivation for this change

Regular update.

Fix runtime dependencies:

  • libjack2 is needed for jack output
  • libX* are needed to properly render the GUI

Missing runtime dependencies were discovered by running: strace -fe open,openat ToneLib-GFX |& grep glibc | grep ENOENT

Things done
  • Built on platform(s)
    • [x] x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • [ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [x] Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • [ ] (Package updates) Added a release notes entry if the change is major or breaking
    • [ ] (Module updates) Added a release notes entry if the change is significant
    • [ ] (Module addition) Added a release notes entry if adding a new NixOS module
  • [x] Fits CONTRIBUTING.md.
+33 -37

0 comment

1 changed file

pr created time in a day

push eventorivej/nixpkgs

Orivej Desh

commit sha 9d6ac8ed9ca051850fd4df0d4c4f999ecf343bfb

tonelib-gfx: 4.6.6 -> 4.7.0 Fix runtime dependencies: - libjack2 is needed for jack output - libX* are needed to properly render the GUI Missing runtime dependencies were discovered by running: strace -fe open,openat ToneLib-GFX |& grep glibc | grep ENOENT

view details

push time in a day

create barnchorivej/nixpkgs

branch : tonelib-gfx

created branch time in a day

push eventorivej/nixpkgs

Orivej Desh

commit sha 97d32431b18834c2ab0a13f0dff518abcc7ad17d

reaper: 6.29 -> 6.38 Dispatch based on hostPlatform.system, similar to how it is done for example in sbclBootstrap.

view details

push time in 3 days

create barnchorivej/nixpkgs

branch : reaper

created branch time in 4 days

PR opened NixOS/nixpkgs

reaper: 6.29 -> 6.37
Motivation for this change

Regular update.

Dispatch based on hostPlatform.system, similar to how it is done for example in sbclBootstrap.

Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  • Built on platform(s)
    • [x] x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • [ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [x] Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • [ ] (Package updates) Added a release notes entry if the change is major or breaking
    • [ ] (Module updates) Added a release notes entry if the change is significant
    • [ ] (Module addition) Added a release notes entry if adding a new NixOS module
  • [x] Fits CONTRIBUTING.md.
+7 -5

0 comment

1 changed file

pr created time in 4 days

startedjessecrossen/jackstrobe

started time in 4 days

startedx42/jack_midi_latency

started time in 15 days

startedbytedance/music_source_separation

started time in a month

pull request commentNixOS/nixpkgs

grpc: 1.39.1 -> 1.40.0

This update has broken libtensorflow and sysdig (and their dependents: https://hydra.nixos.org/eval/1702650#tabs-now-fail); the apparent cause is that grpc now generates code that has to be linked to libabsl_synchronization, but users of the generated code do not link to it.

marsam

comment created time in a month

startedT-vK/ESP32-BLE-Keyboard

started time in 2 months

PR opened NixOS/nixpkgs

musescore: fix JACK output
Motivation for this change

It needs to load libjack in audio/drivers/jackweakapi.cpp.

Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  • Built on platform(s)
    • [x] x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • [ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [x] Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • [ ] (Package updates) Added a release notes entry if the change is major or breaking
    • [ ] (Module updates) Added a release notes entry if the change is significant
    • [ ] (Module addition) Added a release notes entry if adding a new NixOS module
  • [x] Fits CONTRIBUTING.md.
+2 -0

0 comment

1 changed file

pr created time in 2 months

create barnchorivej/nixpkgs

branch : musescore-jack

created branch time in 2 months

startedlinuxmao-org/ISSE

started time in 2 months

startedberg8793/gba-mus-ripper

started time in 2 months

startedjpmac26/gba-mus-ripper

started time in 2 months

startedpablorocka/hydrogen_drumkit_tools

started time in 2 months

PR opened musnix/musnix

Update readme of env vars and paths
+4 -2

0 comment

1 changed file

pr created time in 3 months