profile
viewpoint
OpenShift Merge Robot openshift-merge-robot Red Hat Raleigh, NC http://github.com/openshift OpenShift Merge Robot

containers/podman 11912

Podman: A tool for managing OCI containers and pods.

containers/buildah 4949

A tool that facilitates building OCI images.

kubevirt/kubevirt 2970

Kubernetes Virtualization API and runtime in order to define and manage virtual machines.

ComplianceAsCode/content 1480

Security automation content in SCAP, OSCAL, Bash, Ansible, and other formats

coreos/rpm-ostree 541

⚛📦 Hybrid image/package system with atomic upgrades and package layering

grafana-operator/grafana-operator 366

An operator for Grafana that installs and manages Grafana instances, Dashboards and Datasources through Kubernetes/OpenShift CRs

containers/dnsname 81

name resolution for containers

containers/common 70

Location for shared common files in github.com/containers repos.

che-incubator/chectl 57

CLI to manage Eclipse Che server and workspaces

konveyor/mig-operator 52

OpenShift Migration Operator

push eventopenshift/installer

sunhui

commit sha 03008c7032b585340cd4d17c9c0e251948dad736

Alibaba: fix load balance listener strategy Disable session persistence and removebBandwidth peak of listener Signed-off-by: sunhui <wb-sh373163@alibaba-inc.com>

view details

OpenShift Merge Robot

commit sha 40b74da2db1cdda0bd8748f5718e11aa051323bc

Merge pull request #5540 from dongchen126/fix-slb-listener Bug 2041361: [Alibaba] fix load balance listener strategy

view details

push time in a few seconds

PR merged openshift/installer

Reviewers
Bug 2041361: [Alibaba] fix load balance listener strategy approved lgtm bugzilla/valid-bug bugzilla/severity-high

Disable session persistence and removebBandwidth peak of listener

+6 -9

20 comments

1 changed file

bd233

pr closed time in a few seconds

push eventcontainers/podman

Matthew Heon

commit sha 141de86862898a4b9e35c15f51031952c63c7114

Revamp Libpod state strings for Docker compat Improve our compatibility with Docker by better handling the state strings that we print in `podman ps`. Docker capitalizes all states in `ps` (we do not) - fix this in our PS code. Also, stop normalizing ContainerStateConfigured to the "Created" state, and instead make it always be Created, with the existing Created state becoming Initialized. I didn't rename the actual states because I'm somewhat reticent to make such a large change a day before we leave for break. It's somewhat confusing that ContainerStateConfigured now returns Created, but internally and externally we're still consistent. [NO NEW TESTS NEEDED] existing tests should catch anything that broke. I also consider this a breaking change. I will flag appropriately on Github. Fixes RHBZ#2010432 and RHBZ#2032561 Signed-off-by: Matthew Heon <mheon@redhat.com>

view details

OpenShift Merge Robot

commit sha d6b0720b9cd5d993dffc229e73d8377aae2c2ed4

Merge pull request #12684 from mheon/remap_states Revamp Libpod state strings for Docker compat

view details

push time in 10 minutes

PR merged containers/podman

Revamp Libpod state strings for Docker compat lgtm approved breaking-change

Improve our compatibility with Docker by better handling the state strings that we print in podman ps. Docker capitalizes all states in ps (we do not) - fix this in our PS code. Also, stop normalizing ContainerStateConfigured to the "Created" state, and instead make it always be Created, with the existing Created state becoming Initialized.

I didn't rename the actual states because I'm somewhat reticent to make such a large change a day before we leave for break. It's somewhat confusing that ContainerStateConfigured now returns Created, but internally and externally we're still consistent.

[NO NEW TESTS NEEDED] existing tests should catch anything that broke.

I also consider this a breaking change. I will flag appropriately on Github.

Fixes RHBZ#2010432 and RHBZ#2032561

+24 -18

17 comments

8 changed files

mheon

pr closed time in 11 minutes

push eventopenshift-psap/special-resource-operator

Quentin Barrand

commit sha b4d686f2e1c991a07b78f7e3319f80be080fe8b2

Improve documentation for the SpecialResource API. (#232) Mark unused types as such. Re-generate manifests.

view details

push time in 20 minutes

push eventopenshift-psap/special-resource-operator

Quentin Barrand

commit sha b4d686f2e1c991a07b78f7e3319f80be080fe8b2

Improve documentation for the SpecialResource API. (#232) Mark unused types as such. Re-generate manifests.

view details

push time in 20 minutes

push eventopenshift/release

openshift-bot

commit sha e062ff7ad3d45dae73722f55b8d35880dfb3c48c

registry-replacer --github-token-path /etc/github/oauth --github-endpoint http://ghproxy --config-dir ./ci-operator/config --registry ./ci-operator/step-registry --prune-unused-replacements --prune-ocp-builder-replacements --prune-unused-base-images --ensure-correct-promotion-dockerfile --current-release-minor=8 --ensure-correct-promotion-dockerfile-ignored-repos openshift/origin-aggregated-logging --ensure-correct-promotion-dockerfile-ignored-repos openshift/console

view details

openshift-bot

commit sha 7c2cc9f66e20c705a5cca4bcdb3cec77a1cad820

ci-operator-config-mirror --config-dir ./ci-operator/config --to-org openshift-priv --only-org openshift --whitelist-file ./core-services/openshift-priv/_whitelist.yaml

view details

OpenShift Merge Robot

commit sha 222b395c9335b571d81c267de82afc7c948aa372

Merge pull request #25373 from openshift-bot/auto-config-brancher Automate config brancher by auto-config-brancher job at Tue, 18 Jan 2022 11:03:03 UTC

view details

push time in 20 minutes

push eventcontainers/podman

Daniel J Walsh

commit sha 10d969ff1a15e8f53eb5a2fa7eb8cfb321609b55

Use PODMAN_USERNS environment variable when running as a service Fixes: https://github.com/containers/podman/issues/11350#issuecomment-1011562526 Also add inspect information about the idmappings if they exists. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

view details

OpenShift Merge Robot

commit sha d0eb24bae0023848447568d024acdaadb632edfe

Merge pull request #12870 from rhatdan/userns1 Use PODMAN_USERNS environment variable when running as a service

view details

push time in 24 minutes

issue closedcontainers/podman

Read PODMAN_USERNS env variable when creating containers through compose API

<!--

BUG REPORT INFORMATION

Use the commands below to provide key information from your environment: You do NOT have to include this information if this is a FEATURE REQUEST

NOTE A large number of issues reported against Podman are often found to already be fixed in more current versions of the project. Before reporting an issue, please verify the version you are running with podman version and compare it to the latest release documented on the top of Podman's README.md. If they differ, please update your version of Podman to the latest possible and retry your command before creating an issue.

Also, there is a running list of known issues in the Podman Troubleshooting Guide, please reference that page before opening a new issue.

If you are filing a bug against podman build, please instead file a bug against Buildah (https://github.com/containers/buildah/issues). Podman build executes Buildah to perform container builds, and as such the Buildah maintainers are best equipped to handle these bugs. -->

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

<!-- Briefly describe the problem you are having in a few paragraphs. -->

Running or creating containers from API is not consistent with creating them through the podman cli. Specifically, the PODMAN_USERNS environment variable for the podman system service is completely ignored and therefore you can't set a value as the default for that configuration.

The impact is for running rootless Podman + docker-compose, I can't have a similar experience as I would have with Docker + compose.

Steps to reproduce the issue:

  1. Install docker-compose

  2. Configure podman to run as rootless.

  3. Start podman system service (through systemctl enable --now --user podman.socket)

  4. Run docker-compose run --rm testservice ls -lah /srv using the docker-compose.yml below:

    services:
      testservice:
        image: docker.io/alpine:latest
        volumes:
          - ./:/srv
    
    

Describe the results you received:

You will see the list of files of your current directory as if they're owned by root. This is expected by a rootless container, however there's no way of turning it off, as you would have if you used this command:

podman run --userns=keep-id --rm -it -v "$(pwd):/srv" docker.io/alpine:latest ls -lah /srv

There's no support for setting userns in docker-compose to the value of keep-id, which is the option that allows us to disable the root mapping. I understand though, that this is a limitation of docker-compose and docker-py themselves (you can set userns_mode but only to the value of host, which is supported by Docker engine).

Describe the results you expected:

The implementation of userns (#3196) allowed us to set a global environment variable PODMAN_USERNS and then all containers created through podman run/create would have the userns set to the value of that variable. This does not happen, however, if you try to create the container through the Docker compose API. By using the API, you are required to send the HostConfig.UserNSMode parameter every time, so there's no concept of defaulting to env var. Therefore I couldn't even set that environment variable before running the server, because it will be ignored.

Output of podman version:

podman version 3.3.0

Output of podman info --debug:

host:
  arch: amd64
  buildahVersion: 1.22.3
  cgroupControllers: []
  cgroupManager: systemd
  cgroupVersion: v2
  conmon:
    package: /usr/bin/conmon is owned by conmon 1:2.0.29-1
    path: /usr/bin/conmon
    version: 'conmon version 2.0.29, commit: 7e6de6678f6ed8a18661e1d5721b81ccee293b9b'
  cpus: 12
  distribution:
    distribution: arch
    version: unknown
  eventLogger: journald
  hostname: Arch-Home.lan
  idMappings:
    gidmap:
    - container_id: 0
      host_id: 1000
      size: 1
    - container_id: 1
      host_id: 10000
      size: 65536
    uidmap:
    - container_id: 0
      host_id: 1000
      size: 1
    - container_id: 1
      host_id: 10000
      size: 65536
  kernel: 5.10.60-1-lts
  linkmode: dynamic
  memFree: 9391316992
  memTotal: 16670494720
  ociRuntime:
    name: crun
    package: /usr/bin/crun is owned by crun 0.21-1
    path: /usr/bin/crun
    version: |-
      crun version 0.21
      commit: c4c3cdf2ce408ed44a9e027c618473e6485c635b
      spec: 1.0.0
      +SYSTEMD +SELINUX +APPARMOR +CAP +SECCOMP +EBPF +YAJL
  os: linux
  remoteSocket:
    exists: true
    path: /run/user/1000/podman/podman.sock
  security:
    apparmorEnabled: false
    capabilities: CAP_CHOWN,CAP_DAC_OVERRIDE,CAP_FOWNER,CAP_FSETID,CAP_KILL,CAP_NET_BIND_SERVICE,CAP_SETFCAP,CAP_SETGID,CAP_SETPCAP,CAP_SETUID,CAP_SYS_CHROOT
    rootless: true
    seccompEnabled: true
    seccompProfilePath: /etc/containers/seccomp.json
    selinuxEnabled: false
  serviceIsRemote: false
  slirp4netns:
    executable: /usr/bin/slirp4netns
    package: /usr/bin/slirp4netns is owned by slirp4netns 1.1.12-1
    version: |-
      slirp4netns version 1.1.12
      commit: 7a104a101aa3278a2152351a082a6df71f57c9a3
      libslirp: 4.6.1
      SLIRP_CONFIG_VERSION_MAX: 3
      libseccomp: 2.5.1
  swapFree: 0
  swapTotal: 0
  uptime: 27m 1.63s
registries: {}
store:
  configFile: /home/dpereira/.config/containers/storage.conf
  containerStore:
    number: 1
    paused: 0
    running: 0
    stopped: 1
  graphDriverName: overlay
  graphOptions:
    overlay.mount_program:
      Executable: /usr/bin/fuse-overlayfs
      Package: /usr/bin/fuse-overlayfs is owned by fuse-overlayfs 1.7.1-1
      Version: |-
        fusermount3 version: 3.10.4
        fuse-overlayfs: version 1.7.1
        FUSE library version 3.10.4
        using FUSE kernel interface version 7.31
  graphRoot: /home/dpereira/.local/share/containers/storage
  graphStatus:
    Backing Filesystem: extfs
    Native Overlay Diff: "false"
    Supports d_type: "true"
    Using metacopy: "false"
  imageStore:
    number: 27
  runRoot: /run/user/1000/containers
  volumePath: /home/dpereira/.local/share/containers/storage/volumes
version:
  APIVersion: 3.3.0
  Built: 1629546498
  BuiltTime: Sat Aug 21 08:48:18 2021
  GitCommit: 98f252a3a1a8f1ee00f9f96c6ba00500954b5093-dirty
  GoVersion: go1.17
  OsArch: linux/amd64
  Version: 3.3.0

Package info (e.g. output of rpm -q podman or apt list podman):

❯ pacman -Qi podman
Name            : podman
Version         : 3.3.0-1
Description     : Tool and library for running OCI-based containers in pods
Architecture    : x86_64
URL             : https://github.com/containers/podman
Licenses        : Apache
Groups          : None
Provides        : None
Depends On      : cni-plugins  conmon  containers-common  device-mapper  iptables  libseccomp  crun  slirp4netns  libsystemd  fuse-overlayfs  libgpgme.so=11-64
Optional Deps   : podman-docker: for Docker-compatible CLI [installed]
                  btrfs-progs: support btrfs backend devices [installed]
                  catatonit: --init flag support
                  crun: support for unified cgroupsv2 [installed]
Required By     : podman-docker
Optional For    : None
Conflicts With  : None
Replaces        : None
Installed Size  : 71.69 MiB
Packager        : Morten Linderud <foxboron@archlinux.org>
Build Date      : Sat 21 Aug 2021 08:48:18 AM -03
Install Date    : Tue 24 Aug 2021 02:21:56 AM -03
Install Reason  : Explicitly installed
Install Script  : No
Validated By    : Signature

Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide? (https://github.com/containers/podman/blob/master/troubleshooting.md)

Yes

Additional environment details (AWS, VirtualBox, physical, etc.):

I'm running it locally.

closed time in 25 minutes

kriansa

PR merged containers/podman

Use PODMAN_USERNS environment variable when running as a service lgtm approved

Fixes: https://github.com/containers/podman/issues/11350#issuecomment-1011562526

Also add inspect information about the idmappings if they exists.

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

<!-- Thanks for sending a pull request!

Please make sure you've read our contributing guidelines and how to submit a pull request (https://github.com/containers/podman/blob/main/CONTRIBUTING.md#submitting-pull-requests).

In case you're only changing docs, make sure to prefix the pull-request title with "[CI:DOCS]". That will prevent functional tests from running and save time and energy.

Finally, be sure to sign commits with your real name. Since by opening a PR you already have commits, you can add signatures if needed with something like git commit -s --amend. -->

+58 -3

3 comments

4 changed files

rhatdan

pr closed time in 25 minutes

push eventopenshift/assisted-test-infra

dependabot[bot]

commit sha 91019b93694a690b7e4a1dff0159b88ffa3869ca

Bump libvirt-python from 7.10.0 to 8.0.0 (#1381) Bumps [libvirt-python](http://www.libvirt.org) from 7.10.0 to 8.0.0. --- updated-dependencies: - dependency-name: libvirt-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 30 minutes

push eventopenshift/ocm-agent-operator

Bo Meng

commit sha 8a22305441046227655452d2e28ad200839396fd

init the ocmagent CRD

view details

Bo Meng

commit sha 0119a69e5d7dbb638c89558cb6c4dcff5b866199

fix the generated files

view details

OpenShift Merge Robot

commit sha de6ac533f210998a72706c63c7908681a5908845

Merge pull request #9 from bmeng/ocmagent_cr init the ocmagent CRD and api

view details

push time in 36 minutes

PR merged openshift/ocm-agent-operator

Reviewers
init the ocmagent CRD and api approved lgtm

What type of PR is this?

feature

What this PR does / why we need it?

Initiate the custom resource and the api for the operator

Which Jira/Github issue(s) this PR fixes?

Fixes OSD-8937

Special notes for your reviewer:

Pre-checks (if applicable):

  • [ ] Tested latest changes against a cluster
  • [ ] Ran make generate command locally to validate code changes
  • [ ] Included documentation changes with PR
+126 -89

7 comments

6 changed files

bmeng

pr closed time in 37 minutes

push eventshipwright-io/build

Baran Dalgic

commit sha 9d061d8da276e190acbabc35fb9fe2b00e495ad0

Fix image override bug for mutate-image in config Fixes bug by overriding the right entry of `config` instead of the `GitContainerTemplate`. Adds previously missing unit tests to make sure that override is sound.

view details

OpenShift Merge Robot

commit sha 5afa4c37c56f6c0c34e010327dae1550e53a9749

Merge pull request #982 from dalbar/bug/mutate-image-template-override Fix image override bug for mutate-image in config

view details

push time in 39 minutes

PR merged shipwright-io/build

Reviewers
Fix image override bug for mutate-image in config kind/bug lgtm approved release-note

Changes

Minimal example to reproduce:

package config

import (
	"os"
	"testing"
)

func TestOverrideBug(t *testing.T) {
	cfg := NewDefaultConfig()

	os.Setenv("GIT_CONTAINER_IMAGE", "git-image")
	cfg.SetConfigFromEnv()

	if cfg.GitContainerTemplate.Image != "git-image" {
		t.Fatal("override did not set git image")
	}

	os.Setenv("MUTATE_IMAGE_CONTAINER_TEMPLATE", `{"image":"mutate-image"`)
	cfg.SetConfigFromEnv()

	if cfg.GitContainerTemplate.Image != "git-image" {
		t.Fatalf("mutate image overrides git-template")
	}
}

Fixes bug by overriding the right entry of config instead of the GitContainerTemplate. It additionally adds previously missing unit tests to make sure that override for mutate-image is sound.

Submitter Checklist

  • [x] Includes tests if functionality changed/was added
  • [x] Includes docs if changes are user-facing
  • [x] Set a kind label on this PR
  • [x] Release notes block has been filled in, or marked NONE

See the contributor guide for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Fixes override bug for `pkg/config`: Setting the environment variabel `MUTATE_IMAGE_CONTAINER_TEMPLATE` now works as intended and does not override `config.GitContainerTemplate`.

/kind bug

+38 -1

2 comments

2 changed files

dalbar

pr closed time in 39 minutes

PR merged openshift-psap/special-resource-operator

Improve documentation for the SpecialResource API approved lgtm ok-to-test

Mark unused types as such. Re-generate manifests.

/cc @pacevedom @pmtk

+145 -36

3 comments

3 changed files

qbarrand

pr closed time in 41 minutes

push eventopenshift-psap/special-resource-operator

Quentin Barrand

commit sha b4d686f2e1c991a07b78f7e3319f80be080fe8b2

Improve documentation for the SpecialResource API. (#232) Mark unused types as such. Re-generate manifests.

view details

push time in 41 minutes

PR merged stolostron/work

fix CVE-2021-43565 in 2.3 branch dco-signoff: yes lgtm approved

The related issue: https://github.com/stolostron/backlog/issues/18891 Signed-off-by: Yang Le yangle@redhat.com

+12386 -13764

4 comments

231 changed files

elgnay

pr closed time in an hour

push eventstolostron/work

Yang Le

commit sha 544936a5ec0eb415df4949bbccfba4d9ddc0c8b0

fix CVE-2021-43565 in 2.3 branch (#22) Signed-off-by: Yang Le <yangle@redhat.com>

view details

push time in an hour

push eventopenshift/assisted-test-infra

dependabot[bot]

commit sha 91019b93694a690b7e4a1dff0159b88ffa3869ca

Bump libvirt-python from 7.10.0 to 8.0.0 (#1381) Bumps [libvirt-python](http://www.libvirt.org) from 7.10.0 to 8.0.0. --- updated-dependencies: - dependency-name: libvirt-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in an hour

delete branch openshift/assisted-test-infra

delete branch : dependabot/pip/libvirt-python-8.0.0

delete time in an hour

PR merged openshift/assisted-test-infra

Reviewers
Bump libvirt-python from 7.10.0 to 8.0.0 ok-to-test approved size/XS lgtm dependencies python

Bumps libvirt-python from 7.10.0 to 8.0.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+1 -1

11 comments

1 changed file

dependabot[bot]

pr closed time in an hour

push eventstolostron/work

Yang Le

commit sha f05bb16450847d45e1807f0edf7167533419f147

fix CVE-2021-43565 in 2.4 branch (#23) Signed-off-by: Yang Le <yangle@redhat.com>

view details

push time in an hour

push eventstolostron/work

Yang Le

commit sha 35de46b8ac4a2f76bf1d243290b3b070fa7d3c4d

org rename in 2.2 branch (#24) Signed-off-by: Yang Le <yangle@redhat.com>

view details

push time in an hour

PR merged stolostron/work

org rename in 2.2 branch dco-signoff: yes lgtm approved

The related issue: https://github.com/stolostron/backlog/issues/18746 Signed-off-by: Yang Le yangle@redhat.com

+8 -51

3 comments

3 changed files

elgnay

pr closed time in an hour

push eventcri-o/cri-o

Skyler Clark

commit sha 86e43fc28dbafedbecd3a9ff86b4c0f2c84b7f30

adds comments to default values Signed-off-by: Skyler Clark <skylerjaneclark@gmail.com>

view details

Skyler Clark

commit sha d7da8b2b08ca968f83fed51d58dea2c26262aa3f

adds config template linting Signed-off-by: Skyler Clark <skylerjaneclark@gmail.com>

view details

OpenShift Merge Robot

commit sha 3d39dc3a68e16fc4ba06d211f965da23883c5774

Merge pull request #5007 from wgahnagl/fixDefaultComments Comments default values instead of omitting them

view details

push time in an hour

push eventstolostron/cluster-proxy-addon

xuezhaojun

commit sha 2480056b49254416f3c0fae58f524b44573985f6

rename org name to stolostron in 2.4 branch (#44) Signed-off-by: xuezhaojun <zxue@redhat.com>

view details

push time in an hour

push eventstolostron/cluster-proxy-addon-chart

xuezhaojun

commit sha 59bdbc7169903e69d1c7e69801a1c1a8fdb3038c

rename org name to stolostron in 2.4 branch (#18) Signed-off-by: xuezhaojun <zxue@redhat.com>

view details

push time in an hour

PR merged cri-o/cri-o

Reviewers
Comments default values instead of omitting them lgtm approved release-note ok-to-test dco-signoff: yes

<!-- Thanks for sending a pull request!

Please be aware that we're following the Kubernetes guidelines of contributing to this project. This means that we have to use this mandatory template for all of our pull requests.

Please also make sure you've read and understood our contributing guidelines (https://github.com/cri-o/cri-o/blob/master/CONTRIBUTING.md) as well as ensuring that all your commits are signed with git commit -s.

Here are some additional tips for you:

  • If this is your first time, please read our contributor guidelines: https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide
  • Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here: https://git.k8s.io/community/contributors/devel/sig-release/release.md#issuepr-kind-label
  • If you want faster PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews
  • If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests -->

What type of PR is this?

<!-- Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line: -->

<!-- /kind api-change /kind bug /kind ci /kind cleanup /kind dependency-change /kind deprecation /kind design /kind documentation /kind failing-test /kind feature /kind flake

kind other -->

What this PR does / why we need it:

changes the default crio config to print default config values as comments instead of ommitting them

Which issue(s) this PR fixes:

<!-- Automatically closes linked issue when PR is merged. Usage: Fixes #<issue number>, or Fixes (paste link of issue). -->

Fixes #4770

<!-- Fixes # or None -->

Special notes for your reviewer:

Does this PR introduce a user-facing change?

<!-- If no, just write None in the release-note block below. If yes, a release note is required: Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".

For more information on release notes see: https://git.k8s.io/community/contributors/guide/release-notes.md -->

changes default config output to comment default values instead of omitting them

+145 -113

37 comments

6 changed files

wgahnagl

pr closed time in an hour

more