profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/olivergondza/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

ContainX/openstack4j 272

A Fluent OpenStack SDK / Client Library for Java

jenkinsci/mailer-plugin 29

This plugin allows you to configure email notifications for build results

jenkinsci/lib-annotation-indexer 6

Jenkins annotation-indexer library

jenkinsci/tmpcleaner-plugin 4

Jenkins tmpcleaner plugin

ContainX/openstack4j.com 0

OpenStack4j Website Source

Pull request review commentjenkinsci/gerrit-trigger-plugin

[JENKINS-53250] Gerrit Trigger plugin compatibility with JCasC (JEP-201)

             <version>2.4</version>             <scope>provided</scope>         </dependency>+        <dependency>+            <artifactId>configuration-as-code</artifactId>+            <groupId>io.jenkins</groupId>+            <version>1.36</version>+            <optional>true</optional>+        </dependency>+        <dependency>+            <artifactId>test-harness</artifactId>+            <groupId>io.jenkins.configuration-as-code</groupId>+            <version>1.36</version>+            <scope>test</scope>+        </dependency>+        <dependency>+            <groupId>org.jenkins-ci.main</groupId>+            <artifactId>jenkins-test-harness</artifactId>+            <version>2.56</version>+        </dependency>

@rsandell, Can you please cut 2.35 (there is only a beta out). It affects unrelated plugins as Jenkins introspect this test-only dependency. Thanks!

olivergondza

comment created time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentjenkinsci/gerrit-trigger-plugin

[JENKINS-53250] Gerrit Trigger plugin compatibility with JCasC (JEP-201)

             <version>2.4</version>             <scope>provided</scope>         </dependency>+        <dependency>+            <artifactId>configuration-as-code</artifactId>+            <groupId>io.jenkins</groupId>+            <version>1.36</version>+            <optional>true</optional>+        </dependency>+        <dependency>+            <artifactId>test-harness</artifactId>+            <groupId>io.jenkins.configuration-as-code</groupId>+            <version>1.36</version>+            <scope>test</scope>+        </dependency>+        <dependency>+            <groupId>org.jenkins-ci.main</groupId>+            <artifactId>jenkins-test-harness</artifactId>+            <version>2.56</version>+        </dependency>

What a rookie mistake. Resoled in alpha in https://github.com/jenkinsci/gerrit-trigger-plugin/commit/63407f4c4a314043b39b21c5cc340bb9a8200e7b

olivergondza

comment created time in 10 days

push eventjenkinsci/jms-messaging-plugin

Oliver Gondža

commit sha 65e02ec5113235123710761be2532cf09adc7c8c

Fix code formatting

view details

push time in 11 days

push eventjenkinsci/jms-messaging-plugin

Oliver Gondža

commit sha fdcdb4c65bbe8b9c793b14b46d54e135ebdaa3e6

[maven-release-plugin] prepare for next development iteration

view details

push time in 11 days

created tagjenkinsci/jms-messaging-plugin

tagparent-1.1.23

created time in 11 days

push eventjenkinsci/jms-messaging-plugin

Oliver Gondža

commit sha 5ca4e787d97c7dce0400c9e6e13eb1eb634db249

[maven-release-plugin] prepare release parent-1.1.23

view details

push time in 11 days

delete branch olivergondza/jms-messaging-plugin

delete branch : fix-rabbitmq-message-id

delete time in 11 days

push eventjenkinsci/jms-messaging-plugin

Oliver Gondža

commit sha 6135d0b1b6625a1c51de0528e2f037c38be068b6

Fix #218: Do not prefix Rabbit MQ messages with current year

view details

Oliver Gondža

commit sha 735da13ac06821232a9580cd1650c88c49b0a88d

Use new repository for ui-tests

view details

Oliver Gondža

commit sha b4c3585cf9f3d86ed490741c151e5be7be9c9d00

Bump ATH version to resolve plugin using https

view details

Oliver Gondža

commit sha 16e50cd09931e8407cda1c51620f45fd63b7f881

Merge pull request #219 from olivergondza/fix-rabbitmq-message-id Fix #218: Do not prefix Rabbit MQ messages with current year

view details

push time in 11 days

issue closedjenkinsci/jms-messaging-plugin

messageId property has malformed format

Hello,

The bug is in RabbitMQ part of this plugin. Messages sent with jms-messaging-plugin to RabbitMQ fedora broker have incorrect messageId property. Property messageId has prefix : year-UUID. This is bug.

From : https://fedora-messaging.readthedocs.io/en/stable/wire-format.html#message-id

The message ID field MUST be a version 4 UUID as a standard hexadecimal digit string (e.g. f81d4fae-7dec-11d0-a765-00a0c91e6bf6)

https://github.com/jenkinsci/jms-messaging-plugin/blob/master/plugin/src/main/java/com/redhat/jenkins/plugins/ci/messaging/data/RabbitMQMessage.java#L75

has code:

daee7469 (Oliver Gondža 2020-09-01 20:52:34 +0200 75)             this.msgId = Calendar.getInstance().get(1) + "-" + UUID.randomUUID().toString();

What impact is:

  • messages are malformed.
  • Broker can easily drop messages that doesn't comply with requirements.
  • There is internal logic for datagrepper, where it adds year to messageID too. ---> mess with messageID.

More info you can find at: https://pagure.io/fedora-infrastructure/issue/10084

closed time in 11 days

Andrei-Stepanov

PR merged jenkinsci/jms-messaging-plugin

Fix #218: Do not prefix Rabbit MQ messages with current year

<!-- Please describe your pull request here. -->

  • [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x] Ensure that the pull request title represents the desired changelog entry
  • [x] Please describe what you did
  • [x] Link to relevant issues in GitHub or Jira
  • [x] Link to relevant pull requests, esp. upstream and downstream changes
  • [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

<!-- Put an x into the [ ] to show you have filled the information. The template comes from https://github.com/jenkinsci/.github/blob/master/.github/pull_request_template.md You can override it by creating .github/pull_request_template.md in your own repository -->

CC @Andrei-Stepanov, @Zlopez

+5 -13

0 comment

2 changed files

olivergondza

pr closed time in 11 days

push eventolivergondza/jms-messaging-plugin

Oliver Gondža

commit sha b4c3585cf9f3d86ed490741c151e5be7be9c9d00

Bump ATH version to resolve plugin using https

view details

push time in 12 days

push eventolivergondza/jms-messaging-plugin

Oliver Gondža

commit sha 735da13ac06821232a9580cd1650c88c49b0a88d

Use new repository for ui-tests

view details

push time in 12 days

PR opened jenkinsci/jms-messaging-plugin

Fix #218: Do not prefix Rabbit MQ messages with current year

<!-- Please describe your pull request here. -->

  • [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x] Ensure that the pull request title represents the desired changelog entry
  • [x] Please describe what you did
  • [x] Link to relevant issues in GitHub or Jira
  • [x] Link to relevant pull requests, esp. upstream and downstream changes
  • [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

<!-- Put an x into the [ ] to show you have filled the information. The template comes from https://github.com/jenkinsci/.github/blob/master/.github/pull_request_template.md You can override it by creating .github/pull_request_template.md in your own repository -->

CC @Andrei-Stepanov, @Zlopez

+2 -3

0 comment

1 changed file

pr created time in 13 days

create barncholivergondza/jms-messaging-plugin

branch : fix-rabbitmq-message-id

created branch time in 13 days

issue commentjenkinsci/jms-messaging-plugin

messageId property has malformed format

No idea why it is being done this way: https://github.com/jenkinsci/jms-messaging-plugin/pull/154/files#diff-55442404b12c5e36812d6d2244165fb065f02677aa22a00fc7df400e4b4011b2R98

@Zlopez, what is the motivation to prefix the auto-generated IDs? Thanks!

Andrei-Stepanov

comment created time in 13 days

delete branch olivergondza/docker

delete branch : revert-revert-bats

delete time in 16 days

delete branch olivergondza/docker

delete branch : rhel-ubi

delete time in 16 days

pull request commentjenkinsci/docker

Introduce RHEL 8 support using UBI image

@dduportal, nope. That should not be needed anymore: https://github.com/jenkinsci/docker/pull/1145

olivergondza

comment created time in 16 days

PR opened jenkinsci/docker

Bring back "chore: Bump Bats to 1.3.0 (#1127)"

Unrevert the bats upgrade revert that sneaked in as a part of https://github.com/jenkinsci/docker/pull/1120

@timja, @dduportal, @saper

+19 -68

0 comment

5 changed files

pr created time in 16 days

create barncholivergondza/docker

branch : revert-revert-bats

created branch time in 16 days

PullRequestReviewEvent

push eventolivergondza/docker

Oliver Gondža

commit sha 1745fcd03160bfbd68d523748fe3681a78534f62

rebuild

view details

push time in 16 days

pull request commentjenkinsci/docker

Introduce RHEL 8 support using UBI image

Good catch, @saper. @timja, nice timing ;-)

olivergondza

comment created time in 16 days

push eventolivergondza/docker

Oliver Gondža

commit sha 59576b49a7e6d9fff0168fb384feb16ae36ea903

Revert "chore: Bump Bats to 1.3.0 (#1127)" This reverts commit 451591c5a028ba1c9d8197016ce316ce51a5933e.

view details

Oliver Gondža

commit sha 33f745a40b1a71f42f395439ca364ea27733ff81

Add all other platforms

view details

Oliver Gondža

commit sha 37fda2b684e67ee12796c56b69c0d47b11bbbdb8

Merge branch 'master' of github.com:jenkinsci/docker into rhel-ubi

view details

Oliver Gondža

commit sha a235b6632de08b65fcb253ecac6fbb57d8bb4fb4

Move plugin manager to /opt for UBI

view details

Oliver Gondža

commit sha 22109400a1e1815ef6206595bbd3c7a137588380

Merge branch 'rhel-ubi' of github.com:olivergondza/docker into rhel-ubi

view details

push time in 16 days

pull request commentjenkinsci/docker

Introduce RHEL 8 support using UBI image

Unfortunately, reverting 451591c5a028ba1c9d8197016ce316ce51a5933e made no difference. It is strange this only impacts the added image and not the others. Will need to dig deeper...

olivergondza

comment created time in 17 days

pull request commentjenkinsci/docker

Introduce RHEL 8 support using UBI image

Any idea why the tests might be failing? https://ci.jenkins.io/job/Packaging/job/docker/job/PR-1120/17/execution/node/101/log/

It feels like it cannot find the image under tests in some occasions. Reproducible locally.

olivergondza

comment created time in 17 days

Pull request review commentjenkinsci/docker

Introduce RHEL 8 support using UBI image

 target "debian_slim_jdk8" {   platforms = ["linux/amd64", "linux/ppc64le", "linux/arm64"] } +target "rhel_ubi8_jdk11" {+  dockerfile = "11/rhel/ubi8/hotspot/Dockerfile"+  context = "."+  args = {+    JENKINS_VERSION = JENKINS_VERSION+    JENKINS_SHA = JENKINS_SHA+  }+  tags = [+    "${REGISTRY}/${JENKINS_REPO}:${JENKINS_VERSION}-rhel-ubi8-jdk11",+    equal(LATEST_WEEKLY, "true") ? "${REGISTRY}/${JENKINS_REPO}:rhel-ubi8-jdk11" : "",+    equal(LATEST_LTS, "true") ? "${REGISTRY}/${JENKINS_REPO}:lts-rhel-ubi8-jdk11" : "",+  ]+  platforms = ["linux/amd64"]

None that I know of. Just opted to make the image set smaller than larger when Ubi inclusion is being considered. I do not mind adding all the platforms.

olivergondza

comment created time in 17 days

push eventjenkinsci/pipeline-examples

Oliver Gondža

commit sha 285cc2a0833ee8b2eba7eec9d8b8bde0d9139b6b

typo in BEST_PRACTICES.md

view details

Oliver Gondža

commit sha fb9575a8182b51614f5f0df912b46b37d95fbb8d

Merge pull request #102 from jenkinsci/olivergondza-patch-1 typo in BEST_PRACTICES.md

view details

push time in 17 days