profile
viewpoint

dtolnay/serde-yaml 351

Strongly typed YAML library for Rust

http-rs/async-h1 127

Asynchronous HTTP/1.1 in Rust

oli-obk/camera_capture 33

Crate for capturing images from a webcam

christianpoveda/sire 18

A symbolic evaluator for MIR

embed-rs/embedded-rs 15

Rust embed crate

mbr/mealy-rs 1

Worlds smallest crate.

oli-obk/bareboard 1

Ada source code and complete sample GNAT projects for selected bare-board platforms supported by GNAT.

Lireer/ricochet-robot-solver 0

Solver for ricochet robots written in rust

startedmozilla/geckodriver

started time in 4 hours

starteddherman/winfolder

started time in 7 hours

PR opened rust-lang/miri

Add shim for libc::sysconf(libc::_SC_NPROCESSORS_CONF)

libc::sysconf(libc::_SC_NPROCESSORS_CONF) is used by AArch64 devices to get the number of CPUs in the num_cpus crate:

https://github.com/seanmonstar/num_cpus/blob/b423db0a698b035914ae1fd6b7ce5d2a4e727b46/src/lib.rs#L337-L342

+1 -0

0 comment

1 changed file

pr created time in 14 hours

startedesanum/flutter-trial

started time in 18 hours

created repositoryesanum/flutter-trial

Just evaluating flutter

created time in 18 hours

issue openedoli-obk/cargo_metadata

Why stringly typed data?

It's more of a question and probably I don't see enough details but why Target.kind has a type Vec<String> and doesn't use a proper enum for kinds? Could a kind contain an arbitrary string?

created time in 19 hours

PR merged rust-lang/miri

rustup; test swap of element with itself

Cc https://github.com/rust-lang/rust/issues/80682

+7 -1

4 comments

2 changed files

RalfJung

pr closed time in 19 hours

push eventrust-lang/miri

Ralf Jung

commit sha 3990debf824925230abca279661d7630fd859409

rustup; test swap of element with itself

view details

bors

commit sha 6fdda8aac97c57c84671ae54b6c9377245bc33e8

Auto merge of #1682 - RalfJung:rustup, r=RalfJung rustup; test swap of element with itself Cc https://github.com/rust-lang/rust/issues/80682

view details

push time in 19 hours

pull request commentrust-lang/miri

rustup; test swap of element with itself

:sunny: Test successful - checks-actions Approved by: RalfJung Pushing 6fdda8aac97c57c84671ae54b6c9377245bc33e8 to master... <!-- homu: {"type":"BuildCompleted","approved_by":"RalfJung","base_ref":"master","builders":{"checks-actions":"https://github.com/rust-lang/miri/runs/1747523276"},"merge_sha":"6fdda8aac97c57c84671ae54b6c9377245bc33e8"} -->

RalfJung

comment created time in 19 hours

pull request commentrust-lang/miri

rustup; test swap of element with itself

:hourglass: Testing commit 3990debf824925230abca279661d7630fd859409 with merge 6fdda8aac97c57c84671ae54b6c9377245bc33e8... <!-- homu: {"type":"BuildStarted","head_sha":"3990debf824925230abca279661d7630fd859409","merge_sha":"6fdda8aac97c57c84671ae54b6c9377245bc33e8"} -->

RalfJung

comment created time in 20 hours

push eventrust-lang/miri

Ralf Jung

commit sha 3990debf824925230abca279661d7630fd859409

rustup; test swap of element with itself

view details

bors

commit sha 6fdda8aac97c57c84671ae54b6c9377245bc33e8

Auto merge of #1682 - RalfJung:rustup, r=RalfJung rustup; test swap of element with itself Cc https://github.com/rust-lang/rust/issues/80682

view details

push time in 20 hours

pull request commentrust-lang/miri

rustup; test swap of element with itself

:pushpin: Commit 3990debf824925230abca279661d7630fd859409 has been approved by RalfJung

<!-- @bors r=RalfJung 3990debf824925230abca279661d7630fd859409 --> <!-- homu: {"type":"Approved","sha":"3990debf824925230abca279661d7630fd859409","approver":"RalfJung"} -->

RalfJung

comment created time in 20 hours

pull request commentrust-lang/miri

rustup; test swap of element with itself

@bors r+

RalfJung

comment created time in 20 hours

PR opened rust-lang/miri

rustup; test swap of element with itself
+7 -1

0 comment

2 changed files

pr created time in 20 hours

pull request commentrust-lang/miri

Add ABI check for shims

find_mir_or_eval_fn is called for each function call. ... The main entry point you have to worry about is this

Thanks for pointing me in the right direction, that solved the failing test :smile:

Sorry for the notification spam in the related issue (forgot about the commit message). This PR should be ready for review when you are.

unseddd

comment created time in a day

create barnchLireer/ricochet-robot-solver

branch : lir/ffi

created branch time in a day

pull request commentrust-lang/miri

Add ABI check for shims

Still need to figure out all the callers of the shim find_mir_or_eval_fn.

find_mir_or_eval_fn is called for each function call. Usually it looks up the MIR of the function, but for some function, there's no MIR -- in particular, for extern-imported functions. Generally Miri will just error, saying that it cannot call functions for which there is no MIR available. However, for some specific of these functions, we have implemented "shims" by hand that implement the intended behavior by directly manipulating interpreter state.

The main entry point you have to worry about is this:

https://github.com/rust-lang/miri/blob/903bfd82bfe4fca0b85c8b7eb01b5841eac45f8c/src/shims/foreign_items.rs#L112

unseddd

comment created time in a day

pull request commentrust-lang/miri

Add ABI check for shims

Sorry for the delay; I am quite busy currently so it could take a bit until I can take a closer look at what you did. It's on my queue though and will not get lost!

No worries, thanks for letting me know. No intention of being a nuisance :smile:

If it is __rust_begin_short_backtrace, then that function does have the Rust ABI, not the C ABI -- so looks like the check is wrong here

I'll look into it more, then. Still need to figure out all the callers of the shim find_mir_or_eval_fn. From your earlier comment, I thought these would all be extern "C" calls, but maybe that's only a subset? Anyway, thanks for the feedback, will keep working on this.

unseddd

comment created time in a day

pull request commentrust-lang/miri

Add ABI check for shims

With the update, looks like a test(s) is now failing. Is this expected? Should I fix the test, or did I screw something up?

That's a bit hard to tell, which function is it talking about? If it is __rust_begin_short_backtrace, then that function does have the Rust ABI, not the C ABI -- so looks like the check is wrong here.

unseddd

comment created time in 2 days

pull request commentrust-lang/miri

Add ABI check for shims

Sorry for the delay; I am quite busy currently so it could take a bit until I can take a closer look at what you did. It#s on my queue though and will not get lost!

Would it be correct to just do something simple like

Well, the question is where you meant to put that check. The ABI might not be the same for all the shims we have. It probably is Abi::C for most of them, but some functions will have other ABIs. Probably what makes most sense is to first handle the other ABIs, and then use the existing code for the C ABI.

unseddd

comment created time in 2 days

pull request commentrust-lang/miri

Add ABI check for shims

@RalfJung I changed the ABI check, and rebased on latest master. Let me know what you think.

With the update, looks like a test(s) is now failing. Is this expected? Should I fix the test, or did I screw something up?

unseddd

comment created time in 2 days

pull request commentrust-lang/miri

[cargo-miri] Skip unit tests of `proc-macro` crates

Maybe GHA has network trouble... try waiting a few hours.

hyd-dev

comment created time in 4 days

pull request commentrust-lang/miri

[cargo-miri] Skip unit tests of `proc-macro` crates

https://github.com/rust-lang/miri/runs/1726967213#step:6:42:

44.25 MB / 109.67 MB [==============>--------------------] 40.35 % 8.84 MB/s 7s error: failed to unpack `rustc-dev-nightly-x86_64-apple-darwin/rustc-dev/lib/rustlib/x86_64-apple-darwin/lib/librustc_privacy` into `master/lib/rustlib/x86_64-apple-darwin/lib/librustc_privacy-2effdb4f4976d8ce.rlib`
caused by: request or response body error: error reading a body from connection: end of file before message length reached
caused by: error reading a body from connection: end of file before message length reached
caused by: end of file before message length reached
Error: Process completed with exit code 1.

What's wrong with it?

hyd-dev

comment created time in 4 days

PullRequestEvent

PR closed rust-lang/miri

[cargo-miri] Skip unit tests of `proc-macro` crates

Fixes #1660.

+182 -125

10 comments

5 changed files

hyd-dev

pr closed time in 4 days

pull request commentrust-lang/miri

[cargo-miri] Skip unit tests of `proc-macro` crates

https://github.com/rust-lang/miri/runs/1726955222#step:6:43:

76.69 MB / 103.84 MB [=========================>--------] 73.86 % 10.95 MB/s 2s error: failed to unpack `rustc-dev-nightly-x86_64-unknown-linux-gnu/rustc-dev/lib/rustlib/x86_64-unknown-linux-gnu/lib/librus` into `master/lib/rustlib/x86_64-unknown-linux-gnu/lib/librustc_driver-844665e24828f0f2.so`
caused by: request or response body error: error reading a body from connection: Connection reset by peer (os error 104)
caused by: error reading a body from connection: Connection reset by peer (os error 104)
caused by: Connection reset by peer (os error 104)
Error: Process completed with exit code 1.

Another network failure? :sob:

hyd-dev

comment created time in 4 days

PullRequestEvent

PR closed rust-lang/miri

[cargo-miri] Skip unit tests of `proc-macro` crates

Fixes #1660.

+182 -125

9 comments

5 changed files

hyd-dev

pr closed time in 4 days

pull request commentrust-lang/miri

[cargo-miri] Skip unit tests of `proc-macro` crates

https://github.com/rust-lang/miri/runs/1726916680#step:6:43:

230.81 KB / 2.06 MB [===>------------------------------] 10.92 % 64.72 KB/s 29s error: failed to unpack `rust-src-nightly/rust-src/lib/rustlib/src/rust/library/stdarch/crates/stdarch-verify/x86-intel.xml` into `master/lib/rustlib/src/rust/library/stdarch/crates/stdarch-verify/x86-intel.xml`
caused by: request or response body error: error reading a body from connection: end of file before message length reached
caused by: error reading a body from connection: end of file before message length reached
caused by: end of file before message length reached
Error: Process completed with exit code 1.

Network failure? I'll try to retrigger it.

hyd-dev

comment created time in 4 days

Pull request review commentrust-lang/miri

[cargo-miri] Skip unit tests of `proc-macro` crates

 def test_cargo_miri_test():         "test.subcrate.stdout.ref", "test.stderr-empty.ref",         env={'MIRIFLAGS': "-Zmiri-disable-isolation"},     )+    test("`cargo miri test` (proc-macro-crate)",+        cargo_miri("test") + ["-p", "proc-macro-crate"],+        "test.proc-macro-crate.stdout.ref", "test.stderr-proc-macro.ref",+    )+    test("`cargo miri test` (subcrate and proc-macro-crate, lib target)",+        cargo_miri("test") + ["-p", "subcrate", "-p", "proc-macro-crate", "lib"],+        "test.subcrate-proc-macro-crate.lib-target.stdout.ref", "test.stderr-proc-macro.ref",+    )+    test("`cargo miri test` (proc-macro-crate, test target)",+        cargo_miri("test") + ["-p", "proc-macro-crate", "--test", "test"],+        "test.proc-macro-crate.test-target.stdout.ref", "test.stderr-empty.ref",+    )

I reworked the test. Hope it looks better now.

hyd-dev

comment created time in 4 days

more