profile
viewpoint
Nick Schonning nschonni Treasury Board of Canada Secretariat Ottawa, Ontario, Canada Please don't email me, use the issue tracker

push eventnodejs/nodejs.dev

David Ye

commit sha 1358bb53b85f780b9881ccd7120fdb1ceeda4f75

Append `()` to the function name (#378)

view details

push time in 2 hours

PR merged nodejs/nodejs.dev

Append `()` to the function name

<!-- Please read the Code of Conduct and the Contributing Guidelines before opening a pull request. -->

Description

<!-- Write a brief description of the changes introduced by this PR -->

Related Issues

<!-- Link to the issue that is fixed by this PR (if there is one) e.g. Fixes #1234, Addresses #1234, Related to #1234, etc. -->

+1 -1

1 comment

1 changed file

yedeyu

pr closed time in 2 hours

pull request commentcanada-ca/cloud-guardrails

fix: Minor Markdownlint and Link checks

OK build is green again :)

nschonni

comment created time in 11 hours

push eventnschonni/cloud-guardrails

Po @ TBS-Cyber

commit sha b8c3fa160c7614819fa0f5ef339b9789bc412efe

Update 09_Network-Security-Services.md

view details

Po @ TBS-Cyber

commit sha 7bdbf5176f7bd846600baf6e0b69dd2cefc534eb

Update 10_Cyber-Defense-Services.md

view details

Po @ TBS-Cyber

commit sha 9b6ada566dfcee0c2f9388a6ba9528d11b38bfb3

Update 11_Logging-and-Monitoring.md

view details

Po @ TBS-Cyber

commit sha 075775042260134e62a626d1d85146b464363049

Update 12_Cloud-Marketplace-Config.md

view details

Po @ TBS-Cyber

commit sha 71051cf1f83cf8756b8cc794fc94c56b403d850d

Update 10_Cyber-Defense-Services.md

view details

Nick Schonning

commit sha b53f1100a14355f4f65482df546444f708627222

fix: MD009/no-trailing-spaces Trailing spaces

view details

Nick Schonning

commit sha 24b5db8f016e41729ba454493eb44746e2bf7a30

fix: MD012/no-multiple-blanks Multiple consecutive blank lines

view details

Nick Schonning

commit sha 7c5b70f8a0c56cc714e2c6c1da73a0d93333dd4b

chore: Ignore internal GC links from linting

view details

push time in 12 hours

push eventnschonni/TBS-OCIO-ESP

Nick Schonning

commit sha ff01e540365d645f0bad9f3ab15f52c4202083f3

Set up CI with Azure Pipelines [skip ci]

view details

push time in 13 hours

PR opened nschonni/TBS-OCIO-ESP

Set up CI with Azure Pipelines
+19 -0

0 comment

1 changed file

pr created time in 13 hours

create barnchnschonni/TBS-OCIO-ESP

branch : azure-pipelines

created branch time in 13 hours

fork nschonni/TBS-OCIO-ESP

Workload management for the Enterprise Strategic Planning directorate of the Office of the CIO for Canada

https://canada-ca.github.io/TBS-OCIO-ESP/earb-forward-agenda/index.html

fork in 13 hours

issue closedsass/node-sass

Issue when using the cluster mode of PM2 and node-sass

Hello,

I get an issue using "node-sass" and PM2. When running my app with the cluster mode of PM2 I get an error :

Error: Missing binding /var/www/*****/cms/node_modules/node-sass/vendor/linux-x64-57/binding.node
Node Sass could not find a binding for your current environment: Linux 64-bit with Node.js 8.x
Found bindings for the following environments:
  - Linux 64-bit with Node.js 6.x
This usually happens because your environment has changed since running `npm install`.
Run `npm rebuild node-sass` to download the binding for your current environment.
    at module.exports (/var/www/*****/cms/node_modules/node-sass/lib/binding.js:15:13)
    at Object.<anonymous> (/var/www/*****/cms/node_modules/node-sass/lib/index.js:14:35)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Function._load (/usr/local/lib/node_modules/pm2/node_modules/@pm2/io/build/main/src/metrics/transaction.js:109:33)
    at Module.require (module.js:596:17)
    at Module.newFunc [as require] (/usr/local/lib/node_modules/pm2/node_modules/deep-metrics/lib/aspect.js:101:26)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/var/www/*****/cms/app/controllers/OptionController.js:4:25)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Function._load (/usr/local/lib/node_modules/pm2/node_modules/@pm2/io/build/main/src/metrics/transaction.js:109:33)
    at Module.require (module.js:596:17)
    at Module.newFunc [as require] (/usr/local/lib/node_modules/pm2/node_modules/deep-metrics/lib/aspect.js:101:26)
    at require (internal/module.js:11:18)
    at /var/www/*****/cms/server.js:64:18

It works on my local server, and on my remote server without the cluster mode.

Versions and architecture :

  • NPM version : 3.10.10
  • Node version : v6.9.4
  • Node Process :
{ http_parser: '2.7.0',
  node: '6.9.4',
  v8: '5.1.281.89',
  uv: '1.9.1',
  zlib: '1.2.8',
  ares: '1.10.1-DEV',
  icu: '57.1',
  modules: '48',
  openssl: '1.0.2j' }
  • Node Platform : linux
  • Node architecture : x64
  • node-sass version :
node-sass       4.13.0  (Wrapper)       [JavaScript]
libsass         3.5.4   (Sass Compiler) [C/C++]
  • npm node-sass versions : node-sass@4.13.0

closed time in a day

anthonycluse

issue commentsass/node-sass

Issue when using the cluster mode of PM2 and node-sass

Sorry, I'm not sure what "PM2" is, but we do test the Linux & Node 13 combo in our CI

anthonycluse

comment created time in a day

issue closedsass/node-sass

Space before class-dot

  • NPM version (npm -v): 6.10.3
  • Node version (node -v): 12.10.0
  • Node Process (node -p process.versions):
{
  node: '12.10.0',
  v8: '7.6.303.29-node.16',
  uv: '1.31.0',
  zlib: '1.2.11',
  brotli: '1.0.7',
  ares: '1.15.0',
  modules: '72',
  nghttp2: '1.39.2',
  napi: '4',
  llhttp: '1.1.4',
  http_parser: '2.8.0',
  openssl: '1.1.1c',
  cldr: '35.1',
  icu: '64.2',
  tz: '2019a',
  unicode: '12.1'
}
  • Node Platform (node -p process.platform): win32
  • Node architecture (node -p process.arch): x64
  • node-sass version (node -p "require('node-sass').info"):
$ node-sass -v
node-sass       4.13.0  (Wrapper)       [JavaScript]
libsass         3.5.4   (Sass Compiler) [C/C++]
  • npm node-sass versions (npm ls node-sass): ``-- node-sass@4.13.0`

With the following block:

div {
    width: 300px;
    height: 200px;
    background-color: red;
    padding: 5px;

    .matrix {
        // matrix(scaleX, skewY, skewX, scaleY, translateX, translateY)
        transform: matrix(1, 2, -1, 1, 80, 80);
    }
}

I get the following output with --output-style=expanded. This bug applies to all output-styles.

div {
  width: 300px;
  height: 200px;
  background-color: red;
  padding: 5px;
}

div .matrix {
  transform: matrix(1, 2, -1, 1, 80, 80);
}

/*# sourceMappingURL=matrix.css.map */

A keen eye would spot the div .matrix which, at least on Firefox Quantum v72.0b4, doesn't actually apply the matrix class, as that's for any child. Sure, that might be the wanted behaviour in some situations, but in most, it's not. Is there a way to nest like this without having that problem?

closed time in a day

Proximyst

issue commentsass/node-sass

Space before class-dot

If you're looking for a child selector, it would be https://developer.mozilla.org/en-US/docs/Web/CSS/Child_combinator (you probably know this already). SASS can only output the nesting that you provide, rather than make assumptions, and the output is validate CSS specificity logic. You can play around on sassmeister.com, since we only output according to the reference implementation (was Ruby, now Dart-Sass)

Proximyst

comment created time in a day

issue closedsass/node-sass

CSS file is not overwritten, instead changes are appended

node v12.13.1 npm 6.12.1 node-sass 4.13.0 libsass 3.5.4

node -p process.versions

{ node: '12.13.1', v8: '7.7.299.13-node.16', uv: '1.33.1', zlib: '1.2.11', brotli: '1.0.7', ares: '1.15.0', modules: '72', nghttp2: '1.39.2', napi: '5', llhttp: '1.1.4', http_parser: '2.8.0', openssl: '1.1.1d', cldr: '35.1', icu: '64.2', tz: '2019c', unicode: '12.1' }

node -p process.platform

linux

node -p process.arch

x64

I am using node-sass --watch file.scss > file.css on the command line, but any changes are appended to the output file, instead of overwriting it:

=> changed: /media/xyz/file.scss

[changes here..]

 => changed: /media/xyz/file.scss

[changes here..]

Nor sure where to look for in the documentation. Any clues?

closed time in a day

paddelboot

issue commentsass/node-sass

CSS file is not overwritten, instead changes are appended

If you're using the redirect operator https://quickleft.com/blog/command-line-tutorials-redirection-pipes/ and it's not working, that is a system level issue unrelated to node-sass

paddelboot

comment created time in a day

issue closedsass/node-sass

node-sass not found

Hi,

I know this has been asked before but using linux here and on a bamboo agent. npm install works if I run it on a local ubuntu setup but trying to run it as part of a build I receive the following:

09-Dec-2019 17:52:02 Downloading binary from https://github.com/sass/node-sass/releases/download/v4.9.4/linux-x64-72_binding.node 09-Dec-2019 17:52:03 Cannot download "https://github.com/sass/node-sass/releases/download/v4.9.4/linux-x64-72_binding.node": 09-Dec-2019 17:52:03 HTTP error 404 Not Found

I have had a look at the github project and no binary linux-x64-72_binding.node exists for v4.9.4 Only for v4.13.0. On my local Ubuntu installation the binary https://github.com/sass/node-sass/releases/download/v4.9.4/linux-x64-57_binding.node is downloaded and exists.

What determines which binary is being downloaded from a release?

Thanks for the assistance.

closed time in a day

iburrows

issue commentsass/node-sass

node-sass not found

Your server is running an older version of Node that is incompatible with Node 13 https://github.com/sass/node-sass/blob/master/TROUBLESHOOTING.md#404s

iburrows

comment created time in a day

pull request commentcanada-ca/cloud-guardrails

fix: Minor Markdownlint and Link checks

Not sure about the local failure, since it's not showing up on my Windows machine, so I'll take a look on OSX tonight

nschonni

comment created time in a day

pull request commentcanada-ca/cloud-guardrails

fix: Minor Markdownlint and Link checks

@ptd-tbs the internal GoC links are probably good for the audience, but if you think that public collaboration might be needed, then moving might be required (GCconnex, intranet.canada.ca)

nschonni

comment created time in a day

create barnchnschonni/cloud-guardrails

branch : lint-fixes

created branch time in a day

push eventnschonni/cloud-guardrails

Nick Schonning

commit sha bc99e153c0d890078538743311b88f6496f15fd8

chore: Add Git dotfiles

view details

Nick Schonning

commit sha 03d3a3db69a9d40f57e4ab30b75bc51772a9c5cc

chore: Copy linting setup from template repo Minor formatting for Markdownlint flagging. Additional issues with files with capitalized MD that will be tackled after.

view details

Nick Schonning

commit sha 6bfb44d6b56883a0c891c9d9db61d3d95f854a35

chore: Update Markdown paths - Pad file names with zero for sorting on web - Update casing of extension for consistent globing for later linting - Make links from README relative so they work directly inside the branch - Replace spaces with dashes for 11

view details

Po @ TBS-Cyber

commit sha fa77787e4e381a5c822b4fc4efaa67f8d012be38

Merge pull request #5 from nschonni/markdown-casing chore: Update Markdown paths

view details

Po @ TBS-Cyber

commit sha e9cbaa29b683db21415d7e4db0bab7169072f224

Merge pull request #4 from nschonni/temaplate-files chore: Copy linting setup from template repo

view details

Po @ TBS-Cyber

commit sha eaf1eea0142399dd2a8d101d224697f7d881b34f

Update 01_Protect-Root-Account.md

view details

Po @ TBS-Cyber

commit sha 3a7ec90bd783e4b930a640762e41a3907639d241

Update 01_Protect-Root-Account.md

view details

Po @ TBS-Cyber

commit sha 674ceed9b9b135b580da6df6c78d891e10238d0c

Update 02_Management-Admin-Privileges.md

view details

Po @ TBS-Cyber

commit sha 5825124ca37eebdff8d71bdd9d3ca4d4b071c691

Update 03_Cloud-Console-Access.md

view details

Po @ TBS-Cyber

commit sha 2fd5e5620948c392cd59be47b6eacade27326a5e

Update 05_Data-Location.md

view details

Po @ TBS-Cyber

commit sha 2cc89f735e6d6933d7bfb5e217d40f66d30fff5b

Update 04_Enterprise-Monitoring-Accounts.md

view details

Po @ TBS-Cyber

commit sha f0bde145bddb5fb694c7e6b8e8ef8e8ab0d926a7

Update 06_Protect-Data-at-Rest.md

view details

Po @ TBS-Cyber

commit sha 72e23d2bffd2007cf4281fd5e71b540d3e5c1669

Update 07_Protect-Data-in-Transit.md

view details

Po @ TBS-Cyber

commit sha bebb8e1bc6156ebb7faf5e27aa0c80d80be902c0

Update 08_Segmentation.md

view details

push time in a day

delete branch nschonni/cloud-guardrails

delete branch : markdown-casing

delete time in a day

delete branch nschonni/cloud-guardrails

delete branch : temaplate-files

delete time in a day

startedaws-quickstart/quickstart-compliance-nist

started time in a day

pull request commentdotnet/docs

chore: Run Markdownlint with GitHub Actions

@mairaw curious to hear how the trial has gone

nschonni

comment created time in 2 days

push eventnschonni/cloud-guardrails

Nick Schonning

commit sha 6bfb44d6b56883a0c891c9d9db61d3d95f854a35

chore: Update Markdown paths - Pad file names with zero for sorting on web - Update casing of extension for consistent globing for later linting - Make links from README relative so they work directly inside the branch - Replace spaces with dashes for 11

view details

push time in 3 days

PR opened canada-ca/cloud-guardrails

chore: Update Markdown paths
  • Pad file names with zero for sorting on web
  • Update casing of extension for consistent globing for later linting
  • Make links from README relative so they work directly inside the branch
  • Replace spaces with dashes for 11
+12 -12

0 comment

13 changed files

pr created time in 3 days

create barnchnschonni/cloud-guardrails

branch : markdown-casing

created branch time in 3 days

PR opened canada-ca/cloud-guardrails

chore: Copy linting setup from template repo

Minor formatting for Markdownlint flagging. Additional issues with files with capitalized MD that will be tackled after.

+1038 -3

0 comment

9 changed files

pr created time in 3 days

create barnchnschonni/cloud-guardrails

branch : temaplate-files

created branch time in 3 days

fork nschonni/cloud-guardrails

Minimum guardrails for GC's cloud operationalization framework.

fork in 3 days

issue commentcanada-ca/design-system-systeme-conception

Add stylelint for CSS files

I'm good with discussing this one separately, just linking back to the general thread of #16 Might close the PR, just because of the orphan branch stuff that @delisma is trying to do, but I think the addition probably makes sense. We haven't cut a release on the CSS lint project in forever 😝

cindyledev

comment created time in 4 days

delete branch nschonni/CordovaDocs

delete branch : patch-1

delete time in 4 days

issue commentAzure/azure-rest-api-specs

Typo softareUpdateConfigurationRunTasks in Microsoft.Automation

These are minor, but they affect the documentation, and are likely to cause client support requests when they spell it correctly and it doesn't work. Not as big a deal now since the build will fail unless corrected when submitting a new version of the API though

nschonni

comment created time in 4 days

issue closedsass/node-sass

Any plans to upgrade node-gyp to latest version?

Any plans to upgrade node-gyp to latest version? Then we are not forced to use Python 2, we are able to use Python 3 instead.

closed time in 5 days

codler

issue commentsass/node-sass

Any plans to upgrade node-gyp to latest version?

Also a duplicate of #2716 and a bunch of other isssues

codler

comment created time in 5 days

delete branch canada-ca/ore-ero

delete branch : lac-guidelines-link

delete time in 5 days

startedGSA/code-gov-open-source-toolkit

started time in 5 days

issue openedcanada-ca/design-system-systeme-conception

Should design system have page level commenting

The docs.microsoft.com uses a customized version of https://utteranc.es/ It allows a comment section that is backed by GitHub issues. This could allow a more context specific version of https://github.com/alphagov/govuk-design-system-backlog/issues/

created time in 5 days

issue closedcanada-ca/welcome

Install request for Netifly

Request from @Borges-Porteous for design-system

https://github.com/apps/netlify/installations/new/permissions?request_id=72832&target_id=20973642

closed time in 5 days

nschonni

issue commentcanada-ca/welcome

Install request for Netifly

I'm going to go ahead an approve it. If people are looking for it in other repos, please comment below

nschonni

comment created time in 5 days

issue openedcanada-ca/welcome

Install request for Netifly

Request from @Borges-Porteous for design-system

https://github.com/apps/netlify/installations/new/permissions?request_id=72832&target_id=20973642

created time in 5 days

pull request commentsass/node-sass

feat: Switch to node-pre-gyp

@codler no, it is just as an alternate to our custom build scripts to pull down pre-built binaries. All native modules in node use node-gyp as the fallback build.

nschonni

comment created time in 6 days

issue commentcanada-ca/aia-eia-js

Add Alternate Language Field for Complete AIA

I'm not sure if we need much that is view specific or not. When I was going through the docs and kicking the WYSIWYG, survey.js looked like it can tie visibility of a question on a page based off of other answers. EX: on the summary page, question13_translation could be shown if question13 isn't empty. Might be good to document if a suffix or some other pattern should be followed when adding those questions. Might want to figure out if we just suffix those

ShadeWyrm

comment created time in 6 days

issue commentnodejs/i18n

website content to be translated

@zeke @obensource any progress? There have been more people trying to add additional languages and having a better way for them to start contributing would be great

maddhruv

comment created time in 6 days

issue commentsass/node-sass

_sass_make_boolean symbol not found

Also old, but I'd try out some of this stuff https://stackoverflow.com/questions/15678546/git-dyld-lazy-symbol-binding-failed-symbol-not-found-iconv-open#23785476 I had problems with recent XCode updates as well that messed up general brew/build things till it was able to get past it

dodgertodd

comment created time in 6 days

Pull request review commentnodejs/nodejs.org

about-release-schedule.hbs: add image dimensions

         {{{ contents }}}          <p>-          <img alt="{{ title }}" src="https://raw.githubusercontent.com/nodejs/Release/master/schedule.svg?sanitize=true">+          <img src="https://raw.githubusercontent.com/nodejs/Release/master/schedule.svg?sanitize=true" alt="{{ title }}" width="960" height="500">

Should the SVG get pulled down as part of the build like the schedule.json?

XhmikosR

comment created time in 6 days

pull request commentnodejs/docker-node

chore: update to v13.3.0

This might also be related, as it happened with the last 13 release as well https://github.com/nodejs/build/issues/2059

SimenB

comment created time in 6 days

Pull request review commentnodejs/nodejs.dev

docs: correct azure documentation link

 This is a great article on [getting started with Node.js on Heroku](https://devc  Azure is the Microsoft Cloud offering. -Check out how to [create a Node.js web app in Azure](https://docs.microsoft.com/en-us/microsoftteams/platform/get-started/get-started-nodejs).+Check out how to [create a Node.js web app in Azure](https://docs.microsoft.com/en-us/azure/app-service/app-service-web-get-started-nodejs).

minor: Removing the locale will redirect to the users correct one

Check out how to [create a Node.js web app in Azure](https://docs.microsoft.com/azure/app-service/app-service-web-get-started-nodejs).
clarkio

comment created time in 7 days

issue commentmicrosoft/vscode-docs-authoring

add metadata nag options

An alternate/additional approach would be to have a third auto option, that would auto-update the date on save. I wouldn't suggest that as a default, and maybe you already discounted that as part of your internal discussions.

meganbradley

comment created time in 7 days

issue commentnodejs/docker-node

configuration_issues (vulnerabilities) with FROM node:10

node:10 is based off of Debian Stretch if you look at https://hub.docker.com/_/node/ There is still no MySQL added as part of the node image on top of that, so any security vulerability/issues is with the base image. The SECURITY.md talks about that stuff, which is why I pointed it out

rols2015

comment created time in 7 days

issue commentnodejs/docker-node

configuration_issues (vulnerabilities) with FROM node:10

This image doesn't include any MySQL install. If there are vulnerabilities in the base Alpine image, they need to be reported to those projects, not here

rols2015

comment created time in 7 days

issue commentnodejs/docker-node

configuration_issues (vulnerabilities) with FROM node:10

This isn't something in this image, see https://github.com/nodejs/docker-node/blob/master/SECURITY.md#reporting-a-vulnerability for explaination

rols2015

comment created time in 7 days

push eventGoC-Spending/goc-spending-laravel

dependabot[bot]

commit sha c455b315b68705955d026998212b80120e4f0401

Bump symfony/http-foundation from 3.3.9 to 3.4.36 Bumps [symfony/http-foundation](https://github.com/symfony/http-foundation) from 3.3.9 to 3.4.36. - [Release notes](https://github.com/symfony/http-foundation/releases) - [Changelog](https://github.com/symfony/http-foundation/blob/master/CHANGELOG.md) - [Commits](https://github.com/symfony/http-foundation/compare/v3.3.9...v3.4.36) Signed-off-by: dependabot[bot] <support@github.com>

view details

Nick Schonning

commit sha d6187ac00c56ac81b9f790ecbc7bb7c17205719f

Merge pull request #15 from GoC-Spending/dependabot/composer/symfony/http-foundation-3.4.36 Bump symfony/http-foundation from 3.3.9 to 3.4.36

view details

push time in 7 days

PR merged GoC-Spending/goc-spending-laravel

Bump symfony/http-foundation from 3.3.9 to 3.4.36 dependencies

Bumps symfony/http-foundation from 3.3.9 to 3.4.36. <details> <summary>Changelog</summary>

Sourced from symfony/http-foundation's changelog.

CHANGELOG

5.1.0

  • Deprecate Response::create(), JsonResponse::create(), RedirectResponse::create(), and StreamedResponse::create() methods (use __construct() instead)

5.0.0

  • made Cookie auto-secure and lax by default
  • removed classes in the MimeType namespace, use the Symfony Mime component instead
  • removed method UploadedFile::getClientSize() and the related constructor argument
  • made Request::getSession() throw if the session has not been set before
  • removed Response::HTTP_RESERVED_FOR_WEBDAV_ADVANCED_COLLECTIONS_EXPIRED_PROPOSAL
  • passing a null url when instantiating a RedirectResponse is not allowed

4.4.0

  • passing arguments to Request::isMethodSafe() is deprecated.
  • ApacheRequest is deprecated, use the Request class instead.
  • passing a third argument to HeaderBag::get() is deprecated, use method all() instead
  • [BC BREAK] PdoSessionHandler with MySQL changed the type of the lifetime column, make sure to run ALTER TABLE sessions MODIFY sess_lifetime INTEGER UNSIGNED NOT NULL to update your database.
  • PdoSessionHandler now precalculates the expiry timestamp in the lifetime column, make sure to run CREATE INDEX EXPIRY ON sessions (sess_lifetime) to update your database to speed up garbage collection of expired sessions.
  • added SessionHandlerFactory to create session handlers with a DSN
  • added IpUtils::anonymize() to help with GDPR compliance.

4.3.0

  • added PHPUnit constraints: RequestAttributeValueSame, ResponseCookieValueSame, ResponseHasCookie, ResponseHasHeader, ResponseHeaderSame, ResponseIsRedirected, ResponseIsSuccessful, and ResponseStatusCodeSame
  • deprecated MimeTypeGuesserInterface and ExtensionGuesserInterface in favor of Symfony\Component\Mime\MimeTypesInterface.
  • deprecated MimeType and MimeTypeExtensionGuesser in favor of Symfony\Component\Mime\MimeTypes.
  • deprecated FileBinaryMimeTypeGuesser in favor of Symfony\Component\Mime\FileBinaryMimeTypeGuesser.
  • deprecated FileinfoMimeTypeGuesser in favor of Symfony\Component\Mime\FileinfoMimeTypeGuesser.
  • added UrlHelper that allows to get an absolute URL and a relative path for a given path

4.2.0

  • the default value of the "$secure" and "$samesite" arguments of Cookie's constructor </tr></table> ... (truncated) </details> <details> <summary>Commits</summary>
  • d2d0cfe [HttpFoundation] Fixed typo
  • f7efd0b Simpler example for Apache basic auth workaround
  • ef5fed4 [HttpFoundation] Allow redirecting to URLs that contain a semicolon
  • c9425ba Fix MySQL column type definition.
  • 9e4b3ac [HttpFoundation] fix guessing mime-types of files with leading dash
  • a5d46a3 Fix MockFileSessionStorageTest::sessionDir being used after it's unset
  • 7b4626a Remove unused local variables in tests
  • 4db558c Add plus character + to legal mime subtype
  • 233f40c [HttpFoundation] Check if data passed to SessionBagProxy::initialize is an array
  • 35ffbbf [HttpFoundation] allow additinal characters in not raw cookies
  • Additional commits viewable in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+74 -14

0 comment

1 changed file

dependabot[bot]

pr closed time in 7 days

pull request commentcanada-ca/design-system-systeme-conception

Create branch "master-new" as a Jekyll site

Sent an invitation link to that should be appearing for them on https://github.com/canada-ca/design-system-systeme-conception/invitations

delisma

comment created time in 8 days

delete branch canada-ca/design-system-systeme-conception

delete branch : lighthouse-ci

delete time in 8 days

pull request commentcanada-ca/design-system-systeme-conception

chore: Add Lighthouse-CI config

It can get merged at the end, but if you're going to do the orphan master branch, I can rebase or redo this afterwards

nschonni

comment created time in 9 days

issue commentigorshubovych/markdownlint-cli

MD006 only corrects first list item

Awesome stuff @DavidAnson

nschonni

comment created time in 9 days

pull request commentnodejs/nodejs.org

Fixing translation (fr-FR)

Ping @nodejs/nodejs-fr

ShadixAced

comment created time in 10 days

delete branch nschonni/vsts-docs

delete branch : fix--MD046/code-block-style-docs/repos

delete time in 10 days

delete branch nschonni/azure-docs

delete branch : fix--articles/visual-studio/vs-storage-webjobs-getting-started-tables.md

delete time in 10 days

pull request commentnodejs/nodejs.org

Add blog post for v10 LTS to v12 LTS

@bnb are you still working on this?

bnb

comment created time in 11 days

delete branch nodejs/nodejs.org

delete branch : nschonni-patch-1

delete time in 11 days

push eventnodejs/nodejs.org

Enver Arslan

commit sha 8a02f4e8f318f6cca77538de7834c90b380827d7

change Javascript to JavaScript for proper name.

view details

Enver Arslan

commit sha 7de8100606dc06b2baf14b22dbd72ab151c6f0d0

add translated resources.

view details

push time in 11 days

PR merged nodejs/nodejs.org

Turkish language localization minor update
  • Fix homepage Javascript to JavaScript
  • Add resources page.
+32 -1

1 comment

2 changed files

enverarslan

pr closed time in 11 days

push eventenverarslan/nodejs.org

dependabot-preview[bot]

commit sha 08dc90c7eae7f07b4cadaba228b03c454335fd46

build(deps-dev): bump lockfile-lint from 3.0.1 to 3.0.3 Bumps [lockfile-lint](https://github.com/lirantal/lockfile-lint) from 3.0.1 to 3.0.3. - [Release notes](https://github.com/lirantal/lockfile-lint/releases) - [Commits](https://github.com/lirantal/lockfile-lint/compare/lockfile-lint@3.0.1...lockfile-lint@3.0.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Nick Schonning

commit sha 9624629758a0e0a4c63e53e9a8fc310ff65f80ea

Merge branch 'master' into master

view details

push time in 11 days

Pull request review commentnodejs/TSC

Remove Python3 strategic initiative

 and have the support needed. [node#18106]: https://github.com/nodejs/node/issues/18106 [fishrock123]: https://github.com/fishrock123 [addaleax]: https://github.com/addaleax+[cclauss]: https://github.com/cclauss [mhdawson]: https://github.com/mhdawson [rvagg]: https://github.com/rvagg+[sam-github]: https://github.com/sam-github

Isn't needed now that initiative is removed

sam-github

comment created time in 11 days

Pull request review commentnodejs/TSC

Remove Python3 strategic initiative

 and have the support needed. [node#18106]: https://github.com/nodejs/node/issues/18106 [fishrock123]: https://github.com/fishrock123 [addaleax]: https://github.com/addaleax+[cclauss]: https://github.com/cclauss

Isn't needed now that initiative is removed

sam-github

comment created time in 11 days

issue commentsass/node-sass

@import from node_modules does not allow omitting file extension

The option if you are just using node-sass and not though a separate build tool is the includePaths https://github.com/sass/node-sass#includepaths

teetotum

comment created time in 11 days

issue commentnodejs/nodejs.org

Add OpenJS Foundation logo

Is this something like how Linux Foundation banner is in the footer, or something else?

mcollina

comment created time in 11 days

push eventcanada-ca/ore-ero

Bryan Willey

commit sha 3ee3354857b77bc47cffbb08375f1b3d9b5ccb89

🤖 Committed by bryan.willey@cds-snc.ca

view details

Nick Schonning

commit sha d276df0144591b343c76f8f247ca0fe3fd585da6

Merge pull request #834 from canada-bot/pr-20191129634 feat: Add CDS Notify PaaS

view details

push time in 11 days

PR merged canada-ca/ore-ero

Updated code for Treasury Board of Canada Secretariat

Authored by: bryan.willey@cds-snc.ca Project: Notify An easy and efficient system that helps government departments send notifications, such as email, text messages or letters, to people who use government services.

-- Automated submit by PRB0t

+61 -0

0 comment

1 changed file

canada-bot

pr closed time in 11 days

issue commentcanada-ca/open-source-logiciel-libre

Link from pages to the repository

Not sure about that one works with the canada.ca publishing, but I was more thinking of doing the reverse with a banner on this site pointing to the approved one. Doesn't mean both can't happen though

gcharest

comment created time in 12 days

push eventcanada-ca/design-system-systeme-conception

Nick Schonning

commit sha 0d737d8612d2668b2677036581887bda5b02e2be

fix: try setting "staticDistDir"

view details

push time in 12 days

push eventcanada-ca/design-system-systeme-conception

Nick Schonning

commit sha 7d673517dadc7ab5126adb2d88bb10e0f903f7d2

chore: Add Lighthouse-CI travis steps

view details

push time in 12 days

push eventnschonni/design-system-systeme-conception

Borges-Porteous

commit sha 01a9be981b0db4dec1111d108b49f71d516bf7c5

updates based on feedback and iterations on the contact and checkbox patterns

view details

Borges-Porteous

commit sha d9fcf89da9044ba9aa88de7be9b2004748f78aeb

hours in local time

view details

Borges-Porteous

commit sha afd8fb04964aa93e4be133fc56572056942e7b76

by mail stuff

view details

Borges-Porteous

commit sha 72a274a4193bd50ee20e00c8921741ae19183814

intropiece to decide which contact block pattern to use

view details

Borges-Porteous

commit sha 60f429aff49e690f7f53c49211622e1488169e83

Updates to descriptions for large vs small checkboxes

view details

Borges-Porteous

commit sha 79e5737d7b463a15c822a354c8e1044b83e89cba

Laura's edits

view details

Borges-Porteous

commit sha 2bd36b0ac58c6272830e4dd554b4f9856906d02e

updates to pattern demo and callout css

view details

Borges-Porteous

commit sha 353c2d2ac5d4fe7f1f9d90993a097ba8e177b560

replacing callout with pattern demo class

view details

Borges-Porteous

commit sha 3398fdadfc16b686063442d941dc4470b9a4d09e

jquery!

view details

Borges-Porteous

commit sha b4cb29bdc18f2bc6c45caf53a66c9c0cff6ca3bb

more jquery stuff

view details

Borges-Porteous

commit sha bc6535885e1366b93e9b227093c8bf4aa317c66e

updates to vertical sit pattern

view details

Borges-Porteous

commit sha f0a296b4b316dd15147123acc470500b56a0436c

updates for the service initiation documentation

view details

Jennifer Mealing

commit sha 4d709eb7f4a6e07ad4c2bb953e8e961b7fa47e02

update

view details

Jennifer Mealing

commit sha a396cee4fb375256a71fee7467dc40f734788b4c

Merge branch 'master' of https://github.com/canada-ca/design-system-systeme-conception

view details

Borges-Porteous

commit sha 505354a1400b30a388fd2ed247a6f521241fd12b

checkbox updates

view details

Jennifer Mealing

commit sha 666190580c3663ffb6f0a92b7883b7d1e8b18651

update to gc-form

view details

Jennifer Mealing

commit sha dc84403dbbb292f6fc02c4aab2b56aba9048bcec

adjust font size - convert to sass

view details

Borges-Porteous

commit sha 046536270c612829a58ed24f999cb53f410570fa

separated

view details

quidampepin

commit sha d2e6735b4daa4ed50b490fbca2ba14d64e4568d6

Draft of expandable collapsible

view details

quidampepin

commit sha 447cd55e194c1e10a91c48528b2a3b64775cc3bd

Update collapsible-content.html

view details

push time in 12 days

push eventcanada-ca/design-system-systeme-conception

Nick Schonning

commit sha 41d6126f183d82caf5df6b8eec4b071a54b6139b

chore: Add Lighthouse-CI config

view details

push time in 12 days

create barnchcanada-ca/design-system-systeme-conception

branch : lighthouse-ci

created branch time in 12 days

issue commentmozilla/standards-positions

Default Accessibility Semantics for Custom Elements

OK, thanks for clarifying @annevk

alice

comment created time in 13 days

pull request commentnodejs/nodejs.dev

fix: remark-lint minor suppressed rules

@MylesBorins do you want me to split this up?

nschonni

comment created time in 13 days

delete branch nodejs/nodejs.dev

delete branch : aymen94-patch-3

delete time in 13 days

Pull request review commentgctools-outilsgc/gcconnex

Email analytics

 function phpmailer_send($to, $to_name, $subject, $body, array $bcc = NULL, $html 		$errType = "custom"; 		phpmailer_logging($errMess, $errStack, 'PHPMailer', $errType); 	}-+	count_emails(); 	return $return; } +function count_emails(){

This is vendor'd in now, but is there a way to do this without modifying the 3rd party code through hooks instead?

Phanoix

comment created time in 13 days

Pull request review commentgctools-outilsgc/gcconnex

Email analytics

 function minor_save_hook_handler($hook, $type, $value, $params) {     return true; } +function count_email_types( $type ){+	try {+		$m = new Memcached();+		$m->setOption(Memcached::OPT_BINARY_PROTOCOL, true);+		$m->addServer('localhost', 11211);

should these be config variables?

Phanoix

comment created time in 13 days

push eventnodejs/nodejs.org

pan93412

commit sha 04e85bc527e7d5cbe24c34fe47d7b5fd2ca8b63a

l10n(zh_TW): update base Signed-off-by: pan93412 <pan93412@gmail.com>

view details

pan93412

commit sha 36ef74810d10831c02eb0927be32972cf7a5e781

l10n(zh_TW): update & improve translations Signed-off-by: pan93412 <pan93412@gmail.com>

view details

pan93412

commit sha f9dfab144a93b283371c90bdca3e79bce65f5f75

fix(zh_TW): remove untranslated contents

view details

pan93412

commit sha ecc32a2f37a2319ff10c0bfee53821586d71480a

fix(zh_TW): fix the mistakes mentioned by reviewers

view details

pan93412

commit sha 9ec7d8a3753b12243d6e4cc0925bb9d679da5eee

fix(zh_TW): fix the mistakes mentioned by reviewers

view details

push time in 13 days

PR merged nodejs/nodejs.org

Reviewers
zh-tw: update & improve translations

Also updated the base.

Signed-off-by: pan93412 pan93412@gmail.com

+86 -61

5 comments

9 changed files

pan93412

pr closed time in 13 days

push eventtw-translation/nodejs.org

Tobias Nießen

commit sha 00b901e86ef00e3a2a7d705207d078923ef0f2e4

Revert "feat: minify HTML on build (#2537)" This reverts commit 0cc3648df2741afbfdc29e43247e3dc0e6e44b66. Refs: https://github.com/nodejs/nodejs.org/pull/2537

view details

Nick Schonning

commit sha 06c8d6dbb2b9990ed2a9ee5bd7446c1d517dc379

Merge branch 'master' into zh-tw-translations-191121

view details

push time in 13 days

issue closedsass/node-sass

4 new vulnerabilities detected by Snyk

The following CVEs have been made public by Snyk: https://snyk.io/vuln/SNYK-JS-NODESASS-535497 https://snyk.io/vuln/SNYK-JS-NODESASS-535498 https://snyk.io/vuln/SNYK-JS-NODESASS-535500 https://snyk.io/vuln/SNYK-JS-NODESASS-535502

closed time in 13 days

andymsuk

issue commentsass/node-sass

4 new vulnerabilities detected by Snyk

Follow #2685 for when libsass will be updated

andymsuk

comment created time in 13 days

issue commentMicrosoftDocs/Contribute

Migration cannot be used with version 6.3 of EntityFramework

Think this is probably something for https://github.com/aspnet/EntityFramework6 rather than Contribute

CeciAc

comment created time in 13 days

issue commentAzure/azure-rest-api-specs

NatGateway CreateOrUpdate defines object response for 202

I believe the "schema" value should be removed. I'm guessing there is better internal guidance though on how 202s are represented.

nschonni

comment created time in 13 days

issue closedsass/node-sass

node-sass 4.13 incompatible with latest node 12 version (Utf8Value)

Overview

Using latest version of node-sass with latest version of node 12 fail with this error:

/Users/jeandat/.node-gyp/12.13.0/include/node/v8.h:3046:5: note: candidate constructor not viable: no known conversion from 'v8::Local<v8::Value>' to 'const v8::String::Utf8Value' for 1st argument
    Utf8Value(const Utf8Value&) = delete;
    ^
/Users/jeandat/.node-gyp/12.13.0/include/node/v8.h:3039:5: note: candidate constructor not viable: requires 2 arguments, but 1 was provided
    Utf8Value(Isolate* isolate, Local<v8::Value> obj);
    ^
1 error generated.

Full error log

Trace

Context

❯ npm -v
6.12.0

But I'm using yarn:
❯ yarn -v
1.19.2

❯ node -v
v12.13.0

❯ node -p process.versions
{
  node: '12.13.0',
  v8: '7.7.299.13-node.12',
  uv: '1.32.0',
  zlib: '1.2.11',
  brotli: '1.0.7',
  ares: '1.15.0',
  modules: '72',
  nghttp2: '1.39.2',
  napi: '5',
  llhttp: '1.1.4',
  http_parser: '2.8.0',
  openssl: '1.1.1d',
  cldr: '35.1',
  icu: '64.2',
  tz: '2019a',
  unicode: '12.1'
}

❯ node -p process.platform
darwin

❯ node -p process.arch
x64

❯ node -p "require('node-sass').info"
node-sass       4.13.0  (Wrapper)       [JavaScript]
libsass         3.5.4   (Sass Compiler) [C/C++]

❯ npm ls node-sass
livesp-front@3.11.2 
├─┬ @angular-devkit/build-angular@0.13.0
│ └── UNMET OPTIONAL DEPENDENCY node-sass@4.11.0
└── node-sass@4.13.0 

❯ yarn list --pattern node-sass
yarn list v1.19.2
├─ @angular-devkit/build-angular@0.13.0
│  └─ node-sass@4.11.0
└─ node-sass@4.13.0

closed time in 14 days

jeandat

issue commentsass/node-sass

node-sass 4.13 incompatible with latest node 12 version (Utf8Value)

We actually build and test with this combination in CI. It's likely that you're running into uses somewhere with the combination of Yarn and NVM handling native modules at all, rather than anything particularly with node-sass. the errro line is coming from core Node headers

jeandat

comment created time in 14 days

issue closedsass/node-sass

High severity reports by Snyk

NULL Pointer Dereference

Vulnerable module: node-sass
Introduced through: node-sass@4.13.0

Detailed paths

Introduced through: node-sass@4.13.0

Overview

node-sass is a Node.js bindings to libsass.

Affected versions of this package are vulnerable to NULL Pointer Dereference. An issue was discovered in LibSass through 3.5.4. A NULL pointer dereference was found in the function Sass::Functions::selector_append which could be leveraged by an attacker to cause a denial of service (application crash) or possibly have unspecified other impact. node-sass is affected by this vulnerability due to its bundled usage of libsass. <hr> Use After Free

Vulnerable module: node-sass
Introduced through: node-sass@4.13.0

Detailed paths

Introduced through: node-sass@4.13.0

Overview

node-sass is a Node.js bindings to libsass.

Affected versions of this package are vulnerable to Use After Free. A use-after-free vulnerability exists in handle_error() in sass_context.cpp in LibSass 3.4.x and 3.5.x through 3.5.4 that could be leveraged to cause a denial of service (application crash) or possibly unspecified other impact. node-sass is affected by this vulnerability due to its usage of libsass.

closed time in 15 days

w3bdesign

issue commentsass/node-sass

High severity reports by Snyk

Follow #2685

w3bdesign

comment created time in 15 days

issue commentmozilla/standards-positions

Default Accessibility Semantics for Custom Elements

Just making the comment here instead of the PR, but I think this should be important given discussions like https://twitter.com/sarahmei/status/1198069119897047041 which have people avoiding aspects of web components given accessibility gotchas

alice

comment created time in 15 days

pull request commentnodejs/nodejs.org

ru: translation of timers-in-node.md

Ping @nodejs/nodejs-ru

arturovt

comment created time in 15 days

pull request commentnodejs/nodejs.org

Turkish language localization minor update

Ping @nodejs/nodejs-tr

enverarslan

comment created time in 15 days

issue closedsass/node-sass

node-sass has HIGH vuln as long as it relies on libsass <3.6

You might wanna update your code as no enterprise security team will allow a build to go to production with node-sass as long as it relies on libsass 3.54.

closed time in 15 days

DonkeyAfterDark
more