profile
viewpoint
Jeremy Rose nornagon @tinyspeck San Francisco, CA https://nornagon.net I work on @electron, and make games sometimes.

apple-opensource-mirror/adv_cmds 0

Mirror of Apple's open source release of adv_cmds

apple-opensource-mirror/amavisd 0

Mirror of Apple's open source release of amavisd

apple-opensource-mirror/am_utils 0

Mirror of Apple's open source release of am_utils

apple-opensource-mirror/apache 0

Mirror of Apple's open source release of apache

apple-opensource-mirror/apache1 0

Mirror of Apple's open source release of apache1

apple-opensource-mirror/apache2 0

Mirror of Apple's open source release of apache2

apple-opensource-mirror/apache_mod_bonjour 0

Mirror of Apple's open source release of apache_mod_bonjour

apple-opensource-mirror/apache_mod_bw 0

Mirror of Apple's open source release of apache_mod_bw

apple-opensource-mirror/apache_mod_dav 0

Mirror of Apple's open source release of apache_mod_dav

apple-opensource-mirror/apache_mod_encoding2 0

Mirror of Apple's open source release of apache_mod_encoding2

issue openedelectron/electron

system-context-menu prevents the default behavior from being invalid

<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can. -->

Preflight Checklist

<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->

  • [x] I have read the Contributing Guidelines for this project.
  • [x] I agree to follow the Code of Conduct that this project adheres to.
  • [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • 11.0.3
  • Operating System:
    • Windows 10 (1803)
  • Last Known Working Electron version:
    • <!-- (if applicable) e.g. 3.1.0 -->

Expected Behavior

Prevent the default menu context from being displayed

Actual Behavior

<!-- A clear and concise description of what actually happened. --> image

To Reproduce

<!-- Your best chance of getting this bug looked at quickly is to provide an example. -->

  • Set frame to true
  • Set -webkit-app-region: drag
  • Finally write the following code
win.on('system-context-menu', e => {
    e.preventDefault()
})

<!-- For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report. -->

<!-- If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes. -->

<!-- If you provide a URL, please list the commands required to clone/setup/run your repo e.g.

$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .

-->

Screenshots

<!-- If applicable, add screenshots to help explain your problem. --> image

Additional Information

<!-- Add any other context about the problem here. -->

created time in 34 minutes

issue commentelectron/electron

%APPDATA%/project-name folder still being created after setting userData path

@jkleinsc Hey, I'm experiencing the same issue.

nolawnchairs

comment created time in 2 hours

pull request commentelectron/electron

fix: `nativeTheme.themeSource = 'dark'` on windows

thank you

ckerr

comment created time in 2 hours

pull request commentelectron/electron

feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification

Yes, this has been discussed on this PR already.

tristan957

comment created time in 4 hours

pull request commentelectron/electron

feat: Use GtkFileChooserNative to support the XDG Desktop Portal specification

So I finished what I talked about in my previous comment just now, but I am keeping it local for now. I think that solution depends on how Electron is built? What if Electron is built on a platform with GTK >= 3.20 but distributed to platforms with GTK < 3.20?

Is this use case realistic at all? Even the oldstable versions of Ubuntu LTS (18.04) and Debian (9) have Gtk 3.22 (source). You would have to use Ubuntu 16.04 LTS, 14.04 LTS, Debian 7 or 8. This is really really old stuff.

tristan957

comment created time in 5 hours

issue commentelectron/electron

mainWindow.webContents.openDevTools() throws error when loading new page

I get this when my app starts. Any ideas? [33657:1127/210324.107937:ERROR:CONSOLE(63)] "console.assert", source: devtools://devtools/bundled/sdk/CSSModel.js (63) [33657:1127/210324.107989:ERROR:CONSOLE(63)] "console.assert", source: devtools://devtools/bundled/sdk/CSSModel.js (63) [33657:1127/210324.108040:ERROR:CONSOLE(63)] "console.assert", source: devtools://devtools/bundled/sdk/CSSModel.js (63) [33657:1127/210324.108092:ERROR:CONSOLE(63)] "console.assert", source: devtools://devtools/bundled/sdk/CSSModel.js (63) [33657:1127/210324.111692:ERROR:CONSOLE(63)] "console.assert", source: devtools://devtools/bundled/sdk/CSSModel.js (63) [33657:1127/210324.111780:ERROR:CONSOLE(63)] "console.assert", source: devtools://devtools/bundled/sdk/CSSModel.js (63) [33657:1127/210324.111837:ERROR:CONSOLE(63)] "console.assert", source: devtools://devtools/bundled/sdk/CSSModel.js (63)

electron v8.2.0 node v14.4.0

biomade

comment created time in 5 hours

issue commentelectron/electron

Draggable region behavior varies between two Windows 7 machines

Actually, I guess no matter where I set the style to be draggable, no matter how high in the hierarchy, I continue to see the issue. Maybe an issue with the calculations of the drag region coordinates? I'm not sure what's going on behind the scenes there besides what I've gleaned from some posts from @MarshallOfSound.

Slapbox

comment created time in 6 hours

issue commentelectron/electron

Draggable region behavior varies between two Windows 7 machines

Also, I just remembered that the underlying contentEditable that the mouse events go through to is itself supposed to be a drag region. The property is set, but has no effect in this particular scenario.

Slapbox

comment created time in 6 hours

issue openedelectron/electron

Draggable region behavior varies between two Windows 7 machines

Preflight Checklist

  • [x] I have read the Contributing Guidelines for this project.
  • [x] I agree to follow the Code of Conduct that this project adheres to.
  • [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version: 8.5.3
  • Operating System: Windows 7 & Windows 10
  • Last Known Working Electron version: Unknown

More specifically:

Machine Status
Physical Windows 7 machine Works
Physical Windows 10 machine TBD
Windows 7 VMware machine Bugged
Windows 10 VMware machine Bugged

Expected Behavior

Draggable region behavior should be uniform no matter what machine the code runs on.

Actual Behavior

Scrolling a list so that its contents appear beneath the drag region leads to a third element that is beneath both of the others becoming the element that receives mouse events.

You can see in this video that the first context menu clicks occur on a draggable region, but after scrolling the clicks go straight through it.

https://recordit.co/THHvufn6MY

Now for the strangest part, which is that it works 100% fine on my main machine when packaged up, but on the Windows 7 development machine I use I'm plagued by this issue in both development and the packaged application.

To Reproduce

Wish I knew. Any ideas about the cause? I'd be happy to investigate further but could use some insight into what might be going on behind the scenes.

Additional Information

I'm pretty familiar with the quirks and limitations of drag regions and I feel pretty confident that this weird click-through behavior is not intended - although I can't know what I don't know.

I haven't encountered any other discrepancies in behavior like this between physical and virtual machines, which makes me think the fact it's a VM isn't likely to be the cause.

created time in 6 hours

issue commentelectron/electron

opening developer tools first time messes with background color

This happens with my app too...

Before opening devtools(It's a base starter app): image

After opening devtools(as the author said, it only happens in the first time opening it): image

yilmazdurmaz

comment created time in 9 hours

push eventelectron/electron

Milan Burda

commit sha 7e8e99c8aade3cd9030ec5edd4a51b8eac983dbd

chore: remove deprecated shell.moveItemToTrash()

view details

push time in 9 hours

issue commentelectron/electron

React DevTools and Redux DevTools tabs sometimes not appearing Electron@9.0.0

@happycoder97 I've tried your workaround and several others in the thread before posting already, none of them work for us. Thanks for the recommendation though!

mashafomasha

comment created time in 10 hours

issue openedelectron/electron

opening developer tools first time messes with background color

<!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can. -->

Preflight Checklist

<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->

  • [x] I have read the Contributing Guidelines for this project.
  • [x] I agree to follow the Code of Conduct that this project adheres to.
  • [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version: <!-- (output of node_modules/.bin/electron --version) e.g. 4.0.3 -->
    • v11.0.0-beta.20, v11.0.2, v11.0.3 and v12.0.0-beta.3
  • Operating System: <!-- (Platform and Version) e.g. macOS 10.13.6 / Windows 10 (1803) / Ubuntu 18.04 x64 -->
    • Windows 10 (1909)
  • Last Known Working Electron version: <!-- (if applicable) e.g. 3.1.0 -->
    • haven't tried below v11.0.0-beta.20, but I have VS-Code 1.47.1 that uses an old v7.3.2 that doesn't seem to have this problem

Expected Behavior

<!-- A clear and concise description of what you expected to happen. --> Opening developer tools should not break the look of the page other than resizing mechanism if responsive

Actual Behavior

<!-- A clear and concise description of what actually happened. --> Opening developer tools the first time an app starts breaks the background color, to dark grey as menu bar and dev tools have. this happens only the first time and closing dev tools then reopening wont have the same effect.

To Reproduce

<!-- Your best chance of getting this bug looked at quickly is to provide an example. --> clone, install, run "https://github.com/electron/electron-quick-start" , then open developer tools.

<!-- For bugs that can be encapsulated in a small experiment, you can use Electron Fiddle (https://github.com/electron/fiddle) to publish your example to a GitHub Gist and link it your bug report. -->

<!-- If Fiddle is insufficient to produce an example, please provide an example REPOSITORY that can be cloned and run. You can fork electron-quick-start (https://github.com/electron/electron-quick-start) and include a link to the branch with your changes. -->

<!-- If you provide a URL, please list the commands required to clone/setup/run your repo e.g.

$ git clone $YOUR_URL -b $BRANCH
$ npm install
$ npm start || electron .

-->

Screenshots

<!-- If applicable, add screenshots to help explain your problem. -->

Additional Information

<!-- Add any other context about the problem here. -->

I noticed this first when using Fiddle and even posted in its issues https://github.com/electron/fiddle/issues/536 . Then tried it with electron-quick-start as suggested there to see the problem actually is with electron itself.

created time in 10 hours

push eventelectron/electron

Milan Burda

commit sha d566bbca2a5b4b99ccb4c350b08d868d5559d929

chore: remove deprecated shell.moveItemToTrash()

view details

push time in 11 hours

PR opened electron/electron

chore: remove deprecated shell.moveItemToTrash()

Description of Change

This is already documented as removed in Electron 13

Checklist

Release Notes

Notes: Removed deprecated shell.moveItemToTrash().

+0 -93

0 comment

8 changed files

pr created time in 11 hours

create barnchelectron/electron

branch : miniak/deprecated-trash

created branch time in 11 hours

startednornagon/saxi

started time in 11 hours

push eventelectron/electron

Milan Burda

commit sha ea18b8c4c5bd56504468209d689f511dffffb267

chore: remove deprecated extension APIs

view details

push time in 11 hours

push eventelectron/electron

Milan Burda

commit sha cc43869af5bc34dac1c1eca8fe2b701a2cd5d85f

docs: BrowserWindow extension APIs are deprecated in Electron 9

view details

push time in 11 hours

push eventelectron/electron

Jeremy Rose

commit sha ba629e31273470c4199fd9fe5928a32360091d35

fix: use-after-free in ElectronBrowserContext during shutdown (#26680)

view details

Electron Bot

commit sha d0cf16263e65dda09ccc3e2c304e6dce0c936968

Bump v13.0.0-nightly.20201126

view details

Milan Burda

commit sha 022bafc485986b0a00625bc8976a54801145a5bc

chore: remove deprecated crashReporter APIs (#26695)

view details

Electron Bot

commit sha 8311ea1a361edb010b7d335cbed692679018df32

Bump v13.0.0-nightly.20201127

view details

Milan Burda

commit sha 6787f919b020873b7a4aa7e2166ee071abdf7c4b

chore: remove deprecated extension APIs

view details

push time in 11 hours

push eventelectron/electron

Milan Burda

commit sha 19a5ce26897aef373b045e93ff0a8172c9303815

docs: BrowserWindow extension APIs are deprecated in Electron 9

view details

push time in 11 hours

issue commentelectron/electron

Electron apps freeze on linux 5.x kernel

I am having the same issue. VSCode and Discord both freeze unless I turn off gpu acceleration on both.

NAME="Ubuntu" VERSION="20.04.1 LTS (Focal Fossa)" ID=ubuntu ID_LIKE=debian PRETTY_NAME="Ubuntu 20.04.1 LTS" VERSION_ID="20.04" HOME_URL="https://www.ubuntu.com/" SUPPORT_URL="https://help.ubuntu.com/" BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/" PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy" VERSION_CODENAME=focal UBUNTU_CODENAME=focal 00:00.0 Host bridge: Intel Corporation 4th Gen Core Processor DRAM Controller (rev 06) 00:01.0 PCI bridge: Intel Corporation Xeon E3-1200 v3/4th Gen Core Processor PCI Express x16 Controller (rev 06) 00:02.0 VGA compatible controller: Intel Corporation Xeon E3-1200 v3/4th Gen Core Processor Integrated Graphics Controller (rev 06) 00:03.0 Audio device: Intel Corporation Xeon E3-1200 v3/4th Gen Core Processor HD Audio Controller (rev 06) 00:14.0 USB controller: Intel Corporation 9 Series Chipset Family USB xHCI Controller 00:16.0 Communication controller: Intel Corporation 9 Series Chipset Family ME Interface #1 00:1a.0 USB controller: Intel Corporation 9 Series Chipset Family USB EHCI Controller #2 00:1b.0 Audio device: Intel Corporation 9 Series Chipset Family HD Audio Controller 00:1c.0 PCI bridge: Intel Corporation 9 Series Chipset Family PCI Express Root Port 1 (rev d0) 00:1c.2 PCI bridge: Intel Corporation 9 Series Chipset Family PCI Express Root Port 3 (rev d0) 00:1c.3 PCI bridge: Intel Corporation 82801 PCI Bridge (rev d0) 00:1d.0 USB controller: Intel Corporation 9 Series Chipset Family USB EHCI Controller #1 00:1f.0 ISA bridge: Intel Corporation Z97 Chipset LPC Controller 00:1f.2 SATA controller: Intel Corporation 9 Series Chipset Family SATA Controller [AHCI Mode] 00:1f.3 SMBus: Intel Corporation 9 Series Chipset Family SMBus Controller 01:00.0 VGA compatible controller: NVIDIA Corporation GF110 [GeForce GTX 580] (rev a1) 01:00.1 Audio device: NVIDIA Corporation GF110 High Definition Audio Controller (rev a1) 03:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller (rev 06) 04:00.0 PCI bridge: Intel Corporation 82801 PCI Bridge (rev 41) 05:00.0 Multimedia audio controller: Creative Labs EMU20k1 [Sound Blaster X-Fi Series]

vbatts

comment created time in 11 hours

PR opened electron/electron

docs: BrowserWindow extension APIs are deprecated in Electron 9

Description of Change

Follow-up to #21812

Checklist

  • [x] PR description included and stakeholders cc'd
  • [x] npm test passes
  • [x] relevant documentation is changed or added

Release Notes

Notes: no-notes

+26 -0

0 comment

1 changed file

pr created time in 11 hours

create barnchelectron/electron

branch : miniak/deprecate-extension-apis

created branch time in 11 hours

pull request commentelectron/electron

chore: bump chromium to 87.0.4280.67 (11-x-y)

There is a problem with Chrome v87. While v87 hasn't disabled Flash, it has made it so that Flashplayer can no longer access microphone devices. It can enumerate the audio inputs, but no sound detected. Webcams still work fine, so I think it's a bug.

My electron app uses the Flash plugin, and it is broken as well when I update to Electron 11.0.0. So looks like I will have to stay on 10.1.6.

Should I file a Chromium bug on broken Flashplayer?

electron-bot

comment created time in 13 hours

issue openedelectron/electron

macOS: `logname` can be incorrect depending on how one launches an electron app

Preflight Checklist

  • [x] I have read the Contributing Guidelines for this project.
  • [x] I agree to follow the Code of Conduct that this project adheres to.
  • [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • Electron: 9.3.3
  • Operating System:
    • macOS 11.0.1 (but also happened on 10.15)
  • Last Known Working Electron version:
    • Unknown

Bug Description

I'm hopping over from over from this VSCode issue where I've noticed this behavior:

Depending on how you launched VSCode, the output of logname in the built-in terminal will be different:

  1. VSCode is launched from the CLI (using code): logname will yield your username (cfr. whoami).
  2. VSCode is launched from the macOS Dock / Spotlight / Finder: logname will yield root.

I've come to know that Vercel's Hyper also behaves like this.

Since both apps use Electron under the hood, I'm thinking this is a Electron issue …

To Reproduce / Actual Behavior

  1. Build an Electron app that features a Terminal (😅)
  2. Place this script on disk somewhere
    echo "\$USER: $USER"
    echo "logname: $(logname)"
    echo "whoami: $(whoami)"
    
  3. Launch your app from (1) from the CLI, to see the correct behavior:
    $USER: bramus
    logname: bramus
    whoami: bramus
    
  4. Launch your app from (1) from the macOS Dock / Spotlight / Finder, to see the wrong behavior:
    $USER: bramus
    logname: root
    whoami: bramus
    

Expected Behavior

I expect the output for logname to yield the same output as $USER and whoami, independent of how I launched my Electron based app.

Additional Information

  • VSCode Issue: https://github.com/microsoft/vscode/issues/96463
  • Hyper Issue: https://github.com/vercel/hyper/issues/3762

created time in 15 hours

issue openedelectron/electron

Top zone of the Browser window doesn't work.

Hi guys, I have spent a couple of days and didn't find a solution on how to fix my problem, so decided to report a bug. Issue: All events (js, css) don't work on the top of the window.

Description: if you move the mouse from the top to the bottom through the window everything works well as expected, but if to move the mouse from the bottom to the top through the window the events will not work on the last 5-8px of the window. For example, if the top item on the page has an HTML title attribute it will still be visible after the mouse leaves the window zone. It seems like a transparent part of the top panel is present and it affects on everything in this zone.

My code is the simplest blank app:

// main.js
const { app, BrowserWindow } = require('electron')
function createWindow() {
   // Required frame and resizable options to reproduce this behavior
    const win = new BrowserWindow({
        frame: false,
        resizable: false,
        webPreferences: {
            nodeIntegration: true,
        },
    })

    win.loadFile('index.html')
}
app.whenReady().then(() => {
    createWindow()
    app.on('activate', function () {
        if (BrowserWindow.getAllWindows().length === 0) createWindow()
    })
})
app.on('window-all-closed', function () {
    if (process.platform !== 'darwin') app.quit()
})
// index.html
<!DOCTYPE html>
<html>
    <head>
        <title>Electron test</title>
        <style>
            html, body {
                margin: 0;
                padding: 0;
            }
            div {
                background-color: blue;
            }
            div:hover {
                background-color: #fff;
            }
        </style>
    </head>
    <body>
        <div title="Some title">Some element</div>
    </body>
</html>
// package.json
{
  "name": "blank",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "start": "electron ."
  },
  "author": "Author",
  "license": "ISC",
  "devDependencies": {
    "electron": "^11.0.3"
  }
}

Anything I can do for you, let me know.

created time in 17 hours

created tagelectron/electron

tagv13.0.0-nightly.20201127

:electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS

created time in 17 hours

push eventelectron/electron

Electron Bot

commit sha 8311ea1a361edb010b7d335cbed692679018df32

Bump v13.0.0-nightly.20201127

view details

push time in 17 hours

more