profile
viewpoint
Xi Ge nkcsgexi @apple Cupertino, CA, USA https://twitter.com/xge_apple Swift Compiler at the fruit company 

nkcsgexi/GhostFactor2 2

ghostfactor2

nkcsgexi/swift 1

The Swift Programming Language

nkcsgexi/swift-lldb 1

This is the version of LLDB that supports the Swift programming language & REPL.

nkcsgexi/ghostfactor 0

A novel refactoring tool for visual studio

nkcsgexi/ghostfactor1 0

A novel refactoring tool for visual studio

PullRequestReviewEvent

push eventapple/swift-driver

Xi Ge

commit sha 9a2cbe58c7da6a3556ce94c353e69251660b6e48

Infer .swiftdoc and .swiftsourceinfo paths from .swiftmodule path in a given outputFileMap This allows the -merge-module action to find and import those partial entities. rdar://70494813

view details

Xi Ge

commit sha 84b7035dae04ec154f514e1d52ef27d27a93c8de

Merge pull request #322 from nkcsgexi/70494813-2 Infer .swiftdoc and .swiftsourceinfo paths from .swiftmodule path in a given outputFileMap

view details

push time in a day

PR merged apple/swift-driver

Reviewers
Infer .swiftdoc and .swiftsourceinfo paths from .swiftmodule path in a given outputFileMap

This allows the -merge-module action to find and import those partial entities.

rdar://70494813

+63 -6

3 comments

4 changed files

nkcsgexi

pr closed time in a day

Pull request review commentapple/swift-driver

Infer .swiftdoc and .swiftsourceinfo paths from .swiftmodule path in a given outputFileMap

 public struct OutputFileMap: Hashable, Codable {   }    public func existingOutput(inputFile: VirtualPath, outputType: FileType) -> VirtualPath? {-    entries[inputFile]?[outputType]+    switch outputType {+    case .swiftDocumentation, .swiftSourceInfoFile:+      // If the output map has specific entry for these entities, use that.+      if let path = entries[inputFile]?[outputType] {+        return path+      }

Sounds good, Fixed.

nkcsgexi

comment created time in a day

PullRequestReviewEvent

push eventnkcsgexi/swift-driver

Xi Ge

commit sha 9a2cbe58c7da6a3556ce94c353e69251660b6e48

Infer .swiftdoc and .swiftsourceinfo paths from .swiftmodule path in a given outputFileMap This allows the -merge-module action to find and import those partial entities. rdar://70494813

view details

push time in a day

push eventnkcsgexi/swift-driver

Xi Ge

commit sha d7cdde20077c6eb6acecdeadd7f9c5db0869da83

Infer .swiftdoc and .swiftsourceinfo paths from .swiftmodule path in a given outputFileMap This allows the -merge-module action to find and import those partial entities. rdar://70494813

view details

push time in a day

PR opened apple/swift-driver

Infer .swiftdoc and .swiftsourceinfo paths from .swiftmodule path in a given outputFileMap

This allows the -merge-module action to find and import those partial entities.

rdar://70494813

+63 -5

0 comment

4 changed files

pr created time in a day

create barnchnkcsgexi/swift-driver

branch : 70494813-2

created branch time in a day

create barnchnkcsgexi/swift-driver

branch : 70494813

created branch time in a day

PullRequestReviewEvent

push eventapple/swift-driver

Xi Ge

commit sha 49d670ebacd32e391ef8912600a4d22f7eda9fd7

CompileJob should take precompiled briding header as input rdar://70460548

view details

Xi Ge

commit sha ffcea91422e4d341b725b93157f934de93a84081

Merge pull request #321 from nkcsgexi/70460548 CompileJob should take precompiled bridging header as input

view details

push time in 2 days

PR merged apple/swift-driver

Reviewers
CompileJob should take precompiled bridging header as input

rdar://70460548

+23 -8

2 comments

2 changed files

nkcsgexi

pr closed time in 2 days

pull request commentapple/swift-driver

CompileJob should take precompiled bridging header as input

@swift-ci please test

nkcsgexi

comment created time in 2 days

push eventnkcsgexi/swift-driver

Xi Ge

commit sha 49d670ebacd32e391ef8912600a4d22f7eda9fd7

CompileJob should take precompiled briding header as input rdar://70460548

view details

push time in 2 days

pull request commentapple/swift-driver

CompileJob should take precompiled bridging header as input

@swift-ci please test

nkcsgexi

comment created time in 2 days

PR opened apple/swift-driver

CompileJob should take precompiled bridging header as input

rdar://70460548

+15 -0

0 comment

2 changed files

pr created time in 2 days

create barnchnkcsgexi/swift-driver

branch : 70460548

created branch time in 2 days

PullRequestReviewEvent

push eventapple/swift-driver

Xi Ge

commit sha 87e18655a18f7e042ebb3c4c0d879b0e422a0724

BatchMode: log batch configurations when -driver-show-job-lifecycle is set This allows us to compare the output with that of the C++ driver

view details

Xi Ge

commit sha f6161b08071c89acc8f491d9da8f6f4833ccf96b

Merge pull request #319 from nkcsgexi/log-batch-config BatchMode: log batch configurations when -driver-show-job-lifecycle is set. NFC

view details

push time in 2 days

PR merged apple/swift-driver

Reviewers
BatchMode: log batch configurations when -driver-show-job-lifecycle is set. NFC

This allows us to compare the output with that of the C++ driver

+10 -0

1 comment

1 changed file

nkcsgexi

pr closed time in 2 days

pull request commentapple/swift-driver

BatchMode: log batch configurations when -driver-show-job-lifecycle is set. NFC

@swift-ci please test

nkcsgexi

comment created time in 2 days

PR opened apple/swift-driver

BatchMode: log batch configurations when -driver-show-job-lifecycle is set. NFC

This allows us to compare the output with that of the C++ driver

+10 -0

0 comment

1 changed file

pr created time in 2 days

create barnchnkcsgexi/swift-driver

branch : log-batch-config

created branch time in 2 days

push eventapple/swift-driver

Xi Ge

commit sha 9b0b02f019744f7fc34f67629d9c8f2da68d6fa1

Properly set up jobs when -lto is set rdar://70414259

view details

Xi Ge

commit sha 04175bd3d5549c5cbe51254a2d5858e919f4fe0b

Merge pull request #317 from nkcsgexi/70414259 Properly set up jobs when -lto is set

view details

push time in 3 days

PR merged apple/swift-driver

Reviewers
Properly set up jobs when -lto is set

rdar://70414259

+33 -2

3 comments

4 changed files

nkcsgexi

pr closed time in 3 days

pull request commentapple/swift-driver

Properly set up jobs when -lto is set

@swift-ci please test

nkcsgexi

comment created time in 3 days

Pull request review commentapple/swift-driver

Properly set up jobs when -lto is set

 extension Driver {       return (linkerOutputType == nil)     case .swiftModule:       return compilerMode.isSingleCompilation && moduleOutputInfo.output?.isTopLevel ?? false-    case .llvmBitcode:-      return compilerOutputType == type

I've fixed in the new iteration. Mind taking another look?

nkcsgexi

comment created time in 3 days

PullRequestReviewEvent

push eventnkcsgexi/swift-driver

Xi Ge

commit sha 9b0b02f019744f7fc34f67629d9c8f2da68d6fa1

Properly set up jobs when -lto is set rdar://70414259

view details

push time in 3 days

pull request commentapple/swift-driver

Properly set up jobs when -lto is set

@swift-ci please test

nkcsgexi

comment created time in 4 days

push eventnkcsgexi/swift-driver

Xi Ge

commit sha da441311df8ffdb18949b9c7100de9f86c5fb218

Properly set up jobs when -lto is set rdar://70414259

view details

push time in 4 days

push eventnkcsgexi/swift

Xi Ge

commit sha 61a700d3c851bfeda9beae3a4a039f9bc1504137

drop Windows test for Driver/link-time-opt.swift

view details

push time in 4 days

pull request commentapple/swift-driver

Properly set up jobs when -lto is set

@swift-ci please test

nkcsgexi

comment created time in 4 days

PR opened apple/swift-driver

Properly set up jobs when -lto is set

rdar://70414259

+16 -3

0 comment

4 changed files

pr created time in 4 days

create barnchnkcsgexi/swift-driver

branch : 70414259

created branch time in 4 days

push eventnkcsgexi/swift

Xi Ge

commit sha 706425fb4ef31af6b1f148c3965d51a302725c1a

Fixing Driver/sanitizers.swift

view details

push time in 5 days

push eventapple/swift

Xi Ge

commit sha b9ade70c5d3f9973ba2358655912e970451b1d9b

swift_build_sdk_interfaces.py: create directory under dry-run mode Users may install a different version of SDK from the one found in the originally downloaded toolchain. Thus, we may need to create a new directory structure instead of using the original one in the toolchain, especially if the SDK under use has a different version number. rdar://67951012

view details

Xi Ge

commit sha 3029ce8970a5083ec86d4576964be488e20e2164

Merge pull request #34336 from nkcsgexi/67951012-2 swift_build_sdk_interfaces.py: create directory under dry-run mode

view details

push time in 5 days

PR merged apple/swift

swift_build_sdk_interfaces.py: create directory under dry-run mode

Users may install a different version of SDK from the one found in the originally downloaded toolchain. Thus, we may need to create a new directory structure instead of using the original one in the toolchain, especially if the SDK under use has a different version number.

rdar://67951012

+4 -6

3 comments

1 changed file

nkcsgexi

pr closed time in 5 days

PullRequestReviewEvent

pull request commentapple/swift

swift_build_sdk_interfaces.py: create directory under dry-run mode

@swift-ci please smoke test

nkcsgexi

comment created time in 5 days

pull request commentapple/swift

swift_build_sdk_interfaces.py: create directory under dry-run mode

@swift-ci please smoke test

nkcsgexi

comment created time in 5 days

pull request commentapple/swift

swift_build_sdk_interfaces.py: create directory under dry-run mode

@swift-ci please smoke test

nkcsgexi

comment created time in 5 days

PR opened apple/swift

swift_build_sdk_interfaces.py: create directory under dry-run mode

Users may install a different version of SDK from the one found in the originally downloaded toolchain. Thus, we may need to create a new directory structure instead of using the original one in the toolchain, especially if the SDK under use has a different version number.

rdar://67951012

+4 -6

0 comment

1 changed file

pr created time in 5 days

create barnchnkcsgexi/swift

branch : 67951012-2

created branch time in 5 days

push eventnkcsgexi/swift

Xi Ge

commit sha 54032ac3b3cd512a4e6d53d9cc7aab58861142cd

fix Driver/tools_directory.swift

view details

push time in 5 days

push eventapple/swift-driver

Xi Ge

commit sha 0a57a5e355123f5878e7ccfc3292831c89feedbc

Teach swift-driver to find tools in -tools-directory dir rdar://70381299

view details

Xi Ge

commit sha d4b91be51688e7ad369d90483006b0333070ca3e

Merge pull request #310 from nkcsgexi/70381299 Teach swift-driver to find tools in -tools-directory dir

view details

push time in 5 days

PR merged apple/swift-driver

Reviewers
Teach swift-driver to find tools in -tools-directory dir

rdar://70381299

+39 -4

2 comments

5 changed files

nkcsgexi

pr closed time in 5 days

pull request commentapple/swift-driver

Teach swift-driver to find tools in -tools-directory dir

@swift-ci please test

nkcsgexi

comment created time in 5 days

push eventnkcsgexi/swift-driver

Xi Ge

commit sha 0a57a5e355123f5878e7ccfc3292831c89feedbc

Teach swift-driver to find tools in -tools-directory dir rdar://70381299

view details

push time in 5 days

push eventnkcsgexi/swift-driver

Xi Ge

commit sha 5a6bb21141562d746c10a3699ba461ef1026a6b0

Teach swift-driver to find tools in -tools-directory dir rdar://70381299

view details

push time in 5 days

pull request commentapple/swift-driver

Teach swift-driver to find tools in -tools-directory dir

@swift-ci please test

nkcsgexi

comment created time in 5 days

PR opened apple/swift-driver

Reviewers
Teach swift-driver to find tools in -tools-directory dir

rdar://70381299

+41 -6

0 comment

6 changed files

pr created time in 5 days

create barnchnkcsgexi/swift-driver

branch : 70381299

created branch time in 5 days

push eventnkcsgexi/swift

Xi Ge

commit sha b9f6a7b9a4f2948155b7f8b5c1b83294db8486b8

fixing Driver/modulewrap.swift

view details

push time in 6 days

push eventnkcsgexi/swift

Xi Ge

commit sha 479c837e0d460e83fdc9a173a689b2f82674c2c6

XFail merge-module.swift

view details

push time in 6 days

push eventnkcsgexi/swift

Xi Ge

commit sha 92ad49836256e85ddc9c05b719aa7e4bc0153c48

Xfail Driver/cross_module.swift

view details

push time in 6 days

PullRequestReviewEvent

push eventapple/swift-driver

Xi Ge

commit sha 711278c8d0498de38722a6817dd0e22deb81e68a

Use working directory for top-level implicit module outputs

view details

Xi Ge

commit sha 24c11e5940e9eaec4cc9166ff4f0fcb928190774

Merge pull request #309 from nkcsgexi/working-dir-module Use working directory for top-level implicit module outputs

view details

push time in 6 days

pull request commentapple/swift-driver

Use working directory for top-level implicit module outputs

@swift-ci please test

nkcsgexi

comment created time in 6 days

push eventnkcsgexi/swift-driver

Xi Ge

commit sha 711278c8d0498de38722a6817dd0e22deb81e68a

Use working directory for top-level implicit module outputs

view details

push time in 6 days

push eventapple/swift

Xi Ge

commit sha 29093b15df24e98dda65cd51e26a7bd618a2d709

Driver: -L= belongs to the linker option group rdar://70300892

view details

Xi Ge

commit sha 43a795b0f9f84a0e3d593630c74782d702e57afe

Merge pull request #34309 from nkcsgexi/70300892 Driver: -L= belongs to the linker option group

view details

push time in 6 days

PR merged apple/swift

Driver: -L= belongs to the linker option group

rdar://70300892

+1 -1

3 comments

1 changed file

nkcsgexi

pr closed time in 6 days

create barnchnkcsgexi/swift-driver

branch : working-dir-module

created branch time in 6 days

pull request commentapple/swift

Driver: -L= belongs to the linker option group

@swift-ci Please smoke test Linux platform

nkcsgexi

comment created time in 7 days

push eventapple/swift-driver

Xi Ge

commit sha 5759f22c9d204f0b0fa96cd6ad75f3edbf03ea02

Honor working directory setting for implicit output paths rdar://70311690

view details

Xi Ge

commit sha bd86b019be512a8b7f422a557c0f823d10784612

Merge pull request #308 from nkcsgexi/70311690 Honor working directory setting for implicit output paths

view details

push time in 7 days

PR merged apple/swift-driver

Reviewers
Honor working directory setting for implicit output paths

rdar://70311690

+29 -7

2 comments

3 changed files

nkcsgexi

pr closed time in 7 days

pull request commentapple/swift-driver

Honor working directory setting for implicit output paths

Intermediate outputs should be fine without this change because they always end up in a temp directory IIUC. I'll merge this as-is and keep an eye on future moduleWrapJob failures because of it and fix that case by then if necessary.

nkcsgexi

comment created time in 7 days

pull request commentapple/swift

Driver: -L= belongs to the linker option group

@swift-ci Please smoke test Linux platform

nkcsgexi

comment created time in 7 days

pull request commentapple/swift-driver

Honor working directory setting for implicit output paths

@swift-ci please test

nkcsgexi

comment created time in 7 days

PR opened apple/swift-driver

Honor working directory setting for implicit output paths

rdar://70311690

+29 -7

0 comment

3 changed files

pr created time in 7 days

create barnchnkcsgexi/swift-driver

branch : 70311690

created branch time in 7 days

push eventapple/swift-driver

Xi Ge

commit sha 8654b0f533daebffa0f9a356c014b73e4cea79d9

Regenerate Options.swift after fixing the option group of -L= rdar://70300892

view details

Xi Ge

commit sha e5d4c4e4707bc17e20431712a2aa361b414e78fc

Merge pull request #307 from nkcsgexi/70300892 Regenerate Options.swift after fixing the option group of -L=

view details

push time in 7 days

PR merged apple/swift-driver

Reviewers
Regenerate Options.swift after fixing the option group of -L=

rdar://70300892

+35 -33

5 comments

3 changed files

nkcsgexi

pr closed time in 7 days

pull request commentapple/swift-driver

Regenerate Options.swift after fixing the option group of -L=

@swift-ci please test

nkcsgexi

comment created time in 7 days

push eventnkcsgexi/swift-driver

Xi Ge

commit sha 8654b0f533daebffa0f9a356c014b73e4cea79d9

Regenerate Options.swift after fixing the option group of -L= rdar://70300892

view details

push time in 7 days

pull request commentapple/swift-driver

Regenerate Options.swift after fixing the option group of -L=

@swift-ci please test

nkcsgexi

comment created time in 7 days

push eventnkcsgexi/swift-driver

Xi Ge

commit sha e5a4215e8f20498f76026a5c66edad70f4ba1988

Regenerate Options.swift after fixing the option group of -L= rdar://70300892

view details

push time in 7 days

pull request commentapple/swift-driver

Regenerate Options.swift after fixing the option group of -L=

@swift-ci please test

nkcsgexi

comment created time in 7 days

pull request commentapple/swift-driver

Regenerate Options.swift after fixing the option group of -L=

@DougGregor the C++ side driver has been fixed via https://github.com/apple/swift/pull/34309, and this PR has been repositioned to be regenerating Options.swift.

nkcsgexi

comment created time in 7 days

push eventnkcsgexi/swift-driver

Xi Ge

commit sha 82415e8156a2974f6827ee9d644bedaca2d76c83

Regenerate Options.swift after fixing the option group of -L= rdar://70300892

view details

push time in 7 days

pull request commentapple/swift

Driver: -L= belongs to the linker option group

@swift-ci please smoke test

nkcsgexi

comment created time in 7 days

PR opened apple/swift

Driver: -L= belongs to the linker option group

rdar://70300892

+1 -1

0 comment

1 changed file

pr created time in 7 days

push eventnkcsgexi/swift

Xi Ge

commit sha 29093b15df24e98dda65cd51e26a7bd618a2d709

Driver: -L= belongs to the linker option group rdar://70300892

view details

push time in 7 days

create barnchnkcsgexi/swift

branch : 70300892

created branch time in 7 days

push eventnkcsgexi/swift

Xi Ge

commit sha ece1cec959599a654b6804b44f13c77a3da5da0a

Driver/working-directory.swift

view details

push time in 7 days

pull request commentapple/swift-driver

LEQ belongs to the linkerOption group

@swift-ci please test

nkcsgexi

comment created time in 7 days

PR opened apple/swift-driver

LEQ belongs to the linkerOption group

rdar://70300892

+14 -1

0 comment

2 changed files

pr created time in 7 days

create barnchnkcsgexi/swift-driver

branch : 70300892

created branch time in 7 days

PullRequestReviewEvent

push eventapple/swift-driver

Xi Ge

commit sha 79d4306d2394c7e550daed5a95c740fbb831d7d4

Properly handle input file names after DashDash rdar://70260637

view details

Xi Ge

commit sha d33dfcc0ced17601d230d65a0769f7b3056a27c8

Merge pull request #305 from nkcsgexi/testDashDashPassingDownInput Properly handle input file names after DashDash

view details

push time in 8 days

PR merged apple/swift-driver

Reviewers
Properly handle input file names after DashDash

rdar://70260637

+18 -9

2 comments

3 changed files

nkcsgexi

pr closed time in 8 days

pull request commentapple/swift-driver

Properly handle input file names after DashDash

@swift-ci please test

nkcsgexi

comment created time in 8 days

push eventnkcsgexi/swift-driver

Xi Ge

commit sha 79d4306d2394c7e550daed5a95c740fbb831d7d4

Properly handle input file names after DashDash rdar://70260637

view details

push time in 8 days

pull request commentapple/swift-driver

Properly handle input file names after DashDash

@swift-ci please test

nkcsgexi

comment created time in 8 days

more