profile
viewpoint
Nisheet Jain nisheetjain Microsoft

microsoft/BotFramework-WebChat 1176

A highly-customizable web-based client for Azure Bot Services.

nisheetjain/vscode-emacs 8

Emacs support for Visual Studio Code

issue commentmicrosoft/code-push

Capacitor Support

Just add this and it will work (at least for android, I haven't tested it on IOS yet)

const baseUrl = (
        await Capacitor.Plugins!.Filesystem.getUri({ path: '', directory: FilesystemDirectory.Data })
    ).uri.replace('file://', '')

    codePush.getPendingPackage((localPackage) => {
        if (localPackage) {
            const path = `${baseUrl}${localPackage.localPath}/dist`
            switchToPath(path)
        } else {
            codePush.getCurrentPackage((localPackage) => {
                const path = `${baseUrl}${localPackage.localPath}/dist`
                switchToPath(path)
            })
        }
    })


async function switchToPath(path: string) {
    if ((await Capacitor.Plugins!.WebView.getServerBasePath()).path === path) {
        return
    }

    Capacitor.Plugins!.WebView.setServerBasePath({ path })
    Capacitor.Plugins!.WebView.persistServerBasePath()
}

AgDude

comment created time in 2 minutes

issue commentmicrosoft/code-push

Capacitor Support

@GalvinGao the discussion here is about code-push not push notification or app center

AgDude

comment created time in 4 minutes

issue commentmicrosoft/google-play-vsts-extension

Error: <!DOCTYPE html> using Google Play - Release Bundle Task

@chowarth do you still face with this issue? @anatolybolshakov

  • Internal test track: same issue

  • Alpha track: no errors

JrgSirr

comment created time in 10 hours

issue commentmicrosoft/react-native-code-push

CodePush rollbacks after updating

I seem to be having the same problem:

"react-native-code-push": "^6.4.1", "react-native": "0.63.4",

In the top-level index.js of our app:

const codePushOptions = { checkFrequency: codePush.CheckFrequency.MANUAL };
AppRegistry.registerComponent(appName, () => codePush(codePushOptions)(App))

In our sync func on loading screen:

  async function wrapperFunc() {
    try {
      await codePush.sync(
        { installMode: codePush.InstallMode.IMMEDIATE },
        (status) => {
          switch (status) {
            case codePush.SyncStatus.DOWNLOADING_PACKAGE:
              setDownloading(true);
              alertMsg();
              break;
            case codePush.SyncStatus.UP_TO_DATE:
            default:
              break;
          }
        },
        codePushDownloadDidProgress
      );
    } catch (e) {
      console.error(e);
    }
    await redirectView();
  }

Codepush is working as expected on Android, but our iOS app will only receive codepush updates once: upon 1st app restart. Upon subsequent app restarts, our iOS app seems to not receive updates.

I peeked through #1904 (which seems to describe the same problem), but none of the outlined solutions work for our app.

muzzammil-geniteam

comment created time in 12 hours

issue commentmicrosoft/google-play-vsts-extension

Error: <!DOCTYPE html> using Google Play - Release Bundle Task

@chowarth do you still face with this issue?

JrgSirr

comment created time in 12 hours

issue commentmicrosoft/react-native-code-push

gradle calculation of nodeModulesPath is poorly prioritized

@alexandergoncharov Friendly ping to help move this along. Issue is preventing us from releasing with codepush integrated.

maxkorp

comment created time in 13 hours

issue commentmicrosoft/react-native-code-push

Deployment and hermes builds are failing in monorepo (Lerna, Yarn workspaces)

You can currently work around it by creating a symlink, for example:

// File: <monorepo>/scripts/deploy-to-code-push.js

const appDir = join(__dirname, '../apps/app')

// AppCenter will try to use hermes-engine from the local node_modules
// instead of the hoisted one, so we create a symlink and it'll work
execSync(
  'ln -sfr ../../node_modules/hermes-engine ./node_modules/hermes-engine',
  { cwd: appDir, stdio: 'inherit' },
)

execSync(
  [
    'npx',
    'appcenter-cli',
    'codepush',
    'release-react',
    `--app ${CODE_PUSH_APP}`,
    '--deployment-name Default',
    '--disable-duplicate-release-error',
    '--target-binary-version "*"',
    `--token ${APP_CENTER_ACCESS_TOKEN}`,
  ].join(' '),
  { cwd: appDir, stdio: 'inherit' },
)
tad3j

comment created time in 13 hours

issue commentmicrosoft/cordova-plugin-code-push

[android] FATAL EXCEPTION: decoding JWT token (when installing signed update)

The fix-signed-bundles-crashes works but now I'm having issues with iOS ironically enough (it worked fine before)

Specifically I'm getting the xcode output of Failed to load webpage with error: unsupported URL which is talking about CDVWKWebViewEngine+CodePush.m line 103 I logged the request's url and it came out as nil so I'm not exactly sure what's going on. Any ideas ?

miqmago

comment created time in 13 hours

issue commentmicrosoft/code-push

Rollback a first CodePush release after a binary release

You're correct. It's not possible last time I looked. We have worked around it like this:

  1. Release v 1.0.0 (native version in App Stores)
  2. Push an update via code push: v.1.0.0-1 that is 100% exactly the same as native version. Only version number has changed
  3. Any subsequent pushes can now be rolled back to stable version

This is now part of our fastlane deploy script so it's completely automated.

On Tue, 26 Jan 2021 at 02:11, Alex Fox notifications@github.com wrote:

Just so I understand correctly. This is not possible:

  1. Release: v1.0.0
  2. Push update via code push: v1.0.0-1
  3. Discover bug in v1.0.0-1, rollback app to original v1.0.0 from AppStore

One alternative would be to release a v1.0.0-2 which was the same source as v1.0.0, providing you have tagged your releases on git 😉

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/microsoft/code-push/issues/187#issuecomment-767350312, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD2LRL7D44ALJST6UJM7KSTS3ZTILANCNFSM4B7DXFFQ .

gunters63

comment created time in 16 hours

issue closedmicrosoft/react-native-code-push

Building for iOS Simulator, but linking in object file built for iOS, file for architecture arm64

Hello, I just got a Mac Mini M1, and im trying to build my project but im getting this error. It just happens when trying to build to the Simulator, when trying to build to a physical device it builds correctly.

Expected Behavior

To build with success.

Actual Behavior

This is the error.

  ld: in /Users/luis/app-project/ios/Pods/AppCenter/AppCenter-SDK-Apple/iOS/AppCenter.framework/AppCenter(MSAppCenter.o), building for iOS Simulator, but linking in object file built for iOS, file '/Users/luis/app-project/ios/Pods/AppCenter/AppCenter-SDK-Apple/iOS/AppCenter.framework/AppCenter' for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

  • react-native-code-push version: 7.0.0
  • react-native version: 60.5
  • iOS Version: 14.3
  • Only when building to simulator, building to physical devices works perfectly.

closed time in 17 hours

R8Manzo

issue commentmicrosoft/react-native-code-push

Building for iOS Simulator, but linking in object file built for iOS, file for architecture arm64

@muzzammil-geniteam i did resolve it, i had to change the Build mode from Legacy to the new one. And also cleaned up a bunch of old dependencies, but i guess the build thing did it.

R8Manzo

comment created time in 17 hours

issue commentmicrosoft/google-play-vsts-extension

Error: <!DOCTYPE html> using Google Play - Release Bundle Task

It looks like the issue related to Google Cloud Incident and not to the task itself. It was created almost at the same time this issue was opened.

JrgSirr

comment created time in 21 hours

Pull request review commentmicrosoft/google-play-vsts-extension

Node 10 infrastructure experimental changes

             "path": "_build/Tasks/GooglePlayPromote"         },         {-            "path": "_build/Tasks/GooglePlayIncreaseRollout"+            "path": "_build/Tasks/GooglePlayRolloutUpdate"

Previously build path was determined using task name in task.json, but now we use the same name as the folder containing this task Basically we need to do this because of this change, which was initially made to stay consistent with azure-pipelines-tasks' make.js

DaniilShmelev

comment created time in a day

pull request commentmicrosoft/google-play-vsts-extension

Prepared build scripts for Node 10 migration

Let's test this agains on prem also.

egor-bryzgalov

comment created time in a day

Pull request review commentmicrosoft/google-play-vsts-extension

Node 10 infrastructure experimental changes

             "path": "_build/Tasks/GooglePlayPromote"         },         {-            "path": "_build/Tasks/GooglePlayIncreaseRollout"+            "path": "_build/Tasks/GooglePlayRolloutUpdate"

Could you please describe more in description why do we need this change?

DaniilShmelev

comment created time in a day

issue commentmicrosoft/google-play-vsts-extension

Error: <!DOCTYPE html> using Google Play - Release Bundle Task

Seeing this same error across multiple pipelines using the Google Play - Release Bundle Task when pushing a build to the internal test track.

As @NPadrutt already mentioned, we are also seeing that the packages have been uploaded to the PlayStore correctly when viewing the internal test track.

JrgSirr

comment created time in a day

issue commentmicrosoft/code-push

Rollback a first CodePush release after a binary release

Just so I understand correctly. This is not possible:

  1. Release: v1.0.0
  2. Push update via code push: v1.0.0-1
  3. Discover bug in v1.0.0-1, rollback app to original v1.0.0 from AppStore

One alternative would be to release a v1.0.0-2 which was the same source as v1.0.0, providing you have tagged your releases on git 😉

gunters63

comment created time in a day

issue commentmicrosoft/react-native-code-push

Building for iOS Simulator, but linking in object file built for iOS, file for architecture arm64

@R8Manzo : same here , any update on the issue . Were to able to resolve it

R8Manzo

comment created time in a day

issue commentmicrosoft/google-play-vsts-extension

Error: <!DOCTYPE html> using Google Play - Release Bundle Task

@ka05 yeap, that's why i wanted to confirm. I also re-ran my pipeline and passed without that previous error.

JrgSirr

comment created time in a day

issue commentmicrosoft/google-play-vsts-extension

Error: <!DOCTYPE html> using Google Play - Release Bundle Task

@JrgSirr Earlier today I re-ran my pipeline and this task did succeed!

Does anyone have any info on why this happened or how likely it is to occur again?

JrgSirr

comment created time in a day

issue commentmicrosoft/google-play-vsts-extension

Error: <!DOCTYPE html> using Google Play - Release Bundle Task

@ka05, have you recently tried to release a bundle using this task?

JrgSirr

comment created time in 2 days

issue commentmicrosoft/google-play-vsts-extension

Error: <!DOCTYPE html> using Google Play - Release Bundle Task

We're facing the same issue as @NPadrutt and @ka05 mention.

JrgSirr

comment created time in 2 days

delete branch microsoft/vscode-cordova

delete branch : dependabot/npm_and_yarn/socket.io-2.4.1

delete time in 2 days

PR merged microsoft/vscode-cordova

Bump socket.io from 2.3.0 to 2.4.1 dependencies

Bumps socket.io from 2.3.0 to 2.4.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/socketio/socket.io/releases">socket.io's releases</a>.</em></p> <blockquote> <h2>2.4.1</h2> <p>This release reverts the breaking change introduced in <code>2.4.0</code> (<a href="https://github.com/socketio/socket.io/commit/f78a575f66ab693c3ea96ea88429ddb1a44c86c7">https://github.com/socketio/socket.io/commit/f78a575f66ab693c3ea96ea88429ddb1a44c86c7</a>).</p> <p>If you are using Socket.IO v2, you should explicitly allow/disallow cross-origin requests:</p> <ul> <li>without CORS (server and client are served from the same domain):</li> </ul> <pre lang="js"><code>io.origins((req, callback) => { callback(null, req.headers.origin === undefined); // cross-origin requests will not be allowed }); </code></pre> <ul> <li>with CORS (server and client are served from distinct domains):</li> </ul> <pre lang="js"><code>io.origins(["http://localhost:3000"]); // for local development io.origins(["https://example.com"]); </code></pre> <p>In any case, please consider upgrading to Socket.IO v3, where this security issue is now fixed (CORS is disabled by default).</p> <h3>Reverts</h3> <ul> <li>fix(security): do not allow all origins by default (<a href="https://github.com/socketio/socket.io/commit/a1690509470e9dd5559cec4e60908ca6c23e9ba0">a169050</a>)</li> </ul> <h4>Links:</h4> <ul> <li>Diff: <a href="https://github.com/socketio/socket.io/compare/2.4.0...2.4.1">https://github.com/socketio/socket.io/compare/2.4.0...2.4.1</a></li> <li>Client release: -</li> <li>engine.io version: <code>~3.5.0</code></li> <li>ws version: <code>~7.4.2</code></li> </ul> <h2>2.4.0</h2> <p>Related blog post: <a href="https://socket.io/blog/socket-io-2-4-0/">https://socket.io/blog/socket-io-2-4-0/</a></p> <h3>Features (from Engine.IO)</h3> <ul> <li>add support for all cookie options (<a href="https://github.com/socketio/engine.io/commit/19cc58264a06dca47ed401fbaca32dcdb80a903b">19cc582</a>)</li> <li>disable perMessageDeflate by default (<a href="https://github.com/socketio/engine.io/commit/5ad273601eb66c7b318542f87026837bf9dddd21">5ad2736</a>)</li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>security:</strong> do not allow all origins by default (<a href="https://github.com/socketio/socket.io/commit/f78a575f66ab693c3ea96ea88429ddb1a44c86c7">f78a575</a>)</li> <li>properly overwrite the query sent in the handshake (<a href="https://github.com/socketio/socket.io/commit/d33a619905a4905c153d4fec337c74da5b533a9e">d33a619</a>)</li> </ul> <p>:warning: <strong>BREAKING CHANGE</strong> :warning:</p> <p>Previously, CORS was enabled by default, which meant that a Socket.IO server sent the necessary CORS headers (<code>Access-Control-Allow-xxx</code>) to <strong>any</strong> domain. This will not be the case anymore, and you now have to explicitly enable it.</p> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/socketio/socket.io/blob/2.4.1/CHANGELOG.md">socket.io's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/socketio/socket.io/compare/2.4.0...2.4.1">2.4.1</a> (2021-01-07)</h2> <h3>Reverts</h3> <ul> <li>fix(security): do not allow all origins by default (<a href="https://github.com/socketio/socket.io/commit/a1690509470e9dd5559cec4e60908ca6c23e9ba0">a169050</a>)</li> </ul> <h1><a href="https://github.com/socketio/socket.io/compare/2.3.0...2.4.0">2.4.0</a> (2021-01-04)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>security:</strong> do not allow all origins by default (<a href="https://github.com/socketio/socket.io/commit/f78a575f66ab693c3ea96ea88429ddb1a44c86c7">f78a575</a>)</li> <li>properly overwrite the query sent in the handshake (<a href="https://github.com/socketio/socket.io/commit/d33a619905a4905c153d4fec337c74da5b533a9e">d33a619</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/socketio/socket.io/commit/e6b869738c73fa0ce9928974d823e50cc92f7a1a"><code>e6b8697</code></a> chore(release): 2.4.1</li> <li><a href="https://github.com/socketio/socket.io/commit/a1690509470e9dd5559cec4e60908ca6c23e9ba0"><code>a169050</code></a> revert: fix(security): do not allow all origins by default</li> <li><a href="https://github.com/socketio/socket.io/commit/873fdc55eddd672960fdbc1325ccb7c4bf466f05"><code>873fdc5</code></a> chore(release): 2.4.0</li> <li><a href="https://github.com/socketio/socket.io/commit/f78a575f66ab693c3ea96ea88429ddb1a44c86c7"><code>f78a575</code></a> fix(security): do not allow all origins by default</li> <li><a href="https://github.com/socketio/socket.io/commit/d33a619905a4905c153d4fec337c74da5b533a9e"><code>d33a619</code></a> fix: properly overwrite the query sent in the handshake</li> <li><a href="https://github.com/socketio/socket.io/commit/3951a79359c19f9497de664d96a8f9f80196a405"><code>3951a79</code></a> chore: bump engine.io version</li> <li><a href="https://github.com/socketio/socket.io/commit/6fa026fc94fb3a1e6674b8a2c1211b24ee38934a"><code>6fa026f</code></a> ci: migrate to GitHub Actions</li> <li>See full diff in <a href="https://github.com/socketio/socket.io/compare/2.3.0...2.4.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+91 -126

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 days

push eventmicrosoft/vscode-cordova

dependabot[bot]

commit sha 4810696fd2b7f811eeb087aa37810a7f7c71b29f

Bump socket.io from 2.3.0 to 2.4.1 (#704) Bumps [socket.io](https://github.com/socketio/socket.io) from 2.3.0 to 2.4.1. - [Release notes](https://github.com/socketio/socket.io/releases) - [Changelog](https://github.com/socketio/socket.io/blob/2.4.1/CHANGELOG.md) - [Commits](https://github.com/socketio/socket.io/compare/2.3.0...2.4.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 2 days

PR opened microsoft/google-play-vsts-extension

[GooglePlayPromote] Migrated to Node10

Task name: google-play-promote

Description: Migrated task to Node 10.

Documentation changes required: No

Added unit tests: No

Attached related issue: No

Checklist:

  • [x] Task version was bumped - please check instruction how to do it
  • [] Checked that applied changes work as expected
+453 -5385

0 comment

15 changed files

pr created time in 2 days

issue commentmicrosoft/react-native-code-push

CodePush rollbacks after updating

I'm having the same problem with react native 0.63.4 and code push 7.0

muzzammil-geniteam

comment created time in 2 days

issue commentmicrosoft/google-play-vsts-extension

Error: <!DOCTYPE html> using Google Play - Release Bundle Task

Same here. As @ka05 mentioned, the package was uploaded correctly despite the error.

JrgSirr

comment created time in 3 days

more