profile
viewpoint
Nicolò Ribaudo nicolo-ribaudo @babel Turin, Italy Math student and open source maintainer

babel/eslint-plugin-babel-plugin 7

A set of eslint rules to enforce best practices in the development of Babel plugins.

babel/.github 6

Community health files for the Babel organization

babel/babel-test262-runner 6

Run test262 tests on Node 0.10 using Babel 7 and `core-js@3`.

es-shims/Math.fround 4

An ES-spec-compliant Math.fround shim/polyfill/replacement that works as far down as ES3

es-shims/Number.isInteger 4

An ES-spec-compliant Number.isInteger shim/polyfill/replacement that works as far down as ES3

es-shims/Math.atanh 3

An ES-spec-compliant Math.atanh shim/polyfill/replacement that works as far down as ES3

es-shims/Math.clz32 3

An ES-spec-compliant Math.clz32 shim/polyfill/replacement that works as far down as ES3

es-shims/Math.imul 3

An ES-spec-compliant Math.imul shim/polyfill/replacement that works as far down as ES3

es-shims/Math.cbrt 2

An ES-spec-compliant Math.cbrt shim/polyfill/replacement that works as far down as ES3

pull request commentbabel/babel

Add new decorators transform

Merged to https://github.com/babel/babel/pull/13827

pzuraq

comment created time in 11 hours

push eventbabel/babel

Chris Garrett

commit sha 603e0fa047cd579423361200f77a1bc982602e91

Add the `decoratorsAutoAccessors` parser plugin (#13681) Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com> Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

view details

Chris Garrett

commit sha 6f05357e1fd27883bafd1f1d24c5919da388ae47

Add new decorators transform (#14004) Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>

view details

push time in 11 hours

push eventbabel/babel

magic-akari

commit sha 693f2d282d368f512c5fea161bba87a1651a3ac0

Fix the transform of `super.foo--`/`super[foo]--` (and prefix) (#14162)

view details

Nicolò Ribaudo

commit sha e7c705a7486cc1a1490d26415336afd3100d3c8f

Respect `package.json#exports` when resolving plugins (#14110) * Respect `package.json#exports` when resolving plugins * Use native import.meta.resolve when available * Workaround V8 bug that makes Babel-Jest segfault.

view details

magic-akari

commit sha a6ca39cebb961255e825f3de8e8f59400df4db01

Handle logical assignment in super property transforms (#14164)

view details

Francisco Ryan Tolmasky I

commit sha 478a9709ab20dc942fbb2c20a82ae8fa41e55ed6

Improve errors location tracking (#14130)

view details

Nicolò Ribaudo

commit sha b2cfc5bf27a60c3aa64c55018d5dafdd0eaa9a2c

Skip class fields transform when not necessary for priv methods (#14169) Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>

view details

Nicolò Ribaudo

commit sha e1708ff2e42e3befaf56850e3001a25529f4d6d0

[test runner] Restore `TEST_GREP` support (jest `-t` parameter) (#14170)

view details

1o57

commit sha e6cc1071101b1abbd0325bfc746cd04d7af132b0

Avoid infinite loop when highlighting an empty input (#14165) Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

view details

Nicolò Ribaudo

commit sha 6ec66d8d2249e345a587d8d47722abd779be6416

Remove workaround for `_typeof` in runtime build script (#14157)

view details

Babel Bot

commit sha 4a737547e5eab0950db6c412dc614a329f6e36fe

v7.16.10

view details

Babel Bot

commit sha 35ca17aab6c9daa631a2e80e09afc09da8ce11ec

Add v7.16.10 to CHANGELOG.md [skip ci]

view details

Nicolò Ribaudo

commit sha 44c113f72d15c0cabdff4027ca61ccef269bf7ac

v7.16.11

view details

Babel Bot

commit sha b05dad7fed07672514fa6d0d21ce4c1e2c3a6f79

Add v7.16.11 to CHANGELOG.md [skip ci]

view details

Huáng Jùnliàng

commit sha e5d29f6e402ef6d2b173d555c471d2417401ab6a

fix: incorrect conciseBody lookahead (#14194)

view details

Nicolò Ribaudo

commit sha 2ea90542bcd87e67602331ecc7fd88c43203d706

Avoid dynamic import when it's not needed (#14192)

view details

Babel Bot

commit sha 526660552854e7972228e0c595a20ab904973c2e

v7.16.12

view details

Babel Bot

commit sha 4f7b91be8a370417de1a8762dade50aac30854e7

Add v7.16.12 to CHANGELOG.md [skip ci]

view details

Mattias Ekstrand

commit sha 1e25a2e857d3c92ad4b8382c6b3f4ec701e266e9

Normalize absolute paths on Windows (#14187) Co-authored-by: Babel Bot <babel-bot@users.noreply.github.com>

view details

Huáng Jùnliàng

commit sha 48cf6425345e6b676db512305f2f30d7b06a469c

chore: run tscheck on babel 8 breaking test (#14190)

view details

Huáng Jùnliàng

commit sha 5861002b338815fdbc0f31c5dda477240f188e74

Reinterpret << when parsing TS type arguments (#14145) * refactor: split bitShift to bitShiftL and bitShiftR * fix: reinterpret bitShiftL to lt when parsing type arguments * test: update typescript allowlist * add Babel 8 test cases * test: simplify testcase * add more testcases

view details

Daniel Tschinder

commit sha 66f0bc60dcc0959ccd46699a5d900b5db29bac1e

fix: Enforce newer version of `pirates` (#14195)

view details

push time in 11 hours

push eventnicolo-ribaudo/babel

Stuart Cook

commit sha 68bc4dfd311364f9a96dad03f8b024c2518a65f0

Print parentheses around identifier `let` where necessary (#13269)

view details

Nicolò Ribaudo

commit sha 1879491af7ebbc8d9761c6087f18a285c5573bbf

[eslint] Don't crash on multiple `@babel/parser` copies (#13274)

view details

Huáng Jùnliàng

commit sha a8fea4037dc194c4c220c15a0982c70cc12dce7d

Faster identifier tokenizing (#13262) * add benchmark * perf: faster identifier tokenizing - Mover iterator identifier parsing to the Flow plugin - If the character is an identifier start, pass it to readWord1

view details

Babel Bot

commit sha 4c1b8cc75171630b8e522d41acef44d28810ea4d

chore: update test262 to c11d6b00bc2c53323fe26a5813a720fd74cd25ad (#13276)

view details

Nicolò Ribaudo

commit sha 4c725f8cf810310c4924c925bb480f06ca442528

Support objects from other contexts in `t.valueToNode` (#13275)

view details

serut

commit sha e74b3fb1c6b1d89f856fc4d99b3d534eb823c4c6

[DOC] Add missing Monorepo configuration (#13253) * [DOC] Add missing Monorepo configuration * Update eslint/babel-eslint-parser/README.md Co-authored-by: Federico Ciardi <fed.ciardi@gmail.com> * [DOC] Unify monorepo config file * [DOC] Clean monorepo configuration * [DOC] Monorepo conf when eslint runned by package Co-authored-by: Federico Ciardi <fed.ciardi@gmail.com>

view details

Sosuke Suzuki

commit sha 1d54419ec4cb9eac579b65e4730a16cc8a12654c

Parse attributes of import expression with estree plugin (#13284) * Parse attributes of import expression with estree plugin * Add tests * Update packages/babel-parser/src/types.js Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com> Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>

view details

Trinangkur Chatterjee

commit sha 5ae3a6c2a4ee2656e5cfb12e7c7882aadda77873

Update lodash version for fixing security vulnerability (#13289) * Update lodash version for fixing security vulnerability * Update yarn.lock

view details

Sosuke Suzuki

commit sha b2d9156cc62d37f4c522c9505a00f50b99a1eb74

Update to Prettier 2.3 (#13288)

view details

Huáng Jùnliàng

commit sha 875fc8e6935ef7d124a748331ee8a43d59f4539e

[babel 8] Do not skip requeued paths (#13291)

view details

Clark Jacobsohn

commit sha cca97d1e7847026d70ce5d048e39a00a442b4308

Fix: Only create `@babel/node` IPC channel when needed (#13295) Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>

view details

Huáng Jùnliàng

commit sha 9e241fc18051731ed05722c62b9a0ec1905d86c8

Better error for `export * as ns` without the correct plugin (#13296)

view details

Babel Bot

commit sha 7512095c847bde6ef8eea664d7e0472fce3b89d4

v7.14.2

view details

Babel Bot

commit sha 7c9f618dfc7037810670e0e85956d09405b83317

Add v7.14.2 to CHANGELOG.md [skip ci]

view details

Bogdan Savluk

commit sha 379bc775edab2d223f55c64ad8f7d52bf10ccb22

convert @babel/plugin-transform-react-jsx to typescript (#13221) * babel-plugin-transform-react-jsx flowts rename * babel-plugin-transform-react-jsx flowts convert * babel-plugin-transform-react-jsx * babel-plugin-transform-react-jsx fix * make generate-tsconfig * yarn install * babel-plugin-transform-react-jsx remove unused typecast

view details

Nicolò Ribaudo

commit sha e21abad01696b48916666fb66f33f53e4c760bdf

Add test for fixed block scoping issue (#13304)

view details

Bogdan Savluk

commit sha 72371cb6376a50e5516aa80714dbecb4eee058a9

convert @babel/helper-create-regexp-features-plugin to typescript (#13215)

view details

Bogdan Savluk

commit sha acfff5d7fe5e27e2c984a53874c8c0bf928f61b8

convert @babel/plugin-transform-typescript to typescript (#13222) * babel-plugin-transform-typescript flowts rename * babel-plugin-transform-typescript flowts convert * babel-plugin-transform-typescript * babel-plugin-transform-typescript type fixes * babel-plugin-transform-typescript * make generate-tsconfig * yarn install * babel-plugin-transform-typescript * babel-plugin-transform-typescript avoid typecast

view details

Bogdan Savluk

commit sha 4bf5f45d428d3e7daca44067c8dd745c3dd4dafb

convert @babel/plugin-transform-runtime to typescript (#13216) Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>

view details

Babel Bot

commit sha 5def29d1cab9fb7a173da4a6d2fed6250a28c69d

chore: update test262 to 4f50cbfc771ffe41ac5e4a9d2f12b1d3a5d3b938 (#13310)

view details

push time in 11 hours

Pull request review commentbabel/babel

raise error on single type usage without comma

 export default (superClass: Class<Parser>): Class<Parser> =>           this.resetStartLocationFromNode(expr, typeParameters);         }         expr.typeParameters = typeParameters;++        // report error if single type parameter used without trailing comma.+        if (+          this.hasPlugin("jsx") &&+          expr.typeParameters.params.length === 1 &&+          !expr.typeParameters.extra?.trailingComma+        ) {+          const parameter = expr.typeParameters.params[0];+          if (parameter.constraint) {+            // If parameter has any constraints, it must contain multiple tokens.+            // <T extends U> is a valid declaration.+            // <T extends {name: string}> is also a valid declaration.+          } else invalidSingleType = parameter;+        }+         return expr;       }, state); +      if (invalidSingleType) {+        this.raise(+          TSErrors.SingleTypeParameterWithoutTrailingComma,+          {+            at: {+              ...invalidSingleType.loc.end,+              column: invalidSingleType.loc.end.column + 1,

Yes, please!

ozanhonamlioglu

comment created time in 11 hours

PullRequestReviewEvent

push eventbabel/babel

Chris Garrett

commit sha ec325e2a678bf5c9a05043ea874b09315feb4f57

Add new decorators transform (#14004) Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>

view details

push time in 11 hours

PR merged babel/babel

Add new decorators transform PR: New Feature :rocket: Spec: Decorators

<!-- Before making a PR, please read our contributing guidelines https://github.com/babel/babel/blob/main/CONTRIBUTING.md

Please note that the Babel Team requires two approvals before merging most PRs.

For issue references: Add a comma-separated list of a closing word followed by the ticket number fixed by the PR. (it should be underlined in the preview if done correctly)

If you are making a change that should have a docs update: submit another PR to https://github.com/babel/website -->

Q A <!--(Can use an emoji 👍) -->
Fixed Issues? Fixes #12654
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link No
Any Dependency Changes? No
License MIT

Adds the 2020-09 decorators transform, along with associated tests. See https://github.com/tc39/proposal-decorators for details on the proposal itself.

Resolves #12654.


Update by @JLHwung

Try this feature on REPL

<a href="https://gitpod.io/#https://github.com/babel/babel/pull/14004"><img src="https://gitpod.io/button/open-in-gitpod.svg"/></a>

+8136 -63

5 comments

287 changed files

pzuraq

pr closed time in 11 hours

PR closed babel/actions

Bump node-fetch from 2.6.1 to 3.1.1 in /check-assigned-issues dependencies

Bumps node-fetch from 2.6.1 to 3.1.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/node-fetch/node-fetch/releases">node-fetch's releases</a>.</em></p> <blockquote> <h2>v3.1.1</h2> <h2>Security patch release</h2> <p>Recommended to upgrade, to not leak sensitive cookie and authentication header information to 3th party host while a redirect occurred</p> <h2>What's Changed</h2> <ul> <li>core: update fetch-blob by <a href="https://github.com/jimmywarting"><code>@​jimmywarting</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1371">node-fetch/node-fetch#1371</a></li> <li>docs: Fix typo around sending a file by <a href="https://github.com/jimmywarting"><code>@​jimmywarting</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1381">node-fetch/node-fetch#1381</a></li> <li>core: (http.request): Cast URL to string before sending it to NodeJS core by <a href="https://github.com/jimmywarting"><code>@​jimmywarting</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1378">node-fetch/node-fetch#1378</a></li> <li>core: handle errors from the request body stream by <a href="https://github.com/mdmitry01"><code>@​mdmitry01</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1392">node-fetch/node-fetch#1392</a></li> <li>core: Better handle wrong redirect header in a response by <a href="https://github.com/tasinet"><code>@​tasinet</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1387">node-fetch/node-fetch#1387</a></li> <li>core: Don't use buffer to make a blob by <a href="https://github.com/jimmywarting"><code>@​jimmywarting</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1402">node-fetch/node-fetch#1402</a></li> <li>docs: update readme for TS <code>@​types/node-fetch</code> by <a href="https://github.com/adamellsworth"><code>@​adamellsworth</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1405">node-fetch/node-fetch#1405</a></li> <li>core: Fix logical operator priority to disallow GET/HEAD with non-empty body by <a href="https://github.com/maxshirshin"><code>@​maxshirshin</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1369">node-fetch/node-fetch#1369</a></li> <li>core: Don't use global buffer by <a href="https://github.com/jimmywarting"><code>@​jimmywarting</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1422">node-fetch/node-fetch#1422</a></li> <li>ci: fix main branch by <a href="https://github.com/dnalborczyk"><code>@​dnalborczyk</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1429">node-fetch/node-fetch#1429</a></li> <li>core: use more node: protocol imports by <a href="https://github.com/dnalborczyk"><code>@​dnalborczyk</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1428">node-fetch/node-fetch#1428</a></li> <li>core: Warn when using data by <a href="https://github.com/jimmywarting"><code>@​jimmywarting</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1421">node-fetch/node-fetch#1421</a></li> <li>docs: Create SECURITY.md by <a href="https://github.com/JamieSlome"><code>@​JamieSlome</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1445">node-fetch/node-fetch#1445</a></li> <li>core: don't forward secure headers to 3th party by <a href="https://github.com/jimmywarting"><code>@​jimmywarting</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1449">node-fetch/node-fetch#1449</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/mdmitry01"><code>@​mdmitry01</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1392">node-fetch/node-fetch#1392</a></li> <li><a href="https://github.com/tasinet"><code>@​tasinet</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1387">node-fetch/node-fetch#1387</a></li> <li><a href="https://github.com/adamellsworth"><code>@​adamellsworth</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1405">node-fetch/node-fetch#1405</a></li> <li><a href="https://github.com/maxshirshin"><code>@​maxshirshin</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1369">node-fetch/node-fetch#1369</a></li> <li><a href="https://github.com/JamieSlome"><code>@​JamieSlome</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1445">node-fetch/node-fetch#1445</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/node-fetch/node-fetch/compare/v3.1.0...v3.1.1">https://github.com/node-fetch/node-fetch/compare/v3.1.0...v3.1.1</a></p> <h2>v3.1.0</h2> <h2>What's Changed</h2> <ul> <li>fix(Body): Discourage form-data and buffer() by <a href="https://github.com/jimmywarting"><code>@​jimmywarting</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1212">node-fetch/node-fetch#1212</a></li> <li>fix: Pass url string to http.request by <a href="https://github.com/serverwentdown"><code>@​serverwentdown</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1268">node-fetch/node-fetch#1268</a></li> <li>Fix octocat image link by <a href="https://github.com/lakuapik"><code>@​lakuapik</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1281">node-fetch/node-fetch#1281</a></li> <li>fix(Body.body): Normalize <code>Body.body</code> into a <code>node:stream</code> by <a href="https://github.com/jimmywarting"><code>@​jimmywarting</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/924">node-fetch/node-fetch#924</a></li> <li>docs(Headers): Add default Host request header to README.md file by <a href="https://github.com/robertoaceves"><code>@​robertoaceves</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1316">node-fetch/node-fetch#1316</a></li> <li>Update CHANGELOG.md by <a href="https://github.com/jimmywarting"><code>@​jimmywarting</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1292">node-fetch/node-fetch#1292</a></li> <li>Add highWaterMark to cloned properties by <a href="https://github.com/davesidious"><code>@​davesidious</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1162">node-fetch/node-fetch#1162</a></li> <li>Update README.md to fix HTTPResponseError by <a href="https://github.com/thedanfernandez"><code>@​thedanfernandez</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1135">node-fetch/node-fetch#1135</a></li> <li>docs: switch <code>url</code> to <code>URL</code> by <a href="https://github.com/dhritzkiv"><code>@​dhritzkiv</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1318">node-fetch/node-fetch#1318</a></li> <li>fix(types): declare buffer() deprecated by <a href="https://github.com/dnalborczyk"><code>@​dnalborczyk</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1345">node-fetch/node-fetch#1345</a></li> <li>chore: fix lint by <a href="https://github.com/dnalborczyk"><code>@​dnalborczyk</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1348">node-fetch/node-fetch#1348</a></li> <li>refactor: use node: prefix for imports by <a href="https://github.com/dnalborczyk"><code>@​dnalborczyk</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1346">node-fetch/node-fetch#1346</a></li> <li>Bump data-uri-to-buffer from 3.0.1 to 4.0.0 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1319">node-fetch/node-fetch#1319</a></li> <li>Bump mocha from 8.4.0 to 9.1.3 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1339">node-fetch/node-fetch#1339</a></li> <li>Referrer and Referrer Policy by <a href="https://github.com/tekwiz"><code>@​tekwiz</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1057">node-fetch/node-fetch#1057</a></li> <li>Add typing for Response.redirect(url, status) by <a href="https://github.com/c-w"><code>@​c-w</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1169">node-fetch/node-fetch#1169</a></li> <li>chore: Correct stuff in README.md by <a href="https://github.com/Jiralite"><code>@​Jiralite</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1361">node-fetch/node-fetch#1361</a></li> <li>docs: Improve clarity of "Loading and configuring" by <a href="https://github.com/serverwentdown"><code>@​serverwentdown</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1323">node-fetch/node-fetch#1323</a></li> <li>feat(Body): Added support for <code>BodyMixin.formData()</code> and constructing bodies with FormData by <a href="https://github.com/jimmywarting"><code>@​jimmywarting</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1314">node-fetch/node-fetch#1314</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/node-fetch/node-fetch/blob/main/docs/CHANGELOG.md">node-fetch's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <p>All notable changes will be recorded here.</p> <p>The format is based on <a href="https://keepachangelog.com/en/1.0.0/">Keep a Changelog</a>, and this project adheres to <a href="https://semver.org/spec/v2.0.0.html">Semantic Versioning</a>.</p> <h2>What's Changed</h2> <ul> <li>core: update fetch-blob by <a href="https://github.com/jimmywarting"><code>@​jimmywarting</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1371">node-fetch/node-fetch#1371</a></li> <li>docs: Fix typo around sending a file by <a href="https://github.com/jimmywarting"><code>@​jimmywarting</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1381">node-fetch/node-fetch#1381</a></li> <li>core: (http.request): Cast URL to string before sending it to NodeJS core by <a href="https://github.com/jimmywarting"><code>@​jimmywarting</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1378">node-fetch/node-fetch#1378</a></li> <li>core: handle errors from the request body stream by <a href="https://github.com/mdmitry01"><code>@​mdmitry01</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1392">node-fetch/node-fetch#1392</a></li> <li>core: Better handle wrong redirect header in a response by <a href="https://github.com/tasinet"><code>@​tasinet</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1387">node-fetch/node-fetch#1387</a></li> <li>core: Don't use buffer to make a blob by <a href="https://github.com/jimmywarting"><code>@​jimmywarting</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1402">node-fetch/node-fetch#1402</a></li> <li>docs: update readme for TS <code>@​types/node-fetch</code> by <a href="https://github.com/adamellsworth"><code>@​adamellsworth</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1405">node-fetch/node-fetch#1405</a></li> <li>core: Fix logical operator priority to disallow GET/HEAD with non-empty body by <a href="https://github.com/maxshirshin"><code>@​maxshirshin</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1369">node-fetch/node-fetch#1369</a></li> <li>core: Don't use global buffer by <a href="https://github.com/jimmywarting"><code>@​jimmywarting</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1422">node-fetch/node-fetch#1422</a></li> <li>ci: fix main branch by <a href="https://github.com/dnalborczyk"><code>@​dnalborczyk</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1429">node-fetch/node-fetch#1429</a></li> <li>core: use more node: protocol imports by <a href="https://github.com/dnalborczyk"><code>@​dnalborczyk</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1428">node-fetch/node-fetch#1428</a></li> <li>core: Warn when using data by <a href="https://github.com/jimmywarting"><code>@​jimmywarting</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1421">node-fetch/node-fetch#1421</a></li> <li>docs: Create SECURITY.md by <a href="https://github.com/JamieSlome"><code>@​JamieSlome</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1445">node-fetch/node-fetch#1445</a></li> <li>core: don't forward secure headers to 3th party by <a href="https://github.com/jimmywarting"><code>@​jimmywarting</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1449">node-fetch/node-fetch#1449</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/mdmitry01"><code>@​mdmitry01</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1392">node-fetch/node-fetch#1392</a></li> <li><a href="https://github.com/tasinet"><code>@​tasinet</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1387">node-fetch/node-fetch#1387</a></li> <li><a href="https://github.com/adamellsworth"><code>@​adamellsworth</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1405">node-fetch/node-fetch#1405</a></li> <li><a href="https://github.com/maxshirshin"><code>@​maxshirshin</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1369">node-fetch/node-fetch#1369</a></li> <li><a href="https://github.com/JamieSlome"><code>@​JamieSlome</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1445">node-fetch/node-fetch#1445</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/node-fetch/node-fetch/compare/v3.1.0...v3.1.2">https://github.com/node-fetch/node-fetch/compare/v3.1.0...v3.1.2</a></p> <h2>3.1.0</h2> <h2>What's Changed</h2> <ul> <li>fix(Body): Discourage form-data and buffer() by <a href="https://github.com/jimmywarting"><code>@​jimmywarting</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1212">node-fetch/node-fetch#1212</a></li> <li>fix: Pass url string to http.request by <a href="https://github.com/serverwentdown"><code>@​serverwentdown</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1268">node-fetch/node-fetch#1268</a></li> <li>Fix octocat image link by <a href="https://github.com/lakuapik"><code>@​lakuapik</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1281">node-fetch/node-fetch#1281</a></li> <li>fix(Body.body): Normalize <code>Body.body</code> into a <code>node:stream</code> by <a href="https://github.com/jimmywarting"><code>@​jimmywarting</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/924">node-fetch/node-fetch#924</a></li> <li>docs(Headers): Add default Host request header to README.md file by <a href="https://github.com/robertoaceves"><code>@​robertoaceves</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1316">node-fetch/node-fetch#1316</a></li> <li>Update CHANGELOG.md by <a href="https://github.com/jimmywarting"><code>@​jimmywarting</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1292">node-fetch/node-fetch#1292</a></li> <li>Add highWaterMark to cloned properties by <a href="https://github.com/davesidious"><code>@​davesidious</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1162">node-fetch/node-fetch#1162</a></li> <li>Update README.md to fix HTTPResponseError by <a href="https://github.com/thedanfernandez"><code>@​thedanfernandez</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1135">node-fetch/node-fetch#1135</a></li> <li>docs: switch <code>url</code> to <code>URL</code> by <a href="https://github.com/dhritzkiv"><code>@​dhritzkiv</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1318">node-fetch/node-fetch#1318</a></li> <li>fix(types): declare buffer() deprecated by <a href="https://github.com/dnalborczyk"><code>@​dnalborczyk</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1345">node-fetch/node-fetch#1345</a></li> <li>chore: fix lint by <a href="https://github.com/dnalborczyk"><code>@​dnalborczyk</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1348">node-fetch/node-fetch#1348</a></li> <li>refactor: use node: prefix for imports by <a href="https://github.com/dnalborczyk"><code>@​dnalborczyk</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1346">node-fetch/node-fetch#1346</a></li> <li>Bump data-uri-to-buffer from 3.0.1 to 4.0.0 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1319">node-fetch/node-fetch#1319</a></li> <li>Bump mocha from 8.4.0 to 9.1.3 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1339">node-fetch/node-fetch#1339</a></li> <li>Referrer and Referrer Policy by <a href="https://github.com/tekwiz"><code>@​tekwiz</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1057">node-fetch/node-fetch#1057</a></li> <li>Add typing for Response.redirect(url, status) by <a href="https://github.com/c-w"><code>@​c-w</code></a> in <a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1169">node-fetch/node-fetch#1169</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/node-fetch/node-fetch/commit/36e47e8a6406185921e4985dcbeff140d73eaa10"><code>36e47e8</code></a> 3.1.1 release (<a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1451">#1451</a>)</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/5304f3f7f7778f1011b622bedcb0e4d3c04dba31"><code>5304f3f</code></a> Don't change relative location header on manual redirect (<a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1105">#1105</a>)</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/f5d3cf5e2579cb8f4c76c291871e69696aef8f80"><code>f5d3cf5</code></a> fix(Headers): don't forward secure headers to 3th party (<a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1449">#1449</a>)</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/f2c3d563755d4d357df987fe871607e296463cef"><code>f2c3d56</code></a> Create SECURITY.md (<a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1445">#1445</a>)</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/4ae35388b078bddda238277142bf091898ce6fda"><code>4ae3538</code></a> core: Warn when using data (<a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1421">#1421</a>)</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/41f53b9065a00bc73d24215d42aacdcd284b199c"><code>41f53b9</code></a> fix: use more node: protocol imports (<a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1428">#1428</a>)</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/f674875f98c4ef2970a9acf02324f520b1b77967"><code>f674875</code></a> ci: fix main branch (<a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1429">#1429</a>)</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/1493d046bc0944886277b0b82dfdf78a7b9f7799"><code>1493d04</code></a> core: Don't use global buffer (<a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1422">#1422</a>)</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/eb33090b81442bc6af9f714a5158160856a1e2f2"><code>eb33090</code></a> Chore: Fix logical operator priority (regression) to disallow GET/HEAD with n...</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/7ba5bc9e0aff386ae0e00792d1ea2e2f7a4fd7d6"><code>7ba5bc9</code></a> update readme for TS <code>@​type/node-fetch</code> (<a href="https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1405">#1405</a>)</li> <li>Additional commits viewable in <a href="https://github.com/node-fetch/node-fetch/compare/v2.6.1...v3.1.1">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~endless">endless</a>, a new releaser for node-fetch since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+68 -4

2 comments

2 changed files

dependabot[bot]

pr closed time in 18 hours

pull request commentbabel/actions

Bump node-fetch from 2.6.1 to 3.1.1 in /check-assigned-issues

We only use fetch with trusted URLs (https://github.com/), so this vulnerability does not affect us.

How does this even work?

We don't have tests for this repo :sweat_smile:

dependabot[bot]

comment created time in 18 hours

push eventbabel/babel

Daniel Tschinder

commit sha 66f0bc60dcc0959ccd46699a5d900b5db29bac1e

fix: Enforce newer version of `pirates` (#14195)

view details

push time in 18 hours

delete branch babel/babel

delete branch : danez-patch-1

delete time in 18 hours

PR merged babel/babel

fix: Enforce newer version of pirates due to compatibility issues with esm pkg: register
Q A <!--(Can use an emoji 👍) -->
Fixed Issues?
Patch: Bug Fix? yes
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This issue danez/pirates#90 was preventing the use of @babel/register with esm (https://www.npmjs.com/package/esm) The bug was introduced in 4.0.2 and fixed in 4.0.5.

I think it would be best to enforce the latest version to avoid more people running into this.

<a href="https://gitpod.io/#https://github.com/babel/babel/pull/14195"><img src="https://gitpod.io/button/open-in-gitpod.svg"/></a>

+6 -15

0 comment

2 changed files

danez

pr closed time in 18 hours

PullRequestReviewEvent

startedbnb/awesome-hyper

started time in 19 hours

fork nicolo-ribaudo/dell-xps-9570-ubuntu-respin

Collection of scripts and tweaks to adapt Ubuntu running smooth on Dell XPS 15 9570.

fork in 2 days

issue closedbabel/babel

[Bug]: Destructured symbol fails on IE 10+

💻

  • [ ] Would you like to work on a fix?

How are you using Babel?

@rollup/plugin-babel

Input code

const symbol = Symbol('desc')

export default ({
  [symbol]: alias = {},
  ...rest
}) => {
  return {
    ...rest,
    symbol: alias
  }
}

Configuration file name

babel.config.json

Configuration

{
  "presets": [
    "@babel/env"
  ],
  "exclude": [
    "node_modules/**"
  ],
  "targets": ["since 2000"]
}

Current and expected behavior

Actually, it throws "@@toPrimitive must return a primitive value." which doesn't seems to be catchable.

But the objects passed are pretty fine, since if I extract the parts separately, it works.

const symbol = Symbol('desc')

export default ({
  ...properties
}) => {
  return {
    ...properties,
    [symbol]: properties[symbol]
  }
}

Environment

  • Babel version: 7.16.7
  • Node: 16.3.0
  • npm: 7.18.1
  • OS: Windows 10
  • Monorepo: no

Possible solution

No response

Additional context

No response

closed time in 2 days

Lcfvs

issue commentbabel/babel

[Bug]: Destructured symbol fails on IE 10+

Whops sorry, I forgot about this :sweat_smile:

I'm only case in which ignore and exclude have different behaviors is when you have multiple Babel configurations:

  • exclude means "don't apply this config to these files"
  • ignore means "don't transform these files with Babel"

If, for example, you enable some plugins A in babel.config.js and plugin B by passing it directly to @rollup/plugin-babel:

  • with exclude: node_modules, all the JS files in node_modules will be transformed but only with plugin B;
  • with ignore: node_modules, the JS files in node_modules won't be transformed.
Lcfvs

comment created time in 2 days

push eventnicolo-ribaudo/babel

Babel Bot

commit sha 4a737547e5eab0950db6c412dc614a329f6e36fe

v7.16.10

view details

Babel Bot

commit sha 35ca17aab6c9daa631a2e80e09afc09da8ce11ec

Add v7.16.10 to CHANGELOG.md [skip ci]

view details

Nicolò Ribaudo

commit sha 44c113f72d15c0cabdff4027ca61ccef269bf7ac

v7.16.11

view details

Babel Bot

commit sha b05dad7fed07672514fa6d0d21ce4c1e2c3a6f79

Add v7.16.11 to CHANGELOG.md [skip ci]

view details

Huáng Jùnliàng

commit sha e5d29f6e402ef6d2b173d555c471d2417401ab6a

fix: incorrect conciseBody lookahead (#14194)

view details

Nicolò Ribaudo

commit sha 2ea90542bcd87e67602331ecc7fd88c43203d706

Avoid dynamic import when it's not needed (#14192)

view details

Babel Bot

commit sha 526660552854e7972228e0c595a20ab904973c2e

v7.16.12

view details

Babel Bot

commit sha 4f7b91be8a370417de1a8762dade50aac30854e7

Add v7.16.12 to CHANGELOG.md [skip ci]

view details

Mattias Ekstrand

commit sha 1e25a2e857d3c92ad4b8382c6b3f4ec701e266e9

Normalize absolute paths on Windows (#14187) Co-authored-by: Babel Bot <babel-bot@users.noreply.github.com>

view details

Huáng Jùnliàng

commit sha 48cf6425345e6b676db512305f2f30d7b06a469c

chore: run tscheck on babel 8 breaking test (#14190)

view details

Nicolò Ribaudo

commit sha 7c5a66686406bb3945feb87f2151503a17f4cc14

Convert `@babel/eslint-plugin` to CJS

view details

Nicolò Ribaudo

commit sha 18d05addb7db61b5176da64941ee578655dd73f1

Convert `@babel/eslint-plugin-development` to CJS

view details

Nicolò Ribaudo

commit sha 6280b7332b9f1a86d77fa8ef224a08e181e4a4d3

Convert `@babel/eslint-plugin-development-internal` to CJS

view details

Nicolò Ribaudo

commit sha 7fa0bf61a599f2407f5a5dcb5638a9f22c3b521c

Update `package.json` files

view details

Nicolò Ribaudo

commit sha b770fdaa6f979030f7ad97dcbe941bbd4a07cb33

Update `constraints.pro`

view details

push time in 3 days

push eventbabel/babel

Huáng Jùnliàng

commit sha 48cf6425345e6b676db512305f2f30d7b06a469c

chore: run tscheck on babel 8 breaking test (#14190)

view details

push time in 3 days

delete branch JLHwung/babel

delete branch : run-tscheck-on-babel-8-breaking-test

delete time in 3 days

PR merged babel/babel

chore: run tscheck on babel 8 breaking test PR: Internal :house:

<!-- Before making a PR, please read our contributing guidelines https://github.com/babel/babel/blob/main/CONTRIBUTING.md

Please note that the Babel Team requires two approvals before merging most PRs.

For issue references: Add a comma-separated list of a closing word followed by the ticket number fixed by the PR. (it should be underlined in the preview if done correctly)

If you are making a change that should have a docs update: submit another PR to https://github.com/babel/website -->

Q A <!--(Can use an emoji 👍) -->
Fixed Issues? Run tscheck on Babel 8 breaking tests
License MIT

<!-- Describe your changes below in as much detail as possible --> Currently we only run eslint on the Babel 8 build. In this PR we also enable tscheck. I will mark the PR ready to review when CI is green.

<a href="https://gitpod.io/#https://github.com/babel/babel/pull/14190"><img src="https://gitpod.io/button/open-in-gitpod.svg"/></a>

+1 -1

3 comments

1 changed file

JLHwung

pr closed time in 3 days

push eventbabel/babel

Mattias Ekstrand

commit sha 1e25a2e857d3c92ad4b8382c6b3f4ec701e266e9

Normalize absolute paths on Windows (#14187) Co-authored-by: Babel Bot <babel-bot@users.noreply.github.com>

view details

push time in 3 days

PR merged babel/babel

Normalize absolute paths on Windows PR: Bug Fix :bug:
Q A
Fixed Issues? Fixes #14185
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link N/A
Any Dependency Changes? No
License MIT

Normalized file path, which otherwise causes issues in @rollup/plugin-babel, see issue at https://github.com/rollup/plugins/issues/1089 and PR (incl. discussions) at https://github.com/rollup/plugins/pull/1090

<a href="https://gitpod.io/#https://github.com/babel/babel/pull/14187"><img src="https://gitpod.io/button/open-in-gitpod.svg"/></a>

+2 -2

1 comment

2 changed files

atti187

pr closed time in 3 days

issue closedbabel/babel

[Bug]: Windows path delimiter causing issues in @rollup/plugin-babel

💻

  • [X] Would you like to work on a fix?

How are you using Babel?

@rollup/plugin-babel

Input code

https://github.com/atti187/rollup-babel-bug

Configuration file name

babel.config.js

Configuration

https://github.com/facebook/create-react-app/tree/main/packages/babel-preset-react-app

Current and expected behavior

Issue is occurring in https://github.com/rollup/plugins/tree/master/packages/babel and described in https://github.com/rollup/plugins/issues/1089.

PR (and discussion) at https://github.com/rollup/plugins/pull/1090...

Environment

System: OS: Windows 10 10.0.18363 Binaries: Node: 14.15.5 - C:\Program Files\nodejs\node.EXE npm: 6.14.11 - C:\Program Files\nodejs\npm.CMD npmPackages: babel-preset-react-app: ^10.0.1 => 10.0.1

Possible solution

In https://github.com/babel/babel/blob/35ca17aab6c9daa631a2e80e09afc09da8ce11ec/packages/babel-plugin-transform-runtime/src/get-runtime-path/index.ts#L37, change to:

return require.resolve(path).replace(/\\/g, "/");

Will provide a PR soon...

Additional context

No response

closed time in 3 days

atti187

issue commentbabel/babel

[Bug]: Random segfaults when running webpack and using @babel/core 7.16.10

I'm releasing 7.16.12 with the workaround for this V8 bug.

Artur-

comment created time in 3 days

push eventbabel/babel

Nicolò Ribaudo

commit sha 2ea90542bcd87e67602331ecc7fd88c43203d706

Avoid dynamic import when it's not needed (#14192)

view details

push time in 3 days

delete branch nicolo-ribaudo/babel

delete branch : fix-14186

delete time in 3 days

issue closedbabel/babel

[Bug]: Random segfaults when running webpack and using @babel/core 7.16.10

💻

  • [ ] Would you like to work on a fix?

How are you using Babel?

Other (Next.js, Gatsby, vue-cli, ...)

Input code

No idea how to reproduce it. It reproduces in random places in our CI builds, starting from yesterday after the release of 7.16.10

Configuration file name

No response

Configuration

No response

Current and expected behavior

Apparently we are using Babel through workbox which is used through webpack which is run from Java

├─┬ workbox-build@6.4.1
│ ├─┬ @babel/core@7.16.10

The only expectation I have is that webpack should finish the build instead of segfault. Assuming here that exit value 139 means segmentation fault.

Environment

  • Babel: 7.16.10
  • Node 16.0.0

Possible solution

Downgrading to @babel/core 7.16.7 resolves the problem

Additional context

https://github.com/vaadin/flow/runs/4882425225?check_suite_focus=true is an example of a failed build but it does not provide much more information

https://github.com/vaadin/flow/runs/4882529524 is the same build but with babel 7.16.7

closed time in 3 days

Artur-

PR merged babel/babel

Avoid dynamic import when it's not needed PR: Bug Fix :bug: i: regression

<!-- Before making a PR, please read our contributing guidelines https://github.com/babel/babel/blob/main/CONTRIBUTING.md

Please note that the Babel Team requires two approvals before merging most PRs.

For issue references: Add a comma-separated list of a closing word followed by the ticket number fixed by the PR. (it should be underlined in the preview if done correctly)

If you are making a change that should have a docs update: submit another PR to https://github.com/babel/website -->

Q A <!--(Can use an emoji 👍) -->
Fixed Issues? Fixes #14186
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link <!-- If only readme change, add [skip ci] to your commits -->
Any Dependency Changes?
License MIT

<!-- Describe your changes below in as much detail as possible -->

This fixes https://github.com/babel/babel/issues/14186. It's the annoying segfault; the one that affects Babel/Webpack/Jest but V8 doesn't fix. In https://github.com/babel/babel/pull/14110 I added a workaround just for Jest, but since it also affects other projects this PR replaces the Jest workaround with another one. It will still crash in some cases, but only when using the --experimental-import-meta-resolve experimental flag with Jest or Webpack (hopefully no one relies on this combination, but otherwise there is not much that we can do other than :+1: the Node.js issue and the V8 bug).

@jlowcs Could you also try replacing line 26 of https://unpkg.com/browse/@babel/core@7.16.10/lib/config/files/import-meta-resolve.js with the following code, trigger a few CI runs, and see if it still works (it's a better fix from the one I already asked you to verify, because it doesn't affect the current Babel behavior other than avoiding crashes):

const resolveP = import_ && process.execArgv.includes("--experimental-import-meta-resolve")
    ? import_("data:text/javascript,export default import.meta.resolve").then(m => m.default || _importMetaResolve.resolve, () => _importMetaResolve.resolve)
    : Promise.resolve(_importMetaResolve.resolve);

<a href="https://gitpod.io/#https://github.com/babel/babel/pull/14192"><img src="https://gitpod.io/button/open-in-gitpod.svg"/></a>

+25 -21

2 comments

2 changed files

nicolo-ribaudo

pr closed time in 3 days

more