profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/nicolo-ribaudo/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Nicolò Ribaudo nicolo-ribaudo @babel Turin, Italy Math student and open source maintainer

babel/.github 6

Community health files for the Babel organization

babel/eslint-plugin-babel-plugin 6

A set of eslint rules to enforce best practices in the development of Babel plugins.

babel/babel-test262-runner 4

Run test262 tests on Node 0.10 using Babel 7 and `core-js@3`.

es-shims/Math.fround 4

An ES-spec-compliant Math.fround shim/polyfill/replacement that works as far down as ES3

es-shims/Number.isInteger 4

An ES-spec-compliant Number.isInteger shim/polyfill/replacement that works as far down as ES3

es-shims/Math.atanh 3

An ES-spec-compliant Math.atanh shim/polyfill/replacement that works as far down as ES3

es-shims/Math.clz32 3

An ES-spec-compliant Math.clz32 shim/polyfill/replacement that works as far down as ES3

es-shims/Math.imul 3

An ES-spec-compliant Math.imul shim/polyfill/replacement that works as far down as ES3

es-shims/Math.cbrt 2

An ES-spec-compliant Math.cbrt shim/polyfill/replacement that works as far down as ES3

Pull request review commentbabel/babel

Simplify (transpiled) babel-types builder wrappers

 import { NODE_FIELDS, BUILDER_KEYS } from "../definitions"; import validate from "../validators/validate"; import type * as t from ".."; -export default function builder<T extends t.Node>(-  type: T["type"],-  ...args: Array<any>-): T {+export default function builder<T extends t.Node>(this: T["type"]): T {+  const type = this;   const keys = BUILDER_KEYS[type];

We support swapping the parser and the generator, but not the other packages. You can handle custom AST modifications by changing VISITOR_KEYS.

On the other hand, I don't see why someone would want to change BUILDER_KEYS (you can just directly create the node without using the builder function).

lightmare

comment created time in 8 hours

PullRequestReviewEvent
PullRequestReviewEvent

issue commentbabel/babel

[Bug]: @babel/transform-react-jsx "Unknown term type: reference"

Could you try completely deleting regjsgen and regexpu-core from your lockfile, and reinstalling with npm install/yarn install?

adminy

comment created time in 15 hours

push eventnicolo-ribaudo/babel

Mickey Rose

commit sha 2403a4889dc32c50ee837fff094ed5526dd48c4b

remove ineffectual helper names filter (#13841)

view details

Mickey Rose

commit sha 24aa1b44fe059b0c903458559dfca2bd05f73f3d

[ts] precise return type on `createTypeAnnotationBasedOnTypeof` (#13844)

view details

Babel Bot

commit sha 513b00e60d0ad123f7c4d65adc4f3c4151c2d6fd

chore: update test262 to 8d420cef415f3501cb24d674b8c032d1f09402a0 (#13850)

view details

Nicolò Ribaudo

commit sha 780aa48d2a34dc55f556843074b6aed45e7eabeb

Force loading plugins/presets from the monorepo in tests (#13858)

view details

Nicolò Ribaudo

commit sha 0f8366c171a8f278a23f42b05c93379ad0f0ac0c

Update to Yarn `3.1.0-rc.10`

view details

Nicolò Ribaudo

commit sha 33050287ac5d209134da857451b2189c56117022

Update the `constraints` plugin

view details

Nicolò Ribaudo

commit sha eede8740577b582e6ea0374c651fb7ae2a17eeaf

Workaround `yarn constraints` breaking change

view details

push time in 15 hours

delete branch nicolo-ribaudo/agendas

delete branch : patch-1

delete time in a day

push eventbabel/babel

Nicolò Ribaudo

commit sha 780aa48d2a34dc55f556843074b6aed45e7eabeb

Force loading plugins/presets from the monorepo in tests (#13858)

view details

push time in a day

delete branch nicolo-ribaudo/babel

delete branch : load-monorepo-packages-in-tests

delete time in a day

PR merged babel/babel

Force loading plugins/presets from the monorepo in tests PR: Internal :house:
Q A <!--(Can use an emoji 👍) -->
Fixed Issues? Fixes the CI failure in https://github.com/babel/babel/pull/13856
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link <!-- If only readme change, add [skip ci] to your commits -->
Any Dependency Changes?
License MIT

<!-- Describe your changes below in as much detail as possible -->

When using @babel/-prefixed plugins/presets, they are always loaded from node_modules. With Yarn 2 and Yarn 3 we were lucky enough that the version resolved in node_modules was a symlink to the monorepo version, but due to some changes to the hoisting algorithm this isn't true anymore in Yarn 3.1 (so it uncovered the bug).

<a href="https://gitpod.io/#https://github.com/babel/babel/pull/13858"><img src="https://gitpod.io/button/open-in-gitpod.svg"/></a>

+29 -14

2 comments

5 changed files

nicolo-ribaudo

pr closed time in a day

PR opened tc39/agendas

Schedule constraints
+1 -0

0 comment

1 changed file

pr created time in a day

push eventnicolo-ribaudo/agendas

Nicolò Ribaudo

commit sha 1b2cb42972762248fd373ab646a3796deefd94f1

Schedule constraints

view details

push time in a day

push eventnicolo-ribaudo/agendas

Nicolò Ribaudo

commit sha 599d43ed1022224bae2502bd916e915eb69425af

Schedule constraints

view details

push time in a day

push eventnicolo-ribaudo/agendas

Nicolò Ribaudo

commit sha 8e566d53a465c7b138a3dc326ff7eca99dcf21ca

Schedule constraints

view details

push time in a day

PR closed babel/website

升级到Babel7.md

请勘察翻译不准的地方

+143 -151

3 comments

1 changed file

BodomLake

pr closed time in 2 days

pull request commentbabel/website

升级到Babel7.md

I didn't know about https://babel.docschina.org/, amazing work!

@BodomLake I'm closing this PR because, as @KimYangOfCat, our website doesn't currently translations.

BodomLake

comment created time in 2 days

push eventnicolo-ribaudo/babel

Nicolò Ribaudo

commit sha a60919b41376a5bbcecb670d0c684fe0954ab699

Update the `constraints` plugin

view details

push time in 2 days

push eventnicolo-ribaudo/babel

Nicolò Ribaudo

commit sha 8d0a1be0a223f38b98dab36ce4edcc7c7bbc8f15

Force loading plugins/presets from the monorepo in tests

view details

Nicolò Ribaudo

commit sha c177181bc125731939b7a95fb860f339d35d7bbf

Update to Yarn `3.1.0-rc.10`

view details

push time in 2 days

push eventnicolo-ribaudo/babel

Nicolò Ribaudo

commit sha 8d0a1be0a223f38b98dab36ce4edcc7c7bbc8f15

Force loading plugins/presets from the monorepo in tests

view details

push time in 2 days

push eventnicolo-ribaudo/babel

Nicolò Ribaudo

commit sha ece9f58fdfa8a1b93d84045b0f117507dfb14807

Force loading plugins/presets from the monorepo in tests

view details

Nicolò Ribaudo

commit sha 12c9b1fbe474326ac778d813ce8ca70ff18aa358

Update to Yarn `3.1.0-rc.10`

view details

push time in 2 days

PR opened babel/babel

Force loading plugins/presets from the monorepo in tests
Q A <!--(Can use an emoji 👍) -->
Fixed Issues? Fixes the CI failure in https://github.com/babel/babel/pull/13856
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link <!-- If only readme change, add [skip ci] to your commits -->
Any Dependency Changes?
License MIT

<!-- Describe your changes below in as much detail as possible -->

When using @babel/-prefixed plugins/presets, they are always loaded from node_modules. With Yarn 2 and Yarn 3 we were lucky enough that the version resolved in node_modules was a symlink to the monorepo version, but due to some changes to the hoisting algorithm this isn't true anymore in Yarn 3.1 (so it uncovered the bug).

+28 -13

0 comment

4 changed files

pr created time in 2 days

create barnchnicolo-ribaudo/babel

branch : load-monorepo-packages-in-tests

created branch time in 2 days

pull request commentbabel/babel

perf(traverse): generate faster code for `arguments -> Array` conversion

I have another PR in the works for plugin-transform-spread that will obviate this change for that particular plugin, but scope.toArray can still be used from other places, right?

I think that it's the only way where we use it: if we don't need it anymore we will remove it in Babel 8.

lightmare

comment created time in 2 days

PR opened babel/babel

Update to Yarn `3.1.0-rc.10` PR: Internal :house:

<!-- Before making a PR, please read our contributing guidelines https://github.com/babel/babel/blob/main/CONTRIBUTING.md

Please note that the Babel Team requires two approvals before merging most PRs.

For issue references: Add a comma-separated list of a closing word followed by the ticket number fixed by the PR. (it should be underlined in the preview if done correctly)

If you are making a change that should have a docs update: submit another PR to https://github.com/babel/website -->

Q A <!--(Can use an emoji 👍) -->
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link dev
Any Dependency Changes?
License MIT

<!-- Describe your changes below in as much detail as possible -->

This is mostly to test that Yarn 3.1.0 doesn't break us, before that it's released as stable.

+645 -647

0 comment

5 changed files

pr created time in 2 days

create barnchnicolo-ribaudo/babel

branch : yarn-3.1

created branch time in 2 days

pull request commentyarnpkg/berry

fix(constraints): use JSON.stringify in workspace_field

I think that this is a breaking change. To reproduce:

  • Clone https://github.com/babel/babel
  • Verify that yarn constraints passes
  • Update the plugin to 3.1.0-rc.10: yarn plugin import https://github.com/yarnpkg/berry/raw/@yarnpkg/cli/3.1.0-rc.10/packages/plugin-constraints/bin/%40yarnpkg/plugin-constraints.js
  • yarn constraints reports a ton of failures
paul-soporan

comment created time in 2 days

pull request commentbabel/babel

Convert Babel to native ESM

@arcanis I don't understand why yarn constraints is failing; was there any breaking change in Yarn 3 that caused package.json fields values to be quoted?

nicolo-ribaudo

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentbabel/babel

Implement @babel/plugin-bugfix-safari-id-destructuring-collision-in-function-expression

 module.exports = {       "let / scope shadow resolution",       "let / scope shadow resolution (strict mode)",     ],-    replaces: "transform-block-scoping",+    replaces: ["transform-block-scoping"],   },   "bugfix/transform-safari-for-shadowing": {     features: [       "let / for-in loop binding shadowing parameter",       "let / for-in loop binding shadowing parameter (strict mode)",     ],-    replaces: "transform-block-scoping",+    replaces: ["transform-block-scoping"],+  },+  "bugfix/transform-safari-id-destructuring-collision-in-function-expression": {+    features: ["destructuring, parameters / duplicate identifier"],+    replaces: ["transform-parameters", "proposal-object-rest-spread"],

Even with just transform-parameters that code is transformed to

(function a(_ref) {
  let { ...a
  } = _ref;
  return function () {}();
});

which should work in Safari?

Since many people don't enable bugfixes, I'm trying to minimize the default generated output :sweat_smile:

JLHwung

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentbabel/babel

Implement @babel/plugin-bugfix-safari-id-destructuring-collision-in-function-expression

 prepublish: 	IS_PUBLISH=true $(MAKE) test  new-version-checklist:-	# @echo "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"-	# @echo "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"-	# @echo "!!!!!!                                                   !!!!!!"-	# @echo "!!!!!!         Write any message that should             !!!!!!"-	# @echo "!!!!!!            block the release here                 !!!!!!"-	# @echo "!!!!!!                                                   !!!!!!"-	# @echo "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"-	# @echo "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"-	# @exit 1+	@echo "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"+	@echo "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"+	@echo "!!!!!!                                                   !!!!!!"+	@echo "!!!!!!  Set packages/babel-plugin-bugfix-safari-id-destructuring-collision-in-function-expression/package.json"+	@echo "!!!!!!  @babel/core peerDependencies to latest published version"

Well, when we added proposal-static-block to @babel/preset-env@7.12.0 was already six months old, so it was likely that many people already updated it. This time we are forcing everyone to update @babel/core.

I think that it would be better to:

  1. Leave a lower peerDependency
  2. Change the api.assertVersion call in the new plugin to api.assertVersion("7.16.0")
  3. Add this plugin to the list at https://github.com/babel/babel/blob/513b00e60d0ad123f7c4d65adc4f3c4151c2d6fd/packages/babel-preset-env/src/available-plugins.ts#L149, so that it's only enabled when using new @babel/core versions.
JLHwung

comment created time in 2 days