profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/nhomar/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Nhomar Hernández [Vauxoo] nhomar Vauxoo Colima - México http://nhomar.com CEO at @Vauxoo

nhomar/actions_server 2

Server actions that can be used to customize Odoo

nhomar/backupws 1

A simple set of python scripts to make an Odoo 8.0 backup using oerplib

nhomar/bootstrap-material-design 1

Material design theme for Bootstrap 3

push eventvauxoo-dev/odoo

oco-odoo

commit sha 4c06b3c1180048b1c0db5067adf0c0bef5c02785

[FIX] account: Don't generate pdf at all when trying to print a misc operation from the 'print invoices' actions Before, clicking on 'print invoices' or 'print invoices without payment' on a posted misc operation raised an error message saying that only invoices could be printed. However, the pdf file still got generated and could be found as attachement on the move. With this commit, we don't generate the file anymore in this case. closes odoo/odoo#76419 Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

view details

Nasreddin Boulif (bon)

commit sha 8cc791e2de0f708ff7d69574cc8a8a40ef61c02b

[FIX] stock: Display only one table header in traceability report Steps to reproduce: - Install Manufacturing module - Go to Manufacturing -> Operations -> Manufacturing Orders - Create a new one and add at least 10 product components - Move it to Done stage - Click on stat button Traceability - Unfold the components - Print report Issue: Table header on 2nd page overlap table content. Cause: Wkhtmltopdf does not handle well table on multiple pages. More info here: https://github.com/wkhtmltopdf/wkhtmltopdf/issues/2367 Solution: Do not duplicate table header on next pages. opw-2634492 closes odoo/odoo#76443 Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

view details

Uku Lagle

commit sha 1ebe38aaac9b355a15b0c91cdb5271851c8c833f

[FIX] account_facturx: gross price must be subtotal not unit price Facturx expects line price to be subtotal, not unit price. Odoo parser is also dividing the gross price by quantity. So before this commit, importing PDF invoice rendered by Odoo, results in: unit price / quantity. The bug was introduced in odoo/odoo#53894 closes odoo/odoo#76302 X-original-commit: c6cc3ffee0b762c9104977918a49116e5e70fc68 Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

view details

Nicolas (vin)

commit sha 33ffea3cb610644b21a4ac3116e9fc4ba70fc84c

[ADD] Added VAT report for Italy and simplify tax templates The Italian VAT report is needed to help Italian customers fill in their VAT report. Task id #2079462 closes odoo/odoo#75740 Related: odoo/enterprise#20506 Signed-off-by: Florian Gilbert <FlorianGilbert@users.noreply.github.com>

view details

Nathan Marotte (nama)

commit sha d54a58706225fdfc920a03064b750769d75d91e0

[FIX] stock : Settings change triggered a change of show_operations Issue: When changing a settings and saving, all the operation types (stock_picking.type) that had a code different than incoming had their Show Detailed Operations (show_operations) forced to be True, even when the change in settings was totally unrelated Steps to reproduce : 1) Go to Inventory (stock) / Configuration / Warehouse Management / Operations Types 2) Find or create an Operation Type with Type of Operation set to something else than Receipt (incoming) 3) Ensures that the checkbox Show Detailed Operations (show_operations) is **unchecked** 4) Go to Settings and check or uncheck any setting, for example Permissions > Default Access Rights 5) Save 6) Go back to the Operation Type seen before 7) Show Detailed Operation is now **checked** Why is that a bug: The intended behaviour was to check that Show Detailed Operations box every time we change group_stock_multi_locations group_stock_production_lot, or group_stock_tracking_lot from **unchecked to checked**, but the actual behaviour was to check that SDO box every time one of the **3 was checked when changing settings** backporting from PR #74786 14.0 ticket : opw-2604730 opw-2604730 closes odoo/odoo#75932 Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

view details

Nathan Marotte (nama)

commit sha d4a159402808773550cd916132a59b2984b43054

[FIX] mrp stock_picking : count to do and filter not matching Issue: The button # To Process in mrp/views/stock_picking_views.xml at line 33 uses the domain state confirmed, draft, planned, or progress But the default filter, which is called "to do", show those 4 states + to_close (in mrp/views/mrp_production_views.xml line 309) Side-Note: Issue also present in 14.0, so starting the bug fix from here. 12.0 doesn't seem to have a to_close state but the count and filter domain also do not match Steps to reproduce in 14.0 On Runbot, go to Inventory click on the "# to process" button on a Manufacturing card. - Choose any MO and create a work order. On this work order, click "Start", then "Done". - The MO is now in the "To Close" stage. - Go back to Inventory Overview. The number to process has gone down by one. - Click on the "# to process" button, you will see that the "To Close" MO appears in the list but is not counted by the button. (written by dido) For 13.0 I haven't been able to find steps to reproduce but the button has not changed between the two versions opw-2636447 closes odoo/odoo#76007 Signed-off-by: Rémy Voet <ryv-odoo@users.noreply.github.com>

view details

Nathan Marotte (nama)

commit sha 189dd8ffc1e6f00ba5dd637ca73aa10757784ea9

[FIX] mrp_workorder quality: product and template desynchronized Issue : When selecting mrp_operation as picking_type, the product variant is not changed Steps to reproduce: Install Quality, MRP Disable variants Edit View: Form (debug mode) and remove groups="product.group_product_variant" to show the variants (This is done so we can see the issue in the backend) Set a product Changing product changes the variant Set the operation to manufacturing Set another product -> The variant is not updated Why is that a bug: It can lead to some problems if the variants are disabled and then enabled at a later time for the company Side-Note: The original bug related to the related commit was not present in v13 as said in the related commit opw discussion Related commit 2dc2003 opw-2515100 (related to opw-2490412) closes odoo/odoo#75944 Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

view details

Bruno Zanotti

commit sha 35c8fef451d405f977349cef8440d613d0ff4b45

[FIX] l10n_ar: natural vat for Uruguayan partners Add the natural vat number for partners from Uruguay. closes odoo/odoo#75860 Signed-off-by: Josse Colpaert <jco@openerp.com>

view details

Nathan Marotte (nama)

commit sha 441fb1e9ee97e2dcc1c2bd1a9fdb393d006aa1a5

[FIX] mrp_workorder quality: product and template desynchronized Issue : When selecting mrp_operation as picking_type, the product variant is not changed Steps to reproduce: Install Quality, MRP Disable variants Edit View: Form (debug mode) and remove groups="product.group_product_variant" to show the variants (This is done so we can see the issue in the backend) Set a product Changing product changes the variant Set the operation to manufacturing Set another product -> The variant is not updated Why is that a bug: It can lead to some problems if the variants are disabled and then enabled at a later time for the company Side-Note: The original bug related to the related commit was not present in v13 as said in the related commit opw discussion Related commit 2dc2003 opw-2515100 (related to opw-2490412) closes odoo/odoo#75855 Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

view details

Arnold Moyaux

commit sha f96c78f701831ed7aa1798765e3e5f81d1a689c1

[FIX] stock: avoid breaking global scss for thead commit bc1a6faa51fef60bb64ea09f4e43f1120f9855bd add a rule to fix tracability report but on a global level. However we won't this behavior everywhere in odoo or at least if it's the case it shouldn't be specify there closes odoo/odoo#76589 Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

view details

oco-odoo

commit sha a6ce7280f4a192e877fbdbd4b70c5105a8044fa9

[FIX] account: fix wrong call to super() closes odoo/odoo#76696 Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

view details

Joren Van Onder

commit sha 7316413261ca8294ceffa212d6b5079b6e35daf6

[FIX] payment_authorize: charge tokens via the sandbox when disabled It's possible for a payment.acquirer to charge tokens when it's disabled via the subscription app (_cron_recurring_create_invoice()). Before this patch it would use the production endpoint. It's unexpected and can cause accidental charges in a database meant for testing. opw-2637659 closes odoo/odoo#75958 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

view details

Odoo Translation Bot

commit sha fdff2b828f6750d880419e6aa34bfcf3121ffd93

[I18N] Update translation terms from Transifex

view details

Adrien Widart

commit sha e85316b71bb86339e89f337e32dd8bd63a1e19e7

[FIX] base: use context_today as default rate name Suppose the TZ is UTC+12 and a user creates a new rate in the morning: the date will be the day before The default date should consider the user's timezone. OPW-2590972 closes odoo/odoo#76809 X-original-commit: 579d82f801265407649addd67ec4aa4ddab093da Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com> Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>

view details

Nasreddin Boulif (bon)

commit sha 65250fdef59dc07a5d34302c50b060d45936d234

[FIX] sale_quotation_builder: Update template header message Update header message to match changes in the following commit: https://github.com/odoo/odoo/commit/8ba6e3b0c3bf856308b4d58158392d0e99d2b58e opw-2631125 closes odoo/odoo#76766 X-original-commit: 9b1c35e2a5e335cc463534f1311b43a1eec70c37 Signed-off-by: bon-odoo <nboulif@users.noreply.github.com>

view details

William Braeckman

commit sha 62be05dc40e9f47c1b0a2216f8193d7a79c3a544

[FIX] hr_org_chart: remove res_id from the widget's action On the employee view there is a possibility to open a list of all the employees managed by the current employee however the action contains the key 'res_id' which makes both create and open action invalid. (the manager is opened either way instead of the right action) The action now also has a proper name instead of displaying `unnamed`, aswell as containing the context necessary to default the manager as expected. and the triple dots displayed when there are too many employees has been replaced with `See All`. TaskId-2648133 closes odoo/odoo#76730 Signed-off-by: Kevin Baptiste <kba@odoo.com>

view details

qsm-odoo

commit sha 64ce5a7bff933ad93c0618b0db5be5b3bcb09834

[FIX] web_editor: properly await all async parts for onRemove Even though onRemove cannot be async itself (yet?), it is however still called via a trigger_up of `call_for_each_child_snippet` so that each part of the snippet being removed has their onRemove called. Doing that way, some SnippetEditor instances may have to be created and it can be an async operation... the problem is that our code was only awaiting the first of those instanciations instead of all of them. closes odoo/odoo#76829 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

view details

Hubert Van de Walle (huvw)

commit sha ea122e1d06f2d9f9bc51576ccbec1aff0eb392ff

[FIX] mail, web: don't refresh chatter when opening a dialog Steps to follow - Add an attachment in the chatter of a customer - Create an invoice with this customer - Open the customer form dialog from the sidearrow -> The attachment from the customer is displayed Solution Don't refresh the chatter if the form is from a dialog This is a backport from v14 opw-2525091 closes odoo/odoo#75704 Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

view details

Hed Shefer

commit sha a447d8590469c85c27ee24e2bb803bbc61720627

[CLA] corporate signature for Layline Tech closes odoo/odoo#76824 X-original-commit: 95c99be67989703454b48f42d27798f7de011336 Signed-off-by: Josse Colpaert <jco@openerp.com>

view details

Arturo Flores

commit sha b7cfce2d18275c67603667e35ef0a1dfa2ae7758

[ADD] l10n_pe: add exportation tax The exportation tax should be part of the basic taxes due to the use there is going to have for the users.

view details

push time in 11 hours

push eventvauxoo-dev/odoo

Bruno Zanotti

commit sha a9d35786a253f0af0e6e8ce160a5c571d38f67c0

[FIX] l10n_ar: return vat info grouped by tax In the method _get_vat(), used to inform AFIP about the vat taxes of an invoice, we were assuming that in the journal items of the invoices there is always one line per tax group, but if the user enables the option "Include in Analytic Cost" of the tax, then it could create more than one line per tax so it will return an error if you try to validate the invoice in AFIP or upload the vat book. closes odoo/odoo#75802 Signed-off-by: Josse Colpaert <jco@openerp.com>

view details

Odoo Translation Bot

commit sha 71c3b588575f73f4d618359ce081336f4e9262b9

[I18N] Update translation terms from Transifex

view details

Olivier Dony

commit sha e5a180d44c259a0278f31687885fbeb3ba9c91cc

[FIX] web_editor: limit size of generated images This should avoid disrupting layouts. closes odoo/odoo#75957 X-original-commit: baca6bd71632e68f4e57380537e6282afbc172bc Signed-off-by: Olivier Dony (odo) <odo@openerp.com>

view details

fja-odoo

commit sha 3f6f5868d90e5c28e3f95e3c76c418b57685cc22

[FIX] sale_stock, purchase_stock: fix conversion qty received Rounding in purchase order is 'UP' which is causing issue when doing receipt in a different uom than the purchase. Rounding should be 'HALF-UP' Added test in purchase and sales to ensure this issue is detected in the future. closes odoo/odoo#75792 Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

view details

Ivan Yelizariev

commit sha 28e1ba469a48af90bfa4c86b05c241d0f9acf04f

[FIX] account: unlink moves lines in batch To reproduce performance problem one can use following scenario: * Use Enterprise v13 * go to Accounting / Assets, select the chair and click on "Set To Running" * Click "Modify Deprecation" and enter the following values: Reason: x Number of Deprecations: 1000 Months Deprecation Amount: 1000 Account Asset Counterpart: 101000 Current Assets * click on "Modify" --- opw-2621292 closes odoo/odoo#75919 Signed-off-by: William André (wan) <wan@odoo.com>

view details

ijas ahammed

commit sha 41f59a61992d4e4d62faf5ddbecb344100e2029a

[FIX] link_tracker,test_mail_full: fix traceback while converting links Currently, when we try to shorten the links from content with help of `_convert_links_text` method, it throws traceback if the body(content) we pass is `False`(might happen when we directly pass a model field of textual type but the field doesn't have a value yet). It's because the `re` expects the content to be string / bytestring. This commit fixes the issue by adding a check in this method, which will simply return `False` if there's no body. Task-2628586 closes odoo/odoo#75920 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

view details

Adrien Widart

commit sha 225fb81cc0e7d44678f2b53a9722f5dbd28a9bf6

[FIX] point_of_sale: remove monetary widget of discount field Considering the field declaration: https://github.com/odoo/odoo/blob/fe5deb4ee4c8e07aed2f2cff6210271bfaa61476/addons/point_of_sale/models/pos_order.py#L1121 `discount` is a rate, not an amount. Therefore, suppose a discount of 10%, when opening a POS-generated SO, the discount shouldn't be "$10". OPW-2629493 closes odoo/odoo#75907 X-original-commit: 666955cb630640384c5ca1f0e13e13b5253c3c58 Signed-off-by: pimodoo <pimodoo@users.noreply.github.com> Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>

view details

Goffin Simon

commit sha a8f1ee59a521bc1399dfddb091e6c060ac554d3a

[FIX] sale, sale_crm: Wrong salesperson when creating SO from lead Steps to reproduce the issue: - Let's log in Odoo with a user U1 - Create a lead with user U2 as salesperson - Click on New quotation Bug: A SO was suggested with U1 as salesperson instead of U2 opw:2520827 closes odoo/odoo#75787 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

view details

Hubert Van de Walle (huvw)

commit sha 5780e50c0baf7c4b0c2799c38fd532a6772f6a1d

[FIX] l10n_de_skr04: bad debt accounts have wrong type Bad debt accounts should be of expenses type like the ones in the l10n_de_skr03 addon opw-2512526 closes odoo/odoo#75772 Signed-off-by: William André (wan) <wan@odoo.com>

view details

Denis Ledoux

commit sha 07f0ffad6ecc08f4165902db45ae96e4b41199e8

[FIX] stock: `report_stock_quantity` ambiguous column product_qty In case there is a `product_qty` column added by a custom module, `product_qty`, without specifying from which table to take it from in the view definition, can lead to an ambiguous definition. ``` 2021-08-25 12:25:31,624 1145 ERROR db_23001 odoo.modules.registry: Failed to load registry Traceback (most recent call last): File "/home/odoo/src/odoo/13.0/odoo/modules/registry.py", line 86, in new odoo.modules.load_modules(registry._db, force_demo, status, update_module) File "/home/odoo/src/odoo/13.0/odoo/modules/loading.py", line 424, in load_modules force, status, report, loaded_modules, update_module, models_to_check) File "/home/odoo/src/odoo/13.0/odoo/modules/loading.py", line 315, in load_marked_modules perform_checks=perform_checks, models_to_check=models_to_check File "/home/odoo/src/odoo/13.0/odoo/modules/loading.py", line 202, in load_module_graph registry.init_models(cr, model_names, {'module': package.name}, new_install) File "/home/odoo/src/odoo/13.0/odoo/modules/registry.py", line 370, in init_models model.init() File "/home/odoo/src/odoo/13.0/addons/stock/report/report_stock_quantity.py", line 126, in init self.env.cr.execute(query) File "/home/odoo/src/odoo/13.0/odoo/sql_db.py", line 173, in wrapper return f(self, *args, **kwargs) File "/home/odoo/src/odoo/13.0/odoo/sql_db.py", line 250, in execute res = self._obj.execute(query, params) psycopg2.errors.AmbiguousColumn: column reference "product_qty" is ambiguous LINE 21: ...AND whd.id IS NULL) OR ls.usage = 'transit' THEN -product_qt... ``` upg-23001 closes odoo/odoo#75998 Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>

view details

Adrien Widart

commit sha b53d36b8c4f6afd44b884f6acea9a222ff79b52d

[FIX] website_sale: include purchase_price in product changes When changing the pricelist on the shop, if the new one has a different currency and if the cart already contains some products, the purchase price of each product should be updated To reproduce the error: 1. Select Public Pricelist 2. Add the Customizable Desk (Steel, White) 3. Back to shop, select EUR pricelist Error: Consulting the SO on back-end, the purchase price is not converted (and therefore the margin is incorrect) Changing the pricelist on a SO that already contains some lines is not a valid flow. Therefore, the fix must only concern the web-shop. When setting a new pricelist, the request gets the current carte and forces the new pricelist. Therefore, the cart is updated and several values are computed again: https://github.com/odoo/odoo/blob/379f1490c93dc599a74add2d678c18fbba1efa62/addons/website_sale/models/sale_order.py#L142-L149 In the above dictionary, the price unit is based on the new pricelist (new discount, new currency...). When the module `sale_margin` is installed, this dictionary should include the new value of `purchase_price`. By doing this, the `margin` will also have a correct value: https://github.com/odoo/odoo/blob/194ce17436929b74fc3d4c2744853d32bd9d2567/addons/sale_margin/models/sale_order.py#L64-L67 OPW-2585376 closes odoo/odoo#76008 X-original-commit: 8fffa06efa7905b6d1c875ab0f851c718423f941 Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com> Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>

view details

Adrien Widart

commit sha 3b8615c0f41a32619974eb1ef8b56ec0b13b01d3

[FIX] point_of_sale: consider scanned price as manual price In a POS session, when using the scanner, if the seller changes the customer, the prices may become incorrect To reproduce the issue 1. Create a product P: - Sales Price: 38 - Barcode: 2312345000002 - Available in POS: True 2. Start a POS session (with debug Window) 3. Scan 2312345010001 - This is product P with price $10 4. Set a Customer Error: The price is now $38 Because the price has not been set manually, when changing the customer, the pricelist is updated and so does the price. When scanning a barcode that includes a price, the latter should be considered as manually set. OPW-2618934 closes odoo/odoo#76074 X-original-commit: e66724272a5379c5d56f8fe48fa48ceac53cf12d Signed-off-by: pimodoo <pimodoo@users.noreply.github.com> Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>

view details

Nathan Marotte (nama)

commit sha ec86c67ae789b1e16dbdde248e3350529d20e7a8

[FIX] mrp : Confirm MO twice generates multiple stock move Issue: When two Odoo webpage are open on a Manufacturing order, it is possible to mark the MO as todo twice, then when trying to record the production, there will be a traceback Expected Singleton Steps to reproduce: 1) Install MRP 2) Create a Manufacturing order for a Product with a BO 3) Save, open a new odoo webclient and go to the same MO 4) Mark as todo on each webclient 5) Check availability on each webclient 6) Produce on each webclient, and save the wizard -> Traceback Expected Singleton opw-2636556 closes odoo/odoo#76210 Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

view details

Anh Thao Pham (pta)

commit sha 1cda59cf236e00ca6463d7212582ded050cc5207

[FIX] web: fix data in view graph for concurrent groupby - Go to any graph view (i.e. in CRM) - Change "Group By" 2 times very very quickly (In Chrome, you can set Throttling to "Slow 3G" in Network tab of devtools) Data from first groupby will be mixed with data from the second one. A graph reload is performing the following steps: * clean previous data * fetch data * set data The issue happens when a second reload is performed while the previous one has not set its data yet and the cleaning step of the second one is performed before the setting step of the first one. The solution will be to ignore the setting step of all previous reloads if there is a more recent one. opw-2460145 closes odoo/odoo#75307 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

view details

Anh Thao Pham (pta)

commit sha cc76e76ef2d1cc5a16778bd9440911fd6ec73c9b

[FIX] stock_account: fix access error when computing average price - Create a product with Category configured with: * Costing Method: First In First Out (FIFO) * Inventory Valuation: Automated - Create a PO to buy 1 unit and receive the product - Create a SO to sell 1 unit and deliver the product - Return the product - Re-deliver the product - Create invoice for SO but don't post it - Connect with an user with "Accounting: Accountant" rights only - Post the invoice An access error will be triggered when trying to access stock valuation layer. opw-2623376 closes odoo/odoo#75507 Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

view details

François (FRC)

commit sha ea1869d08693e17477b919732fb261efeb545837

[FIX] snailmail: better tests & delivery address now visible on report Tests now check for the 'error' field in Pingen repsonse snailmail_external_layout.js now targets the right div closes odoo/odoo#76246 Task: 2588145 & 2583718 Signed-off-by: Florian Daloze (fda) <fda@odoo.com>

view details

Roy Le

commit sha 2842a3c396c4230ebcefa6ba8296440fb35d25ee

[FIX] payment: fix some warning in console log The method '_company_default_get' on res.company is deprecated and shouldn't be used anymore. closes odoo/odoo#76186 Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

view details

Nils Hamerlinck

commit sha e503e5ea06ed6999bbc8d6b30a2528eeb4be8f0e

[REM] packaging: remove obsolete dependency feedparser - Up to odoo 10.0, feedparser dependency was optionally used in the cli of vendored html2text.py (see https://github.com/odoo/odoo/blob/10.0/addons/mail/models/html2text.py#L437) - Since 11.0 (67c17cb3), vendored html2text.py has been removed in favor of maintained package - Turns out the feedparser part in html2text was dead code for a long time anyway (see https://github.com/Alir3z4/html2text/issues/220) - So we can safely drop this dependency closes odoo/odoo#76259 X-original-commit: 271b9468c999454527f106b4db177665afeef8ca Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

view details

Xavier ALT

commit sha 28a303a67935dc5566cc0d1fe2be157736691968

[FIX] cloc: also exclude module's "upgrades" folder by default Since commit bbb1a8f151b, module's upgrade script can also be added into special 'upgrades' folder as an alternative to the old 'migrations' folder. As those upgrade scripts are not maintained from version to version, we should not count them as maintenance. OPW-2536046 closes odoo/odoo#76184 Signed-off-by: Xavier Alt (xal) <xal@odoo.com>

view details

Achraf (abz)

commit sha 8ab1e9d884196bfab055e14e3071ca3c32bcc005

[FIX] gamification: Allow users to verify their emails even when disconnected When a user clicks on the link in the verification email to verify his email while being disconnected there is an error specifying that the sender is not defined This pr defines the `email_from` field via the `User: New rank reached` template opw-2469306 closes odoo/odoo#75775 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

view details

push time in 7 days

issue closedodoo/odoo

[BUG] Module: Data Cleaning - Duplicate Removal selection archive/delete disappears when model = res.partner is choosen

Module Name: Data Cleaning Technical Name: data_cleaning Impacted versions: 14.0.1.0

Steps to reproduce:

  1. Go to Data Cleaning module
  2. Go to Deduplication Rules
  3. Create a new rule
  4. Verify that the Duplicate Removal selection is present. To delete or archive the record.
  5. Choose Model = res.partner
  6. Verify that the Duplicate Removal selection is present. To delete or archive the record.
  7. Choose Archive
  8. Save
  9. Click on Deduplicate
  10. Merge one of the proposals
  11. Verify that the merged donor profile is archived and not deleted from the system.

Current behavior: When res.partner is selected as model, it does not give an option to choose between archive/delete after merging. Currently it is deleting the merged profile by default.

Expected behavior: Duplicate Removal Option to choose between Archive/Delete should be given, user should have option to choose between archive or delete. We need to archive the merged profile as part of our business.

Video/Screenshot link (optional): Step 3 & 4 from above: image Step 6 from above: image

Support ticket number submitted via odoo.com/help (optional): Ticket#2569158

closed time in 13 days

samannisar

issue commentodoo/odoo

[BUG] Module: Data Cleaning - Duplicate Removal selection archive/delete disappears when model = res.partner is choosen

Hello @samannisar

I will answer and close:

The reason we can't create such an option is that the model has a method called _merge_method once you set such a method in the model there is no possibility to actually decide what to do (because the code will decide by you) the solution is to customize the code with an external module.

@pedrobaeza BTW you and your prejudices just confuse the users man, the actual code is 100% in community [1] and this is the reason why support both no matter where and why is perfect.

[1] https://github.com/odoo/odoo/blob/14.0/odoo/addons/base/wizard/base_partner_merge.py/#L625-L626

samannisar

comment created time in 13 days

push eventvauxoo-dev/odoo

Nicolas (vin)

commit sha 77dfbe810823b8a0e5675bf1510efebd523c8f54

[FIX] l10n_generic_coa: Fix demo data for reconciliation tests One of the invoices created in the demo data has a variable date. This cause the enumeration of these invoices to vary depending on the date. This variation then cause an issue when testing the reconciliation tour, causing it to fail on certain dates. This change will make sure that the enumeration of the demo invoices stays the same, and avoid such kinds of issues. closes odoo/odoo#72236 Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

view details

Adrien Widart

commit sha 1e176ba3bf9c493067eb649846c6729775a1e997

[FIX] point_of_sale: allow user to close session If a user has no accounting permission, when he opens/closes a POS session (without any sale), he will not be able to close the session To reproduce the error: (Use demo data) 1. Remove all Marc Demo's permissions for the Accounting module 2. Login with Marc Demo 3. Open a POS Session 4. Close the POS Session Error: "Sorry, you are not allowed to delete documents of type 'Journal Entries' (account.move) [...]" Note: if the user processes at least one order during the POS session, he will be able to close it thanks to sudo mode: https://github.com/odoo/odoo/blob/369331dfdc144cf852c80c99d00ce8d5da843be1/addons/point_of_sale/models/pos_session.py#L302 OPW-2523187 closes odoo/odoo#72032 Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

view details

Anh Thao Pham (pta)

commit sha a8d3f466dfffca08214acecf08ec298e3ace6272

[FIX] account: fix taxes set on invoice sections & notes at creation When adding a section or a note on an invoice, default taxes are set on the account move line, making the corresponding Tax Group to appear on the invoice. opw-2541722 closes odoo/odoo#71983 Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>

view details

Djamel (otd)

commit sha fc8266409ca1b6633ab7cd301cd05f5c7eeccfb6

[FIX] sale: re-invoicing of multiple orders Steps to reproduce the bug: - Go to sales app > create two SO with different price lists - Go to expense app > create a new expense - Add two expense lines related to the two SO - Click on the “Submit to Manager” button - Approve the expense - Click on “Post journal entries” - An error is triggered Problem: We call the onchange_discount on all SO lines together in the “_sale_create_reinvoice_sale_line function”, while it should be called on each created line separately. Bug introduced by this commit : https://github.com/odoo/odoo/commit/8815f4d9ab8620428d50abbe603c7f6c63076d6c opw-2571247 closes odoo/odoo#72299 Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

view details

Jairo Llopis

commit sha 6c1fbed523d0b7b83f0d5b3c305f1eb2a7549292

[IMP] mail: allow to remove plus addressing from bounce return addresses Since odoo/odoo@f4524f03c32a27b1899562a71cad6f491bfe44ce plus addressing is not used anymore for handling bounces. Indeed it relies on references / in reply to to find original message that bounced. It is therefore not necessary to enforce the use of plus addressing. As some provider do not support plus addressing as a way to contact left-part of email with sub-informations people should have a way to deactivate plus addressing used in bounce aliases. To preserve backwards compatibility for stable versions old behavior is retained unless a new `mail.bounce.alias.static` ICP is set with a truthy value. Fix https://github.com/odoo/odoo/issues/71242 by dropping requirement of plus addressing. @Tecnativa TT29827 Closes #71242 Task ID-2547347 PR odoo/odoo#72347

view details

Thibault Delavallée

commit sha 0fc5f504170f302fffabeeb32e8c321b62c4467d

[FIX] mail: correctly avoid increasing bounced counter two times When a bounce has to be managed on a record already inheriting from blacklist mixin it shoudl not be counted two times: one for email-based bounce and one for "all records using that email linked to blacklist mechanism should bounce". A mechanism exists to prevent that double increase but it was not correctly done. Protection was reset in a loop. Task ID-2547347 PR odoo/odoo#72347 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

view details

Philémon van Helden

commit sha 23fa5693eadd5a98f84ebc735067d63dc5771867

[FIX] base_vat: properly checks NL VAT numbers In 12.0+ when adding an NL VAT number on a contact without specifying the country as Netherlands, an error shows the VAT number as not valid. This is because the method to check specifically NL VAT numbers requires the complete VAT number with country code, when the country code isn't always provided. With this commit, we allow the check_vat_nl method to take the NL VAT number as argument, with or without the country code. opw-2536261 closes odoo/odoo#72356 X-original-commit: 75cfe3f484bd56723b182def09141d929a3169a1 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com> Signed-off-by: pvh-odoo <SwagSamaSempai@users.noreply.github.com>

view details

Odoo Translation Bot

commit sha 47ed3a2427d6f19bffa99100008b60963d947ed3

[I18N] Update translation terms from Transifex

view details

Goffin Simon

commit sha b0fd29673e13ba459ce86d299eb33928efbaf60b

[FIX] purchase_stock: UOM Error when running scheduler Steps to reproduce the bug: - Let's consider two uom category C1, C2 - Let's consider two uom U1 with category C1 and U2 with category C2 - Let's consider two products P1 with uom U1 and P2 with uom U2 - Create a reordering rule R for P1 - Run the scheduler (PO line L will be generated) - Go to Reordering rule R and change the product to P2. - Run the scheduler Bug: A traceback was raised in function _quantity_in_progress beacause uom of L is not in the same category of P2 opw:2557562 closes odoo/odoo#72274 Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

view details

Adrian Torres

commit sha ed831abd7d91ee873a1a92ecea2de316a025754f

[IMP] tests: partially backport classCleanups from CPython 3.8 This commit partially backports bpo-24412, which allows the definition of class cleanups (addClassCleanup) and module cleanups (omitted), similar to instance cleanups (addCleanup). This is useful for tests that override unittest's setUpClass and could crash during its execution: If this happens, it is possible that a bunch of crap is left in the database or even worse, the cursor becomes completely fucked; Thanks to the addClassCleanup, we can undo the damage done by the setUpClass. Another benefit is that it is called unconditionally after tearDownClass is called, so it can also be called as a replacement and/or safer tearDownClass.

view details

Adrian Torres

commit sha c6c8c84a6bf3c99bb4d7d80263a41782f058acb2

[IMP] tests: use addCleanup and addClassCleanup where useful This commit takes advantages of the features added in the parent commit to have better/cleaner tests. closes odoo/odoo#72391 Signed-off-by: Adrian Torres (adt) <adt@odoo.com>

view details

Achraf (abz)

commit sha e0a63a94768621af573d4199d757b23f5abb44fa

[FIX] web: Prevent quick create from closing after text selection There is a function allowing to close the quick create if we click outside the element. `RecordQuickCreate._onWindowClicked` Except that this function is triggered in a "click" event, so if we click on the quick create element and drag the mouse outside, it will detect that we are outside and close the quick create. This manipulation can happen when you want to select text with the mouse. This PR prevents this behavior by detecting when a click is from the quick create opw-2558932 closes odoo/odoo#72217 X-original-commit: 75538bf2a36aa91df8b183ac21ae99a174e1c2fa Signed-off-by: Achraf <abz-odoo@users.noreply.github.com>

view details

Nicolas Martinelli

commit sha 78727249e281b17bda9ae4c2c7131030348ca2a3

[FIX] website_blog: disallow multi-tag for bot indexation Partial backport of 0f2cada32319b3910d6ace6d412cfa94a646c9c7 closes odoo/odoo#72163 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

view details

Xavier Morel

commit sha b758f798e39e8cb3c77cf60d09ef10e2e8e3ddd0

[FIX] core: don't break import on files triggering UnicodeEncodeError The import logging (ish) assumes that if an exception has at least 2 args the second arg is metadata added by the callee. As it turns out, `UnicodeEncodeError` has *five* arguments, none of which is added by us. So if encoding something fails during the process (e.g. because the file contains a lone surrogate, which leads to the database insert failing when psycopg2 tries to encode the query to UTF8), then the `_log` function itself will fail, yielding a very unhelpful error of: dictionary update sequence element #0 has length 1; 2 is required (because we tried to update a dict using a string). This issue occurs only during *field conversion* and most fields have no need to interact with the database (so don't need to encode the value, which is what fails), however it is a problem when the invalid string is used as a record name to look for (e.g. an m2o). Further improve the experience by converting the UnicodeEncodeError to a ValueError using the stringified UEE: `_log` assumes the first argument to the exception is an error message of some sort, but for UnicodeError subclasses it's just the encoding involved in the error (here `utf-8`), which doesn't really serve as an error message. Stringifying the exception generates a complete error message which is quite a bit more helpful. Issue 2480064 closes odoo/odoo#72395 X-original-commit: a24fe7ff06a03e4a4b477b30ee3feb0ec06a7d0a Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

view details

alt-odoo

commit sha 4fc2ec31861d4602357f130066ec3507b96d8dc8

[FIX] mrp_account: correctly retrieve rounding factor of currency The company is not mandatory on the analytic account, and the currency on it is a related field to the currency of that company, if set. In case it is not set, we should add a default fallback on the currency of the company of the manufacturing order. closes odoo/odoo#72344 Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

view details

Adrien Widart

commit sha 58c4d6fbdf389385086614712065832646835f7c

[FIX] payment_sips: prevent clearing the session cookie When buying a product on website shop, after the payment with SIPS, the page is redirected to an Error message: "We are not able to find your payment, but don't worry. You should receive an email confirming your payment in a few minutes. If the payment hasn't been confirmed you can contact us." To reproduce the error: 1. In Payment Acquirers, enable Sips 2. Go on website shop 3. Add a product to the cart, Checkout 4. Pay with Sips - Visa card number: 4100000000000000 5. Back to Web-shop, if the payment has been successfully processed, repeat steps 2 -> 4 Error: The message "Your payment has been successfully processed. Thank you!" is not displayed. Instead, the message "We are not able [...] you can contact us." is displayed. This message is displayed when: https://github.com/odoo/odoo/blob/5945806c151b13d9d4cc13aa0a6c96a6b1bbad5f/addons/payment/controllers/portal.py#L65-L69 i.e., when the transactions list is empty. Here is how to get the list: https://github.com/odoo/odoo/blob/5945806c151b13d9d4cc13aa0a6c96a6b1bbad5f/addons/payment/controllers/portal.py#L38-L42 It uses the session of the request. The cookie `session_id` is used to identify the current session. However, after the payment on SIPS, the page is redirected to `/payment/sips/dpn` with a POST request. Since the session cookie has the attribute `SameSite=Lax` and the HTTP request is a POST, the cookie will be filtered out: https://drive.google.com/file/d/1xfx3YWkfonO3nK-8Rew45uSoR4lkpjpY/view?usp=sharing (Browser information: This cookie didn't specify a "SameSite" attribute when it was stored and was defaulted to "SameSite=Lax," and was blocked because the request was made from a different site and was not initiated by a top-level navigation. The cookie had to have been set with "SameSite=None" to enable cross-site usage) As a result, the server creates a new one. This is the reason why the transactions list is empty: the list is based on a new session. Adding the attribute `save_session = False` to the route will prevent the server from creating a new session cookie and add it in the POST response. OPW-2518377 closes odoo/odoo#72434 X-original-commit: b60e1574ede3cf2944d2dfb4bbff9af2f5058841 Signed-off-by: Antoine Vandevenne (anv) <AntoineVDV@users.noreply.github.com> Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>

view details

MANALIMALPANI

commit sha 306352d26494af5bae29bd778889914ac1d0635b

[FIX] auth_ldap: fix LDAP error handling In order to ensure consistent results of all error conditions returned by the LDAP server, the _authenticate() method should return `False` for every kind of exception, not just for INVALID_CREDENTIALS. This is not actually relevant in 12.0 as the result is exactly the same, due to the way the `entry` variable is being initialized, but it will make the code path "visibly consistent" across all supported versions closes odoo/odoo#72455 X-original-commit: 24a3f669e5199c35849dabbf7b0d37f43b684538 Signed-off-by: Olivier Dony (odo) <odo@openerp.com>

view details

Adrien Horgnies

commit sha 2b15d35cf97a650a27c7973e9ecd76d87be3dd9b

[IMP] payment_stripe: support webhooks Allow configuring a webhook in Stripe to send s2s notifications to Odoo when a Checkout payment is completed. Note that SetupIntent and PaymentIntent events are not listened to, since they are handled 'live' with the customer actively present; the main use case for Stripe webhooks is a Checkout session that gets interrupted before the customer is redirected to Odoo (e.g. network loss, browser crash, closing the tab, etc.). The webhook should be configured to send its events to <base_url>/payment/stripe/webhook and should only subscribe to checkout.session.completed events to avoid spamming the Odoo server with useless notifications. opw-2488452 opw-2451463 opw-2449738 BACKPORT of commit: dc4f6ad04f8bf3800c650d878b08e44775b95628 Should not be merged beyond 14.0 (14.0 excluded) closes odoo/odoo#71558 X-original-commit: 443da3aa32efba2805159e6496c0b55fb1f48b2a Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

view details

Xavier Morel

commit sha 798d542c1076525f8437f225583d587d120d4e97

[FIX] base_import: ensure errors are always reported Import errors don't necessarily have the `rows` metadata (they may not have been enriched with this information if they're high level recovery). The back2basics error handling changes did not properly handle this situation, so it was possible to end up in situations where the display of error information would silently fail due to the template failing to render. As a result the import (or test) would look like it'd succeeded despite that not being the case. Add the condition to the error multi template, similar to the error single one. Issue 2480064 (kinda, this problem was discovered while working on it though strictly speaking it's completely separate). closes odoo/odoo#72354 Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

view details

Romain Derie

commit sha 9aaa792f48fc74fe759e74c8ceef48496e766309

[FIX] website: safely access menu recordset Introduced with 7fb016f9966b [0] access could crash, recordset could be empty after `filtered`. Step to reproduce: - Add admin group to website top level menu (Website > Debug > Menu) - Try to access frontend as non admin opw-2573763 task-2574346 closes odoo/odoo#72359 Signed-off-by: Romain Derie <rdeodoo@users.noreply.github.com>

view details

push time in 19 days

PullRequestReviewEvent

push eventvauxoo-dev/stock-logistics-barcode

Nhomar Hernández

commit sha 9366d42ff448f6fd8c99708ffa2a839d7083ace2

clean

view details

push time in 2 months

push eventvauxoo-dev/stock-logistics-barcode

Nhomar Hernández

commit sha 518c1565e900411c37ec3d57c43a6d8ca226edd5

[FIX] Remove some warnings and unecessary string on field definitions

view details

push time in 2 months

create barnchVauxoo/edicionesfiscales

branch : theme

created branch time in 3 months