profile
viewpoint
Nikolai Hellwig nhellwig METRO Markets GmbH Düsseldorf, Germany

nhellwig/celect 0

Simple Rust Library for selection in commandline applications

nhellwig/Kluent 0

Fluent Assertion-Library for Kotlin

nhellwig/surf 0

Surf the web – HTTP client framework

nhellwig/tide 0

Serve the web – HTTP server framework

nhellwig/tokio-openssl 0

OpenSSL bindings for Tokio

nhellwig/topgrade 0

Upgrade everything

PR opened sonph/onehalf

Italicize comments in Vim

Italicized comments are popular for Vim users and IMO they look pretty good. Screen Shot 2020-11-28 at 8 59 38 AM

This won't have any effect on terminals that don't support italics.

+2 -2

0 comment

2 changed files

pr created time in 2 days

issue openedsonph/onehalf

Please add onehalflight theme for lighline.

There is only onehalfdark theme now.

created time in a month

issue openedsonph/onehalf

Links highlight in markdown (vim)

Onehalf colorscheme under neovim is missing highlighting of markdown links. I mean:

[Destination](https://page.url)

is rendered as plain text without any change or emphasis.

created time in a month

issue openedsonph/onehalf

Suggestions

Atom Editor Tilix Terminal

created time in 2 months

issue closedsonph/onehalf

VIM NonText Color should match be less visually intrusive

The current setting call s:h("NonText", s:fg, "", "") Should really be a darker color closer the the background color for improved readability/usability. Something even closer to the comment color would work, but I'm personally using: hi NonText guifg=#474d59 ctermfg=237 and it's a massive improvement.

OLD: image

CHANGE SUGGESTION: image

closed time in 2 months

RussBrown00

issue commentsonph/onehalf

VIM NonText Color should match be less visually intrusive

Fixed in #97 🍻

RussBrown00

comment created time in 2 months

push eventsonph/onehalf

Russell Brown

commit sha 89923117bc49dd1e0c6b7fdd34bc6dc4d425fe1f

Reduced contrast on non-text characters in VIM on both light & dark (#97)

view details

push time in 2 months

PR merged sonph/onehalf

Reduced contrast on non-text characters in VIM on both light & dark

This PR reduces the contrast between non-text and regular character colors

Dark Half After Change

Screen Shot 2020-10-14 at 5 13 33 PM

Light Half Afer Change

Screen Shot 2020-10-14 at 5 14 26 PM

+6 -4

6 comments

2 changed files

RussBrown00

pr closed time in 2 months

pull request commentsonph/onehalf

Reduced contrast on non-text characters in VIM on both light & dark

Looks good to me, thanks!

NP. Thanks for the theme. I assume you'll merge -- I can't

RussBrown00

comment created time in 2 months

pull request commentsonph/onehalf

Reduced contrast on non-text characters in VIM on both light & dark

I've updated the PR, hopefully, those changes are closer to desire. I've also moved the NonText next to WhiteSpace and they both use the same color palatte.

RussBrown00

comment created time in 2 months

pull request commentsonph/onehalf

Reduced contrast on non-text characters in VIM on both light & dark

No strong opinions from my side as long as the whitespace markers are not the same as the text :)

RussBrown00

comment created time in 2 months

pull request commentsonph/onehalf

Reduced contrast on non-text characters in VIM on both light & dark

hl-Whitespace is a thing in neovim (but not vim).

Hmm actually after looking closely at your screenshots I have to agree that the lighter colors work better, especially on comment lines in the light theme. I can go with option 1. The difference isn't that pronounced in the dark theme, can we pick another lighter or darker color here? @kdungs if you have any opinions.

Also, cterm = 237 is the same as cursor line. Can you pick a different values? Refer to this 256 color table. 252 (#d0d0d0) for light theme and maybe 239 (#4e4e4e) for dark theme are closest to the colors you picked 🤔

RussBrown00

comment created time in 2 months

issue commentsonph/onehalf

YouCompleteMe (Vim plugin) Signature help popup is not readable

@sonph Thank you for looking into this!

gaborvecsei

comment created time in 2 months

pull request commentsonph/onehalf

Reduced contrast on non-text characters in VIM on both light & dark

Looks ok to me. Is it possible to use comment_fg instead? I'd prefer that we use a small set of colors and also that's consistent with Whitespace (line 125).

The color comment works, I preferred something lighter than the comments personally, but if you want to keep it small I'll change it. I don't think the Whitespace colorspace actually does anything anymore. I haven't had it effect anything in years.

RussBrown00

comment created time in 2 months

pull request commentsonph/onehalf

Reduced contrast on non-text characters in VIM on both light & dark

Looks ok to me. Is it possible to use comment_fg instead? I'd prefer that we use a small set of colors and also that's consistent with Whitespace (line 125).

RussBrown00

comment created time in 2 months

PR opened sonph/onehalf

Reduced contrast on non-text characters in VIM on both light & dark

This PR reduces the contrast between non-text and regular character colors

Dark Half After Change

image

Light Half Afer Change

image

+4 -2

0 comment

2 changed files

pr created time in 2 months

pull request commentsonph/onehalf

Introduce color for whitespace markers in Neovim.

Cool, thanks a lot for merging this :)

Cheers!

kdungs

comment created time in 2 months

pull request commentsonph/onehalf

Use gray for kitty color8

Makes sense. Thanks for merging. I love this color scheme. Good work.

jawang35

comment created time in 2 months

issue commentsonph/onehalf

vim diff highlighting

Much appreciated. TBH. I don't really love the look either and could likely be improved, but I got frustrated and moved on with "good enough for now". The idea came from how Meld does it and it seems like a great way to highlight the differences

image

opennomad

comment created time in 2 months

issue commentsonph/onehalf

[vim] Do you accept per-language tweaks?

No problem man, caught everyone off guard!

adrian5

comment created time in 2 months

issue closedsonph/onehalf

[vim] Do you accept per-language tweaks?

Vim color schemes can offer improved highlighting by targeting specific language tags. Are you open to PRs for that?

closed time in 2 months

adrian5

issue commentsonph/onehalf

[vim] Do you accept per-language tweaks?

Yes totally. Sorry for the late reply as I've been heads down working due to covid. Closing this but feel free to leave any questions or create PRs :) 🍻

adrian5

comment created time in 2 months

issue commentsonph/onehalf

VIM NonText Color should match be less visually intrusive

Yep totally agree with you. I haven't used vim in a while and don't enable :set list so I wasn't aware of that. If the comment fg color works, do you mind creating a pull request similar to #94?

RussBrown00

comment created time in 2 months

push eventsonph/onehalf

A. Schueler

commit sha 018f3329c82452c34de31cc557d906b87d47a63b

Update cursor color in wal light colorscheme (#95) This adapts the cursor color to match VSCode and other applications. Currently, the cursor color is very similar to the background, which makes editing longer commands a pain for the eyes.

view details

push time in 2 months

PR merged sonph/onehalf

Update cursor color in wal light colorscheme

This adapts the cursor color to match VSCode and other applications. Currently, the cursor color is very similar to the background, which makes editing longer commands a pain for the eyes.

+1 -1

0 comment

1 changed file

thraizz

pr closed time in 2 months

push eventsonph/onehalf

adrian5

commit sha 7a35ba5a986ccbc8bcf885642ba083233aeff5d7

Update README for modern vim ecosystem; fix lightline example (#87) Listing existing plugins is superfluous, as their users know them. Some of the listed ones are no longer maintained. vim-plug (and maybe dein.vim) appear to be the most popular ones, and the former is what most projects use in examples. The lightline example is slightly changed, as the `g:lightline` variable cannot be assumed to exist.

view details

push time in 2 months

PR merged sonph/onehalf

Update README for modern vim ecosystem; fix lightline example

Listing existing plugins in a color scheme repo is superfluous, and a maintenance burden. Vim users are aware of existing plugins and how to use them to install things. Some of the listed ones are no longer maintained. vim-plug (and maybe dein.vim) appear to be the most popular ones, and the former is what most projects use in examples.

The lightline example has been slightly changed, as the g:lightline variable cannot be assumed to exist.

+15 -18

0 comment

1 changed file

adrian5

pr closed time in 2 months

push eventsonph/onehalf

Jason Wang

commit sha 0cb1197d7c6c6a1ef57d929a292ce974128bf4a0

Use gray for kitty color8 (#92)

view details

push time in 2 months

PR merged sonph/onehalf

Use gray for kitty color8

For kitty, color8 blends in with the background so that it's impossible to read. This is problematic in the example below with mocha test errors for Node.js:

Screen Shot 2020-09-15 at 11 41 45 PM

I chose the vim onehalf-dark mono2 color to make this legible. Here's the result with the same example:

Screen Shot 2020-09-15 at 11 41 13 PM

+1 -1

1 comment

1 changed file

jawang35

pr closed time in 2 months

pull request commentsonph/onehalf

Use gray for kitty color8

Sorry for the late reply, this looks fine to me.

I made the decision that I want brights to be the same as regular colors, so bright black is the same as the black background color. Probably should revisit that... I'm a light theme user so this problem wasn't noticeable.

Anyway, merging, thanks!

jawang35

comment created time in 2 months

more