profile
viewpoint
Nestor G Pestelos Jr ngpestelos AELOGICA Philippines https://nestor.wtf

startedmhx/dwarfs

started time in 12 minutes

push eventsbt/sbt

Erlend Hamnaberg

commit sha 341e09a07eb374f30b656bffb79ef4adf091f928

Make it possible to not write the bsp connection file Made the bspConfig task dependendant on the bspConfig value. Changed the bspConfig setting to use a attributeKey so we can use it in the server as well.

view details

Erlend Hamnaberg

commit sha a554976ffb588202f2f83d875290ac62ca78e9e6

Update main/src/main/scala/sbt/internal/server/BuildServerProtocol.scala Change from review Co-authored-by: Adrien Piquerez <adrien.piquerez@gmail.com>

view details

eugene yokota

commit sha 2bbbcfae77b53e89cea525e3f7b68da8ea142a96

Merge pull request #6174 from hamnis/bsp_connection_file_possibly_disabled Make it possible to not write the bsp connection file

view details

push time in 33 minutes

PR merged sbt/sbt

Make it possible to not write the bsp connection file area/server

Made the bspConfig task dependendant on the bspConfig value. Changed the bspConfig setting to use a attributeKey so we can use it in the server as well.

I think this should fix #6066

+33 -9

3 comments

6 changed files

hamnis

pr closed time in 34 minutes

issue closedsbt/sbt

sbt 1.4.2 BSP disabled still generates .bsp/sbt.json which causes problems with IntelliJ IDEA

steps

Bloop sbt-plugin installed

bloopExportJarClassifiers in Global := Some(Set("sources"))
bspEnabled := false

run sbt bloopInstall

problem

.bsp/sbt.json is till generated which intellij tries to read and that causes some problem

expectation

Do not generate any files in .bsp

closed time in 34 minutes

hamnis

issue closedrails/rails

Rake DB tasks don't properly initialize environment when switching from development to test env

This is a reopening of a task #32926

Original message

When executing Rake DB tasks in development environment they are also executed in test environment (see). This environment change doesn't prompt the usual intialization but the existing environment config is used, not taking into account that it can dynamically change between environments.

Why is this a problem?

1, Consider the following Rails feature:

The config/database.yml file can contain ERB tags <%= %>. Anything in the tags will be evaluated as Ruby code. You can use this to pull out data from an environment variable or to perform calculations to generate the needed connection information. For example having different values in test env will not be taken into account in this case. This is known to cause issues with dotenv: bkeepers/dotenv#302.

2, AFAICT Rails.env and DatabaseTasks.env are not set correctly after the env change. Amongst other possible issues I believe is the root cause of #26731 which is being solved by hardcoding test env instead of using current_environment.

3, I would imagine there are further implications which I didn't discover.

Steps to reproduce

I reproduce the dotenv issue with a dummy project in the gem dotenv_rails_db_tasks_fix (see db config, .env.test, .env.development, test)

Expected behavior

When switching environments the new one is properly initialized at least in a way to respect existing Rails features (i.e. set env variables such as Rails.env and reload database.yml).

Actual behavior

The existing environment config is used, not taking into account that it can dynamically change between environments.

System configuration

Rails version: Rails 5.1.6

Ruby version: ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-darwin17]

closed time in 2 hours

romansavrulin

startedtensorflow/models

started time in 2 hours

startedtinacms/tina-starter-alpaca

started time in 2 hours

PR opened rails/rails

Change form_with to generate non remote forms by default

Summary

form_with would generate a remote form by default which confused users because they were forced to handle remote requests.

You can still enable remote forms by setting config.action_view.form_with_generates_remote_forms to true.

Other Information

I'm not sure if we can still get this into 6.1, but I've add the configuration change to the 6.1 framework defaults as well. Fixes: #39711

+23 -7

0 comment

7 changed files

pr created time in 6 hours

startedXinyuan-LilyGO/LilyGO-T-Beam

started time in 6 hours

PR opened rails/rails

Set default for datetime precision on sqlite3

Summary

Fixes https://github.com/rails/rails/issues/40647. It sets default for datetime precision on sqlite3. <!-- Provide a general description of the code changes in your pull request... were there any bugs you had fixed? If so, mention them. If these bugs have open GitHub issues, be sure to tag them here as well, to keep the conversation linked together. -->

<!-- If there's anything else that's important and relevant to your pull request, mention that information here. This could include benchmarks, or other information.

If you are updating any of the CHANGELOG files or are asked to update the CHANGELOG files by reviewers, please add the CHANGELOG entry at the top of the file.

Finally, if your pull request affects documentation or any non-code changes, guidelines for those changes are available here

Thanks for contributing to Rails! -->

+8 -0

0 comment

1 changed file

pr created time in 9 hours

fork gjaldon/cockroach

CockroachDB - the open source, cloud-native distributed SQL database.

https://www.cockroachlabs.com

fork in 11 hours

issue commentrails/rails

ActionCable 6.1.0rc1 issue

Adding psych 3.2.0 to my Gemfile did not help me, but symbolizing the environment names in cable.yml did.

rusikf

comment created time in 12 hours

fork gjaldon/kubernetes

Production-Grade Container Scheduling and Management

https://kubernetes.io

fork in 12 hours

startedimadtoubal/Pytorch-Flask-Starter

started time in 12 hours

issue commentrails/rails

PostgreSQL inet column - wrong behaviour

This issue has been automatically marked as stale because it has not been commented on for at least three months. The resources of the Rails team are limited, and so we are asking for your help. If you can still reproduce this error on the 6-0-stable branch or on master, please reply with all of the information you have about it in order to keep the issue open. Thank you for all your contributions.

vihai

comment created time in 13 hours

startedmeshtastic/Meshtastic-device

started time in 13 hours

startedLilyGO/TTGO-T-Beam

started time in 14 hours

issue closedrails/rails

ActiveSupport::TimeWithZone#dst? always returns true

Steps to reproduce

Run rails c for a standard rails application.

Execute

Time.find_zone!('Berlin').parse('2020-01-01').dst?

Expected behavior

dst? should return false for January as this is not within daylight saving time.

Actual behavior

[29] pry(main)> Time.find_zone!('Berlin').parse('2020-01-01').dst?
=> true

System configuration

Rails version: 6.0.3.4

Ruby version: 2.7.2

OS: alpine3.12

The application is running in docker. This is the Dockerfile:

FROM ruby:2.7.2-alpine3.12
RUN apk add --no-cache --update build-base linux-headers git postgresql-dev tzdata less
WORKDIR /my-app
COPY Gemfile* ./
RUN bundle install
COPY . .

closed time in 15 hours

drssdinblck

issue commentrails/rails

ActiveSupport::TimeWithZone#dst? always returns true

@drssdinblck It sounds like you may be experiencing tzinfo/tzinfo#120 (see also #40427). Can you upgrade your tzinfo gem, and see if that resolves the problem?

drssdinblck

comment created time in 15 hours

pull request commentrails/rails

Add supports_advisory_locks detection for Strict SQL Mode in abstract_mysql_adapter.rb

Opt-in configuration gives more control over the behaviour than auto-detection.

Since when is Rails not convention over configuration? If a novice programmer starts programming in Rails and is given ie. Percona XtraDB Cluster then they will hit this snag without even writing their first line of code. This is exactly what deters new adopters and should not be overlooked.

lmojzis

comment created time in 15 hours

GollumEvent
GollumEvent
GollumEvent
GollumEvent

startedziglibs/repository

started time in 18 hours

pull request commentrails/rails

Improve guide for configuring pool size for cache store.

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

tgxworld

comment created time in 18 hours

startedbbqsrc/bare-io

started time in 18 hours

startedcheckra1n/macs

started time in 18 hours

startedZHKKKe/MODNet

started time in 18 hours

more