profile
viewpoint

Exiv2/exiv2 552

Image metadata library and tools

neheb/apinger 0

Alarm Pinger

neheb/btrfs-progs 0

Development of userspace BTRFS tools

neheb/coova-chilli 0

CoovaChilli is an open-source software access controller for captive portal hotspots.

neheb/core 0

Dovecot mail server

neheb/cryptography 0

cryptography is a package designed to expose cryptographic primitives and recipes to Python developers.

neheb/Csocket 0

Asynchronous TCP socket classes

neheb/DAWN 0

Decentralized WiFi Controller

neheb/dcwapd 0

Dual Channel Wi-Fi Access Point Daemon

neheb/domoticz 0

Open source Home Automation System

push eventneheb/gerbera

Karl Straußberger

commit sha 58e93ac21418e214e0c0a54a236356d528b69b2a

Add flag to hide dynamic content on Samsung devices Solves issue from #2064

view details

Rosen Penev

commit sha 963556bea1dba0611f6af7744bae443daffd6194

WIP: add meson Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 5b72de221dec4deb4fcc92f344c59700187dab65

use system cxxopts Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 41a1575142ec5370041496ddbd5f7cf8e73f5955

simplify setValue template if constexpr can be used here. fs::path was kept as it can be implemented as std::wstring. Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 45ff29df3e1bea2ff8ec387d5301420a8b035a1c

add .clang-tidy file Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 57bf9b519eb38362833a1725ee4dbdb2c18df518

temp

view details

Rosen Penev

commit sha e217c878f1ca9a6ced3d1494e6d79dba66611290

const functions Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha ad8b8b1b3d3573686e3a6f8e59ba327ae8281e26

remove several unique_ptrs SonarLint reports: If you use std::unique_ptr<T> const & for a function parameter type, it means that the function will not be able to alter the ownership of the pointed-to object by the unique_ptr: It cannot acquire ownership of the pointed-to object (this would require a parameter of type std::unique_ptr<T>) It cannot transfer the object ownership to someone else (this would require a std::unique_ptr<T> &). That means the function can only observe the pointed-to object, and in this case passing a T* (if the unique_ptr can be null) or a T& (if it cannot) provides the same features, while also allowing the function to work with objects that are not handled by a unique_ptr (E.G. objects on the stack, in a vector, or in another kind of smart pointer), thus making the function more general-purpose. Defauled move constructors for ActionRequest in order to mimic unique_ptr behavior. Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 2609c958b7c6995111097fba86c9e8bfc97ad5c7

const stuff for unique_ptr removal Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 2e63adc1ec798e970d5ec1b1d86691f7590d5c28

fix matroska memory leaks Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 0cac211e81a722aa7678096f1a2fed04bb8ad454

const ref conversion Try to fix memory leak. Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 546eead24e35af4a24ec18f040d035cac6a20934

add const to get functions Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

push time in an hour

issue commentgerbera/gerbera

Remaining memory leaks

well they are sorted by amount leaked :).

neheb

comment created time in 14 hours

issue openedgerbera/gerbera

Remaining memory leaks

https://gist.github.com/neheb/10cfc490b163bbee492231ba682cce7d

from a quick glance, these don't seem to be easily fixable. Not quite sure.

created time in a day

pull request commentopenwrt/openwrt

Build OpenWRT on MacOS arm64 (Apple Silicon)

Needing to disable ASLR sounds like a bug.

svlobanov

comment created time in a day

push eventopenwrt/packages

Oskari Rauta

commit sha 91c7f6e6c086c57057570289cf2ca0f7bfeb8992

slirp4netns: new package Signed-off-by: Oskari Rauta <oskari.rauta@gmail.com>

view details

push time in a day

PR merged openwrt/packages

Reviewers
slirp4netns: new package

Signed-off-by: Oskari Rauta oskari.rauta@gmail.com

Maintainer: Oskari Rauta / @oskarirauta Compile tested: x86_64, recent git Run tested: x86_64, recent git

Description: slirp4netns is required for rootless containers (at least on podman) for networking. slirp4netns requires libslirp, which is in PR #17197

+39 -0

5 comments

1 changed file

oskarirauta

pr closed time in a day

pull request commentgerbera/gerbera

WIP: add meson

Updated with subprojects for libupnp, libebml, and libmatroska. They have been great in finding memory defects in gerbera with memory sanitizer.

The libupnp one is incomplete but works well enough for gerbera's purposes.

neheb

comment created time in a day

push eventneheb/gerbera

Rosen Penev

commit sha d4439fc7998a3e90f0d25b3563f21e5c8849590c

ffmpeg: const additions Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Christian Weiske

commit sha 23633073c8ac36614a38a013d48e226235a3000f

CS: Remove trailing whitespace

view details

Christian Weiske

commit sha 6abbbeb9e2880e5849474f10b86c942e8416aa3e

Hints for writing own import scripts Resolves: https://github.com/gerbera/gerbera/issues/2181

view details

Karl Straußberger

commit sha bb04fdf1efedfe1280a4f6800c35e9a48d4dbdf7

Attempt to close leak

view details

Rosen Penev

commit sha a996779cc95e8fc588e3b5faa7474fe1f279c3f3

remove random header Seems the rng stuff was removed at some point. Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 46792cb77edd7f13e5ba579f031ebdf3b37b3bee

jpeg_resolution: use some std::byte Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 7ede4f006d8c8683b87ec085c451ad096892d86f

remove some more headers Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Karl Straußberger

commit sha d4864c7db32c21e4d548936c1ca536777d6adcad

Add configuration for extensions to ignore on import

view details

Karl Straußberger

commit sha 99d5c10fe308d94cb0b6dc7cadf913a8561e08b8

Warning for sort by metadata

view details

Rosen Penev

commit sha 4bdb0d29d26106221831ab42be9716f1d84e85ef

remove some uninitialized variables Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha b41a53c1c74313d0912f59050893ef1ca0e39fb6

return std::pair for stripLocationPrefix avoids pointer shenanigans. Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Ian Whyman

commit sha a05f00397cd109649b3fa0d2d75497a17ba033c8

MySQL fix warnings with glibc 2.34, pass a real pointer Closes: https://github.com/gerbera/gerbera/issues/2175

view details

Rosen Penev

commit sha 33475ad6f1df9f862a2d2bb280e6cd6f5880332e

fix some implicit conversion warnings clang-tidy throws bugprone-implicit-widening-of-multiplication-result Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 2933928b28c443cba214b8803fb2f5beac38afa7

remove custom destructor In the one place where this is used, close() is called anyway. Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 9a3976be0be93adc7c4f7bb8b4adf30296e0e562

remove FileIOHandler destroctor It calls close() which is an empty function. Removing it like this uses a defaulted destructor. Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha a3d819224b707c52fc35cb05b4251db9d2dcb900

use operator < instead of startswith Avoids unnecessary conversions. Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 2af855b0d1f165aeef0a9755de01273b1486418f

use auto Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Karlchen

commit sha b0b1e049368ca41b0e41126d2fef5a0db67d7a0f

Implement sort on metadata fixes #2215

view details

Rosen Penev

commit sha 666f1744d487f433291a23980d1992ab90e0965e

cast to proper type Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha a4b2b521adf3fb01176a828c87982e1e845ced90

various fixes Mostly unused exception variables. Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

push time in a day

push eventneheb/gerbera

Rosen Penev

commit sha 2530f5cc860d511a332ee04493c174a8ff473f47

use auto with cast Avoids bugprone-implicit-widening-of-multiplication-result warning. Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha e85829d85df31b47de99844625cf3ba6a6d58fe6

WIP: add meson Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 651a332493f2acf4ed7559044e1c72ebc6ec3403

use system cxxopts Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 51e1dd421a0a8b8e567bbff0f95dac7043802a25

simplify setValue template if constexpr can be used here. fs::path was kept as it can be implemented as std::wstring. Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha dd6e5917945b280620c7defe643d8fb4835067c0

add .clang-tidy file Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 4378ba9aeb5f98f1b3cafc9bee708a264451c858

temp

view details

Rosen Penev

commit sha e3566eb469d9267df72ccc2543925abf44b98d7a

const functions Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 6b603be0a1c64501150d4c2962a228562360a6eb

remove several unique_ptrs SonarLint reports: If you use std::unique_ptr<T> const & for a function parameter type, it means that the function will not be able to alter the ownership of the pointed-to object by the unique_ptr: It cannot acquire ownership of the pointed-to object (this would require a parameter of type std::unique_ptr<T>) It cannot transfer the object ownership to someone else (this would require a std::unique_ptr<T> &). That means the function can only observe the pointed-to object, and in this case passing a T* (if the unique_ptr can be null) or a T& (if it cannot) provides the same features, while also allowing the function to work with objects that are not handled by a unique_ptr (E.G. objects on the stack, in a vector, or in another kind of smart pointer), thus making the function more general-purpose. Defauled move constructors for ActionRequest in order to mimic unique_ptr behavior. Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha a6ab388fb72802cbef8a30364e64f84ba5f00d12

const stuff for unique_ptr removal Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 1d1853994be8830b73314c67c3e291329dad6ef9

fix matroska memory leaks Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

push time in a day

delete branch neheb/gerbera

delete branch : 3

delete time in a day

push eventneheb/gerbera

Rosen Penev

commit sha 9b34adf41aec17db41c712fdaa0b1a5ae37e4818

replace insert with emplace Reported by SonarLint. Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha e5289675b71133f99e84bc240110c3233c5482bf

std::string_view conversions Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 71d845b912b7b038c8832fd9751ca40089cadcca

add const to various get functions Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 7e9df9e6bcfdd817e60517c57e99ce3c29ab973f

grb_fs: run through clang-tidy used std::move Change return type to uintmax_t as that is the type returned by file_size(). Switch to fseeko to avoid potential 32-bit problems. Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 187056fc06620845f79328e8bc51d58de168a00a

small std::array conversion Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 539cf137d2f09403105b3da872bfbc02a40d02f0

Add two moves. Avoids copies. Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha b40f13b3634e806cbd1e6fe121f814a9838ccc4e

avoid some shared_ptr copies Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 770d7d01c502a956cf152c9e19bde1eb4c8fc911

remove old libupnp compatibility Minimum version is 1.14 now. Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha f780ddc5e94e2796929e9ca78100007e25b606d5

shared to unique_ptr conversions No copies are needed. Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 5e38fdaf1db06f00c0fb38bc067ffa10b4e16132

convert string to fs::path Avoids conversions Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 29af156f05927b37de314e552b30ff184060229c

WIP: add meson Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha ea81f25f347472732156e31ce802ffc188292b38

use system cxxopts Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 03d7bc5bade7729963543e5a33054de664845e3f

simplify setValue template if constexpr can be used here. fs::path was kept as it can be implemented as std::wstring. Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 90f7e97876f4d8e91a249b8df52d44474dca6a77

add .clang-tidy file Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha d2fad343aee9a65642338177eba396caaf4dc6e6

temp

view details

Rosen Penev

commit sha fa7f4d481c9a540a5959ad12fae37e50621f4e30

const functions Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha e3d6120a729745041a067aa6199c8ac48625bb7f

remove several unique_ptrs SonarLint reports: If you use std::unique_ptr<T> const & for a function parameter type, it means that the function will not be able to alter the ownership of the pointed-to object by the unique_ptr: It cannot acquire ownership of the pointed-to object (this would require a parameter of type std::unique_ptr<T>) It cannot transfer the object ownership to someone else (this would require a std::unique_ptr<T> &). That means the function can only observe the pointed-to object, and in this case passing a T* (if the unique_ptr can be null) or a T& (if it cannot) provides the same features, while also allowing the function to work with objects that are not handled by a unique_ptr (E.G. objects on the stack, in a vector, or in another kind of smart pointer), thus making the function more general-purpose. Defauled move constructors for ActionRequest in order to mimic unique_ptr behavior. Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 07a8576dc7a8837bc602351dfcdbdc4aa202d710

const stuff for unique_ptr removal Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha 3bfab9a60fa16781328929dfb7c8c546293dec45

fix matroska memory leaks Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha ead267d2257185bda4777582aa735c6e12f1f5af

use auto with cast Avoids bugprone-implicit-widening-of-multiplication-result warning. Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

push time in a day

delete branch neheb/gerbera

delete branch : 4

delete time in a day

delete branch neheb/gerbera

delete branch : 2

delete time in a day

pull request commentgerbera/gerbera

use auto with cast

So clang-tidy suggests two fixes.

auto dynId = std::int32_t(std::uint64_t(-(parent->getID() + 1) *) 10000 - count);

and

auto dynId = std::int32_t(std::int64_t(-(parent->getID() + 1)) * 10000 - count);

I think the latter is better. Probably the issue is that count is a size_t and getID returns an int.

neheb

comment created time in a day

pull request commentopenwrt/packages

slirp4netns: new package

arc is failing because of libseccomp. There are two ways to fix. Either set DEPENDS to @!arc or use a solution like the following: https://github.com/openwrt/packages/blob/master/utils/lxc/Config.in#L40

oskarirauta

comment created time in a day

push eventneheb/gerbera

Rosen Penev

commit sha 770d7d01c502a956cf152c9e19bde1eb4c8fc911

remove old libupnp compatibility Minimum version is 1.14 now. Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha f745f4893238341f1ecb4c169a104160743f6cde

convert string to fs::path Avoids conversions Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

push time in a day

pull request commentgerbera/gerbera

use auto with cast

btw removing the inner int64_t cast does not solve the warning.

neheb

comment created time in a day

pull request commentgerbera/gerbera

shared to unique_ptr conversions

Removed second commit and rebased.

neheb

comment created time in a day

push eventneheb/gerbera

Rosen Penev

commit sha 770d7d01c502a956cf152c9e19bde1eb4c8fc911

remove old libupnp compatibility Minimum version is 1.14 now. Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

Rosen Penev

commit sha ee3f8e0667aedfb8cee431b023d232aba99e4302

shared to unique_ptr conversions No copies are needed. Signed-off-by: Rosen Penev <rosenp@gmail.com>

view details

push time in a day

push eventopenwrt/packages

Oskari Rauta

commit sha 5b5873de74b4df9c9f3ef4d5f634781739214f5b

libslirp: new package Signed-off-by: Oskari Rauta <oskari.rauta@gmail.com>

view details

push time in a day

PR merged openwrt/packages

libslirp: new package

Signed-off-by: Oskari Rauta oskari.rauta@gmail.com

Maintainer: Oskari Rauta / @oskarirauta Compile tested: x86_64, recent git Run tested: x86_64, recent git

Description: libslirp is required by slirp4netns which is used in containerised systems, such as podman when used in rootless-mode for networking. slirp4netns is in it's own pr #17198.

+51 -0

0 comment

1 changed file

oskarirauta

pr closed time in a day

Pull request review commentopenwrt/packages

libslirp: new package

+include $(TOPDIR)/rules.mk++PKG_NAME:=libslirp+PKG_VERSION:=4.6.1+PKG_RELEASE:=$(AUTORELEASE)++PKG_SOURCE:=$(PKG_NAME)-v$(PKG_VERSION).tar.gz+PKG_SOURCE_URL:=https://gitlab.freedesktop.org/slirp/$(PKG_NAME)/-/archive/v$(PKG_VERSION)

Ah I misread.

oskarirauta

comment created time in a day

PullRequestReviewEvent

Pull request review commentgerbera/gerbera

shared to unique_ptr conversions

 std::vector<std::shared_ptr<CdsObject>> SQLDatabase::browse(BrowseParam& param)             for (std::size_t count = 0; count < dynContent->size(); count++) {                 auto dynConfig = dynContent->get(count);                 if (parent->getLocation() == dynConfig->getLocation().parent_path() || (parent->getLocation().empty() && dynConfig->getLocation().parent_path() == "/")) {-                    int dynId = -(parent->getID() + 1) * 10000 - count;

Still complains. Will remove the second commit.

neheb

comment created time in a day

PullRequestReviewEvent

Pull request review commentgerbera/gerbera

convert string to fs::path

 void URLRequestHandler::getInfo(const char* filename, UpnpFileInfo* info)         UpnpFileInfo_set_FileLength(info, -1);     } else { #ifdef ONLINE_SERVICES-        std::string url = item->getFlag(OBJECT_FLAG_ONLINE_SERVICE) ? OnlineServiceHelper::resolveURL(item) : item->getLocation().string();+        fs::path url = item->getFlag(OBJECT_FLAG_ONLINE_SERVICE) ? OnlineServiceHelper::resolveURL(item) : item->getLocation();

What's interesting is getLocation() returns an fs::path

neheb

comment created time in 2 days

PullRequestReviewEvent

delete branch neheb/gerbera

delete branch : 1

delete time in 2 days

pull request commentopenwrt/openwrt

Add APK package building capabilities to OpenWrt

rm -rf feeds/packages/lang/lua-lzip

after that it compiles.

aparcar

comment created time in 2 days

pull request commentopenwrt/openwrt

Add APK package building capabilities to OpenWrt

/home/mangix/devstuff/openwrt/staging_dir/hostpkg/bin/lua5.1: ../src/genhelp.lua:246: module 'zlib' not found:
        no field package.preload['zlib']
        no file './zlib.lua'
        no file '/home/mangix/devstuff/openwrt/staging_dir/hostpkg/share/lua/5.1/zlib.lua'
        no file '/home/mangix/devstuff/openwrt/staging_dir/hostpkg/share/lua/5.1/zlib/init.lua'
        no file '/home/mangix/devstuff/openwrt/staging_dir/hostpkg/lib/lua/5.1/zlib.lua'
        no file '/home/mangix/devstuff/openwrt/staging_dir/hostpkg/lib/lua/5.1/zlib/init.lua'
        no file './zlib.so'
        no file '/home/mangix/devstuff/openwrt/staging_dir/hostpkg/lib/lua/5.1/zlib.so'
        no file '/home/mangix/devstuff/openwrt/staging_dir/hostpkg/lib/lua/5.1/loadall.so'
stack traceback:
        [C]: in function 'require'
        ../src/genhelp.lua:246: in function 'compress'
        ../src/genhelp.lua:259: in function 'dump_compressed_vars'
        ../src/genhelp.lua:300: in main chunk
        [C]: ?

sounds like lua-host is needed. I don't think the help database should be compressed.

aparcar

comment created time in 2 days

more