profile
viewpoint

emacs-lsp/dap-mode 773

Emacs :heart: Debug Adapter Protocol

nbfalcon/flycheck-projectile 5

Project-wide flycheck errors

nbfalcon/json5.el 1

Emacs library for parsing JSON5

nbfalcon/C-hello-world 0

A small C program that prints "Hello World!" to stdout, for use in bug reports.

nbfalcon/cargo 0

The Rust package manager

nbfalcon/ccls 0

C/C++/ObjC language server supporting cross references, hierarchies, completion and semantic highlighting

nbfalcon/company-box 0

A company front-end with icons

nbfalcon/company-mode 0

Modular in-buffer completion framework for Emacs

nbfalcon/dap-mode 0

Emacs :heart: Debug Adapter Protocol

nbfalcon/dap-mode-launch-json 0

Extends emacs with launch.json support.

push eventemacs-lsp/lsp-mode

yyoncho

commit sha ce6a38518655323b07e727abedd9f14fbaf6fbf4

deploy: 864dede317f4edf15f670859d771d19a7d650a58

view details

push time in 2 hours

push eventemacs-lsp/lsp-mode

Theodor Thornhill

commit sha 864dede317f4edf15f670859d771d19a7d650a58

Add new server settings to lsp-elm (#2538)

view details

push time in 2 hours

PR merged emacs-lsp/lsp-mode

Add new server settings to lsp-elm client

elm-language-server has released a new version, 2.0, and it adds some new settings to the server.

This commit provides those settings, as well as removing setting no longer in use.

+12 -7

0 comment

1 changed file

theothornhill

pr closed time in 2 hours

push eventemacs-lsp/lsp-mode

yyoncho

commit sha f12e975dfeeacc4f111aa445d81a632a6f1e83b0

deploy: 48648f3f745622dbe5a29db3d4ad23a0579e4a23

view details

push time in 2 hours

push eventemacs-lsp/lsp-mode

Damien Cassou

commit sha 48648f3f745622dbe5a29db3d4ad23a0579e4a23

Fix docstring of lsp--client-packages-required (#2539)

view details

push time in 2 hours

PR opened emacs-lsp/lsp-mode

Add new server settings to lsp-elm

elm-language-server has released a new version, 2.0, and it adds some new settings to the server.

This commit provides those settings, as well as removing setting no longer in use.

+12 -7

0 comment

1 changed file

pr created time in 4 hours

issue commentemacs-lsp/lsp-mode

File watches are created over-zealously

As an idea, it may be helpful to add a hook so that users can more easily customize which files to ignore (with more sophisticated logic than just regexps). Personally, I'd like to ignore everything according to .gitignore (via git-check-ignore) except for Cargo.lock.

hpdeifel

comment created time in 9 hours

issue commentemacs-lsp/lsp-mode

slow paredit

Not sure, is the performance issue related to clojure-lsp? enable lsp-log-io and check the log-io buffer and check how much time is taken between lsp-mode request and response

gdanov

comment created time in 12 hours

issue commentemacs-lsp/lsp-mode

slow paredit

I had typo in the lsp-enable-indentation var name so I never really disabled lsp identation...whit the correct var name it is disabled and performance is as expected.

gdanov

comment created time in 12 hours

issue commentemacs-lsp/lsp-mode

slow paredit

@yyoncho do you know how lsp-mode can slow down that? https://github.com/clojure-emacs/cider/issues/2747#issuecomment-762479602

gdanov

comment created time in 12 hours

issue commentemacs-lsp/lsp-mode

slow paredit

Did you confirm this happens even if lsp-mode is disabled?

gdanov

comment created time in 12 hours

issue commentemacs-lsp/lsp-mode

slow paredit

I can tell I'm having the same issue but was thinking it's something with my emacs setup, but it seems other people are with this problem too.

gdanov

comment created time in 12 hours

issue openedemacs-lsp/lsp-mode

slow paredit

Describe the bug when using clojure-lsp and paredit, paredit operations are very slow (few seconds)

To Reproduce emacs 27.1, latest lsp-mode and clojure-lsp, lsp-enable-identation nil, open clojure file, wait for lsp server to initialize and slurp-sexp for example

Which Language Server did you use clojure-lsp

OS osx

Error callstack here is the output of emacs profiler

- command-execute                                                 516  81%
 - call-interactively                                             516  81%
  - funcall-interactively                                         516  81%
   + helm-M-x                                                     417  65%
   - paredit-forward-slurp-sexp                                    99  15%
    - paredit-forward-slurp-into-list                              99  15%
     - indent-region                                               99  15%
      - apply                                                      99  15%
       - ad-Advice-indent-region                                   99  15%
        - #<compiled 0x4346481f>                                   99  15%
         - lsp-format-region                                       99  15%
          - let                                                    99  15%
           - lsp-request                                           96  15%

here is my initialization of lsp-mode

(use-package lsp-mode 
	;;:ensure t
	:quelpa ;(:stable t)
	:hook
	(clojure-mode  . lsp-deferred)
	:bind
	("C-c C-k" . #'cider-load-buffer)
	("C-c C-z" . #'cider-switch-to-repl-buffer)
	("C-c M-z" . #'cider-load-buffer-and-switch-to-repl-buffer)
	("C-c M-n" . 'cider-ns-map)
	;;("C-M-\\" . #'cider-format-buffer)
	;;("C-M-\\" . #'lsp-format-buffer)
	("C-c C-t t" . #'cider-test-run-test)
	("C-c C-t n" . #'cider-test-run-ns-tests)
	:commands
	(lsp lsp-deferred)
	:init
	(setq lsp-log-io nil
				lsp-server-trace nil
				;;lsp-enable-on-type-formatting nil
				;; see http://blog.binchen.org/posts/how-to-speed-up-lsp-mode.html
				gc-cons-threshold (* 100 1024 1024)
				read-process-output-max (* 1024 1024)
				treemacs-space-between-root-nodes nil
				company-idle-delay 0.0
				company-minimum-prefix-length 1
				)
	:config
	(setq lsp-enable-folding nil
				lsp-enable-identation nil
				lsp-enable-snippet nil
				lsp-lens-auto-enable nil
				lsp-enable-completion-at-point t
				lsp-enable-imenu t
				lsp-enable-on-type-formatting nil
				;;lsp-enable-relative-indentation t
				lsp-headerline-breadcrumb-mode nil)
	;; required?
	(dolist (dir '("[/\\\\]resources$"
								 "[/\\\\]\\.lsp"
								 "[/\\\\]\\.clj-kondo"
								 "[/\\\\]\\.cpcache"))
		(push dir lsp-file-watch-ignored)))

created time in 12 hours

pull request commentemacs-lsp/lsp-mode

(WIP) Signature posframe support

is this posframe displayed on request? on timeout? both? either?

When you press signatureHelp triggerChar (e. g. ()/

yyoncho

comment created time in 13 hours

pull request commentemacs-lsp/lsp-mode

(WIP) Signature posframe support

is this posframe displayed on request? on timeout? both? either?

yyoncho

comment created time in 13 hours

issue commentemacs-lsp/lsp-mode

lsp-mode feature wishlist

Is there any way to get automatic formatting for yanked regions but never their surroundings?

Now it seems there are two suboptimal options:

  • turn off lsp-enable-indentation, paste (unformatted), fix up if needed, reformat the whole buffer or defun with a keyboard shortcut, or
  • turn on lsp-enable-indentation, paste, observe in the case of the region having i.e. a missing trailing semicolon, that its surroundings are reformatted in ugly ways that will need undoing.

Is it possible to have lsp-enable-indentation that never reformats outside of the yanked region?

yyoncho

comment created time in 19 hours

pull request commentemacs-lsp/lsp-mode

Implement lsp-eslint--confirm-local and update ESLint language server

Thank you for contributing to lsp-mode!

Sorixelle

comment created time in 21 hours

push eventemacs-lsp/lsp-mode

yyoncho

commit sha 4d6f0cc4732d3df52ded983593c3b782a16a09fb

deploy: b0ca7142c3042080ef9e5fab315289d0a30dbafc

view details

push time in 21 hours

pull request commentemacs-lsp/lsp-mode

`lsp-iedit': add to docs, changelog, contributors

Thank you!

nbfalcon

comment created time in 21 hours

push eventemacs-lsp/lsp-mode

Nikita Bloshchanevich

commit sha b0ca7142c3042080ef9e5fab315289d0a30dbafc

`lsp-iedit': add to docs, changelog, contributors (#2478) * `lsp-iedit': add to docs, changelog, contributors Add `lsp-iedit' to the docs, describing `lsp-iedit-highlights'. Add it to the integrations section. Add `lsp-iedit' to the changelog. Add `lsp-iedit' to nbfalcon under CONTRIBUTORS. * Docs: move `iedit' sections to "Extensions"

view details

push time in 21 hours

PR merged emacs-lsp/lsp-mode

`lsp-iedit': add to docs, changelog, contributors documentation

Add lsp-iedit to the docs, describing `lsp-iedit-highlights'. Add it to the integrations section.

Add lsp-iedit to the changelog.

Add lsp-iedit to nbfalcon under CONTRIBUTORS.

+17 -1

4 comments

4 changed files

nbfalcon

pr closed time in 21 hours

push eventemacs-lsp/lsp-mode

yyoncho

commit sha 91dd29f9a4735302917caae3ae5f1a325dc6c145

deploy: a0c41e489c656bc69a3cdd0d04ee549f45e42a59

view details

push time in 21 hours

push eventemacs-lsp/lsp-mode

Sorixelle

commit sha a0c41e489c656bc69a3cdd0d04ee549f45e42a59

Implement lsp-eslint--confirm-local and update ESLint language server (#2534) * Implement lsp-eslint--confirm-local and update ESLint language server * fixup! Implement lsp-eslint--confirm-local and update ESLint language server * fixup! Implement lsp-eslint--confirm-local and update ESLint language server

view details

push time in 21 hours

PR merged emacs-lsp/lsp-mode

Implement lsp-eslint--confirm-local and update ESLint language server client
  • Implement lsp-eslint--confirm-local to handle eslint/confirmESLintExecution reqests
  • Update the ESLint language server from 2.1.8 -> 2.1.14
  • Create lsp-ask-question as a way to queue up minibuffer prompts

We should probably find a way to give users the ability to persist the value of lsp-eslint--stored-libraries. Using desktop.el and desktop-globals-to-save is one option, but some users may not want to use all the other features desktop.el provides. We should probably figure this one out before merging.

+72 -8

2 comments

3 changed files

Sorixelle

pr closed time in 21 hours

pull request commentemacs-lsp/lsp-mode

Implement lsp-eslint--confirm-local and update ESLint language server

@Sorixelle can you fix the CI - https://github.com/emacs-lsp/lsp-mode/pull/2534/checks?check_run_id=1721245305#step:6:125

Looks good now.

Sorixelle

comment created time in 21 hours

pull request commentemacs-lsp/lsp-mode

Implement lsp-eslint--confirm-local and update ESLint language server

@Sorixelle can you fix the CI - https://github.com/emacs-lsp/lsp-mode/pull/2534/checks?check_run_id=1721245305#step:6:125

Sorixelle

comment created time in a day

Pull request review commentemacs-lsp/lsp-mode

Implement lsp-eslint--confirm-local and update ESLint language server

 source.fixAll code action."         first-argument-exist       (executable-find (cl-first eslint-server-command))))) -(defun lsp-eslint--confirm-local (_workspace _params)-  ;; don't bother implementing since it will be dropped in next version of the-  ;; server-  t)+(defvar lsp-eslint--stored-libraries (ht)

Sounds good to me. We can move it to metadata once the dap-mode issue is fixed.

Sorixelle

comment created time in a day

Pull request review commentemacs-lsp/lsp-mode

Implement lsp-eslint--confirm-local and update ESLint language server

 source.fixAll code action."         first-argument-exist       (executable-find (cl-first eslint-server-command))))) -(defun lsp-eslint--confirm-local (_workspace _params)-  ;; don't bother implementing since it will be dropped in next version of the-  ;; server-  t)+(defvar lsp-eslint--stored-libraries (ht)

I can merge it as it is.

Sorixelle

comment created time in a day

more