profile
viewpoint
Hiroki Gondo nayuta-gondo @nayutaco Fukuoka, Japan https://nayuta.co/

nayuta-gondo/ics 1

Interchain Standards (ICS) for the Cosmos network & interchain ecosystem.

nayuta-gondo/lightning-rfc 1

Lightning Network Specifications

nayuta-gondo/besu 0

An enterprise-grade Java-based, Apache 2.0 licensed Ethereum client https://wiki.hyperledger.org/display/besu

nayuta-gondo/bitcoincore.org 0

Bitcoin Core project website

nayuta-gondo/eclair 0

A scala implementation of the Lightning Network.

nayuta-gondo/electrum 0

Electrum; Bitcoin thin client

nayuta-gondo/lightning 0

c-lightning — a Lightning Network implementation in C

nayuta-gondo/lightning-dissector 0

WIP: A wireshark plugin to analyze communication between lightning network nodes

nayuta-gondo/lightning-integration 0

Lightning Integration Testing Framework

nayuta-gondo/plc 0

Pure Lua Crypto

Pull request review commentcosmos/relayer

Fix dockerfile

 COPY . .  # Update and install needed deps prioir to installing the binary. RUN apk update && \-    apk --no-cache add make=4.2.1-r2 git=2.24.3-r0 && \+    apk --no-cache add make git && \     make install -FROM alpine:edge+FROM alpine:latest  ENV RELAYER /relayer -RUN addgroup rlyuser && \

Looks fine, but why use the sudo user?

orkunkl

comment created time in 10 hours

issue openedcosmos/relayer

Automatic Updates to clients to prevent expiry

The golang relayer needs to be able to maintain on-chain clients without manual introduction. IG will handle this issue since it is necessary for Stargate

created time in 10 hours

PR opened cosmos/relayer

Tulasi/lint issues fix
+31 -36

0 comment

11 changed files

pr created time in 12 hours

delete branch cosmos/relayer

delete branch : codeowners

delete time in 14 hours

push eventcosmos/relayer

Colin Axnér

commit sha 19f5a6532046343cf56a936e112ad85a1cdf4a4b

add IG as codeowners

view details

Christopher Goes

commit sha a77c7618fc347ae2f5af51bfb3946544a39d7623

Merge pull request #393 from cosmos/codeowners add Interchain Gmbh as codeowners

view details

push time in 14 hours

PR merged cosmos/relayer

Reviewers
add Interchain Gmbh as codeowners

Until a different entity takes ownership of the relayer, Interchain Gmbh is responsible for back stopping the relayer. We might as well make this explicit for now. IG does not have interest in long term ownership

+3 -0

0 comment

1 changed file

colin-axner

pr closed time in 14 hours

pull request commentcosmos/relayer

API server

also waiting on review from @fedekunze

jackzampolin

comment created time in 15 hours

PR opened cosmos/relayer

add IG as codeowners
+3 -0

0 comment

1 changed file

pr created time in 15 hours

create barnchcosmos/relayer

branch : codeowners

created branch time in 15 hours

push eventcosmos/relayer

push time in 15 hours

push eventcosmos/relayer

Colin Axnér

commit sha 9742cacc2d2bd5a56b4b54bd68cd57fcb31af2bd

add codeowners

view details

push time in 15 hours

PR opened cosmos/relayer

Fix dockerfile
  • Set runtime os to latest(stable version)
  • Remove user configurations to make things simpler, you can discard the change if you want.
+2 -10

0 comment

1 changed file

pr created time in 16 hours

push eventlightningnetwork/lightning-rfc

Dan Gershony

commit sha b80f8a719406b70f67e4cf7d034e8cd331850173

Add links to section 9 (anchor outputs) (#833)

view details

push time in 18 hours

issue openedlightningnetwork/lightning-rfc

Lightning Specification Meeting 2021/02/01

The meeting will take place on Monday 2021/02/01 at 7pm UTC on IRC #lightning-dev. It is open to the public.

Pending from last meetings

  • [ ] @rustyrussell to validate #539 test vectors in c-lightning
  • [ ] all implementations to correctly set sync_complete as per #826
  • [ ] second implementation of #672 for compatibility testing with c-lightning
  • [ ] second implementation of #824 for compatibility testing with lnd

Pull Request Review

  • [ ] Compression algorithm gossip #825
  • [ ] Warning message #834
  • [ ] TLV in Bolt 11 invoices #837

Issues

Long Term Updates

  • [ ] Discuss the possibility of a BIP-like structure for LN
  • [ ] Trampoline routing #829 and #836 (@t-bast)
  • [ ] Offers #798
  • [ ] Upfront payments / DoS protection
  • [ ] Blinded paths #765 (@t-bast)

Backlog

The following are topics that we should discuss at some point, so if we have time to discuss them great, otherwise they slip to the next meeting.

  • [ ] Github built-in security tab for vulnerability disclosure (@ariard)
  • [ ] Hornet (@cfromknecht)
  • [ ] lnprototest https://github.com/rustyrussell/lnprototest (@rustyrussell)

created time in 18 hours

issue commentcosmos/relayer

Getting "failed to get trusted headers" error

@orkunkl @kogisin I believe the main issue described above should be fixed. You will need to delete any existing client identifiers in your .relayer/config/config.yaml. Let me know if it still doesn't work

orkunkl

comment created time in a day

delete branch cosmos/relayer

delete branch : colin/373-client-expiration-check

delete time in a day

push eventcosmos/relayer

colin axnér

commit sha b9bf8e24da9d8d1bb5a4bc0d60bf3ec01c75799b

fix client reuse match bug (#391) * fix client match bug * add sanity check * fix build * apply @AdityaSripal suggestion * add comment for sanity check * fix wording

view details

push time in a day

PR merged cosmos/relayer

fix client reuse match bug

ref: #373

The test changes are from a bug I found testing today. It is a continuation of the String() usage issue

+40 -32

0 comment

5 changed files

colin-axner

pr closed time in a day

push eventcosmos/relayer

Colin Axnér

commit sha 916919816b2286e9a28ef2891807adcd8f271a2b

fix wording

view details

push time in a day

push eventcosmos/relayer

Colin Axnér

commit sha c3c52e15bf5e20c3c56831ce91c9683a01f13411

add comment for sanity check

view details

push time in a day

Pull request review commentcosmos/relayer

fix client reuse match bug

 func FindMatchingClient(source, counterparty *Chain, clientState *ibctmtypes.Cli 		}  		// check if the client states match-		if IsMatchingClient(*clientState, *existingClientState) {+		if IsMatchingClient(*clientState, *existingClientState) && !existingClientState.IsFrozen() {

Hmm maybe worth noting that it is just a sanity check cuz i found it confusing why it was there

colin-axner

comment created time in a day

push eventcosmos/relayer

Colin Axnér

commit sha c976099028df8e546b3817877a7a14c6df440647

apply @AdityaSripal suggestion

view details

push time in a day

Pull request review commentcosmos/relayer

fix client reuse match bug

 func FindMatchingClient(source, counterparty *Chain, clientState *ibctmtypes.Cli 				continue 			} -			if IsMatchingConsensusState(consensusStateResp.ConsensusState, header.ConsensusState()) {-				// matching client found-				return identifiedClientState.ClientId, true+			exportedConsState, err := clienttypes.UnpackConsensusState(consensusStateResp.ConsensusState)+			if err != nil {+				if source.debug {+					source.Log(fmt.Sprintf("Error: failed to consensus state on chain %s: %v", counterparty.PathEnd.ChainID, err))+				}+				continue+			}+			existingConsensusState, ok := exportedConsState.(*ibctmtypes.ConsensusState)+			if !ok {+				if source.debug {+					source.Log(fmt.Sprintf("Error:consensus state is not tendermint type on chain %s", counterparty.PathEnd.ChainID))+				}+				continue 			}++			if !IsMatchingConsensusState(existingConsensusState, header.ConsensusState()) {+				continue+			}++			if existingClientState.IsExpired(existingConsensusState.Timestamp, time.Now()) {

yes this was my logic as well

colin-axner

comment created time in a day

Pull request review commentcosmos/relayer

fix client reuse match bug

 func FindMatchingClient(source, counterparty *Chain, clientState *ibctmtypes.Cli 		}  		// check if the client states match-		if IsMatchingClient(*clientState, *existingClientState) {+		if IsMatchingClient(*clientState, *existingClientState) && !existingClientState.IsFrozen() {

I added this as a sanity check. In the issues reported, the client isn't frozen but expired. Expired clients don't have frozen heights

colin-axner

comment created time in a day

Pull request review commentcosmos/relayer

fix client reuse match bug

 func FindMatchingClient(source, counterparty *Chain, clientState *ibctmtypes.Cli 				continue 			} -			if IsMatchingConsensusState(consensusStateResp.ConsensusState, header.ConsensusState()) {-				// matching client found-				return identifiedClientState.ClientId, true+			exportedConsState, err := clienttypes.UnpackConsensusState(consensusStateResp.ConsensusState)+			if err != nil {+				if source.debug {+					source.Log(fmt.Sprintf("Error: failed to consensus state on chain %s: %v", counterparty.PathEnd.ChainID, err))+				}+				continue+			}+			existingConsensusState, ok := exportedConsState.(*ibctmtypes.ConsensusState)+			if !ok {+				if source.debug {+					source.Log(fmt.Sprintf("Error:consensus state is not tendermint type on chain %s", counterparty.PathEnd.ChainID))+				}+				continue 			}++			if !IsMatchingConsensusState(existingConsensusState, header.ConsensusState()) {+				continue+			}++			if existingClientState.IsExpired(existingConsensusState.Timestamp, time.Now()) {

It makes sense to me to move this up to line 308 above the matching consensus state call.

NOTE: This is fine, but we may skip valid clients because we're using local time time.Now rather than blocktime. I don't think it's a big deal so in favor of keeping it how it is.

colin-axner

comment created time in a day

Pull request review commentcosmos/relayer

fix client reuse match bug

 func FindMatchingClient(source, counterparty *Chain, clientState *ibctmtypes.Cli 		}  		// check if the client states match-		if IsMatchingClient(*clientState, *existingClientState) {+		if IsMatchingClient(*clientState, *existingClientState) && !existingClientState.IsFrozen() {

I don't get why this wasn't caught on line 337.

clientState is not frozen but existingClientState is. So wouldn't it have two fields IsFrozen and FrozenHeight that are different?

colin-axner

comment created time in a day

push eventcosmos/relayer

Colin Axnér

commit sha f94040d6d9bc21b4ea9a99b5a5eaa444c4a8fc1b

fix build

view details

push time in a day

issue commentcosmos/relayer

Getting "failed to get trusted headers" error

@akhilkumarpilli if you have bandwidth, these would be some good issues to take on

Edit: I'll handle the first fix of checking for expiration

Sure @colin-axner, will look into this.

orkunkl

comment created time in a day

push eventcosmos/relayer

Colin Axnér

commit sha 717e2082bd8b66e34be38bbb82b49af07a3ed4d8

add sanity check

view details

push time in a day

more