profile
viewpoint
Nayeem Rahman nayeemrmn London, UK Contributing to @denoland. Interested in Rust and Typescript.

nayeemrmn/deno 0

A secure JavaScript/TypeScript runtime built with V8, Rust, and Tokio

nayeemrmn/deno_install 0

Deno Binary Installer

nayeemrmn/deno_std 0

deno standard modules

nayeemrmn/deno_website2 0

deno.land website

nayeemrmn/discord-open-source 0

List of open source communities living on Discord

nayeemrmn/dprint-plugin-typescript 0

TypeScript and JavaScript code formatting plugin for dprint.

nayeemrmn/event-type 0

A general purpose, promise based event system.

nayeemrmn/glob-to-regexp 0

Convert glob strings to regular expressions.

Pull request review commentdenoland/deno

fix(cli): restore permission check on workers

+[WILDCARD]+error: Uncaught (in worker "") read access to "[WILDCARD]worker_types.ts", run again with the --allow-read flag

I've kind of fixed this locally, but I think it's a wontfix. There are error Results throughout cli which are passed to JS in some cases and terminated upon in Rust in other cases (like this one), and there isn't really a good way of selectively unifying the output that always works the way we want it to. The issue has been present for a while, it's mostly fine as it is.

kitsonk

comment created time in an hour

PullRequestReviewEvent

push eventnayeemrmn/deno

Luca Casonato

commit sha acc201625fd613c6e1e66d1714069726ec2a4b73

chore: add bundle_no_check benchmark (#8130)

view details

Kitson Kelly

commit sha b03f4a4a1c252d808b72fc462ea783362f810c75

fix(cli): restore permission check on workers (#8123) Fixes #8120

view details

push time in 4 hours

PR opened denoland/deno

fix(cli/fmt): Strip "\\?\" prefix when displaying Windows paths

Fixes https://discord.com/channels/684898665143206084/689420767620104201/770329467436400710.

We strip this prefix for Deno.realPath(), no reason not to do it for pretty diagnostics.

+13 -9

0 comment

1 changed file

pr created time in 5 hours

create barnchnayeemrmn/deno

branch : fmt-display-path

created branch time in 6 hours

push eventnayeemrmn/deno

Ross Weir

commit sha ece1e1d5f184165f21b17d3fe293d8d31dd9e413

feat(cli): pass script args for test command (#8121) Closes #8096

view details

Nayeem Rahman

commit sha 822e5b653685d539c492b87cf5ae77d0223d9b32

fix(core/runtime): Indicate exceptions in promises (#8124) Fixes #4879

view details

Kitson Kelly

commit sha 78429496e0625a68ccfdd215c7e240eddb3b5b66

revert new std/jwt module so issues can be addressed (#8127) This reverts commit aa0e64b5794e4515d5e1911107ba54ce7e0dcc3c. This reverts commit 034ab48086557af00216ffe311c71ad4eb0ec4d5.

view details

Bartek Iwańczuk

commit sha aebbdd5cc2c75151be28c839878b0dee915147ef

Revert "feat(lint): stabilize "deno lint" subcommand (#8075)" (#8128) This reverts commit c5c48f845a4d25f064c4388fcdd4295317edf155.

view details

Bartek Iwańczuk

commit sha 57cad539457dff7fc273bed5ecaf08bd3dc40d1b

refactor(cli): rewrite Deno.transpileOnly() to use SWC (#8090) Co-authored-by: Kitson Kelly <me@kitsonkelly.com>

view details

uki00a

commit sha b65171e37df066cf7c509434c611163fc8a3c720

fix(std/http/file_server): File server should ignore query params (#8116)

view details

Kid

commit sha 4c41ba5ad787909a478a6ef0d4e36adc05b52b9d

fix(op_crates/fetch): ensure Request.method to be string (#8100) Ensure "Request.method" to be the default value ("GET") if "init.method" is not defined, which follows browser's behavior.

view details

Ryan Dahl

commit sha 6a8d0d81c12e8f0b0c3c32c0cadbf36c021efd49

Remove timezone dependent tests (#8131)

view details

Steven Guerrero

commit sha d52fb903cda4c30bb1673260c673ba27167ab7b1

fix(std/node): Buffer.copy doesn't work as expected (#8125)

view details

Elias Sjögreen

commit sha 305a9c04ba60630f9708b681cfebb522a6110cc3

feat(unstable): add Deno.systemCpuInfo() (#7774)

view details

Tim Reichen

commit sha ae86cbb551f7b88f83d73a447411f753485e49e2

rename(std/testing): rename assert*Contains to assert*Includes (#7951) This commit renames two assertion functions to better align with JS API: - assertStringContains -> assertStringIncludes - assertArrayContains -> assertArrayIncludes

view details

Yasser A.Idrissi

commit sha 35caa160bf9b781d20364d77f53fee6e8f9899c3

feat(std/testing): Add assertExists assertion (#7874)

view details

Casper Beyer

commit sha b9dc2c3521fc5d1ad2cb3579f9be7ca8e3fd90c6

test(std/wasi): re-enable clock_time_get tests (#8098) This brings in revised tests for clock_time_get from upstream and re-enables them. This revision of these tests allow for lower precision clocks (we only provide millisecond precision, and that is conformant but previous tests for this in the upstream test suite were a bit more aggressive).

view details

Ryan Dahl

commit sha c4d33e8d778aa1b86197f1c54ff8e4e61a2ebf53

fix: Use -rw-r--r-- for cache files (#8132)

view details

push time in 6 hours

push eventnayeemrmn/deno

Nayeem Rahman

commit sha fb5b15e254a5242ca2933afd3fa5458aaaaf860a

fixup! feat(cli): Add deno cache --test

view details

push time in 6 hours

push eventnayeemrmn/deno

Bartek Iwańczuk

commit sha 8d95bd15e14a576c45ceadd030d70de43d758379

refactor(core): remove Deno.core.formatError() (#8091) With recent improvements to REPL implementation, Deno.core.formatError() API is no longer needed.

view details

Bartek Iwańczuk

commit sha 35f184cdcca806bda72f65b73c774c53db132a3b

refactor: use of lock file in ModuleGraph2 (#8087)

view details

Casper Beyer

commit sha 2a83b223857722ffe63aeaa35b44aec8659a910d

fix(std/wasi): disallow path_open outside of pre-opened dirfd (#8078)

view details

Casper Beyer

commit sha 9adbca6d195b8ea9ad1474ebbb6f906069d6b130

docs(std/wasi): mark sched_yield as implemented (#8055) This marks sched_yield as implemented, it is a no-op but will probably always be and we have passing tests for it.

view details

Kitson Kelly

commit sha 117fcf61f0feb8d50b3b55f7698929b633980643

test(cli): dynamic imports not evaluated until runtime (#8102) Closes #7997

view details

Kitson Kelly

commit sha dd952818bc6b888b8fd1cff6a3d1e6b15993bafb

test(cli): ensure modules can export typed JS files (#8101) Closes #5935

view details

Bartek Iwańczuk

commit sha 95854b88ad4a67afb885322c70bb424352bca49e

refactor(run): use new module graph for run --watch (#8085) This commit changes how "deno run --watch" is implemented by migrating to use ModuleGraph2.

view details

Kitson Kelly

commit sha 3d19fb493b82a8ab9b3fd0fa923fc81fd68acb4e

fix(cli): properly handle roots with extensions that don't match media type (#8114)

view details

Ross Weir

commit sha ece1e1d5f184165f21b17d3fe293d8d31dd9e413

feat(cli): pass script args for test command (#8121) Closes #8096

view details

Nayeem Rahman

commit sha 822e5b653685d539c492b87cf5ae77d0223d9b32

fix(core/runtime): Indicate exceptions in promises (#8124) Fixes #4879

view details

Kitson Kelly

commit sha 78429496e0625a68ccfdd215c7e240eddb3b5b66

revert new std/jwt module so issues can be addressed (#8127) This reverts commit aa0e64b5794e4515d5e1911107ba54ce7e0dcc3c. This reverts commit 034ab48086557af00216ffe311c71ad4eb0ec4d5.

view details

Bartek Iwańczuk

commit sha aebbdd5cc2c75151be28c839878b0dee915147ef

Revert "feat(lint): stabilize "deno lint" subcommand (#8075)" (#8128) This reverts commit c5c48f845a4d25f064c4388fcdd4295317edf155.

view details

Bartek Iwańczuk

commit sha 57cad539457dff7fc273bed5ecaf08bd3dc40d1b

refactor(cli): rewrite Deno.transpileOnly() to use SWC (#8090) Co-authored-by: Kitson Kelly <me@kitsonkelly.com>

view details

uki00a

commit sha b65171e37df066cf7c509434c611163fc8a3c720

fix(std/http/file_server): File server should ignore query params (#8116)

view details

Kid

commit sha 4c41ba5ad787909a478a6ef0d4e36adc05b52b9d

fix(op_crates/fetch): ensure Request.method to be string (#8100) Ensure "Request.method" to be the default value ("GET") if "init.method" is not defined, which follows browser's behavior.

view details

Nayeem Rahman

commit sha 2f0f6f47b291bf9df203fab44d1b70ffa7cfd56e

feat(cli): Add deno cache --test

view details

push time in 10 hours

PullRequestReviewEvent

delete branch nayeemrmn/deno

delete branch : exception-in-promise

delete time in 20 hours

push eventnayeemrmn/deno

Nayeem Rahman

commit sha a126f7f5b7ca84f008b77a7f3c603d8e812efc68

fixup! fix(core/runtime): Indicate exceptions in promises

view details

push time in a day

PR opened denoland/deno

fix(core/runtime): Indicate exceptions in promises

Closes #4879.

Promise.reject(new Error("foo"));

// Before:
// Uncaught Error: foo
// ...

// After:
// Uncaught (in promise) Error: foo
// ...

image

+27 -25

0 comment

8 changed files

pr created time in a day

create barnchnayeemrmn/deno

branch : exception-in-promise

created branch time in a day

Pull request review commentdenoland/deno

fix(cli): restore permission check on workers

+[WILDCARD]+error: Uncaught (in worker "") read access to "[WILDCARD]worker_types.ts", run again with the --allow-read flag

It should say error: Uncaught (in worker "") PermissionDenied: read access to .... Not sure if this PR did something to omit it or it's an earlier regression.

kitsonk

comment created time in a day

PullRequestReviewEvent

push eventnayeemrmn/deno

Bartek Iwańczuk

commit sha 8d95bd15e14a576c45ceadd030d70de43d758379

refactor(core): remove Deno.core.formatError() (#8091) With recent improvements to REPL implementation, Deno.core.formatError() API is no longer needed.

view details

Bartek Iwańczuk

commit sha 35f184cdcca806bda72f65b73c774c53db132a3b

refactor: use of lock file in ModuleGraph2 (#8087)

view details

Casper Beyer

commit sha 2a83b223857722ffe63aeaa35b44aec8659a910d

fix(std/wasi): disallow path_open outside of pre-opened dirfd (#8078)

view details

Casper Beyer

commit sha 9adbca6d195b8ea9ad1474ebbb6f906069d6b130

docs(std/wasi): mark sched_yield as implemented (#8055) This marks sched_yield as implemented, it is a no-op but will probably always be and we have passing tests for it.

view details

Kitson Kelly

commit sha 117fcf61f0feb8d50b3b55f7698929b633980643

test(cli): dynamic imports not evaluated until runtime (#8102) Closes #7997

view details

Kitson Kelly

commit sha dd952818bc6b888b8fd1cff6a3d1e6b15993bafb

test(cli): ensure modules can export typed JS files (#8101) Closes #5935

view details

Bartek Iwańczuk

commit sha 95854b88ad4a67afb885322c70bb424352bca49e

refactor(run): use new module graph for run --watch (#8085) This commit changes how "deno run --watch" is implemented by migrating to use ModuleGraph2.

view details

Kitson Kelly

commit sha 3d19fb493b82a8ab9b3fd0fa923fc81fd68acb4e

fix(cli): properly handle roots with extensions that don't match media type (#8114)

view details

push time in a day

issue commentdenoland/deno

deno fmt --column-width option

Config for deno fmt was ultimately decided against in https://github.com/denoland/deno/issues/3827#issuecomment-708479969. The same naturally applies to individual flags like this, effective duplicate.

crookse

comment created time in a day

issue commentdenoland/deno_lint

Add lint rule to check unversioned imports from deno.land/x/

-1 for special handling of any host. This should be a plugin.

bartlomieju

comment created time in 2 days

issue commentdenoland/deno

Dynamic import of remote modules should be allowed when they are in the cache

I also don't like the state of the cache affecting required permissions in general, but this one might be worth it for the practical advantage. Why should it require net permission if it's not interacting with the network? The only protection I see is not exposing information about the state of the cache -- but the requested permission is net. That's always bothered me.

It would be like saying for fetch() that if a remote resource is already cached, then don't require --allow-net.

If I implemented my own fetch() and cache system in user space, it wouldn't require net permission if the resource is already cached. So maybe, I think the only fundamentally consistent way of approaching net permission is to only guard "genuine" (as far as Deno can see) network access.

teleclimber

comment created time in 2 days

issue commentdenoland/deno

Support importing data URLs

I mean they're duplicates and one can be closed.

kitsonk

comment created time in 2 days

issue commentdenoland/deno

Custom arg passing to Deno test?

I think we should be able to pass Deno.args with deno test -- arg1 arg2.

wozniakty

comment created time in 3 days

PR opened denoland/deno

feat(cli): Add deno cache --test

Closes #7775.

+114 -27

0 comment

6 changed files

pr created time in 3 days

create barnchnayeemrmn/deno

branch : cache-test-flag

created branch time in 3 days

push eventnayeemrmn/deno

Bartek Iwańczuk

commit sha 9d363312782f00a871c13cd3b0c23617f5e1929d

Revert "feat(cli): Add deno cache --test and --worker (#7920)" (#8089) This reverts commit be15cf285dbf3a7b3025d34cb80e87e54a55dd93.

view details

push time in 3 days

issue commentdenoland/deno

Support importing data URLs

One of this and #7433 can be closed.

kitsonk

comment created time in 3 days

issue commentdenoland/deno

Add deno cache --test=...

@bartlomieju Can you reopen this? I don't have the button.

nayeemrmn

comment created time in 3 days

pull request commentdenoland/deno

Revert "feat(cli): Add deno cache --test and --worker (#7920)"

I agree the implementation for --worker is weird, it's constructing a WebWorker just to compile with different types. I'll re-open only for --test.

  • I dislike that deno test begets more complexity, like with this deno cache --test

This is more than baggage brought on by deno test in my mind. I expect deno cache --test to be the new go-to command for setting up an offline-ready development environment -- as an alternative to deno cache deps.ts dev_deps.ts or something else which depends on the user's source tree. See cargo build --tests and go test -c, a way to compile-only tests is a fundamental expectation for a built-in test runner.

bartlomieju

comment created time in 3 days

issue openeddenoland/deno

Bad import.meta handling in bundles

Input:

console.log(import.meta);

Actual output:

console.log(import.meta);

Expected output:

const import_meta_1 = { url: "file:///path/to/original/source", main: import.meta.main /* or false */ };
console.log(import_meta_1);

We're here again: https://github.com/swc-project/swc/issues/1115#issuecomment-700638446. import.meta is an object that can be wholly referenced and is even writable. SWC should not substitute individual fields, but call back to the loader for the initialising value of import_meta_1.

cc @kitsonk @kdy1

created time in 3 days

push eventnayeemrmn/deno

nerix

commit sha 0a2f0fe7f23a1b3ffa8dedf18694f2e5924a9880

fix(cli/rt/websockets): Only add Sec-WebSocket-Protocol if it's not empty (#7936)

view details

Max Drosdo.www

commit sha 17eaede6438ee62416468815621f19cc0567989c

docs: fix command examples use outdated default file_server port (#8062)

view details

Divy Srivastava

commit sha d592c128cf42852d2ccffc45574761fd78de8fa7

chores(cli/fmt): make --ignore stable (#7922) Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>

view details

Bartek Iwańczuk

commit sha 9b20cfbee8d932c2f232f6bad911fe65c8257adc

upgrade: deno_doc, deno_lint, dprint, swc (#8077) - deno_doc 0.1.13 - deno_lint 0.2.5 - dprint-plugin-typescript 0.32.6 - swc_bundler 0.12.0 - swc_ecmascript 0.11.1

view details

Bartek Iwańczuk

commit sha c5c48f845a4d25f064c4388fcdd4295317edf155

feat(lint): stabilize "deno lint" subcommand (#8075) This commit stabilizes "deno lint" by removing the need to pass --unstable flag. --unstable is still required when using --json flag.

view details

Eugen Cazacu

commit sha 9fa59f0ca8164f5e02ba2a2fa90b6fdbce5c1afb

test(std/datetime): test datetime constants (#8068) Fixes: #8067

view details

Kitson Kelly

commit sha 7e2c7fb6c5454e30158d74e1a5786183ea391f07

refactor(cli): migrate run and cache to new infrastructure (#7996) Co-authored-by: Ryan Dahl <ry@tinyclouds.org>

view details

btoo

commit sha 1d9c7a0a2219893203ae6631889aeb8d344c79ac

docs(std/path): fix typo in globToRegExp docs (#8081)

view details

Nikolai Vavilov

commit sha f56c7868ab3f862fc66c8605ed34c315040cb3a2

docs(cli): update link to dprint-plugin-typescript (#8052)

view details

Nayeem Rahman

commit sha a3024a6dc5c27317049a39ad8cb3e54368429dbf

BREAKING(cli/tsc): Enable isolatedModules by default (#8050)

view details

Kitson Kelly

commit sha ab898556a490d78d93e806ea3ee31147117102e3

refactor(cli): move bundle check to new infrastructure (#8071)

view details

Toan Nguyen

commit sha 29e05bb014015085615f648a31f180ed9dd49e5a

fix: typos in cli and core (#8082)

view details

Nayeem Rahman

commit sha be15cf285dbf3a7b3025d34cb80e87e54a55dd93

feat(cli): Add deno cache --test and --worker (#7920)

view details

push time in 3 days

delete branch nayeemrmn/deno

delete branch : cache-test-flag

delete time in 3 days

delete branch nayeemrmn/deno

delete branch : isolated-modules-stable

delete time in 3 days

push eventnayeemrmn/deno

Nayeem Rahman

commit sha 9b792f10088328d81f2c9ee558cbe7ce66474f30

fixup! BREAKING(cli/tsc): Enable isolatedModules by default

view details

push time in 4 days

push eventnayeemrmn/deno

btoo

commit sha 1d9c7a0a2219893203ae6631889aeb8d344c79ac

docs(std/path): fix typo in globToRegExp docs (#8081)

view details

Nikolai Vavilov

commit sha f56c7868ab3f862fc66c8605ed34c315040cb3a2

docs(cli): update link to dprint-plugin-typescript (#8052)

view details

Nayeem Rahman

commit sha ba81b4d42c5a61977676d9aa76b67fa67d57f0b7

feat(cli/main): Add deno cache --test and --worker

view details

push time in 4 days

push eventnayeemrmn/deno

Casper Beyer

commit sha dfe19c5c7570c650e25617f6653bb103ad89e4d5

feat: stabilize Deno.fsync and Deno.fdatasync (#8038)

view details

Ryan Dahl

commit sha 9e2e2dfb208ea632eaccd51eb9e0240f2e802f99

bump versions for op crates (#8048)

view details

Casper Beyer

commit sha be89bdfed7feea01aa606f4202d23a8d9fa06473

test(std/wasi): reduce test duplication (#8053) This fast-forwards wasi-test-suite a couple of commits removed duplicate, or near duplicate tests with not much additional value. Other tests have been merged to reduce the number of modules to make tests topical to the syscall that is being tested.

view details

Kitson Kelly

commit sha 0fb39f9176c5bfb6a8cd50addd85d596fe93c459

feat(cli): add types for WeakRef/FinalizationRegistry (#8056) Fixes #8051

view details

Akshat Agarwal

commit sha d6c824a6c38e4d443a7f050e2f3b7703f98b2cdc

refactor(cli): use PathBuf instead of String for lint and fmt subcommands (#8042)

view details

Casper Beyer

commit sha 322913ee5c73cd139a46dea593635c2d1a8d5f8c

docs(tools/repl): add special variables section (#8057)

view details

Simon Lecoq

commit sha 23df1c563efee65e6d549308ed0671a9e2933c05

feat(std/testing): Add support for object assertion against object subset (#8001) This commit add supports for a new assertion function "assertObjectMatch" which allows to test an actual object against an expected object subset (i.e. inclusivity, not equality).

view details

Carter Snook

commit sha 4b43f8cffadf8ac5e9e258afaaa5887fc1975884

docs(std/uuid): `creat` -> `create` (#8064)

view details

nerix

commit sha 0a2f0fe7f23a1b3ffa8dedf18694f2e5924a9880

fix(cli/rt/websockets): Only add Sec-WebSocket-Protocol if it's not empty (#7936)

view details

Max Drosdo.www

commit sha 17eaede6438ee62416468815621f19cc0567989c

docs: fix command examples use outdated default file_server port (#8062)

view details

Divy Srivastava

commit sha d592c128cf42852d2ccffc45574761fd78de8fa7

chores(cli/fmt): make --ignore stable (#7922) Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>

view details

Bartek Iwańczuk

commit sha 9b20cfbee8d932c2f232f6bad911fe65c8257adc

upgrade: deno_doc, deno_lint, dprint, swc (#8077) - deno_doc 0.1.13 - deno_lint 0.2.5 - dprint-plugin-typescript 0.32.6 - swc_bundler 0.12.0 - swc_ecmascript 0.11.1

view details

Bartek Iwańczuk

commit sha c5c48f845a4d25f064c4388fcdd4295317edf155

feat(lint): stabilize "deno lint" subcommand (#8075) This commit stabilizes "deno lint" by removing the need to pass --unstable flag. --unstable is still required when using --json flag.

view details

Eugen Cazacu

commit sha 9fa59f0ca8164f5e02ba2a2fa90b6fdbce5c1afb

test(std/datetime): test datetime constants (#8068) Fixes: #8067

view details

Kitson Kelly

commit sha 7e2c7fb6c5454e30158d74e1a5786183ea391f07

refactor(cli): migrate run and cache to new infrastructure (#7996) Co-authored-by: Ryan Dahl <ry@tinyclouds.org>

view details

Nayeem Rahman

commit sha 9906047485f480553355b7343761179fa724e88c

BREAKING(cli/tsc): Enable isolatedModules by default

view details

push time in 4 days

push eventnayeemrmn/deno

Casper Beyer

commit sha 17467d01dad3f280b7f788ba87953392a8e304bb

fix(std/io): remove trivial internal util.ts module (#8032)

view details

KNnut

commit sha aa0e64b5794e4515d5e1911107ba54ce7e0dcc3c

docs(std/jwt): Fix examples (#8044)

view details

Nayeem Rahman

commit sha 070d99645f4849cfc4479382d756bd40379594d0

chore: Rename --importmap to --import-map (#7032) --importmap still works as an alias to --import-map but is not visible in CLI help output.

view details

Casper Beyer

commit sha dfe19c5c7570c650e25617f6653bb103ad89e4d5

feat: stabilize Deno.fsync and Deno.fdatasync (#8038)

view details

Ryan Dahl

commit sha 9e2e2dfb208ea632eaccd51eb9e0240f2e802f99

bump versions for op crates (#8048)

view details

Casper Beyer

commit sha be89bdfed7feea01aa606f4202d23a8d9fa06473

test(std/wasi): reduce test duplication (#8053) This fast-forwards wasi-test-suite a couple of commits removed duplicate, or near duplicate tests with not much additional value. Other tests have been merged to reduce the number of modules to make tests topical to the syscall that is being tested.

view details

Kitson Kelly

commit sha 0fb39f9176c5bfb6a8cd50addd85d596fe93c459

feat(cli): add types for WeakRef/FinalizationRegistry (#8056) Fixes #8051

view details

Akshat Agarwal

commit sha d6c824a6c38e4d443a7f050e2f3b7703f98b2cdc

refactor(cli): use PathBuf instead of String for lint and fmt subcommands (#8042)

view details

Casper Beyer

commit sha 322913ee5c73cd139a46dea593635c2d1a8d5f8c

docs(tools/repl): add special variables section (#8057)

view details

Simon Lecoq

commit sha 23df1c563efee65e6d549308ed0671a9e2933c05

feat(std/testing): Add support for object assertion against object subset (#8001) This commit add supports for a new assertion function "assertObjectMatch" which allows to test an actual object against an expected object subset (i.e. inclusivity, not equality).

view details

Carter Snook

commit sha 4b43f8cffadf8ac5e9e258afaaa5887fc1975884

docs(std/uuid): `creat` -> `create` (#8064)

view details

nerix

commit sha 0a2f0fe7f23a1b3ffa8dedf18694f2e5924a9880

fix(cli/rt/websockets): Only add Sec-WebSocket-Protocol if it's not empty (#7936)

view details

Max Drosdo.www

commit sha 17eaede6438ee62416468815621f19cc0567989c

docs: fix command examples use outdated default file_server port (#8062)

view details

Divy Srivastava

commit sha d592c128cf42852d2ccffc45574761fd78de8fa7

chores(cli/fmt): make --ignore stable (#7922) Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>

view details

Bartek Iwańczuk

commit sha 9b20cfbee8d932c2f232f6bad911fe65c8257adc

upgrade: deno_doc, deno_lint, dprint, swc (#8077) - deno_doc 0.1.13 - deno_lint 0.2.5 - dprint-plugin-typescript 0.32.6 - swc_bundler 0.12.0 - swc_ecmascript 0.11.1

view details

Bartek Iwańczuk

commit sha c5c48f845a4d25f064c4388fcdd4295317edf155

feat(lint): stabilize "deno lint" subcommand (#8075) This commit stabilizes "deno lint" by removing the need to pass --unstable flag. --unstable is still required when using --json flag.

view details

Eugen Cazacu

commit sha 9fa59f0ca8164f5e02ba2a2fa90b6fdbce5c1afb

test(std/datetime): test datetime constants (#8068) Fixes: #8067

view details

Kitson Kelly

commit sha 7e2c7fb6c5454e30158d74e1a5786183ea391f07

refactor(cli): migrate run and cache to new infrastructure (#7996) Co-authored-by: Ryan Dahl <ry@tinyclouds.org>

view details

Nayeem Rahman

commit sha daa4c7a2aad7a8cb9dcfaa680564f7fed9383a63

feat(cli/main): Add deno cache --test and --worker

view details

push time in 4 days

create barnchnayeemrmn/deno

branch : source-line

created branch time in 4 days

issue commentdenoland/deno

lib.dom.d.ts incompatible with built-in Deno libs

Although, I think we should just make "dom" mutually exclusive to Deno's web API libs. Having alignment prevents us from, say, partially populating the navigator object since we are forced to match its type in "dom".

It seems the quoted user can fix the issue by using the following tsconfig:

{
  "compilerOptions": {
    "lib": [
      "dom",
      "deno.ns",
      "deno.unstable"
    ]
  }
}

If not, we should instead focus on making this work.

kitsonk

comment created time in 4 days

issue commentdenoland/deno

lib.dom.d.ts incompatible with built-in Deno libs

For reference, you can get a list of incompatibilities by compiling anything with the following tsconfig:

{
  "compilerOptions": {
    "lib": [
      "dom",
      "deno.web",
      "deno.fetch",
      "deno.window",
      "deno.shared_globals",
      "deno.ns",
      "deno.unstable"
    ]
  }
}

I remember seeing a bunch of errors before #7514, enough that I didn't think it was a goal to have this. If it is, we can easily add an integration test.

kitsonk

comment created time in 4 days

push eventnayeemrmn/deno

Carter Snook

commit sha 4b43f8cffadf8ac5e9e258afaaa5887fc1975884

docs(std/uuid): `creat` -> `create` (#8064)

view details

push time in 5 days

push eventnayeemrmn/deno

Casper Beyer

commit sha dfe19c5c7570c650e25617f6653bb103ad89e4d5

feat: stabilize Deno.fsync and Deno.fdatasync (#8038)

view details

Ryan Dahl

commit sha 9e2e2dfb208ea632eaccd51eb9e0240f2e802f99

bump versions for op crates (#8048)

view details

Casper Beyer

commit sha be89bdfed7feea01aa606f4202d23a8d9fa06473

test(std/wasi): reduce test duplication (#8053) This fast-forwards wasi-test-suite a couple of commits removed duplicate, or near duplicate tests with not much additional value. Other tests have been merged to reduce the number of modules to make tests topical to the syscall that is being tested.

view details

Kitson Kelly

commit sha 0fb39f9176c5bfb6a8cd50addd85d596fe93c459

feat(cli): add types for WeakRef/FinalizationRegistry (#8056) Fixes #8051

view details

Akshat Agarwal

commit sha d6c824a6c38e4d443a7f050e2f3b7703f98b2cdc

refactor(cli): use PathBuf instead of String for lint and fmt subcommands (#8042)

view details

Casper Beyer

commit sha 322913ee5c73cd139a46dea593635c2d1a8d5f8c

docs(tools/repl): add special variables section (#8057)

view details

Simon Lecoq

commit sha 23df1c563efee65e6d549308ed0671a9e2933c05

feat(std/testing): Add support for object assertion against object subset (#8001) This commit add supports for a new assertion function "assertObjectMatch" which allows to test an actual object against an expected object subset (i.e. inclusivity, not equality).

view details

push time in 5 days

pull request commentdenoland/deno

rename(std/testing/asserts.ts): rename contains to includes

if we should have both assertStringIncludes and assertArrayIncludes or just assertIncludes as implemented in this PR

I think they should definitely be different functions. They have different and unrelated behaviour, which would be especially confusing since strings are iterable. The JS methods are namespaced to Array.prototype.includes() and String.prototype.includes(). Making them overloads is illogical and makes both the implementation and call sites harder to read.

timreichen

comment created time in 5 days

PullRequestReviewEvent
PullRequestEvent

Pull request review commentdenoland/deno

refactor(cli): migrate run and cache to new infrastructure

 impl Graph2 {     self.modules.contains_key(s)   } +  /// Type check the module graph, corresponding to the options provided.+  pub fn check(+    self,+    options: CheckOptions,+  ) -> Result<(Stats, Diagnostics, Option<IgnoredCompilerOptions>), AnyError>+  {+    debug!(+      "check: emit={} lib={:?} maybe_config_path={:?}, reload={}",+      options.emit, options.lib, options.maybe_config_path, options.reload+    );+    let mut config = TsConfig::new(json!({+      "allowJs": true,+      // TODO(@kitsonk) is this really needed?+      "esModuleInterop": true,+      // Enabled by default to align to transpile/swc defaults+      "experimentalDecorators": true,+      "incremental": true,+      "isolatedModules": true,

I'll reopen #8050.

kitsonk

comment created time in 5 days

PullRequestReviewEvent

PR closed denoland/deno

BREAKING(cli/tsc): Enable isolatedModules by default

Closes #7326.

Closes #7947, as code written for stable is once again compatible with --unstable. Discussion: I strongly feel we should maintain this property, even if it means going straight to stable for future changes like this. Code written for --unstable is by design incompatible with stable -- having incompatibilities going the opposite way as well splits the ecosystem in half, generating a lot of headache and noise. Better to have everyone adapt at once.

+3 -4

2 comments

2 changed files

nayeemrmn

pr closed time in 6 days

pull request commentdenoland/deno

BREAKING(cli/tsc): Enable isolatedModules by default

Okay, thanks.

nayeemrmn

comment created time in 6 days

PR opened denoland/deno

BREAKING(cli/tsc): Enable isolatedModules by default

Closes #7326.

Closes #7947, as code written for stable is once again compatible with --unstable. Discussion: I strongly feel we should maintain this property, even if it means going straight to stable for future changes like this. Code written for --unstable is by design incompatible with stable -- having incompatibilities going the opposite way as well splits the ecosystem in half, generating a lot of headache and noise. Better to have everyone adapt at once.

+3 -4

0 comment

2 changed files

pr created time in 6 days

create barnchnayeemrmn/deno

branch : isolated-modules-stable

created branch time in 6 days

push eventnayeemrmn/deno

Casper Beyer

commit sha b33e8d5d427934544fa6e0de44df8793aae63c9d

refactor(cli/repl): extract is_closing to a function (#8015) This extracts is closing into a function so that it can easily be used as the condition for the loop.

view details

Bartek Iwańczuk

commit sha 8f9da368f78b0dcd55e701b30daea8b45102a491

refactor(lint): show hint for lint errors (#8016) This commit adds formatting of optional "hint" that can be present in lint diagnostic.

view details

Ryan Dahl

commit sha 3e51610bbb5d5d63863b9989690ca1e8127fdf88

Remove github actions cache (#8020) Running into issues with cache when trying to upgrade V8. Based on the analysis in https://github.com/denoland/deno/pull/7903#issuecomment-706252380 we know the cache is not providing much benefit.

view details

Casper Beyer

commit sha 065db9df19fa9f1f598fc3a5c7fd978b484428de

test(std/io): use a real tempdir (#8019) This replaces a case of a temp file in the working tree with a tempfile in a real temporary directory avoiding pollution of the working directory.

view details

Ryan Dahl

commit sha 59888ff0b27f75feb3ea88cdea943bf9fbd345fd

upgrade rusty_v8 (#8017)

view details

Ryan Dahl

commit sha fb2cae9687569fc891c13ab4a2862b9e66902a75

deno_core 0.64.0 (#8025)

view details

Casper Beyer

commit sha f91c1155f0cccef9a49efdcc489be3f258000957

docs(tools): add repl section (#8011) This adds a section on the repl with the keybindings that we support out of the box.

view details

Marcos Casagrande

commit sha d3dea24560f7434bd1020f0d9dc4c787f79479da

fix(std/tar): fix constant condition (#8010)

view details

Casper Beyer

commit sha f5c23f8058ed7ce85846c6b1e623329a09fa1a76

fix(cli/repl): write all results to stdout (#7893) This writes all evaluaton results to stdout regardless if the result is an error or not. This matches the behavior of other read-eval-print-loops like Node.

view details

Casper Beyer

commit sha 8eb44537ecb35aebf2aa95018ab8806ab899e0f7

fix(cli/repl): keyboard interrupt should continue (#7960) This changes the behavior of keyboard interrupts (ctrl+c) to continue, clearing the current line instead of exiting. Exit can still be done with ctrl+d or by calling close().

view details

Yoshiya Hinosawa

commit sha 342b151b5d9d6c97926588dd118b59032f3b0e40

docs(std/datetime): document toIMF, isLeap, difference, and constants (#7931)

view details

Nayeem Rahman

commit sha 19b918d112c786b1db17fe2d83be79f1114ba240

feat(std/path): Add toFileUrl() (#7971)

view details

Casper Beyer

commit sha e58763737e82db481a05e34ad883b1cd286dd05d

docs(getting_started): fix WebAssembly example (#8028)

view details

vwkd

commit sha e432db70e9b5628990517baa689b74721f6da8e1

docs: readTextFile / readTextFileSync throw when reading directory (#7999)

view details

Casper Beyer

commit sha 35028db5e571b4232dd58293cea7e5a8ec2e3571

fix(cli/repl): unterminated string literal should invalidate (#7896) This adds the grave character to the pair matching so that template string literals trigger multi-line edits.

view details

Luca Casonato

commit sha 08441b855d8cfbe7edd41811c8c719e5fae01f83

fix(op_crates/fetch): Body.body should be stream of Uint8Array (#8030)

view details

Casper Beyer

commit sha 9d664f8375856be228e4f98b8381ac934d84604b

fix(cli/repl): ignore pair matching inside literals (#8037)

view details

Nayeem Rahman

commit sha 3f5513758d9e237d7c3775165c4164db89a95d31

feat(cli/installer): Add missing flags for deno install (#7601) This commit adds support for following flags: - deno install --importmap - deno install --no-remote - deno install --lock - deno install --lock-write - deno install --cached-only - deno install --v8-flags - deno install --seed

view details

Casper Beyer

commit sha c488468b32ef3869a233190437641e5ec8ef11b6

feat(cli/repl): add tab completion (#7827) This commit adds tab completion in REPL. Currently it works only for global identifiers and object properties.

view details

Absebo

commit sha 1474d5d76d38c094c6c551bcd23a61f8328bb258

fix(cli): Handling of relative importmaps while using watch (#7950)

view details

push time in 6 days

push eventnayeemrmn/deno

Casper Beyer

commit sha b33e8d5d427934544fa6e0de44df8793aae63c9d

refactor(cli/repl): extract is_closing to a function (#8015) This extracts is closing into a function so that it can easily be used as the condition for the loop.

view details

Bartek Iwańczuk

commit sha 8f9da368f78b0dcd55e701b30daea8b45102a491

refactor(lint): show hint for lint errors (#8016) This commit adds formatting of optional "hint" that can be present in lint diagnostic.

view details

Ryan Dahl

commit sha 3e51610bbb5d5d63863b9989690ca1e8127fdf88

Remove github actions cache (#8020) Running into issues with cache when trying to upgrade V8. Based on the analysis in https://github.com/denoland/deno/pull/7903#issuecomment-706252380 we know the cache is not providing much benefit.

view details

Casper Beyer

commit sha 065db9df19fa9f1f598fc3a5c7fd978b484428de

test(std/io): use a real tempdir (#8019) This replaces a case of a temp file in the working tree with a tempfile in a real temporary directory avoiding pollution of the working directory.

view details

Ryan Dahl

commit sha 59888ff0b27f75feb3ea88cdea943bf9fbd345fd

upgrade rusty_v8 (#8017)

view details

Ryan Dahl

commit sha fb2cae9687569fc891c13ab4a2862b9e66902a75

deno_core 0.64.0 (#8025)

view details

Casper Beyer

commit sha f91c1155f0cccef9a49efdcc489be3f258000957

docs(tools): add repl section (#8011) This adds a section on the repl with the keybindings that we support out of the box.

view details

Marcos Casagrande

commit sha d3dea24560f7434bd1020f0d9dc4c787f79479da

fix(std/tar): fix constant condition (#8010)

view details

Casper Beyer

commit sha f5c23f8058ed7ce85846c6b1e623329a09fa1a76

fix(cli/repl): write all results to stdout (#7893) This writes all evaluaton results to stdout regardless if the result is an error or not. This matches the behavior of other read-eval-print-loops like Node.

view details

Casper Beyer

commit sha 8eb44537ecb35aebf2aa95018ab8806ab899e0f7

fix(cli/repl): keyboard interrupt should continue (#7960) This changes the behavior of keyboard interrupts (ctrl+c) to continue, clearing the current line instead of exiting. Exit can still be done with ctrl+d or by calling close().

view details

Yoshiya Hinosawa

commit sha 342b151b5d9d6c97926588dd118b59032f3b0e40

docs(std/datetime): document toIMF, isLeap, difference, and constants (#7931)

view details

Nayeem Rahman

commit sha 19b918d112c786b1db17fe2d83be79f1114ba240

feat(std/path): Add toFileUrl() (#7971)

view details

Casper Beyer

commit sha e58763737e82db481a05e34ad883b1cd286dd05d

docs(getting_started): fix WebAssembly example (#8028)

view details

vwkd

commit sha e432db70e9b5628990517baa689b74721f6da8e1

docs: readTextFile / readTextFileSync throw when reading directory (#7999)

view details

Casper Beyer

commit sha 35028db5e571b4232dd58293cea7e5a8ec2e3571

fix(cli/repl): unterminated string literal should invalidate (#7896) This adds the grave character to the pair matching so that template string literals trigger multi-line edits.

view details

Luca Casonato

commit sha 08441b855d8cfbe7edd41811c8c719e5fae01f83

fix(op_crates/fetch): Body.body should be stream of Uint8Array (#8030)

view details

Casper Beyer

commit sha 9d664f8375856be228e4f98b8381ac934d84604b

fix(cli/repl): ignore pair matching inside literals (#8037)

view details

Nayeem Rahman

commit sha 3f5513758d9e237d7c3775165c4164db89a95d31

feat(cli/installer): Add missing flags for deno install (#7601) This commit adds support for following flags: - deno install --importmap - deno install --no-remote - deno install --lock - deno install --lock-write - deno install --cached-only - deno install --v8-flags - deno install --seed

view details

Casper Beyer

commit sha c488468b32ef3869a233190437641e5ec8ef11b6

feat(cli/repl): add tab completion (#7827) This commit adds tab completion in REPL. Currently it works only for global identifiers and object properties.

view details

Absebo

commit sha 1474d5d76d38c094c6c551bcd23a61f8328bb258

fix(cli): Handling of relative importmaps while using watch (#7950)

view details

push time in 6 days

delete branch nayeemrmn/deno

delete branch : import-map-rename

delete time in 6 days

Pull request review commentdenoland/deno

feat(std/testing): Add support for object assertion against object subset

 export function assertNotMatch(   } } +/**+ * Make an assertion that `actual` object is a subset of `expected` object, deeply.+ * If not, then throw.+ */+export function assertObjectMatch(+  actual: Record<string | symbol, unknown>,+  expected: Record<string | symbol, unknown>,+): void {+  type loose = Record<string | symbol, unknown>;+  const seen = new WeakMap();+  return assertEquals(+    (function filter(a: loose, b: loose): loose {+      // Prevent infinite loop with circular references with same filter+      if ((seen.has(a)) && (seen.get(a) === b)) {+        return a;+      }+      seen.set(a, b);+      // Iterate through keys present in both actual and expected+      // and filter recursively on object references+      const filtered = {} as loose;+      for (+        const [key, value] of Object.entries(a).filter(([key]) => key in b)

I don't think Object.entries() includes symbols. This would be shown if the tests included an erroneous case for symbols. You can use [...Object.getOwnPropertyNames(a), ...Object.getOwnPropertySymbols(a)] to get a complete list of keys.

lowlighter

comment created time in 6 days

PullRequestReviewEvent

delete branch nayeemrmn/deno

delete branch : worker-error-stack-trace

delete time in 7 days

push eventnayeemrmn/deno

Nayeem Rahman

commit sha c408a74e4327748362c85a2343d3cb7356f74ce7

Update cli/ops/worker_host.rs

view details

push time in 7 days

Pull request review commentdenoland/deno

fix(cli/worker): Print error stacks from the origin Worker

 pub fn init(rt: &mut deno_core::JsRuntime) {   );   super::reg_json_sync(rt, "op_host_post_message", op_host_post_message);   super::reg_json_async(rt, "op_host_get_message", op_host_get_message);+  super::reg_json_sync(+    rt,+    "op_host_unhandled_error",+    move |_state, args, _zero_copy| {+      if let Some(mut sender) = sender.clone() {+        let args: HostUnhandledErrorArgs = serde_json::from_value(args)?;+        sender+          .try_send(WorkerEvent::Error(generic_error(args.message)))+          .expect("Failed to propagate error event to parent worker");+        Ok(json!({}))
        Ok(json!(true))
nayeemrmn

comment created time in 7 days

PullRequestReviewEvent

Pull request review commentdenoland/deno

fix(cli/worker): Print error stacks from the origin Worker

+function foo() {+  throw new Error("foo");

The "message" being sent is Uncaught <error.name>: <error.message>. This is all that's sent to the host in browsers: image

nayeemrmn

comment created time in 7 days

PullRequestReviewEvent

Pull request review commentdenoland/deno

fix(cli/worker): Print error stacks from the origin Worker

 pub fn init(rt: &mut deno_core::JsRuntime) {   );   super::reg_json_sync(rt, "op_host_post_message", op_host_post_message);   super::reg_json_async(rt, "op_host_get_message", op_host_get_message);+  super::reg_json_sync(+    rt,+    "op_host_unhandled_error",+    move |_state, args, _zero_copy| {

It's a closure that uses structures only safe (or convenient) to retrieve during init, not available in op context under current infrastructure. Suggested here: https://discord.com/channels/684898665143206084/684911491035430919/766354819925278750.

nayeemrmn

comment created time in 7 days

PullRequestReviewEvent

push eventnayeemrmn/deno

Casper Beyer

commit sha 9d664f8375856be228e4f98b8381ac934d84604b

fix(cli/repl): ignore pair matching inside literals (#8037)

view details

Nayeem Rahman

commit sha 3f5513758d9e237d7c3775165c4164db89a95d31

feat(cli/installer): Add missing flags for deno install (#7601) This commit adds support for following flags: - deno install --importmap - deno install --no-remote - deno install --lock - deno install --lock-write - deno install --cached-only - deno install --v8-flags - deno install --seed

view details

Nayeem Rahman

commit sha 2a99c6c3f1f53fd54582be9434f3c8f688a1bc61

chore: Rename --importmap to --import-map

view details

push time in 7 days

delete branch nayeemrmn/deno

delete branch : install-missing-flags

delete time in 7 days

push eventnayeemrmn/deno

Ben Noordhuis

commit sha 46b892ad37df9ba9bed77fb923a1cfe284b208dc

refactor(core): more control over isolate creation (#8000) Make JSRuntime::new() accept a custom v8::CreateParams object to tune the v8::Isolate it creates. Subsumes the functionality of HeapLimits, which I therefore removed.

view details

Bartek Iwańczuk

commit sha c1c760130406405c8fde9a74bd88c62ca721967b

upgrade: deno_doc, deno_lint, dprint, swc (#8009)

view details

Casper Beyer

commit sha b33e8d5d427934544fa6e0de44df8793aae63c9d

refactor(cli/repl): extract is_closing to a function (#8015) This extracts is closing into a function so that it can easily be used as the condition for the loop.

view details

Bartek Iwańczuk

commit sha 8f9da368f78b0dcd55e701b30daea8b45102a491

refactor(lint): show hint for lint errors (#8016) This commit adds formatting of optional "hint" that can be present in lint diagnostic.

view details

Ryan Dahl

commit sha 3e51610bbb5d5d63863b9989690ca1e8127fdf88

Remove github actions cache (#8020) Running into issues with cache when trying to upgrade V8. Based on the analysis in https://github.com/denoland/deno/pull/7903#issuecomment-706252380 we know the cache is not providing much benefit.

view details

Casper Beyer

commit sha 065db9df19fa9f1f598fc3a5c7fd978b484428de

test(std/io): use a real tempdir (#8019) This replaces a case of a temp file in the working tree with a tempfile in a real temporary directory avoiding pollution of the working directory.

view details

Ryan Dahl

commit sha 59888ff0b27f75feb3ea88cdea943bf9fbd345fd

upgrade rusty_v8 (#8017)

view details

Ryan Dahl

commit sha fb2cae9687569fc891c13ab4a2862b9e66902a75

deno_core 0.64.0 (#8025)

view details

Casper Beyer

commit sha f91c1155f0cccef9a49efdcc489be3f258000957

docs(tools): add repl section (#8011) This adds a section on the repl with the keybindings that we support out of the box.

view details

Marcos Casagrande

commit sha d3dea24560f7434bd1020f0d9dc4c787f79479da

fix(std/tar): fix constant condition (#8010)

view details

Casper Beyer

commit sha f5c23f8058ed7ce85846c6b1e623329a09fa1a76

fix(cli/repl): write all results to stdout (#7893) This writes all evaluaton results to stdout regardless if the result is an error or not. This matches the behavior of other read-eval-print-loops like Node.

view details

Casper Beyer

commit sha 8eb44537ecb35aebf2aa95018ab8806ab899e0f7

fix(cli/repl): keyboard interrupt should continue (#7960) This changes the behavior of keyboard interrupts (ctrl+c) to continue, clearing the current line instead of exiting. Exit can still be done with ctrl+d or by calling close().

view details

Yoshiya Hinosawa

commit sha 342b151b5d9d6c97926588dd118b59032f3b0e40

docs(std/datetime): document toIMF, isLeap, difference, and constants (#7931)

view details

Nayeem Rahman

commit sha 19b918d112c786b1db17fe2d83be79f1114ba240

feat(std/path): Add toFileUrl() (#7971)

view details

Casper Beyer

commit sha e58763737e82db481a05e34ad883b1cd286dd05d

docs(getting_started): fix WebAssembly example (#8028)

view details

vwkd

commit sha e432db70e9b5628990517baa689b74721f6da8e1

docs: readTextFile / readTextFileSync throw when reading directory (#7999)

view details

Casper Beyer

commit sha 35028db5e571b4232dd58293cea7e5a8ec2e3571

fix(cli/repl): unterminated string literal should invalidate (#7896) This adds the grave character to the pair matching so that template string literals trigger multi-line edits.

view details

Luca Casonato

commit sha 08441b855d8cfbe7edd41811c8c719e5fae01f83

fix(op_crates/fetch): Body.body should be stream of Uint8Array (#8030)

view details

Casper Beyer

commit sha 9d664f8375856be228e4f98b8381ac934d84604b

fix(cli/repl): ignore pair matching inside literals (#8037)

view details

Nayeem Rahman

commit sha c353885348b7b2dac014d263f4befd5ab2a1ac98

feat(cli/main): Add deno cache --test

view details

push time in 7 days

Pull request review commentdenoland/deno

feat(std/testing): Add support for object assertion against object subset

 export function assertNotMatch(   } } +/**+ * Make an assertion that `actual` object is a subset of `expected` object, deeply.+ * If not, then throw.+ */+export function assertObjectMatch(+  actual: { [key: string]: unknown },+  expected: { [key: string]: unknown },

Should symbols be allowed?

lowlighter

comment created time in 7 days

PullRequestReviewEvent

Pull request review commentdenoland/deno

feat(cli/installer): Add missing flags for deno install

 itest!(_033_import_map {   output: "033_import_map.out", }); -itest!(import_map_no_unstable {-  args:-    "run --quiet --reload --importmap=importmaps/import_map.json importmaps/test.ts",-  output: "import_map_no_unstable.out",-  exit_code: 70,-});

Oh nevermind I never added a unit test for that flag dependency, but like every other unstable flag I think there's no need for an integration test as long as it's represented in flags.

nayeemrmn

comment created time in 7 days

PullRequestReviewEvent

Pull request review commentdenoland/deno

feat(cli/installer): Add missing flags for deno install

 itest!(_033_import_map {   output: "033_import_map.out", }); -itest!(import_map_no_unstable {-  args:-    "run --quiet --reload --importmap=importmaps/import_map.json importmaps/test.ts",-  output: "import_map_no_unstable.out",-  exit_code: 70,-});

This is tested in flags unit tests now. I also added .requires("unstable") on --import-map which wasn't there before, I suspect that's why this was mistakenly tested in integration tests.

nayeemrmn

comment created time in 7 days

PullRequestReviewEvent

issue commentdenoland/deno

API request: toFileURL

I'm interested in cases where fromFileUrl(toFileUrl(path)) != path (or the reverse), if anyone finds any.

callionica

comment created time in 7 days

delete branch nayeemrmn/deno

delete branch : to-file-url

delete time in 7 days

push eventnayeemrmn/deno

Kitson Kelly

commit sha bbe4474d39aecfabed52bd080e73d34978b6481b

fix(cli): ModuleGraph2 properly handles redirects (#7981)

view details

William Perron

commit sha 943b0980c7ff97cb6096291efa5e3d5dbfe10805

feat(cli/ops): add the sleep_sync op (#7974)

view details

Ben Noordhuis

commit sha 46b892ad37df9ba9bed77fb923a1cfe284b208dc

refactor(core): more control over isolate creation (#8000) Make JSRuntime::new() accept a custom v8::CreateParams object to tune the v8::Isolate it creates. Subsumes the functionality of HeapLimits, which I therefore removed.

view details

Bartek Iwańczuk

commit sha c1c760130406405c8fde9a74bd88c62ca721967b

upgrade: deno_doc, deno_lint, dprint, swc (#8009)

view details

push time in 8 days

push eventnayeemrmn/deno

Casper Beyer

commit sha fa80649926bd492b739b4d509008b38c27eeab06

refactor(cli/repl): get context id from notification (#7864) This takes the execution context id from a notification which is sent on Runtime.enable rather than hard-coding it to a magic value.

view details

Peter

commit sha 08f3ae92d3935559a5134bc5da900d3784142bf3

fix(std): Parsing inline arrays of inline tables in toml (#7902)

view details

Casper Beyer

commit sha 86dc55134ef25c1bc4f8db6c3c0dc635c1660ea4

fix(cli/console): only inspect getters with option (#7830)

view details

Yoshiya Hinosawa

commit sha 265a9fb9323a11067b4b826acc7624f2e62f1102

fix(console): fix inspection of Function (#7930) This commit fixes the inspection of functions. The current implementation gets the name of the type of the function from "f.__proto__.constructor.name", and it throws when the prototype is set to null. This commit checks the prototype before accessing its constructor name and uses the generic name 'Function' if the prototype is not available.

view details

Nayeem Rahman

commit sha 5f3028af13c25fb3af8f36d3d5913ef0688e5ce7

fix(cli/rt/main): Add global interface objects (#7875)

view details

Valentin Anger

commit sha fede13f2eb64f648e6c39aa01e2e0ede4e5be25e

feat(cli): support importmap flag with deno doc subcommand (#7821) Fixes #7783

view details

Kitson Kelly

commit sha e877b36072039811066726ab1619e7b5142f5680

refactor(cli): move info subcommand over to new module graph (#7892)

view details

Kitson Kelly

commit sha 26639b3bac463768c65f7fc40a1c53317549e1eb

chore(cli): remove dead code (#7941)

view details

timonson

commit sha 1956cb81372b96bc476e74ab43a62a6e60861277

fix(std/encoding): base64 properly encodes mbc and handles Uint8Arrays (#7807) Fixes #6094 Fixes #4794

view details

Kitson Kelly

commit sha 000ac5c40b71c38cc26a36e579fbb0936f0573d7

reafactor(cli): use Emit enum and rename ts_build_info (#7952)

view details

Bartek Iwańczuk

commit sha 0bd3cea0ff6d2d4840c0df2938b5ae5c5d7cc4bd

refactor(cli): rename GlobalState to ProgramState (#7914)

view details

Yoshiya Hinosawa

commit sha 0dcaea72aeec52a566764b41b10d8fd1854d6fa4

feat: add alert, confirm, and prompt (#7507) This commit adds "alert", "confirm" and "prompt" functions from web standards.

view details

Casper Beyer

commit sha bbf7b2ee72ae7dede26e4ef48b384404525f389e

feat(cli/repl): add regex based syntax highlighter (#7811) This commit adds a simple regex replace based highlighter to the REPL editor. It tries to match the color palette of Deno.inspect()

view details

Nayeem Rahman

commit sha d0c2714c033b010cbd174138638881dc65abef06

fix(op_crates/web/url): apply backslash replacement to the pathname setter (#7937)

view details

Grant Timmerman

commit sha 47eeb889e18cb5be5465a150b05b409d7f77fcb3

docs: fix runtime docs link in README (#7926)

view details

sakas

commit sha f42d0fc99e37bb0583cddeca5367a1dcf83d53b8

docs: fix links to examples (#7919)

view details

Ryan Dahl

commit sha 374d433f1f4885686dc5c166be3a25c839e22959

Remove dead code (#7963)

view details

Kitson Kelly

commit sha 10654fa95553866c63a56a7f84c7ec47fb7aac9c

refactor(cli): add tsc2 (#7942) Ref #7225

view details

Bartek Iwańczuk

commit sha 135053486c4bd112ebd7d0b25c94a8dd346472e6

fix: top-level-await module execution (#7946) This commit changes implementation of top-level-await in "deno_core". Previously promise returned from module evaluation was not awaited, leading to out-of-order execution of modules that have TLA. It's been fixed by changing "JsRuntime::mod_evaluate" to be an async function that resolves when the promise returned from module evaluation also resolves. When waiting for promise resolution event loop is polled repeatedly, until there are no more dynamic imports or pending ops.

view details

Casper Beyer

commit sha e2a1a7c937b67d050e7e3287d7e5dbc6ffd9b168

refactor(cli/repl): clean up prelude injection (#7967) This extracts prelude injection into a helper function and moves the prelude string literal into a top level static string to help trim some of the fat out of the run function.

view details

push time in 9 days

issue commentdenoland/deno

More detailed `deno test` output

Duplicate of #4644.

Soremwar

comment created time in 10 days

push eventnayeemrmn/deno

Bartek Iwańczuk

commit sha bd0c64b9aeeb75eea25402b0ebd5aecc2cec8e3a

Reland feat(cli/console): inspect with colors regardless of Deno.noColor (#7976)

view details

Kitson Kelly

commit sha bbe4474d39aecfabed52bd080e73d34978b6481b

fix(cli): ModuleGraph2 properly handles redirects (#7981)

view details

William Perron

commit sha 943b0980c7ff97cb6096291efa5e3d5dbfe10805

feat(cli/ops): add the sleep_sync op (#7974)

view details

Nayeem Rahman

commit sha e95427f297055cc1b8317b010d49d2e98a318151

feat(cli/main): Add deno cache --test

view details

push time in 11 days

push eventnayeemrmn/deno

Bartek Iwańczuk

commit sha bd0c64b9aeeb75eea25402b0ebd5aecc2cec8e3a

Reland feat(cli/console): inspect with colors regardless of Deno.noColor (#7976)

view details

Kitson Kelly

commit sha bbe4474d39aecfabed52bd080e73d34978b6481b

fix(cli): ModuleGraph2 properly handles redirects (#7981)

view details

William Perron

commit sha 943b0980c7ff97cb6096291efa5e3d5dbfe10805

feat(cli/ops): add the sleep_sync op (#7974)

view details

Nayeem Rahman

commit sha cf204b3f3583c1b2f39a1577be9b5e64030a24d1

feat(std/path): Add toFileUrl()

view details

push time in 11 days

push eventnayeemrmn/deno

Nayeem Rahman

commit sha 6aa6e00ae28864e9757a44d6ec130e2149a0bfe6

fixup! fix(cli/worker): Print error stacks from the origin Worker

view details

push time in 11 days

push eventnayeemrmn/deno

Nayeem Rahman

commit sha b54d05d71dc1727690524fa7a16542e7ad6a45b2

fixup! fix(cli/worker): Print error stacks from the origin Worker

view details

push time in 11 days

PR opened denoland/deno

fix(cli/worker): Print error stacks from the origin Worker

Fixes #4728.

cc @bartlomieju

+129 -42

0 comment

10 changed files

pr created time in 11 days

create barnchnayeemrmn/deno

branch : worker-error-stack-trace

created branch time in 11 days

push eventnayeemrmn/deno

TTtie

commit sha f75bd89aff7cffafceb394d629995479af54a156

feat(cli/console): inspect with colors regardless of Deno.noColor (#7778) This commit adds the ability for users to inspect items stylized with ANSI colors regardless of the value of Deno.noColor.

view details

ali ahmed

commit sha 5bed06fb94214db70a27cca8fa8eff717d537dba

feat(std/fs/node): adding some functions (#7921)

view details

Bartek Iwańczuk

commit sha 81635c59e66b81a4c85aed6775aff4beedf71f14

Revert "feat(cli/console): inspect with colors regardless of Deno.noColor (#7778)" (#7973) This reverts commit f75bd89aff7cffafceb394d629995479af54a156.

view details

Bartek Iwańczuk

commit sha bd0c64b9aeeb75eea25402b0ebd5aecc2cec8e3a

Reland feat(cli/console): inspect with colors regardless of Deno.noColor (#7976)

view details

push time in 12 days

issue commentdenoland/deno

Proposal: std/testing callback helpers

The problem isn't callbacks, "test that f() runs x times in n milliseconds" is just a really specific and strange testing helper. There are usually better ways of testing stuff like this which produce more helpful errors. It's not like you can have a big suite of tests that take a second each to run.

Soremwar

comment created time in 12 days

push eventnayeemrmn/deno

Kitson Kelly

commit sha e877b36072039811066726ab1619e7b5142f5680

refactor(cli): move info subcommand over to new module graph (#7892)

view details

Kitson Kelly

commit sha 26639b3bac463768c65f7fc40a1c53317549e1eb

chore(cli): remove dead code (#7941)

view details

timonson

commit sha 1956cb81372b96bc476e74ab43a62a6e60861277

fix(std/encoding): base64 properly encodes mbc and handles Uint8Arrays (#7807) Fixes #6094 Fixes #4794

view details

Kitson Kelly

commit sha 000ac5c40b71c38cc26a36e579fbb0936f0573d7

reafactor(cli): use Emit enum and rename ts_build_info (#7952)

view details

Bartek Iwańczuk

commit sha 0bd3cea0ff6d2d4840c0df2938b5ae5c5d7cc4bd

refactor(cli): rename GlobalState to ProgramState (#7914)

view details

Yoshiya Hinosawa

commit sha 0dcaea72aeec52a566764b41b10d8fd1854d6fa4

feat: add alert, confirm, and prompt (#7507) This commit adds "alert", "confirm" and "prompt" functions from web standards.

view details

Casper Beyer

commit sha bbf7b2ee72ae7dede26e4ef48b384404525f389e

feat(cli/repl): add regex based syntax highlighter (#7811) This commit adds a simple regex replace based highlighter to the REPL editor. It tries to match the color palette of Deno.inspect()

view details

Nayeem Rahman

commit sha d0c2714c033b010cbd174138638881dc65abef06

fix(op_crates/web/url): apply backslash replacement to the pathname setter (#7937)

view details

Grant Timmerman

commit sha 47eeb889e18cb5be5465a150b05b409d7f77fcb3

docs: fix runtime docs link in README (#7926)

view details

sakas

commit sha f42d0fc99e37bb0583cddeca5367a1dcf83d53b8

docs: fix links to examples (#7919)

view details

Ryan Dahl

commit sha 374d433f1f4885686dc5c166be3a25c839e22959

Remove dead code (#7963)

view details

Kitson Kelly

commit sha 10654fa95553866c63a56a7f84c7ec47fb7aac9c

refactor(cli): add tsc2 (#7942) Ref #7225

view details

Bartek Iwańczuk

commit sha 135053486c4bd112ebd7d0b25c94a8dd346472e6

fix: top-level-await module execution (#7946) This commit changes implementation of top-level-await in "deno_core". Previously promise returned from module evaluation was not awaited, leading to out-of-order execution of modules that have TLA. It's been fixed by changing "JsRuntime::mod_evaluate" to be an async function that resolves when the promise returned from module evaluation also resolves. When waiting for promise resolution event loop is polled repeatedly, until there are no more dynamic imports or pending ops.

view details

Casper Beyer

commit sha e2a1a7c937b67d050e7e3287d7e5dbc6ffd9b168

refactor(cli/repl): clean up prelude injection (#7967) This extracts prelude injection into a helper function and moves the prelude string literal into a top level static string to help trim some of the fat out of the run function.

view details

Yoshiya Hinosawa

commit sha e9f02c231473ba42f506a895734d445cd31d379f

fix(console): fix the test cases of function inspections (#7965)

view details

Bartek Iwańczuk

commit sha 12e700bddfad8c23f6b55baca4ca4afb8337af26

fix(test): return error when awaiting unresolved promise (#7968) This commit fixes test runner by awaitning "Deno.runTests()" call, which ensures proper error is returned when there's an unresolved promise that's being awaited.

view details

vwkd

commit sha f9489e9acb0e3121bbd71ef0cf1826320d0c0995

fix typos (#7964)

view details

TTtie

commit sha f75bd89aff7cffafceb394d629995479af54a156

feat(cli/console): inspect with colors regardless of Deno.noColor (#7778) This commit adds the ability for users to inspect items stylized with ANSI colors regardless of the value of Deno.noColor.

view details

ali ahmed

commit sha 5bed06fb94214db70a27cca8fa8eff717d537dba

feat(std/fs/node): adding some functions (#7921)

view details

Bartek Iwańczuk

commit sha 81635c59e66b81a4c85aed6775aff4beedf71f14

Revert "feat(cli/console): inspect with colors regardless of Deno.noColor (#7778)" (#7973) This reverts commit f75bd89aff7cffafceb394d629995479af54a156.

view details

push time in 12 days

push eventnayeemrmn/deno

Bartek Iwańczuk

commit sha 81635c59e66b81a4c85aed6775aff4beedf71f14

Revert "feat(cli/console): inspect with colors regardless of Deno.noColor (#7778)" (#7973) This reverts commit f75bd89aff7cffafceb394d629995479af54a156.

view details

Nayeem Rahman

commit sha 378b7a24b3d9d9ea921c564667c7fc013a8dffa9

feat(std/path): Add toFileUrl()

view details

push time in 12 days

push eventnayeemrmn/deno

Bartek Iwańczuk

commit sha 81635c59e66b81a4c85aed6775aff4beedf71f14

Revert "feat(cli/console): inspect with colors regardless of Deno.noColor (#7778)" (#7973) This reverts commit f75bd89aff7cffafceb394d629995479af54a156.

view details

Nayeem Rahman

commit sha e15ddf06c04cf5ff14d666f2e5f356901260e51b

feat(cli/main): Add deno cache --test

view details

push time in 12 days

push eventnayeemrmn/deno

Bartek Iwańczuk

commit sha 81635c59e66b81a4c85aed6775aff4beedf71f14

Revert "feat(cli/console): inspect with colors regardless of Deno.noColor (#7778)" (#7973) This reverts commit f75bd89aff7cffafceb394d629995479af54a156.

view details

Nayeem Rahman

commit sha faea0ebbc7948bb1bcba18881608c129613f3556

feat(cli/installer): Add missing flags for deno install

view details

push time in 12 days

push eventnayeemrmn/deno

Kitson Kelly

commit sha 26639b3bac463768c65f7fc40a1c53317549e1eb

chore(cli): remove dead code (#7941)

view details

timonson

commit sha 1956cb81372b96bc476e74ab43a62a6e60861277

fix(std/encoding): base64 properly encodes mbc and handles Uint8Arrays (#7807) Fixes #6094 Fixes #4794

view details

Kitson Kelly

commit sha 000ac5c40b71c38cc26a36e579fbb0936f0573d7

reafactor(cli): use Emit enum and rename ts_build_info (#7952)

view details

Bartek Iwańczuk

commit sha 0bd3cea0ff6d2d4840c0df2938b5ae5c5d7cc4bd

refactor(cli): rename GlobalState to ProgramState (#7914)

view details

Yoshiya Hinosawa

commit sha 0dcaea72aeec52a566764b41b10d8fd1854d6fa4

feat: add alert, confirm, and prompt (#7507) This commit adds "alert", "confirm" and "prompt" functions from web standards.

view details

Casper Beyer

commit sha bbf7b2ee72ae7dede26e4ef48b384404525f389e

feat(cli/repl): add regex based syntax highlighter (#7811) This commit adds a simple regex replace based highlighter to the REPL editor. It tries to match the color palette of Deno.inspect()

view details

Nayeem Rahman

commit sha d0c2714c033b010cbd174138638881dc65abef06

fix(op_crates/web/url): apply backslash replacement to the pathname setter (#7937)

view details

Grant Timmerman

commit sha 47eeb889e18cb5be5465a150b05b409d7f77fcb3

docs: fix runtime docs link in README (#7926)

view details

sakas

commit sha f42d0fc99e37bb0583cddeca5367a1dcf83d53b8

docs: fix links to examples (#7919)

view details

Ryan Dahl

commit sha 374d433f1f4885686dc5c166be3a25c839e22959

Remove dead code (#7963)

view details

Kitson Kelly

commit sha 10654fa95553866c63a56a7f84c7ec47fb7aac9c

refactor(cli): add tsc2 (#7942) Ref #7225

view details

Bartek Iwańczuk

commit sha 135053486c4bd112ebd7d0b25c94a8dd346472e6

fix: top-level-await module execution (#7946) This commit changes implementation of top-level-await in "deno_core". Previously promise returned from module evaluation was not awaited, leading to out-of-order execution of modules that have TLA. It's been fixed by changing "JsRuntime::mod_evaluate" to be an async function that resolves when the promise returned from module evaluation also resolves. When waiting for promise resolution event loop is polled repeatedly, until there are no more dynamic imports or pending ops.

view details

Casper Beyer

commit sha e2a1a7c937b67d050e7e3287d7e5dbc6ffd9b168

refactor(cli/repl): clean up prelude injection (#7967) This extracts prelude injection into a helper function and moves the prelude string literal into a top level static string to help trim some of the fat out of the run function.

view details

Yoshiya Hinosawa

commit sha e9f02c231473ba42f506a895734d445cd31d379f

fix(console): fix the test cases of function inspections (#7965)

view details

Bartek Iwańczuk

commit sha 12e700bddfad8c23f6b55baca4ca4afb8337af26

fix(test): return error when awaiting unresolved promise (#7968) This commit fixes test runner by awaitning "Deno.runTests()" call, which ensures proper error is returned when there's an unresolved promise that's being awaited.

view details

vwkd

commit sha f9489e9acb0e3121bbd71ef0cf1826320d0c0995

fix typos (#7964)

view details

TTtie

commit sha f75bd89aff7cffafceb394d629995479af54a156

feat(cli/console): inspect with colors regardless of Deno.noColor (#7778) This commit adds the ability for users to inspect items stylized with ANSI colors regardless of the value of Deno.noColor.

view details

ali ahmed

commit sha 5bed06fb94214db70a27cca8fa8eff717d537dba

feat(std/fs/node): adding some functions (#7921)

view details

Nayeem Rahman

commit sha 0e26db555e27842b5302b39a73217ef587d87b99

feat(cli/installer): Add missing flags for deno install

view details

push time in 12 days

push eventnayeemrmn/deno

Nayeem Rahman

commit sha 95bc49be52bf45d734f63319711d2125256f05f1

Reset CI

view details

push time in 12 days

push eventnayeemrmn/deno

Nayeem Rahman

commit sha 5f3028af13c25fb3af8f36d3d5913ef0688e5ce7

fix(cli/rt/main): Add global interface objects (#7875)

view details

Valentin Anger

commit sha fede13f2eb64f648e6c39aa01e2e0ede4e5be25e

feat(cli): support importmap flag with deno doc subcommand (#7821) Fixes #7783

view details

Kitson Kelly

commit sha e877b36072039811066726ab1619e7b5142f5680

refactor(cli): move info subcommand over to new module graph (#7892)

view details

Kitson Kelly

commit sha 26639b3bac463768c65f7fc40a1c53317549e1eb

chore(cli): remove dead code (#7941)

view details

timonson

commit sha 1956cb81372b96bc476e74ab43a62a6e60861277

fix(std/encoding): base64 properly encodes mbc and handles Uint8Arrays (#7807) Fixes #6094 Fixes #4794

view details

Kitson Kelly

commit sha 000ac5c40b71c38cc26a36e579fbb0936f0573d7

reafactor(cli): use Emit enum and rename ts_build_info (#7952)

view details

Bartek Iwańczuk

commit sha 0bd3cea0ff6d2d4840c0df2938b5ae5c5d7cc4bd

refactor(cli): rename GlobalState to ProgramState (#7914)

view details

Yoshiya Hinosawa

commit sha 0dcaea72aeec52a566764b41b10d8fd1854d6fa4

feat: add alert, confirm, and prompt (#7507) This commit adds "alert", "confirm" and "prompt" functions from web standards.

view details

Casper Beyer

commit sha bbf7b2ee72ae7dede26e4ef48b384404525f389e

feat(cli/repl): add regex based syntax highlighter (#7811) This commit adds a simple regex replace based highlighter to the REPL editor. It tries to match the color palette of Deno.inspect()

view details

Nayeem Rahman

commit sha d0c2714c033b010cbd174138638881dc65abef06

fix(op_crates/web/url): apply backslash replacement to the pathname setter (#7937)

view details

Grant Timmerman

commit sha 47eeb889e18cb5be5465a150b05b409d7f77fcb3

docs: fix runtime docs link in README (#7926)

view details

sakas

commit sha f42d0fc99e37bb0583cddeca5367a1dcf83d53b8

docs: fix links to examples (#7919)

view details

Ryan Dahl

commit sha 374d433f1f4885686dc5c166be3a25c839e22959

Remove dead code (#7963)

view details

Kitson Kelly

commit sha 10654fa95553866c63a56a7f84c7ec47fb7aac9c

refactor(cli): add tsc2 (#7942) Ref #7225

view details

Bartek Iwańczuk

commit sha 135053486c4bd112ebd7d0b25c94a8dd346472e6

fix: top-level-await module execution (#7946) This commit changes implementation of top-level-await in "deno_core". Previously promise returned from module evaluation was not awaited, leading to out-of-order execution of modules that have TLA. It's been fixed by changing "JsRuntime::mod_evaluate" to be an async function that resolves when the promise returned from module evaluation also resolves. When waiting for promise resolution event loop is polled repeatedly, until there are no more dynamic imports or pending ops.

view details

Casper Beyer

commit sha e2a1a7c937b67d050e7e3287d7e5dbc6ffd9b168

refactor(cli/repl): clean up prelude injection (#7967) This extracts prelude injection into a helper function and moves the prelude string literal into a top level static string to help trim some of the fat out of the run function.

view details

Yoshiya Hinosawa

commit sha e9f02c231473ba42f506a895734d445cd31d379f

fix(console): fix the test cases of function inspections (#7965)

view details

Bartek Iwańczuk

commit sha 12e700bddfad8c23f6b55baca4ca4afb8337af26

fix(test): return error when awaiting unresolved promise (#7968) This commit fixes test runner by awaitning "Deno.runTests()" call, which ensures proper error is returned when there's an unresolved promise that's being awaited.

view details

vwkd

commit sha f9489e9acb0e3121bbd71ef0cf1826320d0c0995

fix typos (#7964)

view details

TTtie

commit sha f75bd89aff7cffafceb394d629995479af54a156

feat(cli/console): inspect with colors regardless of Deno.noColor (#7778) This commit adds the ability for users to inspect items stylized with ANSI colors regardless of the value of Deno.noColor.

view details

push time in 12 days

PR opened denoland/deno

feat(std/path): Add toFileUrl()

Closes #7929.

+89 -5

0 comment

4 changed files

pr created time in 12 days

create barnchnayeemrmn/deno

branch : to-file-url

created branch time in 12 days

push eventnayeemrmn/deno

vwkd

commit sha f9489e9acb0e3121bbd71ef0cf1826320d0c0995

fix typos (#7964)

view details

push time in 12 days

push eventnayeemrmn/deno

Ryan Dahl

commit sha 374d433f1f4885686dc5c166be3a25c839e22959

Remove dead code (#7963)

view details

Kitson Kelly

commit sha 10654fa95553866c63a56a7f84c7ec47fb7aac9c

refactor(cli): add tsc2 (#7942) Ref #7225

view details

Bartek Iwańczuk

commit sha 135053486c4bd112ebd7d0b25c94a8dd346472e6

fix: top-level-await module execution (#7946) This commit changes implementation of top-level-await in "deno_core". Previously promise returned from module evaluation was not awaited, leading to out-of-order execution of modules that have TLA. It's been fixed by changing "JsRuntime::mod_evaluate" to be an async function that resolves when the promise returned from module evaluation also resolves. When waiting for promise resolution event loop is polled repeatedly, until there are no more dynamic imports or pending ops.

view details

Casper Beyer

commit sha e2a1a7c937b67d050e7e3287d7e5dbc6ffd9b168

refactor(cli/repl): clean up prelude injection (#7967) This extracts prelude injection into a helper function and moves the prelude string literal into a top level static string to help trim some of the fat out of the run function.

view details

Yoshiya Hinosawa

commit sha e9f02c231473ba42f506a895734d445cd31d379f

fix(console): fix the test cases of function inspections (#7965)

view details

Bartek Iwańczuk

commit sha 12e700bddfad8c23f6b55baca4ca4afb8337af26

fix(test): return error when awaiting unresolved promise (#7968) This commit fixes test runner by awaitning "Deno.runTests()" call, which ensures proper error is returned when there's an unresolved promise that's being awaited.

view details

push time in 12 days

pull request commentdenoland/deno

fix(cli/repl): keyboard interrupt should continue

Note that the existing SIGINT behaviour still remains when an actual execution in interrupted: image

caspervonb

comment created time in 13 days

push eventnayeemrmn/deno

Casper Beyer

commit sha fa80649926bd492b739b4d509008b38c27eeab06

refactor(cli/repl): get context id from notification (#7864) This takes the execution context id from a notification which is sent on Runtime.enable rather than hard-coding it to a magic value.

view details

Peter

commit sha 08f3ae92d3935559a5134bc5da900d3784142bf3

fix(std): Parsing inline arrays of inline tables in toml (#7902)

view details

Casper Beyer

commit sha 86dc55134ef25c1bc4f8db6c3c0dc635c1660ea4

fix(cli/console): only inspect getters with option (#7830)

view details

Yoshiya Hinosawa

commit sha 265a9fb9323a11067b4b826acc7624f2e62f1102

fix(console): fix inspection of Function (#7930) This commit fixes the inspection of functions. The current implementation gets the name of the type of the function from "f.__proto__.constructor.name", and it throws when the prototype is set to null. This commit checks the prototype before accessing its constructor name and uses the generic name 'Function' if the prototype is not available.

view details

Nayeem Rahman

commit sha 5f3028af13c25fb3af8f36d3d5913ef0688e5ce7

fix(cli/rt/main): Add global interface objects (#7875)

view details

Valentin Anger

commit sha fede13f2eb64f648e6c39aa01e2e0ede4e5be25e

feat(cli): support importmap flag with deno doc subcommand (#7821) Fixes #7783

view details

Kitson Kelly

commit sha e877b36072039811066726ab1619e7b5142f5680

refactor(cli): move info subcommand over to new module graph (#7892)

view details

Kitson Kelly

commit sha 26639b3bac463768c65f7fc40a1c53317549e1eb

chore(cli): remove dead code (#7941)

view details

timonson

commit sha 1956cb81372b96bc476e74ab43a62a6e60861277

fix(std/encoding): base64 properly encodes mbc and handles Uint8Arrays (#7807) Fixes #6094 Fixes #4794

view details

Kitson Kelly

commit sha 000ac5c40b71c38cc26a36e579fbb0936f0573d7

reafactor(cli): use Emit enum and rename ts_build_info (#7952)

view details

Bartek Iwańczuk

commit sha 0bd3cea0ff6d2d4840c0df2938b5ae5c5d7cc4bd

refactor(cli): rename GlobalState to ProgramState (#7914)

view details

Yoshiya Hinosawa

commit sha 0dcaea72aeec52a566764b41b10d8fd1854d6fa4

feat: add alert, confirm, and prompt (#7507) This commit adds "alert", "confirm" and "prompt" functions from web standards.

view details

Casper Beyer

commit sha bbf7b2ee72ae7dede26e4ef48b384404525f389e

feat(cli/repl): add regex based syntax highlighter (#7811) This commit adds a simple regex replace based highlighter to the REPL editor. It tries to match the color palette of Deno.inspect()

view details

Nayeem Rahman

commit sha d0c2714c033b010cbd174138638881dc65abef06

fix(op_crates/web/url): apply backslash replacement to the pathname setter (#7937)

view details

Grant Timmerman

commit sha 47eeb889e18cb5be5465a150b05b409d7f77fcb3

docs: fix runtime docs link in README (#7926)

view details

sakas

commit sha f42d0fc99e37bb0583cddeca5367a1dcf83d53b8

docs: fix links to examples (#7919)

view details

push time in 13 days

Pull request review commentdenoland/deno

fix(cli/rt/console): fix inspection of Function

 unitTest(function consoleTestStringifyCircular(): void { }); /* eslint-enable @typescript-eslint/explicit-function-return-type */ +unitTest(function consoleTestStringifyFunctionWithPrototypeRemoved(): void {+  const f = function f() {};+  Reflect.setPrototypeOf(f, null);+  assertEquals(stringify(f), "[Function: f]");+  const af = async function af() {};+  Reflect.setPrototypeOf(af, null);+  assertEquals(stringify(af), "[Function: af]");+  const gf = function gf() {};+  Reflect.setPrototypeOf(gf, null);+  assertEquals(stringify(gf), "[Function: gf]");+  const agf = function agf() {};+  Reflect.setPrototypeOf(agf, null);+  assertEquals(stringify(agf), "[Function: agf]");

function* gf() {} and async function* agf() {}

Are you saying they should have their own output? That's just declaration-side syntactic sugar.

kt3k

comment created time in 13 days

PullRequestReviewEvent

delete branch nayeemrmn/deno

delete branch : pathname-encoding

delete time in 13 days

more