profile
viewpoint
David Serafimov nasadigital @Microsoft Vancouver Canada

harismandal/ProektVP 0

ProektnaVPLavirint

nasadigital/caide 0

Automates certain common tasks that you do during programming competitions

nasadigital/hermes-windows 0

Hermes is a small and lightweight JavaScript engine optimized for running React Native on Android.

nasadigital/react-native-windows 0

A framework for building native Windows apps with React.

IssuesEvent

issue commentmicrosoft/react-native-windows

Remote debugging Playground with web debugging doesn't work anymore

The PR only fixes remote debugging in the Playground app, so I'm reopening the issue.

kmelmon

comment created time in 3 months

push eventmicrosoft/react-native-windows

David Serafimov

commit sha d3d51b8377fc990f82aa9816846098e6f132eb56

Fix remote debugging with web debugging in Playground. (#5327) * Allow setting debug host as a command line argument in Playground. * Fix namespace issue and rename debugHost to something more appropriate. * Align variable name with naming convention and remove unused variable.

view details

push time in 3 months

PR merged microsoft/react-native-windows

Fix remote debugging with web debugging in Playground. Area: Debug Infrastructure

Fixes #5112. To remote debug the Playground app follow the steps in the wiki: https://github.com/microsoft/react-native-windows/wiki/VS-Remote-Debugging Don't forget to open the port on the host machine. This implementation is based on #3535. Limitations:

  • There is no way to specify only the hostname or only the port, you have to specify both.
  • Not sure what I am missing but running yarn change gives me the following error so I couldn't update the changelog: Annotation 2020-06-23 192843
Microsoft Reviewers: Open in CodeFlow
+10 -1

1 comment

3 changed files

nasadigital

pr closed time in 3 months

issue closedmicrosoft/react-native-windows

Remote debugging Playground with web debugging doesn't work anymore

We added some support for remote debugging the Playground app, see: https://github.com/microsoft/react-native-windows/wiki/VS-Remote-Debugging

However this technique doesn't work anymore. I debugged this and found two issues:

  1. The privateNetworkClientServer capability isn't turned on in Package.appxmanifest
  2. The client code is failing to connect due to using localhost:8081. It looks like we're missing the plumbing code that was originally added to HostingPane, which is no longer being used in Playground.

We should find a way to re-enable this. We should also think about how to enable remote debugging for CLI apps when we fix this - ideally whatever we do would also work for template apps.

closed time in 3 months

kmelmon

pull request commentmicrosoft/react-native-windows

Fix remote debugging with web debugging in Playground.

Thank you for reviewing!

nasadigital

comment created time in 3 months

issue openedmicrosoft/react-native-windows

Rename DebugHost from ReactInstanceSettings to something more appropriate?

The DebugHost property is used to specify the bundler, which might not be clear from the name (particularly in remote debugging scenarios). To boot, the individual settings to set the hostname (SourceBundleHost) and port (SourceBundlePort) don't align with the naming scheme. After talking with @asklar the conclusion was that the name should better reflect this or that this could be better documented.

created time in 3 months

push eventnasadigital/react-native-windows

David Serafimov

commit sha 10f9ee2a4f754abd059404e0752dda950ea7461f

Align variable name with naming convention and remove unused variable.

view details

push time in 3 months

Pull request review commentmicrosoft/react-native-windows

Fix remote debugging with web debugging in Playground.

 struct MainPage : MainPageT<MainPage> {   Windows::Foundation::Collections::IVector<Microsoft::ReactNative::IReactPackageProvider> m_packageProviders;    bool m_useWebDebugger{false};+  winrt::hstring debugHost;

My bad, I also went ahead and removed the the other variable since it wasn't used.

nasadigital

comment created time in 3 months

push eventnasadigital/react-native-windows

David Serafimov

commit sha 823bbd6b9a2ad49aba0b985a4ce8c5b30e403908

Fix namespace issue and rename debugHost to something more appropriate.

view details

push time in 3 months

PR opened microsoft/react-native-windows

Fix remote debugging with web debugging in Playground.

Fixes #5112. To remote debug the Playground app follow the steps in the wiki: https://github.com/microsoft/react-native-windows/wiki/VS-Remote-Debugging Don't forget to open the port on the host machine. This implementation is based on #3535. Limitations:

  • There is no way to specify only the hostname or only the port, you have to specify both.
  • Not sure what I am missing but running yarn change gives me the following error so I couldn't update the changelog: Annotation 2020-06-23 192843
+10 -0

0 comment

3 changed files

pr created time in 3 months

push eventnasadigital/react-native-windows

David Serafimov

commit sha bf7d91d7a13e3a16f35c371ee6b1e6f272b4a191

Allow setting debug host as a command line argument in Playground.

view details

push time in 3 months

push eventnasadigital/react-native-windows

push time in 3 months

create barnchnasadigital/react-native-windows

branch : fixRemoteDebuggingPlayground

created branch time in 3 months

push eventnasadigital/react-native-windows

Igor Klemenski

commit sha 8fd8dcd3b4c6783ad176c620df57521c8131b894

Fix - onPress callback not working for nested <Text> elements (#5125) * Fix - onPress callback not working for nested <Text> elements * fix xaml namespaces; handle RTL * fix formatting * Change files Co-authored-by: Igor Klemenski <igklemen@microsoft.com>

view details

dependabot-preview[bot]

commit sha 86b9cd07dc6895c10378fa8e218015a7ace72085

Bump lerna from 3.22.0 to 3.22.1 (#5157)

view details

dependabot-preview[bot]

commit sha 19c35585d90df557ef6d4947daaee0a15cecc7be

Bump fp-ts from 2.6.3 to 2.6.4 (#5156)

view details

tkamireh

commit sha 93251e5714cfc7ac6211af4e809251d2d3ba7050

ViewWin32 Cursor Prop Type Expanded (#5154) * expand cursor prop + test comopnent * lingering api updates * Change files * remove props for params for test component'

view details

React-Native-Windows Bot

commit sha dd3622ac0f683d68d86f6c58f9f4270d24acb2a6

applying package updates ***NO_CI***

view details

Zihan Chen (MSFT)

commit sha 2f479757c611f1491ea4b47b74f8f76bbe03a39a

Call turbo module in IntegrationTests (#5162) * Call turbo module in IntegrationTests * Change files * ...

view details

Julio César Rocha

commit sha 246cea3abb852dabdcb96e40614e74e909af05d2

Manually set Lib and Include paths for Hermes (#5163) * Manually set Lib and Include paths for Hermes * Change files * Use PlatformTarget for Hermes path resolution * Parameterize path for JSI_Source * MUFA: Make USE_HERMES False Again! * Remove redundant FollyDir vars logging

view details

Andrew Coates

commit sha 72d108144cfddecff3c8e61bc41b13487917bb53

Add support for RedBox's on XamlIslands (#5159) * Add support for redbox's on xamlislands * Change files * Remove playground win32's redbox impl.

view details

dannyvv

commit sha 2a8b11778ed8c7a44d9a9dc0779c15b1fd87f50f

Add Documentation page for React Native Windows Init templating (#5142) * Add React Native Windows Init documentation for mustache templating * Update docs/react-native-windows-init.md Co-authored-by: Alexander Sklar <asklar@microsoft.com> * Update docs/react-native-windows-init.md Co-authored-by: Alexander Sklar <asklar@microsoft.com> * Update docs/react-native-windows-init.md Co-authored-by: Alexander Sklar <asklar@microsoft.com> * Update docs/react-native-windows-init.md Co-authored-by: Alexander Sklar <asklar@microsoft.com> * Update docs/react-native-windows-init.md Co-authored-by: Alexander Sklar <asklar@microsoft.com> * Update docs/react-native-windows-init.md Co-authored-by: Alexander Sklar <asklar@microsoft.com> * Update docs/react-native-windows-init.md Co-authored-by: Alexander Sklar <asklar@microsoft.com> * Update docs/react-native-windows-init.md Co-authored-by: Alexander Sklar <asklar@microsoft.com> * Update docs/react-native-windows-init.md Co-authored-by: Alexander Sklar <asklar@microsoft.com>

view details

dependabot-preview[bot]

commit sha 345d6c2eb9af6d3a5183b23b7402eba4b67e9a8d

Bump fp-ts from 2.6.4 to 2.6.5 (#5165)

view details

Alexander Sklar

commit sha 7062c6ea760096e6d989179098ee33622d1ee3ec

More rnw-dependencies improvements (#5169) * More rnw-dependencies improvements * Change files

view details

React-Native-Windows Bot

commit sha 41d8e7a09302832ea7d23e38811da110f6ada661

applying package updates ***NO_CI***

view details

Andrew Coates

commit sha 0708c894840a0ec51071a9b2b4a8189d3d59ff66

We shouldn't ever need to install RN globally (#5164)

view details

dannyvv

commit sha 7d7b6fb2b392acc7956e32398ac779e78ad0e4cf

Fix support for `--namespace` on react-native-windows init for cpp (#5145) * Fix support for `--namespace` on react-native-windows init for cpp * Change files

view details

React-Native-Windows Bot

commit sha 62a14769b6be82f84e1da2b3dc5813cf8d2aa5c6

applying package updates ***NO_CI***

view details

dannyvv

commit sha 36eaf59b161a8c2aa3dd66e1be338c00211b57f9

Add documentation page for Managed CodeGen for Native Modules (#5141) * Add documentation page for Managed CodeGen for Native Modules Co-authored-by: Alexander Sklar <asklar@microsoft.com>

view details

dannyvv

commit sha 394573753837320f51e9e3969e149961f3471480

Fix file lock issue with MSBuild's `/bl` flag and the metro bundler (#5186) * Fix file lock issue wiht msbuild /bl flag and the metro bundler * Change files

view details

tkamireh

commit sha 67a72aca889f27e2d7bc1e4596d92f36bf311a87

Add focusRef to TouchableWin32 (#5108) * Add focusRef prop to TouchableWin32 * Add example * polish example * API md generation * Change files * internal ref + indirection approach * api fixes * show an example of ref forwarding using a class component

view details

Andrew Coates

commit sha ef0fd96936b64d21345366bf49e96123bf60fa1c

Add Microsoft.ReactNative.Cxx to the nuget package (#5184) * Add Microsoft.ReactNative.Cxx to the nugets. * Change files * pack nuget from location that contains headers and build artifacts

view details

Zihan Chen (MSFT)

commit sha de852396cf3c6e5bb9c15da97a59b3e0256831e3

Implement SyncMethod and Constant for TurboModule (#5171) * Implement SyncMethod and Constant for TurboModule * Change files

view details

push time in 3 months

more