profile
viewpoint
David Serafimov nasadigital @Microsoft Vancouver Canada

microsoft/vscode-python-devicesimulator 80

Device Simulator Express, a Microsoft Garage project

harismandal/ProektVP 0

ProektnaVPLavirint

nasadigital/caide 0

Automates certain common tasks that you do during programming competitions

nasadigital/hermes-windows 0

Hermes is a small and lightweight JavaScript engine optimized for running React Native on Android.

nasadigital/react-native-windows 0

A framework for building native Windows apps with React.

IssuesEvent

issue commentmicrosoft/react-native-windows

Remote debugging Playground with web debugging doesn't work anymore

The PR only fixes remote debugging in the Playground app, so I'm reopening the issue.

kmelmon

comment created time in 17 days

push eventmicrosoft/react-native-windows

David Serafimov

commit sha d3d51b8377fc990f82aa9816846098e6f132eb56

Fix remote debugging with web debugging in Playground. (#5327) * Allow setting debug host as a command line argument in Playground. * Fix namespace issue and rename debugHost to something more appropriate. * Align variable name with naming convention and remove unused variable.

view details

push time in 17 days

PR merged microsoft/react-native-windows

Fix remote debugging with web debugging in Playground. Area: Debug Infrastructure

Fixes #5112. To remote debug the Playground app follow the steps in the wiki: https://github.com/microsoft/react-native-windows/wiki/VS-Remote-Debugging Don't forget to open the port on the host machine. This implementation is based on #3535. Limitations:

  • There is no way to specify only the hostname or only the port, you have to specify both.
  • Not sure what I am missing but running yarn change gives me the following error so I couldn't update the changelog: Annotation 2020-06-23 192843
Microsoft Reviewers: Open in CodeFlow
+10 -1

1 comment

3 changed files

nasadigital

pr closed time in 17 days

issue closedmicrosoft/react-native-windows

Remote debugging Playground with web debugging doesn't work anymore

We added some support for remote debugging the Playground app, see: https://github.com/microsoft/react-native-windows/wiki/VS-Remote-Debugging

However this technique doesn't work anymore. I debugged this and found two issues:

  1. The privateNetworkClientServer capability isn't turned on in Package.appxmanifest
  2. The client code is failing to connect due to using localhost:8081. It looks like we're missing the plumbing code that was originally added to HostingPane, which is no longer being used in Playground.

We should find a way to re-enable this. We should also think about how to enable remote debugging for CLI apps when we fix this - ideally whatever we do would also work for template apps.

closed time in 17 days

kmelmon

pull request commentmicrosoft/react-native-windows

Fix remote debugging with web debugging in Playground.

Thank you for reviewing!

nasadigital

comment created time in 17 days

issue openedmicrosoft/react-native-windows

Rename DebugHost from ReactInstanceSettings to something more appropriate?

The DebugHost property is used to specify the bundler, which might not be clear from the name (particularly in remote debugging scenarios). To boot, the individual settings to set the hostname (SourceBundleHost) and port (SourceBundlePort) don't align with the naming scheme. After talking with @asklar the conclusion was that the name should better reflect this or that this could be better documented.

created time in 17 days

push eventnasadigital/react-native-windows

David Serafimov

commit sha 10f9ee2a4f754abd059404e0752dda950ea7461f

Align variable name with naming convention and remove unused variable.

view details

push time in 17 days

Pull request review commentmicrosoft/react-native-windows

Fix remote debugging with web debugging in Playground.

 struct MainPage : MainPageT<MainPage> {   Windows::Foundation::Collections::IVector<Microsoft::ReactNative::IReactPackageProvider> m_packageProviders;    bool m_useWebDebugger{false};+  winrt::hstring debugHost;

My bad, I also went ahead and removed the the other variable since it wasn't used.

nasadigital

comment created time in 17 days

push eventnasadigital/react-native-windows

David Serafimov

commit sha 823bbd6b9a2ad49aba0b985a4ce8c5b30e403908

Fix namespace issue and rename debugHost to something more appropriate.

view details

push time in 17 days

PR opened microsoft/react-native-windows

Fix remote debugging with web debugging in Playground.

Fixes #5112. To remote debug the Playground app follow the steps in the wiki: https://github.com/microsoft/react-native-windows/wiki/VS-Remote-Debugging Don't forget to open the port on the host machine. This implementation is based on #3535. Limitations:

  • There is no way to specify only the hostname or only the port, you have to specify both.
  • Not sure what I am missing but running yarn change gives me the following error so I couldn't update the changelog: Annotation 2020-06-23 192843
+10 -0

0 comment

3 changed files

pr created time in 17 days

push eventnasadigital/react-native-windows

David Serafimov

commit sha bf7d91d7a13e3a16f35c371ee6b1e6f272b4a191

Allow setting debug host as a command line argument in Playground.

view details

push time in 17 days

push eventnasadigital/react-native-windows

push time in 17 days

create barnchnasadigital/react-native-windows

branch : fixRemoteDebuggingPlayground

created branch time in 17 days

push eventnasadigital/react-native-windows

Igor Klemenski

commit sha 8fd8dcd3b4c6783ad176c620df57521c8131b894

Fix - onPress callback not working for nested <Text> elements (#5125) * Fix - onPress callback not working for nested <Text> elements * fix xaml namespaces; handle RTL * fix formatting * Change files Co-authored-by: Igor Klemenski <igklemen@microsoft.com>

view details

dependabot-preview[bot]

commit sha 86b9cd07dc6895c10378fa8e218015a7ace72085

Bump lerna from 3.22.0 to 3.22.1 (#5157)

view details

dependabot-preview[bot]

commit sha 19c35585d90df557ef6d4947daaee0a15cecc7be

Bump fp-ts from 2.6.3 to 2.6.4 (#5156)

view details

tkamireh

commit sha 93251e5714cfc7ac6211af4e809251d2d3ba7050

ViewWin32 Cursor Prop Type Expanded (#5154) * expand cursor prop + test comopnent * lingering api updates * Change files * remove props for params for test component'

view details

React-Native-Windows Bot

commit sha dd3622ac0f683d68d86f6c58f9f4270d24acb2a6

applying package updates ***NO_CI***

view details

Zihan Chen (MSFT)

commit sha 2f479757c611f1491ea4b47b74f8f76bbe03a39a

Call turbo module in IntegrationTests (#5162) * Call turbo module in IntegrationTests * Change files * ...

view details

Julio César Rocha

commit sha 246cea3abb852dabdcb96e40614e74e909af05d2

Manually set Lib and Include paths for Hermes (#5163) * Manually set Lib and Include paths for Hermes * Change files * Use PlatformTarget for Hermes path resolution * Parameterize path for JSI_Source * MUFA: Make USE_HERMES False Again! * Remove redundant FollyDir vars logging

view details

Andrew Coates

commit sha 72d108144cfddecff3c8e61bc41b13487917bb53

Add support for RedBox's on XamlIslands (#5159) * Add support for redbox's on xamlislands * Change files * Remove playground win32's redbox impl.

view details

dannyvv

commit sha 2a8b11778ed8c7a44d9a9dc0779c15b1fd87f50f

Add Documentation page for React Native Windows Init templating (#5142) * Add React Native Windows Init documentation for mustache templating * Update docs/react-native-windows-init.md Co-authored-by: Alexander Sklar <asklar@microsoft.com> * Update docs/react-native-windows-init.md Co-authored-by: Alexander Sklar <asklar@microsoft.com> * Update docs/react-native-windows-init.md Co-authored-by: Alexander Sklar <asklar@microsoft.com> * Update docs/react-native-windows-init.md Co-authored-by: Alexander Sklar <asklar@microsoft.com> * Update docs/react-native-windows-init.md Co-authored-by: Alexander Sklar <asklar@microsoft.com> * Update docs/react-native-windows-init.md Co-authored-by: Alexander Sklar <asklar@microsoft.com> * Update docs/react-native-windows-init.md Co-authored-by: Alexander Sklar <asklar@microsoft.com> * Update docs/react-native-windows-init.md Co-authored-by: Alexander Sklar <asklar@microsoft.com> * Update docs/react-native-windows-init.md Co-authored-by: Alexander Sklar <asklar@microsoft.com>

view details

dependabot-preview[bot]

commit sha 345d6c2eb9af6d3a5183b23b7402eba4b67e9a8d

Bump fp-ts from 2.6.4 to 2.6.5 (#5165)

view details

Alexander Sklar

commit sha 7062c6ea760096e6d989179098ee33622d1ee3ec

More rnw-dependencies improvements (#5169) * More rnw-dependencies improvements * Change files

view details

React-Native-Windows Bot

commit sha 41d8e7a09302832ea7d23e38811da110f6ada661

applying package updates ***NO_CI***

view details

Andrew Coates

commit sha 0708c894840a0ec51071a9b2b4a8189d3d59ff66

We shouldn't ever need to install RN globally (#5164)

view details

dannyvv

commit sha 7d7b6fb2b392acc7956e32398ac779e78ad0e4cf

Fix support for `--namespace` on react-native-windows init for cpp (#5145) * Fix support for `--namespace` on react-native-windows init for cpp * Change files

view details

React-Native-Windows Bot

commit sha 62a14769b6be82f84e1da2b3dc5813cf8d2aa5c6

applying package updates ***NO_CI***

view details

dannyvv

commit sha 36eaf59b161a8c2aa3dd66e1be338c00211b57f9

Add documentation page for Managed CodeGen for Native Modules (#5141) * Add documentation page for Managed CodeGen for Native Modules Co-authored-by: Alexander Sklar <asklar@microsoft.com>

view details

dannyvv

commit sha 394573753837320f51e9e3969e149961f3471480

Fix file lock issue with MSBuild's `/bl` flag and the metro bundler (#5186) * Fix file lock issue wiht msbuild /bl flag and the metro bundler * Change files

view details

tkamireh

commit sha 67a72aca889f27e2d7bc1e4596d92f36bf311a87

Add focusRef to TouchableWin32 (#5108) * Add focusRef prop to TouchableWin32 * Add example * polish example * API md generation * Change files * internal ref + indirection approach * api fixes * show an example of ref forwarding using a class component

view details

Andrew Coates

commit sha ef0fd96936b64d21345366bf49e96123bf60fa1c

Add Microsoft.ReactNative.Cxx to the nuget package (#5184) * Add Microsoft.ReactNative.Cxx to the nugets. * Change files * pack nuget from location that contains headers and build artifacts

view details

Zihan Chen (MSFT)

commit sha de852396cf3c6e5bb9c15da97a59b3e0256831e3

Implement SyncMethod and Constant for TurboModule (#5171) * Implement SyncMethod and Constant for TurboModule * Change files

view details

push time in 17 days

issue commentmicrosoft/react-native-windows

Remote debugging Playground with web debugging doesn't work anymore

I can pick this up. As @kmelmon mentioned if privateNetworkClientServer is enabled and I add an option to specify the hostname and/or port (similar to how it's done in #5062), remote debugging works for me similarly to how it's outlined in the wiki. This approach should work with template apps as well.

kmelmon

comment created time in a month

push eventnasadigital/react-native-windows

David Serafimov

commit sha 96f7e821bbdba952dff5261c26c0f965da20a567

Allow developers to independently set hostname and port. (#4979) * Add SourceBundleHost and SourceBundlePort settings. * Add yarn change updates. * Add missing files from running yarn build.

view details

Vladimir Morozov

commit sha 7236d61e5736083eec1992df73183c400c787306

Add UIDispatcher property to ReactInstanceSettings and IReactContext (#5007) * Add UIDispatcher property to ReactInstanceSettings and IReactContext * Change files * Fix ReactWindows-Desktop.sln compilation * Address PR feedback for the GetCurrentUIThreadQueue * Remove UIDispatcher setting from Playground project

view details

React-Native-Windows Bot

commit sha bc7c516fa8d5d8119db6e593cf359301f4c8a29e

applying package updates ***NO_CI***

view details

Vladimir Morozov

commit sha 9a4aa3c3f1a46470e11740abcbf06718099db571

Fix loading SampleAppCpp in VS 16.6.0 (#4982) * Fix loading SampleAppCpp in VS 16.6.0 * Add support for pre-16.6.0 VS versions

view details

Andreas Eulitz

commit sha c99549b8edacc750d6efa328ea978304daf615e1

Change ABITest project to GTest executable (#4997) * change ABITest project to GoogleTest executable * Change files * __cdecl main * address x86 build break * format code

view details

Alexander Sklar

commit sha a85f4c8938849faa1f28a561b93229148f43fba3

ReactApplication should not impose a ReactRootView (#4949) * set up react application to use an app's reactrootview * update templates to use ReactApplication / ReactRootView

view details

Zihan Chen (MSFT)

commit sha ed809a428f0bace2dc5bfbe9ce86ffe60af03660

Create JSI implementation for IJSValueReader and IJSValueWriter (#5009) * Create JSI implementation for IJSValueReader and IJSValueWriter * Change files * Fix code review comments

view details

Andreas Eulitz

commit sha f2df8edb4cdfadead41bfcb5d793ba6e1435b11b

Use reg-free WinRT in Desktop.ABITests project (#5013)

view details

React-Native-Windows Bot

commit sha 67df4c32ce6df037ed8fe3662395316b108a95d5

applying package updates ***NO_CI***

view details

Julio César Rocha

commit sha ce5b8b4e6417a67c45908a4f943d416b1b2ff225

Obtain Google Test Adapter path dynamically (#5027) * Find Google Test Adapter path

view details

Vladimir Morozov

commit sha 7a7488d3018c0c502ab716967bae1d91ef994109

Remove unused ABI definitions (#5030) * Remove unused ABI definitions * Change files * Remove LifecycleState

view details

Andrew Coates

commit sha d0c938fe25ed927670ca9543b90fee4c6cff5b37

Attempt to fix intermittent failures in E2E tests (#5040) * Attempt to fix itermittent failures in E2E tests * Add some retry logic on yarn install to reduce itermittent failures on yarn install

view details

dependabot-preview[bot]

commit sha 6eff7342065bd8981f3a490ed18c21e7eb6ff846

Bump @microsoft/api-documenter from 7.8.5 to 7.8.8 (#5035) Bumps [@microsoft/api-documenter](https://github.com/microsoft/rushstack) from 7.8.5 to 7.8.8. - [Release notes](https://github.com/microsoft/rushstack/releases) - [Commits](https://github.com/microsoft/rushstack/compare/@microsoft/api-documenter_v7.8.5...@microsoft/api-documenter_v7.8.8) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Zihan Chen (MSFT)

commit sha 77bbf454e4546ec63e6b698846a1da26ca0fd352

Build ChakraRuntime in ComponentTests with one test case (#5032) * Build ChakraRuntime in ComponentTests with one test case * Change files * Fix clang formatter error Co-authored-by: Vladimir Morozov <vmoroz@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 9001168fded441ca924d0ca9fa8768746078685b

Bump @babel/preset-env from 7.9.6 to 7.10.1 (#5039) Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.9.6 to 7.10.1. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.10.1/packages/babel-preset-env) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 5a01200586195e2a07f40c11a24f45f968f50916

Bump fp-ts from 2.6.1 to 2.6.2 (#5019) Bumps [fp-ts](https://github.com/gcanti/fp-ts) from 2.6.1 to 2.6.2. - [Release notes](https://github.com/gcanti/fp-ts/releases) - [Changelog](https://github.com/gcanti/fp-ts/blob/master/CHANGELOG.md) - [Commits](https://github.com/gcanti/fp-ts/compare/2.6.1...2.6.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dannyvv

commit sha 74da80803b5229d4456b02ac9ca922b6e69dc9b4

Update shared props to have csc emit absolute paths on errors and warnings (#5037) * Update shared props to have csc emit absolute paths on errors and warnings * Change files

view details

Alexander Sklar

commit sha 77dea410d745029e451cc5fc087238bdaee549e4

Add support for long paths to rnw-dependencies.ps1 (#5045) * add support for long paths to rnw-dependencies.ps1 * Change files

view details

React-Native-Windows Bot

commit sha db418d926daeb573ee7459b48406e7551073f3f3

applying package updates ***NO_CI***

view details

Andrew Coates

commit sha 2809c9a14a68cdbaa4b735b189197b5692af0d53

Adds a XamlUIService property to IReactContext, which exposes ElementFromTag (#5034) * Add XamlUIService with ElementFromReactTag * formatting * Change files * XamlUIService shouldn't be part of desktop dll

view details

push time in a month

Pull request review commentmicrosoft/react-native-windows

Implement --proxy flag in CLI

 async function deployToDesktop(options, verbose, slnFile) {     );   } -  let args = ['--remote-debugging', options.proxy ? 'true' : 'false'];+  let args = [];

@rectified95 I know it's outside of the scope of this PR, but could you make the --direct-debugging flag debug only as well (since it provides similar functionality)?

rectified95

comment created time in a month

Pull request review commentmicrosoft/react-native-windows

Implement --proxy flag in CLI

 void ApplyArguments(ReactNative::ReactNativeHost const &host, std::wstring const           hostImpl->InstanceSettings().DebuggerBreakOnNextLine(true);           hostImpl->InstanceSettings().DebuggerPort(port);         }+      } else if (token == L"--proxy") {+        hostImpl->InstanceSettings().UseWebDebugger(true);+        hostImpl->InstanceSettings().UseDirectDebugger(false);+        hostImpl->InstanceSettings().DebuggerBreakOnNextLine(true);

My understanding is that break on next line works only if direct debugging is enabled, so this line could probably be omitted.

rectified95

comment created time in a month

startedmfornet/acmx

started time in a month

push eventnasadigital/react-native-windows

David Serafimov

commit sha fd64d65fbdb2eacf3e807c6e8fde012967f8f72b

Add missing files from running yarn build.

view details

push time in a month

push eventnasadigital/react-native-windows

dependabot-preview[bot]

commit sha a55f0a5439fea4c20e72444e9b6a85ac27b010a6

Bump diff-match-patch from 1.0.4 to 1.0.5 (#4967) Bumps [diff-match-patch](https://github.com/JackuB/diff-match-patch) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/JackuB/diff-match-patch/releases) - [Commits](https://github.com/JackuB/diff-match-patch/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dannyvv

commit sha 23cb6da9a069b57de072073f1f05c92378663393

Update CI pipeline to upload build logs (#4971)

view details

Alexander Sklar

commit sha 7df439c40edf1bcf81a3a1246cd6afbf027f12d9

Add preprocess target to M.RN and missing deploy target in playground, don't overwrite msbuild.binlog on deploy (#4965) * add preprocess target to M.RN and missing deploy target in playground * dont overwrite msbuild log when deploying * Change files * add *.pp to gitignore

view details

dannyvv

commit sha 1ffc221165ebdf97b17ad9244c1f82488fbd385e

Fix spacing and extra dot in copyright of the property sheets (#4970) * Fix spacing and extra dot in copyright of the property sheets * Change files

view details

dannyvv

commit sha 7da2d4e4d29a1475a8912565b9746114e85555ae

Standardize version of Microsoft.NETCore.UniversalWindowsPlatform to 6.2.9 (#4975) * Standardize version of Microsoft.NETCore.UniversalWindowsPlatform to 6.2.9 * Change files

view details

dannyvv

commit sha 68b39682fd0d636ee8a1be676e9541173ce633ee

Remove unneeded reference form Microsoft.ReactNative.Managed (#4977) * Remove unneeded reference form Microsoft.ReactNative.Managed * Change files

view details

Igor Klemenski

commit sha b2241a6a452e3068eb8dccb51f3f3ca1dcb268cc

Add info about yarn format to contribution docs. (#4981) Co-authored-by: Igor Klemenski <igklemen@microsoft.com>

view details

Igor Klemenski

commit sha 2ce41cfb5ac8c3c0e5f283b5df5a31524440d840

Only emit click events for left mouse button (#4878) * Do not emit click events for buttons other than left. Co-authored-by: Igor Klemenski <igklemen@microsoft.com>

view details

React-Native-Windows Bot

commit sha 225df523288d1931899b645f9517476a445792fa

applying package updates ***NO_CI***

view details

Julio César Rocha

commit sha ed7ee2de98d64c1002c8bafa7eacd1e4d8317fb2

Drop LazyDevSupportManager (#4984) * Drop LazySupportManager * Change files * Remove obsolete comment * Remove obsolete comment * Rename buffer0 to buffer * yarn format * Remove unneeded string allocations * Update DevSupportManager.cpp

view details

Alexander Sklar

commit sha cd9206e1a5f8912e1c9a78f1594178c2fe66cf9f

App projects only builds from clean (i.e. the first time only) (#4983) * Fix deploy issue causing 2nd+ builds to break due to bug in appxrecipe which gets imported * Change files

view details

Andrew Coates

commit sha 0e0dba50cc377172a19df4cd97c3babef7da0c8c

Move several stubs from TS to flow (#4976) * Move several stubs from TS to flow * Change files * Fix flow * Move some more stubs to the same as facebook's stubs * fix overrides.json

view details

Vladimir Morozov

commit sha c23d3de53f16d39df07f2b19591cacc5336e6ac4

Implemented support for native module std::weak_ptr (#4980)

view details

dependabot-preview[bot]

commit sha 981e3b58f040e95c631586928a408f58887dd624

Bump @microsoft/api-documenter from 7.8.3 to 7.8.5 (#4989)

view details

dependabot-preview[bot]

commit sha f31136eb65b7ce5bbced48625cfc91c06dd9ab15

Bump beachball from 1.31.0 to 1.31.1 (#4988)

view details

Vladimir Morozov

commit sha 05779f28e8f734bd1aa7e1814d888be4eb179366

Fix ReactInstance error state to avoid crashes (#4986) * Fix ReactInstance error state to avoid crashes * Change files * Clean m_redboxContent after RedBox closing

view details

dependabot-preview[bot]

commit sha 198ce2e3754fdf4063806cd5985c2c9317819ee6

Bump @microsoft/api-extractor from 7.8.3 to 7.8.5 (#4990) Bumps [@microsoft/api-extractor](https://github.com/microsoft/rushstack) from 7.8.3 to 7.8.5. - [Release notes](https://github.com/microsoft/rushstack/releases) - [Commits](https://github.com/microsoft/rushstack/compare/@microsoft/api-extractor_v7.8.3...@microsoft/api-extractor_v7.8.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Andrew Coates

commit sha 8dcf516f91d33a1a54818363f84e91b1b0da5e9b

Move AppState and DeviceInfo to use module spec files (#4991) * Move more native modules to Spec files * Move device info init to object created on UI thread. * feedback * format * Change files * Add missing method on TestAppStateModule

view details

React-Native-Windows Bot

commit sha b814ee38d78c3964fe4b226ddccc9df38e9cf322

applying package updates ***NO_CI***

view details

Nick Gerleman

commit sha 1a96ee7705113b6324ddf9b820a351e056c53405

Remove unneeded or undesirable eslint suppressions (#4994) Fixes #4935 eslint will be default ignore node_modules. Custom ignore files adding node_modules is uneeded, but in E2ETest the file seemingly by design disables linting. We see some linting errors as well that nedeed fixing beyond formatting. Fix that and get things formatted correctly. // eslint-disable-next-line no-undef added for a couple of globals

view details

push time in a month

push eventnasadigital/react-native-windows

dependabot-preview[bot]

commit sha 7970fd915981ed4f597e6333ebfbc189aa164ada

Bump diff-match-patch from 1.0.4 to 1.0.5 (#4967) Bumps [diff-match-patch](https://github.com/JackuB/diff-match-patch) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/JackuB/diff-match-patch/releases) - [Commits](https://github.com/JackuB/diff-match-patch/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dannyvv

commit sha 30be95a655bb863da5372644f3f3472caa6ef325

Update CI pipeline to upload build logs (#4971)

view details

Alexander Sklar

commit sha ad08e7c8ab68d17282a5090cc9ff53d63e1af334

Add preprocess target to M.RN and missing deploy target in playground, don't overwrite msbuild.binlog on deploy (#4965) * add preprocess target to M.RN and missing deploy target in playground * dont overwrite msbuild log when deploying * Change files * add *.pp to gitignore

view details

dannyvv

commit sha d5addff277abc06cb2202bd7aa5e3b192e4248f1

Fix spacing and extra dot in copyright of the property sheets (#4970) * Fix spacing and extra dot in copyright of the property sheets * Change files

view details

dannyvv

commit sha a9225af5ec9ff41b970f0f6ad93ff715c6d26b97

Standardize version of Microsoft.NETCore.UniversalWindowsPlatform to 6.2.9 (#4975) * Standardize version of Microsoft.NETCore.UniversalWindowsPlatform to 6.2.9 * Change files

view details

dannyvv

commit sha e76084259d26d662771e8b51f333e5a6b62b8f1b

Remove unneeded reference form Microsoft.ReactNative.Managed (#4977) * Remove unneeded reference form Microsoft.ReactNative.Managed * Change files

view details

Igor Klemenski

commit sha 70f593daba1948c8718c87afa8f211cb299e827d

Add info about yarn format to contribution docs. (#4981) Co-authored-by: Igor Klemenski <igklemen@microsoft.com>

view details

Igor Klemenski

commit sha b2a2c9f35be86d6815833843e1632a3d2cd5f13f

Only emit click events for left mouse button (#4878) * Do not emit click events for buttons other than left. Co-authored-by: Igor Klemenski <igklemen@microsoft.com>

view details

React-Native-Windows Bot

commit sha 4e0b0da7fe92a5b0b6355f88f7aacb16d88d165c

applying package updates ***NO_CI***

view details

Julio César Rocha

commit sha afa980814ca637481b0cf142812c54766c057864

Drop LazyDevSupportManager (#4984) * Drop LazySupportManager * Change files * Remove obsolete comment * Remove obsolete comment * Rename buffer0 to buffer * yarn format * Remove unneeded string allocations * Update DevSupportManager.cpp

view details

Alexander Sklar

commit sha 76dc9b08cb7bb92486b56a30c82383346e7be2fd

App projects only builds from clean (i.e. the first time only) (#4983) * Fix deploy issue causing 2nd+ builds to break due to bug in appxrecipe which gets imported * Change files

view details

Andrew Coates

commit sha 3550cf48baf5732e8cca20d332f8a7f71a7d00df

Move several stubs from TS to flow (#4976) * Move several stubs from TS to flow * Change files * Fix flow * Move some more stubs to the same as facebook's stubs * fix overrides.json

view details

Vladimir Morozov

commit sha e7d357048d85ca824d36945a419d4bdc86fb2e1a

Implemented support for native module std::weak_ptr (#4980)

view details

dependabot-preview[bot]

commit sha 3cfadd892fa653087797df2bf7b5130471af8467

Bump @microsoft/api-documenter from 7.8.3 to 7.8.5 (#4989)

view details

dependabot-preview[bot]

commit sha 0e58f3eb63c8ca1c9efe6ece145a66029cd68373

Bump beachball from 1.31.0 to 1.31.1 (#4988)

view details

Vladimir Morozov

commit sha b5180886cdafd197701e91626334e9167b4d8b5f

Fix ReactInstance error state to avoid crashes (#4986) * Fix ReactInstance error state to avoid crashes * Change files * Clean m_redboxContent after RedBox closing

view details

dependabot-preview[bot]

commit sha be629d4791d3643a8af67138b35156e0831bfb48

Bump @microsoft/api-extractor from 7.8.3 to 7.8.5 (#4990) Bumps [@microsoft/api-extractor](https://github.com/microsoft/rushstack) from 7.8.3 to 7.8.5. - [Release notes](https://github.com/microsoft/rushstack/releases) - [Commits](https://github.com/microsoft/rushstack/compare/@microsoft/api-extractor_v7.8.3...@microsoft/api-extractor_v7.8.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Andrew Coates

commit sha 2ce09c6c7c71cf985a7f3b4257fa5f0ab2c383da

Move AppState and DeviceInfo to use module spec files (#4991) * Move more native modules to Spec files * Move device info init to object created on UI thread. * feedback * format * Change files * Add missing method on TestAppStateModule

view details

React-Native-Windows Bot

commit sha 23a812a486f6940c619d76850e25109bce591cff

applying package updates ***NO_CI***

view details

Nick Gerleman

commit sha 269ae0a0fe957b385af0c876cfab4f76f3bb2a63

Remove unneeded or undesirable eslint suppressions (#4994) Fixes #4935 eslint will be default ignore node_modules. Custom ignore files adding node_modules is uneeded, but in E2ETest the file seemingly by design disables linting. We see some linting errors as well that nedeed fixing beyond formatting. Fix that and get things formatted correctly. // eslint-disable-next-line no-undef added for a couple of globals

view details

push time in a month

push eventnasadigital/react-native-windows

Nick Gerleman

commit sha 85b01cb32e4b6c46aebb38bdcc5f612a616c856a

Rename override-tools to react-native-platform-override (#4993) * Rename override-tools to react-native-windows-override Fixes #4859 This chnage: 1. Matches better with other packages 2. Allows unambiguously mapping bin name to package name, allowing us to reccomend npx usage instead of Yarn, which has odd cwd behavior. We also need to update out gitignore file which no longer was allowing checking in VS Code project settings. * Use public react-native-platform-override instead of react-native-windows-override * Update descriptions, reduce some hardcoding * Remove some more duplication * Missing file * Remove require-time dependency to be called from the package bin. I.e. allow scripts to still work * More path hardening * Simplify logic a bit more * Fic string

view details

React-Native-Windows Bot

commit sha 310527a94383db0b0917f76f7d409ec39c296a0a

applying package updates ***NO_CI***

view details

Zihan Chen (MSFT)

commit sha 35137fbbbfebf1ebba557cd7a8bdde909627ce3c

Create Microsoft.ReactNative.ComponentTests.vcxproj (#5006) * Create Microsoft.ReactNative.ComponentTests.vcxproj * Change files

view details

dependabot-preview[bot]

commit sha fc6b19538e979a8e5d758c9288c498f973928294

Bump @types/react-native from 0.62.10 to 0.62.11 (#5004)

view details

dependabot-preview[bot]

commit sha bca7a98048a4c32d291c6f2709e1f864eb3b7c60

Bump lerna from 3.21.0 to 3.22.0 (#5005)

view details

Andrew Coates

commit sha f2fffbd85bd62c1fab24982d7394343dc41932ff

Move I18nManager to spec based native module (#4999) * Move I18nManager to spec based native module * Change files * formatting * minor fix

view details

push time in a month

push eventnasadigital/react-native-windows

dependabot-preview[bot]

commit sha a55f0a5439fea4c20e72444e9b6a85ac27b010a6

Bump diff-match-patch from 1.0.4 to 1.0.5 (#4967) Bumps [diff-match-patch](https://github.com/JackuB/diff-match-patch) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/JackuB/diff-match-patch/releases) - [Commits](https://github.com/JackuB/diff-match-patch/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dannyvv

commit sha 23cb6da9a069b57de072073f1f05c92378663393

Update CI pipeline to upload build logs (#4971)

view details

Alexander Sklar

commit sha 7df439c40edf1bcf81a3a1246cd6afbf027f12d9

Add preprocess target to M.RN and missing deploy target in playground, don't overwrite msbuild.binlog on deploy (#4965) * add preprocess target to M.RN and missing deploy target in playground * dont overwrite msbuild log when deploying * Change files * add *.pp to gitignore

view details

dannyvv

commit sha 1ffc221165ebdf97b17ad9244c1f82488fbd385e

Fix spacing and extra dot in copyright of the property sheets (#4970) * Fix spacing and extra dot in copyright of the property sheets * Change files

view details

dannyvv

commit sha 7da2d4e4d29a1475a8912565b9746114e85555ae

Standardize version of Microsoft.NETCore.UniversalWindowsPlatform to 6.2.9 (#4975) * Standardize version of Microsoft.NETCore.UniversalWindowsPlatform to 6.2.9 * Change files

view details

dannyvv

commit sha 68b39682fd0d636ee8a1be676e9541173ce633ee

Remove unneeded reference form Microsoft.ReactNative.Managed (#4977) * Remove unneeded reference form Microsoft.ReactNative.Managed * Change files

view details

Igor Klemenski

commit sha b2241a6a452e3068eb8dccb51f3f3ca1dcb268cc

Add info about yarn format to contribution docs. (#4981) Co-authored-by: Igor Klemenski <igklemen@microsoft.com>

view details

Igor Klemenski

commit sha 2ce41cfb5ac8c3c0e5f283b5df5a31524440d840

Only emit click events for left mouse button (#4878) * Do not emit click events for buttons other than left. Co-authored-by: Igor Klemenski <igklemen@microsoft.com>

view details

React-Native-Windows Bot

commit sha 225df523288d1931899b645f9517476a445792fa

applying package updates ***NO_CI***

view details

Julio César Rocha

commit sha ed7ee2de98d64c1002c8bafa7eacd1e4d8317fb2

Drop LazyDevSupportManager (#4984) * Drop LazySupportManager * Change files * Remove obsolete comment * Remove obsolete comment * Rename buffer0 to buffer * yarn format * Remove unneeded string allocations * Update DevSupportManager.cpp

view details

Alexander Sklar

commit sha cd9206e1a5f8912e1c9a78f1594178c2fe66cf9f

App projects only builds from clean (i.e. the first time only) (#4983) * Fix deploy issue causing 2nd+ builds to break due to bug in appxrecipe which gets imported * Change files

view details

Andrew Coates

commit sha 0e0dba50cc377172a19df4cd97c3babef7da0c8c

Move several stubs from TS to flow (#4976) * Move several stubs from TS to flow * Change files * Fix flow * Move some more stubs to the same as facebook's stubs * fix overrides.json

view details

Vladimir Morozov

commit sha c23d3de53f16d39df07f2b19591cacc5336e6ac4

Implemented support for native module std::weak_ptr (#4980)

view details

dependabot-preview[bot]

commit sha 981e3b58f040e95c631586928a408f58887dd624

Bump @microsoft/api-documenter from 7.8.3 to 7.8.5 (#4989)

view details

dependabot-preview[bot]

commit sha f31136eb65b7ce5bbced48625cfc91c06dd9ab15

Bump beachball from 1.31.0 to 1.31.1 (#4988)

view details

Vladimir Morozov

commit sha 05779f28e8f734bd1aa7e1814d888be4eb179366

Fix ReactInstance error state to avoid crashes (#4986) * Fix ReactInstance error state to avoid crashes * Change files * Clean m_redboxContent after RedBox closing

view details

dependabot-preview[bot]

commit sha 198ce2e3754fdf4063806cd5985c2c9317819ee6

Bump @microsoft/api-extractor from 7.8.3 to 7.8.5 (#4990) Bumps [@microsoft/api-extractor](https://github.com/microsoft/rushstack) from 7.8.3 to 7.8.5. - [Release notes](https://github.com/microsoft/rushstack/releases) - [Commits](https://github.com/microsoft/rushstack/compare/@microsoft/api-extractor_v7.8.3...@microsoft/api-extractor_v7.8.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Andrew Coates

commit sha 8dcf516f91d33a1a54818363f84e91b1b0da5e9b

Move AppState and DeviceInfo to use module spec files (#4991) * Move more native modules to Spec files * Move device info init to object created on UI thread. * feedback * format * Change files * Add missing method on TestAppStateModule

view details

React-Native-Windows Bot

commit sha b814ee38d78c3964fe4b226ddccc9df38e9cf322

applying package updates ***NO_CI***

view details

Nick Gerleman

commit sha 1a96ee7705113b6324ddf9b820a351e056c53405

Remove unneeded or undesirable eslint suppressions (#4994) Fixes #4935 eslint will be default ignore node_modules. Custom ignore files adding node_modules is uneeded, but in E2ETest the file seemingly by design disables linting. We see some linting errors as well that nedeed fixing beyond formatting. Fix that and get things formatted correctly. // eslint-disable-next-line no-undef added for a couple of globals

view details

push time in 2 months

push eventnasadigital/react-native-windows

David Serafimov

commit sha b6c2dc540f26c8e7f1619d8be88cbc17d0924e4a

Adress PR feedback.

view details

push time in 2 months

Pull request review commentmicrosoft/react-native-windows

Allow developers to independently set hostname and port.

 void UwpReactInstance::Start(const std::shared_ptr<IReactInstance> &spThis, cons     devSettings->useJITCompilation = settings.EnableJITCompilation;     devSettings->debugHost = settings.DebugHost;     devSettings->debuggerPort = settings.DebuggerPort;+    devSettings->sourceBundleHost = settings.SourceBundleHost;

My bad, thanks for catching this! Noob question, how can I test an app with ReactInstanceWin? I tried using packages/microsoft-reactnative-sampleapps, but that app allowed me to edit hostname/port without this change.

nasadigital

comment created time in 2 months

push eventnasadigital/react-native-windows

David Serafimov

commit sha 13c589a071136c0576f8b3b01fc9a120d9aa69b8

Add yarn change updates.

view details

push time in 2 months

PR opened microsoft/react-native-windows

Allow developers to independently set hostname and port.

Addresses #2586. Adds new settings SourceBundleHost (defaults to localhost) and SourceBundlePort (defaults to 8081) to specify hostname and port. If DebugHost is set, these settings are ignored.

+35 -0

0 comment

5 changed files

pr created time in 2 months

create barnchnasadigital/react-native-windows

branch : independent_hostname_and_port

created branch time in 2 months

push eventnasadigital/react-native-windows

Alexander Sklar

commit sha b3fc68fd8ea6f85dbc3bfdc92dc8063dc9edbc17

Deploy from layout (#4945) * deploy from layout

view details

dependabot-preview[bot]

commit sha 282ee22b9dff42ff24d5d0b12236bfa72d729b2a

Bump typescript from 3.9.2 to 3.9.3 (#4956)

view details

React-Native-Windows Bot

commit sha 95f55d3d3ea0aa57189cabca1735357e94df1c07

applying package updates ***NO_CI***

view details

Alexander Sklar

commit sha 8253a685dec0915fd60f169975be45891df00660

Work around regression in UWP app packaging in VS 16.5-16.6 (#4958) * Work around regression in UWP app packaging in VS 16.5-16.6

view details

dependabot-preview[bot]

commit sha bea629d304e5f0a98f6d818151d204d97d5dd83f

Bump @types/lodash from 4.14.151 to 4.14.152 (#4955)

view details

Vladimir Morozov

commit sha 70baa5fd803a08c6fb2b673d78f18cecf953f146

Fixed Microsoft.ReactNative build in VS 16.6.0 (#4962) * Fixed Microsoft.ReactNative build in VS 16.6.0 * Change files

view details

kmelmon

commit sha 1fe030aa07bb6c7eb901b345358c5f1666b9eddf

Fix animation bug (#4964) * Change files * comment

view details

dependabot-preview[bot]

commit sha b4b50e93211fbebf9a61ef6ccd4f1bda3ceb2fba

Bump @microsoft/api-extractor from 7.8.2 to 7.8.3 (#4969)

view details

dependabot-preview[bot]

commit sha 9ba3b78f3e8c781c9b3e58a7a8998857e15b80af

Bump @microsoft/api-documenter from 7.8.2 to 7.8.3 (#4968)

view details

dependabot-preview[bot]

commit sha 17624a751b1a8f81ca54880d15234ff620c8f973

Bump io-ts from 2.2.2 to 2.2.3 (#4966)

view details

push time in 2 months

push eventnasadigital/react-native-windows

dannyvv

commit sha 64144a989231a5573b665ac189ac015c6f007dfc

Exclude test projects and proposals from being published in the npm package (#4737) * Exclude test projects and proposals from being published in the npm package * Change files

view details

dannyvv

commit sha f7be64d8089b847108d4722b219e321aa19a0d25

Update version number of the Azure DevOps PR validation step (#4738)

view details

React-Native-Windows Bot

commit sha 808ca324a028a4a283848173954c98cf1418e2b6

applying package updates ***NO_CI***

view details

kmelmon

commit sha ee00cce8da0f3fdc5a3ddb7ac7ced3e2dc01c2d5

Auto-detect RTL locale and apply to root view (#4732) * implement allowRTL, forceRTL, and use RTLness on root * namespace rename * cleanup

view details

Alexander Sklar

commit sha 5edb66b341b6c36e85702eb2a7ea8953495affc9

Expose Debug macro for hresult_error. Start catching these... (#4742) * Expose Debug macro for hresult_error. Start catching these... * Change files

view details

Andrew Coates

commit sha 36ca14d11d0ff8029664d5e77f6b434111c9a6db

Update tscodegen to version based on 0.62 (#4747) * Update tscodegen to version based on 0.62 * Change files

view details

dependabot-preview[bot]

commit sha d33450d9b0b88411616bf31c7aeb3f6e526405d6

Bump @types/react-native from 0.62.4 to 0.62.5 (#4748) Bumps [@types/react-native](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-native) from 0.62.4 to 0.62.5. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-native) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Alexander Sklar

commit sha 297e217a48d2795b75f88a986ab5d344a384aa42

Remove unnecessary CLI elevation (#4745) * Try uninstalling without elevation in case since it is not needed for layout installs (debug) * Change files

view details

Alexander Sklar

commit sha f923f9890441ad5aa6340c95bf412441165c3fcc

Refactor TestHook out of ViewManagerBase and special case layout properties (#4741) * Refactor TestHook out of ViewManagerBase and special case layout properties * Change files * PR and get playground win32 building * format and remove debug in the header

view details

React-Native-Windows Bot

commit sha 800850c8e945aee6620f3aede38bdb323e2a0116

applying package updates ***NO_CI***

view details

Alexander Sklar

commit sha 1ec1663d3790ce33fb62db297d324c097d7f163b

.net projects need more work to build a package layout (#4751) * .net projects need more work to build a package layout * Change files * make async

view details

Alexander Sklar

commit sha 15ad43e230f3523beb3efead10d642e1eaab2b13

Expose YellowBox functionality to native code (#4740) * Change files * don't need sstream yet * const noexcept

view details

Nick Gerleman

commit sha 1ca0c2916ac29d3646a35d0e90c8bee8c6cda8d2

Package Version Fixes (#4752) * Package Fixes 1. Use looser peer dependencies on React Native. 0.61 specified 0.61.5 explicitly, but based on recent discussion we want to allow patch releases of RN to work on any RNW version. Allow prerelease versions as well for any special forks, etc. 2. Fixup React Version everywhere. I missed upgraded React dependencies during the 0.62 upgrade. This was fixed in vnext and e2etest with #4734 but other packages were not updated. Update everything here. * Change files

view details

Nick Gerleman

commit sha 0f2fca4c1a49288840fb640a530d0503e9c36ea3

Stop publishing ReactUwp NuGet Package (#4753) * Stop publishing ReactHwp NuGet Package We no longer support ReactUwp in 0.62. Stop publishing a NuGet package with it. * Change files * Remove stale variable * Remove another stale var

view details

React-Native-Windows Bot

commit sha 3e1e61d677b0688aaa664203034ea037ca43aac5

applying package updates ***NO_CI***

view details

dependabot-preview[bot]

commit sha 2a86937f668952eecb9a3e661da8887ec5c8ce6e

Bump @babel/runtime from 7.9.2 to 7.9.6 (#4758)

view details

dependabot-preview[bot]

commit sha 95a1987c7448efbe271e5dd0b3e9d8cb5251c529

Bump @babel/preset-env from 7.9.5 to 7.9.6 (#4756)

view details

Vladimir Morozov

commit sha 9d9a541aa40c4af2950cf784b5ba0ada935686c4

Removed the ref count work around from classes derived from ReactApplication (#4755) * Removed the ref count work around from classes derived from ReactApplications * Change files

view details

dependabot-preview[bot]

commit sha fb48078eefa5948e49d71e77c1010d115eda316f

Bump @babel/core from 7.9.0 to 7.9.6 (#4757) Bumps [@babel/core](https://github.com/babel/babel) from 7.9.0 to 7.9.6. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](https://github.com/babel/babel/compare/v7.9.0...v7.9.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dannyvv

commit sha d2583c94eda49aa95704a917d94d6f8333a88d89

Add a step in CI to upload verdaccio logs to diagnose package restore failures (#4761)

view details

push time in 2 months

Pull request review commentmicrosoft/PowerToys

welcome window documentation

+# PowerToys Out Of Box Experience Proposal and Code++##### Developers: [Furaha Dami�n](https://github.com/furahadamien), [Letitia Kwan](https://github.com/letitiakwan), [Jessica Lim](https://github.com/JessicaLim8)+##### Program Manager : [Eunice Choi](https://github.com/eunicechoi98)+##### Designer : Rafael Flora++## Overview+A team of Microsoft Garage interns have created a proposal for the out-of-box experience after the first time install of the PowerToys app, and a proposal for the UI experience of updates.++## 1. Welcome Screen++#### Rationale:+PowerToys v17 has a silent launch after first time installation and update. As evidenced in issue #1285, users are left wondering if anything happened at all. The aim of this new feature is to allow users a chance to appreate the install/update of PowerToys while at the same time giving them a chance to explore what PowerToys has to offer if they so wish to. ++#### Design:+<img align="left" src="./images/welcomeWindow.png" /> Welcome window

Just FYI, this picture should show up once you merge if you were wondering.

furahadamien

comment created time in 2 months

Pull request review commentmicrosoft/PowerToys

welcome window documentation

+# PowerToys Out Of Box Experience Proposal and Code++##### Developers: [Furaha Dami�n](https://github.com/furahadamien), [Letitia Kwan](https://github.com/letitiakwan), [Jessica Lim](https://github.com/JessicaLim8)+##### Program Manager : [Eunice Choi](https://github.com/eunicechoi98)+##### Designer : Rafael Flora++## Overview+A team of Microsoft Garage interns have created a proposal for the out-of-box experience after the first time install of the PowerToys app, and a proposal for the UI experience of updates.++## 1. Welcome Screen++#### Rationale:+PowerToys v17 has a silent launch after first time installation and update. As evidenced in issue #1285, users are left wondering if anything happened at all. The aim of this new feature is to allow users a chance to appreate the install/update of PowerToys while at the same time giving them a chance to explore what PowerToys has to offer if they so wish to. ++#### Design:+<img align="left" src="./images/welcomeWindow.png" /> Welcome window+++#### Code:+The frontend and the backend for this window are in [onLaunchContentDialog.xaml](https://github.com/microsoft/PowerToys/blob/interns/users/t-fudami/documentation/POC-OOBE/OOBE-Sandbox/PowerToys%20Settings%20Sandbox/Views/onLaunchContentDialog.xaml) and [onLaunchContentDialog.xaml.cs](https://github.com/microsoft/PowerToys/blob/interns/users/t-fudami/documentation/POC-OOBE/OOBE-Sandbox/PowerToys%20Settings%20Sandbox/Views/onLaunchContentDialog.xaml.cs) respectively. It is later called in the MainPage as below:++```+ private async void powerOnLaunchDialog()+        {+            onLaunchContentDialog dialog = new onLaunchContentDialog();+            dialog.PrimaryButtonClick += Dialog_PrimaryButtonClick;+            await dialog.ShowAsync();+        }++        private void Dialog_PrimaryButtonClick(ContentDialog sender, ContentDialogButtonClickEventArgs args)+        {+            OpenFirstGeneralSettingsTip();+        }+```++#### Considerations: +The aim of the feature is to introduce PowerToys to the user while at the same time not getting in their way. To achieve this we decided to use a [contentDialog](https://docs.microsoft.com/en-us/uwp/api/Windows.UI.Xaml.Controls.ContentDialog?view=winrt-19041). This allows the user to either explore PowerToys features as soon as they install/update the application or do the exploration at a later time. For users who chose the later, The window privides animated gifs that give a glimpse of what PowerToys has to offer. Using a contentDialog also allows us to fire a toast notifcation at a later time.

I am not a native speaker, but what do you think about using latter instead of later here: For users who chose the LATER, The window privides animated gifs that give a glimpse of what PowerToys has to offer.

furahadamien

comment created time in 2 months

Pull request review commentmicrosoft/PowerToys

welcome window documentation

+# PowerToys Out Of Box Experience Proposal and Code++##### Developers: [Furaha Dami�n](https://github.com/furahadamien), [Letitia Kwan](https://github.com/letitiakwan), [Jessica Lim](https://github.com/JessicaLim8)+##### Program Manager : [Eunice Choi](https://github.com/eunicechoi98)+##### Designer : Rafael Flora++## Overview+A team of Microsoft Garage interns have created a proposal for the out-of-box experience after the first time install of the PowerToys app, and a proposal for the UI experience of updates.++## 1. Welcome Screen++#### Rationale:+PowerToys v17 has a silent launch after first time installation and update. As evidenced in issue #1285, users are left wondering if anything happened at all. The aim of this new feature is to allow users a chance to appreate the install/update of PowerToys while at the same time giving them a chance to explore what PowerToys has to offer if they so wish to. 

You might consider linking to the issue #1285, so it's easier for the reader of the doc to look it up. Up to you!

furahadamien

comment created time in 2 months

Pull request review commentmicrosoft/PowerToys

welcome window documentation

+# PowerToys Out Of Box Experience Proposal and Code++##### Developers: [Furaha Dami�n](https://github.com/furahadamien), [Letitia Kwan](https://github.com/letitiakwan), [Jessica Lim](https://github.com/JessicaLim8)+##### Program Manager : [Eunice Choi](https://github.com/eunicechoi98)+##### Designer : Rafael Flora++## Overview+A team of Microsoft Garage interns have created a proposal for the out-of-box experience after the first time install of the PowerToys app, and a proposal for the UI experience of updates.++## 1. Welcome Screen++#### Rationale:+PowerToys v17 has a silent launch after first time installation and update. As evidenced in issue #1285, users are left wondering if anything happened at all. The aim of this new feature is to allow users a chance to appreate the install/update of PowerToys while at the same time giving them a chance to explore what PowerToys has to offer if they so wish to. ++#### Design:+<img align="left" src="./images/welcomeWindow.png" /> Welcome window+++#### Code:+The frontend and the backend for this window are in [onLaunchContentDialog.xaml](https://github.com/microsoft/PowerToys/blob/interns/users/t-fudami/documentation/POC-OOBE/OOBE-Sandbox/PowerToys%20Settings%20Sandbox/Views/onLaunchContentDialog.xaml) and [onLaunchContentDialog.xaml.cs](https://github.com/microsoft/PowerToys/blob/interns/users/t-fudami/documentation/POC-OOBE/OOBE-Sandbox/PowerToys%20Settings%20Sandbox/Views/onLaunchContentDialog.xaml.cs) respectively. It is later called in the MainPage as below:

The links are pointing to the files in the branch interns/users/t-fudami/documentation. Once you remove the branch (E.g. after merging the PR), the links won't work. I would consider linking to the files in the branch interns/dev-oobe instead. Up to you!

furahadamien

comment created time in 2 months

Pull request review commentmicrosoft/PowerToys

welcome window documentation

+# PowerToys Out Of Box Experience Proposal and Code++##### Developers: [Furaha Dami�n](https://github.com/furahadamien), [Letitia Kwan](https://github.com/letitiakwan), [Jessica Lim](https://github.com/JessicaLim8)+##### Program Manager : [Eunice Choi](https://github.com/eunicechoi98)+##### Designer : Rafael Flora++## Overview+A team of Microsoft Garage interns have created a proposal for the out-of-box experience after the first time install of the PowerToys app, and a proposal for the UI experience of updates.++## 1. Welcome Screen++#### Rationale:+PowerToys v17 has a silent launch after first time installation and update. As evidenced in issue #1285, users are left wondering if anything happened at all. The aim of this new feature is to allow users a chance to appreate the install/update of PowerToys while at the same time giving them a chance to explore what PowerToys has to offer if they so wish to. ++#### Design:+<img align="left" src="./images/welcomeWindow.png" /> Welcome window+++#### Code:+The frontend and the backend for this window are in [onLaunchContentDialog.xaml](https://github.com/microsoft/PowerToys/blob/interns/users/t-fudami/documentation/POC-OOBE/OOBE-Sandbox/PowerToys%20Settings%20Sandbox/Views/onLaunchContentDialog.xaml) and [onLaunchContentDialog.xaml.cs](https://github.com/microsoft/PowerToys/blob/interns/users/t-fudami/documentation/POC-OOBE/OOBE-Sandbox/PowerToys%20Settings%20Sandbox/Views/onLaunchContentDialog.xaml.cs) respectively. It is later called in the MainPage as below:

Perhaps consider linking to MainPage.cs as well.

furahadamien

comment created time in 2 months

Pull request review commentmicrosoft/PowerToys

welcome window documentation

+# PowerToys Out Of Box Experience Proposal and Code++##### Developers: [Furaha Dami�n](https://github.com/furahadamien), [Letitia Kwan](https://github.com/letitiakwan), [Jessica Lim](https://github.com/JessicaLim8)+##### Program Manager : [Eunice Choi](https://github.com/eunicechoi98)+##### Designer : Rafael Flora++## Overview+A team of Microsoft Garage interns have created a proposal for the out-of-box experience after the first time install of the PowerToys app, and a proposal for the UI experience of updates.++## 1. Welcome Screen++#### Rationale:+PowerToys v17 has a silent launch after first time installation and update. As evidenced in issue #1285, users are left wondering if anything happened at all. The aim of this new feature is to allow users a chance to appreate the install/update of PowerToys while at the same time giving them a chance to explore what PowerToys has to offer if they so wish to. ++#### Design:+<img align="left" src="./images/welcomeWindow.png" /> Welcome window

Just FYI, you should be able to use markup to do the same like this:

![](./images/welcomeWindow.png)
*Welcome window*

Up to you!

furahadamien

comment created time in 2 months

Pull request review commentmicrosoft/PowerToys

welcome window documentation

+# PowerToys Out Of Box Experience Proposal and Code++##### Developers: [Furaha Dami�n](https://github.com/furahadamien), [Letitia Kwan](https://github.com/letitiakwan), [Jessica Lim](https://github.com/JessicaLim8)+##### Program Manager : [Eunice Choi](https://github.com/eunicechoi98)+##### Designer : Rafael Flora++## Overview+A team of Microsoft Garage interns have created a proposal for the out-of-box experience after the first time install of the PowerToys app, and a proposal for the UI experience of updates.++## 1. Welcome Screen++#### Rationale:+PowerToys v17 has a silent launch after first time installation and update. As evidenced in issue #1285, users are left wondering if anything happened at all. The aim of this new feature is to allow users a chance to appreate the install/update of PowerToys while at the same time giving them a chance to explore what PowerToys has to offer if they so wish to. ++#### Design:+<img align="left" src="./images/welcomeWindow.png" /> Welcome window

I noticed that in this PR four pictures are added, but only one is used in this doc. Are the other pictures used anywhere?

furahadamien

comment created time in 2 months

Pull request review commentmicrosoft/PowerToys

refactored on-launch contentDialog

+using PowerToys_Settings_Sandbox.ViewModels;+using System;+using System.Collections.Generic;++using Windows.UI.Xaml.Controls;+++// The Content Dialog item template is documented at https://go.microsoft.com/fwlink/?LinkId=234238

*nit* I would move the comment closer to the class, just so it's super clear what it's commenting. I am not super familiar with ContentDialog, but if it is something that developers familiar with the stack should be familiar with, I would also consider omitting it.

furahadamien

comment created time in 2 months

Pull request review commentmicrosoft/PowerToys

refactored on-launch contentDialog

+<ContentDialog+    x:Class="PowerToys_Settings_Sandbox.Views.onLaunchContentDialog"+    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"+    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"+    xmlns:local="using:PowerToys_Settings_Sandbox.Views"+    xmlns:d="http://schemas.microsoft.com/expression/blend/2008"+    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"+    mc:Ignorable="d"

Sorry, I am not super familiar with this tech stack. What does this line do?

furahadamien

comment created time in 2 months

Pull request review commentmicrosoft/PowerToys

refactored on-launch contentDialog

-using Microsoft.QueryStringDotNET;+

*nit* Remove newline.

furahadamien

comment created time in 2 months

GollumEvent

Pull request review commentmicrosoft/PowerToys

[intern] onLaunch dialog window

-using System;+using Microsoft.QueryStringDotNET;+using System;+using System.Collections.Generic;+using System.IO;+using System.Linq;+using System.Runtime.InteropServices.WindowsRuntime;+using Windows.Foundation;+using Windows.Foundation.Collections;+using Windows.UI.Composition;+using Windows.UI.Notifications;+using Windows.UI.Xaml;+using Windows.UI.Xaml.Controls;+using Windows.UI.Xaml.Controls.Primitives;+using Windows.UI.Xaml.Data;+using Windows.UI.Xaml.Input;+using Windows.UI.Xaml.Media;+using Windows.UI.Xaml.Navigation;+using System;

That's awesome, looking forward to it! I'll resolve this conversation in the meanwhile.

furahadamien

comment created time in 2 months

Pull request review commentmicrosoft/PowerToys

[intern] onLaunch dialog window

-using System;+using Microsoft.QueryStringDotNET;+using System;+using System.Collections.Generic;+using System.IO;+using System.Linq;+using System.Runtime.InteropServices.WindowsRuntime;+using Windows.Foundation;+using Windows.Foundation.Collections;+using Windows.UI.Composition;+using Windows.UI.Notifications;+using Windows.UI.Xaml;+using Windows.UI.Xaml.Controls;+using Windows.UI.Xaml.Controls.Primitives;+using Windows.UI.Xaml.Data;+using Windows.UI.Xaml.Input;+using Windows.UI.Xaml.Media;+using Windows.UI.Xaml.Navigation;+using System;

System is added twice.

furahadamien

comment created time in 2 months

Pull request review commentmicrosoft/PowerToys

[intern] onLaunch dialog window

-using System;+using Microsoft.QueryStringDotNET;+using System;+using System.Collections.Generic;+using System.IO;+using System.Linq;+using System.Runtime.InteropServices.WindowsRuntime;+using Windows.Foundation;+using Windows.Foundation.Collections;+using Windows.UI.Composition;+using Windows.UI.Notifications;+using Windows.UI.Xaml;+using Windows.UI.Xaml.Controls;+using Windows.UI.Xaml.Controls.Primitives;+using Windows.UI.Xaml.Data;+using Windows.UI.Xaml.Input;+using Windows.UI.Xaml.Media;+using Windows.UI.Xaml.Navigation;+using System;

I am not super familiar with this tech stack and I might be missing something, but maybe consider removing all the using statements that you are not using.

furahadamien

comment created time in 2 months

pull request commentmicrosoft/PowerToys

onLaunch dialog window

@furahadamien Thanks for sharing! Do you think you could perhaps add instructions (maybe screenshots as well?) on how to trigger this new feature? It would be super helpful for the coaches who don't have much context :)

furahadamien

comment created time in 2 months

pull request commentmicrosoft/hermes-windows

Build hermes using a single script.

@nasadigital Are we ready to check this in?

@Khalef1 Should be good for now.

nasadigital

comment created time in 2 months

PR closed microsoft/vscode-python-devicesimulator

Reviewers
Correct typo for cpx import on getting started

Description:

Minor PR to fix typo on getting started page for cpx. Remove micro:bit and replace with Circuit Playground.

Screen Shot 2020-05-06 at 6 20 41 PM

Issue referenced here #367

+3 -4

0 comment

2 changed files

xnkevinnguyen

pr closed time in 2 months

Pull request review commentmicrosoft/vscode-python-devicesimulator

Correct typo for cpx import on getting started

 exports[`GettingStartedPage component  should render correctly 1`] = `     <h3       className="normalFontWeight"     >-      &gt; Import the micro:bit library to use it (This is required)+      Import the Circuit Playground library to use it (This is required)

It seems that we are keeping the '>' symbol at the start of the line in other lines. Perhaps we keep it here as well?

xnkevinnguyen

comment created time in 2 months

issue openedmicrosoft/react-native-windows

Support direct debugging when using Chakra in VS Code.

<!-- This is a template for new feature or API proposals for React Native Windows. Use this to submit new API/component requests or behavior updates that are specific to Windows-only. For feature requests to React Native, go here instead.

It's fine if you don't have all the details for the template below: you can start with the Summary and Rationale. Read more about React Native for Windows proposal process here -->

Proposal: Support direct debugging in visual studio code

<!-- Add a title for your feature or API proposal. Please be short and descriptive -->

Summary

<!-- Brief explanation of the new API or change. --> You can use VS Code for direct debugging when using V8/Hermes, but not for Chakra. This issue is for adding support.

Motivation

<!-- Why are we doing this? What use cases does it support? What is the expected outcome? Why should this be done for Windows-only?

Please focus on explaining the motivation so that if this proposal is not accepted, the motivation could be used to develop alternative solutions. In other words, enumerate the constraints you are trying to solve without coupling them too closely to the solution you have in mind. --> The only way to do direct debugging with Chakra is through Visual Studio. Adding support for VS Code would allow developers to pick the tool that better suits their needs.

Basic example

<!-- [Optional] If the proposal involves a new or changed API, include a basic code example. Omit this section if it's not applicable. -->

Open Questions

<!-- Please list any open issues that you think still need to be addressed. These could include areas you think would benefit from community or the react-native-windows team input -->

created time in 2 months

issue closedmicrosoft/react-native-windows

Implement Direct Debugging

<!-- This is a template for new feature or API proposals for React Native Windows. Use this to submit new API/component requests or behavior updates that are specific to Windows-only. For feature requests to React Native, go here instead.

It's fine if you don't have all the details for the template below: you can start with the Summary and Rationale. Read more about React Native for Windows proposal process here -->

Proposal: Add support for Direct Debugging

<!-- Add a title for your feature or API proposal. Please be short and descriptive -->

Summary

React-native has direct debugging on other platforms. My understanding is this allows you to debug the javascript running directly in-proc rather than out-of-proc over a websocket connection. We don't support this yet in vnext. This issue is tracking adding support.

Motivation

<!-- Why are we doing this? What use cases does it support? What is the expected outcome? Why should this be done for Windows-only?

Please focus on explaining the motivation so that if this proposal is not accepted, the motivation could be used to develop alternative solutions. In other words, enumerate the constraints you are trying to solve without coupling them too closely to the solution you have in mind. -->

Basic example

<!-- [Optional] If the proposal involves a new or changed API, include a basic code example. Omit this section if it's not applicable. -->

Open Questions

<!-- Please list any open issues that you think still need to be addressed. These could include areas you think would benefit from community or the react-native-windows team input -->

closed time in 2 months

kmelmon

issue commentmicrosoft/react-native-windows

Implement Direct Debugging

@chrisglein To my understanding direct debugging currently works with visual studio. Some remaining work items are:

  • Adding visual studio code support.
  • Updating the wiki with instructions on direct debugging.

My suggestion is open issues for the remaining tasks and close this one. The following board tracks Hermes support (including direct debugging support): https://github.com/microsoft/react-native-windows/projects/25 Would that make sense?

kmelmon

comment created time in 2 months

push eventnasadigital/react-native-windows

dependabot-preview[bot]

commit sha 8a730a15ef2a2addb5b47b6eb2fabee5d54e4bbf

Bump io-ts from 2.2.0 to 2.2.1 (#4644) Bumps [io-ts](https://github.com/gcanti/io-ts) from 2.2.0 to 2.2.1. - [Release notes](https://github.com/gcanti/io-ts/releases) - [Changelog](https://github.com/gcanti/io-ts/blob/master/CHANGELOG.md) - [Commits](https://github.com/gcanti/io-ts/compare/2.2.0...2.2.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 854fd9d0b1f8b41203396697342d30c965d32f14

Bump @types/lodash from 4.14.149 to 4.14.150 (#4642) Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.14.149 to 4.14.150. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Andrew Coates

commit sha 5c98e236066ced8eb314fae9995c288cb2eee798

Release bundle builds should have --dev false flag (#4603) * Make default template build non-dev bundle when not using debug configuration * Change files * review feedback * ReactNativeWindows location shouldn't be hard coded in template project, since RNW could be hoisted * Align bundle props with gradle build options * Fix playground app * minor change * Change how we find the packageroot

view details

Andrew Coates

commit sha a34e2169b7a0224cd2486fab5bd224077234d5d5

react-native-windows-init should support npm tags for --version parameter (#4647) * Fix react-native-windows-init to work with tags (@master) * Change files

view details

Vladimir Morozov

commit sha 21dea64efa55d0cc23d0ad0e33a058b0e3981800

Implemented C++ TurboModule compile time spec validation (#4656) * Implemented C++ TurboModule compile time spec validation * Change files

view details

dependabot-preview[bot]

commit sha 94f2b3f49681bd84fcd2791b815a732db5a12d95

Bump beachball from 1.29.1 to 1.30.2 (#4658) Bumps [beachball](https://github.com/microsoft/beachball) from 1.29.1 to 1.30.2. - [Release notes](https://github.com/microsoft/beachball/releases) - [Changelog](https://github.com/microsoft/beachball/blob/master/azure-pipelines.release.yml) - [Commits](https://github.com/microsoft/beachball/compare/beachball_v1.29.1...beachball_v1.30.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Andrew Coates

commit sha c779043f0dd5e57f66b7609a8a09270aa78ad1b7

Opening the devmenu should attempt to connect to dev tools (#4660) * Fix devtools connection to match RN0.62 * Change files * review feedback

view details

React-Native-Windows Bot

commit sha 3eece7f91fb3dffb7a28b0e7dec726113dcbf371

applying package updates ***NO_CI***

view details

Alexander Sklar

commit sha 16a4ede863a147bf2b473b1eb3b85e6b19c3cb72

Handle syntax errors in RedBox (#4666) * Publish fix * Creating new Microsoft.ReactNative.sln (#4535) * Created new Microsoft.ReactNative.sln * Update PR to build vnext/Microsoft.ReactNative.sln * Add params to disable ReactUWP nuget pack during PR * applying package updates ***NO_CI*** * Move playground app to use Microsoft.ReactNative (#4534) * Move playground app to use Microsoft.ReactNative * formatting * Bunch of code review feedback * Change files * formatting * Delete unneeded gitignore * Minor removal of diff * Minor changes to try to avoid having to update cert all the time * Fix bundle command * No need to build rntester seperately, the release build of playground will do it from msbuild * Remove test property * Bump beachball from 1.28.0 to 1.28.1 (#4539) * applying package updates ***NO_CI*** * applying package updates ***NO_CI*** * Enabling managed unit tests in CI loop (#4532) * Disable .net native for managed unit tests * Change files * Enable managed unit tests in ci loop * re-merge unit test tasks, can't run arm anyway * Remove prefer 32bit from 64bit flavors * Update mstest dependencies * Managed tests are separate again * Add comment * Add test adapter path * x86 debug again * Update test adapter folder * Try again * remove frameworkuap10 * Switch to appxrecipie * Try to switch to installed version of vstest * Remove installer task * applying package updates ***NO_CI*** * Remove 'Delete Android SDK' from E2ETest (#4554) * Enable WebSocketModule unit tests (#4538) * Prototype mockable MessageQueueThread and JSExecutor * Declare MockJSExecutor::CallFunctionFunctor * Add missing using std::unique_ptr * Use WebSocketModule::MethodId * clang format * Make WebSocketModule methods override instead of virtual. * Allow WebSocketModule to use custom resource factory * Rename *Impl to *Mock * Move Instance mocks into separate source files * Move Instance mocks into separate source files * Change files * clang format * Define WebSocketModule::SetResourceFactory * applying package updates ***NO_CI*** * Improve inner loop and error reporting (local CLI) (#4536) -Surface msbuild errors (shows as undefined right now) -downloading nuget with Invoke-WebRequest will usually take a long time because of the PS progress bar (which sadly gets updated for every byte), so I'm disabling the progress bar (it only takes a second to download when the progress bar is turned off) retry once if nuget failed since if you cancel at just the right time, you could end up with a truncated nuget.exe and are wedged unless you know which file to delete. Learned that the hard way. -factor out calling onto powershell functions -we were not exposing whether the function failed or not * applying package updates ***NO_CI*** * Don't set readyState on connection error (#4562) * Don't set readyState on connection error * Change files * applying package updates ***NO_CI*** * Bump @babel/core from 7.8.4 to 7.9.0 (#4565) * Simplified C++ macros and improved their comments (#4568) * Simplified C++ macros and improved their comments * Change files * applying package updates ***NO_CI*** * Handle syntax errors in RedBox * Change files * format * clean up Co-authored-by: Andrew Coates (REDMOND) <acoates@microsoft.com> Co-authored-by: Jon Thysell <jthysell@microsoft.com> Co-authored-by: React-Native-Windows Bot <53619745+rnbot@users.noreply.github.com> Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Julio César Rocha <JunielKatarn@users.noreply.github.com> Co-authored-by: Vladimir Morozov <vmoroz@users.noreply.github.com>

view details

Andrew Coates

commit sha 2fad67bf25bc6eff90417cff91493d9479db5076

Hitting 'r' in the packager should reload the instance (#4665) * Hook up to packager websocket to allow 'r' to reload instance * Change files * minor fix

view details

Andrew Coates

commit sha b35cc97adef395d7b9886425ef3b12ccd5cec6ee

Microsoft.ReactNative Nuget only contains debug bits (#4674) * Publish ship and debug bits in the nuget * Change files * minor change

view details

Andrew Coates

commit sha dcccb2c4d84ff530de5a80ac7e947c3287dff5ab

Create initial codegen for creating TurboModuleSpec's from JS Spec files (#4677) * Start project to codegen NM2 from spec files * Basic codegen working. * formatting * formatting * Get basic codegen sample working. * minor change * minor change * minor changes * Change files

view details

Nick Gerleman

commit sha 509b9e5a57f6d032f2422ead1e09207f10855cbd

Implement String ViewManager Command IDs (#4667) * Implement String ViewManager Command IDs In 0.61 Facebook added the ability to dispatch view manager commands using a string directly instead of the current indirection of getting a command ID from the view manager. This is leveraged in 0.62 in a couple places, including for Switches. UIManager overloads for string commands are added. This change impacts the C++ Microsoft.ReactNative ViewManager APIs C# and upstream view managers abstract away command IDs where they are currently left explicit in our C++ ViewManagers. Given our desire to implement built-in controls, we will need to support string commands here as well. This is made trickier with Facebook still publicly documenting grabbing command IDs from the VIewManager. Providing parallel explicit DispatchCommand functions to Microsoft.ReactNative ViewManagers would be too confusing to our users. Instead of adding parallel paths to the C++ ViewManager for commands without IDs, we remove the ID indirection entirely. Instead of internal ID mapping like we previously did with the C# ViewManagers, we now map constants to literal strings of themselves. This allows ViewManagers to accept the new form of literal string commands dispatched from JS without breaking the documented workflow of getting command IDs from the ViewManager. Eventually we should be able to remove integer only command IDs, as they are internally deprecated. Validated C# and C++ commands still work through the sample app. Validated switch behavior using the RNTester page. Fixes #4596 * Change files

view details

React-Native-Windows Bot

commit sha a57ded1531eb0c14801f5b7d4d0f885b63f7918f

applying package updates ***NO_CI***

view details

Alexander Sklar

commit sha cf58dd6ea41721f26d8df20db68a1e517972892a

Add DevMode in bug template (#4685) * add devmode in template

view details

kmelmon

commit sha b79777438c8e3b17d007aade83172dd676bfa0c5

Fixup direction == 'rtl' (#4683) * fix RTL * lint * Change files * fix clang formatting * fix github issue number

view details

Nick Gerleman

commit sha ff09c554518e7004acc829633a206e044d6870dd

Fix Odd Input Behavior With Override Tool Prompts (#4687) * Fix Odd Input Behavior With Override Tool Prompts `prompts` has some odd behavior when pasting in input, or when adding numbers slowly. Replace it with a similar "inquirer" package which seems to handle input better. Validated overall prompt functionality, copy and paste of text, slow number typing, non-numeric answers, etc. * lint:fix

view details

dependabot-preview[bot]

commit sha 65e4a0438f6df9cb6c9f9aa6eee963ff98288eab

Bump @types/react-native from 0.62.2 to 0.62.3 (#4692)

view details

Nick Gerleman

commit sha 884b7785de848e82d3f36bd48ffbaf51f2a9144c

Pass XamlViews through ReactUwp View Managers by Const Ref (#4681) * Pass XamlView's through ReactUwp View Managers by Const Ref Passing by values means extra copies + extra atomic AddRef and Release. Pass by ref instead. This was a quick find/replace, inspect, and see if we compile deal. I didn't bother trying to catch everything in every view manager, and just fixed the main interface. Much of this will likely get nuked when ABIViewManager becomes the sole source of goodness. * Change files * yarn format

view details

Nick Gerleman

commit sha 6cf4c2bb579b424783530f1b3213a9fcb5742d2d

Fix Build Break Due To Missing Include in DevSupportManagerUwp (#4693) * Fix Missing Include in DevSupportManagerUwp This is causing failures in publish and locally. Possibly a silent merge conflict? * Change files

view details

push time in 2 months

pull request commentmicrosoft/hermes-windows

Build hermes using a single script.

@mganandraj Thanks for the feedback! As you mentioned, I think the best approach is to use a powershell script. I have added a new script which builds hermes on Windows. The script can be used like this: > .\utils\build\buildWindows.ps1 Currently it supports the parameter -Release which builds the release configuration instead of debug. Let me know if I should add any other parameters or if you have any other feedback!

nasadigital

comment created time in 2 months

push eventnasadigital/hermes-windows

David Serafimov

commit sha ee0801aa007c1470860c2977e1957c45722b77ba

Use powershell script to build on Windows.

view details

push time in 2 months

PR opened microsoft/hermes-windows

Build hermes using a single script.

Tried to addresses https://github.com/microsoft/react-native-windows/projects/25#card-36054669. Allows user to build hermes using a single call to utils/build/configure.py, like so:

$ utils/build/configure.py --build-system='Visual Studio 16 2019' --cmake-flags='-A x64'

Added --release flag which when omitted builds hermes in debug. This builds all .exes, which I am not sure are different from a UWP binary. Let me know if you had something different in mind!

+9 -0

0 comment

1 changed file

pr created time in 3 months

create barnchnasadigital/hermes-windows

branch : singleCommand

created branch time in 3 months

fork nasadigital/hermes-windows

Hermes is a small and lightweight JavaScript engine optimized for running React Native on Android.

https://hermesengine.dev

fork in 3 months

Pull request review commentmicrosoft/vscode-python-devicesimulator

Release Note Apr 21

 // TODO: find a better way of loading html into a string-export const LATEST_RELEASE_NOTE = `<h1>Device Simulator Express Release Notes 📝(April 20, 2020)</h1>-<p>-    <p> We're back with a full release for the Adafruit CLUE 🐍🔍.</p>+export const LATEST_RELEASE_NOTE = `<h1>Device Simulator Express Release Notes </h1>+<p>Device Simulator Express, a Microsoft Garage project, allows you to code microcontrollers without the hardware on hand! You can program your Adafruit Circuit Playground Express (CPX), your BBC micro:bit or the Adafruit CLUE!</p>+<div style="padding:20px 0px 10px 0px">+    <svg xmlns="http://www.w3.org/2000/svg" width="300px" viewBox="0 0 304.89 250.98"><defs><style>.cls-1{fill:#097054;}.cls-1,.cls-13,.cls-14,.cls-15,.cls-23,.cls-9{stroke:#000;}.cls-1,.cls-11,.cls-12,.cls-13,.cls-14,.cls-15,.cls-17,.cls-22,.cls-23,.cls-3,.cls-4,.cls-5,.cls-6,.cls-9{stroke-miterlimit:10;}.cls-1,.cls-23{stroke-width:1.99px;}.cls-18,.cls-2{fill:#fff;}.cls-11,.cls-12,.cls-17,.cls-23,.cls-3,.cls-4,.cls-5,.cls-6,.cls-7,.cls-8{fill:none;}.cls-11,.cls-12,.cls-17,.cls-3,.cls-4,.cls-5,.cls-6,.cls-7,.cls-8{stroke:#fff;}.cls-3{stroke-width:2px;}.cls-12,.cls-17,.cls-4,.cls-5,.cls-6,.cls-7,.cls-8{stroke-linecap:round;}.cls-4,.cls-7{stroke-width:1.63px;}.cls-5{stroke-width:1.41px;}.cls-6{stroke-width:1.6px;}.cls-7,.cls-8{stroke-linejoin:round;}.cls-8{stroke-width:1.63px;}.cls-10,.cls-15,.cls-9{fill:#7e7272;}.cls-22,.cls-9{stroke-width:1.5px;}.cls-12{stroke-width:1.71px;}.cls-13{fill:#6599ff;}.cls-13,.cls-14,.cls-15{stroke-width:0.25px;}.cls-16{fill:#ffde00;}.cls-17{stroke-width:2.02px;}.cls-18{font-size:7px;font-family:SegoeUI-Bold, Segoe UI;font-weight:700;letter-spacing:-0.02em;}.cls-19{letter-spacing:-0.03em;}.cls-20{letter-spacing:-0.05em;}.cls-21{letter-spacing:0em;}.cls-22{stroke:#7e7272;}</style></defs><g id="Green"><rect class="cls-1" x="1.92" y="0.99" width="301.98" height="248.98" rx="18.28"/><path d="M352.66,281.16c-.24-1.61.56-3.37.5-5-.06-1.82,0-3.29,0-5.11,0-.6-.93-1.17-.59-1.49v0c0-.93.14-1.84.12-2.78a2.35,2.35,0,0,1,0-.47H51a2.15,2.15,0,0,1,.09.59c0,3.63-.33,7.25-.41,10.88a19.72,19.72,0,0,0,.34,4.79,29.45,29.45,0,0,0,1.71,4.74c.48,1.19.85,2.37,1.43,3.49l.66.63a8.82,8.82,0,0,0,1.52,1.2,14.9,14.9,0,0,1,2.11,1.61c.52.49,1,1,1.53,1.51a13,13,0,0,0,7.93,2.64,1.86,1.86,0,0,1,1.34.55H336.36a2.16,2.16,0,0,1,.6-.32c1.47-.51,3-1,4.44-1.47.74-.25,1.48-.52,2.21-.81l.22-.09.53-.23,1.05-.51c.16-.19.32-.38.49-.55a11.28,11.28,0,0,1,1.78-1.45l.71-.5c-.1.07.28-.25.28-.25s.21-.2.31-.3l.13-.12.07-.1.22-.3.48-.62c.47-1.27.86-2.58,1.31-3.85.27-.74.54-1.48.75-2.23a10.88,10.88,0,0,0,.26-1.13.64.64,0,0,1,0-.07v-.07q0-.35,0-.69a2,2,0,0,1,.51-1.29C352.73,281.68,352.7,281.41,352.66,281.16Z" transform="translate(-49.27 -48.48)"/><path class="cls-2" d="M337.11,97.27l-8.21,8a5.75,5.75,0,0,1-5.11,1.67,10.11,10.11,0,0,1-5.69-3.26,9.08,9.08,0,0,1-2.92-5.53,6.28,6.28,0,0,1,2.18-5l8.09-7.85,4.8,4.94L322.17,98a1.39,1.39,0,0,0-.11,2.21,1.36,1.36,0,0,0,2.18-.08l8.07-7.84Z" transform="translate(-49.27 -48.48)"/><circle class="cls-3" cx="245.66" cy="20.77" r="6.6"/></g><g id="Clue"><path class="cls-2" d="M307.54,78.85a15.08,15.08,0,1,0-2.61,2.78l-4.61-4.73a9.3,9.3,0,1,1,2.5-2.71Z" transform="translate(-49.27 -48.48)"/><polygon class="cls-2" points="265.35 26.2 269.45 30.3 259.85 39.06 265.63 45.11 262.09 48.44 251.64 38.41 265.35 26.2"/><polygon class="cls-2" points="276.59 62.99 289.35 50.19 300.35 61.15 296.77 64.66 290.07 58.19 288.88 59.39 295.73 66.25 292.62 69.37 285.77 62.5 284.69 63.58 291.51 70.41 287.58 73.99 276.59 62.99"/></g><g id="Finger_Prints_A" data-name="Finger Prints A"><path class="cls-4" d="M56.44,206.71s-4,.81-5.08.3" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M115.19,141.85S107,131,89.4,131.58" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M86.93,131.55s-16,1-22.88,9.67c0,0-6,7.85-12.69,10.41" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M115.19,146.78s-8.87-12.47-27.15-12a35.07,35.07,0,0,0-20.3,7.47S55,155.13,53.57,155.75c-3.49,1.56-2.94,1.16-2.94,1.16" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M116.55,154.8s-5.43-14.1-25.71-16.72c0,0-15.78,0-25,10.21" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M105.87,147.52s-14-12.75-31.18-1.62c0,0-9.16,6.27-9.43,7.6" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M108.11,149.69s12.43,8.9,4.87,27.41c0,0-14.65,24-34.36,31.87" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M85.09,201.08s22.62-15.61,25.51-27.61" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M91.68,145.64s21.42-.51,20.36,24.7" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M101.48,152.82s24.86,15-17,44.75" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M115.19,182.53s-24,28.17-39.43,32" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M115.31,187.21c-.51-.47-17.81,23.27-40.22,31.12" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M115.19,192.85s-24.84,26.76-39.43,28.33" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M65.74,148.45S55.6,160.61,51.26,160.61" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M63.46,155.69S53,165.84,51.36,164.41" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M63.92,160.13s-9.49,8.58-12.57,8.05" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M63.92,166.34s-9.53,4.74-11.82,4.74" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M63.28,174.08s-9.07,5.55-12.28,4.67" transform="translate(-49.27 -48.48)"/><line class="cls-4" x1="14.37" y1="130.55" x2="2.53" y2="133.56"/><path class="cls-4" d="M63.28,182.53S51.91,184.31,51,187.68c0,0,.26,3.95,14.56-2.56" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M71.09,153s9.67-9.07,16.46-7.75c0,0,3.72,2.71,0,3.19,0,0-11.11,3.12-12,5.05" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M92.85,185.35S84.46,198.59,59.44,206" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M88,185.12s-16,18.23-36.59,18.87" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M81.43,185.12s-12.16,13.24-30.9,15.42" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M76.62,185.12s-17.78,11.82-26.54,11.54" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M69.27,185.35c-1.14,1.32-12.46,7.88-17.91,7" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M50.53,211C74.23,208.24,82,199.2,82,199.2s3.55,3.57-2.24,5.62c0,0-7.7,3.69-8.06,14.79" transform="translate(-49.27 -48.48)"/><path class="cls-5" d="M64.67,220.54c-1.22-2.53,1.35-5.16,1.84-5.71s-5.05,3.43-8.14,2.44" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M71.64,209.67c.68-.52-14.32,6.57-20.64,4.83" transform="translate(-49.27 -48.48)"/><path class="cls-6" d="M68.7,220.6c-1.89-2.94,2.33-10.1,2.84-10.76" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M95.17,155.18a6.87,6.87,0,0,1,4.12.9c4.26,2.28,9.24,9.44,1.22,21L90.3,188.47" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M98.88,151.63s-7.68-5.19-16.61,3.51" transform="translate(-49.27 -48.48)"/><path class="cls-7" d="M94.86,177.1s7.45-5.5,6.38-10.76c-1.26-6.22-2.36-5.56-6.38-6.21" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M95,171.08s5.24-2,3.5-4.6c-.79-1.16-3.3-1.93-4.18-1.93" transform="translate(-49.27 -48.48)"/><path class="cls-8" d="M54,136.57s15.76-9.34,16.09-9.42,3.7,2.21,3.41,3.76c0,0-11.71,13-13.37,14.65-.74.72-2.32-3-2.37-3.63s3-3.1,3-3.1l-1.12-1.29-3.48,3.06S53,138.6,54,136.57Z" transform="translate(-49.27 -48.48)"/><path class="cls-2" d="M62.25,135.36c.09-.14,5.61-2.87,5.61-2.87l-4.52,4.61Z" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M63.64,170.34s-10.09,5.18-12.38,5" transform="translate(-49.27 -48.48)"/></g><g id="Bottom"><path class="cls-9" d="M335.52,298.51c1.73-.47,3.56-.61,5.25-1.17.4-.14.79-.29,1.18-.45l.26-.11.82-.34q.6-.26,1.23-.48l-.16-40.78s-.11-11.64-14.42-11.77c-14.3.13-13.42,11.77-13.42,11.77V298.5c6.23.17,11.41.22,16.19.2l2.81-.09A1.17,1.17,0,0,1,335.52,298.51Z" transform="translate(-49.27 -48.48)"/><path class="cls-9" d="M269.57,244.65c-14.3.13-13.42,11.78-13.42,11.78v41.78a53.61,53.61,0,0,1,7.28.19h.08c.85,0,1.7,0,2.56,0,1.76.07,3.53.06,5.29.06h5.57c.87,0,1.73,0,2.6.06a11,11,0,0,0,1.87-.36,2.58,2.58,0,0,1,1.27.11l1.32-.14V256.43S283.88,244.78,269.57,244.65Z" transform="translate(-49.27 -48.48)"/><path class="cls-9" d="M200.66,298.39c4.71.21,9.43.3,14.14.31l.48,0a2.2,2.2,0,0,1,.6-.12,2.55,2.55,0,0,1,.51-.11v-42s-.12-11.65-14.42-11.78c-14.31.13-13.42,11.78-13.42,11.78v42l.31,0a16.3,16.3,0,0,0,3.35.05h3.39l4.33,0A1.67,1.67,0,0,1,200.66,298.39Z" transform="translate(-49.27 -48.48)"/><path class="cls-9" d="M148.42,298.45v-42s-.11-11.65-14.41-11.78h0c-14.31.13-13.42,11.78-13.42,11.78v41.89C132.07,298,140,298.7,148.42,298.45Z" transform="translate(-49.27 -48.48)"/><path class="cls-9" d="M61.42,296.3l.24.11a4.86,4.86,0,0,1,.78.49,1.91,1.91,0,0,1,.52.46c4.79.23,19.65.77,25.72.83l-.15-41.45S88.42,245.1,74.12,245c-14.31.13-13.42,11.77-13.42,11.77Z" transform="translate(-49.27 -48.48)"/><circle cx="85.24" cy="210.35" r="12.23"/><circle cx="153.2" cy="210.35" r="12.23"/><circle cx="220.8" cy="210.35" r="12.23"/><circle cx="280.98" cy="210.98" r="12.23"/><circle cx="25.35" cy="210.72" r="12.23"/><rect class="cls-10" x="40.39" y="219.54" width="5.97" height="30.12" rx="0.72"/><rect class="cls-10" x="48.31" y="219.46" width="5.97" height="30.12" rx="0.72"/><rect class="cls-10" x="56.23" y="219.46" width="5.97" height="30.12" rx="0.72"/><rect class="cls-10" x="64.16" y="219.46" width="5.97" height="30.12" rx="0.72"/><rect class="cls-10" x="100.43" y="219.76" width="5.97" height="30.12" rx="0.72"/><rect class="cls-10" x="108.36" y="219.76" width="5.97" height="30.12" rx="0.72"/><rect class="cls-10" x="116.13" y="219.76" width="5.97" height="30.12" rx="0.72"/><rect class="cls-10" x="124.05" y="219.67" width="5.97" height="30.12" rx="0.72"/><rect class="cls-10" x="132.03" y="219.67" width="5.97" height="30.12" rx="0.72"/><rect class="cls-10" x="168.17" y="219.67" width="5.97" height="30.12" rx="0.72"/><rect class="cls-10" x="176.09" y="219.67" width="5.97" height="30.12" rx="0.72"/><rect class="cls-10" x="184.01" y="219.67" width="5.97" height="30.12" rx="0.72"/><rect class="cls-10" x="191.94" y="219.67" width="5.97" height="30.12" rx="0.72"/><rect class="cls-10" x="199.86" y="219.67" width="5.97" height="30.12" rx="0.72"/><rect class="cls-10" x="235.94" y="219.61" width="5.97" height="30.12" rx="0.72"/><rect class="cls-10" x="243.87" y="219.61" width="5.97" height="30.12" rx="0.72"/><rect class="cls-10" x="251.79" y="219.41" width="5.97" height="30.12" rx="0.72"/><rect class="cls-10" x="259.71" y="219.41" width="5.97" height="30.12" rx="0.72"/><path class="cls-10" d="M352.06,289.38V268.61a.78.78,0,0,0-.82-.72h-5.18a.78.78,0,0,0-.82.72v25.76l1.34.56c.71-.48,1.45-.93,2.18-1.4a9.06,9.06,0,0,0,1.45-1.23,5.31,5.31,0,0,0,.66-1,1.6,1.6,0,0,1,.65-.61,2,2,0,0,1,.37-.84A.73.73,0,0,0,352.06,289.38Z" transform="translate(-49.27 -48.48)"/><path class="cls-10" d="M52.92,291.09h0c.12-.6,0-.12,0,.13l.08.26a1.58,1.58,0,0,1,.49.73v0a1.49,1.49,0,0,0,.15.2,10.15,10.15,0,0,0,1.42,1.07,15.45,15.45,0,0,0,2.9,1.37l1,.33a3.7,3.7,0,0,1,.9.39V268.71a.83.83,0,0,0-.91-.72H53.34a.83.83,0,0,0-.91.72v20.61a2.84,2.84,0,0,1,.24.26A1.75,1.75,0,0,1,52.92,291.09Z" transform="translate(-49.27 -48.48)"/><path class="cls-11" d="M76,297" transform="translate(-49.27 -48.48)"/><path class="cls-11" d="M107.76,292.27" transform="translate(-49.27 -48.48)"/><path d="M136.31,286.57h-1.49V281a5,5,0,0,1-1.91,1.12v-1.34a4.35,4.35,0,0,0,1.26-.72,2.76,2.76,0,0,0,.93-1.24h1.21Z" transform="translate(-49.27 -48.48)"/><path d="M205.2,285.25v1.38H200a3.63,3.63,0,0,1,.51-1.48,9.93,9.93,0,0,1,1.66-1.86A10.32,10.32,0,0,0,203.4,282a1.61,1.61,0,0,0,.31-.91,1,1,0,0,0-.27-.76,1,1,0,0,0-.73-.27,1,1,0,0,0-.74.28,1.48,1.48,0,0,0-.32.93l-1.47-.15a2.39,2.39,0,0,1,.82-1.75,2.78,2.78,0,0,1,1.74-.54,2.51,2.51,0,0,1,1.8.62,2,2,0,0,1,.66,1.54,2.81,2.81,0,0,1-.19,1,4.43,4.43,0,0,1-.59,1,9.4,9.4,0,0,1-1,1c-.47.43-.77.72-.89.86a2.6,2.6,0,0,0-.31.41Z" transform="translate(-49.27 -48.48)"/><path d="M263.73,283.81l1.44-.17a1.37,1.37,0,0,0,.37.84,1,1,0,0,0,1.5-.06,1.35,1.35,0,0,0,.31-.94,1.28,1.28,0,0,0-.3-.89,1,1,0,0,0-.73-.32,2.33,2.33,0,0,0-.68.11l.16-1.21a1.33,1.33,0,0,0,.92-.26.94.94,0,0,0,.31-.74.81.81,0,0,0-.23-.62.85.85,0,0,0-.62-.23.9.9,0,0,0-.64.26,1.25,1.25,0,0,0-.33.77l-1.37-.23a3.16,3.16,0,0,1,.43-1.12,1.94,1.94,0,0,1,.8-.66,2.74,2.74,0,0,1,1.16-.24,2.29,2.29,0,0,1,1.75.7,1.8,1.8,0,0,1,.54,1.28,1.83,1.83,0,0,1-1.11,1.63,1.72,1.72,0,0,1,1.06.64,1.8,1.8,0,0,1,.4,1.19,2.35,2.35,0,0,1-.74,1.74,2.81,2.81,0,0,1-3.6.11A2.4,2.4,0,0,1,263.73,283.81Z" transform="translate(-49.27 -48.48)"/><path d="M272.09,285.86l-2.76-7.73H271l2,5.72,1.89-5.72h1.66l-2.77,7.73Z" transform="translate(-49.27 -48.48)"/><path d="M322.5,283.73v-1.31h3.36v3.08a4.19,4.19,0,0,1-1.42.84,5.2,5.2,0,0,1-1.89.36,4.23,4.23,0,0,1-2.11-.51,3.29,3.29,0,0,1-1.36-1.45,4.77,4.77,0,0,1-.45-2.06,4.44,4.44,0,0,1,.51-2.15,3.33,3.33,0,0,1,1.48-1.44,3.93,3.93,0,0,1,1.85-.38,3.71,3.71,0,0,1,2.25.6,2.7,2.7,0,0,1,1,1.67l-1.55.29a1.64,1.64,0,0,0-.61-.9,1.89,1.89,0,0,0-1.13-.33,2.13,2.13,0,0,0-1.63.65,2.73,2.73,0,0,0-.6,1.92,3,3,0,0,0,.61,2.07,2,2,0,0,0,1.6.69,2.69,2.69,0,0,0,1-.2,3,3,0,0,0,.84-.46v-1Z" transform="translate(-49.27 -48.48)"/><path d="M327.32,286.57v-7.73h1.51L332,284v-5.16h1.45v7.73h-1.57l-3.11-5v5Z" transform="translate(-49.27 -48.48)"/><path d="M335.09,278.84H338a5.51,5.51,0,0,1,1.47.15,2.54,2.54,0,0,1,1.16.71,3.32,3.32,0,0,1,.74,1.25,5.65,5.65,0,0,1,.25,1.83,5,5,0,0,1-.23,1.64,3.52,3.52,0,0,1-.83,1.37,2.83,2.83,0,0,1-1.1.62,5,5,0,0,1-1.38.16h-2.94Zm1.56,1.31v5.12h1.17a4,4,0,0,0,.94-.08,1.35,1.35,0,0,0,.63-.32,1.55,1.55,0,0,0,.41-.75,4.79,4.79,0,0,0,.16-1.41,4.48,4.48,0,0,0-.16-1.38,1.72,1.72,0,0,0-.44-.75,1.45,1.45,0,0,0-.72-.36,7.16,7.16,0,0,0-1.28-.07Z" transform="translate(-49.27 -48.48)"/><path d="M74.76,278.24a2.11,2.11,0,0,1,1.75.8,6.91,6.91,0,0,1,0,6.3,2.11,2.11,0,0,1-1.75.8,2.21,2.21,0,0,1-1.82-.87A7.08,7.08,0,0,1,73,279,2.13,2.13,0,0,1,74.76,278.24Zm0,1.23a.76.76,0,0,0-.48.17,1.2,1.2,0,0,0-.33.62,8.54,8.54,0,0,0-.15,1.93,7.85,7.85,0,0,0,.14,1.87,1.29,1.29,0,0,0,.34.68.76.76,0,0,0,1,0,1.13,1.13,0,0,0,.32-.62,7.85,7.85,0,0,0,.16-1.93,8.44,8.44,0,0,0-.14-1.87,1.42,1.42,0,0,0-.34-.68A.76.76,0,0,0,74.76,279.47Z" transform="translate(-49.27 -48.48)"/></g><g id="Finger_Prints_B" data-name="Finger Prints B"><line class="cls-4" x1="301.28" y1="125.01" x2="303.85" y2="125.01"/><path class="cls-12" d="M344.42,194.53l4.53,4.09v3.74l-2,2.89-3,.95s1.09,1.45.13,2.6-2.88,3.46-4.23,3.56-4.23-1.49-5.28-2.21c-.82-.56-2.5-2-2.5-2l12.38-13.47" transform="translate(-49.27 -48.48)"/><path class="cls-2" d="M344.46,199.68s2,1.59.64,3.16c0,0-2.05,1.57-2.68,1.11l-.91-1Z" transform="translate(-49.27 -48.48)"/><path class="cls-2" d="M336.52,208.15l2.84-3.13a1.39,1.39,0,0,1,1.31,1.44s-1,3.41-2.07,3.16C338.6,209.62,336.51,209.74,336.52,208.15Z" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M287.52,141.58a33.74,33.74,0,0,1,26.82-11.13" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M316.82,130.42s16,1,22.87,9.66c0,0,6,7.85,12.69,10.42" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M287.74,146.43A34.47,34.47,0,0,1,336,141.12s12.79,12.88,14.18,13.5c3.48,1.56,2.94,1.15,2.94,1.15" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M287.19,153.67s5.43-14.1,25.71-16.73c0,0,15.79.05,25,10.22" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M297.87,146.39s14-12.75,31.18-1.62c0,0,8.23,5.45,8.49,6.78" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M295.93,148.26s-13.35,11.21-5.16,27.7c0,0,14.65,24,34.35,31.87" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M318.65,199.94s-22.62-15.61-25.5-27.61" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M312.06,144.51s-24.32,1.92-19.47,25.44" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M302.17,151.55s-22.49,18.4,17.11,44.88" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M287,178.13s4.77,6.64,5.88,7.37" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M294.5,187.66s18.81,21.52,33.49,25.7" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M287,184.45c.51-.47,19.21,24.9,41.62,32.74" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M287.75,190.81S313.4,218.48,328,220" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M338,147.31s10.63,12,13.65,12.16" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M340.28,154.56s10.44,10.14,12.1,8.72" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M339.83,159s9.21,8.58,11.82,7.91" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M339.83,165.21s9.53,4.74,11.82,4.74" transform="translate(-49.27 -48.48)"/><line class="cls-4" x1="290.56" y1="120.26" x2="298.72" y2="124.28"/><path class="cls-4" d="M340.46,172.94s9.07,5.55,12.29,4.67" transform="translate(-49.27 -48.48)"/><line class="cls-4" x1="290.84" y1="129.42" x2="302.68" y2="132.43"/><path class="cls-4" d="M340.46,181.4s11.37,1.78,12.29,5.15c0,0,.37,3.87-12.64-1.88" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M332.65,151.87s-9.66-9.06-16.45-7.74c0,0-3.73,2.7,0,3.18,0,0,10.44,2.3,11.36,4.24" transform="translate(-49.27 -48.48)"/><line class="cls-4" x1="299.12" y1="155.01" x2="303.12" y2="156.54"/><path class="cls-4" d="M312.05,184.77s13.24,14.41,25.12,17.6" transform="translate(-49.27 -48.48)"/><line class="cls-4" x1="299.91" y1="152.87" x2="303.9" y2="153.36"/><path class="cls-4" d="M349.17,201.35" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M339.54,199.62" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M317.48,185c-.09-.15,10.84,10.54,22.06,14.67" transform="translate(-49.27 -48.48)"/><line class="cls-4" x1="299.67" y1="149.65" x2="303.48" y2="150.39"/><path class="cls-4" d="M323.16,185a39.85,39.85,0,0,0,19.21,11.75" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M328.65,185s14.77,9.86,23.73,10.55" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M334.13,184.45c1.94,2.33,12.8,7.64,18.25,6.78" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M334.61,205c-4.31-1.83-12.91-7-12.91-7s-2.42,3.81,2.24,5.62c0,0,7.71,3.69,8.07,14.79" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M338.6,218.29c1.65-2.77-1-6-1.54-6.74s5.45,4.45,9.1,3.62" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M332.63,207.48c-.49-.69,4.23,5.35,6.89,4.81" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M335,218.48c2.07-2.87-1.91-10.31-2.41-11" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M308.57,154.05a6.88,6.88,0,0,0-4.12.9c-4.26,2.27-9.23,9.43-1.22,21l6.4,7.7" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M304.45,149.78s7.07-3.21,10.94,1.26" transform="translate(-49.27 -48.48)"/><path class="cls-7" d="M308.89,176s-6.27-5-5.27-10.23a8.83,8.83,0,0,1,5.27-6.73" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M308.55,170s-2.65-1.89-1.77-4.23a3.08,3.08,0,0,1,2.11-1.79" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M345.59,205.67l2.39,2.16s3.67,1.95,4.78,1.68" transform="translate(-49.27 -48.48)"/><path class="cls-4" d="M343.13,209.87l2.59,1.45s5,2.41,7.4,2.17" transform="translate(-49.27 -48.48)"/></g><g id="Buttons"><rect class="cls-10" x="258.06" y="100.27" width="35.04" height="34.82" rx="1.79"/><circle class="cls-13" cx="275.58" cy="117.58" r="11.6"/><circle class="cls-14" cx="262.37" cy="104.6" r="3.23"/><circle class="cls-14" cx="288.79" cy="104.6" r="3.23"/><circle class="cls-14" cx="288.8" cy="130.74" r="3.23"/><circle class="cls-14" cx="262.37" cy="130.74" r="3.23"/><rect class="cls-15" x="13.19" y="100.56" width="35.04" height="34.82" rx="1.79"/><circle class="cls-13" cx="30.71" cy="117.86" r="11.6"/><circle class="cls-14" cx="17.49" cy="104.88" r="3.23"/><circle class="cls-14" cx="43.92" cy="104.88" r="3.23"/><circle class="cls-14" cx="43.92" cy="131.03" r="3.23"/><circle class="cls-14" cx="17.49" cy="131.03" r="3.23"/></g><g id="Buttons_at_top" data-name="Buttons at top"><rect class="cls-16" x="105.78" y="5.76" width="17.4" height="8.98"/><rect class="cls-16" x="182.92" y="7.04" width="17.4" height="8.98"/><rect x="141.05" y="3.38" width="24.18" height="15.57"/><polyline class="cls-17" points="101.04 11.16 57.9 11.16 53.94 14.23"/><text class="cls-18" transform="translate(29.59 11.79) rotate(45.15) scale(1 1.56)">LIGHT</text><text class="cls-18" transform="translate(22.78 18.93) rotate(45.15) scale(1 1.56)">GESTURE</text><text class="cls-18" transform="translate(15.48 26.01) rotate(45.15) scale(1 1.56)">P<tspan class="cls-19" x="4.13" y="0">R</tspan><tspan class="cls-20" x="8.47" y="0">O</tspan><tspan x="13.43" y="0">XIMI</tspan><tspan class="cls-21" x="28.48" y="0">T</tspan><tspan x="32.56" y="0">Y</tspan></text><path class="cls-2" d="M74,56.37l1.72-1.8.9.86-1.72,1.8L76.73,59l-.86.91-1.8-1.72-1.72,1.8-.9-.86,1.72-1.8-1.81-1.72.86-.9Z" transform="translate(-49.27 -48.48)"/><path class="cls-2" d="M66.81,63.6l1.72-1.81.9.86-1.72,1.81,1.8,1.71-.86.91-1.8-1.72-1.72,1.8-.9-.86L66,64.5l-1.81-1.72.86-.9Z" transform="translate(-49.27 -48.48)"/><rect class="cls-2" x="127.86" y="5.76" width="8.61" height="12.92"/><rect class="cls-2" x="169.77" y="5.76" width="8.61" height="12.92"/></g><g id="Frame"><rect class="cls-22" x="64.9" y="26.42" width="175.97" height="152.12"/><rect class="cls-23" x="1.82" y="0.99" width="301.98" height="248.98" rx="18.28"/></g></svg>+</div>++<h2>📝(April 21, 2020)</h2>

*nit* Perhaps omit the brackets around the date?

andreamah

comment created time in 3 months

Pull request review commentmicrosoft/vscode-python-devicesimulator

Slideshow Backwards/Forwards Bug Fix

 def update(self): 
     def __get_next_img(self):
 
-        # handle empty queue
-        if not len(self.pic_queue):
-            if self.loop:
+        if self.direction == PlayBackDirection.FORWARD:
+            self._current_image_index +=1
+            
+            if (self._current_image_index>= len(self.dir_imgs)):

*nit* Spacing around operators.

andreamah

comment created time in 3 months

Pull request review commentmicrosoft/vscode-python-devicesimulator

Table of Contents for README

 Make without limit! Device Simulator Express, a Microsoft Garage project, allows result when you plug in your actual microcontroller. Curious about the output of the device, the serial
 monitor allows you to observe the device output.
 
-## Devices we support:
+## Table of Contents
+  - [Devices we support](#devices-we-support)

Do we know how the table of contents will work in the marketplace?

vandyliu

comment created time in 3 months

push eventnasadigital/react-native-windows

Andrew Coates

commit sha 32121155445b8e063c2f356ccf6c5105707bcc32

Rework more publish logic - produce nugets in PRs (#4524) * Rework more publish logic - produce nugets in PRs * Change files * typo * minor fix * minor fixes * minor fixes * typo

view details

React-Native-Windows Bot

commit sha a1d4a2b49e8beaccf62033d21626914d7f336652

applying package updates ***NO_CI***

view details

Andrew Coates (REDMOND)

commit sha 8134be51dcbc3b51239cf71b9fc06f7a4a7db7aa

Publish fix

view details

Kai Guo

commit sha f4ca47692485f0991c4b1175deac5d7f4b19b74f

Remove "Using namespace" in ReactPackageProvider.h (#4525) * Remove using namespace * Change files

view details

React-Native-Windows Bot

commit sha 4350275e18aa8fb61532de0d7c7f50f09274be1e

applying package updates ***NO_CI***

view details

Andrew Coates (REDMOND)

commit sha f3a24fb9a04ca6c0b5a0d10568c44e9c2ab47413

Publish fix

view details

Jon Thysell

commit sha 89accf227366ccda8da7faf8957612401c2aac88

Creating new Microsoft.ReactNative.sln (#4535) * Created new Microsoft.ReactNative.sln * Update PR to build vnext/Microsoft.ReactNative.sln * Add params to disable ReactUWP nuget pack during PR

view details

React-Native-Windows Bot

commit sha 9e4cbc98ed11294310236abe361548da8cf88890

applying package updates ***NO_CI***

view details

Andrew Coates

commit sha 03fb17db7b929a6a9ec5b3ce4a00f8ea54560b03

Move playground app to use Microsoft.ReactNative (#4534) * Move playground app to use Microsoft.ReactNative * formatting * Bunch of code review feedback * Change files * formatting * Delete unneeded gitignore * Minor removal of diff * Minor changes to try to avoid having to update cert all the time * Fix bundle command * No need to build rntester seperately, the release build of playground will do it from msbuild * Remove test property

view details

dependabot-preview[bot]

commit sha 92e84e2eadc15300f3378568c546124bb4e72917

Bump beachball from 1.28.0 to 1.28.1 (#4539)

view details

React-Native-Windows Bot

commit sha 6b30869bfdd828e105d71bc0149147cdaeba8024

applying package updates ***NO_CI***

view details

React-Native-Windows Bot

commit sha 5c2d49a8bf45680c41785ac906c1e0f72389b377

applying package updates ***NO_CI***

view details

Jon Thysell

commit sha 98049fcc569ec9ff0ee735311b1f4552adee8be2

Enabling managed unit tests in CI loop (#4532) * Disable .net native for managed unit tests * Change files * Enable managed unit tests in ci loop * re-merge unit test tasks, can't run arm anyway * Remove prefer 32bit from 64bit flavors * Update mstest dependencies * Managed tests are separate again * Add comment * Add test adapter path * x86 debug again * Update test adapter folder * Try again * remove frameworkuap10 * Switch to appxrecipie * Try to switch to installed version of vstest * Remove installer task

view details

React-Native-Windows Bot

commit sha aeacf64c918891e8ca3b8d1a10943fa03054c8f9

applying package updates ***NO_CI***

view details

Jon Thysell

commit sha a09aa1998dc6c792042da1a2d905d4fa535b18d0

Remove 'Delete Android SDK' from E2ETest (#4554)

view details

Julio César Rocha

commit sha c8085b5bb88342ed9c7b91ed3c093818ef67aad2

Enable WebSocketModule unit tests (#4538) * Prototype mockable MessageQueueThread and JSExecutor * Declare MockJSExecutor::CallFunctionFunctor * Add missing using std::unique_ptr * Use WebSocketModule::MethodId * clang format * Make WebSocketModule methods override instead of virtual. * Allow WebSocketModule to use custom resource factory * Rename *Impl to *Mock * Move Instance mocks into separate source files * Move Instance mocks into separate source files * Change files * clang format * Define WebSocketModule::SetResourceFactory

view details

React-Native-Windows Bot

commit sha 174396631d01f1c5c81d8ca2e7ac5d79271715a5

applying package updates ***NO_CI***

view details

Alexander Sklar

commit sha ff6f8f57587f7364143a701ef6637039b6643cf4

Improve inner loop and error reporting (local CLI) (#4536) -Surface msbuild errors (shows as undefined right now) -downloading nuget with Invoke-WebRequest will usually take a long time because of the PS progress bar (which sadly gets updated for every byte), so I'm disabling the progress bar (it only takes a second to download when the progress bar is turned off) retry once if nuget failed since if you cancel at just the right time, you could end up with a truncated nuget.exe and are wedged unless you know which file to delete. Learned that the hard way. -factor out calling onto powershell functions -we were not exposing whether the function failed or not

view details

React-Native-Windows Bot

commit sha 01906c323b87d50d19fb746bf411ddb683386ae9

applying package updates ***NO_CI***

view details

Julio César Rocha

commit sha 9d68988472f32739185957959e78c35c51203e49

Don't set readyState on connection error (#4562) * Don't set readyState on connection error * Change files

view details

push time in 3 months

pull request commentmicrosoft/vscode-python-devicesimulator

Fix state of switch for CPX

Just a comment, the switch is red when turned off and grey when turned on. That's fine with me, since previously it used to be red when turned on but you might want to think about it.

xnkevinnguyen

comment created time in 3 months

Pull request review commentmicrosoft/vscode-python-devicesimulator

Fix state of switch for CPX

 export const updateSwitch = (switchState: boolean): void => {     if (switchElement && switchInner) {         svg.addClass(switchInner, "sim-slide-switch-inner"); -        if (switchState) {+        if (!switchState) {             svg.addClass(switchInner, "on");             switchInner.setAttribute("transform", "translate(-5,0)");         } else {

if (condition) { doIfTrue(); } else { doIfFalse(); } is easier to understand than if (!condition) { doIfFalse(); } else { doIfTrue(); } I would swap the blocks.

xnkevinnguyen

comment created time in 3 months

Pull request review commentmicrosoft/vscode-python-devicesimulator

Fix state of switch for CPX

 def __init__(self):             (0, 0, 0),         ]         self.__state[CONSTANTS.EXPRESS_STATE.RED_LED] = False-        self.__state[CONSTANTS.EXPRESS_STATE.SWITCH] = False+        self.__state[CONSTANTS.EXPRESS_STATE.SWITCH] = True

Is the switch supposed to be on by default?

xnkevinnguyen

comment created time in 3 months

Pull request review commentmicrosoft/vscode-python-devicesimulator

Properly resolve Python path if not set

 export class SetupService {         return pythonExecutablePath;
     };
 
-    public getCurrentPythonExecutablePath = async () => {
-        let originalpythonExecutablePath = "";
-
+    public getCurrentPythonExecutablePath = async (
+        isTryingPython3: boolean = false
+    ) => {
+        let originalPythonExecutablePath = "";
+        const systemPythonVar = isTryingPython3
+            ? GLOBAL_ENV_VARS.PYTHON3
+            : GLOBAL_ENV_VARS.PYTHON;
         // try to get name from interpreter
         try {
-            originalpythonExecutablePath = getConfig(CONFIG.PYTHON_PATH);
+            originalPythonExecutablePath = getConfig(CONFIG.PYTHON_PATH);
         } catch (err) {
-            originalpythonExecutablePath = GLOBAL_ENV_VARS.PYTHON;
+            originalPythonExecutablePath = systemPythonVar;
         }

Thanks for clarifying!

andreamah

comment created time in 3 months

Pull request review commentmicrosoft/vscode-python-devicesimulator

Properly resolve Python path if not set

 export class SetupService {         return pythonExecutablePath;
     };
 
-    public getCurrentPythonExecutablePath = async () => {
-        let originalpythonExecutablePath = "";
-
+    public getCurrentPythonExecutablePath = async (
+        isTryingPython3: boolean = false
+    ) => {
+        let originalPythonExecutablePath = "";
+        const systemPythonVar = isTryingPython3
+            ? GLOBAL_ENV_VARS.PYTHON3
+            : GLOBAL_ENV_VARS.PYTHON;
         // try to get name from interpreter
         try {
-            originalpythonExecutablePath = getConfig(CONFIG.PYTHON_PATH);
+            originalPythonExecutablePath = getConfig(CONFIG.PYTHON_PATH);
         } catch (err) {
-            originalpythonExecutablePath = GLOBAL_ENV_VARS.PYTHON;
+            originalPythonExecutablePath = systemPythonVar;
         }

Honestly, I would just prompt the user to pick the interpreter in the python extension if nothing is selected and call it a day. That way you have a single source of truth, we piggyback on any improvements that the python extension might introduce in the future and we keep this method much simpler. What do you think?

andreamah

comment created time in 3 months

Pull request review commentmicrosoft/vscode-python-devicesimulator

Properly resolve Python path if not set

 export class SetupService {         return pythonExecutablePath;
     };
 
-    public getCurrentPythonExecutablePath = async () => {
+    public getCurrentPythonExecutablePath = async (
+        tryingPython3: boolean = false
+    ) => {
         let originalpythonExecutablePath = "";
-
+        const systemPythonVar = tryingPython3
+            ? GLOBAL_ENV_VARS.PYTHON3
+            : GLOBAL_ENV_VARS.PYTHON;
         // try to get name from interpreter
         try {
             originalpythonExecutablePath = getConfig(CONFIG.PYTHON_PATH);
         } catch (err) {
-            originalpythonExecutablePath = GLOBAL_ENV_VARS.PYTHON;
+            originalpythonExecutablePath = systemPythonVar;
         }
 
         if (
+            originalpythonExecutablePath === GLOBAL_ENV_VARS.PYTHON3 ||
             originalpythonExecutablePath === GLOBAL_ENV_VARS.PYTHON ||
             originalpythonExecutablePath === ""
         ) {
+            // catching any instance where the python path needs to be resolved
+            // from an system variable
             this.telemetryAI.trackFeatureUsage(
                 TelemetryEventName.SETUP_AUTO_RESOLVE_PYTHON_PATH
             );
             try {
                 const { stdout } = await this.executePythonCommand(
-                    GLOBAL_ENV_VARS.PYTHON,
+                    systemPythonVar,
                     `-c "import sys; print(sys.executable)"`
                 );
                 originalpythonExecutablePath = stdout.trim();
             } catch (err) {
                 this.telemetryAI.trackFeatureUsage(
                     TelemetryEventName.SETUP_NO_PYTHON_PATH
                 );
+                if (tryingPython3) {
+                    // if trying python3 failed, that means that BOTH
+                    // python and python3 failed as system variables
+                    // so that means that there is no python
+                    vscode.window
+                        .showErrorMessage(
+                            CONSTANTS.ERROR.NO_PYTHON_PATH,
+                            DialogResponses.INSTALL_PYTHON
+                        )
+                        .then((selection: vscode.MessageItem | undefined) => {
+                            if (selection === DialogResponses.INSTALL_PYTHON) {
+                                const okAction = () => {
+                                    this.telemetryAI.trackFeatureUsage(
+                                        TelemetryEventName.SETUP_DOWNLOAD_PYTHON
+                                    );
+                                    open(CONSTANTS.LINKS.DOWNLOAD_PYTHON);
+                                };
+                                showPrivacyModal(
+                                    okAction,
+                                    CONSTANTS.INFO.THIRD_PARTY_WEBSITE_PYTHON
+                                );
+                            }
+                        });
+                    // no python installed, cannot get path
+                    return "";
+                } else {
+                    // "python" didn't resolve to anything, trying "python3"
+                    return this.getCurrentPythonExecutablePath(true);
+                }
+            }
+            if (
+                !(await this.validatePythonVersion(
+                    originalpythonExecutablePath
+                ))
+            ) {
+                this.telemetryAI.trackFeatureUsage(
+                    TelemetryEventName.SETUP_INVALID_PYTHON_VER
+                );
+                if (tryingPython3) {
+                    // if we're trying python3, it means we already tried python and it
+                    // all doesn't seem to work, but it got this far, so it means that
+                    // their system python3 version is still not above 3.7, but they
+                    // don't have a path selected.
+                    vscode.window
+                        .showInformationMessage(
+                            CONSTANTS.ERROR.INVALID_PYTHON_PATH,
+                            DialogResponses.INSTALL_PYTHON
+                        )
+                        .then(
+                            (installChoice: vscode.MessageItem | undefined) => {
+                                if (
+                                    installChoice ===
+                                    DialogResponses.INSTALL_PYTHON
+                                ) {
+                                    const okAction = () => {
+                                        open(CONSTANTS.LINKS.DOWNLOAD_PYTHON);
+                                    };
+                                    showPrivacyModal(
+                                        okAction,
+                                        CONSTANTS.INFO
+                                            .THIRD_PARTY_WEBSITE_PYTHON
+                                    );
+                                }
+                            }
+                        );
+                    return "";
+                } else {
+                    // otherwise, we ran the "python" system variable
+                    // and we can try python3
+                    return this.getCurrentPythonExecutablePath(true);
+                }
+            }
+        } else {
+            // should only be applicable if the user defined their own path
+
+            // fix path to be absolute

*nit* I feel like this block is pretty self-documenting and that the comment can be omitted.

andreamah

comment created time in 3 months

issue closedmicrosoft/react-native-windows

Enable direct debugging through the CLI

Currently, to enable direct debugging, the app developer has to change native code and recompile their app.

This task is tracking the ability to control direct debugging through the react-native run-windows CLI. We can likely model this after https://github.com/microsoft/react-native-windows/pull/4277, which added an environment variable to control the bundler. The idea is to supply a parameter to the CLI, which turns on the environment variable, and the VS solution can use that variable to define something used in the project.

closed time in 3 months

kmelmon

Pull request review commentmicrosoft/react-native-windows

Allow enabling direct debugging through the CLI.

 using namespace Windows::ApplicationModel::Activation;  namespace winrt::Microsoft::ReactNative::implementation { -static void ApplyArguments(ReactNative::ReactNativeHost const & /*host*/, std::wstring const &arguments) noexcept {-  // Microsoft::ReactNative::implementation::ReactNativeHost* hostImpl {-  // get_self<Microsoft::ReactNative::implementation::ReactNativeHost>(host)};+static void ApplyArguments(ReactNative::ReactNativeHost const &host, std::wstring const &arguments) noexcept {+  Microsoft::ReactNative::implementation::ReactNativeHost *hostImpl{+      get_self<Microsoft::ReactNative::implementation::ReactNativeHost>(host)};   if (!arguments.empty() /*&& host.HasInstance()*/) {+    constexpr wchar_t delimiter = L' ';+    std::wistringstream argumentStream(arguments);+    std::wstring token;+    while (std::getline(argumentStream, token, delimiter)) {+      if (token == L"-?") {+        std::cout << "Options:" << std::endl+                  << "  directDebugging <port>    Enable direct debugging on specified port." << std::endl;

Thanks for your input. Sounds good, changed all options to be consistent.

nasadigital

comment created time in 3 months

push eventnasadigital/react-native-windows

David Serafimov

commit sha cb8b7c77a25b99dc6ea22ec5b371194f30e9054e

Address PR feedback.

view details

push time in 3 months

Pull request review commentmicrosoft/react-native-windows

Allow enabling direct debugging through the CLI.

 using namespace Windows::ApplicationModel::Activation;  namespace winrt::Microsoft::ReactNative::implementation { -static void ApplyArguments(ReactNative::ReactNativeHost const & /*host*/, std::wstring const &arguments) noexcept {-  // Microsoft::ReactNative::implementation::ReactNativeHost* hostImpl {-  // get_self<Microsoft::ReactNative::implementation::ReactNativeHost>(host)};+static void ApplyArguments(ReactNative::ReactNativeHost const &host, std::wstring const &arguments) noexcept {+  Microsoft::ReactNative::implementation::ReactNativeHost *hostImpl{+      get_self<Microsoft::ReactNative::implementation::ReactNativeHost>(host)};   if (!arguments.empty() /*&& host.HasInstance()*/) {+    constexpr wchar_t delimiter = L',';+    std::wistringstream argumentStream(arguments);+    std::wstring token;+    while (std::getline(argumentStream, token, delimiter)) {+      if (token == L"-?") {+        std::cout << "Options:\n"+                     "  directDebugging,<port>    Enable direct debugging on specified port.\n";+        std::cout.flush();+      } else if (token == L"directDebugging") {

My bad. The options starting with -- are options for the react native windows CLI, while this option (directDebugging) is for any app built with react native for windows (using Microsoft.ReactNative). I saw another option remoteDebugging passed to the app in the deploy/start powershell script so I went with camel case for the new option. It seems that that remoteDebugging is not being used anymore, so it might be safe to remove? Either way, I'm not sure what's the best way to proceed. Perhaps make it consistent across the CLI and the apps? What do you suggest?

nasadigital

comment created time in 3 months

pull request commentmicrosoft/vscode-python-devicesimulator

IMPORTANT: Hotfix for users without Git

@andreamah How can I build a .vsix to try if it fixes the issue?

andreamah

comment created time in 3 months

Pull request review commentmicrosoft/react-native-windows

Allow enabling direct debugging through the CLI.

 using namespace Windows::ApplicationModel::Activation;  namespace winrt::Microsoft::ReactNative::implementation { -static void ApplyArguments(ReactNative::ReactNativeHost const & /*host*/, std::wstring const &arguments) noexcept {-  // Microsoft::ReactNative::implementation::ReactNativeHost* hostImpl {-  // get_self<Microsoft::ReactNative::implementation::ReactNativeHost>(host)};+static void ApplyArguments(ReactNative::ReactNativeHost const &host, std::wstring const &arguments) noexcept {+  Microsoft::ReactNative::implementation::ReactNativeHost *hostImpl{+      get_self<Microsoft::ReactNative::implementation::ReactNativeHost>(host)};   if (!arguments.empty() /*&& host.HasInstance()*/) {+    constexpr wchar_t delimiter = L',';

I agree. I changed WindowsStoreAppUtils.ps1 to use whitespace when starting the app.

nasadigital

comment created time in 3 months

push eventnasadigital/react-native-windows

David Serafimov

commit sha f48cb5baa53a18115c4f776a5651f2950b540353

Change delimiter back to whitespace.

view details

push time in 3 months

issue closedmicrosoft/react-native-windows

Add DebuggerPort to ReactInstanceSettings

For CLI generated apps, direct debugging doesn't work because there is no DebuggerPort property, which is needed to tell the core what port to open a WebSocket on.

From Anandraj: "Developer configures the JSI runtime to additionally spawn a debugger (websocket) server listening for Chrome debug protocol messages at a specific port. The debugger server directly talks to the Javascript engine using engine specific debugger APIs"

closed time in 3 months

kmelmon

issue commentmicrosoft/react-native-windows

Add DebuggerPort to ReactInstanceSettings

I will go ahead and close the issue, as the PR has been merged.

kmelmon

comment created time in 3 months

Pull request review commentmicrosoft/react-native-windows

Allow enabling direct debugging through the CLI.

 using namespace Windows::ApplicationModel::Activation;  namespace winrt::Microsoft::ReactNative::implementation { -static void ApplyArguments(ReactNative::ReactNativeHost const & /*host*/, std::wstring const &arguments) noexcept {-  // Microsoft::ReactNative::implementation::ReactNativeHost* hostImpl {-  // get_self<Microsoft::ReactNative::implementation::ReactNativeHost>(host)};+static void ApplyArguments(ReactNative::ReactNativeHost const &host, std::wstring const &arguments) noexcept {+  Microsoft::ReactNative::implementation::ReactNativeHost *hostImpl{+      get_self<Microsoft::ReactNative::implementation::ReactNativeHost>(host)};   if (!arguments.empty() /*&& host.HasInstance()*/) {+    std::wistringstream argumentStream(arguments);+    std::wstring token;+    while (std::getline(argumentStream, token, L' ')) {+      if (token == L"directDebugging" && std::getline(argumentStream, token, L' ')) {+        wchar_t *nextPosition = nullptr;

I updated the PR. Did you have something like this in mind?

nasadigital

comment created time in 3 months

Pull request review commentmicrosoft/react-native-windows

Allow enabling direct debugging through the CLI.

 using namespace Windows::ApplicationModel::Activation;  namespace winrt::Microsoft::ReactNative::implementation { -static void ApplyArguments(ReactNative::ReactNativeHost const & /*host*/, std::wstring const &arguments) noexcept {-  // Microsoft::ReactNative::implementation::ReactNativeHost* hostImpl {-  // get_self<Microsoft::ReactNative::implementation::ReactNativeHost>(host)};+static void ApplyArguments(ReactNative::ReactNativeHost const &host, std::wstring const &arguments) noexcept {+  Microsoft::ReactNative::implementation::ReactNativeHost *hostImpl{+      get_self<Microsoft::ReactNative::implementation::ReactNativeHost>(host)};   if (!arguments.empty() /*&& host.HasInstance()*/) {+    std::wistringstream argumentStream(arguments);+    std::wstring token;+    while (std::getline(argumentStream, token, L' ')) {+      if (token == L"directDebugging" && std::getline(argumentStream, token, L' ')) {+        wchar_t *nextPosition = nullptr;+        const uint16_t port = static_cast<uint16_t>(std::wcstol(token.c_str(), &nextPosition, 10));+        if (nextPosition == nullptr) {+          hostImpl->InstanceSettings().UseWebDebugger(false);

My bad, I misunderstood the parameter. Thanks for catching this!

nasadigital

comment created time in 3 months

push eventnasadigital/react-native-windows

David Serafimov

commit sha 7f5dec3468a05b7723da795cb06afdedc1e0488a

Addres PR feedback.

view details

David Serafimov

commit sha 9da0d64e89fff748f9d169e3376d6c96b8bbcbe6

Use same delimiter as when running through the react native CLI.

view details

push time in 3 months

issue commentmicrosoft/react-native-windows

Implement Direct Debugging

@mganandraj and @nasadigital , where are we in this? We have a direct debugging experience in place, and I want to make sure we're tracking the right concrete next steps. Do we think tracking them via this issue is appropriate? Or can we move on to more scoped individual issues?

Thanks for reaching out! My understanding is that there is support, but some work needs to be done on reliability and streamlining the developer experience. I am not sure, so I would need to double check and break down the work in tasks. For tracking progress, I am not very familiar with what are best practices for github. Perhaps if I updated this project it would do the job? What do you think?

kmelmon

comment created time in 3 months

Pull request review commentmicrosoft/react-native-windows

Allow enabling direct debugging through the CLI.

 App::App() noexcept {   InstanceSettings().EnableDeveloperMenu(false); #endif +#if USE_DIRECT_DEBUGGING+  InstanceSettings().UseWebDebugger(false);+  InstanceSettings().UseDirectDebugger(true);+  InstanceSettings().DebuggerBreakOnNextLine(true);+  InstanceSettings().DebuggerPort(9229);

Thank you for the feedback @acoates-ms @asklar @kmelmon. I replaced the defines with command line arguments. To my understanding with the new approach:

  • You can toggle between direct debugging and web debugging without rebuilding.
  • Is compatible with existing projects (is not app specific).
  • You can also specify the port (C# defines can't be assigned values, so previous approach didn't allow that). Unfortunately there still isn't an equivalent option in the android and iOS CLI. Let me know if you have any concerns.
nasadigital

comment created time in 3 months

push eventnasadigital/react-native-windows

David Serafimov

commit sha 557f5dd06da04aa9ea1a0e6c35a2a09aaf93f3e0

Enable direct debugging through command line arguments instead of defines.

view details

push time in 3 months

pull request commentmicrosoft/vscode-python-devicesimulator

Bug Fix for different values of Pressure on Python and React-side

Maybe store them all in a JSON document and load them from that or something to that degree?

Sounds like a good approach to me. Perhaps someone in the future will be able to work on that.

vandyliu

comment created time in 3 months

Pull request review commentmicrosoft/react-native-windows

Allow enabling direct debugging through the CLI.

 App::App() noexcept {   InstanceSettings().EnableDeveloperMenu(false); #endif +#if USE_DIRECT_DEBUGGING+  InstanceSettings().UseWebDebugger(false);+  InstanceSettings().UseDirectDebugger(true);+  InstanceSettings().DebuggerBreakOnNextLine(true);+  InstanceSettings().DebuggerPort(9229);

How do we feel about adding a new template where the debug builds use direct debugging instead of web debugging?

nasadigital

comment created time in 3 months

more