profile
viewpoint
Will Vaughn nackjicholson Carbon Lighthouse San Francisco, CA willvaughn.org I have moved a lot of my personal projects to https://gitlab.com/willvaughn I work to stop climate change at Carbon Lighthouse. Reach out!

nackjicholson/aiosql 791

Simple SQL in Python

honza/anosql 197

Easy SQL in Python

nackjicholson/haskellbook-solutions 18

My (incomplete && ugly) notes and solutions to haskellbook

nackjicholson/generator-backbone-module 8

Yeoman generator for creating distributable backbone modules

nackjicholson/generator-react-hapi-universal 7

Scaffold a Universal JavaScript App using React and hapi

nackjicholson/comtrade-coffee 5

Sample usage of the comtrade UN database API

nackjicholson/ergast-python 5

Python HTTP client to the Ergast Motor Racing Data API

nackjicholson/checkbox-group 3

React Checkbox Group Component

nackjicholson/file-parser 3

PHP composer package for parsing data contained in a file into a php array.

nackjicholson/generator-hapi-es2015 3

Scaffold a hapijs micro service

issue commentnackjicholson/aiosql

Could I drop support for python 3.6?

@dlax I see, thanks for that!

I think I need to think about this a little more. There's some other api changes I want to play with for a version 4, chiefly around changing record_class to something that can both marshal data in, as well as out. With that major bump it seems I'll also need to make a decision on the manner in which to support py3.6. What you did there still demands a major version bump because it takes away async drivers for people on 3.6. it makes me think maybe the hack I did for the async context manager isn't the worst thing I could've done, it lets me support 3.6 fully. I wonder if there's a more "official" backport of it available on pypi or something. Its not ideal to support two different sets of functionality for different versions of python, that seems like it could cause people confusion about the library and be troublesome to debug and develop around for us.

Here's the options I'm seeing now for py3.6:

  1. Drop it entirely from a version 4, point people back to a pretty mature final version of version 3 if they really need to be on version 3.6.
  2. Support py3.6 but only for sync drivers, take your changes in #48
  3. Fully support py3.6 for all drivers, keep the hack, or find a better one.

Thanks for the discussion! Let me know what you think about all that.

nackjicholson

comment created time in an hour

issue commentnackjicholson/aiosql

Could I drop support for python 3.6?

@dlax I'd be interested in doing that. How do I do that? :D

nackjicholson

comment created time in 13 hours

PR closed nackjicholson/aiosql

DB wrapper

It is convenient to mix queries and a connection. The DB class does that.

+376 -0

4 comments

5 changed files

zx80

pr closed time in 13 hours

pull request commentnackjicholson/aiosql

DB wrapper

@zx80 Thank you again for contributing this. I hope others will find it useful.

I have decided not to pull this into the project though. It doesn't support both normal and asyncio driver types and ultimately I think that makes it non-essential to support. I would encourage you to break this out into your own repo and publish it to pypi (if you don't I might). Let me know if you do and I'll link to it from the README and/or docs.

Cheers!

zx80

comment created time in 13 hours

PullRequestEvent

PR closed nackjicholson/aiosql

Another Python SQLite Wrapper (APSW) support

Another Python SQLite Wrapper (APSW) is an alternative to the built-in sqlite3 module. As well as more closely following SQLite's C API, APSW allows the use of newer SQLite versions than the system version. This can be a major boon on LTS Linux distributions.

The API is similar enough that I could quickly implement an adapter by tweaking the one for sqlite3.

The only real challenge was that cursor descriptions are only available during query execution, unlike in the sqlite3 module where they are available afterwards. I resolved this with the _record_generator function, but perhaps there is a better way.

I added a test case for select_one with a record_class, because that branch did not seem to be covered. It's currently defined in users_apsw.sql, but perhaps it should be promoted all-adapter suite.

There is one potential blocker: APSW is not easily installed using poetry. APSW is not available through PyPI. There is an apsw package on PyPI, but it should not be used. It is not controlled by the author of APSW and is several years out of date.

It is possible to install APSW using pip, and the relevant options can be specified in a requirements.txt file, but this is not yet possible using poetry / pyproject.toml. See python-poetry/poetry#845 for details.

I was able to install APSW for testing by running the command from the APSW documentation, minus --user, through poetry run:

poetry run pip install https://github.com/rogerbinns/apsw/releases/download/3.32.2-r1/apsw-3.32.2-r1.zip \
--global-option=fetch --global-option=--version --global-option=3.32.2 --global-option=--all \
--global-option=build --global-option=--enable-all-extensions

I'm interested to hear whether you find this to be an acceptable workaround.

+300 -5

2 comments

7 changed files

iamthad

pr closed time in 13 hours

pull request commentnackjicholson/aiosql

Another Python SQLite Wrapper (APSW) support

@iamthad Thanks again for this contribution. I'm not going to pull this into the project because I already have the normal sqlite3 driver. I will leave it open for people to discover and use as a reference for making driver adapters.

If you make this into a project of your own , say aiosql-apsw or whatever you would like to call it, let me know and I can link to it from the README and/or docs.

iamthad

comment created time in 13 hours

push eventnackjicholson/aiosql

Deployment Bot (from Travis CI)

commit sha 549dcc7f57a998b88d9c2a7e473e6f5509c01c9f

Deploy nackjicholson/aiosql to github.com/nackjicholson/aiosql.git:gh-pages

view details

push time in 13 hours

created tagnackjicholson/aiosql

tag3.2.0

Simple SQL in Python

created time in 13 hours

release nackjicholson/aiosql

3.2.0

released time in 13 hours

push eventnackjicholson/aiosql

Will Vaughn

commit sha 51a89a8e74b153872dacd67f0cb08305a20cd8bb

poetry version minor

view details

push time in 13 hours

push eventnackjicholson/aiosql

Deployment Bot (from Travis CI)

commit sha 6dc49ee1c0d25b3b379d6f848e1e049bb4f03cec

Deploy nackjicholson/aiosql to github.com/nackjicholson/aiosql.git:gh-pages

view details

push time in 13 hours

issue closednackjicholson/aiosql

Allow comments in SQL files

It is really convenient to allow misc SQL comments in the SQL file loaded. With something like:

    -- SQL queries...

    -- name: one
    SELECT 1;

I got aiosql.exceptions.SQLParseException: name must convert to valid python variable, got "__ SQL queries".

closed time in 13 hours

zx80

issue commentnackjicholson/aiosql

Allow comments in SQL files

https://github.com/nackjicholson/aiosql/commit/9c3cc26449fdfc4a8a4aec2f98a131d953ef75ee Addressed! @zx80

zx80

comment created time in 13 hours

push eventnackjicholson/aiosql

Will Vaughn

commit sha 9c3cc26449fdfc4a8a4aec2f98a131d953ef75ee

allow SQL header comments at top of files

view details

push time in 13 hours

push eventnackjicholson/aiosql

Deployment Bot (from Travis CI)

commit sha 216fc080f959d164d7bcc8a25e2a34e3b177eff4

Deploy nackjicholson/aiosql to github.com/nackjicholson/aiosql.git:gh-pages

view details

push time in 13 hours

push eventnackjicholson/aiosql

Denis Laxalde

commit sha f449f172800773e748168f55fa96793113961169

Factor out a _make_ctx_mgr() helper This is similar to _make_sync_fn() and _make_async_fn() and will help in the next commit.

view details

Denis Laxalde

commit sha 8e53c68c79485eb5d8b054c45f6a792134e984d6

Re-use the _params() helper in ctx_mgr()

view details

Denis Laxalde

commit sha a15218959933b0d3ccbfa21c1d11a421234bef5d

Introduce a QueryFn protocol This is to avoid the '# type: ignore' on the sql attribute set to queries' functions. We then declare _make_sync_fn() and _make_async_fn() to return this type value. In order to avoid a mypy error when setting the 'sql' attribute to the (plain) 'fn' function, we cast this value to a QueryFn. We also add a _query_fn() helper function for the wrapping logic.

view details

Will Vaughn

commit sha ee3e5895b67342ef5aeb028a0034b3d25684da02

Merge pull request #45 from dlax/queryfn introduce a QueryFn protocol

view details

push time in 14 hours

PR merged nackjicholson/aiosql

introduce a QueryFn protocol

We add a QueryFn protocol type definition in types module that is used to annotate queries functions more accurately. This already resolves a couple of '# type: ignore' in queries and will help with further improvements on typing.

(I suggest reading individual commits to review.)

+31 -22

0 comment

2 changed files

dlax

pr closed time in 14 hours

Pull request review commentnackjicholson/aiosql

introduce a QueryFn protocol

 class QueryDatum(NamedTuple):     record_class: Any = None  +class QueryFn(Protocol):

Awesome!

dlax

comment created time in 14 hours

Pull request review commentnackjicholson/aiosql

introduce a QueryFn protocol

 def fn(self: Queries, conn, *args, **kwargs):     else:         raise ValueError(f"Unknown operation_type: {operation_type}") -    fn.__name__ = query_name-    fn.__doc__ = doc_comments-    fn.sql = sql  # type: ignore+    return _query_fn(fn, query_name, doc_comments, sql) -    return fn --def _make_async_fn(fn: Callable):+def _make_async_fn(fn: QueryFn) -> QueryFn:     async def afn(self: Queries, conn, *args, **kwargs):         return await fn(self, conn, *args, **kwargs) -    afn.__name__ = fn.__name__-    afn.__doc__ = fn.__doc__-    afn.sql = fn.sql  # type: ignore+    return _query_fn(afn, fn.__name__, fn.__doc__, fn.sql)

Lovely reuse. :+1:

dlax

comment created time in 14 hours

Pull request review commentnackjicholson/aiosql

introduce a QueryFn protocol

 def fn(self: Queries, conn, *args, **kwargs):     else:         raise ValueError(f"Unknown operation_type: {operation_type}") -    fn.__name__ = query_name-    fn.__doc__ = doc_comments-    fn.sql = sql  # type: ignore+    return _query_fn(fn, query_name, doc_comments, sql) -    return fn --def _make_async_fn(fn: Callable):+def _make_async_fn(fn: QueryFn) -> QueryFn:     async def afn(self: Queries, conn, *args, **kwargs):         return await fn(self, conn, *args, **kwargs) -    afn.__name__ = fn.__name__-    afn.__doc__ = fn.__doc__-    afn.sql = fn.sql  # type: ignore+    return _query_fn(afn, fn.__name__, fn.__doc__, fn.sql)+ -    return afn+def _make_ctx_mgr(fn: QueryFn) -> QueryFn:+    def ctx_mgr(self, conn, *args, **kwargs):+        return self.driver_adapter.select_cursor(conn, fn.__name__, fn.sql, _params(args, kwargs))

Beautiful, thanks for catching that this _params helper wasn't being used here.

dlax

comment created time in 14 hours

PullRequestReviewEvent
PullRequestReviewEvent

push eventnackjicholson/aiosql

Deployment Bot (from Travis CI)

commit sha 0d774663f79b5ebfb75d11fb838e07f132d645e1

Deploy nackjicholson/aiosql to github.com/nackjicholson/aiosql.git:gh-pages

view details

push time in 14 hours

delete branch nackjicholson/aiosql

delete branch : select-value-op

delete time in 14 hours

push eventnackjicholson/aiosql

Will Vaughn

commit sha 9160b24003c39b4ca076059dddf98933688f419a

implement select_value method feature

view details

Will Vaughn

commit sha b9ec4615b0bd908c544568bb9c4cca08034c1b4f

add doc for select_value

view details

Will Vaughn

commit sha b6f9b5b7b15c4277c691a0fafa18df2d140701d8

Merge pull request #47 from nackjicholson/select-value-op add select_value operation

view details

push time in 14 hours

PR merged nackjicholson/aiosql

add select_value operation

Pickup the work on #22 that addresses issue #11

+96 -0

0 comment

13 changed files

nackjicholson

pr closed time in 14 hours

issue closednackjicholson/aiosql

Add support for 'fetchval' to return a single value.

Asyncpg has a fetchval method that can be used to return a column from a single row. This is useful for queries such as getting the count.

e.g.

-- name: count_rows^
SELECT COUNT(*) FROM rows WHERE param = :value

requires the one of the python calls to get the value

count, = queries.count_rows(value=1)
count = queries.count_rows(value=1)[0]

Whereas, if a notation for fetchval was supported only the following would be required:

count = queries.count_rows(value=1)

closed time in 14 hours

xlevus

issue commentnackjicholson/aiosql

Add support for 'fetchval' to return a single value.

Completed in the PR linked above.

xlevus

comment created time in 14 hours

PR closed nackjicholson/aiosql

SELECT_VALUE operation support

As requested in #11 and also missed by myself I started implementing support for queries returning only a single value. Up for discussion:

  • Is $ as a operation type prefix fine. Any other preferences?
  • Is the implementation I provided for the AioSQLiteAdapter method select_value the right way to go forward?

I'll extend this pull request with implementations for the other adapters as soon as I get feedback no my questions.

+108 -1

5 comments

13 changed files

wagnerflo

pr closed time in 14 hours

pull request commentnackjicholson/aiosql

SELECT_VALUE operation support

@wagnerflo Thank you for your efforts. I picked this up in the PR back-linked above.

wagnerflo

comment created time in 14 hours

push eventnackjicholson/aiosql

Will Vaughn

commit sha 9160b24003c39b4ca076059dddf98933688f419a

implement select_value method feature

view details

Will Vaughn

commit sha b9ec4615b0bd908c544568bb9c4cca08034c1b4f

add doc for select_value

view details

push time in 14 hours

PR opened nackjicholson/aiosql

add select_value operation

Pickup the work on #22 that addresses issue #11

+97 -0

0 comment

13 changed files

pr created time in 14 hours

push eventnackjicholson/aiosql

Will Vaughn

commit sha 29702fde67c6b28d874dd6e75d367aac14eeb74a

implement select_value method feature

view details

Will Vaughn

commit sha 6990ed72693f54623aea0e272b7d7dbca61e7a86

add doc for select_value

view details

push time in 14 hours

create barnchnackjicholson/aiosql

branch : select-value-op

created branch time in 14 hours

push eventnackjicholson/aiosql

Deployment Bot (from Travis CI)

commit sha 49a393dcad3a41a21a109f66476adb48e14415d4

Deploy nackjicholson/aiosql to github.com/nackjicholson/aiosql.git:gh-pages

view details

push time in 15 hours

PR closed nackjicholson/aiosql

Returns from a simple execute on asyncpg driver

seems to fix https://github.com/nackjicholson/aiosql/issues/8 happy to add some tests should you think it's necessary

+2 -1

3 comments

1 changed file

euri10

pr closed time in 15 hours

issue closednackjicholson/aiosql

asyncpg execute return is not passed

greetings, amazing library I'm discovering so bear with me maybe I'm misusing it.

should I use asyncpg directly this way, the response will be CREATE DATABASE

dbpool = await get_db_pool(database_subscriber_dsn)
# response = await create_queries.create_db_test(dbpool)
response = await dbpool.execute("create database postgres_test;")

now should I try it with aiosql with the following sql file it returns None

-- name: create_db_test#
create database postgres_test;

happy to send a little PR

closed time in 15 hours

euri10

issue commentnackjicholson/aiosql

asyncpg execute return is not passed

It does not have an analog for sqlite drivers unfortunately. But I am just returning a string "DONE" for those drivers. This is done @euri10

euri10

comment created time in 15 hours

delete branch nackjicholson/aiosql

delete branch : execute-script-returns

delete time in 15 hours

push eventnackjicholson/aiosql

Will Vaughn

commit sha 7c3fa4326511e12633ab6df2963a1bcaccf114f2

sqlite3 execute script with return

view details

Will Vaughn

commit sha d4b328695281a9d0b6c7c0cfb70a8978cda3b3fa

psycopg2 execute_script with return

view details

Will Vaughn

commit sha c523cc1546f14b886618e6003dbe5fc1400f4f28

asyncpg execute_script with return

view details

Will Vaughn

commit sha daa65108a48b12f80f007613eb0d844a33426d26

aiosqlite execute_script with return

view details

Will Vaughn

commit sha 4f9427baf0430ce3ef198541b43aa217417fb832

fix execute_script driver adapter type signature

view details

Will Vaughn

commit sha 3b883d5de1816033c801fa69bfcb8e02bb2241e4

Merge pull request #46 from nackjicholson/execute-script-returns execute_script method returns string status message

view details

push time in 15 hours

PR merged nackjicholson/aiosql

execute_script method returns string status message

Complete the work from #9 to address issue #8

+47 -5

0 comment

11 changed files

nackjicholson

pr closed time in 15 hours

PR opened nackjicholson/aiosql

execute_script method returns string status message

Complete the work from #9 to address issue #8

+47 -5

0 comment

11 changed files

pr created time in 15 hours

create barnchnackjicholson/aiosql

branch : execute-script-returns

created branch time in 15 hours

issue commentnackjicholson/aiosql

How to connect to MySQL or MariaDB?

You need to create a driver adapter for pymysql. https://nackjicholson.github.io/aiosql/database-driver-adapters/

This question has come up before. #24 I encourage anyone who needs this to create a driver adapter and opensource it. If it were a project called aiosql-mysql I would certainly link to it from the README here.

If someone wants to figure out how to do asyncio and sync adapters for MySQL I would consider adding it to this project as officially supported.

Same goes for MariaDB using the underlying https://github.com/mariadb-corporation/mariadb-connector-python driver.

gudata

comment created time in a day

release nackjicholson/aiosql

3.1.3

released time in a day

push eventnackjicholson/aiosql

Deployment Bot (from Travis CI)

commit sha 973c01c8699697f57987e0aab9987c3fdd799865

Deploy nackjicholson/aiosql to github.com/nackjicholson/aiosql.git:gh-pages

view details

push time in a day

created tagnackjicholson/aiosql

tag3.1.3

Simple SQL in Python

created time in a day

push eventnackjicholson/aiosql

Will Vaughn

commit sha 0d03bbfc73383f54977edd542438872e74ab9bb9

patch version

view details

push time in a day

issue commentnackjicholson/aiosql

Could I drop support for python 3.6?

@dlax Thank you that's a very good point. I recently used python on Centos 8 with python 3.6. It is something to consider. I think @alecbrooks made a point that makes me feel like we're not leaving users of python 3.6 without an option. The lib still supports 3.6 on this current major version. I think I'd like to shore up some loose ends, make this version as mature as possible and then make a major version bump that drops 3.6.

I'm still not decided on if I'm going to do it or not. Just thoughts.

nackjicholson

comment created time in 3 days

push eventnackjicholson/aiosql

Deployment Bot (from Travis CI)

commit sha d03f6d79eb04fcdf5d0eac5e26c4c47010105cdb

Deploy nackjicholson/aiosql to github.com/nackjicholson/aiosql.git:gh-pages

view details

push time in 4 days

pull request commentnackjicholson/aiosql

fix license in pyproject.toml

@dlax Thank you!

dlax

comment created time in 4 days

push eventnackjicholson/aiosql

Denis Laxalde

commit sha 64ed3472b52335e7eee8a5680b068c5143533612

fix license in pyproject.toml Running 'poetry check' yields: Error: FreeBSD is not a valid license The actual license code is BSD-2-Clause (https://python-poetry.org/docs/pyproject/#license).

view details

Will Vaughn

commit sha 859f71e8795b6df2ef9a1566f36eac69e90a2e4d

Merge pull request #43 from dlax/license fix license in pyproject.toml

view details

push time in 4 days

PR merged nackjicholson/aiosql

fix license in pyproject.toml

Running poetry check yields:

Error: FreeBSD is not a valid license

The actual license code is BSD-2-Clause (https://python-poetry.org/docs/pyproject/#license).

+1 -1

0 comment

1 changed file

dlax

pr closed time in 4 days

PullRequestReviewEvent

push eventnackjicholson/aiosql

Deployment Bot (from Travis CI)

commit sha ca3a183c22d42d548e0c0f66fe21f93d9077a095

Deploy nackjicholson/aiosql to github.com/nackjicholson/aiosql.git:gh-pages

view details

push time in 5 days

PR closed nackjicholson/aiosql

Making aiosql pandas aware

This pull request aims to allow for queries to be returned as a pandas.DataFrame when a DataFrame is presented as the record_class.

Why?

Unless a record_class is provided for the SQL query, there is no way to retrieve the column names after executing the query. Furthermore, even to define a record_class, one needs to know in advance the names of all the fields one expects to save.

With a DataFrame, this would be solved as columns would automatically be given the name of the corresponding SQL output field.

How?

To keep the current API behavior and not break backwards compatibility, the DataFrame should be provided simply as record_classes={"DataFrame": pd.DataFrame} during query loading.

Steps

  • [x] Unify the behavior when assigning a record_class into an assign_record_class function.
  • [x] Test if the record_class is DataFrame inside a try/except ImportError to not make pandas a mandatory dependency (if the user doesn't have it he/she will be unable to provide a DataFrame as input anyways).
  • [x] Add tests.
  • [ ] Add a note in documentation highlighting the feature.
+518 -65

3 comments

12 changed files

jaumebonet

pr closed time in 5 days

pull request commentnackjicholson/aiosql

Making aiosql pandas aware

I am going to close this. I would like to make an advancement in the API of aiosql which would make it easier for you to marshal to and from whatever data types you like. Thanks for pursuing this code and for surfacing the idea. Cheers!

jaumebonet

comment created time in 5 days

push eventnackjicholson/aiosql

Denis Laxalde

commit sha f34e2d66086cf734ba867fca55ee37f4e8465bdf

fix type of record_class argument in drivers protocol = instead of :

view details

Will Vaughn

commit sha a1327f12751fa70e18d6aac1f73d40b4a7666f54

Merge pull request #42 from dlax/fix-type fix type of record_class argument in drivers protocol

view details

push time in 5 days

PR merged nackjicholson/aiosql

fix type of record_class argument in drivers protocol

= instead of :

+4 -4

1 comment

1 changed file

dlax

pr closed time in 5 days

PullRequestReviewEvent

issue commentnackjicholson/aiosql

Difference between aiosql and anosql?

@anthonydb aiosql is a fork of anosql. I kept them very similar for a long time. In short aiosql is usable with asyncio based database drivers. And aiosql is only usable on python versions >= 3.6.

anthonydb

comment created time in 12 days

startedhlissner/doom-emacs

started time in 12 days

issue commenthlissner/doom-emacs

+notmuch/update () does not close window after finish

I pulled that approach over her into a PR, back-linked above.

sonnius

comment created time in 13 days

Pull request review commenthlissner/doom-emacs

Notmuch module remove `*notmuch-hello*` buffer customizations + add some documentation

  ;; FIXME This module is a WIP!

I'm trying!

nackjicholson

comment created time in 13 days

PullRequestReviewEvent

PR opened hlissner/doom-emacs

Notmuch -- make +afew feature and fix +notmuch/update buffer kill

Addressing #3188

Using compile approach similar to doom sync. It runs in a buffer and deletes the buffer when complete.

afew is and should be optional. Putting it behind a feature flag so that if you don't have afew install, it won't be run. It's easily available for those that want it, and easy to ignore for everyone else.

added documentation.

+54 -25

0 comment

3 changed files

pr created time in 15 days

create barnchnackjicholson/doom-emacs

branch : notmuch-develop

created branch time in 15 days

push eventnackjicholson/doom-emacs

William Vaughn

commit sha 8b8f4978154a813d08a556972a8d11fc2c78cd66

make +afew feature, fix +notmuch/update buf kill Using `compile` approach similar to `doom sync`. It runs in a buffer and deletes the buffer when complete. `afew` is and should be optional. Putting it behind a feature flag so that if you don't have afew install, it won't be run. It's easily available for those that want it, and easy to ignore for everyone else. added documentation.

view details

push time in 15 days

push eventnackjicholson/doom-emacs

Will Vaughn

commit sha 68d8f713d356dbf57c207db601d50fd6a85b8eb8

change name back to update, fix copy paste error

view details

push time in 15 days

create barnchnackjicholson/doom-emacs

branch : notmuch-sync

created branch time in 15 days

push eventnackjicholson/doom-emacs

Henrik Lissner

commit sha ce9162647d528bfa05f04366b184383691f46cd6

cli/env: blacklist SHLVL & comment default blacklist

view details

Henrik Lissner

commit sha 1456108d5bef89195b2b63f962e0ae9d24f4c652

Fix #3888: fall back to org-journal-is-journal Closes #3925

view details

push time in 15 days

PR opened hlissner/doom-emacs

Notmuch module remove `*notmuch-hello*` buffer customizations + add some documentation

@hlissner I would like to progress development of this module if no one else has interest. It seems to have been in a WIP state for a while.

What I did here is remove some forced aesthetic customizations that the doom module currently imposes. I think these customizations are extremely easy to achieve via user config and I provided documentation to do so. As a user of notmuch with vanilla emacs I've grown very used to landing on the normal notmuch-hello buffer and I think that should be the default when using notmuch in doom as well.

I think I've struck a decent balance here of having unsurprising defaults, but also improved customizability for those that want it. Please consider this PR for merge.

+59 -11

0 comment

3 changed files

pr created time in 15 days

push eventnackjicholson/doom-emacs

Henrik Lissner

commit sha ce9162647d528bfa05f04366b184383691f46cd6

cli/env: blacklist SHLVL & comment default blacklist

view details

Henrik Lissner

commit sha 1456108d5bef89195b2b63f962e0ae9d24f4c652

Fix #3888: fall back to org-journal-is-journal Closes #3925

view details

William Vaughn

commit sha ec80e49b9fde9d7646099597dde5373b41ffcf13

rm notmuch-hello customization Seeking to make this notmuch module behave more like vanilla notmuch to be less disorienting for users who are familiar with notmuch. The customizations of the notmuch-hello screen can easily be done in user configs by users that want those customizations.

view details

William Vaughn

commit sha 8803ccbb3e96b89c0e9856cd2abfaa36ebcdc867

change +notmuch/update -> +notmuch/sync Using `gmi sync` instead of push/pull Made `afew` something behind a feature flag because it is not essential for running and using notmuch, this makes it easily available for those that want it and easy to ignore for those that do not.

view details

Will Vaughn

commit sha ab9c0a3acb4ffc3152b92297203138ce1bc9ce9d

Update notmuch documentation

view details

push time in 15 days

create barnchnackjicholson/doom-emacs

branch : rm-notmuch-hello-customizations

created branch time in 15 days

delete branch nackjicholson/lieer

delete branch : patch-1

delete time in 15 days

issue commentnackjicholson/aiosql

Could I drop support for python 3.6?

@alecbrooks Thanks for letting me know about these things. Also, thank you for weighing in with an opinion!

nackjicholson

comment created time in 15 days

CommitCommentEvent

startedgoogle/digitalbuildings

started time in 19 days

push eventnackjicholson/doom-emacs

Gabriele Bozzola

commit sha 7877c928094a4f7a73c870fd68900b3e7a7de766

Docs: Fix typo: vterm-module.sh -> vterm-module.so

view details

t-e-r-m

commit sha 0ef8f0031fc6ded2e87027d80bf279d418df78f8

configure dired-aux variables `dired-create-destination-dirs` : set to "ask", non-existent directories will be created when copying, if the user consents. `dired-vc-rename-file` : rename file using the vc system, if present

view details

t-e-r-m

commit sha 1dd796b1809b161435f556e64496270414dd911f

Added :defer to dired-aux use-package!

view details

Henrik Lissner

commit sha 406c651059c8b99fab305bb29a24d04f84650e67

Increase search depth for doom/help-search-headings

view details

Henrik Lissner

commit sha aa06309067eeec46aecc387761f9ccecb434323e

lang/markdown: fontify rust blocks correctly

view details

Henrik Lissner

commit sha 5f47169c0efd54f0a903879976af48fe59e30e1c

Load ccls.el after lsp-mode lsp-mode is the package's entry point now, not lsp.

view details

Henrik Lissner

commit sha 60ba42ca4aa04145637f9c1c28b16da2f2f513b0

Fix #3873: use thing-at-point for nox & elpy

view details

Henrik Lissner

commit sha 79c1fcefcf2b135deacb743dc5d2badeb67db09c

Fix #3863: "load" ispell after flyspell Emacs loads both ispell and flyspell at startup, so to lazy load user configuration to either package, we fool Emacs into thinking neither is loaded yet. However, this means we need a trigger to eventually "load" ispell, which we didn't have until now, causing #3863.

view details

Henrik Lissner

commit sha 3935d431fc4077cb0fd62cd948dc25020cbd3dc8

tab-always-indent = nil Seems like a more sensible default to reindent the line if cursor is at BOL or in indentation, then insert literal indentation (tab or space * tab-width) otherwise.

view details

Henrik Lissner

commit sha 8024f4edf918a1c909ff5edc4f35b8f7f7dbff4e

Fix #3215 (again): --path-separator / Use a single slash.

view details

Andrew Whatson

commit sha bb74d2716fd4f4083c55220402226ee7766b2a76

Allow :no-native-compile in package recipes

view details

Petri Lehtinen

commit sha ecc6fcd8d5abf73d7d72c9872922f7fe25ef00cd

Bump :lang javascript ananthakumaran/tide@f0b6dac -> ananthakumaran/tide@fa617f5 New version of tide.el introduces xref backend.

view details

Henrik Lissner

commit sha 09a202e8a6def5beeca5790566798fd4ae530e6a

Merge pull request #3828 from Sbozzolo/develop Docs: Fix typo: vterm-module.sh -> vterm-module.so

view details

Henrik Lissner

commit sha f15b36e818ac900d9fce1929a034944194a8a3b5

Merge pull request #3864 from akheron/develop Upgrade tide, enable xref-tide-xref-backend

view details

Henrik Lissner

commit sha 851d11db02e35781188e476b7c256eb45d72d777

Merge pull request #3869 from t-e-r-m/dired-aux-200829 configure dired-aux variables

view details

Henrik Lissner

commit sha c55391d4ac937569ed8be8e658020b33edd98ce4

Merge pull request #3876 from flatwhatson/no-native-compile Allow :no-native-compile in package recipes

view details

Henrik Lissner

commit sha 5940d931f4b48d67372071f57915fe2137af3053

Fix "read only variable" errors on doom {sync,upgrade} Relevant to #3844

view details

Henrik Lissner

commit sha 73565f104162ad34fa8d6ee6f941d83d0e09ba63

Only expand emmet snippets if at word boundary Makes emmet a little less aggressive on TAB. Addresses #3383

view details

Henrik Lissner

commit sha 5de263f6a490bb2e806b47f41dc3508adc59f325

Bump :lang common-lisp joaotavora/sly@155cb06 -> joaotavora/sly@34239bc And chain sly packages together, so disabling sly will disable them all.

view details

Henrik Lissner

commit sha 91c1e705e603fb97129b2b22011ae7fdc8f7d399

checkers/spell: add add/remove word & next/prev error commands So both spell-fu and flyspell users have a more consistent interface.

view details

push time in 22 days

push eventnackjicholson/doom-emacs

Eric Dallo

commit sha b54cf0fe7e954e147410cde6e362ba2601418616

Bump :lang dart emacs-lsp/lsp-dart@437c548 -> emacs-lsp/lsp-dart@9036e4b ericdallo/hover.el@6f9ed1a -> ericdallo/hover.el@079efb1

view details

Nick Hackman

commit sha 64444ac2e7f68a653a0e8c295809a285cf73bb00

Fix typo Ivy README.org Removed extraneous `)`.

view details

Florian Bruhin

commit sha 7dbcd19453afd364d25388436d40640db8b73bca

Fix typo in nav-flash README

view details

Henrik Lissner

commit sha 4cecb22f3776531462df4a3ec66ee22ed5cc98ca

Merge pull request #3884 from ericdallo/bump-dart Bump :lang dart

view details

Henrik Lissner

commit sha 62599cb5f99ddf87fe5cc5488a404defdc488ff1

Merge pull request #3885 from NickHackman/fix-typo-ivy-documentation Fix typo Ivy README.org

view details

Henrik Lissner

commit sha c2e9211776074937244fdc2b68189e04a48c5c09

Merge pull request #3892 from The-Compiler/patch-1 Fix typo in nav-flash README

view details

push time in 22 days

issue commenthlissner/doom-emacs

+notmuch/update () does not close window after finish

@sonnius I wrote this commit to address the same thing https://github.com/nackjicholson/doom-emacs/commit/f41dee3700125b541452dec47719d90c1ce08693

@hlissner Does any one person own the progression of the notmuch portion of doom-emacs? It has FIXMEs that state it's a work in progress. I think I could make a few tweaks and add some documentation to it. I have the interest in using notmuch with doom and would be glad to take a shot at making it less a work in progress. Who do I need to talk to?

sonnius

comment created time in 24 days

create barnchnackjicholson/doom-emacs

branch : nack-notmuch

created branch time in 24 days

fork nackjicholson/doom-emacs

An Emacs framework for the stubborn martian hacker

fork in 24 days

PR opened gauteh/lieer

Add notmuch to setup.py

#174 Related

Need to install notmuch when running python setup.py install

+1 -1

0 comment

1 changed file

pr created time in a month

push eventnackjicholson/lieer

Will Vaughn

commit sha 6673ceababbc1dd6cf8a9bbc0462b3b4101c8bb8

Update setup.py

view details

push time in a month

issue commentnackjicholson/aiosql

Multiple statements don't work

@ccann Glad you figured it out. Glad the DB Adapter worked for you. If you want to contribute a PR with that adapter I'll at least read it over. Not sure if I want to take on having more officially "blessed" driver adapters in the repo or not, but a PR and some example code/discussion could be really helpful to anyone else that comes along looking to use pymysql and aiosql.

ccann

comment created time in a month

pull request commentnackjicholson/aiosql

Replacing internal NameTuple instances with @dataclass usage

@yanniskatsaros Thanks, I have used that package before. I'm being a bit stubborn not wanting to add it as an install dependency only for 3.6. But I may end up doing that.

nackjicholson

comment created time in a month

pull request commentnackjicholson/aiosql

setup.py file based on toml contents

@zx80 I'm confused by these build failures saying that the pyproject.toml file doesn't exist. Any idea what's going on there?

zx80

comment created time in a month

issue commentnackjicholson/aiosql

pip vs poetry

Poetry deploys using wheels, it doesn't need the setup.py to deploy to pypi. I'll take a look at your PR, building the setup.py off of the deps listed in the toml seems like a good approach.

zx80

comment created time in a month

issue closednackjicholson/aiosql

Cant run test suite in dev mode without a local postgres instance

I found it annoying to have to install postgres on my dev machine just to run the tests, most of the time I'm using a throwaway docker container to do that. The following PR https://github.com/nackjicholson/aiosql/pull/15 is an attempt at solving it. For those who use a local instance it basically changes nothing, just need to run POSTGRES_DSN=postrgres://.... pytest instead of pytest and or those who don't have one they can chose to point the new var to wherever the db is.

closed time in a month

euri10

push eventnackjicholson/aiosql

Deployment Bot (from Travis CI)

commit sha 4862da586ea665bc81358790062fcbdcb03f2e04

Deploy nackjicholson/aiosql to github.com/nackjicholson/aiosql.git:gh-pages

view details

push time in a month

delete branch nackjicholson/aiosql

delete branch : detached-postgres-tests

delete time in a month

push eventnackjicholson/aiosql

William Vaughn

commit sha 0ab121dbefcda32007ddb8093fc52add63ce676c

allow tests to execute without postgres installed

view details

Will Vaughn

commit sha 6f1280ba21192031912de27b2376d7d33f017a80

Merge pull request #40 from nackjicholson/detached-postgres-tests allow tests to execute against detached postgres instance (docker/RDS/etc)

view details

push time in a month

PR merged nackjicholson/aiosql

allow tests to execute against detached postgres instance (docker/RDS/etc)

Addresses #16 in a way that is different from how PR #15 did it.

Allows doing something like this with a docker container running postgres rather than having postgres installed on my machine.

docker run --rm --name pg-docker -e POSTGRES_PASSWORD=docker -d -p 5432:5432 -v $HOME/docker/volumes/postgres:/var/lib/postgresql/data  postgres:12-alpine
poetry run pytest --postgresql-detached --postgresql-password=docker
+25 -13

0 comment

2 changed files

nackjicholson

pr closed time in a month

PR closed nackjicholson/aiosql

Upgrade packages, rework test suite

I've been frustrated by being forced to have a local postgres install just for the sake of running tests, so this is an attempt to solve https://github.com/nackjicholson/aiosql/issues/16

I made a few changes that I hope simplify the development for those who don't have a local db running on 5432. For those who use one, it will be just a matter of using the POSTGRES_DNS env var to run them

summary of changes:

  • removed psycopg2 for psycopg2-binary

  • removed pytest-postgresql dependency and use a POSTGRES_DNS env var to point to the test db

  • wrote a small test.sh script that enforces black, flake8 and runs the tests

  • slightly modified travis.yml to test the lib on 3.6 to 3.8

  • upgrade dependencies to latest versions

+634 -238

4 comments

5 changed files

euri10

pr closed time in a month

pull request commentnackjicholson/aiosql

Upgrade packages, rework test suite

@xlevus @euri10 I did this differently without the required environment variable in #40. When you do have postgres installed locally the tests can work exactly the same and still use pytest-postgresql. For the case where someone wants to run tests against a detached instance of postgres (like a docker container or RDS) you can use the pytest-postgresql CLI options to configure the connection to the remote instance along with a new option I added to aiosql tests --postgresql-detached.

euri10

comment created time in a month

issue commentnackjicholson/aiosql

Cant run test suite in dev mode without a local postgres instance

@euri10 Check out #40, it should allow you to run your tests without having postgresql installed.

euri10

comment created time in a month

PR opened nackjicholson/aiosql

allow tests to execute without postgres installed

Addresses #16 in a way that is different from how PR #15 did.

+25 -13

0 comment

2 changed files

pr created time in a month

create barnchnackjicholson/aiosql

branch : detached-postgres-tests

created branch time in a month

more