profile
viewpoint
Max R mxr @lyft San Francisco, CA carpe viverra petitio

mxr/lyft-challenge 2

Solution to the Lyft minimum detour distance programming challenge

mxr/dotfiles 1

:black_circle: :memo: :file_folder:

jmphilli/dot-files 0

{u|li}nux-y files

mxr/add-trailing-comma 0

A tool (and pre-commit hook) to automatically add trailing commas to calls and literals.

mxr/all-repos 0

Clone all your repositories and apply sweeping changes.

mxr/all-repos-depends 0

View the dependencies of your repositories.

mxr/aspy.refactor_imports 0

Utilities for refactoring imports in python-like syntax.

mxr/aspy.yaml 0

Some extensions to pyyaml.

mxr/astpretty 0

Pretty print the output of python stdlib `ast.parse`.

PR opened lyft/beam

[LYFT][STRMCMP-1152] Code refactoring for s3AndKinesis PTransform

Refactoring s3AndKinesis PTransform.

  1. Adding missing dependencies.
  2. Default Kinesis parallelism
  3. Removing namedtuple and using classes.
  4. Variable renaming
+112 -38

0 comment

4 changed files

pr created time in 2 hours

create barnchlyft/beam

branch : STRMCMP-1152

created branch time in 2 hours

Pull request review commentenvoyproxy/envoy

config: stats flush via admin

 message Bootstrap {   // Configuration for internal processing of stats.   metrics.v3.StatsConfig stats_config = 13; -  // Optional duration between flushes to configured stats sinks. For-  // performance reasons Envoy latches counters and only flushes counters and-  // gauges at a periodic interval. If not specified the default is 5000ms (5-  // seconds).-  // Duration must be at least 1ms and at most 5 min.-  google.protobuf.Duration stats_flush_interval = 7 [(validate.rules).duration = {-    lt {seconds: 300}-    gte {nanos: 1000000}-  }];+  oneof stats_flush {

Sounds good. Went ahead and used the oneof_promotion annoatation

hamdiallam

comment created time in 4 hours

create barnchenvoyproxy/envoy

branch : interface_cleanups

created branch time in 6 hours

issue commentlyft/flinkk8soperator

Configuring Prometheus metric reporter

@anandswaminathan are you guys using Prometheus for metrics collection?

aleksandr-spb

comment created time in 10 hours

Pull request review commentlyft/l5kit

Vectorized draw_boxes function

 def draw_boxes(     else:         im = np.zeros((raster_size[1], raster_size[0], 3), dtype=np.uint8) -    box_world_coords = np.zeros((len(agents), 4, 2))-    corners_base_coords = np.asarray([[-1, -1], [-1, 1], [1, 1], [1, -1]])+    corners_base_coords = (np.asarray([[-1, -1], [-1, 1], [1, 1], [1, -1]]) / 2)[None, :, :]      # compute the corner in world-space (start in origin, rotate and then translate)-    for idx, agent in enumerate(agents):-        corners = corners_base_coords * agent["extent"][:2] / 2  # corners in zero-        r_m = yaw_as_rotation33(agent["yaw"])-        box_world_coords[idx] = transform_points(corners, r_m) + agent["centroid"][:2]+    corners_m = corners_base_coords * agents["extent"][:, None, :2]  # corners in zero+    s = np.sin(agents["yaw"])+    c = np.cos(agents["yaw"])+    rotation_m = np.moveaxis(np.array(((c, -s), (s, c))), 2, 0)

Speed is similar to the einsum. So I changed to using matrix multiplication for easier read.

louis925

comment created time in 10 hours

PR opened pre-commit/pre-commit.com

added init-templatedir example windows cmd/ps

added example which uses windows environment variables instead of the ~ (see https://github.com/pre-commit/pre-commit/issues/1720#issuecomment-735304274)

+6 -0

0 comment

1 changed file

pr created time in 10 hours

push eventpre-commit/pre-commit

Anthony Sottile

commit sha 8cfe8e590d9568ff8fb9d5deb0c46776ee966162

don't crash on cygwin mismatch check

view details

Anthony Sottile

commit sha 92ce2dcbc375831bab244507e8072a834b761946

Merge pull request #1721 from pre-commit/dont_crash_on_cygwin_check don't crash on cygwin mismatch check

view details

push time in 10 hours

delete branch pre-commit/pre-commit

delete branch : dont_crash_on_cygwin_check

delete time in 10 hours

PR merged pre-commit/pre-commit

don't crash on cygwin mismatch check

Resolves #1720

The cygwin check depends on being in a git repo, but not all of the pre-commit commands need a git repo (such as gc / clean / init-templatedir) -- allow the cygwin check to fail silently here

+4 -1

0 comment

1 changed file

asottile

pr closed time in 10 hours

issue closedpre-commit/pre-commit

init-templatedir installing hooks to wrong directory

I was trying to use the init-templatedir functionality of pre-commit and ran into a weird problem:

Using Windows 10, pre-commit 2.9.2, git version 2.29.2.windows.1

I followed the example on the pre-commit.com website and used:

git config --global init.templateDir ~/.git-template
pre-commit init-templatedir ~/.git-template

grafik

It wants me to be in a git repository (I thought you prevented this with da80cc6479154c0a0a6096d183f9d1d72aae556b). So i switched to a git repository and rerun

pre-commit init-templatedir ~/.git-template

grafik

the hooks aren't installed in the stated directory. Based on the warnings it looks like pre-commit isn't resolving the ~ correctly, or did I miss sth.?

git config --get init.templateDir 

returns ~/.git-template

grafik

closed time in 10 hours

chronoB

issue commentlyft/flinkk8soperator

Configuring Prometheus metric reporter

@aleksandr-spb have you submitted the PR?

aleksandr-spb

comment created time in 11 hours

IssuesEvent

issue closedpre-commit/pre-commit

init-templatedir installing hooks to wrong directory

I was trying to use the init-templatedir functionality of pre-commit and ran into a weird problem:

Using Windows 10, pre-commit 2.9.2, git version 2.29.2.windows.1

I followed the example on the pre-commit.com website and used:

git config --global init.templateDir ~/.git-template
pre-commit init-templatedir ~/.git-template

grafik

It wants me to be in a git repository (I thought you prevented this with da80cc6479154c0a0a6096d183f9d1d72aae556b). So i switched to a git repository and rerun

pre-commit init-templatedir ~/.git-template

grafik

the hooks aren't installed in the stated directory. Based on the warnings it looks like pre-commit isn't resolving the ~ correctly, or did I miss sth.?

git config --get init.templateDir 

returns ~/.git-template

grafik

closed time in 11 hours

chronoB

issue commentpre-commit/pre-commit

init-templatedir installing hooks to wrong directory

Ahah, so the first part of this is that the cygwin check relies on being in a git repo and it is only run on windows -- that's why it only was failing on windows and why I didn't notice the regression there

As for the other components here, ~ is a special shell expansion on posix -- on windows you'll use %HOMEPATH%\.git-template instead (this probably is worth a documentation update -- the docs live at https://github.com/pre-commit/pre-commit.com if you'd like to contribute to them!).

If we try with %HOMEPATH% I get this output:

(venv) C:\Users\Anthony\workspace\wat>pre-commit init-templatedir %HOMEPATH%\.git-template
pre-commit installed at \Users\Anthony\.git-template\hooks\pre-commit
[WARNING] `init.templateDir` not set to the target directory
[WARNING] maybe `git config --global init.templateDir C:\Users\Anthony\.git-template`?

(venv) C:\Users\Anthony\workspace\wat>git config --global init.templateDir %HOMEPATH%\.git-template

(venv) C:\Users\Anthony\workspace\wat>pre-commit init-templatedir %HOMEPATH%\.git-template
pre-commit installed at \Users\Anthony\.git-template\hooks\pre-commit
chronoB

comment created time in 11 hours

PR opened pre-commit/pre-commit

don't crash on cygwin mismatch check

Related to #1720

The cygwin check depends on being in a git repo, but not all of the pre-commit commands need a git repo (such as gc / clean / init-templatedir) -- allow the cygwin check to fail silently here

+4 -1

0 comment

1 changed file

pr created time in 11 hours

push eventpre-commit/pre-commit

Anthony Sottile

commit sha 8cfe8e590d9568ff8fb9d5deb0c46776ee966162

don't crash on cygwin mismatch check

view details

push time in 11 hours

create barnchpre-commit/pre-commit

branch : dont_crash_on_cygwin_check

created branch time in 11 hours

issue openedpre-commit/pre-commit

init-templatedir installing hooks to wrong directory

I was trying to use the init-templatedir functionality of pre-commit and ran into a weird problem:

Using Windows 10, pre-commit 2.9.2, git version 2.29.2.windows.1

I followed the example on the pre-commit.com website and used:

git config --global init.templateDir ~/.git-template
pre-commit init-templatedir ~/.git-template

grafik

It wants me to be in a git repository (I thought you prevented this with da80cc6479154c0a0a6096d183f9d1d72aae556b). So i switched to a git repository and rerun

pre-commit init-templatedir ~/.git-template

grafik

the hooks aren't installed in the stated directory. Based on the warnings it looks like pre-commit isn't resolving the ~ correctly, or did I miss sth.?

git config --get init.templateDir 

returns ~/.git-template

grafik

created time in 11 hours

PR opened envoyproxy/envoy

Reviewers
route config: use clusters() instead of get() for route validation

This is a follow up to #13906. It replaces use of the thread local clusters with the main thread clusters() output for static route validation. This will enable further cleanups in the cluster manager code.

Risk Level: Low Testing: Existing tests Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A

+198 -46

0 comment

12 changed files

pr created time in 11 hours

push eventenvoyproxy/envoy

htuch

commit sha 8c4a3c77a7de016a118aacc4cea933951b85e589

xdstp: rename UDPA to xDS. (#14157) As per the decision to move the cncf/udpa repository to cncf/xds branding. Also updated cncf/udpa hash and updated identifier handling (moved from repeated to a flat string). Risk level: Low (the only breaking API changes affect not-implemented-hide fields). Testing: New unit tests for path components. Signed-off-by: Harvey Tuch <htuch@google.com>

view details

htuch

commit sha e9fde688402c6fd01189a7333119f9d97c3c9046

vrp: fix local build flow, add to examples CI validation. (#14164) Changes to .dockerignore broke the flow described at https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/security/google_vrp#rebuilding-the-docker-image. This PR fixes and adds a CI verify-example test. Risk level: Low Testing: New verify-examples case. Signed-off-by: Harvey Tuch <htuch@google.com>

view details

alyssawilk

commit sha 6a8785cc37127d32c160aab4e21410b6ae45c834

http: fixing a protocol TODO (#14145) Delaying protocol detection until after a protocol can definitely be established. This means for fixed HTTP/1 HTTP/2 connection pools protocol won't be logged if the upstream connection times out. Risk Level: Medium Testing: existing tests verify protocol is still set Docs Changes: n/a Release Notes: inline Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

view details

Kevin Baichoo

commit sha e42ed4db09ad7e7ae6b575bd1e9a73b57d01e3c7

Fixed typo. (#14171) Signed-off-by: Kevin Baichoo <kbaichoo@google.com>

view details

asraa

commit sha d775afeeb82df3ef6913647aa456b33de960be15

[fuzz] add back fuzzing build macro to CLI (#14182) Adds back FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION macro to CLI. This is the actual fix for #10322, after nocopts was a dead end from RE2 issue google/re2#272. Now when running real unit tests in fuzzing mode, we ignore the test result since we aren't testing for functionality. (config_impl_test doesn't need to succeed for route_fuzz_test to build). Risk Level: Low Testing: Testing fuzz mode fuzzers and regression style fuzzers locally Signed-off-by: Asra Ali <asraa@google.com>

view details

Adam Kotwasinski

commit sha b5f66218e8b5cfd5e51277e1f98658d1a5eaac05

kafka: fix broker integration test (#14177) Follow up to #13950 Commit Message: kafka: fix broker integration test Additional Description: fixes manually executed kafka integration test; started to crash due to using now-fatal v2 config AFACT Risk Level: Low Testing: manual; bazel test //test/extensions/filters/network/kafka/broker/integration_test:kafka_broker_integration_test Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>

view details

Kateryna Nezdolii

commit sha bbb81e4bd213be0cc092d27b5972705eef95b7d8

Introduce creation_time field into host description (#13631) Signed-off-by: Kateryna Nezdolii <nezdolik@spotify.com>

view details

htuch

commit sha 4ac979915fce8562e49293d8e52a48fc25ec6cf6

dependencies: automated OSSF Scorecard runs for Envoy deps. (#14191) This script runs https://github.com/ossf/scorecard against the runtime Envoy deps. The criteria for use_category and scorecard selection are described at https://docs.google.com/document/d/1HbREo7pv7rgeIIjQn6mNpySzQE5rx2Yv9dXm5NqR2N8/edit#heading=h.xnpvc6pk0h0v. Example output is at https://docs.google.com/spreadsheets/d/1caO4qMmG8o5i2nGoEof1qMpD5_WicfiC5WcxA_5isTY/edit#gid=0. The goal will be to evolve this script to help generate and validate metadata describing dependency conformance. Part of #10471. Signed-off-by: Harvey Tuch <htuch@google.com>

view details

Dmitry Rozhkov

commit sha 0f7952d1850be92620f2add304c8d95fce028f93

deps: update Abseil library (#14041) Risk Level: Low Testing: run integration tests Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A Fixes #13973 Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>

view details

Raúl Gutiérrez Segalés

commit sha c70b3e6e30d865ee6b5d81fad312eb49251667b5

filter contract: clarification around local replies (#14193) Follow-up to #13678. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>

view details

Manish Kumar

commit sha c0a044944f45605c86f090182dc92a549e91785f

Removed `--use-fake-symbol-table` option. (#14178) Signed-off-by: Manish Kumar <manish.kumar1@india.nec.com>

view details

Dmitry Rozhkov

commit sha 41de2912488c9ba09efe4f4a5d1c81de9de4110f

doc: mention gperftools explicitly in PPROF.md (#14199) Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>

view details

Adam Kotwasinski

commit sha 39bf75fba0c5eae6eaf0544393ce71daa2e17f9b

kafka: add missing unit tests (#14195) Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>

view details

Sotiris Nanopoulos

commit sha 021e815db3ad83c1a3d110aff343f6edff3245fd

[Windows] Fix thrift proxy tests (#13220) Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>

view details

justin-mp

commit sha 1209a69e14775d69147ae94f5692fed7bf3d1a7d

server: Return nullopt when process_context is nullptr (#14181) The InstanceImpl::processContext() function returns a ProcessContextOptRef a.k.a. absl::optional<std::reference_wrapper<ProcessContext>>. When InstanceImpl::process_context_ is nullptr, the returned value an absl::optional with a value of std::reference_wrapper<>(nullptr), better known as an illegal reference to nullptr. While everything is fine in the InstanceImpl, anyone who tries to use the returned reference will be greeted with a crash. This commit follows the lead of the initializer of InstanceImpl::api_ and returns absl::nullopt when InstanceImpl::process_context_ is nullptr. Risk: Low Testing: bazel test //test/server:server_test Documentation: N/A Release Notes: N/A Signed-off-by: Justin Mazzola Paluska <justinmp@google.com>

view details

asraa

commit sha dee245da6af4c36406be001573450576b194b437

[grpc] validate grpc config for illegal characters (#14129) Signed-off-by: Asra Ali <asraa@google.com>

view details

Matt Klein

commit sha c5b05596a407c6bfbf1ad8e29d71f7e0fdf598e0

route config: use clusters() instead of get() for route validation This is a follow up to #13906. It replaces use of the thread local clusters with the main thread clusters() output for static route validation. This will enable further cleanups in the cluster manager code. Signed-off-by: Matt Klein <mklein@lyft.com>

view details

push time in 11 hours

push eventenvoyproxy/envoy-filter-example

envoy-filter-example(Azure Pipelines)

commit sha f76480d3c7bd7c87d1964359d9b19410ba00d617

Update Envoy submodule to dee245da6af4c36406be001573450576b194b437

view details

push time in 12 hours

push eventenvoyproxy/envoy-filter-example

envoy-filter-example(Azure Pipelines)

commit sha 87a225a1d298a7d5c3a5393b5e8bc0ad58788553

Update Envoy submodule to 1209a69e14775d69147ae94f5692fed7bf3d1a7d

view details

push time in 12 hours

push eventenvoyproxy/envoy

asraa

commit sha dee245da6af4c36406be001573450576b194b437

[grpc] validate grpc config for illegal characters (#14129) Signed-off-by: Asra Ali <asraa@google.com>

view details

push time in 12 hours

PR merged envoyproxy/envoy

[grpc] validate grpc config for illegal characters

Signed-off-by: Asra Ali asraa@google.com

Commit Message: Prevent configuring initial metadata with illegal header characters as per https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md#requests. Otherwise, the start call for a gRPC stream will throw an assertion failure in the grpc library and cause cause a crash. Risk Level: Low, config only. Testing: Added unit test and corpus entry. Fixes https://github.com/envoyproxy/envoy/issues/14128 https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=23829

+124 -0

0 comment

3 changed files

asraa

pr closed time in 12 hours

push eventenvoyproxy/envoy-filter-example

envoy-filter-example(Azure Pipelines)

commit sha aa61312386aa7c96024f1dba2c29bf7a51b2565d

Update Envoy submodule to 021e815db3ad83c1a3d110aff343f6edff3245fd

view details

push time in 12 hours

push eventenvoyproxy/envoy

justin-mp

commit sha 1209a69e14775d69147ae94f5692fed7bf3d1a7d

server: Return nullopt when process_context is nullptr (#14181) The InstanceImpl::processContext() function returns a ProcessContextOptRef a.k.a. absl::optional<std::reference_wrapper<ProcessContext>>. When InstanceImpl::process_context_ is nullptr, the returned value an absl::optional with a value of std::reference_wrapper<>(nullptr), better known as an illegal reference to nullptr. While everything is fine in the InstanceImpl, anyone who tries to use the returned reference will be greeted with a crash. This commit follows the lead of the initializer of InstanceImpl::api_ and returns absl::nullopt when InstanceImpl::process_context_ is nullptr. Risk: Low Testing: bazel test //test/server:server_test Documentation: N/A Release Notes: N/A Signed-off-by: Justin Mazzola Paluska <justinmp@google.com>

view details

push time in 12 hours

PR merged envoyproxy/envoy

server: Return nullopt when process_context is nullptr

The InstanceImpl::processContext() function returns a ProcessContextOptRef a.k.a. absl::optional<std::reference_wrapper<ProcessContext>>. When InstanceImpl::process_context_ is nullptr, the returned value an absl::optional with a value of std::reference_wrapper<>(nullptr), better known as an illegal reference to nullptr. While everything is fine in the InstanceImpl, anyone who tries to use the returned reference will be greeted with a crash.

This commit follows the lead of the initializer of InstanceImpl::api_ and returns absl::nullopt when InstanceImpl::process_context_ is nullptr.

Risk: Low Testing: bazel test //test/server:server_test Documentation: N/A Release Notes: N/A

Signed-off-by: Justin Mazzola Paluska justinmp@google.com

+19 -1

0 comment

3 changed files

justin-mp

pr closed time in 12 hours

push eventenvoyproxy/envoy

Sotiris Nanopoulos

commit sha 021e815db3ad83c1a3d110aff343f6edff3245fd

[Windows] Fix thrift proxy tests (#13220) Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>

view details

push time in 12 hours

PR merged envoyproxy/envoy

[Windows] Fix thrift proxy tests area/thrift area/windows

Signed-off-by: Sotiris Nanopoulos sonanopo@microsoft.com

Commit Message:

Fixes Thrift-Proxy Tests on Windows. Since Python does not support AF_UNIX sockets at all, I changed the tests to communicate over the loopback address.

Risk Level: N/A (test only) Testing: N/A (test only) Docs Changes: N/A Release Notes: N/A

+81 -31

5 comments

7 changed files

davinci26

pr closed time in 12 hours

more