profile
viewpoint

Pull request review commentdenoland/deno

DRAFT: Add experimental inspector support

 pub fn parse_flags(     flags = parse_run_args(flags.clone(), run_matches);   } +  // TODO (matt): Do we also need to set a v8 flag here too? - Seems not required+  // TODO (matt): handle the inspector host/port flags here

Thanks @ak239 this is now possible via --debug=127.0.0.1:5555

mtharrison

comment created time in 2 months

pull request commentdenoland/deno

DRAFT: Add experimental inspector support

@piscisaureus cool, thanks! I'll try to incorporate that into my branch.

mtharrison

comment created time in 2 months

pull request commentdenoland/deno

DRAFT: Add experimental inspector support

Review coming tonight

Excellent. Looking forward to it. I'm going to carve out some time this weekend to work on this.

mtharrison

comment created time in 2 months

pull request commentdenoland/deno

DRAFT: Add experimental inspector support

FYI you can now do --debug run script.js and it will default to 127.0.0.1:9888 or specify your own address with --debug=127.0.0.1:5555 run script.js .

mtharrison

comment created time in 2 months

push eventmtharrison/deno

Matt Harrison

commit sha 2f7dfbe03548c5f1bb48cf89904daecaf1f964ea

Make debug address value optional

view details

push time in 2 months

pull request commentdenoland/deno

DRAFT: Add experimental inspector support

@bartlomieju I'm not seeing this error. Are you using cargo build?

mtharrison

comment created time in 2 months

pull request commentdenoland/deno

DRAFT: Add experimental inspector support

@bartlomieju I've changed the flags a bit now, in the process of just having a single --debug=[address] flag. Can you try again with ./target/debug/deno --debug=127.0.0.1:9888 run script.js.

mtharrison

comment created time in 2 months

push eventmtharrison/deno

Bartek Iwańczuk

commit sha 5350abbc7ffdba6d17166fa00ad89e86979a43f7

manual: Edit note about V8 profiling (#2742)

view details

Ryan Dahl

commit sha e438ac2c74c823882dc9c9ecde2a9e9ed7bcfb4b

Add op_id throughout op API (#2734) Removes the magic number hack to switch between flatbuffers and the minimal dispatcher. Adds machinery to pass the op_id through the shared_queue.

view details

Daniel Buckmaster

commit sha 520bdb6c31dd08b6f4e52de5116fd23d6d57fdda

Fix repl crash when deno dir doesn't exist (#2727)

view details

Matt Harrison

commit sha dc2c3395afddd998bef2d36066dd798490914b4b

Add experimental inspector support

view details

Matt Harrison

commit sha 24052c5cb8a4692faf90500b791fcb77b3bfb81c

Give ownership of Inspector to Worker - tidies things marginally

view details

Matt Harrison

commit sha d6c0b5b16872365bb7628e5beac948f214d344e7

format tool

view details

Matt Harrison

commit sha 4fc04cb02a324cacddf2787aa28441d5e2e7f9ea

Split Inspector and Client(State)

view details

Matt Harrison

commit sha 3f4fc51c4c829993c765f239ff390249669b515b

updated with master

view details

Matt Harrison

commit sha 06559a99ea5638d0d22fef1cc6a058f360a417b5

fix bad merge

view details

Matt Harrison

commit sha 87b2228ef6aaf7418e3b13acb1a59349aa01a687

Partially implemented --debug flag

view details

push time in 2 months

push eventmtharrison/deno

Kitson Kelly

commit sha 5083f5fd908057cbc8649b79c13ab78a7f7ebf34

Remap stack traces of unthrown errors. (#2693)

view details

Bartek Iwańczuk

commit sha ac269beabe1b16294118e64e69bf487639086941

feat: add debug info to ModuleResolutionError (#2697)

view details

Nayeem Rahman

commit sha ef63ec763a142f1e96e12e21d27ffae439f84ffd

Makes shebang Linux compatible (#2694)

view details

Bartek Iwańczuk

commit sha 421cbd39b4f0fdbdfc2eeed6da8dd3410246a044

factor out FileFetcher to separate module (#2683) * merge SourceFileFetcher trait and FileFetcher struct * move logic related to source file fetching to //cli/file_fetcher.rs * use Result when creating new ThreadSafeState

view details

Bartek Iwańczuk

commit sha e7cee29c849286f9b492eb404634a0387b9a75a0

Add --current-thread flag (#2702)

view details

Bartek Iwańczuk

commit sha 2e1ab8232156a23afd22834c1e707fb3403c0db6

refactor: cleanup compiler pipeline (#2686) * remove fetch_source_file_and_maybe_compile_async and replace it with State.fetch_compiled_module * remove SourceFile.js_source() * introduce CompiledModule which is basically the same as deno::SourceInfo and represents arbitrary file that has been compiled to JS module * introduce //cli/compilers module containing all compilers * introduce JsCompiler which is a no-op compiler - output is the same as input, no compilation takes place - it is used for MediaType::JavaScript and MediaType::Unknown * introduce JsonCompiler that wraps JSON in default export * support JS-to-JS compilation using checkJs

view details

Ryan Dahl

commit sha b3541c38f5672ffb4a29d66dca19d88b9ecae478

v0.13.0

view details

Ryan Dahl

commit sha 3971dcfe10b94e901a224b5328a9dafd1e2ecc08

Use system rustfmt instead of fixed binary (#2701)

view details

Tomohito Nakayama

commit sha deec1b9b97011d1a0ef7312c0a3efde21186b82d

Implement function convertLineEndingsToNative in blob.ts (#2695) based on https://w3c.github.io/FileAPI/#convert-line-endings-to-native

view details

Bert Belder

commit sha 5bca001f9703940e693d6a55944ef1ee7fc67f58

build: support crate imports using an alias name A crate can assign an alternative name, different from the crate name, when importing another crate. On the command line this looks like: rustc ... --extern foo_crate=path/to/bar_crate.rlib We need to support this so we can eventually upgrade to rand-0.7.x.

view details

Bert Belder

commit sha c6861b537ead4bba21817610664d68ffbe7daad5

third_party: upgrade rust crates

view details

Kevin (Kun) "Kassimo" Qian

commit sha 52c13fb3ed94e41d90bbe08d1bc299ca90505755

Enforce env permission on homeDir() and execPath (#2714)

view details

Bartek Iwańczuk

commit sha aaa7a3eac4df0de9a93dc8fc4717d38212a3de5b

use BTreeMap for ResourceTable (#2721)

view details

Kevin (Kun) "Kassimo" Qian

commit sha ddee2dff14772ade16e282ad18eda6f5054ce94e

Provide option to delete Deno namespace in worker (#2717)

view details

Ryan Dahl

commit sha a517513182221aa351528cf15d28c449b49fea13

Remove Deno.build.args feature (#2728) This is a minor feature which complicates the build signifigantly. Removing to ease refactoring the build system: https://github.com/denoland/deno/issues/2608

view details

Ryan Dahl

commit sha 046cccfe1768837fcd5b4c1fd7d52fb2d98c0b11

Remove dispatch optimization (#2732) Deno.core.dispatch() used to push the "control" buf onto the shared array buffer before calling into V8, with the idea that it was one less argument to parse. Turns out there is no more overhead passing the control ArrayBuffer directly over. Furthermore this optimization was making the refactors outlined in #2730 more complex. Therefore it is being removed.

view details

Nayeem Rahman

commit sha 11c850af423f07769f054c494a76cbd9efb8806c

Enforce permissions on kill(), homeDir() and execPath (#2723)

view details

Kevin (Kun) "Kassimo" Qian

commit sha ccee2f01ba2f6304720ab17e99dee17bf6687bd8

Implement Blob url support for worker (#2729)

view details

Kevin (Kun) "Kassimo" Qian

commit sha 4519f9a50db8852c5b70ff47481f0fc9d0fbe2f2

Make Deno.execPath a function (#2743) And throws without allow-env

view details

Kevin (Kun) "Kassimo" Qian

commit sha 77d0d1e45ccfd33a8a98e2f5fa4ba618759b5dd3

Fix small execPath issues (#2744)

view details

push time in 2 months

create barnchmtharrison/deno

branch : inspector-rebased

created branch time in 2 months

pull request commentdenoland/deno

DRAFT: Add experimental inspector support

Ok @ry if it causes too much pain we could probably look at another ws crate. What we need is pretty simple for this use case.

mtharrison

comment created time in 2 months

pull request commentdenoland/deno

DRAFT: Add experimental inspector support

Thanks for all the feedback so far. I'm away this weekend on a trip but I'll start working on the suggestions on Monday 😄

mtharrison

comment created time in 2 months

push eventmtharrison/deno

Matt Harrison

commit sha aff61fa8e21803f6690598a763c085c90d475a8d

Split Inspector and Client(State)

view details

push time in 3 months

push eventmtharrison/deno

Matt Harrison

commit sha 2cd6e348ad303ecedd9dbcddc1e9ce2358dafe3e

format tool

view details

push time in 3 months

pull request commentdenoland/deno

DRAFT: Add experimental inspector support

@bartlomieju I could do, however are there any benefits other than seeing test results? Right now it's quite a ways off that really being relevant as I've not written any tests and this likely breaks a bunch of stuff. This is mainly open now to get feedback on the shape of the feature. WDYT?

mtharrison

comment created time in 3 months

push eventmtharrison/deno

Matt Harrison

commit sha 3b0026e33d5287d34d60ee12f4f39d549b9764cb

Give ownership of Inspector to Worker - tidies things marginally

view details

push time in 3 months

startedry/v8worker2

started time in 3 months

startedry/v8worker

started time in 3 months

PR opened denoland/deno

DRAFT: Add experimental inspector support

I wanted to share my progress so far with adding inspector support to Deno via a draft PR. There are still many issues to be ironed out but it feels most productive at this point to get some comments on the approach and suggestions for improvement rather I keep hacking on it in private.

I've added TODO comments to areas I know need work but I'm sure there's lots of other stuff too that I've missed.

To test this out:

cargo build
./target/debug/deno --inspect-brk run script.js
// Inspect via Chrome Devtools
+929 -46

0 comment

22 changed files

pr created time in 3 months

create barnchmtharrison/deno

branch : inspector

created branch time in 3 months

push eventmtharrison/deno

Matt Harrison

commit sha 47311ae3e940ac329dd4787ba3ec3ade6034ffaf

edit script

view details

push time in 3 months

push eventmtharrison/deno

Matt Harrison

commit sha d55edeabb1d168d35a8e8dcc7a4e1852f0bdb765

Cleanup c++

view details

Matt Harrison

commit sha e844acd71adb5634762dbd36b89926879c06d09a

Cleanup c++ some more

view details

Matt Harrison

commit sha 8b9bf8672806a242d22da5aac887e253ef61df43

format

view details

push time in 3 months

push eventmtharrison/deno

Matt Harrison

commit sha 6dc389331e870ab3a5a1f5558b7f6e6bb3bea3aa

Cleanup rust

view details

push time in 3 months

push eventmtharrison/deno

Maxim Mazurok

commit sha b7026816b6c45be0d68880568989698856b30b7f

Typo fix (#2592)

view details

Bartek Iwańczuk

commit sha 3ae808986d583ab4e151a7799acee4680c66bd78

cli: unify deno -h options (#2682)

view details

Bartek Iwańczuk

commit sha 89e6792203678a2ae4911e006fcf9b26f63c700d

cli: handle deno -v and deno --version (#2684)

view details

Bartek Iwańczuk

commit sha 729c4e9377c2112d51cefb6eb0c723cbaf2a1ff5

make importmap flag global (#2687)

view details

hashrock

commit sha 877e5ed7844a1754080ddff9c095ed941072775f

use animated-deno-logo in denolib (#2691)

view details

Bartek Iwańczuk

commit sha 187310a3e151303504a1dc5830334ae7ac1fef57

benchmarks: add bundle size (#2690)

view details

Bartek Iwańczuk

commit sha ff96e3dc637974c6f9853f3bf9565bfd63f22b17

benchmarks: make latency benchmark less noisy (#2689)

view details

Matt Harrison

commit sha 9ed144cb1d4bc748ffaca6947beb48a207a9fe34

Inspector changes

view details

Matt Harrison

commit sha 9f4fab512971dedab70fef07d941e08286299993

Make it pass

view details

Matt Harrison

commit sha 4bfc090d3766aff7486277e4407d0caff7f3b538

x

view details

Matt Harrison

commit sha 5630a813f95c5d7b94ab15fbde870cd667c394e4

trying to make things work

view details

Matt Harrison

commit sha 4ef3dfeecb2d697536313d54eab0b1e38b0ff337

fix lint errors

view details

Matt Harrison

commit sha 3ff259c68d5075e10427189765136c7c697ba495

Things are working

view details

Matt Harrison

commit sha c0df0b4d343c028192e88a6ae2ab050781eff7eb

Prevent nested loop issue

view details

push time in 3 months

push eventmtharrison/deno

Matt Harrison

commit sha 12b518e7e8f12919182017585b63b3e9c1ce5200

Things are working

view details

push time in 3 months

push eventmtharrison/deno

Matt Harrison

commit sha fd187143d2539a5bc30a0d99ae5310a5a1d30b03

fix lint errors

view details

push time in 3 months

push eventmtharrison/deno

Matt Harrison

commit sha 548bdcb42a7d6c2053079b57864772c7f33e368c

Make it pass

view details

Matt Harrison

commit sha c9e59f3164a1dcd34c71164b0fb6b8ea9c14f875

x

view details

Matt Harrison

commit sha 7de782af1defacb8ed0f0e88e948e244cdd8dae4

trying to make things work

view details

push time in 3 months

create barnchmtharrison/deno

branch : v8-inspector-new

created branch time in 3 months

create barnchmtharrison/deno

branch : v8-inspector

created branch time in 3 months

more