profile
viewpoint

msteinert/bstring 106

A fork of Paul Hsieh's Better String Library

jrfoell/campfire-libpurple 50

A Campfire protocol plugin for libpurple (Pidgin)

msteinert/cairo-demo 9

Some Cairo demonstration code.

msteinert/dotfiles 3

My configuration files

msteinert/drone-tower 3

Drone plugin for Ansible Tower

msteinert/BIO-xor 1

An OpenSSL BIO filter implementing the XOR cipher

msteinert/cairo 1

A 2D graphics library with support for multiple output devices

msteinert/campfire-libpurple 1

A Campfire protocol plugin for libpurple (Pidgin & Adium)

msteinert/agent-test 0

experimenting with build agent concepts

msteinert/apple2_disk_utils 0

Utilities for reading from Apple II disks.

fork yashPat98/gltools

Autotooled version of the GLTools library

http://www.starstonesoftware.com/OpenGL/

fork in 4 hours

startedmsteinert/libtask

started time in a day

issue commentdrone-plugins/drone-matrix

Update image to support TLS 1.3

Tested it and it works (built with go 1.14.10)

I don't have a private registry, so, it's only the "connecting to" part i'm worried. ;)

r3pek

comment created time in 3 days

issue commentdrone-plugins/drone-matrix

Update image to support TLS 1.3

You would need to build the executable and see if it connects to your server.

go build ./cmd/drone-matrix

Will make an exe. You can then run ./drone-matrix --help to get a list of options. You should see options that correspond to the settings values. Run it and see if it works.

With the docker one things might be tricky for you https://github.com/drone-plugins/drone-docker/issues/244 so you should probably not use TLS 1.3 exclusively if you have a local registry. But yea you can open the bug.

r3pek

comment created time in 3 days

issue commentdrone-plugins/drone-matrix

Update image to support TLS 1.3

@donny-dont not really sure how i can test this :-/ btw, i guess all images have this problem (just hit it with the docker plugin too). should i open an issue on everyone?

r3pek

comment created time in 3 days

issue commentdrone-plugins/drone-matrix

Update image to support TLS 1.3

Please do a local build of https://github.com/drone-plugins/drone-matrix/pull/18 and see if this solves your problem. I don't use matrix so I can't verify it works.

r3pek

comment created time in 4 days

PR opened drone-plugins/drone-matrix

Use plugin lib

Update to the drone-plugin-lib.

+789 -1207

0 comment

28 changed files

pr created time in 4 days

create barnchdrone-plugins/drone-matrix

branch : use-plugin-lib

created branch time in 4 days

push eventdrone-plugins/drone-github-release

Thorsten Klein

commit sha f00f91df75a18fc5b266bc3114b3648d43c8234c

feature: consider every type of release (real, pre, draft) - loop through list of releases to find one associated with the tag - convert drafted releases to published releases (no downgrading)

view details

push time in 4 days

PR merged drone-plugins/drone-github-release

[Feature] Consider all release types enhancement

Follow-Up on #68 (fixes #65) including fix for issue #71 as per comments below.

+53 -17

8 comments

1 changed file

iwilltry42

pr closed time in 4 days

issue closeddrone-plugins/drone-github-release

Publish a drafted release

First off: Thanks for this awesome Drone Plugin :)

I have the following config for pre-releases (and similar for releases)

- name: pre-release
  image: plugins/github-release
  settings:
    api_key:
      from_secret: github_token
    files:
      - _dist/*
    checksum:
      - sha256
    prerelease: true
  depends_on:
    - lint
    - test
    - build
  when:
    event:
      - tag
    ref:
      include:
        - "refs/tags/*rc*"
        - "refs/tags/*beta*"
        - "refs/tags/*alpha*"

In general, this works really well. However, I'd like to achieve the following flow, which I'm used to from TravisCI:

  1. I draft a release for tag vX.Y.Z
  2. I trigger the drone pipeline by pushing tag vX.Y.Z
  3. Drone builds the release files, picks up the draft release, updates it with the new details and publishes it

So in basic steps: Manually draft a Release -> Drone updates and publishes this release

Right now, Drone will just create a new release with the same tag, rendering the draft invalid.

closed time in 4 days

iwilltry42

pull request commentdrone-plugins/drone-github-release

[Feature] Consider all release types

@donny-dont :heavy_check_mark:

iwilltry42

comment created time in 4 days

pull request commentdrone-plugins/drone-github-release

[Feature] Consider all release types

@iwilltry42 if you rebase the build should complete

iwilltry42

comment created time in 4 days

delete branch drone-plugins/drone-github-release

delete branch : template-update-2020-11

delete time in 4 days

push eventdrone-plugins/drone-github-release

Don

commit sha 527d7fb6495ef38f55a492521cc1ea820d18a008

Update to latest boilr template

view details

push time in 4 days

PR merged drone-plugins/drone-github-release

Reviewers
Update to latest boilr template

Update to the build removes the dry run build of the dockerfile for PRs. A build for Windows 1909 is added. Additionally adds a renovate config.

+340 -325

1 comment

3 changed files

donny-dont

pr closed time in 4 days

pull request commentdrone-plugins/drone-github-release

Update to latest boilr template

The relevant changes to the template are at https://github.com/drone-plugins/boilr-plugin/pull/16

donny-dont

comment created time in 4 days

pull request commentdrone-plugins/drone-github-release

[Feature] Consider all release types

@bradrydzewski the dry-run step is removed in #72

iwilltry42

comment created time in 4 days

push eventdrone-plugins/drone-github-release

Don

commit sha 6f535ae6a453cd723bca7066cfc8d27db136ae52

Update to latest boilr template

view details

push time in 4 days

PR opened drone-plugins/drone-github-release

Update to latest boilr template

Update to the build removes the dry run build of the dockerfile for PRs. Additionally adds a renovate config.

+349 -325

0 comment

3 changed files

pr created time in 4 days

create barnchdrone-plugins/drone-github-release

branch : template-update-2020-11

created branch time in 4 days

pull request commentdrone-plugins/drone-github-release

[Feature] Consider all release types

the dry run needs to be removed because this results in unauthenticated pulls to dockerhub

iwilltry42

comment created time in 4 days

pull request commentdrone-plugins/drone-github-release

[Feature] Consider all release types

@Upgreydd could you please take a look at this to make sure it works since you reported that failure?

iwilltry42

comment created time in 4 days

pull request commentdrone-plugins/drone-github-release

[Feature] Consider all release types

@bradrydzewski could you just configure a pull-through cache for cloud.drone.io?

iwilltry42

comment created time in 5 days

startedmsteinert/pam

started time in 5 days

pull request commentdrone-plugins/drone-github-release

[Feature] Consider all release types

@lafriks I pulled the original changes into this PR and rewrote it. The error came from leftover, but now improper case handling, when no release was returned, but also no error was raised. It should be fixed now. Please give it a try. (Relevant Lines: https://github.com/drone-plugins/drone-github-release/pull/69/files#diff-d839f0f9a2a680ce257706a246a02fc0a8ef3eb09212ae1d5085fa84c7dc7321R36-R49)

iwilltry42

comment created time in 6 days

IssuesEvent

issue commentdrone-plugins/drone-github-release

Publish a drafted release

@iwilltry42 this was reverted because https://github.com/drone-plugins/drone-github-release/issues/71 was reported.

iwilltry42

comment created time in 6 days

pull request commentdrone-plugins/drone-github-release

[Fix] always publish drafts (not only if overwrite=true)

As #68 was reverted this needs new start taking into account issue #71

iwilltry42

comment created time in 6 days

issue closeddrone-plugins/drone-github-release

Plugin failure

latest: Pulling from plugins/github-release
--
2 | Digest: sha256:d7b0d14cd45b9bcc370810fda6b52ff3cc2aada5ede62e6f3005c3d8670f4510
3 | Status: Downloaded newer image for plugins/github-release:latest
4 | no existing release (draft) found for the given tag
5 | panic: runtime error: invalid memory address or nil pointer dereference
6 | [signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x80f256]
7 |  
8 | goroutine 1 [running]:
9 | github.com/drone-plugins/drone-github-release/plugin.(*Plugin).Execute(0xc000130b00, 0x0, 0x0)
10 | /drone/src/plugin/impl.go:147 +0x386
11 | main.run.func1(0xc000033a80, 0xc00000eb00, 0x50)
12 | /drone/src/cmd/drone-github-release/main.go:60 +0x386
13 | github.com/urfave/cli/v2.(*App).RunContext(0xc000001200, 0x9fb1a0, 0xc00002a038, 0xc0000201e0, 0x1, 0x1, 0x0, 0x0)
14 | /go/pkg/mod/github.com/urfave/cli/v2@v2.2.0/app.go:315 +0x70b
15 | github.com/urfave/cli/v2.(*App).Run(...)
16 | /go/pkg/mod/github.com/urfave/cli/v2@v2.2.0/app.go:215
17 | main.main()
18 | /drone/src/cmd/drone-github-release/main.go:37 +0x223

Caused by task:

- name: Create release in GitHub
  image: plugins/github-release
  settings:
    api_key:
      from_secret: github_token
  when:
    event: tag

Should create release without attaching files.

closed time in 6 days

Upgreydd
more