profile
viewpoint
Michelle Scharlock mscharlock @Microsoft Redmond, WA https://www.linkedin.com/in/mscharlock/ Dev Writer II @ MSFT | MSFT GLEAM Outreach | Opera singer | Enamel pin enthusiast | ICE + Github = no | BLM | My views don't represent MSFT

MicrosoftDocs/VBA-Docs 169

This repo is no longer accepting new issues. To request changes, you can create a branch, make changes, then submit a PR. Code questions? Try https://stackoverflow.com/questions/tagged/vba. Suggestions? Go to https://officespdev.uservoice.com. Need more help? Try https://docs.microsoft.com/office/vba/articles/feedback-support. Office VBA reference:

arn1313/201-Final-Project 1

Team Kranky 201 Final Project

arn1313/kc-farmers-market 1

a social media app for the Kansas City Farmers Market

arn1313/mock-restaurant 0

Mock up of a basic restaurant site

delete branch OfficeDev/office-js-docs-pr

delete branch : developingtodevelop

delete time in a day

push eventOfficeDev/office-js-docs-pr

Michelle Scharlock

commit sha c51e481a1fb64be4c8a70cd9a74c8f6e0cd24100

[Add-ins][All hosts] Changed developing office add-ins to right title (#2266)

view details

push time in a day

PR merged OfficeDev/office-js-docs-pr

[Add-ins][All hosts] Changed developing office add-ins to right title

We changed the title of an article from "Developing Office Add-ins" to "Develop Office Add-ins" but forgot the See Alsos. Also one weird duple.

+39 -41

4 comments

22 changed files

mscharlock

pr closed time in a day

push eventOfficeDev/office-js-docs-pr

Alison McKay

commit sha 92eb00462fb96e86e9cee176674574459f10fec1

[Excel] (Range) Add formula precedents article section (#2253) * [Excel] (Range) Add formula precedents article section * Add detail to Formula precedents section * Adjust article section title * Remove version from URL * Apply suggestions from code review Co-authored-by: Alex Jerabek <38896772+AlexJerabek@users.noreply.github.com> * Incorporate changes per code review * Add an !IMPORTANT note * Adjust grammar, clarify 'trace' references * Add WorkbookRangeAreas object description per feedback * Adjust format and code comment Co-authored-by: Alex Jerabek <38896772+AlexJerabek@users.noreply.github.com>

view details

Elizabeth Samuel

commit sha 4a6636e2025f27c5317516443883fd4467269ae9

[Outlook] (delegate) Update support note (#2267)

view details

Elizabeth Samuel

commit sha cc7e3c927af5d533a74856b7323067f68f3694c5

[Admin] Fix broken links reported (#2274)

view details

Elizabeth Samuel

commit sha a9802046cbd56a9bceb91df926ce82d0ae5cd0d4

[Outlook] Add requirement set 1.9 (#2264) * [Outlook] Add requirement set 1.9 * Fix links * Update based on feedback * Update build info

view details

Elizabeth Samuel

commit sha 76c72c9d2cbbde151cccd9cea593830ffde457be

[Outlook] (preview) New Mac UI doesn't support compose window pop-out (#2276)

view details

Alex Jerabek

commit sha e24eee9a98b8566d5884380636704c4d14b26f63

Add moniker to TOC fusion: (#2272)

view details

Michelle Scharlock

commit sha fb35dabe2571dedd5197dbfba68deabe34ed55ef

[Add-ins][All hosts] Add links to the Dev Program (#2265) * add links to the Dev Program * Update docs/outlook/outlook-add-ins-overview.md Co-authored-by: Alison McKay <almckay@microsoft.com> * remove dupe Co-authored-by: Alison McKay <almckay@microsoft.com>

view details

Michelle Scharlock

commit sha 06e3a3d47127b25eb0efc70688adce57492f30ff

Merge branch 'master' into developingtodevelop

view details

push time in a day

delete branch OfficeDev/office-js-docs-pr

delete branch : devprogrammentions

delete time in a day

push eventOfficeDev/office-js-docs-pr

Michelle Scharlock

commit sha fb35dabe2571dedd5197dbfba68deabe34ed55ef

[Add-ins][All hosts] Add links to the Dev Program (#2265) * add links to the Dev Program * Update docs/outlook/outlook-add-ins-overview.md Co-authored-by: Alison McKay <almckay@microsoft.com> * remove dupe Co-authored-by: Alison McKay <almckay@microsoft.com>

view details

push time in a day

PR merged OfficeDev/office-js-docs-pr

Reviewers
[Add-ins][All hosts] Add links to the Dev Program

Putting some cross-links to the dev program seems to me like it would be a good idea since we rarely expose it in our docs. :)

+35 -18

5 comments

17 changed files

mscharlock

pr closed time in a day

push eventOfficeDev/office-js-docs-pr

mscharlock

commit sha 541ba523a8884a3171e325b9df5a905eb7c01e93

remove dupe

view details

push time in 3 days

push eventOfficeDev/office-js-docs-pr

Michelle Scharlock

commit sha 3f79de5345041bce66d8c33d6573f4998adf5350

Update docs/outlook/outlook-add-ins-overview.md Co-authored-by: Alison McKay <almckay@microsoft.com>

view details

push time in 3 days

pull request commentOfficeDev/office-js-docs-pr

[Add-ins][All hosts] Add links to the Dev Program

@mscharlock Note that Developer Program is in the header on docs though: image

This is specific to an experiment to see if this drives any engagement with the program. I don't think the header is prominent enough for people to notice and sign up.

mscharlock

comment created time in 3 days

push eventOfficeDev/office-js-docs-pr

Michelle Scharlock

commit sha 6a7edbc70dce52dba8a90938e3f668553f3320ab

Apply suggestions from code review Co-authored-by: Elizabeth Samuel <elizs@microsoft.com>

view details

push time in 3 days

push eventOfficeDev/office-js-docs-pr

Michelle Scharlock

commit sha b1a73b8acb3454f4b8fdae0f74664eb9eabf50b0

Apply suggestions from code review Co-authored-by: Elizabeth Samuel <elizs@microsoft.com>

view details

push time in 6 days

PullRequestReviewEvent

PR opened OfficeDev/office-js-docs-pr

[Add-ins][All hosts] Changed developing office add-ins to right title

We changed the title of an article from "Developing Office Add-ins" to "Develop Office Add-ins" but forgot the See Alsos. Also one weird duple.

+48 -49

0 comment

24 changed files

pr created time in 8 days

create barnchOfficeDev/office-js-docs-pr

branch : developingtodevelop

created branch time in 8 days

PR opened OfficeDev/office-js-docs-pr

Reviewers
[Add-ins][All hosts] Add links to the Dev Program

Putting some cross-links to the dev program seems to me like it would be a good idea since we rarely expose it in our docs. :)

+35 -17

0 comment

17 changed files

pr created time in 8 days

issue commentOfficeDev/office-js-docs-pr

When "Let users access the Office Store is disabled" sideload is prevented

@ElizabethSamuel-MSFT let me check that this is expected and then will doc. Thanks!

bakerm00

comment created time in 8 days

issue commentOfficeDev/office-js

Running `npm run build` creates and then deletes functions.json file

@ElizabethSamuel-MSFT let me follow up with you offline :)

areed1192

comment created time in 8 days

create barnchOfficeDev/office-js-docs-pr

branch : devprogrammentions

created branch time in 8 days

fork mscharlock/testing-assets

The asserts for testing purpose.

fork in 8 days

issue commentOfficeDev/office-js-docs-pr

Custom Functions / Call Office.js article should be more specific on pattern

An fyi to @alison-mk - I believe a previous version of the params article has some copy on invocation.address that might be helpful on this.

keyur32

comment created time in 24 days

pull request commentOfficeDev/office-js-docs-pr

Update CF req set overview page

Actually one thing - do we want descending order or ascending order for the req set #s? I seem to remember Excel is highest first. Not a huge deal, but might be good for consistency. @AlexJerabek to confirm that this is actually a rule that we follow though as a double check

alison-mk

comment created time in a month

PullRequestReviewEvent

pull request commentOfficeDev/office-js-docs-pr

Update CF req set overview page

Agree with Alex's comments, but this looks great! :D Will be exciting to check this off the list :)

alison-mk

comment created time in a month

PullRequestReviewEvent

push eventmscharlock/DefinitelyTyped

tempaccount-m

commit sha b6af4bed7338cdcd9a68ceb9893b2c2cf4ecca6c

@types/plotly.js Added histfunc and added (#45828) to hoverinfo Co-authored-by: ck <ck@ck.de>

view details

Wafa

commit sha 7152e63617fb8f6b4459833f353ddb0e5e017eac

make bitrateCangedEvent extend type Event (#45826)

view details

Frelia

commit sha 1882299f0994c3481fd43bb9a23920ffe999915d

Add types to randomatic (#45822) * Add types to randomatic * Include definition author for randomatic

view details

Zach Anthony

commit sha fd848fb6752692d0d8cc914b8e6c5c7ceb9a15f7

feat(aws-lambda): add the amazon connect contact flow trigger (#45820) * Added support for Amazon Connect Contact Flow Trigger to AWS Lambda * Updated formatting of files

view details

J. Pablo Fernández

commit sha 58e136504dbf04dfb77717f9ef305c4955e98feb

Passport's authorize function accepts Strategy (#45817) Some references: https://medium.com/passportjs/authenticate-using-strategy-instances-49e58d96ec8c https://stackoverflow.com/a/62644453/6068

view details

Tomas Carnecky

commit sha b9f4e2353b008ae1f79d40e3341f6c80630151db

markdown-to-jsx: children prop is required and must be a string (#45815)

view details

Dennis Snell

commit sha 6c2bcffe6837ce930027801d20a6c191152c4a07

update(simperium): add missing optional parameters to event listener (#45814) When creating the original types there was an oversight in the event types for the `Channel` and its `update` event. In some cases the event fires only with the first two parameters: the entity id and data. In the normative case however there are additional parameters available indicating meta information about the update. Those optional paramters have been added here. Although it looks like all three of the last parameters are optional it's actually the case that either you get only the first two or all five. It would not occur that you only get three or four of them but I wasn't sure how to type this beyond function overloads and I believe that it's not the best idea to use function overloads for optional parameters.

view details

Kyle Poole

commit sha a40caac0b52e1246ad51ec49f772099a124c5156

fix CartesianGridProps CoordinatesGenerator (#45809)

view details

Zoran Kokeza

commit sha 642829c88a90e46ef27d5b6d02387dba81bf68db

[Cesium] - fix wrong parameters on EllipsoidTangentPlane.fromPoints (#44899) * Update index.d.ts * Update index.d.ts

view details

DerZade

commit sha 6a6dd4ff8dcbb1ca1c4a51f7e6dbb5cdac502703

Update index.d.ts (#45804)

view details

Jason Buckner

commit sha 775c5acd6a86a8cb2f2daf6c48a7a500fc334e75

Update braintree-web and add paypal-checkout-components (#45655) * Add GooglePayment interface This also adds a dependency on the `googlepay` types * Add parameters and `teardown` Promise to `HostedFields` * Add PayPalCheckout interface * Add Venmo interface * Export `venmo`, `googlePayment`, and `paypalCheckout` * Add PayPalCheckout test * Bump version to 3.1 * Test removing the dependency * Split braintree-web into modules * Import us-bank-account * Update types and add tests * Add google pay test * Clean up some exports * Bump version of braintree-web * Run prettier * Remove unneeded references * Update paypal-checkout createPayment return value * Move braintree paypal checkout definitions to paypal-checkout-components There were several definitions that were part of PayPal, not Braintree so this puts them in their correct spot. * Add tests and organize * Linting * Add createPayment and tokenize options interfaces * Add myself to the "by" line * Remove tsling tweaks except namespace I couldn't figure out how to not use this rule override. * Disable max-length * Clean up paypal modules * Convert declare namespace to module style This updates the format of braintree-web and paypal-checkout-components to use module-style. Previously it was using `declare namespace` declarations. Now it uses module style imports and exports so it's more explicit. * Add a few additional exports and methods

view details

Ricardo Amaral

commit sha da860cab5df906d7a1c5b18c4a507a4a6dd98dd8

Do not expose `cheerio` object globally (#45800) This change prevents one to use `cheerio` without importing the object first. I'm not totally aware if this change has any major implications as I'm no TypeScript definitions expert, but looks okay to me. Please advise if otherwise, I'd love to understand how could this be improved/fixed.

view details

Sina Aghajani

commit sha 3f1836cba57649bb4fbe1ee290b2dca89750b2bc

add missing 'useFindAndModify' option (#45799) add missing 'useFindAndModify' option to 'QueryFindOneAndUpdateOptions' of 'types/mongoose'

view details

kozzzz-07

commit sha 5284814412ef2c018e7627264511df37d79932f7

fix: USAGE of Express for types express (#44740) * fix: USAGE of Express * changed UTF8 to utf8 * changed whitespace to spaces * Update passport-saml-tests.ts * Update index.d.ts

view details

Jamie Magee

commit sha b670549f489eb0abd5e1bf93ed26780cf7d7d385

Add types for linkify-markdown (#45794)

view details

Daniel Cassidy

commit sha 011614c581eb8ce0aef67a87c6df16a00319c9e7

xml-formatter: Delete not-needed types (#45788)

view details

Elvis Wolcott

commit sha f901e853ca2d03ae5ff62dc5b779bea5968c5793

pubnub: Update for Objects v2 (#45738) * add objects listener * depreciate objects v1 methods * cleanup callback types * add type definitions for objects v2 * update deprecation message * remove todo (I think I got the answer) * fix lint errors * update version * add tests and fix a few things * fix lint errors * more specific custom type * type custom objects

view details

William Orr

commit sha 30af8f7c653b6fd690444fa68408ddaee54ec8e6

Add missing chai-as-promised assert functions (#45784)

view details

Johanns Gregorian

commit sha 86aab7c104baa6d35076c45469d46130fc4251c0

[uikit] UIkit.modal.prompt returns `string` or `null` (when cancelled) (#45483) * UIkit.modal.prompt returns `string` or `null` (when cancelled) * UIkit: Adding myself to defintion owners since current owners are unresponsive * UIkit: Fixed header typo

view details

Anton Rieder

commit sha ac78970630a999154c15af3e13c9f2d3d8344a7b

[string-natural-compare] Add type definition (#45777) * [string-natural-compare] Add type definition * Fix CI errors

view details

push time in 2 months

push eventmscharlock/DefinitelyTyped

mscharlock

commit sha b2ee62d854cc30839e4e65ad982905aa27148046

changes!

view details

push time in 2 months

pull request commentDefinitelyTyped/DefinitelyTyped

Update to CustomFunctionsRuntime to 1.3

@ElizabethSamuel-MSFT any chance you can review to see if this blocks? I cannot add you as a reviewer for some weirdo reason

mscharlock

comment created time in 2 months

push eventmscharlock/DefinitelyTyped

mscharlock

commit sha 1aedb84b818639a42792295af946477f5fd8e8dc

move back to 1.5?

view details

push time in 2 months

push eventmscharlock/DefinitelyTyped

mscharlock

commit sha 43d626cebdb39b8cb0109fb30a53e3b230c2c77b

put the tests back in

view details

push time in 2 months

push eventmscharlock/DefinitelyTyped

mscharlock

commit sha 0e4b83215f06a377074c3da74cd7f3b9ab1580fc

get rid of all the tests??

view details

push time in 2 months

push eventmscharlock/DefinitelyTyped

mscharlock

commit sha 09297051d93d4fc6716311d9ad09708a3a5e3b0a

rerun CI

view details

push time in 2 months

push eventmscharlock/DefinitelyTyped

mscharlock

commit sha fb51d547e65f8b8c48576580f76a572203f88c8c

hrm

view details

push time in 2 months

Pull request review commentDefinitelyTyped/DefinitelyTyped

Update to CustomFunctionsRuntime to 1.3

 declare namespace CustomFunctions {          * `{ "requiresAddress": true }`          *          * If the metadata JSON file is being generated from JSDoc comments, include the tag `@requiresAddress`.+         * [Api set: CustomFunctionsRuntime 1.1]          */         address?: string;+        /**+         * The range addresses where the function parameters are located, if requested, otherwise undefined.+         *+         * To request the parameter addresses for the function, in the metadata JSON file, the function options should specify:+         * `{ "requiresParameterAddresses": true }`+         *+         * If the metadata JSON file is being generated from JSDoc comments, include the tag `@requiresParameterAddresses`.+         * [Api set: CustomFunctionsRuntime 1.1]+         */+        parameterAddresses?: string;

I want to check with Ruoying or Phoebe to make sure I write the right thing here but good call out

mscharlock

comment created time in 2 months

PullRequestReviewEvent

push eventmscharlock/DefinitelyTyped

mscharlock

commit sha 560f6e7b07c882f422d96bf3772485d715fcd988

tried to add some kind of test

view details

mscharlock

commit sha 49bc525afef5b7c85942ce28cb63db7c78d21e71

minor adjustment

view details

mscharlock

commit sha 0986bc6f244917e451274303f82e7801ce5c3e17

Merge branch 'michelle-cfruntime13' of https://github.com/mscharlock/DefinitelyTyped into michelle-cfruntime13

view details

mscharlock

commit sha fe71205cfc7e7dd98831b86d2497fe81b93c1a46

add a test?

view details

push time in 2 months

push eventmscharlock/DefinitelyTyped

Michelle Scharlock

commit sha 60eba947e881f52679271c358a1603e4592d562b

Apply suggestions from code review Co-authored-by: Alex Jerabek <38896772+AlexJerabek@users.noreply.github.com> Co-authored-by: Alison McKay <almckay@microsoft.com>

view details

push time in 2 months

issue commentOfficeDev/office-js-docs-pr

When is the shared runtime environment changing to use Edge instead of IE11?

So long as the version of Office is up to date on Mac (16.35 or later), shared runtime will work. The IE11 engine is only used on Windows 32-bit. Let me know if you have any other questions!

astak15

comment created time in 2 months

issue commentOfficeDev/office-js-docs-pr

Unclear documentation on shared runtimes and mulitple taskpanes

@Murugananths - do you still need assistance with this? If so, can I ask you to open a separate issue? That will help me funnel this to the right people. Thank you!

naterush

comment created time in 2 months

issue commentOfficeDev/office-js-docs-pr

When is the shared runtime environment changing to use Edge instead of IE11?

Hi @astak15 - I can't share any timelines with you at this point, but if we develop new things with shared runtime (such as the change you suggest), I will be updating the docs and an update would go into our developer newsletter! Sorry I cannot provide any more information for you. Thanks!

astak15

comment created time in 2 months

push eventmscharlock/DefinitelyTyped

Thomas Aribart

commit sha c7b08e7d3a71b5834977537d3b13b732bcd23032

🤖 Merge PR #45726 Serverless: Add id authorizer to http api event by @ThomasAribart

view details

martin-badin

commit sha cf0cdcc3abcaed10f30bae37eb5ec0b72180b0e1

[shopify-buy] Update types for Query interface (#45721) Co-authored-by: Martin Badin <MBadin@gohealth.com>

view details

Andrew Hazlett

commit sha 786d1ede4351c44cf4d3cfbf605f339fb4d41348

restrict return of getCurrency() to valid values (#45671)

view details

Maxime Chéramy

commit sha 385d6cbe7a19730b612527a72107368671fbfdaa

fix: options argument is optional (#45725) Here's the declaration of the function: /** * Pull is a wrapper around createImage, parsing image's tags. * @param {String} repoTag Repository tag * @param {Object} opts Options (optional) * @param {Function} callback Callback * @param {Object} auth Authentication (optional) * @return {Object} Image */ Docker.prototype.pull = function(repoTag, opts, callback, auth) {}

view details

Jason O'Neill

commit sha bf2a6e1785dc5f702846d56c092a092b7eb485b4

Fix optional parameters (#45728)

view details

Alex Jerabek

commit sha 40e15fbd16990c73eb1ae6501b14cf2299ef1542

Add note about the Binding ID that's returned by binding events (#45730)

view details

ron23

commit sha 26824cd54eecee5fb4de215515e6e62663815125

🤖 Merge PR #45733 [react-color] Add objectList presetColor by @ron23 * add objectList presetColor * rename `name` to `title` and use `type` * fix linting errors Co-authored-by: rrosenshain <rrosenshain@snapchat.com>

view details

Piotr Błażejewicz (Peter Blazejewicz)

commit sha b878c634d684e13b920f6fd6fac2b705500d70c5

feat(scroll-lock): new type library (#45735) - definition file - tests https://github.com/FL3NKEY/scroll-lock#readme Thanks!

view details

Connor Peet

commit sha dedd90e20ca68d711af06c2c7e151aca9e87313f

vscode-notebook-renderer: init (#45731) * vscode-notebook-renderer: init * fixup! bad username link

view details

Adam Larsen

commit sha 5ca1e873b7d45542b10b27b065a79a851ceb728a

🤖 Merge PR #45635 Add support for Promises in redux-api-middleware by @AdamCLarsen * Add support for Promises in redux-api-middleware fix * Change promises result type def in redux-api-middleware Reducing the duplication in the type definitions for the Promises return types in functions. Change promises result type def in redux-api-middleware

view details

Daniel Rearden

commit sha 58752d5aff5ae2cdfcee10647b611811b11d07fd

🤖 Merge PR #45737 [superagent] Fix Request.write return type by @danielrearden

view details

Evgeniy Timokhov

commit sha eaaf689a26e03875d7a8b32aa4c7833d5ebf957a

🤖 Merge PR #45745 [puppeteer] Fixed return type for `Frame.executionContext` and `ExecutionContext.queryObjects` by @timocov - Frame.executionContext returns a Promise - ExecutionContext.queryObjects returns a Promise

view details

Michael Ness

commit sha bce8dab379fa6be5c291772c63a663bf02c61cc7

🤖 Merge PR #45717 [@types/underscore] Collection and Array Tests - Type Extractors by @reubenrybnik * Adding type extractors and updating existing tests to use them. * Improving handling of mixed-iterability types by simplifying the Underscore and chain functions to a single overload. * Updating TypeOfCollection to check against List and Dictionary separately instead of using Collection since using the latter behaves oddly with JQuery objects. * Renaming a variable to something slightly more friendly. * Renaming variables in tests.

view details

Piotr Błażejewicz (Peter Blazejewicz)

commit sha 99fe2e5223f44928ff4ff62c5ac16626c3955c40

feat(write-file-encoding): add support for encoding option (#44800) * feat(write-file-encoding): add support for encoding option The api supports string as an option This string option is the encodign of the data, defaulting to 'utf8'. As the Node types are referenced, simply BufferEncoding is beign used instead of string or string aliases to align with Node types. For backward compatiblity options 'encoding' is defined as: BufferEncoding | '' https://github.com/npm/write-file-atomic#write-file-atomic Thanks! * Be specific about allowed encoding as per PR comment /cc @amcasey

view details

Piotr Błażejewicz (Peter Blazejewicz)

commit sha ee7bf679aee6e838b69ea4c32553626dbc37e3e9

update(gh-pages): v3 bump (#45161) * update(gh-pages): v3 bump This version (as per release notes) does not change API. So this just aligns with source code package version: https://github.com/tschaub/gh-pages/releases/tag/v3.0.0 Thanks! * Add `defaults` export as per PR check

view details

Ole André Vadla Ravnås

commit sha ce04d8c89e39f8ede0aa98e7dd03ec38f00a1515

Sync frida-gum typings with Frida 12.10.1 (#45592)

view details

Piotr Błażejewicz (Peter Blazejewicz)

commit sha 687a62f7dbc28e9ff27e1abc3ae73a38f7b734e9

update(cuss): minor version bump (#45665) - v1.20 - test updated - DT header minor change https://github.com/words/cuss/releases/tag/1.20.0 Thanks!

view details

Sebastian Silbermann

commit sha 30efa4bd9f6c58c5c2f0394b03f3f914619072ce

feat(aria-query): Update types for 4.2 (#45657) * feat(aria-query): Update typings for 4.0.0 * feat(aria-query): Upate typings for 4.2.x

view details

Asitha de Silva

commit sha 55726030104317911bd6a7b7794e858c76a8f280

🤖 Merge PR #45509 Stripe - Subscriptions Transfer Data Definition by @asithade * Subscription Transfer Data Definition * Missing Semi-colon * Added Test & Fixed Optional Field

view details

Luksys5

commit sha b0f5ef9a018efacd321047da44d4a6138662a0c1

Types.ReactSvgRadarChart. Updating the package, resolving previous comments (#45680) * Feature.ReactSvgRadarChart. Add typings for package react-svg-radar-chart * Feature.ReactSvgRadarChart.Adding ReadonlyArray instead of normal one * Feature.ReactSvgRadarChart. Added more default values to show and set some properties optional. * Adding newline where it should exist * Remove trailing whitespace. Adding minimum because linting throws errors other way * Leaving the minimum ts version only Co-authored-by: Lukas Tutkus <lukas.tutkus@macaw.nl>

view details

push time in 2 months

PR opened DefinitelyTyped/DefinitelyTyped

Update to CustomFunctionsRuntime to 1.3

Please fill in this template.

  • [ x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x ] Test the change in your own code. (Compile and run.)
  • [ x] Add or edit tests to reflect the change. (Run with npm test.)
  • [ x] Follow the advice from the readme.
  • [ x] Avoid common mistakes.
  • [ x] Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • [x ] Provide a URL to documentation or source code which provides context for the suggested changes: This is an update based on code from a Microsoft team, there is no openly available source code.
  • [ x] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [ x] Include tests for your changes
+86 -22

0 comment

1 changed file

pr created time in 2 months

push eventmscharlock/DefinitelyTyped

mscharlock

commit sha 961bd60d70af6f9a27ff6211a2406d0d983ca4d7

minor updates

view details

push time in 2 months

create barnchmscharlock/DefinitelyTyped

branch : michelle-cfruntime13

created branch time in 2 months

create barnchOfficeDev/office-js-docs-pr

branch : customfunctionsignitemain

created branch time in 2 months

issue commentOfficeDev/office-js-docs-pr

UI-less Custom functions does not trigger when a workbook is opened

Hi @vikasm1720 It's my understanding that this doesn't work with dynamic arrays. Reason being, our dependency model is such that formulas can only impact the cells that they live in. Otherwise, you run into weird side effects when a spreadsheet recalculates. Hope that helps answer your question. Let me know if you need anything else.

vikasm1720

comment created time in 2 months

issue commentOfficeDev/office-js-docs-pr

Improving a Custom functions debugging documentation regarding sideloading an add-in when using Visual Studio

Hi there @topkoong - to follow up on this, wanted to let you know about some new documentation on our add-in debugger for VSC. Let me know if that helps. Thanks!

topkoong

comment created time in 2 months

issue commentOfficeDev/office-js-docs-pr

The shared javascript runtime does't work

Hi @uangyydev - Thanks for reading our docs and writing in. Can you let me know if you have used the manifest validator tool to ensure your manifest is correct? Let me know when you get a chance. Thanks!

uangyydev

comment created time in 2 months

issue commentOfficeDev/office-js-docs-pr

UI-less Custom functions does not trigger when a workbook is opened

@vikasm1720 I'll look into this with our engineers and let you know. Thanks!

vikasm1720

comment created time in 2 months

issue closedOfficeDev/office-js-docs-pr

Improve documentation for working with existing .Net web project

If you want to create custom functions that connect to a web project you have in asp.net (core or otherwise), the Yeoman approach is a pain as you end up with 2 web servers and then you have preflight/CORS issues to deal with. It would be good to have a github repro, or section about how to integrate with an existing .Net web project.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

closed time in 2 months

yowl

issue commentOfficeDev/office-js-docs-pr

Improve documentation for working with existing .Net web project

I'm going to close this issue for now, but wanted to let you know that your feedback has passed on! Thank you.

yowl

comment created time in 2 months

issue commentOfficeDev/office-js-docs-pr

Unclear documentation on shared runtimes and mulitple taskpanes

@lliu113, can you have a look at this? Thanks

naterush

comment created time in 2 months

issue commentOfficeDev/office-js-docs-pr

Loading Office add-in which has equivalent COM add-in, custom functions names appear without namespace

Transferring to CFs repo, as I just want to verify the behavior expectations. I don't think this is expected, but @RuoyingLiang would you know?

sshukurov

comment created time in 2 months

push eventOfficeDev/office-js-docs-pr

Alison McKay

commit sha 080febf4b32aa5de1bcf39e07ad7f0499f379299

[all](ToC) TOC update ideas (#2057) * TOC update ideas * Simplify TOC label * Make dev terms in ToC more consistent Co-authored-by: Elizabeth Samuel <elizs@microsoft.com> * Make dev terms in ToC more consistent Co-authored-by: Elizabeth Samuel <elizs@microsoft.com> * docs/toc.yml, make TOC title more concise Co-authored-by: Michelle Scharlock <mischarl@microsoft.com> * docs/toc.yml, make TOC title more concise Co-authored-by: Michelle Scharlock <mischarl@microsoft.com> * docs/toc.yml, make new titles grammatically consistent * carry new beginner and VSTO transition titles through articles Co-authored-by: Elizabeth Samuel <elizs@microsoft.com> Co-authored-by: Michelle Scharlock <mischarl@microsoft.com>

view details

Elizabeth Samuel

commit sha b67f6ec2a9ba2598708024fd3be0fee4072a6464

[Outlook] (on send) Describe workaround to prevent editing the item (#2086)

view details

Elizabeth Samuel

commit sha 7c006ee7809ee9e3349f862a25ef7f6110bcd007

[Outlook] (recurrence) Add example of how to change recurrence (#2099)

view details

Elizabeth Samuel

commit sha cdf6e3c76491b11f9bc03be07b455d75fc87c647

[Outlook] (event-based) Note add-in doesn't activate on edit (#2098)

view details

Elizabeth Samuel

commit sha e1bf786030ceb8dda6d401dfb98791e88f977295

[Outlook] (IRM) Add-ins work with digitally signed messages (#2100) * [Outlook] (IRM) Add-ins work with digitally signed messages * Update date

view details

Alex Jerabek

commit sha e392c5c24420b493db36cda1b6af7dc620110cec

Remove warning about onSelectionChanged behavior (#2102)

view details

Michelle Scharlock

commit sha 16c7f60c4cf51485cafaa280f6f9e62736ff025a

[Deployment][Update document on publishing in VSC to include Azure instructions] (#2069)

view details

AlexJerabek

commit sha 3f2b6b1e3a717557c0abdf9af56f4cf55037a8ea

Merging

view details

Michelle Scharlock

commit sha abc73c2d6e64ee5b1f2236bacd4cf43a0ad91653

Merge branch 'HackTOC' into michelle-tocvsto

view details

push time in 2 months

PullRequestReviewEvent

Pull request review commentOfficeDev/office-js-docs-pr

[TOC][Put VSTO in a top level node]

  - name: Patterns and practices   items:-  - name: Share code from VSTO Add-in to Office add-in-    href: tutorials/migrate-vsto-to-office-add-in-shared-code-library-tutorial.md   - name: Batching custom function remote calls     href: excel/custom-functions-batching.md     displayName: Excel, Custom Functions   - name: Authentication     href: develop/authentication-pnp.md   - name: Handle high DPI and DPI scaling in your Office solution     href: /office/client-developer/ddpi/handle-high-dpi-and-dpi-scaling-in-your-office-solution++- name: VSTO transition resources+  items: +    - name: VSTO add-in developers' guide+      href: overview/learning-path-transition.md+    - name: Share code from VSTO Add-in to Office add-in+      href: tutorials/migrate-vsto-to-office-add-in-shared-code-library-tutorial.md+    - name: Identify an equivalent COM add-in

Yep, came from some other node that dealt with generic concepts or something

mscharlock

comment created time in 2 months

push eventOfficeDev/office-js-docs-pr

Michelle Scharlock

commit sha 16c7f60c4cf51485cafaa280f6f9e62736ff025a

[Deployment][Update document on publishing in VSC to include Azure instructions] (#2069)

view details

push time in 2 months

Pull request review commentOfficeDev/office-js-docs-pr

[Deployment][Update document on publishing in VSC to include Azure instructions]

 This article describes how to publish an Office Add-in that you created using th  ## Publishing an add-in for other users to access -[!include[instructions for publishing an Office Add-in](../includes/publish-add-in.md)]+An Office Add-in consists of a web application and a manifest file. The web application defines the add-in's user interface and functionality, while the manifest specifies the location of the web application and defines settings and capabilities of the add-in.++While you're developing your add-in, you can run the add-in on your local web server (`localhost`), but when you're ready to publish it for other users to access, you'll need to deploy the web application and update the manifest to specify the URL of the deployed application.++When your add-in is working as desired, you can publish it directly through Visual Studio Code using the Azure Storage extension.++## Using Visual Studio Code to publish++1. Open your project from its root folder in VS (Visual Studio) Code.+2. From the Extensions view in VS Code, search for the Azure Storage extension and install it.+3. Once installed, an Azure icon will be added to the Activity Bar. Select it to access the extension. If your Activity Bar is hidden, you won't be able to access the extension. Show the Activity Bar by selecting **View > Appearance > Show Activity Bar**.+4. When in the extension, sign in to your Azure account by selecting **Sign in to Azure**. You can also create an Azure account if you don't already have one by selecting **Create a free Azure account**. Follow the provided steps to set up your account.+5. Once you have signed in to your Azure account, you'll see your Azure storage accounts appear in the extension. If you don't already have a storage account, you'll need to create one using the **Create new storage account** option. Name your storage account a globally unique name, using only 'a-z' and '0-9'. Note that by default, this creates a storage account and a resource group with the same name. It automatically puts the storage account in West US. This can be adjusted online through [your Azure account](https://portal.azure.com/).

I can't see a difference here so just marking as resolved.

mscharlock

comment created time in 2 months

PullRequestReviewEvent

push eventOfficeDev/office-js-docs-pr

Michelle Scharlock

commit sha 53cd6b678642d3822d0c15991a6dab0865af704c

Apply suggestions from code review Co-authored-by: Linda Lu Cannon <lindalu@microsoft.com>

view details

push time in 2 months

push eventOfficeDev/office-js-docs-pr

mscharlock

commit sha 6b2e8ba6d794c0d16eb24a89ab95bca85ba590a2

apply some changes from feedback

view details

push time in 2 months

push eventOfficeDev/office-js-docs-pr

Alex Jerabek

commit sha 876082c04c452705d0ede538eab231a2f3ace164

[all] (Host-specific APIs) Create a host-specific API model page (#2046) * Initial file * Start of general Rich API doc * Complete Promise-based page * Adding connections * Switch to JS code * Update docs/develop/host-specific-api-model.md Co-authored-by: Elizabeth Samuel <elizs@microsoft.com> * Update docs/develop/host-specific-api-model.md Co-authored-by: Elizabeth Samuel <elizs@microsoft.com> * Update docs/develop/host-specific-api-model.md Co-authored-by: Elizabeth Samuel <elizs@microsoft.com> * Update docs/includes/office-js-api-models.md Co-authored-by: Elizabeth Samuel <elizs@microsoft.com> * Update docs/develop/host-specific-api-model.md Co-authored-by: Elizabeth Samuel <elizs@microsoft.com> Co-authored-by: Elizabeth Samuel <elizs@microsoft.com>

view details

Alex Jerabek

commit sha 4825e99b1a940a56e16463407468b17f14e35c94

[all] (Host-specific APIs) Referencing the host-specific page and removing duplicate content (#2050) * Fix OrNullObject text * Rewrite Excel ref overview * Add unbounded range content to range article * Added object model * More host-specific model links * Fix relative links * Remove Excel advanced concepts file * Fix links * References from other hosts * Add Michelle's feedback from PR #2046 * Update docs/excel/excel-add-ins-conditional-formatting.md Co-authored-by: Elizabeth Samuel <elizs@microsoft.com> * Update docs/excel/excel-add-ins-ranges-advanced.md Co-authored-by: Elizabeth Samuel <elizs@microsoft.com> * Update docs/excel/excel-add-ins-ranges.md Co-authored-by: Elizabeth Samuel <elizs@microsoft.com> * Fragment feedback * Update docs/reference/overview/excel-add-ins-reference-overview.md Co-authored-by: Alison McKay <almckay@microsoft.com> * Update docs/excel/excel-add-ins-ranges.md Co-authored-by: Alison McKay <almckay@microsoft.com> * Update docs/reference/requirement-sets/excel-api-1-4-requirement-set.md Co-authored-by: Alison McKay <almckay@microsoft.com> * Update docs/word/word-add-ins-programming-overview.md Co-authored-by: Alison McKay <almckay@microsoft.com> * Update docs/excel/excel-add-ins-core-concepts.md Co-authored-by: Alison McKay <almckay@microsoft.com> * Update docs/excel/excel-add-ins-core-concepts.md Co-authored-by: Alison McKay <almckay@microsoft.com> * Adding Elizabeth's feedback from PR #2046 * Update docs/develop/host-specific-api-model.md Co-authored-by: Elizabeth Samuel <elizs@microsoft.com> * Update docs/develop/host-specific-api-model.md Co-authored-by: Elizabeth Samuel <elizs@microsoft.com> * Update docs/excel/excel-add-ins-core-concepts.md Co-authored-by: Elizabeth Samuel <elizs@microsoft.com> * Update docs/excel/excel-add-ins-core-concepts.md Co-authored-by: Elizabeth Samuel <elizs@microsoft.com> * Update docs/excel/excel-add-ins-ranges.md Co-authored-by: Elizabeth Samuel <elizs@microsoft.com> * Update docs/excel/excel-add-ins-ranges.md Co-authored-by: Elizabeth Samuel <elizs@microsoft.com> * Update docs/excel/excel-add-ins-ranges.md Co-authored-by: Elizabeth Samuel <elizs@microsoft.com> * Update docs/reference/requirement-sets/excel-api-1-4-requirement-set.md Co-authored-by: Elizabeth Samuel <elizs@microsoft.com> * Apply suggestions from code review Co-authored-by: Elizabeth Samuel <elizs@microsoft.com> * Fixing double hash Co-authored-by: Elizabeth Samuel <elizs@microsoft.com> Co-authored-by: Alison McKay <almckay@microsoft.com>

view details

Alison McKay

commit sha 75aa42b8758b17e238479c3a45583e88d21fef78

Fix two typos

view details

Alex Jerabek

commit sha 8988c59ece863de35d19ccb5d576029b3fdc0da5

[all] (Performance) Move host-specific API perf tips up from the Excel article (#2051) * Move host-specific performance information up from the Excel level * Fix link * Moving Excel data limits section to more global location * Better cross linking to new perf article sections * Fix links * Correct bookmark * Apply suggestions from code review Co-authored-by: Elizabeth Samuel <elizs@microsoft.com> Co-authored-by: Alison McKay <almckay@microsoft.com> * Applying feedback Co-authored-by: Elizabeth Samuel <elizs@microsoft.com> Co-authored-by: Alison McKay <almckay@microsoft.com>

view details

Alex Jerabek

commit sha 22c879bf4bebaa4a03b13327292152cd1d05cd1e

[admin] (TOC) Removing ambiguous "Develop" subheaders (#2055) * Adding Plan node * Remove Concepts * Moving UI UX section * Removing How-To * Fix TOC typo * Further organization * Move perf under Testing * Moving Add-in commands back under UI * Add plan entry to concepts overview * Fix SVG

view details

AlexJerabek

commit sha 9e518c0fe89edc6470b31559db19e2e29204b700

Remove duplicate display name

view details

Alison McKay

commit sha 1509d615dad875fd9fe60b6343574dcfc191cf92

[all] (index.yaml) Adding links to main landing page (#2058) * Define quick start, tutorial in landing page intro, link to MS Learn * Fix schema validation error * Fix schema validation error, round 2 * Add MS Learn links to main landing page * Update MS Learn links on landing page * Fix schema validation error * Remove language encoding from MS learn links * Change title on landing page to distinguish from sidebar * switch to relative link Co-authored-by: Alex Jerabek <38896772+AlexJerabek@users.noreply.github.com> * switch to relative link Co-authored-by: Alex Jerabek <38896772+AlexJerabek@users.noreply.github.com> * Switch order of Learn/Overview per feedback * Remove new intro content due to schema limitations Co-authored-by: Alex Jerabek <38896772+AlexJerabek@users.noreply.github.com>

view details

Alex Jerabek

commit sha 775b9b604c93f753c902600d008ea3f7085a0d57

[admin] (Term change) Change "host" to "application" in the context of an Office client hosting an add-in. (#2062) * Host -> Application * Rename file * More host to application changes * Fix anchor * Apply suggestions from code review Co-authored-by: Alison McKay <almckay@microsoft.com> * Mass title change * Apply suggestions from code review Co-authored-by: Elizabeth Samuel <elizs@microsoft.com> Co-authored-by: Alison McKay <almckay@microsoft.com> * Replace capitalization * Revert error code page changes * Removing typos * Switch to suspected correct error code Co-authored-by: Alison McKay <almckay@microsoft.com> Co-authored-by: Elizabeth Samuel <elizs@microsoft.com>

view details

AlexJerabek

commit sha 72e65ca662137c77356a33e3cfdef95d363880a8

Merging

view details

Michelle Scharlock

commit sha 3e670c417d5d22ac86b27b21aea10e9f837d2320

Merge branch 'HackTOC' into michelle-tocvsto

view details

push time in 2 months

create barnchOfficeDev/office-js-docs-pr

branch : michelle-tocvsto

created branch time in 2 months

Pull request review commentOfficeDev/office-js-docs-pr

[all](ToC) TOC update ideas

     href: overview/set-up-your-dev-environment.md     displayName: Excel, Word, OneNote, Project, PowerPoint, Outlook -- name: Core concepts+- name: Development process

Is it weird to have "Dev process overview" and then "Dev process" underneath it? Curious on your opinion on this one :)

alison-mk

comment created time in 2 months

Pull request review commentOfficeDev/office-js-docs-pr

[all](ToC) TOC update ideas

  - name: Get started   items:-  - name: Start Here! A guide for beginners+  - name: A guide for beginners     href: overview/learning-path-beginner.md     displayName: develop-  - name: Transition Here! A guide for VSTO add-in developers+  - name: A guide for VSTO add-in developers
  - name: VSTO add-in developers guide
alison-mk

comment created time in 2 months

Pull request review commentOfficeDev/office-js-docs-pr

[all](ToC) TOC update ideas

  - name: Get started   items:-  - name: Start Here! A guide for beginners+  - name: A guide for beginners
  - name: Beginners' guide
alison-mk

comment created time in 2 months

pull request commentOfficeDev/office-js-docs-pr

[Deployment][Update document on publishing in VSC to include Azure instructions]

@Rick-Kirkham Good plan, that totally makes sense.

mscharlock

comment created time in 2 months

pull request commentOfficeDev/office-js-docs-pr

[Deployment][Update document on publishing in VSC to include Azure instructions]

Just an FYI v2 might be to include more pics to this so it's a bit easier to figure out where the various bits and pieces live in VSC (like the Azure icon etc)

mscharlock

comment created time in 2 months

delete branch OfficeDev/office-js-docs-pr

delete branch : michelle-ie11quickfix

delete time in 2 months

push eventOfficeDev/office-js-docs-pr

Michelle Scharlock

commit sha ad873951b561bc03ed25add2f43ea1b785f9fdd8

[Add-ins][Shared Runtime] Making sure a note about IE11 is prominent (#2088)

view details

push time in 2 months

PR merged OfficeDev/office-js-docs-pr

[Add-ins][Shared Runtime] Making sure a note about IE11 is prominent

We originally had left this info just in the Runtimes element but apparently nobody is finding it so now I put it all over the place!

+15 -9

3 comments

5 changed files

mscharlock

pr closed time in 2 months

pull request commentOfficeDev/office-js-docs-pr

[Add-ins][Shared Runtime] Making sure a note about IE11 is prominent

Ok, FYI I am gonna pull this in - have addressed things and just want this to get out to customers ASAP. Let me know if you have any other concerns :)

mscharlock

comment created time in 2 months

push eventOfficeDev/office-js-docs-pr

mscharlock

commit sha 979b7d61a2533c1c2126bf09c6244b9bbf5c4264

apply feedback

view details

push time in 2 months

PR opened OfficeDev/office-js-docs-pr

Reviewers
[Add-ins][Shared Runtime] Making sure a note about IE11 is prominent

We originally had left this info just in the Runtimes element but apparently nobody is finding it so now I put it all over the place!

+13 -7

0 comment

5 changed files

pr created time in 2 months

push eventOfficeDev/office-js-docs-pr

mscharlock

commit sha a2c33f7c5c12b29308c0149af64345da556642ab

add date

view details

push time in 2 months

push eventOfficeDev/office-js-docs-pr

mscharlock

commit sha 179a4352c2412bffc0b25d42eee3c684b67951f8

adding in a few more spots

view details

mscharlock

commit sha d2bcc44a124fa842574b6364ad930e7cf5833c7f

putting this note in even more places

view details

push time in 2 months

push eventOfficeDev/office-js-docs-pr

mscharlock

commit sha 455519b5f1b4a0753f8f7706903cc2ee4781c06e

update language

view details

push time in 2 months

create barnchOfficeDev/office-js-docs-pr

branch : michelle-ie11quickfix

created branch time in 2 months

pull request commentOfficeDev/office-js-docs-pr

[all](ToC) TOC update ideas

Out of curiosity, @AlexJerabek can you integrate a pr in here about the VSTO/COM stuff in one top level node? I am hoping that I can link to this on the new portal page, to make this more exposed.

alison-mk

comment created time in 2 months

push eventOfficeDev/office-js-docs-pr

mscharlock

commit sha 3bd7dd59a810af445661cfa4ecab7f3d90e2e989

fixes

view details

push time in 2 months

push eventOfficeDev/office-js-docs-pr

mscharlock

commit sha adb9e02aab8720d382496c1c05c9744acb543a3c

image links obvs

view details

mscharlock

commit sha c18274d77d5a64182d9812a1a8731ea59fd89207

Merge branch 'michelle-aaddeploy' of https://github.com/OfficeDev/office-js-docs-pr into michelle-aaddeploy

view details

push time in 2 months

push eventOfficeDev/office-js-docs-pr

Michelle Scharlock

commit sha a54554b44fac0170df032af2c2ba536ce2e14122

Update docs/publish/publish-add-in-vs-code.md Co-authored-by: Elizabeth Samuel <elizs@microsoft.com>

view details

push time in 2 months

push eventOfficeDev/office-js-docs-pr

Michelle Scharlock

commit sha b5d5682301013632479a6a9683a47bde7710f87b

Update docs/publish/publish-add-in-vs-code.md

view details

push time in 2 months

Pull request review commentOfficeDev/office-js-docs-pr

[Deployment][Update document on publishing in VSC to include Azure instructions]

 This article describes how to publish an Office Add-in that you created using th > [!NOTE] > For information about publishing an Office Add-in that you created using Visual Studio, see [Publish your add-in using Visual Studio](package-your-add-in-using-visual-studio.md). +## Publishing pre-requisites++An Office Add-in consists of a web application and a manifest file. The web application defines the add-in's user interface and functionality, while the manifest specifies the location of the web application and defines settings and capabilities of the add-in.++While you're developing your add-in, you can run the add-in on your local web server (`localhost`), but when you're ready to publish it for other users to access, you'll need to deploy the web application and update the manifest to specify the URL of the deployed application.++When your add-in is working as desired and you're ready to publish it for other users to access, ensure you have the following pre-requisites:++- An [Azure account](https://azure.microsoft.com/free/). You can start one for free if you don't already have an account.+- An Azure storage account. If you need to set one up after creating your Azure account, do so using instructions in [Create an Azure Storage Account](https://docs.microsoft.com/azure/developer/javascript/tutorial-vscode-static-website-node-03).+ ## Publishing an add-in for other users to access -[!include[instructions for publishing an Office Add-in](../includes/publish-add-in.md)]+1. Open your browser and navigate to https://portal.azure.com/, then select **Storage accounts**. You will see your storage accounts. Select the one you would like to use for your add-in.++2. On this same page under the settings menu, choose the **Static website** option. You'll notice **Index document name** and **Error document path** are pre-populated with the filename index.html. Change both fields from index.html to **taskpane.html**. Next, copy the **primary endpoint** URL that you did not change.++![Static website settings in Azure](static-website-in-azure.png)++3. Open your project from it's root folder in VS Code. Next, open your project's manifest file (`manifest.xml`) and change any reference to your localhost URL (such as https://localhost:3000) to the primary endpoint information you've copied. This endpoint is the static website URL for your newly created storage account. Save the changes you've made to your manifest file.++4. Open a command line prompt. From the command line, navigate to the root directory of your add-in project. Then run the following command to prepare all files for production deployment:++    ```command&nbsp;line+    npm run build+    ```++    When the build completes, the **dist** folder in the root directory of your add-in project will contain the files that you'll deploy in subsequent steps.++5. Next go to the **Azure Storage** explorer in VS Code, expand your subscription, and expand the node for the Azure Storage account that you created in the previous step. Expand the **Blob Containers** node. The $web container is where you deploy your app code.++![Storage nodes listed in the Blob Containers node](azure-storage-container.png)++6. To deploy, select the Files explorer, right-click on your **dist** folder, and choose **Deploy to Static Website**. When prompted, select the storage account you created previously.

Yeah I had the same thought, although I have had this discussion about a year ago with the VSC folks who write their docs. Their perspective is that this is ok which is odd to me. I guess the alternative is "select and hold (or right click)" which might be more in line with our philosophy

mscharlock

comment created time in 2 months

Pull request review commentOfficeDev/office-js-docs-pr

[Deployment][Update document on publishing in VSC to include Azure instructions]

 This article describes how to publish an Office Add-in that you created using th > [!NOTE] > For information about publishing an Office Add-in that you created using Visual Studio, see [Publish your add-in using Visual Studio](package-your-add-in-using-visual-studio.md). +## Publishing pre-requisites++An Office Add-in consists of a web application and a manifest file. The web application defines the add-in's user interface and functionality, while the manifest specifies the location of the web application and defines settings and capabilities of the add-in.++While you're developing your add-in, you can run the add-in on your local web server (`localhost`), but when you're ready to publish it for other users to access, you'll need to deploy the web application and update the manifest to specify the URL of the deployed application.++When your add-in is working as desired and you're ready to publish it for other users to access, ensure you have the following pre-requisites:++- An [Azure account](https://azure.microsoft.com/free/). You can start one for free if you don't already have an account.+- An Azure storage account. If you need to set one up after creating your Azure account, do so using instructions in [Create an Azure Storage Account](/azure/developer/javascript/tutorial-vscode-static-website-node-03).+ ## Publishing an add-in for other users to access -[!include[instructions for publishing an Office Add-in](../includes/publish-add-in.md)]+1. Open your browser and navigate to https://portal.azure.com/, then select **Storage accounts**. You will see your storage accounts. Select the one you would like to use for your add-in.++2. On this same page under the settings menu, choose the **Static website** option. You'll notice **Index document name** and **Error document path** are pre-populated with the filename index.html. Change both fields from index.html to **taskpane.html**. Next, copy the **primary endpoint** URL that you did not change.++![Static website settings in Azure](static-website-in-azure.png)++3. Open your project from it's root folder in VS Code. Next, open your project's manifest file (`manifest.xml`) and change any reference to your localhost URL (such as https://localhost:3000) to the primary endpoint information you've copied. This endpoint is the static website URL for your newly created storage account. Save the changes you've made to your manifest file.++4. Open a command line prompt. From the command line, navigate to the root directory of your add-in project. Then run the following command to prepare all files for production deployment:++    ```command&nbsp;line+    npm run build+    ```++    When the build completes, the **dist** folder in the root directory of your add-in project will contain the files that you'll deploy in subsequent steps.++5. Next go to the **Azure Storage** explorer in VS Code, expand your subscription, and expand the node for the Azure Storage account that you created in the previous step. Expand the **Blob Containers** node. The $web container is where you deploy your app code.++![Storage nodes listed in the Blob Containers node](azure-storage-container.png)++6. To deploy, select the Files explorer, right-click on your **dist** folder, and choose **Deploy to Static Website**. When prompted, select the storage account you created previously.
6. To deploy, select the Files explorer, select and hold (right-click) on your **dist** folder, and choose **Deploy to Static Website**. When prompted, select the storage account you created previously.
mscharlock

comment created time in 2 months

push eventOfficeDev/office-js-docs-pr

Michelle Scharlock

commit sha 5601dff7f40545529145e2a2cc877f154ec093c6

Apply suggestions from code review Co-authored-by: Elizabeth Samuel <elizs@microsoft.com>

view details

push time in 2 months

Pull request review commentOfficeDev/office-js-docs-pr

[Deployment][Update document on publishing in VSC to include Azure instructions]

 This article describes how to publish an Office Add-in that you created using th > [!NOTE] > For information about publishing an Office Add-in that you created using Visual Studio, see [Publish your add-in using Visual Studio](package-your-add-in-using-visual-studio.md). +## Publishing pre-requisites++An Office Add-in consists of a web application and a manifest file. The web application defines the add-in's user interface and functionality, while the manifest specifies the location of the web application and defines settings and capabilities of the add-in.++While you're developing your add-in, you can run the add-in on your local web server (`localhost`), but when you're ready to publish it for other users to access, you'll need to deploy the web application and update the manifest to specify the URL of the deployed application.++When your add-in is working as desired and you're ready to publish it for other users to access, ensure you have the following pre-requisites:++- An [Azure account](https://azure.microsoft.com/free/). You can start one for free if you don't already have an account.+- An Azure storage account. If you need to set one up after creating your Azure account, do so using instructions in [Create an Azure Storage Account](https://docs.microsoft.com/azure/developer/javascript/tutorial-vscode-static-website-node-03).+ ## Publishing an add-in for other users to access -[!include[instructions for publishing an Office Add-in](../includes/publish-add-in.md)]+1. Open your browser and navigate to https://portal.azure.com/, then select **Storage accounts**. You will see your storage accounts. Select the one you would like to use for your add-in.++2. On this same page under the settings menu, choose the **Static website** option. You'll notice **Index document name** and **Error document path** are pre-populated with the filename index.html. Change both fields from index.html to **taskpane.html**. Next, copy the **primary endpoint** URL that you did not change.++![Static website settings in Azure](static-website-in-azure.png)

I'm gonna commit to see if these work, will fix if that doesn't fix it

mscharlock

comment created time in 2 months

push eventOfficeDev/office-js-docs-pr

Michelle Scharlock

commit sha c6e9f3aa128789027a82cb070224c9b51e539a61

Update docs/publish/publish-add-in-vs-code.md Co-authored-by: Elizabeth Samuel <elizs@microsoft.com>

view details

push time in 2 months

create barnchOfficeDev/office-js-docs-pr

branch : michelle-addpublishmethod

created branch time in 3 months

create barnchOfficeDev/office-js-docs-pr

branch : michelle-aaddeploy

created branch time in 3 months

push eventOfficeDev/office-store-docs

mscharlock

commit sha 177a389ea119e35e8b22562c1bc64e1ac14d36a7

minor tweaks

view details

push time in 3 months

push eventOfficeDev/office-store-docs

mscharlock

commit sha 173bc6f155333b0032ec455d1d813add90cab245

various small fixes

view details

push time in 3 months

push eventOfficeDev/office-store-docs

mscharlock

commit sha 52625c194b454c33e930a8e5d9f0af63c27d996c

fix links, fix mention of above

view details

push time in 3 months

push eventOfficeDev/office-store-docs

mscharlock

commit sha b79dfc9377917fbf1c2f39e3525d3dd9de759d9b

update links

view details

push time in 3 months

push eventOfficeDev/office-store-docs

mscharlock

commit sha 369aac431cd5b28c0332c99a7162ab896efb31fa

fix toc problem

view details

push time in 3 months

push eventOfficeDev/office-store-docs

mscharlock

commit sha 0eaa3015cd067776a1bd67d92a0572b17e47e458

experiment with toc

view details

push time in 3 months

push eventOfficeDev/office-store-docs

mscharlock

commit sha 22586eceb25aabdcabf249d5da3dca02298caeb5

fix typos

view details

push time in 3 months

more