profile
viewpoint

mrmonday/find-cmdlet 3

A search engine for PowerShell. Source code for https://find-cmdlet.com/

mrmonday/bitrust 2

A list of breaking changes in rust-lang/rust

mrmonday/j2d 2

A Java to D source code translator

mrmonday/misc 2

Miscellaneous things

mrmonday/d-programming-language.org 1

Pages for the d-programming-language.org web site

mrmonday/dmd 1

dmd D Programming Language compiler

mrmonday/druntime 1

Low level runtime library for the D programming language

mrmonday/DustMite 1

D test case minimization tool

mrmonday/full-circle-notifier 1

Notifier application for Full Circle Magazine

mrmonday/html5test 1

How well does your browser support HTML5? Interested in the next version of this test? Try http://beta.html5test.com

issue commentlibpnet/libpnet

Travis not running

Don't know why it wasn't triggered - I closed and re-opened all recent PRs where Travis wasn't triggered, it seems to be running now.

pheki

comment created time in 14 days

PullRequestEvent

PR closed libpnet/libpnet

Update ipnetwork requirement from 0.16.0 to 0.17.0 dependencies

Updates the requirements on ipnetwork to permit the latest version. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/achanda/ipnetwork/releases">ipnetwork's releases</a>.</em></p> <blockquote> <h2>Release v0.17.0</h2> <p>Please download from crates.io</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/achanda/ipnetwork/commit/0b98eecf6abeb48e995d46a1c2b450e8fb19972c"><code>0b98eec</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/achanda/ipnetwork/issues/134">#134</a> from achanda/v0.17.0</li> <li><a href="https://github.com/achanda/ipnetwork/commit/6c6bdb333d6b6bb3935afe1b9dcd076b8d88ca89"><code>6c6bdb3</code></a> Cut a new release</li> <li><a href="https://github.com/achanda/ipnetwork/commit/eded5f13a9de924c02d0dae78475904b424ad56c"><code>eded5f1</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/achanda/ipnetwork/issues/133">#133</a> from jethrogb/patch-1</li> <li><a href="https://github.com/achanda/ipnetwork/commit/1d4665dfe64e828ddf612c7a52d278a65bbd392e"><code>1d4665d</code></a> Update serde version</li> <li><a href="https://github.com/achanda/ipnetwork/commit/e80eab0c80a0eef2be09d434ad5171d589951854"><code>e80eab0</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/achanda/ipnetwork/issues/131">#131</a> from tshepang/patch-1</li> <li><a href="https://github.com/achanda/ipnetwork/commit/8f1c6b59bb1b8064c1cc9c2c13faae34a451b4ec"><code>8f1c6b5</code></a> Update README.md</li> <li><a href="https://github.com/achanda/ipnetwork/commit/a9f4547c828b3f0a5a106ac55df4537544ed7502"><code>a9f4547</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/achanda/ipnetwork/issues/128">#128</a> from achanda/dual-license</li> <li><a href="https://github.com/achanda/ipnetwork/commit/fa128680b51fbcf9c37db99f011c91204c4a3b0d"><code>fa12868</code></a> Dual license this project</li> <li><a href="https://github.com/achanda/ipnetwork/commit/620ec4d42cf968a2a29de3cd2c37bc8013ec590f"><code>620ec4d</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/achanda/ipnetwork/issues/123">#123</a> from achanda/bench-speedup</li> <li><a href="https://github.com/achanda/ipnetwork/commit/b6397ca2bc3b72f04147bc4fe2d608a53927dc25"><code>b6397ca</code></a> Isolate the contains call in bench</li> <li>Additional commits viewable in <a href="https://github.com/achanda/ipnetwork/compare/v0.16.0...v0.17.0">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+1 -1

0 comment

1 changed file

dependabot-preview[bot]

pr closed time in 14 days

PR closed libpnet/libpnet

Fix undefined behavior in packet field setters

It is currently possible to trigger undefined behavior in field setters created by the packet macro, such as MutableIpv4Packet::set_payload, by setting a buffer larger than the remaining space in the packet buffer.

Fix this by replacing the unsafe copy_nonoverlapping call with copy_from_slice. This function still compiles to memcpy, but includes a range check which which will panic if the destination buffer is too small.

Fixes #449. Fixes #411.

+27 -8

1 comment

2 changed files

tdryer

pr closed time in 14 days

PullRequestEvent

PR closed libpnet/libpnet

Re-add serde support to NetworkInterface

In #255, the ipnetwork crate was added. IpNetwork did not yet support Serde, so (de)serialization support using such had to be removed.

As of https://github.com/achanda/ipnetwork/commit/c9e25e15fa0d0be3060bed2e38a86d5717d9c76b, IpNetwork includes feature-gated serde support

This snippet did not function prior to my changes, but seems to function fine after re-implementing serde support for IpNetwork

pub fn get_network_interfaces() -> anyhow::Result<Value> {
    let raw_interfaces: Vec<NetworkInterface> = interfaces();
    Ok(json!(raw_interfaces))
}

Result:

[{"flags":65609,"index":1,"ips":["127.0.0.1/8","::1/128"],"mac":"00:00:00:00:00:00","name":"lo"},{"flags":69699,"index":2,"ips":["10.10.0.211/24","fe80::a9d:7071:53a:3da1/64"],"mac":"08:62:66:45:70:18","name":"eno1"},{"flags":4099,"index":3,"ips":["172.17.0.1/16"],"mac":"02:42:91:88:fa:1e","name":"docker0"}]

I understand there was question as to whether this feature was useful, but it seems appropriate to enable it in this case, especially since it is now supported upstream, and requires minimal effort in terms of maintenance for this repository (as far as I understand).

+12 -1

1 comment

3 changed files

evanjs

pr closed time in 14 days

PullRequestEvent
PullRequestReviewEvent

issue openedmozilla-mobile/fenix

[Bug] Videos with playbackRate > 1 have robotic audio

Steps to reproduce

  1. Go to YouTube, select any video with speech
  2. Tap the settings cog, set the play back speed to anything greater than 1 (1.25x, 2x, etc)
  3. Speech will sound robotic/echoy

Expected behavior

Speech should sound fast, not robotic.

Actual behavior

Speech sounds robotic/echoy.

Device information

  • Android device: Samsung Galaxy S9+ (SM-G965F)
  • Fenix version: 79.0.5 (Build #2015758619) AC: 48.0.15, 8755ac0cd GV: 79.0.1-20200813192915 AS: 61.0.10

This worked correctly with the previous (non-Fenix) version of Firefox for Android.

created time in 2 months

issue openeddotnet/SqlClient

Native libraries not loaded in C# interactive

Using the following project (SqlClientInteractive.csproj):

<?xml version="1.0" encoding="utf-8"?>
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFramework>net48</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.Data.SqlClient" Version="2.0.0" />
  </ItemGroup>
</Project>

Code (Conn.cs):

using System;
using Microsoft.Data.SqlClient;
//using System.Data.SqlClient;

namespace SqlClientInteractive
{
    public class Conn
    {
        public static void Open()
        {
            try
            {
                var conn = new SqlConnection("Data Source=zzzzzzzzzzzz; Connection Timeout=1");
                conn.Open();
            }
            catch (SqlException)
            {
            }
        }
    }
}

In Visual Studio (tested with 2019, v16.6.5), right click the project, then "Initialize Interactive with Project". Run Conn.Open().

Using System.Data.SqlClient, this works correctly.

When using Microsoft.Data.SqlClient, this gives the following exception:

> Conn.Open()
System.TypeInitializationException: The type initializer for 'Microsoft.Data.SqlClient.TdsParser' threw an exception.
  + Microsoft.Data.SqlClient.TdsParser..ctor(bool, bool)
  + Microsoft.Data.SqlClient.SqlInternalConnectionTds.LoginNoFailover(Microsoft.Data.SqlClient.ServerInfo, string, System.Security.SecureString, bool, Microsoft.Data.SqlClient.SqlConnectionString, Microsoft.Data.SqlClient.SqlCredential, Microsoft.Data.ProviderBase.TimeoutTimer)
  + Microsoft.Data.SqlClient.SqlInternalConnectionTds.OpenLoginEnlist(Microsoft.Data.ProviderBase.TimeoutTimer, Microsoft.Data.SqlClient.SqlConnectionString, Microsoft.Data.SqlClient.SqlCredential, string, System.Security.SecureString, bool)
  + Microsoft.Data.SqlClient.SqlInternalConnectionTds..ctor(Microsoft.Data.ProviderBase.DbConnectionPoolIdentity, Microsoft.Data.SqlClient.SqlConnectionString, Microsoft.Data.SqlClient.SqlCredential, object, string, System.Security.SecureString, bool, Microsoft.Data.SqlClient.SqlConnectionString, Microsoft.Data.SqlClient.SessionData, Microsoft.Data.SqlClient.ServerCertificateValidationCallback, Microsoft.Data.SqlClient.ClientCertificateRetrievalCallback, Microsoft.Data.ProviderBase.DbConnectionPool, string, Microsoft.Data.SqlClient.SqlClientOriginalNetworkAddressInfo, bool)
  + Microsoft.Data.SqlClient.SqlConnectionFactory.CreateConnection(Microsoft.Data.Common.DbConnectionOptions, Microsoft.Data.Common.DbConnectionPoolKey, object, Microsoft.Data.ProviderBase.DbConnectionPool, System.Data.Common.DbConnection, Microsoft.Data.Common.DbConnectionOptions)
  + Microsoft.Data.ProviderBase.DbConnectionFactory.CreatePooledConnection(Microsoft.Data.ProviderBase.DbConnectionPool, System.Data.Common.DbConnection, Microsoft.Data.Common.DbConnectionOptions, Microsoft.Data.Common.DbConnectionPoolKey, Microsoft.Data.Common.DbConnectionOptions)
  + Microsoft.Data.ProviderBase.DbConnectionPool.CreateObject(System.Data.Common.DbConnection, Microsoft.Data.Common.DbConnectionOptions, Microsoft.Data.ProviderBase.DbConnectionInternal)
  + Microsoft.Data.ProviderBase.DbConnectionPool.UserCreateRequest(System.Data.Common.DbConnection, Microsoft.Data.Common.DbConnectionOptions, Microsoft.Data.ProviderBase.DbConnectionInternal)
  + Microsoft.Data.ProviderBase.DbConnectionPool.TryGetConnection(System.Data.Common.DbConnection, uint, bool, bool, Microsoft.Data.Common.DbConnectionOptions, out Microsoft.Data.ProviderBase.DbConnectionInternal)
  + Microsoft.Data.ProviderBase.DbConnectionPool.TryGetConnection(System.Data.Common.DbConnection, TaskCompletionSource<Microsoft.Data.ProviderBase.DbConnectionInternal>, Microsoft.Data.Common.DbConnectionOptions, out Microsoft.Data.ProviderBase.DbConnectionInternal)
  + Microsoft.Data.ProviderBase.DbConnectionFactory.TryGetConnection(System.Data.Common.DbConnection, TaskCompletionSource<Microsoft.Data.ProviderBase.DbConnectionInternal>, Microsoft.Data.Common.DbConnectionOptions, Microsoft.Data.ProviderBase.DbConnectionInternal, out Microsoft.Data.ProviderBase.DbConnectionInternal)
  + Microsoft.Data.ProviderBase.DbConnectionInternal.TryOpenConnectionInternal(System.Data.Common.DbConnection, Microsoft.Data.ProviderBase.DbConnectionFactory, TaskCompletionSource<Microsoft.Data.ProviderBase.DbConnectionInternal>, Microsoft.Data.Common.DbConnectionOptions)
  + Microsoft.Data.SqlClient.SqlConnection.TryOpenInner(TaskCompletionSource<Microsoft.Data.ProviderBase.DbConnectionInternal>)
  + Microsoft.Data.SqlClient.SqlConnection.TryOpen(TaskCompletionSource<Microsoft.Data.ProviderBase.DbConnectionInternal>, Microsoft.Data.SqlClient.SqlConnectionOverrides)
  + Microsoft.Data.SqlClient.SqlConnection.Open(Microsoft.Data.SqlClient.SqlConnectionOverrides)
  + SqlClientInteractive.Conn.Open()

Debugging gives the following:

Inner Exception 1:
TypeInitializationException: The type initializer for 'Microsoft.Data.SqlClient.SNILoadHandle' threw an exception.

Inner Exception 2:
DllNotFoundException: Unable to load DLL 'Microsoft.Data.SqlClient.SNI.x64.dll': The specified module could not be found. (Exception from HRESULT: 0x8007007E)

As part of a larger test case, I am able to work around this with the following snippet - unfortunately this does not seem to work for the reduced test case as given here:

var assembly = System.Reflection.Assembly.GetAssembly(typeof(Microsoft.Data.SqlClient.SqlConnection));
var sqlClientDir = Path.GetDirectoryName(new Uri(assembly.Location).LocalPath);
var userProfile = Environment.GetFolderPath(Environment.SpecialFolder.UserProfile);
var nativeName = IntPtr.Size == 8 ? "Microsoft.Data.SqlClient.SNI.x64.dll" : "Microsoft.Data.SqlClient.SNI.x86.dll";
var nativeLocation = Path.Combine(userProfile, @".nuget\packages\microsoft.data.sqlclient.sni\2.0.0\build\net46\", nativeName);
File.Copy(nativeLocation, Path.Combine(sqlClientDir, nativeName));

The native library seems to be loaded correctly in web and console applications, but not in an interactive shell.

created time in 3 months

push eventmrmonday/find-cmdlet

Robert Clipsham

commit sha cd2b166efef7201cdafb2822140704568132e5c6

Add ansible stuff

view details

push time in 3 months

PublicEvent
more