profile
viewpoint
Marcus Weiner mraerino @netlify Cologne, Germany Engineer for the JAMstack

aergus/collectd-batman-adv 3

a batman-adv plugin for collectd

mraerino/cdn-static 2

A static file CDN hosted on Cloudflare Workers (+KV) and Wasabi

devops-nrw/homepage 1

Our meetup's little homepage. Please improve.

ffddorf/gluon-rfkill-disable 1

Gluon package to disable wifi onoff button

mraerino/awm-postfixadmin-change-password 1

AfterLogic WebMail Lite Password change plugin for systems utilising PostfixAdmin

aergus/u23-projekt-netzwerk-monitoring-slides 0

slides about a network monitoring project for a Freifunk network (in German, cf. collectd-batman-adv)

FactoryCampus/netbox 0

IP address management (IPAM) and data center infrastructure management (DCIM) tool.

Pull request review commentnetlify/open-api

add delete site to porcelain client

 vendor yarn.lock dist .vscode-.gobincache\ No newline at end of file+.gobincache+.idea/*

please put those into your global gitignore file, not in the repo. I know we have .vscode in there, but this should not prove as an example.

reed-acst

comment created time in a day

issue closednetlify/open-api

Missing DeleteSite on Porcelain Netlify client

I'm using Netlify client from porcelain package for site operations (create, deploy..). I want to implement site delete action (using site id), but I'm getting error type *porcelain.Netlify has no field or method DeleteSite. I tried adding DeleteSite method to site.go in porcelain package (using GetSite from Netlify client as a pattern) just to see would it work, and it did, site got deleted.

Are you planning on adding this method to Netlify client?


I did manage to make it work by calling Operations.DeleteSite on Netlify client, but I also had to import plumbing operations package in order to get NewDeleteSiteParams. Site gets deleted, but this just doesn't look like a preferred way of doing it.

import(
    netlify "github.com/netlify/open-api/go/porcelain"
    netlifyOperations "github.com/netlify/open-api/go/plumbing/operations"
)

func deleteNetlifySite(siteID string) {
    
    ...

    client := netlify.New(transport, strfmt.Default)
    resp, err := client.Operations.DeleteSite(netlifyOperations.NewDeleteSiteParams().WithSiteID(siteID), authInfo)
}

closed time in 2 days

Lanchi

issue commentnetlify/open-api

Missing DeleteSite on Porcelain Netlify client

this is not a missing method. the way pointed out by the issue creator is the expected way right now. if you want that as part of the lib, create a pull request, please.

Lanchi

comment created time in 2 days

issue commentgolang/go

x/tools/cmd/godoc: generate static docs

I wrote a small prototype that can output static html: https://github.com/netlify/godoc-static (not in any way complete, will try to write a blog post on it soon)

moraes

comment created time in 3 days

issue commentnetlify/git-gateway

cannot get files from netlifycms admin panel using Gitlab repo setup

If you provide more/better logs in any way, we can try to triage. I'm saying i cannot reproduce.

artemtech

comment created time in 6 days

pull request commentnetlify/netlify-commons

Bugsnag updates

Would this mean that every service that is using bugsnag now would need to change their config structure when upgrading netlify-commons?

mheffner

comment created time in 9 days

push eventnetlify/git-gateway

Erez Rokah

commit sha 54d55cd4c740a873d9925c31078c63009d01fd46

feat(gitlab): allow merge_requests, compare, branches APIs (#47) * feat(gitlab): allow merge_requests, compare, branches APIs * docs: fix readme * fix: update gitlab regex Co-Authored-By: Marcus Weiner <marcus.weiner@gmail.com> Co-authored-by: Marcus Weiner <marcus.weiner@gmail.com>

view details

push time in 10 days

PR merged netlify/git-gateway

feat(gitlab): allow merge_requests, compare, branches APIs

<!-- Thanks for submitting a pull request!

Please make sure you've read and understood our contributing guidelines; https://github.com/netlify/git-gateway/blob/master/CONTRIBUTING.md

If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx", where #xxxx is the issue number.

Please provide enough information so that others can review your pull request. The first three fields are mandatory: -->

- Summary

<!-- Explain the motivation for making this change. What existing problem does the pull request solve? -->

Required for Netlify CMS GitLab editorial workflow https://github.com/netlify/netlify-cms/pull/3014

- Test plan

Was able to test locally by setting local git-gateway and go-true instances and pointing the CMS to the local instances.

- Description for the changelog

<!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: -->

Added the relevant APIs to the gitlabAllowedRegexp regular expression and fixed the Readme

+7 -4

0 comment

2 changed files

erezrokah

pr closed time in 10 days

Pull request review commentnetlify/git-gateway

feat(gitlab): allow merge_requests, compare, branches APIs

 type GitLabGateway struct { }  var gitlabPathRegexp = regexp.MustCompile("^/gitlab/?")-var gitlabAllowedRegexp = regexp.MustCompile("^/gitlab/repository/(files|commits|tree)/?")+var gitlabAllowedRegexp = regexp.MustCompile("^/gitlab/merge_requests|(repository/(files|commits|tree|compare|branches))/?")
var gitlabAllowedRegexp = regexp.MustCompile("^/gitlab/(merge_requests|(repository/(files|commits|tree|compare|branches)))/?")

this is safer.

I don't like having a regex here at all, but we are not going to refactor this now i think.

erezrokah

comment created time in 10 days

push eventbio-routing/bio-rd

Marcus Weiner

commit sha 73d6fecc240ce76a0079a45722e1ef4efd52f0cb

Refactor decode test setup

view details

Marcus Weiner

commit sha a6a2efc82a8ce6de0f91d87d2553739479068650

Test encoding of hello packets

view details

push time in 10 days

push eventbio-routing/bio-rd

Marcus Weiner

commit sha 3187300d740d0b55902967345b0402e433cc9dc2

Split packet tests

view details

Marcus Weiner

commit sha 8652fdeb1371fe39e37afe41a0334e23af6cc97e

Refactor metric field

view details

Marcus Weiner

commit sha d657342422aec710d10805cd5aaea8655e3dea2c

Add helper to lsa prefix

view details

Marcus Weiner

commit sha c4c2ed5c580b74ca53ca1a298f524b7db4922a75

Extend LS update test

view details

push time in 11 days

push eventbio-routing/bio-rd

Marcus Weiner

commit sha 1c3aad8dd4ff4be538d5be7eddaccfb1d027fcf6

Simplify link state acknowledgement

view details

Marcus Weiner

commit sha 94e880b6fb477a1107917ba32e27c7854e9edaca

Test decoding link state acknowledgement

view details

push time in 11 days

startedretejs/rete

started time in 11 days

create barnchffddorf/supernodes-v2

branch : master

created branch time in 12 days

created repositoryffddorf/supernodes-v2

created time in 12 days

push eventffddorf/tunneldigger

Marcus Weiner

commit sha e24c4a5c48c886681a481693475476c7853beaf6

Ignore if chains exists when creating

view details

push time in 12 days

push eventffddorf/tunneldigger

Marcus Weiner

commit sha 836e37fa2652259106142114a7fd55e28fb3bd84

Fix container entrypoint

view details

push time in 12 days

push eventffddorf/tunneldigger

Marcus Weiner

commit sha e1d32b33a1fc8f10a5b8b3ac15e08242debcee5c

Configure docker command

view details

push time in 12 days

push eventffddorf/tunneldigger

Marcus Weiner

commit sha bd039d3218ccefd6dff83b5b0d58631b7182aa05

Build in docker

view details

push time in 12 days

pull request commentmk-fg/python-pulse-control

Implement sample play command

thanks for the really fast merge! are you going to do a release?

mraerino

comment created time in 12 days

delete branch mraerino/python-pulse-control

delete branch : feat/play-sample

delete time in 12 days

startedmk-fg/python-pulse-control

started time in 12 days

PR opened mk-fg/python-pulse-control

Implement sample play command

This exposes the c api command pa_context_play_sample from the library

the volume parameter is actually different than in other commands so I decided to always pass "keep volume".

+11 -1

0 comment

2 changed files

pr created time in 12 days

create barnchmraerino/python-pulse-control

branch : feat/play-sample

created branch time in 12 days

fork mraerino/python-pulse-control

Python high-level interface and ctypes-based bindings for PulseAudio (libpulse)

fork in 12 days

delete branch netlify/git-gateway

delete branch : chore/upgrade-sqlite

delete time in 15 days

push eventnetlify/git-gateway

Marcus Weiner

commit sha e7a09f2efc751b9b8d1623c93f0c768f4979ab42

Upgrade sqlite for macos compat (#46)

view details

push time in 15 days

PR merged netlify/git-gateway

Upgrade sqlite for macos compat

- Summary

On macOS the older sqlite lib uses some deprecated libc features. Upgrade to get rid of them in tests.

- Test plan

  • SQlite is only used in tests

- Description for the changelog

Upgrade Sqlite adapter

- A picture of a cute animal (not mandatory but encouraged)

+3 -1

1 comment

2 changed files

mraerino

pr closed time in 15 days

pull request commentnetlify/git-gateway

Upgrade sqlite for macos compat

The Go versioning scheme expects you to create a sub-package like v2 once your major version is above 1 (their idea of "no breaking changes"). Therefore, a dependency which goes above 1.x but is not using that subpackage is considered "incompatible". See https://blog.golang.org/v2-go-modules

mraerino

comment created time in 15 days

push eventnetlify/git-gateway

Erez Rokah

commit sha 8361c931209c20841f20c7993d65726bc709e77a

feat: allow GitHub compare API (#45)

view details

push time in 15 days

PR merged netlify/git-gateway

feat: allow GitHub compare API

Due to a recent change in Netlify CMS, we are using the GitHub compare API to rebase branches.

Not sure how to go about testing it locally.

+4 -1

4 comments

2 changed files

erezrokah

pr closed time in 15 days

push eventnetlify/git-gateway

Marcus Weiner

commit sha 19d348bed8b134bf37c087d2e80c600cea31ee9f

Dummy commit for getting new staging config

view details

push time in 15 days

pull request commentnetlify/git-gateway

feat: allow GitHub compare API

Using a repo-local branch: https://github.com/netlify/git-gateway/tree/feat/allow_github_compare_api

erezrokah

comment created time in 15 days

create barnchnetlify/git-gateway

branch : feat/allow_github_compare_api

created branch time in 15 days

PR opened netlify/git-gateway

Upgrade sqlite for macos compat

- Summary

On macOS the older sqlite lib uses some deprecated libc features. Upgrade to get rid of them in tests.

- Test plan

  • SQlite is only used in tests

- Description for the changelog

Upgrade Sqlite adapter

- A picture of a cute animal (not mandatory but encouraged)

+3 -1

0 comment

2 changed files

pr created time in 15 days

create barnchnetlify/git-gateway

branch : chore/upgrade-sqlite

created branch time in 15 days

pull request commentnetlify/git-gateway

feat: allow GitHub compare API

I can provide you with a staging deployment of this PR. Would that help?

erezrokah

comment created time in 15 days

push eventkalkspace/website

Marcus Weiner

commit sha 50513dfaf320e1e24af94bfce7dc355ee6c0820e

Add precompiled styles

view details

push time in 16 days

push eventkalkspace/website

Marcus Weiner

commit sha eede0aceec03a3c015b28f919c93b3f1f6b167ac

Disable style build

view details

push time in 16 days

create barnchkalkspace/website

branch : temp/without-sass

created branch time in 16 days

issue commentnetlify/git-gateway

cannot get files from netlifycms admin panel using Gitlab repo setup

I was not able to easily gather from the code why this is happening. We are using a reverse-proxy in front of the service that may be involved with this. If you can provide more logs, I can maybe find something out.

Reproducing your setup is rather complicated.

artemtech

comment created time in 16 days

pull request commentnetlify/build-image

Add PHP 7.4

Cool. I will see when we can get it rolled to the Netlify CI.

Jamesking56

comment created time in 16 days

pull request commentnetlify/build-image

Add PHP 7.3 and 7.4

yeah, that should be enough

Jamesking56

comment created time in 16 days

pull request commentnetbox-community/go-netbox

Add support to Netbox _choice api for Circuits/DCIM/IPAM/Secrets/Tenancy/Virtualization

Can you give me some example for high-level client methods that are useful to you? I'd like to get an idea of what we could build

quakelee

comment created time in 16 days

push eventffddorf/netbox

Jeremy Stretch

commit sha a2a83a4a4c76c13dec39ea9ac86d6b833a6e4f30

Post-release version bump

view details

Sander Steffann

commit sha 7f779e39426eb3c24dda9684c1b1e2859ec4fac0

Hide password change page when user is logged in using LDAP

view details

struppi

commit sha 99a542e4e4fd2b6b3e8b4b2652cd141722d4dd60

Closes #3663: API filter by created, last_updated

view details

struppi

commit sha a11fa44170092bb5a0cf01097f625bd52c62fdc5

Closes #3663: fix inheritance error

view details

Alexander Olofsson

commit sha bbd65988f92add4bf0c9699b506c3088cde896ec

3457 Display cable colors in device interface list

view details

Jeremy Stretch

commit sha fb4283ed53b0c4cb3f9dd2b498036eea9dc19ea5

Move alternative installations to the GitHub wiki

view details

Jeremy Stretch

commit sha 5eb5c4bac551d9875a3688aad36388af8f61e3a6

Fixes #3674: Include comments on PowerFeed view

view details

Jeremy Stretch

commit sha fbde6187eae6d37a8cded99a6b2899ed4a034060

Fixes #3669: Include weight field in prefix/VLAN role form

view details

Jeremy Stretch

commit sha 053f49c76a2f2879e80144e670ff84fbd2f447d1

Merge pull request #3673 from ananace/cable-color-display 3457 Display cable colors in device interface list

view details

Jeremy Stretch

commit sha b4433a84715e02c65b9837d6e90c0f5cece195c8

Merge pull request #3667 from steffann/3139-disable-user-password-change-if-come-in-with-ldap-auth Hide password change page when user is logged in using LDAP

view details

Jeremy Stretch

commit sha 1bc38f66ae29c29f1d149f56970802d1251a93df

Changelog entries for #3139 and #3457

view details

Jeremy Stretch

commit sha b1761f78567bc5137771128557d851f37efa385b

#3139: Add a message indicating why the user is redirected

view details

struppi

commit sha 099774d66758426c8ed4224527d6553faab45316

Closes #3663: PEP8 fixes

view details

struppi

commit sha 03194506430764863d58cd13c5aa39dc6c027665

Closes #3663: rename filter class

view details

Bernhard Bock

commit sha 1aaa101fb5cd9d9206cd477769a0a8f6ad2c7b5e

Docs: Remove obsolete P3P policy P3P is obsolete (https://www.w3.org/TR/P3P11/), therefore the HTTP header should be removed from the recommended config in the installation docs.

view details

kobayashi

commit sha cc848a3f01edb5ef4ca0e23a4af11e821707a878

Merge pull request #3684 from bbock/docs-remove-p3p Docs: Remove obsolete P3P policy

view details

kobayashi

commit sha 5904f1f8ee722d8f82f02d93e4b97ff6d548a827

Changelog for #3329

view details

kobayashi

commit sha 3c8083ed7fe94b55010d3b5961a38809bed27079

fix url expressions

view details

Jeremy Stretch

commit sha bdd623f82c910865b5e09c57697dc8b686113677

Merge pull request #3680 from struppinet/develop Closes #3663: API filter by created, last_updated

view details

Jeremy Stretch

commit sha 03b8759597b100076d57c88920a9370631e08988

'base_name' deprecated in DRF v3.9.0

view details

push time in 17 days

pull request commentnetbox-community/go-netbox

Add support to Netbox _choice api for Circuits/DCIM/IPAM/Secrets/Tenancy/Virtualization

We are currently trying to get this project into a state where we can fully generate models and a low level client from a swagger definition: https://github.com/netbox-community/go-netbox/pull/52

Might it be possible to get your changes out of that effort?

We are also thinking about a higher level client that will provide the appropriate unmarshaling for those cases of polymorphism

quakelee

comment created time in 17 days

pull request commentnetlify/build-image

Swift Support

the swiftenv idea seems right. though i'd like to have one stable version preinstalled as the default so without targeting a special version builds might be faster

SimonRice

comment created time in 17 days

pull request commentnetlify/build-image

Add PHP 7.3 and 7.4

In order to not bloat the image, let's not include 7.3? does that seem ok?

Jamesking56

comment created time in 17 days

push eventbio-routing/bio-rd

Marcus Weiner

commit sha 126b4944f2ad63a97ea61af00ddb9836b207a5a5

Improve router options handling

view details

Marcus Weiner

commit sha de856c403d05118c97856fadff4ff8a138b57afa

Use constants for area link description types

view details

Marcus Weiner

commit sha 4366e7d8ea611ad07fd9f6c63aee67153e7d6222

Provide consts and helpers for Router lsa flags

view details

Marcus Weiner

commit sha 5d08b6b89828fcd8fc65841ddc71b6c35f8ae625

Refactor handling when payload is a list

view details

Marcus Weiner

commit sha c3b08230125c38d035e9cca7d19482afd0e47a73

Test decoding ls request and update

view details

push time in 18 days

push eventbio-routing/bio-rd

Marcus Weiner

commit sha e30a901bd36717fa7031ec66c3b29c1b8f5f9a13

Refactor router id creation in tests

view details

Marcus Weiner

commit sha f8db1be0949176b782dceb82f79b640648061b19

Improve definition of LSA-Type

view details

Marcus Weiner

commit sha b24ee16f25f8e5d090d8e82d43798cc4c888fae1

Test Database description with LSAs

view details

Marcus Weiner

commit sha 94a2736eb05162146087e8f7aaac18ebfdd36449

Test LSA flooding indicators

view details

push time in 18 days

push eventbio-routing/bio-rd

Marcus Weiner

commit sha 069885e54f70b5c5b3bf2c30d651c30afe9d4cf1

Refactor hello tests

view details

Marcus Weiner

commit sha b7b9538c9cf25ddb9dc8a685a8b419d820c4a802

Add test for database description

view details

push time in 18 days

push eventbio-routing/bio-rd

Marcus Weiner

commit sha c835f9f31e1800e8131aba1818c7660ab8aa8f23

Remove unused dependency

view details

Marcus Weiner

commit sha 68c3ceee7818fa05a8e89e52b90742b2b084232c

Refactor OSPF checksumming

view details

Marcus Weiner

commit sha 4a9240cb1d4039bd8ec3eba130610024afa74795

Provide helpers for router options

view details

Marcus Weiner

commit sha 180c4be3e6dd75aa781cc26c17cd43be3bfca6d1

Test decode of hello packets

view details

push time in 18 days

push eventbio-routing/bio-rd

Marcus Weiner

commit sha 6e4197249701253036bc60310af74d8b8f765671

Remove autogenerated tests for encoding

view details

Marcus Weiner

commit sha dec25065656d784d4666a83863ef5cba4e8f8fa2

Fix usage of net.IP as pointer

view details

push time in 18 days

push eventbio-routing/bio-rd

takt

commit sha f280f199e146c481de86202c21b894b5f7a0c38e

BGP speed improvement (#228) * Add decoding benchmark * Add .gitattributes * Add test data * Implement decoding speed improvements * Performance improvements * Fix tests * Optimizing values vs ptr. * Change cache inserts to pointers * Refactor tests for ip dedup changes * Fix tests * Fix types in device protocol tests * Fix tests * Fix types in routingtable tests * Fix kernel package for darwin/win * Swap BTree with Map * Drop legacy BMP code * Drop legacy fib implementation. * Fix Ptr calls * Drop unused code * Drop unused Less functions * Drop unused copy function * Drop dead code. Add IP dedup to prefix dedup. Co-authored-by: Marcus Weiner <marcus.weiner@gmail.com>

view details

Marcus Weiner

commit sha 8cc51d2ff77a34d128d129315baf90967697bcb7

Update gomod

view details

Marcus Weiner

commit sha 2083e611ea2f8ed137079f6ecacc2e5c5b1558d2

Implement handling of OSPFv3 packets

view details

Marcus Weiner

commit sha 3f46ce5c00be98930794a1864fa78acecb94d79e

Refactor to use net.IP as pointer Also removes generated tests

view details

push time in 18 days

PR opened netbox-community/go-netbox

Reviewers
Autogenerate client from swagger json

Focussed on these goals:

  • Have up-to-date swagger.json
  • Generate client from swagger.json
  • Simplify structure of package (breaking change)
    • models and client directories
+117277 -88043

0 comment

2440 changed files

pr created time in 18 days

create barnchnetbox-community/go-netbox

branch : refactor/autogeneration

created branch time in 18 days

Pull request review commentbio-routing/bio-rd

BGP speed improvement

 func (ip *IP) Equal(other *IP) bool { }  // Less compares ips for use in btree.Btree-func (ip *IP) Less(other btree.Item) bool {+func (ip IP) Less(other btree.Item) bool { 	return ip.Compare(other.(*IP)) == -1 }

Is this still needed?

taktv6

comment created time in a month

Pull request review commentbio-routing/bio-rd

BGP speed improvement

 func init() { }  type pfxCache struct {+	cache   map[Prefix]*Prefix 	cacheMu sync.Mutex-	tree    *btree.BTree }  func newPfxCache() *pfxCache { 	return &pfxCache{-		tree: btree.New(prefixCacheBTreeGrade),+		cache: make(map[Prefix]*Prefix, prefixCachePreAlloc), 	} } -func (pfxc *pfxCache) get(pfx *Prefix) *Prefix {+func (pfxc *pfxCache) get(pfx Prefix) *Prefix { 	pfxc.cacheMu.Lock() -	item := pfxc.tree.Get(pfx)-	if item != nil {+	if p, exists := pfxc.cache[pfx]; exists {

Should the IP in the prefix be deduped first, so we get more hits?

taktv6

comment created time in a month

Pull request review commentbio-routing/bio-rd

BGP speed improvement

 type Prefix struct { }  // Dedup gets a copy of Prefix from the cache-func (p *Prefix) Dedup() *Prefix {+func (p Prefix) Dedup() *Prefix { 	return pfxc.get(p) } +// Ptr returns a pointer to p+func (p Prefix) Ptr() *Prefix {+	return &p+}++// Copy creates a copy of the prefix+func (p Prefix) Copy() *Prefix {+	return &Prefix{+		addr:   p.addr,+		pfxlen: p.pfxlen,+	}+}

Unused?

taktv6

comment created time in a month

Pull request review commentbio-routing/bio-rd

BGP speed improvement

 type Prefix struct { }  // Dedup gets a copy of Prefix from the cache-func (p *Prefix) Dedup() *Prefix {+func (p Prefix) Dedup() *Prefix { 	return pfxc.get(p) } +// Ptr returns a pointer to p+func (p Prefix) Ptr() *Prefix {+	return &p+}++// Copy creates a copy of the prefix+func (p Prefix) Copy() *Prefix {+	return &Prefix{+		addr:   p.addr,+		pfxlen: p.pfxlen,+	}+}+ // Less compares prefixes for use in btree.Btree-func (p *Prefix) Less(other btree.Item) bool {+func (p Prefix) Less(other btree.Item) bool {

Is this still needed?

taktv6

comment created time in a month

Pull request review commentbio-routing/bio-rd

BGP speed improvement

 type IP struct { }  // Dedup gets a copy of IP from the cache-func (ip *IP) Dedup() *IP {+func (ip IP) Dedup() *IP { 	return ipc.get(ip) } +// Ptr returns a pointer to ip+func (ip IP) Ptr() *IP {+	return &ip+}++// Copy creates a copy+func (ip IP) Copy() *IP {+	return &IP{+		higher:   ip.higher,+		lower:    ip.lower,+		isLegacy: ip.isLegacy,+	}+}

This is unused, right?

taktv6

comment created time in a month

push eventbio-routing/bio-rd

Marcus Weiner

commit sha 96c4a1e4d7a9d98073fb1aa46d086ef5d1ec1d36

Fix types in routingtable tests

view details

Marcus Weiner

commit sha a43e6fd18c582504f13b32c5e1f9d8f9b4c9252b

Fix kernel package for darwin/win

view details

push time in a month

push eventbio-routing/bio-rd

Marcus Weiner

commit sha 23bed30943af54e19f84fd0703d6050883459b73

Fix types in device protocol tests

view details

push time in a month

push eventbio-routing/bio-rd

Marcus Weiner

commit sha c2f6ca0fc4df19494ceb98715b561fcb4b9ff855

Refactor tests for ip dedup changes

view details

push time in a month

Pull request review commentbio-routing/bio-rd

BGP speed improvement

+package main++import (+	"bytes"+	"flag"+	"fmt"+	"io/ioutil"+	"os"+	"runtime/pprof"+	"time"++	"github.com/bio-routing/bio-rd/protocols/bgp/packet"++	log "github.com/sirupsen/logrus"+)++var (+	nRuns = flag.Int("runs", 1, "# runs")+)++type task struct {+	num int+	raw *bytes.Buffer+	msg *packet.BGPMessage+}++func main() {

we tried to refactor to benchmarks with a setup function but ran into issues with the buffers used. Since benchmarks are not part of the CI, we decided to no integrate it as a standard benchmark

taktv6

comment created time in a month

push eventbio-routing/bio-rd

Marcus Weiner

commit sha 6b88cc897eb8197f76f2bf175f75a6113d92c415

Refactor to use net.IP as pointer Also removes generated tests

view details

push time in a month

PR closed bio-routing/bio-rd

Implement OSPFv3 packet layer

Supports decoding and encoding of OSPFv3 messages in IPv6 packets.

RFC: 5340 - OSPF for IPv6

Test suite

Testing is based on packet captures from packetlife - in fixtures

Decoding

Decodes all packets from the capture. Only fails on unexpected conditions (length or checksum mismatch).

Encoding

Encodes go structs from snapshots in fixtures/packets. Compares the results to the packet capture. To update the snapshots, run go run ./protocols/ospf/packetv3/fixtures/packets/gen/.

+3826 -10

1 comment

22 changed files

mraerino

pr closed time in a month

pull request commentbio-routing/bio-rd

Implement OSPFv3 packet layer

Superseded by https://github.com/bio-routing/bio-rd/pull/235

mraerino

comment created time in a month

push eventbio-routing/bio-rd

Marcus Weiner

commit sha 456896def0da9a2347c9a470bf32e896047ffca2

Update gomod

view details

Marcus Weiner

commit sha 4129f7390f6f7b61ea7b0dc3945a4c7a6378544d

Implement handling of OSPFv3 packets

view details

push time in a month

push eventbio-routing/bio-rd

Julian Kornberger

commit sha e65ce25750323e801a370b4504ec3a4dd637bf25

Build with Go 1.13 (#226)

view details

takt

commit sha 5ffad221293df96b21657735e4be1aa6fe057f26

Fix index out of range bug (#227)

view details

takt

commit sha 59e01a4b8560d3124021ceb2f8107caf1f948050

Fix type assertions (#224) * Fix type assertions * Fix type assertion * Remove debug output

view details

takt

commit sha e0b63db1bfbcbad637a5541ca4834f455b16b8ca

Add prefix dedup function that also dedups IPs

view details

takt

commit sha f85e0e4c412e7e8142129ca77d207cb2b8e8a79a

Add prefix dedup function that also dedups IPs (#231)

view details

Maximilian Wilhelm

commit sha 7f54c2b29bdc1d2010c18f8492153f8a2062da50

First shot at list of supported RFCs (#232) * Add myself to Authors / Contributors. Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> * First shot at list of supported RFCs. Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> * Make the list a .. list. Signed-off-by: Maximilian Wilhelm <max@sdn.clinic>

view details

takt

commit sha 5496009b692db09bee0680422f320a2314475ea3

Replace ip/prefix map caches with btree caches. (#229) * Replace ip/prefix map caches with btree caches. * Cleanup * Fix magic number * fixed build

view details

takt

commit sha 9a2f84b22a4aac17b61e2cdddefd23f228234246

Fix pfx dedup and add tests (#233)

view details

takt

commit sha f23bac7ee16aaa49f4358bd712f5956f40cdb6f4

Merge branch 'fix/pfxdedup' of github.com:bio-routing/bio-rd into fix/pfxdedup

view details

takt

commit sha 2f52452b7964495aed9db95db068f86122b688bb

Fix Less method

view details

Christoph Petrausch

commit sha 02bfd001bab07fd9276a7607587961d8d4e7229c

Merge pull request #234 from bio-routing/fix/pfxdedup Fix/pfxdedup

view details

Marcus Weiner

commit sha 3f2d751c4921fb29024741c0da1467aabcdd4116

Provide OSPF testlab via Vagrant

view details

Marcus Weiner

commit sha 4da0c14716c449bb85c8ee0d87665b53ab520543

Update gomod

view details

Marcus Weiner

commit sha 137a8a18635aa56f46684cbd7c506ff81413f58f

Implement handling of OSPFv3 packets

view details

push time in a month

PR opened bio-routing/bio-rd

Implement OSPFv3 packet layer

Supports decoding and encoding of OSPFv3 messages in IPv6 packets.

RFC: 5340 - OSPF for IPv6

Test suite

Testing is based on packet captures from packetlife - in fixtures

Decoding

Decodes all packets from the capture. Only fails on unexpected conditions (length or checksum mismatch).

Encoding

Encodes go structs from snapshots in fixtures/packets. Compares the results to the packet capture. To update the snapshots, run go run ./protocols/ospf/packetv3/fixtures/packets/gen/.

+3826 -10

0 comment

22 changed files

pr created time in a month

create barnchbio-routing/bio-rd

branch : packet/ospfv3

created branch time in a month

Pull request review commentnetlify/netlify-commons

make server package

+package server++import (+	"context"+	"fmt"+	"net/http"+	"time"++	"github.com/netlify/netlify-commons/nconf"+	"github.com/netlify/netlify-commons/router"+	"github.com/pkg/errors"+	"github.com/sirupsen/logrus"+)++// Server handles the setup and shutdown of the http server+// for an API+type Server struct {+	log logrus.FieldLogger+	svr *http.Server+}++type Config struct {+	HealthPath string `split_words:"true"`+	Port       int+	TLS        nconf.TLSConfig+}++// APIDefinition is used to define the routes used by the API+type APIDefinition interface {+	AddRoutes(r router.Router)+}++func New(log logrus.FieldLogger, config Config, api APIDefinition) (*Server, error) {+	r := router.New(+		log,+		router.OptHealthCheck(config.HealthPath, nil),+		router.OptTracingMiddleware(log, "PROJECTNAME"),

this needs to be configurable...

rybit

comment created time in a month

push eventkalkspace/website

Marcus Weiner

commit sha 6162787e8982901961ee6552d4b85d797d3ae39c

Fix type in brand name

view details

push time in a month

startedrusoto/rusoto

started time in a month

pull request commentnetlify/open-api

Regenerate go client

Finally released :tada: https://github.com/netlify/open-api/releases/tag/v0.12.0

Mongey

comment created time in a month

push eventnetlify/open-api

Marcus Weiner

commit sha 0f597f713d6e1b1da619105d926d69423b161b8e

Fix changelog formatting

view details

Marcus Weiner

commit sha ae396ebc9aca6f4b447b016137e3a1ddcf9a9ce2

Fix snapshot for versioning

view details

push time in a month

release netlify/open-api

v0.12.0

released time in a month

created tagnetlify/open-api

tagv0.12.0

Open API specification of Netlify's API

created time in a month

push eventnetlify/open-api

Marcus Weiner

commit sha 133a8c54656f0dd1732040af5a5ef416bb49a1b5

0.12.0

view details

push time in a month

pull request commentnetlify/open-api

Gerald/dns zones

@futuregerald do wou want to pick this up again? otherwise i'd like to clase as stale

futuregerald

comment created time in a month

push eventnetlify/open-api

Esteban Pastorino

commit sha 63c8479a4f2ce7847249b82366d8fc3afca2b329

Remove `payment_method_id` from accountUpdateSetup (#169) * Remove `payment_method_id` from accountUpdateSetup It's not being processed by API. * Regenerate go client * Update js test snapshots

view details

push time in a month

delete branch netlify/open-api

delete branch : kitop-patch-1

delete time in a month

PR merged netlify/open-api

Remove `payment_method_id` from accountUpdateSetup

It's not being processed by API.

+0 -11

4 comments

4 changed files

kitop

pr closed time in a month

push eventnetlify/open-api

Marcus Weiner

commit sha e9aa0d5dd3263c27eb8c77a2e93d74a448e2aa48

Update js test snapshots

view details

push time in a month

push eventnetlify/open-api

ehmicky

commit sha 153ede85372c9ce0945886f296a1f5efdf54c213

Add terms of service

view details

ehmicky

commit sha 70bfa1e976e62a2934923b60b426b83e095bde7f

Add OpenAPI tags

view details

ehmicky

commit sha ba22fa93c7db43a3c3d13d6f530f720b27c7daf9

Fix typo

view details

ehmicky

commit sha fb4b07ceb1fa468a1ff8ce7f696fd5abe4265f5d

Re-order npm scripts

view details

ehmicky

commit sha d7a7c3d196b1518a98b586aed16a964bbfeb2691

Add Node.js version

view details

ehmicky

commit sha cc9c0798245398034e14bae644627e29a02d00c2

Use Node 12

view details

ehmicky

commit sha 8342738f2760b1e251ba3bb213e4b54df7831f06

Add `externalDocs`

view details

ehmicky

commit sha cbf441cdbb4cf8002a10aebf98932fddbdde8160

Remove `required: false`

view details

ehmicky

commit sha 3c3e3c56185b2e03d31d0ce60367a4550fd6c93d

Fix YAML syntax error

view details

ehmicky

commit sha 587d55ce16418d3a768f5809320e82de8f58675a

Remove `files` field in `package.json`

view details

ehmicky

commit sha 0dd8e77ee3e9bd832777e9f5fbe5ec6e41f26a55

Fix `files`

view details

David Wells

commit sha 9b1f10d49d2c2e6726dbb6e1c173f087a4c3648e

Merge pull request #195 from netlify/refactor/remove-files Make npm package size smaller

view details

David Wells

commit sha 41b96a5997e1c2a6996d007e918e5095227f889c

Merge pull request #173 from netlify/doc/add-terms-of-service Add terms of service

view details

David Wells

commit sha 7867d2fcf4d74abf66db72ede7fc194bf60bc355

Merge pull request #178 from netlify/doc/add-tags Add OpenAPI tags

view details

David Wells

commit sha 70e2750518b209ac55ce0cd973b0c31c6a7ded76

Merge pull request #184 from netlify/refactor/add-node-version Add Node.js version

view details

David Wells

commit sha ba110c86b89f3f966474fa92b1c19c3560ac22cd

Merge pull request #180 from netlify/refactor/npm-scripts Re-order npm scripts

view details

David Wells

commit sha b8811141e43bb1762be1cd70773616554bbb7ed0

Merge pull request #188 from netlify/doc/remove-required-false Remove `required: false`

view details

David Wells

commit sha 167430ad852efbf4c0d2e87e3837d9b53e561d24

Merge pull request #193 from netlify/bug/fix-openapi-syntax-error Fix YAML syntax error

view details

David Wells

commit sha c726bc6afe355158c4775065a65d98a23abdced5

Merge branch 'master' into doc/online-docs

view details

ehmicky

commit sha 03cc7cb939df57f05b0046f2ce02315196f77f09

Add unit tests

view details

push time in a month

pull request commentnetlify/open-api

Remove `payment_method_id` from accountUpdateSetup

Cool. I'm going to add a Regeneration of the go client to the branch and them merge

kitop

comment created time in a month

delete branch netlify/open-api

delete branch : chore/fix-go-generate-cmd

delete time in a month

push eventnetlify/open-api

Marcus Weiner

commit sha ccc8e482b2f4027d92bae1d478b26ab2ffba7137

Fix options of go generation command (#205)

view details

push time in a month

PR merged netlify/open-api

Reviewers
Fix options of go generation command

Without this option some files were structured differently when regenerating. So adding this for consistency.

+1 -1

3 comments

1 changed file

mraerino

pr closed time in a month

pull request commentnetlify/open-api

Fix options of go generation command

Yeah, seems like I did accidentally remove it. 🙈

mraerino

comment created time in a month

pull request commentnetlify/open-api

Remove `payment_method_id` from accountUpdateSetup

@kitop is it still true that this field is not doing anything right now?

kitop

comment created time in a month

PR opened netlify/open-api

Reviewers
Remove obsolete okbody structs

This is the result of running make generate. Those structs are not referenced anywhere in the client code and I don't think anybody needs them as part of the public lib.

+0 -987

0 comment

21 changed files

pr created time in a month

create barnchnetlify/open-api

branch : chore/remove-obsolete

created branch time in a month

PR opened netlify/open-api

Reviewers
Fix options of go generation command

Without this option some files were structured differently when regenerating. So adding this for consistency.

+1 -1

0 comment

1 changed file

pr created time in a month

create barnchnetlify/open-api

branch : chore/fix-go-generate-cmd

created branch time in a month

delete branch netlify/open-api

delete branch : escape-file-upload-urls

delete time in a month

delete branch netlify/open-api

delete branch : go-deps

delete time in a month

delete branch netlify/open-api

delete branch : gerald/traffic_split

delete time in a month

delete branch netlify/open-api

delete branch : fix-retrying

delete time in a month

more