profile
viewpoint
Antón Molleda molant Microsoft Seattle https://webhint.io @molant is currently unavailable, please leave a message

microsoft/edge-diagnostics-adapter 124

Microsoft Edge Diagnostics Adapter is a protocol adapter that enables tools to debug Microsoft Edge using the Chrome DevTools Protocol.

htmlhint/chai-htmlhint 3

Extends Chai with assertions for HTMLHint

molant/arbor 1

a graph visualization library using web workers and jQuery

molant/BrowserExperiments 1

Experiments with shims

molant/angular-seed 0

Seed project for angular apps.

molant/angular.js 0

HTML enhanced for web apps

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

issue closedwebhintio/hint

[Bug] Bug description

<!--

Hi there 👋

Thanks for taking the time to make webhint better! Before opening a new issue please take a look at the troubleshoot guide: https://webhint.io/docs/user-guide/troubleshoot/summary/ and make sure to search the existing ones (even closed!) as they might contain information about workarounds, resolution, or progress updates.

-->

🐛 Bug report

Description

<!-- ✍️ What were you doing? How do we repro your issue? -->

Environment

  • webhint version: <!-- ✍️ Menu > Add-ons / Extensions -->
  • Browser version: <!-- ✍️ Menu > Help > About -->
  • URL for which webhint failed: <!-- ✍️ -->

webhint configuration

<details> <summary>webhint’s configuration</summary>

Categories:

  • [x] Accessibility
  • [x] Compatibility
  • [x] Performance
  • [x] Pitfalls
  • [x] PWA
  • [x] Security

Your target browsers:

  • [x] Recommended settings
  • [ ] Custom: <!-- Custom target browsers -->

Ignored resources:

  • [x] None
  • [ ] Different origin
  • [ ] Custom: <!-- Custom ignored resources -->

</details>

Debug output

Please include the content of the Error details section if an error message was displayed.

<details> <summary>webhint’s Error details</summary>

<!-- ✍️ Paste the error details here -->


</details>

closed time in 4 days

0352053439

issue commentwebhintio/hint

[Bug] Bug description

Hello @0352053439

Was this issue opened by mistake or did you have a problem with the extension? If you had a problem, feel free to open a new issue filling the details so we can take action on it.

Thank you!

0352053439

comment created time in 4 days

issue commentwebhintio/hint

[Bug] Doesn't support Yarn v2 with PnP.

Hi @yoannmoinet

Seems like yarn2 is not downloading the packages the same way npx does. I haven't tried yarn 2 myself but if their goal is to have parity I would raise this issue with them as I doubt we would be the only project running into this.

Unfortunately the team does not have time to look into this at the moment but if you find out how to make it work please submit a PR!

yoannmoinet

comment created time in 4 days

issue commentwebhintio/webhint.io

Electron node-gyp canvas package not found.

Do you have a repo we can clone with some steps to reproduce the error? I'm not sure what do I have to do to see the same problem you do right now.

Thanks!

paragdiwan

comment created time in 5 days

issue commentwebhintio/webhint.io

Electron node-gyp canvas package not found.

Hi @paragdiwan,

Sorry for the late response. From the error it seems like you are running it directly inside electron. Is that right? Native modules need to be recompiled for Electron and unfortunately canvas is not an easy one to compile...

What is the scenario you are trying to achieve? canvas is used by the jsdom connector but you can probably use the puppeteer connector.

paragdiwan

comment created time in 6 days

PublicEvent

push eventmolant/xplat-benchmark

Anton Molleda

commit sha 5f2e19d9e2ddff3ab6ce195d5852edf4065e79ed

Docs: Update link to CPU benchmark

view details

push time in 7 days

pull request commentwebhintio/hint

Editorial updates for the documentation.

The limit in 80 characters is for convenience when reading the markdown directly as its difficult to follow long lines.

jm-trd-ms

comment created time in 21 days

startedtjanczuk/edge

started time in 25 days

PullRequestReviewEvent

push eventwebhintio/hint

Tony Ross

commit sha d31adaa73c3e2d820158a2d6b9f4d3baf62870a5

Chore: Fix VS Code debugging of ava tests timing out after 10s

view details

push time in a month

PR merged webhintio/hint

Reviewers
Chore: Fix VS Code debugging of ava tests timing out after 10s

<!--

Read our pull request guide: https://webhint.io/docs/contributor-guide/getting-started/pull-requests/

For the following items put an "x" between the square brackets (i.e. [x]) if you completed the associated item.

-->

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • [ ] Added/Updated related documentation.
  • [x] Added/Updated related tests.

Short description of the change(s)

<!--

If this is a non-trivial change, include information such as what benefits this change brings as well as possible drawbacks.

If this fixes an existing issue, include the relevant issue number(s).

Thank you for taking the time to open this PR!

-->

VS Code has a custom launch config that is different from our normal config when running tests. We were getting the default ava timeout of 10s, making stepping through the debugger nearly impossible. Fixed by extending the timeout to five minutes when launched from VS Code.

+1 -0

0 comment

1 changed file

antross

pr closed time in a month

PullRequestReviewEvent
PullRequestReviewEvent

issue commentwebhintio/webhint-ado-extension

Create tabs using newer SDK

@EddyHaigh creating a markdown formatter should relatively easy. Do you mind opening an issue in the main project? If you could add your ideas about how it should look like it would be great.

I quickly look at the commands page you've linked and it looks like we will have to use a special formatting for ADO, right? Maybe we could have a general markdown formatter and then a transformation step if needed in the extension?

molant

comment created time in a month

PullRequestReviewEvent

Pull request review commentwebhintio/hint

Fix: Silent mode in CI

 export default async (actions: CLIOptions): Promise<boolean> => {             updateCallback: undefined         }; -        /* istanbul ignore else */-        if (!actions.debug) {+        // /* istanbul ignore else */

Do we need this to be a single line comment or is a leftover from tests?

sarvaje

comment created time in a month

PullRequestReviewEvent

issue commentwebhintio/hint

[Bug] Do not show autocomplete warning (input[autocomplete]) if it's off

Ignoring sounds good to me 😊

gianpaj

comment created time in a month

Pull request review commentwebhintio/webhint.io

Fix: Support mapping links to full URLs from `hint` Github repo

 const updateMarkdownlinks = (content, filePath) => {             val[0].replace(/(index|readme)\.md/i, '') :             val[0].replace('.md', '/'); +        /*+         * An github url is found for a md file.+         * In this case we need to replace it with the a valid+         * url in the website.+         */+        if (val[2].startsWith('https')) {

It is a bit weird to say the link is for github and then check just for https.

        if (val[2].startsWith('https://github.com/')) {
sarvaje

comment created time in a month

Pull request review commentwebhintio/webhint.io

Fix: Support mapping links to full URLs from `hint` Github repo

 const updateMarkdownlinks = (content, filePath) => {             val[0].replace(/(index|readme)\.md/i, '') :             val[0].replace('.md', '/'); +        /*+         * An github url is found for a md file.+         * In this case we need to replace it with the a valid+         * url in the website.+         */+        if (val[2].startsWith('https')) {+            replacement =+                `${val[1]}/docs/${file.frontMatter.section}${file.frontMatter.tocTitle ? `/${file.frontMatter.tocTitle.replace(' ', '-')}` : ''}/${val[4].replace('/docs/', '/')}/`;+

Maybe we could document what the different val[x] are?

sarvaje

comment created time in a month

pull request commentwebhintio/hint

Docs: Fix broken README.md links on npmjs.org

It creates a link using the first pair of brackets as a key to find the link later on the link:


[link 1][]

Some text here

[link 1]: https://webhit.io
johnemau

comment created time in a month

issue commentwebhintio/hint

[Docs Bug] npm webhint (hint) page: 404s

Good question. Before we were cloning the latest version of master in webhint.io, but now we are pulling the latest npm packages.

I think that a way would be clone the website's repo locally, install all dependencies, manually update a couple of the files you've modified, and then run the generation scripts to see what comes out of that.

henrihelvetica

comment created time in a month

issue commentwebhintio/hint

Add support for ASP.NET Core's URL fingerprinting syntax

Sure. The file to modify would be this one.

The idea will be to detect the finger printing syntax after cacheRevvingPatterns fails. If it is detected then change the severity from Severity.warning to Severity.hint a couple lines later from where I pointed.

Ideally there should be a new test here as well 😊

Hopefully the Contributor Guide is clear enough. If it isn't please let us know so we can address that (you can file a new issue or post a comment here and we will open it).

Thank you!

madskristensen

comment created time in a month

issue commentwebhintio/hint

Add support for ASP.NET Core's URL fingerprinting syntax

This might take a bit because of other priorities but if you want to do a PR we will be happy to help you along the way!

madskristensen

comment created time in a month

issue commentwebhintio/hint

Add support for ASP.NET Core's URL fingerprinting syntax

It will depend on what the user has configured as the minimum threshold. IIRC the default one for the browser extension is warning so it will not show up unless they change it.

madskristensen

comment created time in a month

issue commentwebhintio/hint

[Feature] cli tool: silent mode

@zmeyc in the meantime I you want to try to do a PR please don't hesitate!

We should be detecting when we are running on CI and not print similar messages but we must have missed this one.

zmeyc

comment created time in a month

issue commentwebhintio/hint

[Feature] cli tool: silent mode

@antross @hxlnt @sarvaje I'd like us too discuss this in the next meeting and see what we can do. Sounds good?

zmeyc

comment created time in a month

issue commentwebhintio/webhint.io

Remove GA from website

We'd just need to update the extension to append a source param and we could follow that through.

My question was more about what is going to record how many visits come with that param. If the plan is to report it via AppInsights that's fine. Another problem is the data retention, especially if at one moment there are OKRs about any of these values (although we already have that problem).

antross

comment created time in 2 months

Pull request review commentmicrosoft/vscode

Add rnw and rnm to workspace tags

 export class WorkspaceTagsService implements IWorkspaceTagsService { 			const packageJsonPromises = getFilePromises('package.json', this.fileService, this.textFileService, content => { 				try { 					const packageJsonContents = JSON.parse(content.value);-					let dependencies = Object.keys(packageJsonContents['dependencies']).concat(Object.keys(packageJsonContents['devDependencies']));+					let dependencies = Object.keys(packageJsonContents['dependencies'] || {}).concat(Object.keys(packageJsonContents['devDependencies'] || {}));

Done!

molant

comment created time in 2 months

push eventmolant/vscode

Rob Lourens

commit sha 13001de3b78c1f10257bf3ae80438d5b8427af2b

collapse with ...

view details

Rob Lourens

commit sha 4b8e0c732c0382c901489bdeb50ac530191cbd39

Collapsing markdown, adding actions to menu and keybindings

view details

Rob Lourens

commit sha db170566b846acbba7e1c459864457b2bf536101

Cell collapse indicator tweaks

view details

Matt Bierner

commit sha 731f9c25632dbbf01ee3a7892ad9d2791fe0260c

Prefer using data-href if it exists on a markdown preview link Fixes #101203

view details

Alex Dima

commit sha 2fa41fb23ec030a7c904a82c4a9b4c51f6cbc6bf

Add "web" as extensionKind to extensions which support this

view details

Alex Dima

commit sha fd91d449f98516b7383c1709fcd2c852174c8ca0

Improve default extensionKind detection

view details

Alex Dima

commit sha 98e653e82cd0aa521c4daa161c2e9b7da1b6657b

Add tests for deducing extension kind

view details

Alex Dima

commit sha a7b1e06283abfc7205d574a953f49a325ce9f2b3

Add support for web worker extensions to define their entry point via "browser"

view details

Alex Ross

commit sha 8ba686c4e4283beaacc64f8405da598dc7541e11

Allow background tasks in dependsOn Part of #70283

view details

Sandeep Somavarapu

commit sha bc532589c18408565ac3cc6c1eee5750fd3e970b

:lipstick:

view details

Sandeep Somavarapu

commit sha 8ef53a3f08b68cbe1874b7fdf1be53fd7c4102d6

#103238 Initialize as soon as one of the account providers is available

view details

Sandeep Somavarapu

commit sha f6ec272bbd2682b84706707ca2cf60739ee29733

set turning on context using enablement and sync status

view details

Sandeep Somavarapu

commit sha bf9cc76621252b82ea672ebde15046532a72756a

show merge dialog only when there are merges from another machine

view details

Sandeep Somavarapu

commit sha a8b2444df154f6d1ea5e6625c18c67df9dc873a5

fix accepting local and remote content during merge

view details

Alex Dima

commit sha 750baf0af6fc71706e356baabedf820082e8f9a3

Minify extension resources

view details

Alex Dima

commit sha 91cdca1bdb0ea233e0c2d5bcb5f4ca60efc0f30e

Do not ship unnecessary files with extensions

view details

Alex Dima

commit sha d42e9162b92e2178c2f55b798657c9a75fbca89b

Remove some extension package.json patching

view details

Daniel Imms

commit sha e8c3ff351bdf2d93e12fff29a6daed3124190f12

Log ext host terminal process requests

view details

Alex Dima

commit sha 2de499749410cf099f4f9a224b82e75e507f1659

Allow ms-vscode.references-view to use proposed API when running from sources

view details

Rachel Macfarlane

commit sha 3c96ef7d897bac3b31b02315f58ec448aea45f61

Update Microsoft auth callbacks

view details

push time in 2 months

Pull request review commentwebhintio/hint

New: Support documentation link and text in a report

 const validateResults = (t: ExecutionContext<HintRunnerContext>, sources: Map<st             return;         } -        const filteredByPosition = filteredByMessage.filter((report) => {-            if (report.position && location) {-                let position: ProblemLocation | undefined;+        const filteredByDocumentation = filteredByMessage.filter((report) => {+            /*+             * If the report from the test doesn't ask for documentation,+             * we don't need to macth it.+             */+            if (!report.documentation) {+                return true;+            } -                if ('match' in report.position) {-                    position = findPosition(sources.get(resource) || '', report.position);-                } else {-                    position = report.position;-                }+            /*+             * If the report from the test does ask for documentation+             * but the result doesn't provide it, then it isn't a match.+             */+            if (!documentation) {+                return false;+            }++            return report.documentation.some((docReport) => {+                return documentation.some((docResult) => {+                    return docReport.link === docResult.link &&+                        docReport.text === docResult.text;+                });+            });+        }); -                return position.column === location.column &&-                    position.line === location.line &&-                    (!('range' in report.position) || (-                        position.endLine === location.endLine &&-                        position.endColumn === location.endColumn));+        if (filteredByDocumentation.length === 0) {+            // TODO: Improve message.

It's a test message so I'm fine with it as it is 😊

sarvaje

comment created time in 2 months

Pull request review commentwebhintio/hint

New: Support documentation link and text in a report

 const validateResults = (t: ExecutionContext<HintRunnerContext>, sources: Map<st             return;         } -        const filteredByPosition = filteredByMessage.filter((report) => {-            if (report.position && location) {-                let position: ProblemLocation | undefined;+        const filteredByDocumentation = filteredByMessage.filter((report) => {+            /*+             * If the report from the test doesn't ask for documentation,+             * we don't need to macth it.+             */+            if (!report.documentation) {+                return true;+            } -                if ('match' in report.position) {-                    position = findPosition(sources.get(resource) || '', report.position);-                } else {-                    position = report.position;-                }+            /*+             * If the report from the test does ask for documentation+             * but the result doesn't provide it, then it isn't a match.+             */+            if (!documentation) {+                return false;+            }++            return report.documentation.some((docReport) => {+                return documentation.some((docResult) => {+                    return docReport.link === docResult.link &&+                        docReport.text === docResult.text;+                });+            });+        }); -                return position.column === location.column &&-                    position.line === location.line &&-                    (!('range' in report.position) || (-                        position.endLine === location.endLine &&-                        position.endColumn === location.endColumn));+        if (filteredByDocumentation.length === 0) {+            // TODO: Improve message.

Should we improve it now or just remove this comment?

sarvaje

comment created time in 2 months

issue commentmicrosoft/vscode-react-native

Better logging experience

Awesome,

What do you think about updating the documentation showing how people can change between channels and what each channel is for and also doing the coloring?

Maybe we could split this into 2 different PRs: docs + coloring.

molant

comment created time in 2 months

issue commentwebhintio/webhint.io

Remove GA from website

Is there a plan to track click through from the tools to the documentation pages?

antross

comment created time in 2 months

issue commentwebhintio/hint

[Bug] package.json browserslist with multiple environments

if none of the properties is development nor production? which one we will chose?

Then we delegate to browserslist decide whatever logic it has.

Maybe this code should go in webhint itself, and not only in VSCode.

I'm more worried about modifying something that touches webhint entirely as that can cause side effects we don't want. For the CLI scenario the user should be capable of setting an environment variable for that process just before launching (e.g. BROWSERSLIST_ENV=development yarn hint src). That is not possible in the VS Code extension. Maybe it is a question of improving the documentation in there?

zmeyc

comment created time in 2 months

issue commentwebhintio/hint

[Bug] package.json browserslist with multiple environments

@zmeyc we actually support the property browserslist in .hintrc so you should be able to use that. Our aspiration is for developers to only have to maintain one browserslist configuration instead of duplicating code.

I've searched on GitHub OSS projects that use this feature and all of the use production or development.

I think we could improve a bit the VS Code extension by doing some checks before initializing hint:

  1. If there's a NODE_ENV or BROWSERSLIST_ENV do nothing
  2. Find browserslist configuration (could be in package.json or browserslistrc).
  3. If it has multiple properties and one of those is development, then process.env.BROWSERSLIST_ENV = "development" and continue the execution. That should hopefully be enough to pass a new environment variable to the new process and will not make it persistent

@antross @sarvaje thoughts?

zmeyc

comment created time in 2 months

issue commentmicrosoft/vscode-react-native

Better logging experience

Thanks for the update @SounD120 !

Can a user switch between channels? Also I've seen there are some "hacks" to colorize channels. Could this apply to us?

molant

comment created time in 2 months

pull request commentwebhintio/hint

Include Analyzer instance resources when calling formatters

Thanks @jackkoppa!

jackkoppa

comment created time in 2 months

push eventwebhintio/hint

Jack Koppa

commit sha 1b6b4b1e43a77b202b55aebd8eb126a2a1112be0

Fix: Include Analyzer instance resources when calling formatters When calling `Analyzer.format()`, any resources already on the instance should be included, if not provided separately on an options argument; this way the formatters called will have access to the hints that were tested, and thus can include only those categories involved - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Fix #3910 Close #3918

view details

push time in 2 months

PR merged webhintio/hint

Reviewers
Include Analyzer instance resources when calling formatters

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • n/a Added/Updated related documentation.
  • [x] Added/Updated related tests.

Short description of the change(s)

Fixes #3910

Formatters need to know which hints were used during analyze, and so by including the Analyzer.resources when calling formatters, they can then display only the categories that were actually used.

+40 -5

2 comments

2 changed files

jackkoppa

pr closed time in 2 months

issue closedwebhintio/hint

[Bug] When running Analyzer.format(), the resources from Analyzer.create() are not referenced

🐛 Bug report

Description

Note: if the intended behavior is to always have all categories when using the programmatic API, then this could be closed & we could stick with our workaround. However, given that formatters have methods to only display categories for actual hints, it seems likely we'd want to "fix" this

// index.js
const hint = require('hint')
const fs = require('fs')
const userConfig = require('./hintConfig')

const webhint = hint.Analyzer.create(userConfig)
const results = await webhint.analyze('http://example.com')
await webhint.format(results[0].problems)

Actual Result: When running webhint.format(), the resources array that gets used during webhint.analysis() is not referenced. This means that while analyze checks the correct hints based on our configuration (in our case, those from the accessibility default), the generated HTML file does not know which hints were used. Meaning that the output file includes all categories, rather than just the categories where hints are actually targeted.

Expected Result: webhint.format() should generate a response that only includes the categories for targeted hints; i.e. if a user doesn't provide a custom list of resources, then the instance list of Analyzer._resources should be referenced

Possible line to add: https://github.com/webhintio/hint/blob/main/packages/hint/src/lib/analyzer.ts#L269

options = { ...options, resources: this.resources }

Current Workaround:

await webhint.format(results[0].problems, { resources: webhint.resources })

Current: Screen Shot 2020-07-23 at 1 19 31 PM

After Workaround: Screen Shot 2020-07-23 at 1 19 06 PM

Environment

  • hint version: v6.0.6
  • Node.js version: v12.16.1
  • OS: MacOS 10.15.6
  • URL for which webhint failed: any

webhint configuration

<details> <summary>webhint’s configuration</summary>

// hintConfig.js
module.exports = {
	extends: ['accessibility']
}

</details>

Debug output

n/a (Webhint completes successfully, see screenshots for issue)

closed time in 2 months

jackkoppa

PR opened microsoft/vscode

Add rnw and rnm to workspace tags

This adds the react-native-windows and react-native-macos to workspace tags.

+5 -1

0 comment

1 changed file

pr created time in 2 months

create barnchmolant/vscode

branch : rntags

created branch time in 2 months

pull request commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

Don't think I'll have the time to check until next week. If it's OK on your side then go ahead 😊

sarvaje

comment created time in 2 months

issue commentmicrosoft/vscode-react-native

[Discussion] Preparing for Turbomodules

The current thinking is to contribute back to Metro the proxy work so any CDP tool can debug react native applications on iOS.

We were told to start looking in https://github.com/facebook/metro/tree/master/packages/metro-inspector-proxy

@SounD120 can you use https://github.com/facebook/react-native/tree/master/RNTester to test things or do you need a way to test direct debugging on iOS?

molant

comment created time in 2 months

pull request commentwebhintio/webhint.io

Fix: Downgrade puppeteer verstion to 5.0.0

Is there any issue in their github repo we can track? Maybe something related to network requests and their order?

sarvaje

comment created time in 2 months

pull request commentwebhintio/hint

Fix: Generated file `browser-compat-api` incomplete

@sarvaje CI keeps failing even after restart. Can you please take a look?

sarvaje

comment created time in 2 months

pull request commentwebhintio/hint

Fix: Generated file `browser-compat-api` incomplete

/azp run

sarvaje

comment created time in 2 months

issue commentwebhintio/webhint-ado-extension

ADO extension v1

Hi @EddyHaigh definitely not abandoned just some changes in the priorities and available time due to the state of the world.

IIRC, the biggest thing would be #14. I look into it a while ago but I had some issues understanding how to connect the dots and make it work 😓 Basically we wanted to reuse the HTML formatter and embedded into the results. Don't know if that's the recommended way but if it makes it easier to reuse the react components of the browser extension we can do that as well (I believe the new SDK was using react?)

There's also #15 that could be done after that or maybe at the same time if that's going to make the development easier.

Any help with this would be really appreciated 🙏

Thanks!

molant

comment created time in 2 months

push eventmolant/vscode

Alvin Tang

commit sha 341a45914d07ac40b0eced6ddfbadb03d1b97c7d

Added new configuration comments.includeEmptyLines for feature request raised #88480.

view details

Alvin Tang

commit sha 09c73130d6f5a8aef26ecaa5635dc33ef687897d

Changed configuration for where the setting will be placed for includeEmptyLines. Also added a test that doesn't work - to be fixed.

view details

Dharmik Shah

commit sha 9bd5d3b23c32b4d88415c3cb65c4693729030135

Added proper test case for empty strings, input false, output true

view details

Alvin Tang

commit sha 551f91887707f3ca833419eae4ca1285294afc74

Added new setting editor.comments.includeEmptyLines for feature request raised in #88480 with a new suite of tests based off original.

view details

Jeffrey L

commit sha 86ab76408d287773b7d68e0d8f6fdfeb2aa8d894

Fix merge conflict

view details

Ludovic Galibert

commit sha 4f68d66ec9a8072fc970dbfb34c9fc1a90467615

Add #97640: Added options to enable codelens for diff editors

view details

ConnorSkees

commit sha a7cfc3f779920369b5c1abe39498e31e29ac85fd

use ^H to delete word left in cmd.exe

view details

Ludovic Galibert

commit sha 9b8d5cb6e228e9f42b5d2f1276fd7d784ed9a75c

Add #97640: corrected code documentation

view details

Ed Jeffreys

commit sha 447099dfd1766480a61db4541e04aa147080208b

fixes #98942 * Register new search action button: clear search patterns - Visible when pattern input fields contain text * Introduce clear method on PatternInputWidget ToDo: Create new icon for clear search pattern button??

view details

Ed Jeffreys

commit sha a65503869539e95f03533596b951bdf12abb84e7

fix type in method name

view details

Ed Jeffreys

commit sha 234bbef7b471124056e4361adb9e2d188a530e31

convert to 2-stage button Finally realized what a 2-stage button is... Clears search fields first if there are any values entered, otherwise clears file pattern fields

view details

Alvin Tang

commit sha 483bd32f612a12a7d6806f150b8210d880fbb20b

Merge branch 'master' into team19/comment-whitespace-88480

view details

gjsjohnmurray

commit sha ef583d90b56fcf604a0c45fb1c6ffe0c8afa7ce8

fix #100437 Improve 'terminal.integrated.commandsToSkipShell' information in Settings Editor

view details

Martin Aeschlimann

commit sha 5069ddc650c776e79b795e84bd125c012d36ed36

workbench.colorCustomizations not kept when loaded from remote workspace. Fixes #101433

view details

Miguel Solorio

commit sha 0bd3862a44361d4dafa587368c1761495b62d3c3

Add border to top and bottom focused notebook cells (refs #101375)

view details

Rob Lourens

commit sha 06ba687683ee81ec9ebd4d56cd6ca86031cf9195

Bump distro ThirdPartyLicenses updates for vscode-ripgrep

view details

João Moreno

commit sha 6968ef84a0e1a857cc92a0ec457c15e7a7acfc2a

force rebase when pulling

view details

Matt Bierner

commit sha e96aaa0befaabe39a4579081a6fa5e75c5e838b8

Always use http for internal webview resource loading Fixes #101272

view details

Matt Bierner

commit sha 4c7d5640804ae4883ad0d679331714ef10646f5a

Pick up new TS version

view details

Miguel Solorio

commit sha 11cb67466aae047a2dd101ba0a2f8afd160bd51a

Update notebook color token names (fixes #98984)

view details

push time in 2 months

push eventwebhintio/hint

John

commit sha 9d953777c0e75bb0919d1b1a6f0508e00c50c688

Chore: Prefer querySelector over querySelectorAll This change prefers `querySelector` over `querySelectorAll` in `utils-dom`. This better expresses the intent of the code and leverages the performance improvement in #3861. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Close #3862

view details

push time in 2 months

Pull request review commentwebhintio/hint

Chore: Prefer querySelector over querySelectorAll

 export class HTMLDocument extends Node {      * https://developer.mozilla.org/docs/Web/API/Document/body      */     public get body(): HTMLElement {-        return this.querySelectorAll('body')[0];+        return this.querySelector('body') as HTMLElement;

Do we need as HTMLElement or can TypeScript infer it?

johnemau

comment created time in 2 months

push eventwebhintio/hint

John

commit sha c83a91b7ae3fd0cb83da15517bbcfa3c3a33ba26

Chore: Improve `querySelector` perf by using `cssSelect.selectOne` This change improves `querySelector` best case performance from O(N) to O(1). Previously `querySelector` called `querySelectorAll` which had a best case of O(N) traversing all nodes in the DOM (passed in via `_document.children`). The new implementation re-uses the css-select query cached (shared with `querySelectorAll`) and then leverages `cssSelect.selectOne` which internally leverages [domUtil's `findOne`][1] which has the improved performance (over `findAll`). - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - [1]: https://github.com/fb55/domutils/blob/d7d349c25f78a50cc3f29d9e83f86cbbcf93b2a9/src/querying.ts#L75 Close #3861

view details

push time in 2 months

PR merged webhintio/hint

Reviewers
Fix: Improve utils-dom querySelector perf by using cssSelect.selectOne

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • [ ] Added/Updated related documentation.
  • [x] Added/Updated related tests.

Short description of the change(s)

This change improves querySelector best case performance from O(N) to O(1).

Previously querySelector called querySelectorAll which had a best case of O(N) traversing all nodes in the DOM (passed in via _document.children).

The new implementation re-uses the css-select query cached (shared with querySelectorAll) and then leverages cssSelect.selectOne which internally leverages domUtil's findOne which has the improved performance (over findAll).

+30 -2

0 comment

2 changed files

johnemau

pr closed time in 2 months

issue closedwebhintio/hint

[Bug] Bug description

<!--

Hi there 👋

Thanks for taking the time to make webhint better! Before opening a new issue please take a look at the troubleshoot guide: https://webhint.io/docs/user-guide/troubleshoot/summary/ and make sure to search the existing ones (even closed!) as they might contain information about workarounds, resolution, or progress updates.

-->

🐛 Bug report

Description

<!-- ✍️ What were you doing? How do we repro your issue? -->

Environment

  • webhint version: 2.1.0 <!-- ✍️ Menu > Add-ons / Extensions -->
  • Browser version: Mozilla/5.0 (X11; Linux x86_64; rv:77.0) Gecko/20100101 Firefox/77.0 <!-- ✍️ Menu > Help > About -->
  • URL for which webhint failed: <!-- ✍️ -->

webhint configuration

<details> <summary>webhint’s configuration</summary>

Categories:

  • [x] Accessibility
  • [x] Compatibility
  • [x] Performance
  • [x] Pitfalls
  • [x] PWA
  • [x] Security

Your target browsers:

  • [x] Recommended settings
  • [ ] Custom: <!-- Custom target browsers -->

Ignored resources:

    • [x] None
    • [ ] Different origin
    • [ ] Custom: <!-- Custom ignored resources -->

</details>

Debug output

Please include the content of the Error details section if an error message was displayed.

<details> <summary>webhint’s Error details</summary>

Scan timed out.



</details>

closed time in 2 months

hellosct1

Pull request review commentwebhintio/hint

Fix: Improve utils-dom querySelector perf by using cssSelect.selectOne

 export class HTMLDocument extends Node {     /**      * https://developer.mozilla.org/docs/Web/API/Document/querySelector      */-    public querySelector(selector: string): HTMLElement {-        return this.querySelectorAll(selector)[0];+    public querySelector(selector: string): HTMLElement | null {+        if (!CACHED_CSS_SELECTORS.has(selector)) {+            CACHED_CSS_SELECTORS.set(selector, cssSelect.compile(selector));+        }++        const data: any | undefined = cssSelect.selectOne(+            CACHED_CSS_SELECTORS.get(selector) as cssSelect.CompiledQuery,

Can't the cache cause troubles if we switch to analyze continuously?

johnemau

comment created time in 2 months

Pull request review commentwebhintio/hint

Fix: Improve utils-dom querySelector perf by using cssSelect.selectOne

 export class HTMLDocument extends Node {     /**      * https://developer.mozilla.org/docs/Web/API/Document/querySelector      */-    public querySelector(selector: string): HTMLElement {-        return this.querySelectorAll(selector)[0];+    public querySelector(selector: string): HTMLElement | null {+        if (!CACHED_CSS_SELECTORS.has(selector)) {+            CACHED_CSS_SELECTORS.set(selector, cssSelect.compile(selector));+        }++        const data: any | undefined = cssSelect.selectOne(

Can we use NodeData in here or is that causing any types issue? If so, maybe we should cast it already here instead of pass any around?

johnemau

comment created time in 2 months

issue commentwebhintio/hint

webhint meeting 2020-07-09

@hxlnt i won't be able to attend. Will be good to find something fo the issue about browserlist and development environment.

hxlnt

comment created time in 2 months

pull request commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

@sarvaje is this ready for another review?

sarvaje

comment created time in 2 months

push eventwebhintio/hint

Nils Torbjörn Petersen

commit sha 2d4732f999bd54f0e649ba51d7f783e4eb23f775

Build: Add publishing scripts for OVSX Fix #3831 Close #3848 Co-authored-by: Antón Molleda <amolleda@gmail.com>

view details

push time in 2 months

issue closedwebhintio/hint

Please publish the VSCode extension on OpenVSX

I'm a VS Codium user, a FLOSS version of VS Code. It's the same code but without Microsoft's telemetry, branding and licensing.

I would like to request, if possible, to add the webhint extension to the open-vsx.org market as it is unclear if it's legal to use the official Microsoft extension marketplace on VS Code forks, see here.

Additional information on how to publish an extension to Open VSX can be obtained here.

closed time in 2 months

entepe85

PR merged webhintio/hint

Reviewers
New: Add publishing scripts for OVSX

<!--

Read our pull request guide: https://webhint.io/docs/contributor-guide/getting-started/pull-requests/

For the following items put an "x" between the square brackets (i.e. [x]) if you completed the associated item.

-->

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • [ ] Added/Updated related documentation.
  • [ ] Added/Updated related tests.

Short description of the change(s)

<!--

If this is a non-trivial change, include information such as what benefits this change brings as well as possible drawbacks.

If this fixes an existing issue, include the relevant issue number(s).

Thank you for taking the time to open this PR!

-->

+38 -1

6 comments

2 changed files

entepe85

pr closed time in 2 months

push eventwebhintio/hint

Patrick Brosset

commit sha a37a7a39ee27ecb8ed289d1e8c74014a6895e5e0

Fix: Break header text anywhere needed If a report is generated on a site with a very long URL, horizontal overflow can happen. We want to avoid this as it forces users to scroll horizontally to reveal the content. To do this, we make sure the header text can break anywhere. - - - - - - - - - - - - - - - - - - - - - - - - - - Fix #3587 Close #3855

view details

push time in 2 months

PR merged webhintio/hint

Reviewers
Fix: Break header text anywhere needed

If a report is generated on a site with a very long URL, horizontal overflow can happen. We want to avoid this as it forces users to scroll horizontally to reveal the content.

To do this, we make sure the header text can break anywhere.

Fix #3587

+1 -1

0 comment

1 changed file

captainbrosset

pr closed time in 2 months

issue closedwebhintio/hint

[Bug] Long URLs break word wrap in results

🐛 Bug report

Description

When I run a scan against a very long URL, word wrap breaks in the results.

long-url

Environment

  • webhint version: 1.2.1
  • Browser version: Edge Beta (80)

closed time in 2 months

hxlnt

issue commentwebhintio/hint

[Bug] package.json browserslist with multiple environments

Thanks for reporting this @zmeyc!

Wonder what is going on. We delegate everything to the browserslist package to find the right configuration. For more context about environments there's https://github.com/browserslist/browserslist#configuring-for-different-environments

@hxlnt adding this to the agenda so we can talk about it this Friday 😊

zmeyc

comment created time in 2 months

push eventmolant/vscode

Antón Molleda

commit sha 919334666fa58b9fc2483cbdfd76a55cf3076e94

Add MetaModules to workspace tags

view details

push time in 3 months

push eventmolant/vscode

Martin Aeschlimann

commit sha 4c030c46d4ecadfb2c7ce624630f5d9d486d8920

[json] run serverless

view details

Sandeep Somavarapu

commit sha d6d6fb2cbf563b641ff7d86b1af5fd2d5fd66e25

#93368 Replace biased util with using extUri based on fileservice provider's case sensiive capability

view details

Rob Lourens

commit sha 2acd4eb7693e06761c66c7a899292a273478dec1

Don't render markdown cell in the background while typing Fix #99253

view details

isidor

commit sha 40fc91206551978a7235ba414bbf35d5d3f8b038

Change order of focus next part so panel is after editor fixes #99564

view details

Sandeep Somavarapu

commit sha f7b0d41e646ddd7a08cb532a9ea9286da2d4b002

use onDidChangeCapabilities event from the provider

view details

João Moreno

commit sha 08bf15f3592c531d99068c3d8e7bdde59c2c99be

make horizontalScrolling changeable at runtime

view details

João Moreno

commit sha 5dd0eb4e9dd0c1e15da6c777ab40a0444852e6ad

remove horizontal scrolling from restart settings

view details

isidor

commit sha 0762c3d12167bc2fee1fa18d9b36d797a8b2456e

fixes #99761

view details

João Moreno

commit sha 32a0c9ede4809dc5bb76da1449a3d72602ec279c

propagate horizontal scrolling setting update through workbench widgets

view details

SteVen Batten

commit sha fb6f16f8133a769a290354aae89a3beecd6a6046

add focus menu command for web fixes #82759

view details

Daniel Imms

commit sha 314446f954bbc0fbb6678ce25ca60bc764dd3d82

Move off deprecated node-pty on API

view details

Matt Bierner

commit sha 84487337d7cbf4210fdaabc02d13e6d4fd32ea38

Remove more unused files from the typescript package

view details

Matt Bierner

commit sha 3b3674290842cea06fe892d2b2002103b8ea99d2

Disable custom editors for some specific schemes Fixes #99906

view details

gjsjohnmurray

commit sha 49b0477399a5f9e83e5c1867e0e5b0d70ddc9ebd

fix #99854 make 'Edit in settings.json' add the default for an undefined object-type setting

view details

Martin Aeschlimann

commit sha 917064c80c53482ce8535f14d6f9f629df2874db

move polyfills to build/polyfills

view details

Martin Aeschlimann

commit sha 8e58baf50d813e38c1d6e9ae6d6b193d5bedd5b9

configuration-editing serverless

view details

Martin Aeschlimann

commit sha 9007dfc97139d616dd6f972b411b8666b9857cc2

json webpack fixes

view details

rebornix

commit sha cc937a368cdd37a55a27a4ac916ecd7ce0dcfe0a

Undo/Redo for split/join cells. Fix #99158.

view details

Andre Weinand

commit sha e3df1e23cc9cbfb288fd1e614ebfb08e7bda6d7d

fix naming

view details

Eric Amodio

commit sha 9e0ab5ca6b9d9aa19666a808b06bdb315fd212aa

Fixes #96939 - reworks default view layout api

view details

push time in 3 months

push eventmolant/vscode

push time in 3 months

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 export default class ManifestIconHint implements IHint {             return validSizes;         }; +        const validatePurposesValues = (purposes: string[], resource: string, iconIndex: number, getLocation: JSONLocationFunction) => {+            for (const purpose of purposes) {+                // Check if the purpose is valid.+                if (!validPurposes.includes(purpose)) {+                    context.report(resource, getMessage('iconPurposeInvalid', context.language, purpose), {+                        location: getLocation(`icons[${iconIndex}].purpose`),+                        severity: Severity.warning+                    });+                }+            }+            console.log(iconIndex);+        };++        const validateDuplicatedValues = (purposes: string[], resource: string, iconIndex: number, getLocation: JSONLocationFunction) => {+            /*+             * Creating a set will remove automatically the duplicated items.+             */+            const purposesSet = new Set(purposes);++            if (purposes.length === purposesSet.size) {+                // No duplicated found.+                return;+            }++            const purposesCopy = [...purposes];++            for (const purpose of purposesSet) {+                const purposeIndex = purposesCopy.indexOf(purpose);++                if (purposeIndex >= 0) {+                    purposesCopy.splice(purposeIndex, 1);+                }+            }++            /*+             * Check if purposesCopy contains any purpose, if so, those+             * items are duplicated.+             */+            if (purposesCopy.length > 0) {+                context.report(resource, getMessage('iconPurposeDuplicate', context.language, [...(new Set(purposesCopy))].join(' ')), {+                    location: getLocation(`icons[${iconIndex}].purpose`),+                    severity: Severity.hint+                });+            }++            console.log(getMessage('iconPurposeDuplicate', context.language, [...(new Set(purposesCopy))].join(' ')));+            console.log(getLocation(`icons[${iconIndex}].purpose`));+            console.log(iconIndex);

Are this leftovers or did you intend to use debug instead?

sarvaje

comment created time in 3 months

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 export default class ManifestIconHint implements IHint {             return validSizes;         }; +        const validatePurposesValues = (purposes: string[], resource: string, iconIndex: number, getLocation: JSONLocationFunction) => {+            for (const purpose of purposes) {+                // Check if the purpose is valid.+                if (!validPurposes.includes(purpose)) {+                    context.report(resource, getMessage('iconPurposeInvalid', context.language, purpose), {+                        location: getLocation(`icons[${iconIndex}].purpose`),+                        severity: Severity.warning+                    });+                }+            }+            console.log(iconIndex);
sarvaje

comment created time in 3 months

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 const tests: HintTest[] = [                                 "sizes": "192x192",                                 "type": "image/png"                             }-                            ]+                        ]+                    }`+            }+        }+    },+    {+        name: 'Duplicated purpose found',

English isn't @sarvaje's nor mine first language so any grammar, spelling, or style corrections are more than welcome 😊

Thanks a lot!

sarvaje

comment created time in 3 months

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 export default class ManifestIconHint implements IHint {             return validSizes;         }; +        const validateIconsPurpose = (icons: ManifestImageResource[], resource: string, getLocation: JSONLocationFunction) => {+            for (let iconIndex = 0; iconIndex < icons.length; iconIndex++) {+                const icon = icons[iconIndex];++                if (!icon.purpose) {+                    continue;+                }++                const purposes = icon.purpose.split(' ').filter((purpose) => {+                    return purpose;+                });+                const purposesSet = new Set(purposes);++                for (const purpose of purposesSet) {+                    if (!validPurposes.includes(purpose)) {+                        context.report(resource, getMessage('iconPurposeInvalid', context.language, purpose), {+                            location: getLocation(`icons[${iconIndex}].purpose`),+                            severity: Severity.warning+                        });+                    }++                    const purposeIndex = purposes.indexOf(purpose);++                    if (purposeIndex >= 0) {+                        purposes.splice(purposeIndex, 1);+                    }+                }++                if (purposes.length > 0) {

I think it might be we are doing things in 2 different places.

What about filtering/finding duplicated in the same place?

if (purposes.length !== purposesSet.size) {
  // Check if it's duplicated here and report
}

That way if we want to refactor that code into another function we can. We might have to do an extra loop but it should be negligible and make it better to read/maintain.

sarvaje

comment created time in 3 months

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 export default class ManifestIconHint implements IHint {             return validSizes;         }; +        const validateIconsPurpose = (icons: ManifestImageResource[], resource: string, getLocation: JSONLocationFunction) => {+            for (let iconIndex = 0; iconIndex < icons.length; iconIndex++) {+                const icon = icons[iconIndex];++                if (!icon.purpose) {+                    continue;+                }++                const purposes = icon.purpose.split(' ').filter((purpose) => {+                    return purpose;+                });

Let's optimize for readability then, I don't think we can really measure the impact of one or the other 😊

sarvaje

comment created time in 3 months

issue commentwebhintio/hint

New webhint release

@johnemau @sarvaje with the changes in #3848 we will be publishing the extension to open-vsx as well. Before releasing you will have to:

  • Log into open-vsx.org with your GitHub account
  • Let me know so I can add you to the webhint namespace
  • Get a token and add it top an env variable OVSX_TOKEN

Let me know if you have any questions.

johnemau

comment created time in 3 months

pull request commentwebhintio/hint

New: Add publishing scripts for OVSX

And I totally forgot to comment on the PR: Authentication on Open VSX requires to log into open-vsx.org through GitHub and then creating an access token which is needed for the publishing to succeed

Yup, already did that and claimed the org, need to figure out now how I can add more people to the org because @johnemau is probably the next one doing a release...

I've pushed a new commit to your PR that fixes some linting errors. Waiting for CI to pass although should be fine.

Thanks a lot!

entepe85

comment created time in 3 months

push evententepe85/hint

Antón Molleda

commit sha acc9d99f12a4b1b6cb101893a88e0087de1e6df4

Chore: Linting errors

view details

push time in 3 months

pull request commentwebhintio/hint

New: Add publishing scripts for OVSX

This is quite curious. I signed the CLA and added my company email to my account.

You might want to make sure the commit is with your personal account and maybe redo the PR?

@sarvaje had a similar issue the other day IIRC.

entepe85

comment created time in 3 months

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 export default class ManifestIconHint implements IHint {             return validSizes;         }; +        const validateIconsPurpose = (icons: ManifestImageResource[], resource: string, getLocation: JSONLocationFunction) => {+            for (let iconIndex = 0; iconIndex < icons.length; iconIndex++) {+                const icon = icons[iconIndex];++                if (!icon.purpose) {+                    continue;+                }++                const purposes = icon.purpose.split(' ').filter((purpose) => {+                    return purpose;+                });

The following should work but at this time I'm not sure what's easier to read

                const purposes = icon.purpose.trim().replace(/\s\s*/g,' ').split(' ').;

@johnemau what do you think?

sarvaje

comment created time in 3 months

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 const tests: HintTest[] = [                                 "sizes": "192x192",                                 "type": "image/png"                             }-                            ]+                        ]+                    }`+            }+        }+    },+    {+        name: 'Duplicated purpose found',+        reports: [+            {+                message: `Duplicate value(s) found in icon purpose porperty: any.`,+                position: {

I thought it was a bit more flexible. Not worth doing it then.

sarvaje

comment created time in 3 months

issue commentwebhintio/hint

Release manifest-icons

There are 2 PWA hints that are not published: https://github.com/webhintio/hint/issues/2351

This one is to track manifest-icons exclusively.

  • [ ] Once #3841 is done, badge
  • [ ] Update docs and also point to the w3c manifest above in the section about issues
molant

comment created time in 3 months

issue openedwebhintio/hint

Release manifest-icons

@sarvaje @hxlnt this hint is still not published "officially" although it seems we are using it seems to be active in different places. IIRC the missing piece was to update the documentation. Ideally we should do the badge/monochrome before we "release" it.

https://github.com/w3c/manifest/pull/833#issuecomment-645756918

Confirmed that Chrome does not use purpose: badge anywhere, including on the server-side infrastructure. From our perspective, we are good to rename it and change its semantics. LGTM.

@amazingcaio, thanks for catching this change!

Originally posted by @molant in https://github.com/webhintio/hint/pull/3841/review_comment/create

created time in 3 months

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 import { extname } from 'path';  const debug: debug.IDebugger = d(__filename); +// Valid values for icon purpose property.+const validPurposes = ['any', 'maskable', 'badge', 'monochrome'];

@sarvaje @hxlnt this hint is still not published "officially" although it seems we are using it seems to be active in different places. IIRC the missing piece was to update the documentation. Ideally we should do the badge/monochrome before we "release" it.

https://github.com/w3c/manifest/pull/833#issuecomment-645756918

Confirmed that Chrome does not use purpose: badge anywhere, including on the server-side infrastructure. From our perspective, we are good to rename it and change its semantics. LGTM.

@amazingcaio, thanks for catching this change!

sarvaje

comment created time in 3 months

push eventwebhintio/serverless-online-service

Jesus David García Gomez

commit sha 718ebea9adb2d189b2411456c2d658ae50f725bd

Chore: Update Octokit types and version There was a mismatch between types and package that was preventing the project from compiling without a `package-lock.json`. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Fix #32 Close #36

view details

push time in 3 months

PR merged webhintio/serverless-online-service

Reviewers
Fix: Compiling error

Fix #32

+120 -88

0 comment

3 changed files

sarvaje

pr closed time in 3 months

issue closedwebhintio/serverless-online-service

Project fails compiling

src/github/issuereporter.ts(25,22): error TS2709: Cannot use namespace 'Octokit' as a type.
src/github/issuereporter.ts(34,28): error TS2351: This expression is not constructable.
  Type 'typeof import("/home/site/utils/node_modules/@octokit/rest/index")' has no construct signatures.
src/github/issuereporter.ts(51,44): error TS2694: Namespace '"/home/site/utils/node_modules/@octokit/rest/index"' has no exported member 'SearchIssuesResponseItemsItem'.
src/github/issuereporter.ts(61,45): error TS2694: Namespace '"/home/site/utils/node_modules/@octokit/rest/index"' has no exported member 'SearchIssuesResponseItemsItem'.
src/github/issuereporter.ts(68,48): error TS2694: Namespace '"/home/site/utils/node_modules/@octokit/rest/index"' has no exported member 'IssuesUpdateParams'.
src/github/issuereporter.ts(73,22): error TS2694: Namespace '"/home/site/utils/node_modules/@octokit/rest/index"' has no exported member 'IssuesUpdateParams'.
src/github/issuereporter.ts(206,51): error TS7006: Parameter 'label' implicitly has an 'any' type.
src/github/issuereporter.ts(225,52): error TS2694: Namespace '"/home/site/utils/node_modules/@octokit/rest/index"' has no exported member 'SearchIssuesResponseItemsItem'.

/cc @hxlnt @sarvaje

closed time in 3 months

molant

push eventwebhintio/serverless-online-service

Jesus David García Gomez

commit sha 55d1096369398daaf553de501f1974558fb179a8

Fix: Dependabot configuration Fix #35 Close #37

view details

push time in 3 months

issue closedwebhintio/serverless-online-service

Your .dependabot/config.yml contained invalid details

Dependabot encountered the following error when parsing your .dependabot/config.yml:

The property '#/update_configs/0/ignored_updates' of type null did not match the following type: array

Please update the config file to conform with Dependabot's specification using our docs and online validator.

closed time in 3 months

dependabot-preview[bot]

Pull request review commentwebhintio/serverless-online-service

Fix: Compiling error

 type GithubData = {     repo: string; } +/*+ * Octokit/types doesn't define a type for the items in a search and+ * doesn't export the type IssuesUpdateEndpoint.+ * These are a copy/paste of what they have in their code.+ * Any suggestion to do this in a better way?

Is there an issue opened reporting this? If so can you put the link in here?

sarvaje

comment created time in 3 months

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 const tests: HintTest[] = [                                 "sizes": "192x192",                                 "type": "image/png"                             }-                            ]+                        ]+                    }`+            }+        }+    },+    {+        name: 'Duplicated purpose found',+        reports: [+            {+                message: `Duplicate value(s) found in icon purpose porperty: any.`,+                position: {

Maybe we could use the position matching so this is easier to maintain in the future?

sarvaje

comment created time in 3 months

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 export default class ManifestIconHint implements IHint {             return validSizes;         }; +        const validateIconsPurpose = (icons: ManifestImageResource[], resource: string, getLocation: JSONLocationFunction) => {+            for (let iconIndex = 0; iconIndex < icons.length; iconIndex++) {+                const icon = icons[iconIndex];++                if (!icon.purpose) {+                    continue;+                }++                const purposes = icon.purpose.split(' ').filter((purpose) => {+                    return purpose;+                });+                const purposesSet = new Set(purposes);++                for (const purpose of purposesSet) {+                    if (!validPurposes.includes(purpose)) {+                        context.report(resource, getMessage('iconPurposeInvalid', context.language, purpose), {+                            location: getLocation(`icons[${iconIndex}].purpose`),+                            severity: Severity.warning+                        });+                    }++                    const purposeIndex = purposes.indexOf(purpose);++                    if (purposeIndex >= 0) {+                        purposes.splice(purposeIndex, 1);+                    }+                }++                if (purposes.length > 0) {

It took me a bit to figure out what you were doing in here and why purposes.length had to be 0 by line 301.

What do you think of instead doing this:

                }

                if (purposes.length !== purposesSet.size) {
sarvaje

comment created time in 3 months

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 export default class ManifestIconHint implements IHint {             return validSizes;         }; +        const validateIconsPurpose = (icons: ManifestImageResource[], resource: string, getLocation: JSONLocationFunction) => {+            for (let iconIndex = 0; iconIndex < icons.length; iconIndex++) {+                const icon = icons[iconIndex];++                if (!icon.purpose) {+                    continue;+                }++                const purposes = icon.purpose.split(' ').filter((purpose) => {+                    return purpose;+                });

Is this filter to remove any possible trailing space? For example, if the purpose is maskable badge? If so I think it will be more readable if you just do this:

                const purposes = icon.purpose.trim().split(' ');
sarvaje

comment created time in 3 months

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 export default class ManifestIconHint implements IHint {             return validSizes;         }; +        const validateIconsPurpose = (icons: ManifestImageResource[], resource: string, getLocation: JSONLocationFunction) => {

        // See https://w3c.github.io/manifest/#purpose-member
        const validateIconsPurpose = (icons: ManifestImageResource[], resource: string, getLocation: JSONLocationFunction) => {
sarvaje

comment created time in 3 months

push eventwebhintio/hint

Jesus David García Gomez

commit sha 6ac40b384d61dd20142b77e8bad9228d12c8b6b2

Chore: Update AVA test configuration in launch.json Fix #3838 Close #3842

view details

push time in 3 months

PR merged webhintio/hint

Reviewers
Fix: Run AVA test configuration in launch.json

Fix #3838

<!--

Read our pull request guide: https://webhint.io/docs/contributor-guide/getting-started/pull-requests/

For the following items put an "x" between the square brackets (i.e. [x]) if you completed the associated item.

-->

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • [ ] Added/Updated related documentation.
  • [ ] Added/Updated related tests.

Short description of the change(s)

<!--

If this is a non-trivial change, include information such as what benefits this change brings as well as possible drawbacks.

If this fixes an existing issue, include the relevant issue number(s).

Thank you for taking the time to open this PR!

-->

+6 -3

0 comment

1 changed file

sarvaje

pr closed time in 3 months

more