profile
viewpoint
Antón Molleda molant Microsoft Seattle https://webhint.io @molant is currently unavailable, please leave a message

microsoft/edge-diagnostics-adapter 124

Microsoft Edge Diagnostics Adapter is a protocol adapter that enables tools to debug Microsoft Edge using the Chrome DevTools Protocol.

htmlhint/chai-htmlhint 3

Extends Chai with assertions for HTMLHint

molant/arbor 1

a graph visualization library using web workers and jQuery

molant/BrowserExperiments 1

Experiments with shims

molant/angular-seed 0

Seed project for angular apps.

molant/angular.js 0

HTML enhanced for web apps

issue closedwebhintio/hint

[Bug] Bug description

<!--

Hi there 👋

Thanks for taking the time to make webhint better! Before opening a new issue please take a look at the troubleshoot guide: https://webhint.io/docs/user-guide/troubleshoot/summary/ and make sure to search the existing ones (even closed!) as they might contain information about workarounds, resolution, or progress updates.

-->

🐛 Bug report

Description

<!-- ✍️ What were you doing? How do we repro your issue? -->

Environment

  • webhint version: 2.1.0 <!-- ✍️ Menu > Add-ons / Extensions -->
  • Browser version: Mozilla/5.0 (X11; Linux x86_64; rv:77.0) Gecko/20100101 Firefox/77.0 <!-- ✍️ Menu > Help > About -->
  • URL for which webhint failed: <!-- ✍️ -->

webhint configuration

<details> <summary>webhint’s configuration</summary>

Categories:

  • [x] Accessibility
  • [x] Compatibility
  • [x] Performance
  • [x] Pitfalls
  • [x] PWA
  • [x] Security

Your target browsers:

  • [x] Recommended settings
  • [ ] Custom: <!-- Custom target browsers -->

Ignored resources:

    • [x] None
    • [ ] Different origin
    • [ ] Custom: <!-- Custom ignored resources -->

</details>

Debug output

Please include the content of the Error details section if an error message was displayed.

<details> <summary>webhint’s Error details</summary>

Scan timed out.



</details>

closed time in 16 hours

hellosct1

Pull request review commentwebhintio/hint

Fix: Improve utils-dom querySelector perf by using cssSelect.selectOne

 export class HTMLDocument extends Node {     /**      * https://developer.mozilla.org/docs/Web/API/Document/querySelector      */-    public querySelector(selector: string): HTMLElement {-        return this.querySelectorAll(selector)[0];+    public querySelector(selector: string): HTMLElement | null {+        if (!CACHED_CSS_SELECTORS.has(selector)) {+            CACHED_CSS_SELECTORS.set(selector, cssSelect.compile(selector));+        }++        const data: any | undefined = cssSelect.selectOne(+            CACHED_CSS_SELECTORS.get(selector) as cssSelect.CompiledQuery,

Can't the cache cause troubles if we switch to analyze continuously?

johnemau

comment created time in 16 hours

Pull request review commentwebhintio/hint

Fix: Improve utils-dom querySelector perf by using cssSelect.selectOne

 export class HTMLDocument extends Node {     /**      * https://developer.mozilla.org/docs/Web/API/Document/querySelector      */-    public querySelector(selector: string): HTMLElement {-        return this.querySelectorAll(selector)[0];+    public querySelector(selector: string): HTMLElement | null {+        if (!CACHED_CSS_SELECTORS.has(selector)) {+            CACHED_CSS_SELECTORS.set(selector, cssSelect.compile(selector));+        }++        const data: any | undefined = cssSelect.selectOne(

Can we use NodeData in here or is that causing any types issue? If so, maybe we should cast it already here instead of pass any around?

johnemau

comment created time in 16 hours

issue commentwebhintio/hint

webhint meeting 2020-07-09

@hxlnt i won't be able to attend. Will be good to find something fo the issue about browserlist and development environment.

hxlnt

comment created time in a day

pull request commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

@sarvaje is this ready for another review?

sarvaje

comment created time in 4 days

push eventwebhintio/hint

Nils Torbjörn Petersen

commit sha 2d4732f999bd54f0e649ba51d7f783e4eb23f775

Build: Add publishing scripts for OVSX Fix #3831 Close #3848 Co-authored-by: Antón Molleda <amolleda@gmail.com>

view details

push time in 4 days

issue closedwebhintio/hint

Please publish the VSCode extension on OpenVSX

I'm a VS Codium user, a FLOSS version of VS Code. It's the same code but without Microsoft's telemetry, branding and licensing.

I would like to request, if possible, to add the webhint extension to the open-vsx.org market as it is unclear if it's legal to use the official Microsoft extension marketplace on VS Code forks, see here.

Additional information on how to publish an extension to Open VSX can be obtained here.

closed time in 4 days

entepe85

PR merged webhintio/hint

Reviewers
New: Add publishing scripts for OVSX

<!--

Read our pull request guide: https://webhint.io/docs/contributor-guide/getting-started/pull-requests/

For the following items put an "x" between the square brackets (i.e. [x]) if you completed the associated item.

-->

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • [ ] Added/Updated related documentation.
  • [ ] Added/Updated related tests.

Short description of the change(s)

<!--

If this is a non-trivial change, include information such as what benefits this change brings as well as possible drawbacks.

If this fixes an existing issue, include the relevant issue number(s).

Thank you for taking the time to open this PR!

-->

+38 -1

6 comments

2 changed files

entepe85

pr closed time in 4 days

push eventwebhintio/hint

Patrick Brosset

commit sha a37a7a39ee27ecb8ed289d1e8c74014a6895e5e0

Fix: Break header text anywhere needed If a report is generated on a site with a very long URL, horizontal overflow can happen. We want to avoid this as it forces users to scroll horizontally to reveal the content. To do this, we make sure the header text can break anywhere. - - - - - - - - - - - - - - - - - - - - - - - - - - Fix #3587 Close #3855

view details

push time in 4 days

PR merged webhintio/hint

Reviewers
Fix: Break header text anywhere needed

If a report is generated on a site with a very long URL, horizontal overflow can happen. We want to avoid this as it forces users to scroll horizontally to reveal the content.

To do this, we make sure the header text can break anywhere.

Fix #3587

+1 -1

0 comment

1 changed file

captainbrosset

pr closed time in 4 days

issue closedwebhintio/hint

[Bug] Long URLs break word wrap in results

🐛 Bug report

Description

When I run a scan against a very long URL, word wrap breaks in the results.

long-url

Environment

  • webhint version: 1.2.1
  • Browser version: Edge Beta (80)

closed time in 4 days

hxlnt

issue commentwebhintio/hint

[Bug] package.json browserslist with multiple environments

Thanks for reporting this @zmeyc!

Wonder what is going on. We delegate everything to the browserslist package to find the right configuration. For more context about environments there's https://github.com/browserslist/browserslist#configuring-for-different-environments

@hxlnt adding this to the agenda so we can talk about it this Friday 😊

zmeyc

comment created time in 4 days

push eventmolant/vscode

Antón Molleda

commit sha 919334666fa58b9fc2483cbdfd76a55cf3076e94

Add MetaModules to workspace tags

view details

push time in 10 days

push eventmolant/vscode

Martin Aeschlimann

commit sha 4c030c46d4ecadfb2c7ce624630f5d9d486d8920

[json] run serverless

view details

Sandeep Somavarapu

commit sha d6d6fb2cbf563b641ff7d86b1af5fd2d5fd66e25

#93368 Replace biased util with using extUri based on fileservice provider's case sensiive capability

view details

Rob Lourens

commit sha 2acd4eb7693e06761c66c7a899292a273478dec1

Don't render markdown cell in the background while typing Fix #99253

view details

isidor

commit sha 40fc91206551978a7235ba414bbf35d5d3f8b038

Change order of focus next part so panel is after editor fixes #99564

view details

Sandeep Somavarapu

commit sha f7b0d41e646ddd7a08cb532a9ea9286da2d4b002

use onDidChangeCapabilities event from the provider

view details

João Moreno

commit sha 08bf15f3592c531d99068c3d8e7bdde59c2c99be

make horizontalScrolling changeable at runtime

view details

João Moreno

commit sha 5dd0eb4e9dd0c1e15da6c777ab40a0444852e6ad

remove horizontal scrolling from restart settings

view details

isidor

commit sha 0762c3d12167bc2fee1fa18d9b36d797a8b2456e

fixes #99761

view details

João Moreno

commit sha 32a0c9ede4809dc5bb76da1449a3d72602ec279c

propagate horizontal scrolling setting update through workbench widgets

view details

SteVen Batten

commit sha fb6f16f8133a769a290354aae89a3beecd6a6046

add focus menu command for web fixes #82759

view details

Daniel Imms

commit sha 314446f954bbc0fbb6678ce25ca60bc764dd3d82

Move off deprecated node-pty on API

view details

Matt Bierner

commit sha 84487337d7cbf4210fdaabc02d13e6d4fd32ea38

Remove more unused files from the typescript package

view details

Matt Bierner

commit sha 3b3674290842cea06fe892d2b2002103b8ea99d2

Disable custom editors for some specific schemes Fixes #99906

view details

gjsjohnmurray

commit sha 49b0477399a5f9e83e5c1867e0e5b0d70ddc9ebd

fix #99854 make 'Edit in settings.json' add the default for an undefined object-type setting

view details

Martin Aeschlimann

commit sha 917064c80c53482ce8535f14d6f9f629df2874db

move polyfills to build/polyfills

view details

Martin Aeschlimann

commit sha 8e58baf50d813e38c1d6e9ae6d6b193d5bedd5b9

configuration-editing serverless

view details

Martin Aeschlimann

commit sha 9007dfc97139d616dd6f972b411b8666b9857cc2

json webpack fixes

view details

rebornix

commit sha cc937a368cdd37a55a27a4ac916ecd7ce0dcfe0a

Undo/Redo for split/join cells. Fix #99158.

view details

Andre Weinand

commit sha e3df1e23cc9cbfb288fd1e614ebfb08e7bda6d7d

fix naming

view details

Eric Amodio

commit sha 9e0ab5ca6b9d9aa19666a808b06bdb315fd212aa

Fixes #96939 - reworks default view layout api

view details

push time in 10 days

push eventmolant/vscode

push time in 10 days

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 export default class ManifestIconHint implements IHint {             return validSizes;         }; +        const validatePurposesValues = (purposes: string[], resource: string, iconIndex: number, getLocation: JSONLocationFunction) => {+            for (const purpose of purposes) {+                // Check if the purpose is valid.+                if (!validPurposes.includes(purpose)) {+                    context.report(resource, getMessage('iconPurposeInvalid', context.language, purpose), {+                        location: getLocation(`icons[${iconIndex}].purpose`),+                        severity: Severity.warning+                    });+                }+            }+            console.log(iconIndex);+        };++        const validateDuplicatedValues = (purposes: string[], resource: string, iconIndex: number, getLocation: JSONLocationFunction) => {+            /*+             * Creating a set will remove automatically the duplicated items.+             */+            const purposesSet = new Set(purposes);++            if (purposes.length === purposesSet.size) {+                // No duplicated found.+                return;+            }++            const purposesCopy = [...purposes];++            for (const purpose of purposesSet) {+                const purposeIndex = purposesCopy.indexOf(purpose);++                if (purposeIndex >= 0) {+                    purposesCopy.splice(purposeIndex, 1);+                }+            }++            /*+             * Check if purposesCopy contains any purpose, if so, those+             * items are duplicated.+             */+            if (purposesCopy.length > 0) {+                context.report(resource, getMessage('iconPurposeDuplicate', context.language, [...(new Set(purposesCopy))].join(' ')), {+                    location: getLocation(`icons[${iconIndex}].purpose`),+                    severity: Severity.hint+                });+            }++            console.log(getMessage('iconPurposeDuplicate', context.language, [...(new Set(purposesCopy))].join(' ')));+            console.log(getLocation(`icons[${iconIndex}].purpose`));+            console.log(iconIndex);

Are this leftovers or did you intend to use debug instead?

sarvaje

comment created time in 11 days

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 export default class ManifestIconHint implements IHint {             return validSizes;         }; +        const validatePurposesValues = (purposes: string[], resource: string, iconIndex: number, getLocation: JSONLocationFunction) => {+            for (const purpose of purposes) {+                // Check if the purpose is valid.+                if (!validPurposes.includes(purpose)) {+                    context.report(resource, getMessage('iconPurposeInvalid', context.language, purpose), {+                        location: getLocation(`icons[${iconIndex}].purpose`),+                        severity: Severity.warning+                    });+                }+            }+            console.log(iconIndex);
sarvaje

comment created time in 11 days

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 const tests: HintTest[] = [                                 "sizes": "192x192",                                 "type": "image/png"                             }-                            ]+                        ]+                    }`+            }+        }+    },+    {+        name: 'Duplicated purpose found',

English isn't @sarvaje's nor mine first language so any grammar, spelling, or style corrections are more than welcome 😊

Thanks a lot!

sarvaje

comment created time in 11 days

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 export default class ManifestIconHint implements IHint {             return validSizes;         }; +        const validateIconsPurpose = (icons: ManifestImageResource[], resource: string, getLocation: JSONLocationFunction) => {+            for (let iconIndex = 0; iconIndex < icons.length; iconIndex++) {+                const icon = icons[iconIndex];++                if (!icon.purpose) {+                    continue;+                }++                const purposes = icon.purpose.split(' ').filter((purpose) => {+                    return purpose;+                });+                const purposesSet = new Set(purposes);++                for (const purpose of purposesSet) {+                    if (!validPurposes.includes(purpose)) {+                        context.report(resource, getMessage('iconPurposeInvalid', context.language, purpose), {+                            location: getLocation(`icons[${iconIndex}].purpose`),+                            severity: Severity.warning+                        });+                    }++                    const purposeIndex = purposes.indexOf(purpose);++                    if (purposeIndex >= 0) {+                        purposes.splice(purposeIndex, 1);+                    }+                }++                if (purposes.length > 0) {

I think it might be we are doing things in 2 different places.

What about filtering/finding duplicated in the same place?

if (purposes.length !== purposesSet.size) {
  // Check if it's duplicated here and report
}

That way if we want to refactor that code into another function we can. We might have to do an extra loop but it should be negligible and make it better to read/maintain.

sarvaje

comment created time in 12 days

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 export default class ManifestIconHint implements IHint {             return validSizes;         }; +        const validateIconsPurpose = (icons: ManifestImageResource[], resource: string, getLocation: JSONLocationFunction) => {+            for (let iconIndex = 0; iconIndex < icons.length; iconIndex++) {+                const icon = icons[iconIndex];++                if (!icon.purpose) {+                    continue;+                }++                const purposes = icon.purpose.split(' ').filter((purpose) => {+                    return purpose;+                });

Let's optimize for readability then, I don't think we can really measure the impact of one or the other 😊

sarvaje

comment created time in 12 days

issue commentwebhintio/hint

New webhint release

@johnemau @sarvaje with the changes in #3848 we will be publishing the extension to open-vsx as well. Before releasing you will have to:

  • Log into open-vsx.org with your GitHub account
  • Let me know so I can add you to the webhint namespace
  • Get a token and add it top an env variable OVSX_TOKEN

Let me know if you have any questions.

johnemau

comment created time in 12 days

pull request commentwebhintio/hint

New: Add publishing scripts for OVSX

And I totally forgot to comment on the PR: Authentication on Open VSX requires to log into open-vsx.org through GitHub and then creating an access token which is needed for the publishing to succeed

Yup, already did that and claimed the org, need to figure out now how I can add more people to the org because @johnemau is probably the next one doing a release...

I've pushed a new commit to your PR that fixes some linting errors. Waiting for CI to pass although should be fine.

Thanks a lot!

entepe85

comment created time in 12 days

push evententepe85/hint

Antón Molleda

commit sha acc9d99f12a4b1b6cb101893a88e0087de1e6df4

Chore: Linting errors

view details

push time in 12 days

pull request commentwebhintio/hint

New: Add publishing scripts for OVSX

This is quite curious. I signed the CLA and added my company email to my account.

You might want to make sure the commit is with your personal account and maybe redo the PR?

@sarvaje had a similar issue the other day IIRC.

entepe85

comment created time in 12 days

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 export default class ManifestIconHint implements IHint {             return validSizes;         }; +        const validateIconsPurpose = (icons: ManifestImageResource[], resource: string, getLocation: JSONLocationFunction) => {+            for (let iconIndex = 0; iconIndex < icons.length; iconIndex++) {+                const icon = icons[iconIndex];++                if (!icon.purpose) {+                    continue;+                }++                const purposes = icon.purpose.split(' ').filter((purpose) => {+                    return purpose;+                });

The following should work but at this time I'm not sure what's easier to read

                const purposes = icon.purpose.trim().replace(/\s\s*/g,' ').split(' ').;

@johnemau what do you think?

sarvaje

comment created time in 12 days

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 const tests: HintTest[] = [                                 "sizes": "192x192",                                 "type": "image/png"                             }-                            ]+                        ]+                    }`+            }+        }+    },+    {+        name: 'Duplicated purpose found',+        reports: [+            {+                message: `Duplicate value(s) found in icon purpose porperty: any.`,+                position: {

I thought it was a bit more flexible. Not worth doing it then.

sarvaje

comment created time in 12 days

issue commentwebhintio/hint

Release manifest-icons

There are 2 PWA hints that are not published: https://github.com/webhintio/hint/issues/2351

This one is to track manifest-icons exclusively.

  • [ ] Once #3841 is done, badge
  • [ ] Update docs and also point to the w3c manifest above in the section about issues
molant

comment created time in 12 days

issue openedwebhintio/hint

Release manifest-icons

@sarvaje @hxlnt this hint is still not published "officially" although it seems we are using it seems to be active in different places. IIRC the missing piece was to update the documentation. Ideally we should do the badge/monochrome before we "release" it.

https://github.com/w3c/manifest/pull/833#issuecomment-645756918

Confirmed that Chrome does not use purpose: badge anywhere, including on the server-side infrastructure. From our perspective, we are good to rename it and change its semantics. LGTM.

@amazingcaio, thanks for catching this change!

Originally posted by @molant in https://github.com/webhintio/hint/pull/3841/review_comment/create

created time in 12 days

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 import { extname } from 'path';  const debug: debug.IDebugger = d(__filename); +// Valid values for icon purpose property.+const validPurposes = ['any', 'maskable', 'badge', 'monochrome'];

@sarvaje @hxlnt this hint is still not published "officially" although it seems we are using it seems to be active in different places. IIRC the missing piece was to update the documentation. Ideally we should do the badge/monochrome before we "release" it.

https://github.com/w3c/manifest/pull/833#issuecomment-645756918

Confirmed that Chrome does not use purpose: badge anywhere, including on the server-side infrastructure. From our perspective, we are good to rename it and change its semantics. LGTM.

@amazingcaio, thanks for catching this change!

sarvaje

comment created time in 12 days

push eventwebhintio/serverless-online-service

Jesus David García Gomez

commit sha 718ebea9adb2d189b2411456c2d658ae50f725bd

Chore: Update Octokit types and version There was a mismatch between types and package that was preventing the project from compiling without a `package-lock.json`. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Fix #32 Close #36

view details

push time in 12 days

PR merged webhintio/serverless-online-service

Reviewers
Fix: Compiling error

Fix #32

+120 -88

0 comment

3 changed files

sarvaje

pr closed time in 12 days

issue closedwebhintio/serverless-online-service

Project fails compiling

src/github/issuereporter.ts(25,22): error TS2709: Cannot use namespace 'Octokit' as a type.
src/github/issuereporter.ts(34,28): error TS2351: This expression is not constructable.
  Type 'typeof import("/home/site/utils/node_modules/@octokit/rest/index")' has no construct signatures.
src/github/issuereporter.ts(51,44): error TS2694: Namespace '"/home/site/utils/node_modules/@octokit/rest/index"' has no exported member 'SearchIssuesResponseItemsItem'.
src/github/issuereporter.ts(61,45): error TS2694: Namespace '"/home/site/utils/node_modules/@octokit/rest/index"' has no exported member 'SearchIssuesResponseItemsItem'.
src/github/issuereporter.ts(68,48): error TS2694: Namespace '"/home/site/utils/node_modules/@octokit/rest/index"' has no exported member 'IssuesUpdateParams'.
src/github/issuereporter.ts(73,22): error TS2694: Namespace '"/home/site/utils/node_modules/@octokit/rest/index"' has no exported member 'IssuesUpdateParams'.
src/github/issuereporter.ts(206,51): error TS7006: Parameter 'label' implicitly has an 'any' type.
src/github/issuereporter.ts(225,52): error TS2694: Namespace '"/home/site/utils/node_modules/@octokit/rest/index"' has no exported member 'SearchIssuesResponseItemsItem'.

/cc @hxlnt @sarvaje

closed time in 12 days

molant

push eventwebhintio/serverless-online-service

Jesus David García Gomez

commit sha 55d1096369398daaf553de501f1974558fb179a8

Fix: Dependabot configuration Fix #35 Close #37

view details

push time in 12 days

issue closedwebhintio/serverless-online-service

Your .dependabot/config.yml contained invalid details

Dependabot encountered the following error when parsing your .dependabot/config.yml:

The property '#/update_configs/0/ignored_updates' of type null did not match the following type: array

Please update the config file to conform with Dependabot's specification using our docs and online validator.

closed time in 12 days

dependabot-preview[bot]

Pull request review commentwebhintio/serverless-online-service

Fix: Compiling error

 type GithubData = {     repo: string; } +/*+ * Octokit/types doesn't define a type for the items in a search and+ * doesn't export the type IssuesUpdateEndpoint.+ * These are a copy/paste of what they have in their code.+ * Any suggestion to do this in a better way?

Is there an issue opened reporting this? If so can you put the link in here?

sarvaje

comment created time in 15 days

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 const tests: HintTest[] = [                                 "sizes": "192x192",                                 "type": "image/png"                             }-                            ]+                        ]+                    }`+            }+        }+    },+    {+        name: 'Duplicated purpose found',+        reports: [+            {+                message: `Duplicate value(s) found in icon purpose porperty: any.`,+                position: {

Maybe we could use the position matching so this is easier to maintain in the future?

sarvaje

comment created time in 15 days

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 export default class ManifestIconHint implements IHint {             return validSizes;         }; +        const validateIconsPurpose = (icons: ManifestImageResource[], resource: string, getLocation: JSONLocationFunction) => {+            for (let iconIndex = 0; iconIndex < icons.length; iconIndex++) {+                const icon = icons[iconIndex];++                if (!icon.purpose) {+                    continue;+                }++                const purposes = icon.purpose.split(' ').filter((purpose) => {+                    return purpose;+                });+                const purposesSet = new Set(purposes);++                for (const purpose of purposesSet) {+                    if (!validPurposes.includes(purpose)) {+                        context.report(resource, getMessage('iconPurposeInvalid', context.language, purpose), {+                            location: getLocation(`icons[${iconIndex}].purpose`),+                            severity: Severity.warning+                        });+                    }++                    const purposeIndex = purposes.indexOf(purpose);++                    if (purposeIndex >= 0) {+                        purposes.splice(purposeIndex, 1);+                    }+                }++                if (purposes.length > 0) {

It took me a bit to figure out what you were doing in here and why purposes.length had to be 0 by line 301.

What do you think of instead doing this:

                }

                if (purposes.length !== purposesSet.size) {
sarvaje

comment created time in 15 days

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 export default class ManifestIconHint implements IHint {             return validSizes;         }; +        const validateIconsPurpose = (icons: ManifestImageResource[], resource: string, getLocation: JSONLocationFunction) => {+            for (let iconIndex = 0; iconIndex < icons.length; iconIndex++) {+                const icon = icons[iconIndex];++                if (!icon.purpose) {+                    continue;+                }++                const purposes = icon.purpose.split(' ').filter((purpose) => {+                    return purpose;+                });

Is this filter to remove any possible trailing space? For example, if the purpose is maskable badge? If so I think it will be more readable if you just do this:

                const purposes = icon.purpose.trim().split(' ');
sarvaje

comment created time in 15 days

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 export default class ManifestIconHint implements IHint {             return validSizes;         }; +        const validateIconsPurpose = (icons: ManifestImageResource[], resource: string, getLocation: JSONLocationFunction) => {

        // See https://w3c.github.io/manifest/#purpose-member
        const validateIconsPurpose = (icons: ManifestImageResource[], resource: string, getLocation: JSONLocationFunction) => {
sarvaje

comment created time in 15 days

push eventwebhintio/hint

Jesus David García Gomez

commit sha 6ac40b384d61dd20142b77e8bad9228d12c8b6b2

Chore: Update AVA test configuration in launch.json Fix #3838 Close #3842

view details

push time in 15 days

PR merged webhintio/hint

Reviewers
Fix: Run AVA test configuration in launch.json

Fix #3838

<!--

Read our pull request guide: https://webhint.io/docs/contributor-guide/getting-started/pull-requests/

For the following items put an "x" between the square brackets (i.e. [x]) if you completed the associated item.

-->

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • [ ] Added/Updated related documentation.
  • [ ] Added/Updated related tests.

Short description of the change(s)

<!--

If this is a non-trivial change, include information such as what benefits this change brings as well as possible drawbacks.

If this fixes an existing issue, include the relevant issue number(s).

Thank you for taking the time to open this PR!

-->

+6 -3

0 comment

1 changed file

sarvaje

pr closed time in 15 days

issue closedwebhintio/hint

[Bug] Update "Run AVA test" configuration in "launch.json"

<!--

Hi there 👋

Thanks for taking the time to make webhint better! Before opening a new issue please take a look at the troubleshoot guide: https://webhint.io/docs/user-guide/troubleshoot/summary/ and make sure to search the existing ones (even closed!) as they might contain information about workarounds, resolution, or progress updates.

-->

🐛 Bug report

Description

Looks like AVA has done some breaking change and the file profile.js doesn't exist anymore.

closed time in 15 days

sarvaje

push eventwebhintio/serverless-online-service

Jesus David García Gomez

commit sha eb781bfcaea059138662fdffe0ba3138b810f0e7

Chore: Add dependabot configuration Fix #33 Close #34

view details

push time in 15 days

issue commentwebhintio/serverless-online-service

Project fails compiling

I believe this was in CI. I don't remember downloading the project when I reported it. Is it compiling now?

molant

comment created time in 15 days

issue commentwebhintio/hint

Please publish the VSCode extension on OpenVSX

Hi @entepe85 we discussed this in today's meeting and we agreed to publish on open-vsx.org.

Because we want to make sure that package is up to date with the one published in the VS marketplace, the release script needs to be updated (see my previous comment).

Do you mind making a PR with those changes? If you run into any issues please let us know. Happy to help you along the way!

Also I'm claiming the webhint namespace. Do you think you can test things without publishing the extension?

entepe85

comment created time in 15 days

issue openedeclipse/open-vsx.org

Claiming namespace [webhint]

<!-- Briefly explain what makes you a legitimate owner of the namespace mentioned in the issue title. Please ensure that you have logged in to https://open-vsx.org at least once, otherwise we cannot process your request. -->

I'm one of the core maintainers of webhint.

In today's meeting we decided to publish our extension to Open VSX as well per a request done by @entepe85 in https://github.com/webhintio/hint/issues/3831

Webhint is an OpenJS Foundation project and the brand is trademarked. We would like to have ownership of this namespace to prevent any issues.

Thank you

created time in 15 days

issue commentwebhintio/hint

webhint team meeting 2020-06-26

webhint team meeting 2020-06-26 notes

Agenda items

  • #3831: We are OK publishing there too. Need to create an account and ask for a PR to automate the process in our release script
  • #3844: Investigate how to be added as part of GitHub Super Linter
  • webhintio/serverless-online-service#32: @sarvaje will take a look
  • webhintio/webhint.io#913: It will not work because in production static files are server via IIS. @utsavized will look into pulling that data from GA and see if we can consolidate it in Application Insights.

Next sprint

@johnemau is investigating some perf issues so he will probably won't have the time to contribute to this project @sarvaje will work on #3769 and #3791. There will be multiple PRs: One to update main, one per hint that will provide this information (compat, vulnerabilities, axe), and one per extension or formatter that needs to be updated. This is going to take a while so probably will spawn to another sprint. @molant will work on review PRs and try to fix the current dependabot PR issues @hxlnt will post the mockups for #3690 when they are finished

hxlnt

comment created time in 15 days

issue commentwebhintio/hint

webhint team meeting 2020-06-26

I might be even later than I expected so don't wait for me 😔

hxlnt

comment created time in 15 days

issue commentwebhintio/hint

webhint team meeting 2020-06-26

@hxlnt I'll arrive a few minutes late to the meeting.

hxlnt

comment created time in 16 days

issue commentwebhintio/hint

[Feature] Include links and text in problem reports

There's also the no vulnerable js libraries that should point to snyk (see #3780). By text I think we meant "Learn more in BLA" and then the formatter can use it or not.

antross

comment created time in 16 days

Pull request review commentwebhintio/webhint.io

DRAFT: Add telemetry for URL logging + update endpoint to match new API

 const configureRoutes = (app) => {     require('./routes/changelog.js')(app); }; +const trackUrlTelemetry = (req, res, next) => {+    var props = {+        url: req.url+    };++    if(req.query['source'] !== undefined) {+        props.source = req.query['source'];+    }++    telemetry.trackEvent('online-activity-url', props);+    next();+}+ const configureFallbacks = (app) => {+    app.use(trackUrlTelemetry);

We already have google analytics and can get this information (and more) from there. Is the plan to remove GA?

utsavized

comment created time in 17 days

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 export default class ManifestIconHint implements IHint {             }         }; +        const invalidManifest = ({ errors, resource }: ManifestInvalidSchema) => {+            for (const error of errors) {+                const isIconError = error.dataPath.match(iconsErrorRegex);++                if (isIconError) {+                    // Is error the right severity?+                    context.report(resource, getMessage('iconPurposeInvalid', context.language, isIconError[1]), {

That's what the spec says so...

sarvaje

comment created time in 17 days

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

         "description": "Report message when an icon request return an status code !== 200",         "message": "Icon could not be fetched (status code: $1)."     },+    "iconPurposeDuplicate": {+        "description": "Report message when an icon has a duplicate value in the property purpose",+        "message": "Duplicate value(s) '$1' found in icon purpose property."

SGTM

sarvaje

comment created time in 17 days

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

         "description": "Report message when an icon request return an status code !== 200",         "message": "Icon could not be fetched (status code: $1)."     },+    "iconPurposeDuplicate": {+        "description": "Report message when an icon has a duplicate value in the property purpose",+        "message": "Duplicate value(s) '$1' found in icon purpose property."+    },+    "iconPurposeInvalid": {+        "description": "Report message when an icon has an invalid value in the property purpose",+        "message": "Invalid icon property $1."
        "message": "Invalid icon property: $1."
sarvaje

comment created time in 17 days

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 export default class ManifestIconHint implements IHint {             }         }; +        const invalidManifest = ({ errors, resource }: ManifestInvalidSchema) => {+            for (const error of errors) {+                const isIconError = error.dataPath.match(iconsErrorRegex);++                if (isIconError) {+                    // Is error the right severity?+                    context.report(resource, getMessage('iconPurposeInvalid', context.language, isIconError[1]), {

The spec says the following:

If an icon contains multiple purposes, it could be used for any of those purposes. If none of the stated purposes are recognized, the icon is totally ignored. For example, if an icon has purpose "monochrome fizzbuzz", then it could be used as a monochrome icon, as "monochrome" is a valid purpose. However, if an icon just has the purpose "fizzbuzz", then it will be ignored.

That said, I think that we should have an Error if none of the purposes are recognized (the icon is not going to work so that's probably an error) and a warning otherwise. We could maybe lower the severity one level for each but probably at that moment we will have to look at other icons and what they do, etc. which might complicate things a lot for not a lot of value.

@Malvoz what do you think?

sarvaje

comment created time in 17 days

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

 export default class ManifestIconHint implements IHint {             return validSizes;         }; +        const validateIconsPurpose = (icons: ManifestImageResource[], resource: string, location: ProblemLocation | null) => {+            for (let index = 0; index < icons.length; index++) {+                const icon = icons[index];++                if (!icon.purpose) {+                    continue;+                }++                const purposes = compact(icon.purpose.split(' '));+                const purposesSet = new Set(purposes);++                for (const purpose of purposesSet) {+                    const index = purposes.indexOf(purpose);++                    if (index >= 0) {+                        purposes.splice(index, 1);+                    }+                }++                if (purposes.length > 0) {+                    // Is warning the right severity?+                    context.report(resource, getMessage('iconPurposeDuplicate', context.language, [...(new Set(purposes))].join(' ')), { location, severity: Severity.warning });

We might even want to lower the severity and mark it as a hint. Having a valid duplicate purpose doesn't break anything.

sarvaje

comment created time in 17 days

Pull request review commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

         "description": "Report message when an icon request return an status code !== 200",         "message": "Icon could not be fetched (status code: $1)."     },+    "iconPurposeDuplicate": {+        "description": "Report message when an icon has a duplicate value in the property purpose",+        "message": "Duplicate value(s) '$1' found in icon purpose property."

The convention is to use $1 at the end so localization is easier. @johnemau do you have any suggestions?

sarvaje

comment created time in 17 days

pull request commentwebhintio/hint

Fix: Icon purpose doesn't support combination of values

@sa change the author in the commit and reopen the pr?

sarvaje

comment created time in 17 days

Pull request review commentwebhintio/webhint.io

DRAFT: Add telemetry for URL logging + update endpoint to match new API

 const configureRoutes = (app) => {     require('./routes/changelog.js')(app); }; +const trackUrlTelemetry = (req, res, next) => {+    var props = {+        url: req.url+    };++    if(req.query['source'] !== undefined) {+        props.source = req.query['source'];+    }++    telemetry.trackEvent('online-activity-url', props);+    next();+}+ const configureFallbacks = (app) => {+    app.use(trackUrlTelemetry);

IIRC, this will only send telemetry for static assets. Is this what you want?

utsavized

comment created time in 18 days

push eventwebhintio/hint

Utsav Pandey

commit sha 90c39ddf8123526ecf9b1473251e675e6598ba0c

Chore: Update telemetry and contract Fix #3829 Close #3830

view details

push time in 18 days

PR merged webhintio/hint

Reviewers
New: Add endpoint/data contract to log telemetry to internal api

Closes #3829

+21 -40

3 comments

3 changed files

utsavized

pr closed time in 18 days

issue closedwebhintio/hint

[Feature] Update utils-telemetry package with new endpoint and data contract

Update utils-telemetry package with updated telemetry endpoint and also simplify data model.

closed time in 18 days

utsavized

push eventwebhintio/hint

dependabot-preview[bot]

commit sha b202cd528288471aca7b1a006099e4cbf311688b

Upgrade: Bump @types/vscode from 1.44.0 to 1.46.0 Bumps [@types/vscode](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/vscode) from 1.44.0 to 1.46.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/vscode) - - - - - - - - - - - - - - - - - - - - - Close #3746 Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Antón Molleda <amolleda@gmail.com>

view details

push time in 18 days

PR merged webhintio/hint

Reviewers
Upgrade: Bump @types/vscode from 1.44.0 to 1.45.1 dependencies

Bumps @types/vscode from 1.44.0 to 1.45.1. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/vscode">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

If all status checks pass Dependabot will automatically merge this pull request.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+6 -6

1 comment

2 changed files

dependabot-preview[bot]

pr closed time in 18 days

issue closedwebhintio/hint

Rename master branches

Per our team meeting on June 12, the team would like to do an en masse rename of master branches throughout our repos. I think we informally talked about changing it to "main," which works for me.

We may need to do some research on how to unblock impacts on our build pipeline and other dependencies, if any.

closed time in 18 days

hxlnt

issue commentwebhintio/hint

Rename master branches

This is done across the org except the archived repos, PRs included.

hxlnt

comment created time in 18 days

push eventwebhintio/hint

Antón Molleda

commit sha 93b972f324e866cfa6f53a94641c56fba02c29fe

Upgrade: Bump @types/vscode from 1.45.1 to 1.46.0

view details

push time in 18 days

delete branch webhintio/hint

delete branch : update-faq-support

delete time in 18 days

push eventwebhintio/hint

Antón Molleda

commit sha 87ac4ab571742bf4ef852ea936e7d621cc391e75

Chore: Move from master to main Fix #3809 Close #3837

view details

push time in 18 days

PR merged webhintio/hint

Reviewers
Chore: Move from master to main

Part of #3809 All the other repos have been renamed but this one is a bit trickier so doing a PR in case someone catches something I missed.

Once this is merged the only remaining task would be to change the default branch and delete master. If other PRs are merged in master before this PR should be rebased.

+50 -50

2 comments

20 changed files

molant

pr closed time in 18 days

Pull request review commentwebhintio/hint

Chore: Move from master to main

-# Scope the validations to master and PRs to master+# Scope the validations to main and PRs to main trigger:-  - master+    - main

an autoformatter when saving 😠 Should be fixed now

molant

comment created time in 19 days

push eventmolant/hint

Antón Molleda

commit sha 5fbbf15e0efee52124f94c6c0feb0b2c9a5d2394

Chore: PR Feedback

view details

push time in 19 days

pull request commentwebhintio/hint

Chore: Move from master to main

Windows timedout while installing dependencies but the others pass with no pbms.

@sarvaje can you take a look?

molant

comment created time in 19 days

PR closed webhintio/hint

Reviewers
Create Hom

<!-

Read our pull request guide: https://webhint.io/docs/contributor-guide/getting-started/pull-requests/

For the following items put an "x" between the square brackets (i.e. [x]) if you completed the associated item.

--

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • [ ] Added/Updated related documentation.
  • [ ] Added/Updated related tests.

Short description of the change(s)

<!--

If this is a non-trivial change, include information such as what benefits this change brings as well as possible drawbacks.

If this fixes an existing issue, include the relevant issue number(s).

Thank you for taking the time to open this PR!

-->

+1 -0

2 comments

1 changed file

Migilo

pr closed time in 19 days

pull request commentwebhintio/hint

Create Hom

@Migilo I'm closing this PR as we haven't heard back and we don't know the purpose of this PR.

If you still think that we should add it, feel free to provide more details about the purpose.

Thank you!

Migilo

comment created time in 19 days

push eventmolant/hint

Antón Molleda

commit sha 5e73cd7a4e6505238027a1f4515f9d3f103c3c68

Chore: Move from master to main

view details

push time in 19 days

issue openedwebhintio/serverless-online-service

Project fails compiling

src/github/issuereporter.ts(25,22): error TS2709: Cannot use namespace 'Octokit' as a type.
src/github/issuereporter.ts(34,28): error TS2351: This expression is not constructable.
  Type 'typeof import("/home/site/utils/node_modules/@octokit/rest/index")' has no construct signatures.
src/github/issuereporter.ts(51,44): error TS2694: Namespace '"/home/site/utils/node_modules/@octokit/rest/index"' has no exported member 'SearchIssuesResponseItemsItem'.
src/github/issuereporter.ts(61,45): error TS2694: Namespace '"/home/site/utils/node_modules/@octokit/rest/index"' has no exported member 'SearchIssuesResponseItemsItem'.
src/github/issuereporter.ts(68,48): error TS2694: Namespace '"/home/site/utils/node_modules/@octokit/rest/index"' has no exported member 'IssuesUpdateParams'.
src/github/issuereporter.ts(73,22): error TS2694: Namespace '"/home/site/utils/node_modules/@octokit/rest/index"' has no exported member 'IssuesUpdateParams'.
src/github/issuereporter.ts(206,51): error TS7006: Parameter 'label' implicitly has an 'any' type.
src/github/issuereporter.ts(225,52): error TS2694: Namespace '"/home/site/utils/node_modules/@octokit/rest/index"' has no exported member 'SearchIssuesResponseItemsItem'.

/cc @hxlnt @sarvaje

created time in 19 days

Pull request review commentwebhintio/hint

New: Add endpoint/data contract to log telemetry to internal api

 type Properties = { [key: string]: string };  type TelemetryItem = {     data: {-        baseData: {-            measurements: Measurements;-            name: string;-            properties: Properties;-            ver?: number;

TBH, I don't know. @antross it he one that took care of the telemetry and now you so probably you know best how it works 😅

Let's get #3837 merged first and then this one, sounds good?

utsavized

comment created time in 19 days

push eventwebhintio/webhint-ado-extension

Antón Molleda

commit sha dab5b52e8f64f278d7bda066ba0c187cf0cc8ede

Chore: Move from master to main

view details

push time in 19 days

push eventwebhintio/telemetry

Antón Molleda

commit sha 149d235aafaff5157a5052c5f1e210d0e68d15c6

Chore: Move from master to main

view details

push time in 19 days

push eventwebhintio/artwork

Antón Molleda

commit sha 8044762ac8d190aef85fcacd8e058ddc868f957a

Chore: Move from master to main

view details

push time in 19 days

PR opened webhintio/hint

Reviewers
Chore: Move from master to main

Part of #3809 All the other repos have been renamed but this one is a bit trickier so doing a PR in case someone catches something I missed.

Once this is merged the only remaining task would be to change the default branch and delete master. If other PRs are merged in master before this PR should be rebased.

+53 -53

0 comment

20 changed files

pr created time in 19 days

create barnchmolant/hint

branch : main-updates

created branch time in 19 days

create barnchwebhintio/hint

branch : main

created branch time in 19 days

delete branch webhintio/webhint.io

delete branch : patch-1

delete time in 19 days

delete branch webhintio/webhint.io

delete branch : patch

delete time in 19 days

delete branch webhintio/webhint.io

delete branch : functions/serverless

delete time in 19 days

delete branch webhintio/webhint.io

delete branch : dependabot/npm_and_yarn/ejs-2.6.2

delete time in 19 days

delete branch webhintio/webhint.io

delete branch : hintcount

delete time in 19 days

delete branch webhintio/webhint.io

delete branch : master

delete time in 19 days

push eventwebhintio/webhint.io

Antón Molleda

commit sha 97edfaae34939f4b14c4c118b8c1911d6ea8d8a8

Chore: Move from master to main

view details

push time in 19 days

create barnchwebhintio/webhint.io

branch : main

created branch time in 19 days

delete branch webhintio/serverless-online-service

delete branch : master

delete time in 19 days

push eventwebhintio/serverless-online-service

Antón Molleda

commit sha 479a7a1cc54d92e6806ad0032bd04507cc7431ac

Chore: Move from master to main

view details

push time in 19 days

create barnchwebhintio/serverless-online-service

branch : main

created branch time in 19 days

delete branch webhintio/.github

delete branch : master

delete time in 19 days

create barnchwebhintio/.github

branch : main

created branch time in 19 days

more