profile
viewpoint
Tom Preston-Werner mojombo @chatterbugapp, @redwoodjs, @preston-werner-ventures San Francisco http://tom.preston-werner.com

mojombo/chronic 3088

Chronic is a pure Ruby natural language date parser.

hackclub/hackclub 1977

🎓🏫 Hack Club is a nonprofit network of computer science clubs where members learn to code through tinkering and building projects

defunkt/github-gem 1108

`github` command line helper for simplifying your GitHub experience.

mojombo/clippy 954

Clippy is a very simple Flash widget that makes it possible to place arbitrary text onto the client's clipboard.

brianmario/charlock_holmes 917

Character encoding detection, brought to you by ICU

defunkt/hurl 523

Hurl makes HTTP requests.

mojombo/ernie 447

Ernie is an Erlang/Ruby BERT-RPC Server.

mojombo/erlectricity 339

Erlectricity exposes Ruby to Erlang and vice versa.

mojombo/bert 197

BERT (Binary ERlang Term) serialization library for Ruby.

mojombo/bertrpc 156

BERTRPC is a Ruby BERT-RPC client library.

pull request commentsemver/semver

feat: Add specification for SemVer Ranges

Well you could at least use standard notations to define how all those adhoc schemes behave.

isaacs

comment created time in 5 hours

pull request commentsemver/semver

feat: Add specification for SemVer Ranges

@jwdonahue That is not a bad idea in isolation, and perhaps even a better idea than what exists in the package management ecosystems today.

However, the goal of this range specification is not to design a maximally expressive syntax for version ranges. The goal is to standardize the way that existing major package managers express version ranges. Those package managers are represented by the team that owns this org and is thankfully too busy to make ecosystem-breaking changes to this spec on a regular basis. 😅

Already, this needs to be pared down quite a bit (as suggested by the comments from @indirect, @steveklabnik, and @Seldaek. We are paving cowpaths, and trying to cut an absolute minimum of new trail.

isaacs

comment created time in 8 hours

Pull request review commentredwoodjs/redwood

Router: Partial TS rewrite

 module.exports = (webpackEnv) => {             // .module.css (3), .css (4), .module.scss (5), .scss (6)             ...getStyleLoaders(isEnvProduction),             isEnvProduction && {+              // Will this still work now that it's a .tsx file intead of .js?               test: path.join(                 redwoodPaths.base,                 'node_modules/@redwoodjs/router/dist/splash-page'

Does anyone know if this matches .tsx files as well? (it used to be splash-page.js, now it's splash-page.tsx)

Tobbe

comment created time in 9 hours

pull request commentredwoodjs/redwood

Don't bundle Apollo Client if the user specify their own client

Docs See https://github.com/redwoodjs/redwoodjs.com/issues/528

Breaking I've labeled this and added to my release To Dos. Seems simple enough to explain. We should definitely focus on deprecation warnings and more graceful changes after v1.

Sound like a plan?

Tobbe

comment created time in 10 hours

pull request commentredwoodjs/redwood

Don't bundle Apollo Client if the user specify their own client

Nice! Moving forward, does this require:

  • any doc updates (I don't believe so)
  • any CRWA template or Tutorial updates (again, assuming not)
  • any upgrade instructions because of breaking change?

CRWA template update is part of this PR

image

This is also a breaking change. Whenever someone upgrades to the next release (0.24.0?) they'd have to do the update above manually.

The docs do mention <RedwoodProvider> in a few places. Those need to be updated to <RedwoodApolloProvider>. The tutorial is fine.

As for the breaking change, is it enough to just mention it in upgrade instructions? Or should I create a <RedwoodProvider> component that throws a helpful error message when/if someone tries to use it?

Tobbe

comment created time in 11 hours

pull request commentredwoodjs/redwood

Don't bundle Apollo Client if the user specify their own client

Nice! Moving forward, does this require:

  • any doc updates (I don't believe so)
  • any CRWA template or Tutorial updates (again, assuming not)
  • any upgrade instructions because of breaking change?
Tobbe

comment created time in 12 hours

issue commentredwoodjs/redwood

Config: Add redwood.toml setting to disable generating tests and storybook with every generator

Thanks for the work on this @jvanbaarsen! I agree with @thedavidprice and @mojombo, I like the individual options spelled out:

[generate]
tests = true
storybook = false

Everything else sounds good to me (default to true, generate a mock if generating either a test or a story, etc). On the api side it should create the scenarios.js file if it creates the test.js file.

cannikin

comment created time in 13 hours

pull request commentredwoodjs/redwood

Revise the CRWA package README

📦 PR Packages

<details><summary>Click to Show Package Download Links</summary>

https://rw-pr-redwoodjs-com.s3.amazonaws.com/1668/create-redwood-app-0.23.0-6130213.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1668/redwoodjs-api-0.23.0-6130213.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1668/redwoodjs-api-server-0.23.0-6130213.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1668/redwoodjs-auth-0.23.0-6130213.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1668/redwoodjs-cli-0.23.0-6130213.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1668/redwoodjs-core-0.23.0-6130213.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1668/redwoodjs-dev-server-0.23.0-6130213.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1668/redwoodjs-eslint-config-0.23.0-6130213.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1668/redwoodjs-eslint-plugin-redwood-0.23.0-6130213.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1668/redwoodjs-forms-0.23.0-6130213.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1668/redwoodjs-internal-0.23.0-6130213.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1668/redwoodjs-router-0.23.0-6130213.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1668/redwoodjs-structure-0.23.0-6130213.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1668/redwoodjs-testing-0.23.0-6130213.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1668/redwoodjs-web-0.23.0-6130213.tgz </details>

Install this PR by running yarn rw upgrade --pr 1668:0.23.0-6130213

thedavidprice

comment created time in 13 hours

PR opened redwoodjs/redwood

Revise the CRWA package README

Now that the create-redwood-app template has been integrated with the eponymous package, we should update the package README in time for the next release. This is also an opportunity to format the README more appropriately for display on NPM.

INTRO Will be visible on NPM at https://www.npmjs.com/package/create-redwood-app Note: open graph doesn't play nice with markup it seems

  • [ ] Add RedwoodJS one-line description
  • [ ] Add getting started: use yarn create ...
  • [ ] quick links to website + tutorial and help

EXISTING

  • [ ] Audit and complete or remove existing sections
  • [ ] Reference Contributing content from create-redwood-app repo
+19 -5

0 comment

1 changed file

pr created time in 14 hours

push eventredwoodjs/redwood

David S Price

commit sha 87044f5cea38d30fe850b0ed90b48d99308295e9

initial to tods

view details

David S Price

commit sha 6130213632b0dd07c6db5f6ce45bd25d80cc2161

misc

view details

push time in 14 hours

create barnchredwoodjs/redwood

branch : dsp-update-crwa-readme

created branch time in 14 hours

push eventredwoodjs/redwood

Tobbe Lundberg

commit sha c0f61647bb5f6521402e78e08da3e49a26f641c0

New export of <RedwoodApolloProvider>

view details

Tobbe Lundberg

commit sha 8e5b123a0270506181903c9462f82d1fda39f7c8

Merge pull request #1639 from Tobbe/tobbe-redwoodapolloprovider Don't bundle Apollo Client if the user specify their own client

view details

push time in 14 hours

PR merged redwoodjs/redwood

Don't bundle Apollo Client if the user specify their own client

Redwood bundles Apollo GraphQL, but offers the ability to specify your own GraphQL client. Unfortunately even when you use your own GraphQL client you'll still get Apollo bundled. This PR attempts to place Apollo's client outside of main, so if you do not use it it will not be bundled.

+39 -19

15 comments

10 changed files

Tobbe

pr closed time in 14 hours

pull request commentredwoodjs/redwood

Don't bundle Apollo Client if the user specify their own client

P.S. I wonder why "graphql" is packaged

I included it to use its print function, which takes a gql ast and transforms it to a string. I replaced it by this function in my index.js file

const gqlToString = (gqlAst) => {
  return gqlAst.loc?.source.body
}

And now it looks like this image

It was my understanding that we transpile the gql syntax at build-time, but maybe the babel-plugin isn't working properly... Or my understanding is misguided.

It's not transpiled. If it was my gqlToString function above wouldn't work (and wouldn't be needed)

Tobbe

comment created time in 14 hours

issue commentredwoodjs/redwood

Using file access for Vercel deployment

Would it be possible to override the default build command to inject an extra script right after yarn rw build?

Actually, @Tobbe and @viperfx I think that's worth a try -- after build:

zip -ur /dist/functionsgraphql.zip ./email/src/templates

viperfx

comment created time in 14 hours

issue commentredwoodjs/redwood

Using file access for Vercel deployment

Would it be possible to override the default build command to inject an extra script right after yarn rw build?

image

This script could place files in /dist/functions. Would that work?

viperfx

comment created time in 14 hours

issue commentredwoodjs/redwood

Config: Add redwood.toml setting to disable generating tests and storybook with every generator

@mojombo In the CLI I used stories. I was planning on doing the same here.

cannikin

comment created time in 15 hours

startedmojombo/grit

started time in 16 hours

startedmojombo/chronic

started time in 16 hours

issue commentredwoodjs/redwood

Prisma - Service generators findUnique replaces findOne

YUP this is done

dthyresson

comment created time in 16 hours

issue closedredwoodjs/redwood

Prisma - Service generators findUnique replaces findOne

Prisma will deprecate findOne in favor of findUnique in 2.12

https://www.prisma.io/docs/concepts/components/prisma-client/crud

Service generators should use findUnique as a result:

https://github.com/redwoodjs/redwood/blob/75b609c17ed036dcd9ba647f927499fbfcfe9692/packages/cli/src/commands/generate/service/templates/service.ts.template#L14

closed time in 16 hours

dthyresson

issue commentredwoodjs/redwood

Prisma - Service generators findUnique replaces findOne

@cannikin I believe we've handled this in both the generators and the docs+tutorial, correct? Please close if so!

dthyresson

comment created time in 17 hours

issue commentredwoodjs/redwood

Config: Add redwood.toml setting to disable generating tests and storybook with every generator

Mock Files --> perfect and well done! I hadn't reviewed code or functionality (yet).

Docs --> thank you in advance!

cannikin

comment created time in 17 hours

Pull request review commentredwoodjs/redwood

[Draft] Getting started with prerender

 import {   InMemoryCache,   useQuery,   useMutation,+  HttpLink, } from '@apollo/client'+import fetch from 'cross-fetch'

I'm now shimming fetch into the node.js context, during prerender. This now isn't required anymore

dac09

comment created time in 17 hours

issue commentredwoodjs/create-redwood-app

Closing this Repo after v0.24.0 release

Once v0.24.0 is released (should be this week), it will be time to archive this Repo. 2 of the 3 open PRs are stale and from Peter and me. I have already informed Danny that he needs to move his PR to the main repo.

I did change this Issue title and will pin it to the top of the Issues page. Also, I am watching for incoming.

Any other suggestions for quick/easy messaging this week? Thanks!

jvanbaarsen

comment created time in 17 hours

issue commentredwoodjs/redwood

Using file access for Vercel deployment

Are there any frameworks that provide this functionality in some way?

viperfx

comment created time in 17 hours

issue commentsemver/semver

conflict between a hyphen (-) in the version and rpmbuild

@jbigot - it would have been possible, but that's neither here nor there.

Defining a standardized mapping would be a good thing, that would probably resolve it.

markgalassi

comment created time in 18 hours

issue closedredwoodjs/redwood

Documentation: Forms - Document use of SelectField

While SelectField was added to the forms package, it is missing documentation.

image

Needs example with validation and error handling as well.

closed time in 19 hours

dthyresson

issue commentredwoodjs/redwood

Documentation: Forms - Document use of SelectField

Approved and merged redwoodjs/redwoodjs.com#526

dthyresson

comment created time in 19 hours

issue commentredwoodjs/redwood

Documentation: Forms - Document use of SelectField

One tiny wording change and we'll merge. The docs were excellent.

dthyresson

comment created time in 21 hours

more