profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/modocache/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Brian Gesiak modocache Jersey City, NJ https://modocache.io Compiler engineer @facebook.

apple/swift 55769

The Swift Programming Language

apple/swift-evolution 12168

This maintains proposals for changes and user-visible enhancements to the Swift Programming Language.

llvm/llvm-project 8576

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies. Note: the repository does not accept github pull requests at this moment. Please submit your patches at http://reviews.llvm.org.

apple/swift-package-manager 8244

The Package Manager for the Swift Programming Language

apple/swift-corelibs-foundation 4250

The Foundation Project, providing core utilities, internationalization, and OS independence

apple/swift-corelibs-libdispatch 2023

The libdispatch Project, (a.k.a. Grand Central Dispatch), for concurrency on multicore hardware

luisobo/Nocilla 1842

Testing HTTP requests has never been easier. Nocilla: Stunning HTTP stubbing for iOS and Mac OS X.

apple/swift-corelibs-xctest 894

The XCTest Project, A Swift core library for providing unit test support

apple/swift-llbuild 849

A low-level build system, used by Xcode and the Swift Package Manager

push eventllvm/llvm-project

Raphael Isemann

commit sha 00764c36edf88ae9806e8d57a6addb782e6ceae8

[lldb] Add support for evaluating expressions in static member functions At the moment the expression parser doesn't support evaluating expressions in static member functions and just pretends the expression is evaluated within a non-member function. This causes that all static members are inaccessible when doing unqualified name lookup. This patch adds support for evaluating in static member functions. It essentially just does the same setup as what LLDB is already doing for non-static member functions (i.e., wrapping the expression in a fake member function) with the difference that we now mark the wrapping function as static (to prevent access to non-static members). Reviewed By: shafik, jarin Differential Revision: https://reviews.llvm.org/D81550

view details

push time in a few seconds

push eventllvm/llvm-project

Nemanja Ivanovic

commit sha 092619cf6b8d33e8830221925c1174f5d373f1d2

[PowerPC] Improve codegen for vector fp to int widening conversions We currently do not utilize instructions that convert single precision vectors to doubleword integer vectors. These conversions come up in code occasionally and this improvement allows us to open code some functions that need to be added to altivec.h.

view details

push time in 11 minutes

push eventllvm/llvm-project

Thomas Schmeyer

commit sha 28b6726c4df399ea597a021f63dc1bc00814b316

[mlir] Move memref-tests from standard to memref folder. Split memref-test from standard test and move them to the folder MemRef. Differential Revision: https://reviews.llvm.org/D100950

view details

push time in 13 minutes

push eventllvm/llvm-project

Martin Storsjö

commit sha 8000e1f5789c423e7c447782de65c56d84b66e1e

[AArch64] Fix calling windows varargs with floats in fixed args from non-windows functions When inspecting the calling convention, for calling windows functions from a non-windows function, inspect the calling convention of the called function, not the caller. Also remove an unnecessary parameter to AArch64CallLowering OutgoingArgHandler. Differential Revision: https://reviews.llvm.org/D100890

view details

push time in an hour

pull request commentSwiftWeekly/swiftweekly.github.io

Issue 183

@fassko Ready when this pull request is to send it out. :) Let's hope @JaredHalpern and @morqon have some time to do their review.

It is a good workflow to have so many eyes on the content before sending it. 👍

fassko

comment created time in an hour

push eventllvm/llvm-project

Jan Svoboda

commit sha 398f25340000f26d648ebbc7eae9dc401ffc7d5f

[clang][deps] Include "-cc1" in the arguments To simplify tools consuming dependency scanning results, prepend the "-cc1" argument by default. Reviewed By: Bigcheese Differential Revision: https://reviews.llvm.org/D100942

view details

push time in an hour

push eventllvm/llvm-project

Tobias Gysi

commit sha 0e777e4ad7d554436a1c181674bdbaeab9053c31

[mlir][linalg] remove interchange option on linalg to loop lowering. The interchange option attached to the linalg to loop lowering affects only the loops and does not update the memory accesses generated in to body of the operation. Instead of performing the interchange during the loop lowering use the interchange pattern. Differential Revision: https://reviews.llvm.org/D100758

view details

push time in an hour

push eventllvm/llvm-project

Martin Probst

commit sha fbc6f42dbee5d1d4ced30f520418c2b62942845a

clang-format: [JS] do not merge side-effect imports. The if condition was testing the current element, but forgot to check the previous element (doh), so it would fail depending on sort order of the imports. Differential Revision: https://reviews.llvm.org/D101020

view details

push time in 2 hours

push eventllvm/llvm-project

Jay Foad

commit sha 79cb3ba08f8022ad1bb664bb0d0cd3cfe5111001

[AMDGPU] SIWholeQuadMode: don't add duplicate implicit $exec operands STRICT_WWM and STRICT_WQM are already defined with Uses = [EXEC], so there is no need to add another implicit use of $exec when lowering them to V_MOV_B32 instructions. Differential Revision: https://reviews.llvm.org/D100969

view details

push time in 2 hours

push eventllvm/llvm-project

Serge Pavlov

commit sha 740962e5d02480e98696db432481443866e2206c

[RISCV] Custom lowering of SET_ROUNDING Differential Revision: https://reviews.llvm.org/D91242

view details

push time in 2 hours

push eventllvm/llvm-project

David Sherwood

commit sha 5a229a6702e2e810c4f8ed29eb3b5af01afff2c7

[LoopVectorize] Don't create unnecessary vscale intrinsic calls In quite a few cases in LoopVectorize.cpp we call createStepForVF with a step value of 0, which leads to unnecessary generation of llvm.vscale intrinsic calls. I've optimised IRBuilder::CreateVScale and createStepForVF to return 0 when attempting to multiply vscale by 0. Differential Revision: https://reviews.llvm.org/D100763

view details

push time in 2 hours

push eventllvm/llvm-project

Wenlei He

commit sha dff8315892e764c57324921bd75b4e9ad184de7c

[CSSPGO][llvm-profdata] Support trimming cold context when merging profiles The change adds support for triming and merging cold context when mergine CSSPGO profiles using llvm-profdata. This is similar to the context profile trimming in llvm-profgen, however the flexibility to trim cold context after profile is generated can be useful. Differential Revision: https://reviews.llvm.org/D100528

view details

push time in 3 hours

push eventllvm/llvm-project

Martin Storsjö

commit sha cfec0a3e9e70e9a7ce5ca6a0888ba71e2d978767

[libcxx] [test] Fix testing on windows with c++experimental enabled The straightforward `AddLinkFlag('-lc++experimental')` approach doesn't work on e.g. MSVC. For linking to libc++ itself, a more convoluted logic is used (see configure_link_flags_cxx_library). Differential Revision: https://reviews.llvm.org/D99177

view details

push time in 3 hours

pull request commentllvm/circt

[FIRRTL] Fix `is invalid` on duplex types and bundles

The new python-format checker isn't working properly, but besides that the CI passed.

youngar

comment created time in 3 hours

push eventllvm/llvm-project

Georgy Komarov

commit sha 9a930aa5bd2fc4686002d02411141a19f0ad8f36

[clang-tidy] Avoid bugprone-macro-parentheses warnings after goto argument clang-tidy should not generate warnings for the goto argument without parentheses, because it would be a syntax error. The only valid case where an argument can be enclosed in parentheses is "Labels as Values" gcc extension: https://gcc.gnu.org/onlinedocs/gcc/Labels-as-Values.html. This commit adds support for the label-as-values extension as implemented in clang. Fixes bugzilla issue 49634. Reviewed By: aaron.ballman Differential Revision: https://reviews.llvm.org/D99924

view details

push time in 3 hours

pull request commentfacebookexperimental/libunifex

Use gtest iff BUILD_TESTING=ON

Yes this PR is still a draft. I just realized that there was no need for a special title to get into draft mode. I will hit ready for review if I've managed to put some time into it.

I changed my job and I am still awaiting an answer from my employer if it is legal for me to contribute here, which is not clear to me even outside of my working time.

maikel

comment created time in 3 hours

Pull request review commentllvm/circt

[FIRRTL] Fix `is invalid` on duplex types and bundles

 struct FIRStmtParser : public FIRScopedParser {   /// a passive-typed value and return that.   Value convertToPassive(Value input, Location loc); +  /// Attach invalid values to every element of the value.+  void emitInvalidate(Value val, Location loc, bool isDuplex) {+    // Invalidate doesn't match the semantics of connect or partial connect, and+    // so we have to manually do something like expand-connects. Invalid value+    // needs to be connected to every field of a bundle which is flip, or+    // every field in a duplex operation.+    auto invalidType = val.getType().cast<FIRRTLType>();+    if (invalidType.isa<AnalogType>()) {+      // Analog types must be 'attach'ed, not connected.+      auto invalidVal =+          builder.create<InvalidValuePrimOp>(loc, invalidType.getPassiveType());+      builder.create<AttachOp>(loc, ValueRange{val, invalidVal});

I started dropping the attaches.

Note to self: I need to fix the expand-whens initialization checking here, right now it would complain about an analog wire with no connections.

youngar

comment created time in 3 hours

push eventllvm/llvm-project

Arthur Eubanks

commit sha 1dfb52a75687d6e6ca52fe49c879257011ba9538

[NewPM] Mark some more wrapper passes as ignored We shouldn't print IR when seeing these passes.

view details

push time in 3 hours

pull request commentQuick/Nimble

Replace deprecated libswiftXCTest.dylib with libXCTestSwiftSupport.dylib

Any chance to get a release with this? Xcode 12.5 RC 1 was out yesterday and this is blocking our test builds @ikesyo 🙏

evelynccordner

comment created time in 3 hours

push eventllvm/circt

John Demme

commit sha eb7b36760bf57cbf2226ca43bc09f8d047a8559d

Fix test

view details

push time in 3 hours

push eventllvm/circt

John Demme

commit sha 077cb056139bd85d7a9eff2d7b4d94b123241dab

Adding `operation()` method

view details

push time in 3 hours

push eventllvm/llvm-zorg

Galina Kistanova

commit sha 930e06c674229ae00916a7e9f012ca5269105f76

Revert "[Zorg] Change make to ninja instead for Clang RHEL buildbot" This reverts commit f785f4216432aa0d249ee3ad1f86515caf4c7b10.

view details

Galina Kistanova

commit sha 6eff27204f3ee010f3c166fca3dd142258970120

Revert "[PowerPC] Allow the PowerPC RHEL buildbot to use cmake with test-suite" This reverts commit 4b8974b63dcc1c5eab28a6ec33328b30e63e396b.

view details

push time in 3 hours

delete branch apple/swift-driver

delete branch : cherry-pick-433c66dbe644f5beb6adb9127eba7e838489a707

delete time in 4 hours

push eventapple/swift-driver

Artem Chikin

commit sha e2bbad1a911c905574ea5d1d196526d4199659f0

Remove target `x86_64` specialization from `testExplicitModuleBuildEndToEnd` (cherry picked from commit 433c66dbe644f5beb6adb9127eba7e838489a707)

view details

Mishal Shah

commit sha d72c0b85721cf74c101756c55edb128a13372d49

Merge pull request #612 from apple/cherry-pick-433c66dbe644f5beb6adb9127eba7e838489a707 [5.5] Remove target `x86_64` specialization from `testExplicitModuleBuildEn…

view details

push time in 4 hours

PR merged apple/swift-driver

[5.5] Remove target `x86_64` specialization from `testExplicitModuleBuildEn…

…dToEnd`

(cherry picked from commit 433c66dbe644f5beb6adb9127eba7e838489a707)

+3 -3

1 comment

3 changed files

shahmishal

pr closed time in 4 hours

Pull request review commentllvm/circt

[FIRRTL] Fix `is invalid` on duplex types and bundles

 struct FIRStmtParser : public FIRScopedParser {   /// a passive-typed value and return that.   Value convertToPassive(Value input, Location loc); +  /// Attach invalid values to every element of the value.+  void emitInvalidate(Value val, Location loc, bool isDuplex) {+    // Invalidate doesn't match the semantics of connect or partial connect, and+    // so we have to manually do something like expand-connects. Invalid value+    // needs to be connected to every field of a bundle which is flip, or+    // every field in a duplex operation.+    auto invalidType = val.getType().cast<FIRRTLType>();+    if (invalidType.isa<AnalogType>()) {+      // Analog types must be 'attach'ed, not connected.+      auto invalidVal =+          builder.create<InvalidValuePrimOp>(loc, invalidType.getPassiveType());+      builder.create<AttachOp>(loc, ValueRange{val, invalidVal});+    } else if (auto bundleType = invalidType.dyn_cast<BundleType>()) {+      // We need to recurse into bundle types without an outer flip.  They could+      // have inner flips or analog types.+      for (auto element : bundleType.getElements()) {+        auto elementVal = builder.create<SubfieldOp>(loc, val, element.name);+        emitInvalidate(elementVal, loc, isDuplex);+      }+    } else if (invalidType.isa<FlipType>() || isDuplex) {

This only works when the bundle has an outer flip. There is an inefficiency here that I was too lazy/ it was too ugly to fix: It doesn't do the same sort of thing for a wire with non-flipped fields, it will generate a separate subfield+connect for each field :(

youngar

comment created time in 4 hours

pull request commentllvm/circt

[RTL][Python] Add InstanceBuilder for constructing instances.

@teqdruid here's the patch for PyValue <> MlirValue interop: https://github.com/circt/llvm/commit/5fab6d398c57127072019449b4c5b4d4db434b04

Also bumped to ref in this PR, so you should be able to pull down this branch if you want to test.

mikeurbach

comment created time in 4 hours

push eventllvm/circt

Mike Urbach

commit sha c1309c8aae6813a0c11c044467ecd7a23ef391ae

Clean up, tests passing.

view details

Mike Urbach

commit sha 88340b3ecf213bd57b2d109a599a5f43c21c7bc7

Check in ref to staged LLVM patch for PyValue capsules.

view details

push time in 4 hours

Pull request review commentllvm/circt

[FIRRTL] Fix `is invalid` on duplex types and bundles

 struct FIRStmtParser : public FIRScopedParser {   /// a passive-typed value and return that.   Value convertToPassive(Value input, Location loc); +  /// Attach invalid values to every element of the value.+  void emitInvalidate(Value val, Location loc, bool isDuplex) {+    // Invalidate doesn't match the semantics of connect or partial connect, and+    // so we have to manually do something like expand-connects. Invalid value+    // needs to be connected to every field of a bundle which is flip, or+    // every field in a duplex operation.+    auto invalidType = val.getType().cast<FIRRTLType>();+    if (invalidType.isa<AnalogType>()) {+      // Analog types must be 'attach'ed, not connected.+      auto invalidVal =+          builder.create<InvalidValuePrimOp>(loc, invalidType.getPassiveType());+      builder.create<AttachOp>(loc, ValueRange{val, invalidVal});

Invalid values of Analog type get lowered to a wire with nothing connected to them.

youngar

comment created time in 4 hours

push eventllvm/llvm-project

Craig Topper

commit sha 58c5b4c2c356a377581440110f1e634fbb49cef6

[RISCV] Use TargetConstant for condition code of RISCVISD::SELECT_CC. The value is always an immediate and can never be in a register. This the kind of thing TargetConstant is for. Saves a step GenDAGISel to convert a Constant to a TargetConstant.

view details

push time in 4 hours