profile
viewpoint
Mateusz Łoskot mloskot @Cadcorp Wrocław, PL | London, UK http://mateusz.loskot.net Senior Software Engineer @Cadcorp Charter Member @OSGeo Open Source Cowboy

boostorg/geometry 318

Boost.Geometry - Generic Geometry Library | Requires C++14 since Boost 1.75

boostorg/gil 138

Boost.GIL - Generic Image Library | Requires C++11 since Boost 1.68

boostorg/wiki 70

Boost Wiki

mloskot/archlinux-config 22

Arch Linux config files and dotfiles I use to setup Linux system. WARNING: Not been updated!

mloskot/cmake-modules 12

My modules and scripts for CMake ***WARNING***: Legacy modules, not good for Modern CMake!

boostorg/boost-ci 8

Continuous Integration Toolkit for boostorg code repositories

mloskot/ci-test 5

Project to learn features and configurations of various public CI service

mloskot/boost-gil-workshop 4

Sandbox for experiments with Boost Generic Image Library (Boost.GIL)

mloskot/autotools-modules 3

My modules and scripts for GNU Autotools

mloskot/boost-geometry-workshop 2

Boost.Geometry (aka Generic Geometry Library, GGL), part of collection of the Boost C++ Libraries, defines concepts, primitives and algorithms for solving geometry problems.

startedvv9k/dockeye

started time in 7 days

issue commentlibgeos/geos

Iterator invalidation is ignored

Well, the bug (yours) report points the C++ spec violation. If the performance of the checks wasn't an issue, the checks would be there regardless of build type.

mmomtchev

comment created time in 10 days

create barnchCadcorp/geos

branch : 3.10

created branch time in 10 days

issue commentlibgeos/geos

Iterator invalidation is ignored

not an actual problem only a theoretical one (since the vector only grows, never shrinks)

Well, one can argue the code violates the standard.

If the new size() is greater than capacity() then all iterators and references (including the past-the-end iterator) are invalidated. Otherwise only the past-the-end iterator is invalidated.

mmomtchev

comment created time in 10 days

push eventmloskot/wsl-config

Mateusz Łoskot

commit sha 4e8e5ba6c197564b61541d1cdfe6815aef329da8

Add ps1/Install-Modules.ps1

view details

push time in 12 days

create barnchCadcorp/openssl

branch : openssl-3.0

created branch time in 13 days

push eventCadcorp/xerces-c

Mateusz Łoskot

commit sha 6378ee301e4cf56c5d17896f3208233699995e42

Patch src/CMakeLists.txt with Cadcorp suffix for .lib and .dll

view details

push time in 13 days

push eventCadcorp/gdal

Mateusz Łoskot

commit sha 9bca0f58ac3964ec9ef1d166b7cf4def2be277ce

Linking against static libtiff requires Lerc library objects

view details

push time in 13 days

pull request commentboostorg/boost-ci

Get SELF from meta/libraries.json

Is it a bit obstacle to add meta/libraries.json to those new libraries?

Flamefire

comment created time in 14 days

create barnchCadcorp/xerces-c

branch : cadcorp/xerces-3.2.2

created branch time in 14 days

push eventCadcorp/xerces-c

Even Rouault

commit sha e335da54127cd29091f6be97da97b24c9fd7c7e7

ICUTranscoder::transcodeFrom(): fix read heap-buffer-overflow Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=35373 When charsDecoded == 0, the line ``for (index = 0; index < charsDecoded - 1; index++)`` will cause to read out of bounds of fSrcOffsets, due to unsigned integer underflow rules.

view details

Roger Leigh

commit sha 307b646019e1a2f1dc5c571f3ab1212e09b55597

ci: Travis uses XCode 12.5

view details

Even Rouault

commit sha 327abd3551bdbca808b7fc22019c51210358b645

CurlURLInputStream constructor: avoid memory leak CurlURLInputStream constructor calls the readMore() method, which can throw exceptions. In that situation, the destructor is not called, which results in resource/memory leaks. To fix that, catch the exceptions, manually do the cleanup and rethrow the exceptions. Found by ossfuzz (locally)

view details

Roger Leigh

commit sha a5cfe26540c29ba6735c51b66e2b9eeffa981baa

Merge pull request #26 from rleigh-codelibre/fix-travis-ci-osx ci: Travis uses XCode 12.5

view details

Even Rouault

commit sha cf436abc181ab65824f6f51ae087e166dbdcd249

XMLReader constructor: fix memory leak when refreshRawBuffer() throws Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=37529 on GDAL The backtrace of the exception that caused the memory leak was: ``` Catchpoint 1 (exception thrown), 0x00007ffff5547672 in __cxa_throw () from /lib/x86_64-linux-gnu/libstdc++.so.6 (gdb) bt 0 0x00007ffff5547672 in __cxa_throw () from /lib/x86_64-linux-gnu/libstdc++.so.6 1 0x00007ffff24447c4 in xercesc_4_0::PosixFileMgr::fileRead (this=<optimized out>, f=<optimized out>, byteCount=<optimized out>, buffer=<optimized out>, manager=0x5555556df730) at xercesc/util/FileManagers/PosixFileMgr.cpp:160 2 0x00007ffff24e6ec2 in xercesc_4_0::XMLReader::refreshRawBuffer (this=0x5555557e49f8) at xercesc/internal/XMLReader.cpp:1891 3 0x00007ffff24e70d4 in xercesc_4_0::XMLReader::XMLReader (this=0x5555557e49f8, pubId=<optimized out>, sysId=0x555555750920 u"/", streamToAdopt=0x55555574e838, from=<optimized out>, type=xercesc_4_0::XMLReader::Type_General, source=xercesc_4_0::XMLReader::Source_External, throwAtEnd=false, calculateSrcOfs=false, lowWaterMark=100, version=xercesc_4_0::XMLReader::XMLV1_0, manager=0x5555556df730) at xercesc/internal/XMLReader.cpp:130 4 0x00007ffff24ced75 in xercesc_4_0::ReaderMgr::createReader (this=this@entry=0x5555557896d8, src=..., refFrom=refFrom@entry=xercesc_4_0::XMLReader::RefFrom_NonLiteral, type=type@entry=xercesc_4_0::XMLReader::Type_General, source=source@entry=xercesc_4_0::XMLReader::Source_External, calcSrcOfs=false, lowWaterMark=100) at ./xercesc/sax/InputSource.hpp:314 5 0x00007ffff24cb0af in xercesc_4_0::IGXMLScanner::scanReset (this=0x555555789608, src=...) at xercesc/internal/IGXMLScanner2.cpp:1286 6 0x00007ffff24c36e9 in xercesc_4_0::IGXMLScanner::scanDocument (this=0x555555789608, src=...) at xercesc/internal/IGXMLScanner.cpp:198 7 0x00007ffff250abaf in xercesc_4_0::AbstractDOMParser::parse (this=0x7fffffffc2d0, source=...) at xercesc/parsers/AbstractDOMParser.cpp:545 8 0x00007ffff24cbdbe in xercesc_4_0::IGXMLScanner::resolveSchemaGrammar (this=0x555555792f78, loc=0x5555557dd694 u"/", uri=0x555555737180 u"`", ignoreLoadSchema=<optimized out>) at xercesc/internal/IGXMLScanner2.cpp:1895 0x00007ffff24cce7c in xercesc_4_0::IGXMLScanner::parseSchemaLocation (this=0x555555792f78, schemaLocationStr=<optimized out>, ignoreLoadSchema=false) at ./xercesc/framework/XMLBuffer.hpp:171 10 0x00007ffff24cd182 in xercesc_4_0::IGXMLScanner::scanRawAttrListforNameSpaces (this=this@entry=0x555555792f78, attCount=attCount@entry=9) at xercesc/internal/IGXMLScanner2.cpp:1649 11 0x00007ffff24c22cb in xercesc_4_0::IGXMLScanner::scanStartTagNS (this=0x555555792f78, gotData=@0x7fffffffc91f: true) at xercesc/internal/IGXMLScanner.cpp:2213 12 0x00007ffff24c3522 in xercesc_4_0::IGXMLScanner::scanContent (this=0x555555792f78) at xercesc/internal/IGXMLScanner.cpp:890 13 0x00007ffff24c3760 in xercesc_4_0::IGXMLScanner::scanDocument (this=0x555555792f78, src=...) at xercesc/internal/IGXMLScanner.cpp:217 14 0x00007ffff25158e3 in xercesc_4_0::SAX2XMLReaderImpl::parse (this=0x555555731828, source=...) at xercesc/parsers/SAX2XMLReaderImpl.cpp:409 ```

view details

Roger Leigh

commit sha b0e7b3c4dc2e3cd3a4edecf61e7c386773f311d1

Merge pull request #24 from rouault/fix_gdal_ossfuzz_35373 XERCESC-2217: ICUTranscoder::transcodeFrom(): fix read heap-buffer-overflow

view details

Roger Leigh

commit sha a313987df3ae0a2d8b981b19fbb1a5c5c2eb745f

Merge pull request #28 from rouault/curl_memleak_fix XERCESC-2218: CurlURLInputStream constructor: avoid memory leak

view details

Roger Leigh

commit sha caa65157acf2a9e77a0bc5d9e7594a367198c440

Merge pull request #30 from rouault/fix_ossfuzz_37529 XERCESC-2219: XMLReader constructor: fix memory leak when refreshRawBuffer() throws

view details

Even Rouault

commit sha 1bdf6d8ba878c1fe1d779824be70001fc0bebd2c

InMemMsgLoader::loadMsg(): fix memory leak when transcoding fails. Seen with the IconvGNU transcoder when parsing "<aaa.xsdopengis.net/gml\x96". The reason is that XMLString::transcode(repText2, manager) throws a TranscodingException which causes the tmp1 string to leak. ``` 0 0x8791409 in operator new(unsigned int) /src/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:99:3 1 0xbd147f7 in xercesc_4_0::MemoryManagerImpl::allocate(unsigned int) gdal/xerces-c/src/xercesc/internal/MemoryManagerImpl.cpp:40:18 2 0xbe8c73e in xercesc_4_0::IconvGNULCPTranscoder::transcode(char const*, xercesc_4_0::MemoryManager*) gdal/xerces-c/src/xercesc/util/Transcoders/IconvGNU/IconvGNUTransService.cpp:870:32 3 0xbc22ca2 in xercesc_4_0::XMLString::transcode(char const*, xercesc_4_0::MemoryManager*) gdal/xerces-c/src/xercesc/util/XMLString.cpp:621:25 4 0xbe8f4ad in xercesc_4_0::InMemMsgLoader::loadMsg(unsigned int, char16_t*, unsigned int, char const*, char const*, char const*, char const*, xercesc_4_0::MemoryManager*) gdal/xerces-c/src/xercesc/util/MsgLoaders/InMemory/InMemMsgLoader.cpp:157:16 5 0xbc20175 in xercesc_4_0::XMLException::loadExceptText(xercesc_4_0::XMLExcepts::Codes, char const*, char const*, char const*, char const*) gdal/xerces-c/src/xercesc/util/XMLException.cpp:241:23 6 0xbc48bee in xercesc_4_0::UTFDataFormatException::UTFDataFormatException(char const*, unsigned long long, xercesc_4_0::XMLExcepts::Codes, char const*, char const*, char const*, char const*, xercesc_4_0::MemoryManager*) gdal/xerces-c/src/xercesc/util/UTFDataFormatException.hpp:31:1 7 0xbc4824e in xercesc_4_0::XMLUTF8Transcoder::transcodeFrom(unsigned char const*, unsigned int, char16_t*, unsigned int, unsigned int&, unsigned char*) gdal/xerces-c/src/xercesc/util/XMLUTF8Transcoder.cpp:182:13 8 0xbd27d7e in xercesc_4_0::XMLReader::xcodeMoreChars(char16_t*, unsigned char*, unsigned int) gdal/xerces-c/src/xercesc/internal/XMLReader.cpp:1926:34 9 0xbd271dd in xercesc_4_0::XMLReader::refreshCharBuffer() gdal/xerces-c/src/xercesc/internal/XMLReader.cpp:571:19 10 0xbd15c63 in xercesc_4_0::XMLReader::peekNextChar(char16_t&) gdal/xerces-c/src/xercesc/internal/XMLReader.hpp:767:14 11 0xbd15aaf in xercesc_4_0::ReaderMgr::peekNextChar() gdal/xerces-c/src/xercesc/internal/ReaderMgr.cpp:158:21 12 0xbd328da in xercesc_4_0::XMLScanner::scanProlog() gdal/xerces-c/src/xercesc/internal/XMLScanner.cpp:1241:45 13 0xbd31ef4 in xercesc_4_0::XMLScanner::scanFirst(xercesc_4_0::InputSource const&, xercesc_4_0::XMLPScanToken&) gdal/xerces-c/src/xercesc/internal/XMLScanner.cpp:549:9 14 0xbdadcff in xercesc_4_0::SAX2XMLReaderImpl::parseFirst(xercesc_4_0::InputSource const&, xercesc_4_0::XMLPScanToken&) gdal/xerces-c/src/xercesc/parsers/SAX2XMLReaderImpl.cpp:500:22 ```

view details

Even Rouault

commit sha dc3bd8fd1bffc7c7d7ca37dc98036954921691ef

Fix -Wmemset-transposed-args warnings of clang++ Fixes: xercesc/util/XMLChTranscoder.cpp:73:23: warning: setting buffer to a 'sizeof' expression; did you mean to transpose the last two arguments? [-Wmemset-transposed-args] memset(charSizes, sizeof(XMLCh), countToDo); ^ xercesc/util/XMLChTranscoder.cpp:73:23: note: cast the second argument to 'int' to silence and xercesc/util/XMLUTF16Transcoder.cpp:114:23: warning: setting buffer to a 'sizeof' expression; did you mean to transpose the last two arguments? [-Wmemset-transposed-args] memset(charSizes, sizeof(UTF16Ch), countToDo); ^ xercesc/util/XMLUTF16Transcoder.cpp:114:23: note: cast the second argument to 'int' to silence 1 warning generated.

view details

Chris Mc

commit sha af1935b567c18c8b2de71d6ea97239be60876335

link to installed CMake targets of CURL Just like how it was done for ICU

view details

Roger Leigh

commit sha 471e23c34805ecb9605f27aeed8202a570ee4c52

Merge pull request #32 from rouault/fix_ossfuzz_37666 XERCESC-2221: InMemMsgLoader::loadMsg(): fix memory leak when transcoding fails.

view details

Roger Leigh

commit sha 4f5404b03ff4458232fb10309fda9753d290abd0

Merge pull request #33 from rouault/fix_memset-transposed-args Fix -Wmemset-transposed-args warnings of clang++

view details

Even Rouault

commit sha 79f61cb45672546187b2bc6863858ee410267d00

DFAContentModel::checkUniqueParticleAttribution(): fix memory leak If a memory allocation of conflictTable[] fails, or later in the function, the array is not freed. Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=38533

view details

Roger Leigh

commit sha 60fd4e2a3b2e203b3d12c85b66e21be97039690b

Merge pull request #35 from rouault/fix_memleak_checkUniqueParticleAttribution [XERCESC-2222] DFAContentModel::checkUniqueParticleAttribution(): fix memory leak

view details

Even Rouault

commit sha 328f5be1006faf4859f1dfeffb56ccf9a9e5ee16

SAX2XMLReaderImpl::error(): use exception memory manager, otherwise regular memory manager might fail to fully allocate the strings in the exception and cause memory leaks

view details

Roger Leigh

commit sha 7dd9c518368be91497a0ae413b595b991fae2f00

Merge pull request #36 from rouault/SAX2XMLReaderImpl_error_fix [XERCESC-2223] SAX2XMLReaderImpl::error(): use exception memory manager, …

view details

Even Rouault

commit sha 02cec9524882815db078fa5fb7486762928a4d3d

DFAContentModel::checkUniqueParticleAttribution (): speed enhancement The complexity of this method is roughly O(n^3). Fuzzers can generate schemas with n = several thousands. The test fTransTable[i][j] == XMLContentModel::gInvalidTrans is independant of the k loop, and can thus being moved at a upper level to improve runtime.

view details

Roger Leigh

commit sha c0b90c22fc284055752be14594ab8d82ca71dba8

Merge pull request #37 from rouault/faster_checkUniqueParticleAttribution [XERCESC-2224] DFAContentModel::checkUniqueParticleAttribution (): speed enhancement

view details

Roger Leigh

commit sha 6b82b24cb05e6f99da434edbd81b67af1fd6cbc4

Merge pull request #34 from prince-chrismc/patch-1 XERCESC-2225: Link to installed CMake targets of CURL

view details

push time in 14 days

create barnchCadcorp/skia

branch : chrome/m93

created branch time in 14 days

create barnchCadcorp/skia

branch : main

created branch time in 14 days

push eventmloskot/valhalla

Mateusz Łoskot

commit sha c5af8fd2bbc492fa97bc406ff3b335632b71ca99

Accommodate for API change in Protobuf 3.18+ https://github.com/protocolbuffers/protobuf/commit/cda795437d00a15f375d3d5e2659adac715459c6

view details

push time in 17 days

PR opened valhalla/valhalla

Accommodate for API change in Protobuf 3.18+

Issue

Update related to this changes https://github.com/protocolbuffers/protobuf/commit/cda795437d00a15f375d3d5e2659adac715459c6

It should allow to build with older and newer Protobuf

Tasklist

  • [ ] Add tests
  • [ ] Add #fixes with the issue number that this PR addresses
  • [ ] Update the docs with any new request parameters or changes to behavior described
  • [ ] Update the changelog
  • [ ] If you made changes to the lua files, update the taginfo too.
+12 -0

0 comment

2 changed files

pr created time in 17 days

push eventmloskot/valhalla

Kevin Kreiser

commit sha 982ed3b46c234bb856c3b15bbc654ec980c84656

outlines for thoughts on reach fixes

view details

Duane Gearhart

commit sha 87f17dc0c2aa2bbb641516a0712b2fff0b84de43

fixed placement of o/d for test

view details

Mateusz Łoskot

commit sha 3176db5363b4a3c678532b8d496274858977776d

Initialise current_time=0 as origin.has_date_time() may report false (#1964) It also helps to avoid annoyance of Visual C++ check: Runtime Check Failure #3 - Variable is not initiliazed

view details

Kevin Kreiser

commit sha 8f442444ab5cb480d1e2c7713ddb9a5ff7db4a84

initial implementation, without check for correctness

view details

Kevin Kreiser

commit sha 8731e515ed6cf5745e5aac26fc647aeffb29737c

now with failing tests but geting close

view details

Kevin Kreiser

commit sha 67acdc180141aa8bae25178f3b76e1c90040bb85

Merge remote-tracking branch 'origin/master' into reachability2

view details

Kevin Kreiser

commit sha 74184c3b32e86477cadbd0b06e6185ec1755ec29

fix opposing edge from wrong tile and protect against partial data sets

view details

Kevin Kreiser

commit sha 1b7ab0b7979d49bb0a683a15edd38bbca02cf14b

stupid stupid lint

view details

Kevin Kreiser

commit sha a85fbb8c1a9a4c04739d14fae9a0500245fdab81

refactor loki to actually use new reach checks

view details

Kevin Kreiser

commit sha 4f38b3c7000b75ec8ec23866b96ede20e0c3a219

finally getting reach results through loki, reach checks in there show different reachability for what should all be passable nodes and edges..

view details

Kevin Kreiser

commit sha 8e186352049a40fc0a19a2b03cacab4747e09407

shortcircuit if reach is 0, return max reach even if we find a higher one, use the right node when doing the reverse expansion. when routing we only need outbound reach at the origin and inbound reach at the destination

view details

Kevin Kreiser

commit sha d8f750b7eedf43c829c95709f513cf4fa607b0b4

clean up some TODOs, add what is hopefully the last one

view details

Kevin Kreiser

commit sha 8e76cce37acc80f975b1f13573b188d9a8783bd6

handle the case when we need to be looking at the opposing edge for reach checks for a particular locations candidate

view details

Kevin Kreiser

commit sha 08b761ba420920851eb8ae6296b46bc646027244

if we are going to switch to the opposing edge because it does meet the criteria we ought to mark it as such

view details

Alessandro Biessek

commit sha 377a75a37f84e849a7b29856b62e2bb49e6ffaca

add pt-br locale (#1958) * Update README.md nproc is not a command on macos * add pt-BR locale * add pt-BR locale

view details

Kevin Kreiser

commit sha 6ceeadac34bb8357d0cfbcd2ddc83240b176f8d5

Merge remote-tracking branch 'origin/master' into reachability2

view details

Kevin Kreiser

commit sha ea9cd2123799971ba83eb64c0ba07627275ad9ef

update changelog

view details

Daniel Paz-Soldan

commit sha 8e8e3de1259fb139ab086c8410e92948c06bd037

Merge pull request #1965 from valhalla/reachability2 Reachability... Round 2... FIGHT!

view details

Duane Gearhart

commit sha 50c234cde847a86d8170e89adab402bbaa037c15

Establish pinpoint test pattern (#1969) * Dump path.pbf if requested * Updated TurnLanesToString - did not need argument * Started to update turn lanes test to have pinpoints * Updated to rename and move path.pbf to pinpoint test dir * Finished first turn lane pinpoint test * refactor turn lanes test to be reused for multiple tests * Added the create_path_pbf.sh script Moved the path.pbf rename logic to the create_path_pbf.sh script * Added left active test * added left_active_pinpoint test request * Update README.md * Update README.md * added error for missing pbf file * Added right_most_left_active_pinpoint test * Updated changelog for #1969 * added both_left_active_pinpoint test * added both_left_active_pinpoint test * added right_most_slight_left_active_pinpoint test * Added slight_right_active_pinpoint test * Added left_most_left_uturn_active_pinpoint test * Added left_reverse_active_pinpoint test

view details

Mateusz Łoskot

commit sha b86bac0fe923aeda054930c8897ab90bcafab1ad

README: Add complete git command to clone Valhalla [skip ci] (#1973) Show that `core.symlinks=true` is required in order to get complete and buildable clone of the repository.

view details

push time in 17 days

create barnchmloskot/valhalla

branch : ml/update-to-protobuf-3.18-api-change

created branch time in 17 days

issue commentprotocolbuffers/protobuf

Building static protobuf on Windows forces linking to static MSVC runtime.

I confirm it, I've just hit the same bug.

ambrop72

comment created time in 17 days

push eventCadcorp/postgres

Peter Geoghegan

commit sha 9afdea982420f9672b88e5c17d1ee8eec64105fc

Fix VACUUM VERBOSE's LP_DEAD item pages output. Oversight in commit 5100010e.

view details

Andrew Dunstan

commit sha fb424ae85f6b1e32e545f13902d3ba3429be44df

Report configured port in MSVC built pg_config This is a long standing omission, discovered when trying to write code that relied on it. Backpatch to all live branches.

view details

Andrew Dunstan

commit sha d69fcb9caef1ac1f38241645d4fb9f7e0ce02a70

fix syntax error

view details

Thomas Munro

commit sha b1d6538903504904db44679355ac109aeda01737

Fix race condition when sharing tuple descriptors. Parallel query processes that called BlessTupleDesc() for identical tuple descriptors at the same moment could crash. There was code to handle that rare case, but it dereferenced a bogus DSA pointer. Repair. Back-patch to 11, where commit cc5f8136 added support for sharing tuple descriptors in parallel queries. Reported-by: Eric Thinnes <e.thinnes@gmx.de> Discussion: https://postgr.es/m/99aaa2eb-e194-bf07-c29a-1a76b4f2bcf9%40gmx.de

view details

Tom Lane

commit sha ba356a397de565c014384aa01a945aab7d50928c

Doc: improve libpq service-file docs, avoid overspecifying pathnames. Clarify libpq.sgml's description of service file locations and semantics. Avoid use of backtick'ed pg_config calls to describe paths; that doesn't work on Windows, and even on Unix it's an idiom that not all readers may be instantly familiar with. Don't overspecify the locations of include files, instead writing only as much as you'd use in #include directives. The previous text in these places was incorrect for some installations, depending on where "postgresql" is in the install path. Our convention for referencing the user's home directory seems to be "~", so change the one place that spelled it "$HOME". install-windows.sgml follows the platform convention of spelling file paths with "\", so change the one place that used "/". Haiying Tang and Tom Lane Discussion: https://postgr.es/m/162149020918.26174.7150424047314144297@wrigleys.postgresql.org

view details

Michael Paquier

commit sha 12cc956664f159e97be71e33f15ec5f42e46b24e

Improve some error wording with multirange type parsing Braces were referred in some error messages as only brackets (not curly brackets or curly braces), which can be confusing as other types of brackets could be used. While on it, add one test to check after the case of junk characters detected after a right brace. Author: Kyotaro Horiguchi Discussion: https://postgr.es/m/20210514.153153.1814935914483287479.horikyota.ntt@gmail.com

view details

Noah Misch

commit sha d03eeab886baa1be73f8fc2938fb842d25a71fe8

Raise a timeout to 180s, in test 010_logical_decoding_timelines.pl. Per buildfarm member hornet. Also, update Pod documentation showing the lower value. Back-patch to v10, where the test first appeared.

view details

Tom Lane

commit sha 6ee41a301e70fc8e4ad383bad22d695f66ccb0ac

Fix mis-planning of repeated application of a projection. create_projection_plan contains a hidden assumption (here made explicit by an Assert) that a projection-capable Path will yield a projection-capable Plan. Unfortunately, that assumption is violated only a few lines away, by create_projection_plan itself. This means that two stacked ProjectionPaths can yield an outcome where we try to jam the upper path's tlist into a non-projection-capable child node, resulting in an invalid plan. There isn't any good reason to have stacked ProjectionPaths; indeed the whole concept is faulty, since the set of Vars/Aggs/etc needed by the upper one wouldn't necessarily be available in the output of the lower one, nor could the lower one create such values if they weren't available from its input. Hence, we can fix this by adjusting create_projection_path to strip any top-level ProjectionPath from the subpath it's given. (This amounts to saying "oh, we changed our minds about what we need to project here".) The test case added here only fails in v13 and HEAD; before that, we don't attempt to shove the Sort into the parallel part of the plan, for reasons that aren't entirely clear to me. However, all the directly-related code looks generally the same as far back as v11, where the hazard was introduced (by d7c19e62a). So I've got no faith that the same type of bug doesn't exist in v11 and v12, given the right test case. Hence, back-patch the code changes, but not the irrelevant test case, into those branches. Per report from Bas Poot. Discussion: https://postgr.es/m/534fca83789c4a378c7de379e9067d4f@politie.nl

view details

Peter Eisentraut

commit sha 7c544ecdad814ccda709cfb6aa7d62840c3a7486

Fix RADIUS error reporting in hba file parsing The RADIUS-related checks in parse_hba_line() did not respect elevel and did not fill in *err_msg. Also, verify_option_list_length() pasted together error messages in an untranslatable way. To fix the latter, remove the function and do the error checking inline. It's a bit more verbose but only minimally longer, and it makes fixing the first two issues straightforward. Reviewed-by: Magnus Hagander <magnus@hagander.net> Discussion: https://www.postgresql.org/message-id/flat/8381e425-8c23-99b3-15ec-3115001db1b2%40enterprisedb.com

view details

Thomas Munro

commit sha a40646e30d85e51a76fb620822d4d921b6802157

Fix error handling in replacement pthread_barrier_init(). Commit 44bf3d50 incorrectly used an errno-style interface when supplying missing pthread functionality (i.e. on macOS), but it should check for and return error numbers directly.

view details

Amit Kapila

commit sha eb89cb43a0d0e401e71b8e2345b5f5bc8b2755a1

pgoutput: Fix memory leak due to RelationSyncEntry.map. Release memory allocated when creating the tuple-conversion map and its component TupleDescs when its owning sync entry is invalidated. TupleDescs must also be freed when no map is deemed necessary, to begin with. Reported-by: Andres Freund Author: Amit Langote Reviewed-by: Takamichi Osumi, Amit Kapila Backpatch-through: 13, where it was introduced Discussion: https://postgr.es/m/MEYP282MB166933B1AB02B4FE56E82453B64D9@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM

view details

Tom Lane

commit sha 1103033aedc10295eb689a4b7158f21ef4c14a11

Reject SELECT ... GROUP BY GROUPING SETS (()) FOR UPDATE. This case should be disallowed, just as FOR UPDATE with a plain GROUP BY is disallowed; FOR UPDATE only makes sense when each row of the query result can be identified with a single table row. However, we missed teaching CheckSelectLocking() to check groupingSets as well as groupClause, so that it would allow degenerate grouping sets. That resulted in a bad plan and a null-pointer dereference in the executor. Looking around for other instances of the same bug, the only one I found was in examine_simple_variable(). That'd just lead to silly estimates, but it should be fixed too. Per private report from Yaoguang Chen. Back-patch to all supported branches.

view details

Noah Misch

commit sha 49527a32ca97761d78efef732a4ac76a2fc086b2

Fix missing gettimeofday() declaration. This avoids a warning under MinGW versions having gettimeofday(), per buildfarm member walleye.

view details

Noah Misch

commit sha 42344ad0ed465ea988d8310d2f413d65329f55a8

Add Windows file version information to libpq_pipeline.exe.

view details

Fujii Masao

commit sha 6bbc5c5e96b08f6b8c7d28d10ed8dfe6c49dca30

Add regression test for recovery pause. Previously there was no regression test for recovery pause feature. This commit adds the test that checks - recovery can be paused or resumed expectedly - pg_get_wal_replay_pause_state() reports the correct pause state - the paused state ends and promotion continues if a promotion is triggered while recovery is paused Suggested-by: Michael Paquier Author: Fujii Masao Reviewed-by: Kyotaro Horiguchi, Dilip Kumar Discussion: https://postgr.es/m/YKNirzqM1HYyk5h4@paquier.xyz

view details

Fujii Masao

commit sha df466d30c6caa02e2215595fd83ca70be3199cec

Remove unnecessary use of Time::HiRes from 013_crash_restart.pl. The regression test 013_crash_restart.pl included "use Time::HiRes qw(usleep)", but the usleep was not used there. Author: Fujii Masao Reviewed-by: Kyotaro Horiguchi Discussion: https://postgr.es/m/63ad1368-18e2-8900-8443-524bdfb1bef5@oss.nttdata.com

view details

Tom Lane

commit sha 9e3b3ff2664dd0b349d2a6d6f047128cb3489cf2

Teach tab-complete.c about recently-added CREATE TYPE options. Commit c7aba7c14 missed adding SUBSCRIPT here, and commit 6df7a9698 missed adding MULTIRANGE_TYPE_NAME. Haiying Tang and Tom Lane Discussion: https://postgr.es/m/OS0PR01MB6113F9EDA46FA53BAA5445BDFB3D9@OS0PR01MB6113.jpnprd01.prod.outlook.com

view details

Tom Lane

commit sha 79c50ca57828e9f8375766b36cce1e2960eebf87

Update plannodes.h's comments about PlanRowMark. The reference here to different physical column numbers in inherited UPDATE/DELETE plans is obsolete as of 86dc90056; remove it. Also rework the text about inheritance cases to make it clearer.

view details

Tom Lane

commit sha 889592344c48d3965567f331b4ea89dfe6447bce

Fix planner's row-mark code for inheritance from a foreign table. Commit 428b260f8 broke planning of cases where row marks are needed (SELECT FOR UPDATE, etc) and one of the query's tables is a foreign table that has regular table(s) as inheritance children. We got the reverse case right, but apparently were thinking that foreign tables couldn't be inheritance parents. Not so; so we need to be able to add a CTID junk column while adding a new child, not only a wholerow junk column. Back-patch to v12 where the faulty code came in. Amit Langote Discussion: https://postgr.es/m/CA+HiwqEmo3FV1LAQ4TVyS2h1WM=kMkZUmbNuZSCnfHvMcUcPeA@mail.gmail.com

view details

Tomas Vondra

commit sha 8e03eb92e9ad54e2f1ed8b5a73617601f6262f81

Revert most of 39b66a91bd Reverts most of commit 39b66a91bd, which was found to cause significant regression for REFRESH MATERIALIZED VIEW. This means only rows inserted by heap_multi_insert will benefit from the optimization, implemented in commit 7db0cd2145. Reported-by: Masahiko Sawada Discussion: https://postgr.es/m/CAD21AoA%3D%3Df2VSw3c-Cp_y%3DWLKHMKc1D6s7g3YWsCOvgaYPpJcg%40mail.gmail.com

view details

push time in 17 days

push eventCadcorp/PDAL

Mateusz Łoskot

commit sha bb658cc430af95dd35a9863b58a23efd67d9343b

Patch cmake/lazperf.cmake to laz-perf via variables instead of obscure CMake config module The laz-perf is no longer header-only library

view details

push time in 17 days

push eventCadcorp/zstd

senhuang42

commit sha 4d01979b6255e0ccc2b8ba868c9e769bf00b60c2

Expose and call ZSTD_ldm_skipRawSeqStoreBytes()

view details

senhuang42

commit sha 590f7f55f0ca68bb1a90043efb014f18c4b07cd1

Add ldm enable condition in ZSTD_resetCCtx_internal

view details

senhuang42

commit sha df470e176bdd4240a18997f4cf57e100c0ac6755

Add unit test for no cctx requested params change

view details

senhuang42

commit sha aad436da37168bfa4860db92c2669905426cefc3

Document ldm enabled by default in zstd.h

view details

senhuang42

commit sha b1c7fc57687e208b82bcbe46387f6de5d5052d94

Add compatibility for multithreading

view details

senhuang42

commit sha 81a2c02d8f5a98f93a85a10bec7a5717ca71afad

Move ldm no regression test to fuzzer longtests

view details

senhuang42

commit sha d28d8a1d725ca1885a69f012dd0525d59c5b066e

Include LDM tables size for CCtx size estimation where relevant

view details

Nick Terrell

commit sha d6dae2000b3148105a4cf8e56ff133f61211767a

Merge pull request #2365 from senhuang42/move_opt_parser_test_to_long_tests Move ldm + opt parser no regression test to long tests

view details

senhuang42

commit sha 578e889ec1797b96f62cf73480d0ba3b3823b79c

Move ldm enable to compressStream2()

view details

senhuang42

commit sha 8bdb32aebe181ebfa62237be49e9d183c2daf596

Add a function for LDM enable check

view details

Yann Collet

commit sha a9f7e77d440bc2c8694a78f4cdc4403a72b2df85

fixed travis tests

view details

Yann Collet

commit sha 684f8ea970f15a19f82728d596ecfbf509ea686f

decouple zstd object files from lib/ That was a subtle one : VPATH is affecting search for both %.c source and %.o object files. This meant that, when an object file already exists in lib/, it's used in programs/, even though programs/ is supposed to generate its own %.o object files. With the new vpath directive, this is no longer the case : the search is only activated for %.c source files. Now, local programs/%.o are always generated even if equivalent ones are already created in lib/. It more clearly guarantees that lib/ and programs/ can use different compilation directives without mixing resulting %.o object files.

view details

Yann Collet

commit sha 911dbdbb4b1374fcc4c2c8a6199bb15ecb69b24a

build libzstd.so from object files %.o object files generated for dynamic library must be different from those generated for static library. Due to this difference, %.o were so far only generated for the static library. The dynamic library was rebuilt from %.c source. This meant that, for every minor change, the entire dynamic library had to be rebuilt. This is fixed in this PR : only the modified %.c source get rebuilt.

view details

Yann Collet

commit sha 3e519be9656c586e2b80441929b1692adec21a9e

minor cleaning

view details

Yann Collet

commit sha e8eb2939feb98c5dd425181247557b9c59649fca

store %.o object files into obj/ both static and dynamic libraries have their own object directory

view details

Yann Collet

commit sha 2b99bc29bf80eb0e0e7e6cf7d21014bd8f08d62f

consolidated vpath

view details

Yann Collet

commit sha 2224ec33ed5c5242dbb2a074d9cc2566f9bac007

Merge pull request #2367 from facebook/progressive_build faster rebuild of zstd

view details

Yann Collet

commit sha 8a453a34c57d2097bf499fb81446e90636851f86

automatic %.h header dependency tracking also : BUILD_DIR can be manually specified

view details

Yann Collet

commit sha d0436b2a454f39979ef506be152c597707d7243c

automatically detect configuration changes Makefile now automatically detects modifications of compilation flags, and produce object files in directories dedicated to this compilation flags. This makes it possible, for example, to compile libzstd with different DEBUGLEVEL. Object files sharing the same configration will be generated into their dedicated directories. Also : new compilation variables - DEBUGLEVEL : select the debug level (assert & traces) inserted during compilation (default == 0 == release) - HASH : select a hash function to differentiate configuration (default == md5sum) - BUILD_DIR : skip the hash stage, store object files into manually specified directory

view details

Yann Collet

commit sha 0f8ee5c51ed867d1ea271f4c1f70a195061a1980

Merge branch 'dev' into libzstd_autoconf

view details

push time in 17 days

push eventCadcorp/laz-perf

Howard Butler

commit sha 3b37edf473fe17160b21272dbf509641f387a7bc

Code tree reorganization (#72) * upload wheel artifacts * upload working-dir * wheelhouse directory for ubuntu wheel * paths * many linux * major reorg * python reorg * package_dir * get tests happy * ignore cpp tests for python * linux wheel * setupminiconda * activate shell for osx * package collation * add top-level CMakeLists.txt and forward to cpp API * emscripten build * wheel test * paths * print python version * python3 * build 3.6 too * run pytest on wheel * use correct python to test * do not package __init__.py test dir * PATH munging? * remove shell invocation * test from top dir

view details

Kyle Mann

commit sha 2742911adc16f16c554805c7f46578872cc7bf4c

fixing pathing (#73)

view details

Howard Butler

commit sha acd38ab3decb2d0747e83ac9d4ab50d013f26309

github ci for wheel testing (#74) * test wheels * use manylinux1_x86_64 for wheel generation * lint * use manylinux2010_x86_64 * run w bash * windows wheel install * tweaks * cmd.exe looping * run in cmd

view details

Howard Butler

commit sha 02c27c845d55ec1495979a1aa135f1605cfab431

bump version to 1.5.0 to prepare for release

view details

Howard Butler

commit sha 9d4048ebb0a0e7df0626edd8b0814bff6d1a3e4e

GHA fixups due to security policy

view details

Howard Butler

commit sha dfec0f6ddc958d615aeb274487c60219dcec9d6e

LAZ 1.4 support

view details

Howard Butler

commit sha 40f934b5b681f438765df770b1f0a1ce665a01fc

run ci on all branch pushes

view details

Andrew Bell

commit sha 667ed6de299fd67109dd34986f65368107c3c24f

Missed file (#76) * Recurse where expected when encoding GPSTIME. Add tests for issue 44. Make IO tests more generic. * Open LAZ file as binary. * Update location of test data. * Add (deprecated) functions to support backward-compatibility. * Checkpoint. The encoder/decoder now sits inside the compressor/decompressor. * Working checkpoint without record_compressor. Record compressor is still used in examples and such. * More checkpoint. Use new classes for 1.2 compression/decompression. * More progress and a checkpoint. Notable in that this changes the chunk handling in io.hpp. * Minimally working. * Seemingly working output for point14. * Fixup LASzip VLR * First part of decompression - in progress. * Add gpstime code. Checkpoint. * Working X/Y/Z/Time * Working encoding. * Working writer. Tests well with random data. * A couple more GPS bugs fixed. * All working. * Extra bytes VLR. * Working with extrabytes. * Don't allocate things on the heap. * Remove Schema. * More cleanup. Guard debug. * Version and base header files. * Cleanup. * Checkpoint. * Test-passing checkpoint. * Small interface for lazperf. * Add simple access to file streams. Support simple chunk encoding. * LAZ 1.4 support in a library. * Update in prep for emscripten. * Working WASM generation with Emscripten. * Update version. * Remove lazperf-specific types. Use generic utilities. * Remove dead file. * Get rid of intrinsic -- slower for some reason. * Formatting, and remote unnecessary check for 32. * Add missed file. * Use project source dir. * Don't use subdirectory. * Fixes for Linux. * More Linux changes. * Use memcpy instead of reinterpret_cast. * More Linux fixes. * Windows warnings. * Windows warnings. * Quiet MSVC. * Export functions. * Too many parens? * More export stuff. * Build static and shared libs. * Fix some odd UB according the the C++ standard. * More random nonsense. * Move tools so things are defined. * Install io.hpp * Remove fast test. * Actions. * Actions. * Actions. * Actions. * Actions * Action * Action * Action * Action * Action

view details

Andrew Bell

commit sha 6db4dabc1886dba1b2c8a26a3c7a3266bb7d4d59

README update.

view details

Andrew Bell

commit sha f45c5ec3e7f968df0a242975d6d279e76f68057f

Unix visibility

view details

Andrew Bell

commit sha c7cb71be219437fa5b3763c58c10c55c9b5739ea

Fail if someone attempts to run cmake from the cpp directory.

view details

Andrew Bell

commit sha da5da9c092cd1b5f4327708007d320bb7e54b7af

ex

view details

Andrew Bell

commit sha 4a12345f1162cb70a19890fbf2b3912e414347e8

Don't enable exceptions at all (#79) * ex * def * Update. * emopts * Add missed file. * Update. * Update2 * Update3 * simplify

view details

Howard Butler

commit sha 2e3c316248fa534cdeba1b47b2e9fe1a0ecf5dca

bump version to 2.0.0 instead of 2.0

view details

Andrew Bell

commit sha a003d1ead4afb9a0c61cde8b00340c489f2ce370

Remove unnecessary byte ordering. (#86)

view details

Andrew Bell

commit sha 0bbec11a68214ebb4bdc0a35f9877c177e4316d8

Merge remote-tracking branch 'origin/master'

view details

Andrew Bell

commit sha 988fc70a72f9015e61cba28d8d0a6f07e5d0b75f

Clean up exported IO functions (#88) * Fix the exported function issue for io functions * Include memory. * Header file.

view details

Andrew Bell

commit sha b7456352e0e8a758842cd39de8e837a257d68489

Don't setup Windows compiler if we aren't on windows.

view details

Andrew Bell

commit sha 279bf9f2becbb79599024ceae44a6537dadd64c0

Fix array reference.

view details

Andrew Bell

commit sha 99ec34f72aa468f522e956001fda058e2c8b1054

Remove python support. Cmake cleanup.

view details

push time in 17 days

push eventCadcorp/PDAL

Mateusz Łoskot

commit sha ebc3bf4489ccdac22ef28992d7af6aa7469c411c

Link against crypt32 normaliz wldap32 ws2_32 - following update to cURL 7.75.0 or later (cherry picked from cadcorp/2.1-maintenance branch commit d43b9eaea35b8a3b1abf8ea5a2415951057ccbab)

view details

Mateusz Łoskot

commit sha 0b37d2a10eaef5414513adaf171ba058c455030a

Define LIBXML_STATIC to avoid dllimport and names mangling

view details

push time in 17 days

create barnchCadcorp/PDAL

branch : cadcorp/2.3-maintenance

created branch time in 17 days

push eventCadcorp/PDAL

Howard Butler

commit sha f50a63d6f2d522475a4ccf1baf9a1d60a99311a8

STANDALONE prefix for building RDB plugin

view details

Howard Butler

commit sha 26b3374c3e7fa09ce21b90ac3a2bed8803479c15

Merge branch 'master' of github.com:PDAL/PDAL

view details

Even Rouault

commit sha 0f9407ab531780b4eef4d859685dd412ef81574f

CI: update to conda-incubator/setup-miniconda@v2 due to GHA security fix (#3285) Due to https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ and the old action still using the deprecated syntax

view details

Crghilardi

commit sha dd51c47dd9d32498cc78688c5d727ff8bdc4169e

update windows compilation docs to point to GitHub Actions instead of Appveyor.yml (#3290)

view details

Andrew Bell

commit sha 0f319a51cb3cb67b10328176ebbefcbe6ca4fc9b

Fixes for VS 2019 (#3292)

view details

Andrew Bell

commit sha 78c0d7f3f313c8be7b32a2d52ab3e553a4a950da

Misc. Changes To Fix CI and Memory Leaks (#3294) * Link thread library to pdal_util. * Remove condition preventing tiledb writer test build on osx. * See * See * Test. * More test. * Comment out faux readers. * Use vector instead of raw buf. * Fixes. * Just factory. * Run all TileDB writer tests for now.

view details

theirix

commit sha a5a08a689ce39fdc3e1b674fdfc1b7ed997f88c9

Add missing libc includes (#3296)

view details

Stephen Knox

commit sha f6bb0acf1cce0a5e3a2274480187aaa894f316f5

Fix JSON format for example (#3295)

view details

chambbj

commit sha 2c87bb8ed46bc16c840a95466aa12d7a08346bf9

Initial commit of TEASER++ (#3265) * Initial commit of TEASER++ * Addressing PR comments * Make TEASER work with C++11 Vendor the TEASER registration header from v2.0 release tag, implementing workaround documented at https://stackoverflow.com/a/17903225/1620549 to provide std::make_unique.

view details

chambbj

commit sha c6abbef2aefa3d73862a227e323d58dbfd98392a

Minor updates to several filters (#3270) * Minor updates to several filters Initial focus is on updating static filters to always register official Dimensions. * LiTreeFilter now registers existing ClusterID instead of custom TreeID. * LOFFilter now registers existing NNDistance instead of custom KDistance. * OptimalNeighborhoodFilter now registers existing OptimalRadius and OptimalKNN. * Register the following as "official" Dimensions: Coplanar, Eigenvalue0, Eigenvalue1, Eigenvalue2, LocalOutlierFactor, LocalReachabilityDistance, Miniball, PlaneFit, RadialDensity, Rank, Reciprocity While updating Dimensions, also took the opportunity to: * Be more explicit about datatypes, instead of relying on auto, to improve readability. * Use PointView range-based for loops where it make sense. Generally makes code a little more succinct. * Do not pass KDIndex as frequently, when it can typically be grabbed off the view at no cost. * Addressing PR comments

view details

chambbj

commit sha 788e130e55c5d50a9efb08e5fb28434a5235cdac

Add chamfer distance to PDALUtils and expose via kernel (#3183)

view details

Howard Butler

commit sha e1b4e80ed152af41b9639e0854e6a1c80f6c8c6b

Merge branch 'master' of github.com:PDAL/PDAL

view details

Andrew Bell

commit sha 5ab42b6d0a9869fdac705169dcea9037a39527d4

Debugging tiledb failure. (#3300)

view details

Matyáš Hollmann

commit sha 50fd6cd24a8696b74939139c0dd24306980506e8

LasWriter: proposed solution to autoscale with autooffset bug (0 variance data) (#3305) * LasWriter: proposed solution to autoscale with autooffset bug. * LasWriter: improved precision when using auto-offset

view details

Howard Butler

commit sha 4c7e4c401849ac71b2dcd7e64f0755f6f0f755f5

Merge branch 'master' of github.com:PDAL/PDAL

view details

Howard Butler

commit sha 585e4cee2837c5a43ad3392e5b5c43257d214189

Use conda-forge pins for Conda package GHA (#3308) * STANDALONE prefix for building RDB plugin * use conda-forge pins for package generation * dont use clone for build * path * path again

view details

Andrew Bell

commit sha d703f7fd2f09335825f02e854994e11765aa6252

Allow limiting of dimensions. (#3311)

view details

Connor Manning

commit sha 504b22b1b228a825a84848b6f25c88128276476a

Fix typo in an EPT reader error message.

view details

Andrew Bell

commit sha afb371eba13950fdf07db1b044d213d98c88504e

Eigen (#3315) * Update Eigen. * Comment out bad initial Xform test. * Comment out test.

view details

Connor Manning

commit sha f591dbbbe99c2734c91e880ff04cbf6e3c3adfcc

Add streamable tag to the EPT reader doc.

view details

push time in 17 days

create barnchCadcorp/microtar

branch : cadcorp/master

created branch time in 17 days

push eventCadcorp/lz4

Nimloth

commit sha 5e433066f81861812cb069696523380a516e3f4d

Update .cirrus.yml current up-to-date stable branch is 12.2

view details

Yann Collet

commit sha 1d58f77818f2ac8c18e89a884826c9fa8acba295

Merge pull request #970 from Nimloth/patch-1 Update .cirrus.yml

view details

Jasper Lievisse Adriaanse

commit sha 8301a21773ef61656225e264f4f06ae14462bca7

Fix potential memory corruption with negative memmove() size

view details

klebertosantos

commit sha 29a6a1f4941e7243241fe00d6c13b749fd6b60c2

fix null pointer dereference

view details

Yann Collet

commit sha bdc9d3b0c10cbf7e1ff40fc6e27dad5f693a00e7

Merge pull request #973 from klebertarcisio/patch_fix Avoiding null pointer dereference

view details

Yann Collet

commit sha 7d8d1075e696d585238e6aa6a4f43dc759da250e

fixed incorrect propagation of default CFLAGS

view details

Yann Collet

commit sha 7a966c1511816b53ac93aa2f2a2ff97e036a4a60

Merge pull request #972 from jasperla/memmove_crash Fix potential memory corruption with negative memmove() size

view details

Sandy Harvie

commit sha 7da3ab4bec3e38651ce53d660746d2b9d144d6de

bump CMake minimum required version to 2.8.12

view details

Takayuki Matsuoka

commit sha 0d2570b7c53a7392da4c81fcf6ffa77d4d608119

Add CC propagation to 'make usan' The following command doesn't work as intended ``` cd git clone https://github.com/lz4/lz4.git cd lz4 make usan MOREFLAGS='-Wcomma -Werror' ``` ``` Cleaning completed cc: error: unrecognized command line option ‘-Wcomma’; did you mean ‘-Wcomment’? make[3]: *** [<builtin>: ../lib/lz4.o] Error 1 make[2]: *** [Makefile:65: lz4] Error 2 make[1]: *** [Makefile:133: test] Error 2 make: *** [Makefile:158: usan] Error 2 ``` Because the following part of the `Makefile` doesn't propagate `CC`, `CFLAGS` and `LDFLAGS` to child `$(MAKE)` properly. ``` .PHONY: usan usan: CC = clang usan: CFLAGS = -O3 -g -fsanitize=undefined -fno-sanitize-recover=undefined -fsanitize-recover=pointer-overflow usan: LDFLAGS = $(CFLAGS) usan: clean $(MAKE) test FUZZER_TIME="-T30s" NB_LOOPS=-i1 ``` We need explicit propagation for child process ``` - $(MAKE) test FUZZER_TIME="-T30s" NB_LOOPS=-i1 + CC=$(CC) CFLAGS=$(CFLAGS) LDFLAGS=$(LDFLAGS) $(MAKE) test FUZZER_TIME="-T30s" NB_LOOPS=-i1 ``` After that, `make usan` works and it shows expected runtime error. ``` $ make usan MOREFLAGS='-Wcomma -Werror' Cleaning completed ../lib/lz4frame.c:907:25: runtime error: applying non-zero offset 65536 to null pointer SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../lib/lz4frame.c:907:25 in ../lib/lz4frame.c:907:58: runtime error: applying zero offset to null pointer SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../lib/lz4frame.c:907:58 in ... ``` Please note that `make usan` is working at travis-ci. Because `.travis.yml` has the following [explicit `compiler:` setting](https://github.com/lz4/lz4/blob/7a966c1511816b53ac93aa2f2a2ff97e036a4a60/.travis.yml#L66). ``` - name: (Trusty) USan test dist: trusty compiler: clang script: - make usan MOREFLAGS=-Wcomma -Werror ```

view details

Takayuki Matsuoka

commit sha 4a9bbc2480b16c2d6eaed00612884010774fbe40

Fix -Wshorten-64-to-32 warning

view details

Takayuki Matsuoka

commit sha 0276f0b120f64a4aa01b231436da9886009bbdef

Add GitHub Actions script ci.yml

view details

Yann Collet

commit sha d00319baabe63c58df71059ae8af89c8e7d4a59e

Merge pull request #984 from t-mat/fix-wconversion-warning Fix -Wshorten-64-to-32 warning

view details

Yann Collet

commit sha 5b86e4e5ed4429a8c0f58dadc3ebaf65ba029d18

Merge pull request #982 from t-mat/fix-make-usan Fix 'make usan'

view details

Yann Collet

commit sha 8e46846287c60bb34ab8157113715b94e39261b9

fix UB of lz4frame:907 now line 912 by ensuring pointer arithmetic is only performed if there is a reason for an internal buffer to be used.

view details

Yann Collet

commit sha c2c0c47d5f27752097ae379645e34bcba4d604ed

fix NULL ptr arithmetic of lz4:1572 was blindly adding an offset (0) to `dictionary` which could be `NULL`.

view details

Takayuki Matsuoka

commit sha 54b695800d6be3cc4e1b32dbf390c37e427d1c5b

Temporary ignore make usan We must enable this test when all make usan errors will be resolved properly.

view details

Yann Collet

commit sha dd7a6fbdc4a1f683705ee6550089fde5527639ca

Merge pull request #986 from lz4/fixub907 fix UB of lz4frame:907

view details

Yann Collet

commit sha 6ac3b7ba9486c0fc0bf98baf3755f9dd55120aa8

Merge pull request #985 from t-mat/add-github-actions Add GitHub Actions script ci.yml

view details

Takayuki Matsuoka

commit sha 1f6d2efda1ba3b0687896708cba23c84af4748cd

Disable Meson + clang build at travis-ci

view details

Yann Collet

commit sha cacdcf1f51e41b391ec760d7ddf201940f269ebf

Merge pull request #987 from t-mat/tmp-disable-meson Disable Meson + clang build at travis-ci

view details

push time in 17 days

created tagCadcorp/libxml2

tagv2.9.11

Read-only mirror of https://gitlab.gnome.org/GNOME/libxml2

created time in 17 days

created tagCadcorp/libxml2

tagCVE-2021-3541

Read-only mirror of https://gitlab.gnome.org/GNOME/libxml2

created time in 17 days

created tagCadcorp/libxml2

tagv2.9.12

Read-only mirror of https://gitlab.gnome.org/GNOME/libxml2

created time in 17 days

more