profile
viewpoint
Mikko Korpela mkorpela Reaktor Helsinki, Finland

mkorpela/pabot 298

Parallel executor for Robot Framework test cases.

mkorpela/overrides 131

A decorator to automatically detect mismatch when overriding a method

mkorpela/RoboMachine 91

Model-based testing with Robot Framework

MarketSquare/robotframework-browser 54

Robot Framework Browser library powered by Playwright.

mkorpela/RoboZombie 10

Robot Framework test library that uses zombie.js

reaktor/robotframework-tail 6

On the fly logging to webservice for Robot Framework test cases.

mkorpela/robotframework-expects 5

Robot Framework library that can train computers to validate expected results based on examples.

mkorpela/robotframework-websocket 5

WebSocket demo for browser library creation

mkorpela/EventLibrary 4

Event dispatcher Library for Robot Framework

mkorpela/yabot 4

Yet another bot - a script for executing Robot Framework tests

push eventrobotframework/robotframework

Mikko Korpela

commit sha 2127dd9589561c37f13d5ea279c63e52042a100f

Topic/libdoc html (#3675) New libdoc html format. Responsive, communicating Robot Framework brand and easier overview beside details UX pattern. Most of this is done with none custom CSS to achieve future proof.

view details

push time in 2 hours

PR merged robotframework/robotframework

Topic/libdoc html

New style for libdoc .html: Better mobile support.

+795 -379

3 comments

12 changed files

mkorpela

pr closed time in 2 hours

issue commentMarketSquare/robotframework-browser

Get Elements should not raise timeout exception when no elements found. It should return an empty list.

I think you fixed it, I just kind of forgot that timeout setting is an option.

mkorpela

comment created time in 2 hours

push eventrobotframework/robotframework

Mikko Korpela

commit sha 3b89180cf328d79877b06842411d2009544b9417

doc_formatting splitted to log and libdoc

view details

Mikko Korpela

commit sha 9941f84205bcf1614a1cb50d365bae793ef73ca8

doc_formatting for report and log

view details

push time in 3 hours

issue commentMarketSquare/robotframework-browser

Get Elements should not raise timeout exception when no elements found. It should return an empty list.

From dynamic behaviour point of view (such as crawling unknown site), it is a normal situation that elements are not found. So it also can’t take 10 seconds when ending to this kinds of pages..

mkorpela

comment created time in 14 hours

issue closedMarketSquare/robotframework-browser

Get Elements should not raise timeout exception when no elements found. It should return an empty list.

Is your feature request related to a problem? Please describe. Selectors can match multiple targets. Currently Get element just "randomly" returns the first match. This might not be the correct thing. Get Element is used so that further manipulations or validations can be made to that element. Selector might match 0, 1 or N elements.

Describe the solution you'd like Replace Get Element with Get Elements that returns a list of matches. Also have assertion engine there for easy manipulation of that list such as Get Elements selector then value[0]

Describe alternatives you've considered Get Element might also raise an error when multiple matches.

closed time in 14 hours

mkorpela

issue commentMarketSquare/robotframework-browser

Get Elements should not raise timeout exception when no elements found. It should return an empty list.

I mean that it will with the exception waiting version wait until timeout

mkorpela

comment created time in a day

IssuesEvent

pull request commentMarketSquare/robotframework-browser

Get Elements returns empty list when element is not found

This most likely just waits for the timeout. So it does not fix.

aaltat

comment created time in a day

push eventrobotframework/robotframework

Mikko Korpela

commit sha 7239a3fee546626755bea4aeb8225ba22569a7c3

fix desktop long library name above doc text

view details

push time in 2 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha 35b4db8561b586f9f17543640ae4feb1ea23d1a1

ie11 background defaults

view details

push time in 2 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha 1428a3f5a631c428fae0c4d8b373e475901ced45

fix highlighted color

view details

push time in 2 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha d08ca81fb7d7ee4201415cc204e1d65d2d418bd5

no scroll to hash + side-effects when clearingKeywords search

view details

Mikko Korpela

commit sha aa4f66bcb59c3210b0bee52391f3f99262243dbe

replace path with no params when clearingKeywords

view details

Mikko Korpela

commit sha 85003321ce6bfabb9e56b7c89c2cc7d33a40b234

remove comma from args

view details

Mikko Korpela

commit sha f1ff636f72641af6e904d7283f6895d69ddcc3ea

close menu when link clicked

view details

push time in 2 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha ece21a321c1ced52bd7dd8f639ab29a4a0c89ee7

fix tests about TOC containing shortcuts and tags

view details

push time in 3 days

issue commentrobotframework/robotframework

Implicit type conversion should ensure type or raise an exception

The major benefit in static types is static type checking. Robot Framework <-> Python interface is a border. I've seen this happen with several languages: Objective-C <-> Swift, Java <-> Kotlin and JavaScript <-> Typescript for instance. Type hint based type checking starts from the expectation that the type hint holds. When it does not, it results in very ugly and hard to debug bugs.

None is the basic example of this problem. Objective-C and Java let null be part of every type, and Swift and Kotlin do not. This means that in pure Swift or Kotlin world there are no nullpointer problems. That is solved completely by the static type checking in Swift and Kotlin.

JavaScript as with RF the problem is a bit larger (although I would still argue that most likely problem is still the nullpointer case) as you can completely miss the type. Again hard to debug bugs and code (Python with type hints or TypeScript) that kind of tells that things should be ok.

Making a border that lets invalid types through will generally then mean that responsibility will be on the library side and Robot Framework facing keywords should not be typed. As the types can not be guaranteed.

mkorpela

comment created time in 3 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha 228c8e01cf212e5bd686755abed333f7277e5d18

search box color

view details

push time in 3 days

issue commentrobotframework/robotframework

Implicit type conversion should ensure type or raise an exception

After some thought there are two things happening here:

  1. Automatic type conversion (from string to what the converter thinks should be ok for the receiving end)
  2. Me as a library developer assuming that this is also a type guard that will fail when user gives an enumeration value that is not allowed.

I propose that we add the type guard that will raise an exception if the receiving end expects a specific type and one is not given. Expectation must be explicit and not inferred from a default value.

mkorpela

comment created time in 3 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha faa695268bb6050dc386d29b02e01c05328f4c69

make robot work in dark

view details

push time in 3 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha 8f868ca1658d7c298989b3ff4c1441a72edb584d

colors and darkmode

view details

push time in 3 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha d4d345d2df557930dc20ae93bf93d9678e010b61

fix title not showing on ie11

view details

push time in 3 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha 5713b3df3378c29a7f8dd29d37a93172569df17c

tune hamburger

view details

push time in 3 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha 257b408694e5b35f786cf322f8314b3d911be375

go to top menu mode when under 900px screen width

view details

Mikko Korpela

commit sha 0be44f9cd710e3a6cdb1f2974439355101c23a0a

portin to ie11

view details

Mikko Korpela

commit sha a0c54fd55685333dcf7db9411178c0f80bafd618

tuning limits

view details

Mikko Korpela

commit sha 7602faeeacb52da34a5862417091ffaaba2fcfc4

tune search indent

view details

push time in 3 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha 0db6ad8ca029b21d92c7fa660a35b2020b537e2f

clear tagsSelect when search is cleared

view details

Mikko Korpela

commit sha 83b9730f613c1d3a93a879aeb97b4bb2abd763eb

limit menu width

view details

Mikko Korpela

commit sha 3e127bfaa30bce4f8458b2d4cd9b98d3571d18bd

shortcuts max width in mobile view

view details

Mikko Korpela

commit sha 4d9c020fc890291546673f0e5f2eae56e39285b4

show doc only if one exists

view details

Mikko Korpela

commit sha 5631f4d0ebde149f93e2c8f6ba5ccd415c35af79

Show doc in inits only if one exists

view details

Mikko Korpela

commit sha 13d3eab1dbc6484ca51a3c10403dcb8faf9474de

reorder keywords based on matched or not

view details

Mikko Korpela

commit sha d8652620a57067b37e1b1a91668627a51f02dc15

highlight in args + no-match gray

view details

Mikko Korpela

commit sha 0b0c9cc03c51fa9b73c2c26288c47941ef0c6905

all content to own rows

view details

Mikko Korpela

commit sha 459229c0c87b2df2467003e8b9b44f7b104abac1

tune max width for bigger screens (1920×1080) => 1600 + 320

view details

push time in 3 days

issue commentrobotframework/robotframework

Failure stdout to show where failure happened

About exception representation https://www.diva-portal.org/smash/get/diva2:1052658/FULLTEXT01.pdf

mkorpela

comment created time in 4 days

issue commentrobotframework/robotframework

Implicit type conversion should ensure type or raise an exception

I would prefer option 3. incase the type is defined explicitly. Python is in my opinion going towards JS world and TypeScript typing system. Types should fail fast. Preferably before execution, but execution time typecheck is also ok.

If it is inferred from default value only, then I would assume type as Any and allow all..

mkorpela

comment created time in 4 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha a8aff6ac48624e4643f69e67c4a2c39f63e67773

remove search and tags headers

view details

push time in 4 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha 4bd6b926367fa299598021efb6a342c06b907399

make menu more dense

view details

push time in 4 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha 72e60b2904e4754640160bd45ae46f0ab2ee904d

less pixels for the top header

view details

push time in 4 days

issue openedrobotframework/robotframework

Implicit type conversion should ensure type or raise an exception

When implementing Browser library, we heavily used enum conversion feature as we thought that this offloads type checking to Robot Framework side. Unfortunately this is not the case and now there are some leaky ways of invalid types getting in to library function parameters.

Basically two things have been discovered so far:

  1. If an argument object is not a string, it will be passed to library keyword without checking the type agains required type.
  2. None is expected to be part of all types and strings (and objects) that can be converted to none are passed as None.

https://robotframework.org/robotframework/latest/RobotFrameworkUserGuide.html#implicit-argument-types-based-on-default-values

Example case Python``` from enum import Enum

class Fruit(Enum): APPLE = 1 ORANGE = 2 STRAWBERRY = 3

def eat_fruit(fruit: Fruit): print(type(fruit))


RobotFramework```
*** Settings ***
Library  fruits.py

*** Test cases ***
Testing
     Eat fruit   APPLE     # OK
     Eat fruit   Orange   # OK
     Eat fruit   None       # Is converted to None => Should raise an exception as the type it not optional
     Eat fruit   ${32}      # Type is ignored => Should check type and raise an exception

Now it seems that the type conversion leaks invalid objects. This implies that library should then doublecheck the types anyway. In my opinion Robot Framework should ensure valid types when they are explicitly given in the library code.

created time in 4 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha 208c9c4c82b68b8a3ae003d6f33bce81980fce9a

scroll to top - really

view details

Mikko Korpela

commit sha 288abc10d9286da35bd8976595425b236f94b9bd

shortcuts and tags targets removed

view details

Mikko Korpela

commit sha f795c730612c3659e7ffe6bde269ef5a57fcbdc9

Remove Shortcuts and Tags from TOC

view details

Mikko Korpela

commit sha 0b8fec58f3d58d2466ee3ecad29b425f8f3a6a9e

fix firefox menu overflow

view details

push time in 4 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha 4b2be44042fea61ab8493d8df7a6adc44741a171

remove functionality to hide unmatched keywords

view details

Mikko Korpela

commit sha 88509641e22c25e9f2d4a514a54d0bf75c966aec

scroll keywords to top when tags selected

view details

push time in 4 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha c2ec8e087ca4cf4994e2c5be1a3ff77704e927b7

initial target shadow

view details

Mikko Korpela

commit sha c8e93f7bf848ff670741fc6f1b5cbcf074143b1a

make box-shadow show also on left side

view details

Mikko Korpela

commit sha fd34ea5f97952750eaf6596e5ff50ea9cbbdc0ce

use robot turquoise

view details

push time in 4 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha 09ba74a619161aa346459a8ba4dc16e06c7dd29a

reduce margin

view details

push time in 4 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha bd952591ee82993c25037f65cf2dc1301ac3e806

menu layout tuning

view details

Mikko Korpela

commit sha 21fd575d1330c71770c34325e013cfa8bb42bad0

tag selection nsync

view details

push time in 4 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha d8fa3672e453e88e6a84e6aeb2328098b3bc1c71

prevent rf logo from getting under hamburger

view details

push time in 5 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha 33ff8726255d99abcb2156624f835bac3812374e

Prevent ios Safari zoom on input

view details

push time in 5 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha a035b03f47bbff5ec3622de2ff5982b5f9765feb

tags to menu

view details

Mikko Korpela

commit sha 94b484e4569101476820c55f33331072a32144a8

tags WIP

view details

push time in 5 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha 39563e0561592c79fe5e4db0bb1399de7f5540f5

prevent default input behaviour

view details

Mikko Korpela

commit sha da243b3067a8c6aef7f7cb5ce0121fa95106852d

tuning

view details

Mikko Korpela

commit sha b973bc4aeb3bb3e9b5fbb460803de029ab923056

prevent default did not work

view details

Mikko Korpela

commit sha 805d586d09bd6223ea7e92799df6a565ae0a898a

only redraw keyword shortcuts when searching

view details

Mikko Korpela

commit sha 5c9da121d27c60e4b0bbbf6acdd153e01619d20d

remove old search ui

view details

push time in 5 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha 36c29e1c399a38f618d025e14c28faf57ad8e4eb

remove keydown global handling

view details

Mikko Korpela

commit sha 05256cf13763915a8860a97004a5521eaf750e20

search wip

view details

Mikko Korpela

commit sha 5d96627ed101e1e238da78872f3fa5c0daf432c9

details top to others level

view details

push time in 5 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha fa42497e07e33b2549f33f370f1584183748be60

add search to overview

view details

Mikko Korpela

commit sha 1e1c930ab07169e91df45157f254fe0f357146f7

Search box style

view details

Mikko Korpela

commit sha eeb20a455e2d9ca285b8de66c779d8e354fb5a41

tuning css

view details

push time in 5 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha 7f2bbdfc1f7af28edc613b3b4a116a4ba6fade9e

libdoc-overview defines margin to details

view details

Mikko Korpela

commit sha b638a9f7a9a15068e1a5494fd3b461331304f191

remove title border

view details

Mikko Korpela

commit sha 25c4ee06bbd6735cfea30e1de81ace3b2589a93d

tune hamburger menu touch area and animation speed

view details

Mikko Korpela

commit sha d86287ae2f38d08618d7d2fee1b7e07881b1895f

fix syntax error

view details

Mikko Korpela

commit sha 3770f13285b02700299b6492842800a03483075b

add scroll-margin-top (Safari support still missing)

view details

push time in 5 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha f81f60a902cf1b928776d7c43fe7ba995f411414

use rf svg instead of ico

view details

push time in 6 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha 199bd712c273b03ec58c4e2ccd1f6d9d89aaa81f

no name again

view details

Mikko Korpela

commit sha d5bbc7d862c73a1849051c5b5646eb90a6f1a4fa

separate lib name from keywords

view details

Mikko Korpela

commit sha d885dbaac3cfb2e7042ed96f28e3b6f1079db772

keyword name based left panel width

view details

Mikko Korpela

commit sha ede5fccfa5cf7741f2b145a4be3181fe6e5c9b3e

split header form keywords left panel

view details

Mikko Korpela

commit sha ef20cfe3c0cecfb215a2ea3e3c210c10c2f9ea8b

tune mobile layout margin

view details

Mikko Korpela

commit sha a4fafd811f74a4761781573232056dcf991ac8e4

hamburger seed

view details

Mikko Korpela

commit sha e779d63a409fd8134478b665a820ea47a03c47d3

close hamburger menu when element selected

view details

Mikko Korpela

commit sha 609301d8de23e743104863471a9d7e36f7d9a08f

hamburgermenu nro 1

view details

push time in 6 days

issue commentrobotframework/robotframework

Libdoc localizations

Questions: Ux: How should this be in code comments? Tech: How should it be stored in libdoc outputs? Ux: How should language choice be shown in libdoc.html.

mkorpela

comment created time in 7 days

issue closedrobotframework/robotframework

`xmlschema` is missing in requirements-build.txt

Hi Peke,

xmlschema is missing in the requirements. So all libdoc atests fail.

Cheers

closed time in 7 days

Snooz82

issue commentrobotframework/robotframework

`xmlschema` is missing in requirements-build.txt

https://github.com/robotframework/robotframework/blob/master/atest/requirements-run.txt

Snooz82

comment created time in 7 days

issue openedrobotframework/robotframework

Libdoc localizations

One of the key features of Robot Framework is good accessibility. We have many users accross the globe. Most of them (including my self) are not native english speakers. To make Robot Framework more accessible we should support multiple languages in library documentation. This would allow a much larger audience to understans what keywords do.

created time in 7 days

startedMarketSquare/robotframework-robocop

started time in 8 days

pull request commentrobotframework/robotframework

Topic/libdoc html

  • [ ] hash url => highlight
  • [ ] click or scroll => remove hash url
  • [ ] search to left panel + remove floating search
  • [ ] mobile layout (max 640px)
  • [ ] RFW logo to svg
  • https://github.com/robotframework/visual-identity#brand-guidelines
  • [ ] Robot Turquoise 0/192/181 as highlight colour.
  • [ ] Tags
mkorpela

comment created time in 8 days

issue commentrobotframework/robotframework

Improving libdoc HTML output for mobile

@boakley css controls now most of the look and feel of an html page. This means that it mostly builts what you see where as html only has some nodes of data. Most of the work I have done so far is css. I think we need to think carefully how this custom styling should actually happen. For instance overwriting colors might be easy or using company font or adding logo, but changing menu locations or link or list styles globally might have unwanted consequences.

mkorpela

comment created time in 9 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha cec6580e978e6ad1df43b073cb5ec048d6946026

padding

view details

push time in 9 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha e61549fcffd1007c16c3ac5ac5d34aa150653451

move readme link to library name

view details

Mikko Korpela

commit sha 20b9eb464932c3eb072df7dbbecc198609fca150

css tune

view details

Mikko Korpela

commit sha 88b9a55bc764100d57762e346dfb6781a38f2fea

css tuning

view details

Mikko Korpela

commit sha 5dcb721fca4282532c4e80a8656914ea061f294f

separate tags from keywords

view details

push time in 9 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha 9cbd20f242e27965d78432d775148ef97dd67ea7

shortcuts on left menu

view details

Mikko Korpela

commit sha ef5551ecb393d3e80b05de1806598b7ebba0f24f

fix old js equals

view details

Mikko Korpela

commit sha 1294724a0859132e9b039356a8888390fbc80e7a

menu tuning

view details

Mikko Korpela

commit sha 62d2c4f625aa1057efc0837769f5105aaf477281

improve shortcut click area

view details

push time in 9 days

push eventrobotframework/robotframework

Mihai Pârvu

commit sha 208852a6d72ca0de924bee8140e3c3748102074b

Exclude some standard library keywords from automatic type argument conversion due to `none` => `None` evaluation. (#3660) Fixes #3649.

view details

Mikko Korpela

commit sha 67828db9a1b7bd01345e674473fc31b4ede598d6

add viewport tag for responsive scaling

view details

Mikko Korpela

commit sha 045ed6452d171f8670ab5e48cbe9d16d87829401

pre formatted code blocks should not overflow from their background. Instead there should be a scrolling possibility when overflow happens.

view details

Mikko Korpela

commit sha fac70c6efaeab934f424c3e234875197ff17d1e0

libdoc.html: flexbox div instead of table

view details

Mikko Korpela

commit sha 9c558f5be962244385b05cd009cb9dfd61b057f2

libdoc: hide unmatched keywords again

view details

Mikko Korpela

commit sha 455d343276874d939f6f5808b421d98ed831e8ba

prevent table overflow in docs

view details

Mikko Korpela

commit sha b84864d2a76814a27fb818e81ee72622a7598a9a

no block borders for table - only table inner borders

view details

Mikko Korpela

commit sha 4c2440f898999ac7963f947d5c1f256dcc953da1

libdoc: internal links to kw-block

view details

Mikko Korpela

commit sha dfa2fa87eee1419452d80ada8975aa64b1dcb32f

mediaquery proto

view details

Mikko Korpela

commit sha 76594f1d33206f2565d8697a813c0b046fe4d8c3

big screen tuning

view details

Mikko Korpela

commit sha cd5ba0922ed311a1ad5ea4609f3e586cc0139c32

tag style

view details

Mikko Korpela

commit sha 93321c5df2c11256b9cc50aeb5d8f5ee5d9fe25f

libdoc: fix imports

view details

Mikko Korpela

commit sha 4031592b465b2a9ceac665ccb89bcfcd95f16508

fix link style

view details

Mikko Korpela

commit sha f3d77140fbf33913c40ed37330dee4467a61fb13

Revert "tag style" This reverts commit ddaa698f190e011e19701d5727c79dcc6aa1dd5e.

view details

Mikko Korpela

commit sha a7ab1d3b4177fbdd2589218c5f42e445da049685

prevent overflow

view details

Mikko Korpela

commit sha 985941323ad5e809543b910a54172abdaee6b9e2

remove scrollbars

view details

Mikko Korpela

commit sha 77d2562f3e59b8f300ede1646f293beb0f6ec2fb

fix keyword-container select

view details

Mikko Korpela

commit sha 323d8b85f58221bf88ccdb2d14e7b4a61333fbbc

remove link color for better accessibility

view details

Mikko Korpela

commit sha 6e075ea042b8017ec8fe955ca15b208227fc1d8f

fix importing section

view details

Mikko Korpela

commit sha f066d43998e25bad660789d82c1ffa412b1fe6ae

tuning code blocks

view details

push time in 9 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha b442c64c1818bbde50d54bb9b64d4fa26a983b23

tuning code blocks

view details

Mikko Korpela

commit sha ca08ea179c6fcf044f125357f34d8b9f2507e7fe

show arguments only when they exists

view details

Mikko Korpela

commit sha a1616a19f45416d13c135510785805326b35d10b

use system-ui font family and normal font size

view details

Mikko Korpela

commit sha c4f296d3130f20fc86a79cbb8174e254006b320f

attach RF icon to title

view details

push time in 9 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha 1c2f28270795bed644565d3905ac5f47fc7bdec1

fix importing section

view details

push time in 10 days

push eventMarketSquare/robotframework-browser

allcontributors[bot]

commit sha 5b5d1f4a3f249527a40a232b684f7c913447f191

docs: update README.md [skip ci]

view details

allcontributors[bot]

commit sha 19ef82cfaeb95fdf3dd8d7d239e01bd44ede1a18

docs: update .all-contributorsrc [skip ci]

view details

Mikko Korpela

commit sha ef2943a89b7042d97785c7e2f516555a3a56f85c

Merge pull request #400 from MarketSquare/all-contributors/add-emanlove docs: add emanlove as a contributor

view details

push time in 10 days

PR merged MarketSquare/robotframework-browser

docs: add emanlove as a contributor

Adds @emanlove as a contributor for doc.

This was requested by mkorpela in this comment

+13 -1

0 comment

2 changed files

allcontributors[bot]

pr closed time in 10 days

pull request commentMarketSquare/robotframework-browser

Minor correction - removed special characters within code example

@all-contributors please add emanlove for doc.

emanlove

comment created time in 10 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha a9f194e1390bcb3165e4cf7329f212ac66767be5

fix keyword-container select

view details

Mikko Korpela

commit sha ece974d0e4ccee659d060e69c32fe7f69a3af74f

remove link color for better accessibility

view details

push time in 10 days

push eventrobotframework/robotframework

Mikko Korpela

commit sha 6d425e1ca1ad05bc0d698a7897cd3544e770f261

remove scrollbars

view details

push time in 10 days

issue commentrobotframework/robotframework

Improving libdoc HTML output for mobile

Pull request https://github.com/robotframework/robotframework/pull/3675

mkorpela

comment created time in 10 days

pull request commentrobotframework/robotframework

Topic/libdoc html

Example http://dynamic-trip.surge.sh/ and Old version http://dynamic-trip.surge.sh/old.html

mkorpela

comment created time in 10 days

PR opened robotframework/robotframework

Topic/libdoc html

New style for libdoc .html: Better mobile support.

+101 -54

0 comment

3 changed files

pr created time in 10 days

create barnchrobotframework/robotframework

branch : topic/libdoc-html

created branch time in 10 days

PR opened robotframework/robotframework

failure exceptiontype in output.xml

Based on discussions on #devel channel.

I got requirement that perform auto analysis on failures. I have did this but I felt if robot provide few info in error message this will help more in my task with high accuracy Example: Let us assume test case consist keyword Should Be True "Demo" != "Demo1" and it got failed, we will get error message like "Demo" != "Demo1" In above error message =! is my key and I update testcase analysis comment that its application issue since validation got failed. Note: Accuracy may not be 100% but we have started and will improve this. Here I need help from robotframework that, Let us have custom robotframework exceptions as prefix in error message Example:

  1. Robotframework: If any Should * keyword got failed error message should be like ValidationException: <actual error>
  2. Selenium: If any Wait * keyword got failed error message should be ElementException: <actual selenium throwed exception & error> So above approach gives confident on which type of error we got based on exception type and we can take a call on this. Note: This is draft idea and im not sure is this possible or not, is it valid?, how it helps robotframework, how other libraries owner react to it if possible. Since we are working on CI error message like showing error line number I have proposed this.
+12 -9

0 comment

4 changed files

pr created time in 11 days

create barnchrobotframework/robotframework

branch : topic/exceptiontype-in-output

created branch time in 11 days

push eventMarketSquare/robotframework-browser

Mikko Korpela

commit sha 2f796f254890c5279910312f60d857f3ba1ef2ec

Expose fullPage flag from screenshot

view details

Mikko Korpela

commit sha b2fa70799b655c88244e85e4e345fb5722ed5b0a

docs

view details

push time in 11 days

PR opened microsoft/playwright

Update api.md

Fix typo in fullPage description.

+1 -1

0 comment

1 changed file

pr created time in 11 days

push eventmkorpela/playwright

Mikko Korpela

commit sha ddc39afcf03ebae627497baaf0bc266cbc1eb359

Update api.md Fix typo in fullPage description.

view details

push time in 11 days

fork mkorpela/playwright

Node.js library to automate Chromium, Firefox and WebKit with a single API

https://playwright.dev

fork in 11 days

pull request commentrobotframework/robotframework

Sketching how to make keyword start, end and lineno work on Listener v3 and v2

Test template lineno is still None.

mkorpela

comment created time in 11 days

issue commentrobotframework/robotframework

Support for `start/end_keyword` in listener version 3

Related draft pull request #3672

bergstenarn

comment created time in 11 days

issue commentrobotframework/robotframework

Expose keyword line numbers via listener API v2

Related draft. https://github.com/robotframework/robotframework/pull/3672

pekkaklarck

comment created time in 11 days

create barnchrobotframework/robotframework

branch : topic/listener-improvements

created branch time in 11 days

issue commentmkorpela/pabot

The 'robotframework' distribution was not found and is required by robotframework-pabot

Could you update pabot to latest?

Stansfield

comment created time in 11 days

issue openedMarketSquare/robotframework-browser

Go to should return HTTP status code

Describe the bug We should detect 404 and 500 return codes. page.goto will not throw an error when any valid HTTP status code is returned by the remote server, including 404 "Not Found" and 500 "Internal Server Error". The status code for such responses can be retrieved by calling response.status().

So return code should be returned when we navigate to a page.

created time in 12 days

push eventMarketSquare/robotframework-browser

Mikko Korpela

commit sha 8d9dae4301fe263bc0f7682de58a6bf299211382

fix screenshot test

view details

Mikko Korpela

commit sha d555d6fcdbe3350f59fb05faec7ccf49f1b2a97b

Add crawl site stub

view details

Mikko Korpela

commit sha f256f0226cdc46f85e1349beb620d6efa81d6d9e

tif

view details

Mikko Korpela

commit sha c55b4ee02e82f04e7e226934e3b4aa2ee6a127f9

crawler draft

view details

Mikko Korpela

commit sha c6f3f2bdf197aa9299034effca16d20fceeefd38

lint

view details

Mikko Korpela

commit sha 4d483abfb6286fcf567a6dfe2fc7240880bc049a

initial doc

view details

Mikko Korpela

commit sha b795c0a71bcafeb2536334862ebc1e18e1ad1082

crawl BFS

view details

Mikko Korpela

commit sha 26ac90fba40fc38a1accb30f8a09ada0d99343a6

black

view details

Mikko Korpela

commit sha 3663a35e25234879e68d848d90344cf1434d3411

ignore zip files

view details

push time in 12 days

push eventMarketSquare/robotframework-browser

Mikko Korpela

commit sha 8d9dae4301fe263bc0f7682de58a6bf299211382

fix screenshot test

view details

push time in 12 days

push eventMarketSquare/robotframework-browser

Mikko Korpela

commit sha 65e87d47a329aae1a84e158fcb8233e592ba79a1

fix typo

view details

Mikko Korpela

commit sha 9a71ac6a8f3f23401cbfff8a611a34d2fb265586

show screenshot

view details

Mikko Korpela

commit sha 3e67a568619b0ff9360bbba6ebc290a16ba0b861

Add crawl site stub

view details

Mikko Korpela

commit sha 1a9b1e97c87b4be41f613d9702324b074ce60691

tif

view details

Mikko Korpela

commit sha fa355db477d22520f65a6bf38c1aca4bf89e3738

crawler draft

view details

Mikko Korpela

commit sha b9d5c6c6aa5edbbd47c543033b6d432e429fcd82

lint

view details

Mikko Korpela

commit sha e2412150a430b803c8108bc3f629ec30b1d11b33

initial doc

view details

Mikko Korpela

commit sha 22e2d41b34af5371f5f7c1d8db1e43ac2a05b4e0

crawl BFS

view details

Mikko Korpela

commit sha d6d2958650cbd84163458b098bd44701e020a385

black

view details

Mikko Korpela

commit sha 88db42b44e954e5d6019dbbc09a8120ede51c0f1

ignore zip files

view details

push time in 12 days

push eventMarketSquare/robotframework-browser

Mikko Korpela

commit sha 65e87d47a329aae1a84e158fcb8233e592ba79a1

fix typo

view details

Mikko Korpela

commit sha 9a71ac6a8f3f23401cbfff8a611a34d2fb265586

show screenshot

view details

push time in 12 days

PR closed robotframework/robotframework

Topic/listener v2 lineno and source

This is here to start discussing on how this should be designed.

I've added @boakley pull request commit (on top of master and criticality removal changes by @yanne ) as the bases.

Related issue: https://github.com/robotframework/robotframework/issues/3538

+356 -948

0 comment

89 changed files

mkorpela

pr closed time in 12 days

PR opened robotframework/robotframework

Topic/debugger api

Lsp debugger needs for a stable API for a debugger. Key requirements for the (listener) API are:

  1. Source + linenumber for currently executed step. To stop in debugger to a specific point OR to show where we are in robot code.
  2. Variables in scope. To observe variables and their current values.
  3. Execution stack (suite source + line, test source + line, keyword source + line). To show also higher levels of execution.
  4. Keyword / variable evaluation in context. When debugger is stopped to certain position, to be able to execute a keyword.

This DRAFT Pull request now contains an example DebuggerListener with call stack and line numbers exposed through Listener API 2.

To test it: ./rundevel.py --listener robot.api.DebuggerListener YOURTESTS

+61 -11

0 comment

9 changed files

pr created time in 12 days

create barnchrobotframework/robotframework

branch : topic/debugger-api

created branch time in 12 days

create barnchrobotframework/robotframework

branch : topic/libdoc

created branch time in 12 days

MemberEvent

issue commentMarketSquare/robotframework-browser

Crawl screenshots / page errors

Related pull https://github.com/MarketSquare/robotframework-browser/pull/392

mkorpela

comment created time in 13 days

pull request commentMarketSquare/robotframework-browser

Topic/crawler

  • [ ] Make it BFS algo
  • [ ] Control max deepness in branches
  • [ ] Ignore some url pattern
  • [ ] Check and report 404 and other errors
  • [ ] Reuse already open page
mkorpela

comment created time in 13 days

PR opened MarketSquare/robotframework-browser

Topic/crawler

Crawling a site for screenshots and errors.

+46 -0

0 comment

4 changed files

pr created time in 13 days

create barnchMarketSquare/robotframework-browser

branch : topic/crawler

created branch time in 13 days

issue openedMarketSquare/robotframework-browser

Set Browser Timeout should be ok to call even when no browser is open.

Describe the bug It will crash currently.

created time in 13 days

issue commentMarketSquare/robotframework-browser

Get Elements instead of Get Element

This seems to already work. Although Bug defined here is a valid one. I'll edit the title.

mkorpela

comment created time in 13 days

issue commentrobotframework/robotframework

Failure stdout to show where failure happened

I like your example output better Bryan, but I think that time playes an important role here. So command line output could be already available before test execution is over. Once it is over then log is also available. But giving the location in the output at the time it happens, gives a possible speed up in testing and fixing iteration.

mkorpela

comment created time in 13 days

issue openedrobotframework/robotframework

Failure stdout to show where failure happened

WHY Current normal Robot Framework command line output does not show where a failure happened. It will only show failed test case name and failure message.

Especially when executing tests on a continuous integration server or service, such as GH Actions, Travis CI or CircleCI, first thing you will look at is the terminal output related to the specific task that failed. Showing directly where the failure happened, would speed up debugging and most likely also make it more likely that easy to fix bugs will be get fixed faster.

Logs are only generated at the end of execution and will also require by default a manual download. This is why I believe they should be used mostly in more demanding debugging situations or when reporting a failure happens far away from time when a failure is fixed.

pytest has a very nice and informative way of showing failure output and this many times points directly the root cause of the problem. For instance a change in input data.

WHAT Lets show where a failure happens directly on the command line output.

HOW I propose that the failure message that gets printed to stdout should have the following components:

  1. Failure message from the error as it is already shown
  2. File and linenumber of the step that is failing
  3. The step as it is in the file (possibly some parts truncated if too big)
  4. The step arguments resolved to values (possibly some parts truncated if too big)

A proof of concept of this can be found from https://github.com/robotframework/robotframework/commit/49dede55654d390bd40fd9e98716330e09ffe0ba

Optimal output would in my opinion look something like this:

==============================================================================
Test
==============================================================================
Test.04 Frames
==============================================================================
Test.04 Frames.Deep Frames
==============================================================================
First level                                                           | PASS |
------------------------------------------------------------------------------
Second level                                                          | PASS |
------------------------------------------------------------------------------
Third level                                                           | FAIL |
test/resources/frame_stuff.robot:15
> Get Text    ${selector}    ==    This is ${part}
E Get Text    id=b >>> id=c >>> id=cc    ==    This is g
E Property innerText `This is c` should be `This is g`
------------------------------------------------------------------------------
Third level from second                                               | PASS |
------------------------------------------------------------------------------
Test.04 Frames.Deep Frames                                            | FAIL |

created time in 13 days

more