profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/miniupnp/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Thomas BERNARD miniupnp Paris http://miniupnp.free.fr/ some experience in network programming (BSD sockets and such) retrocomputing enthousiast.

atarijookie/ce-atari 25

Official repository for Cosmos Ex software

miniupnp/AtariST 19

Various AtariST/STE stuff

miniupnp/hfsplustools 8

Tools to manipulate (Apple) HFS+ file systems, such as .toast files or .dmg

miniupnp/Cards-Against-Humanity---Generator 4

Card Generator from CSV file + French translation attempt

miniupnp/DreamCastIntros 3

old works for the ECHELON Dreamcast release group

miniupnp/eskimo 2

ESKIMO Fishing Trip game source

atarijookie/ce-atari-releases 1

repository containing releases for Cosmos Ex devices for Atari ST

miniupnp/ardrone-tool 1

Automatically exported from code.google.com/p/ardrone-tool

miniupnp/idsk 1

Edit DSK files from the command line

miniupnp/6502 0

Highly portable MOS 6502 CPU emulator written in ANSI C

delete branch miniupnp/miniupnp

delete branch : include-dir

delete time in 3 days

issue commentminiupnp/miniupnp

Using gateway address

first of all, could you precisely describe your environment ? OS version, miniupnpc library version etc. It looks like you are using the python module, is that right ? Which python version.

It is easier to help people when we are 100% sure we are talking about the same thing.

mrx23dot

comment created time in 3 days

push eventminiupnp/miniupnp

SpaceIm

commit sha da771539c1e11fa5a699eb8285977ea8e1a3bde5

fix cross-build to iOS/tvOS/watchOS

view details

Thomas BERNARD

commit sha 77876aea5fd926ef25dce9af6b264c7b53d2b134

Merge pull request #555 from SpaceIm/fix/cmake-cross-build-ios CMake: fix cross-build to iOS/tvOS/watchOS

view details

push time in 3 days

PR merged miniupnp/miniupnp

CMake: fix cross-build to iOS/tvOS/watchOS

Cross-compilation of miniupnpc to iOS/tvOS/watchOS fails:

<details><summary>Compilation errors</summary>

[5/16] Building C object source_subfolder/miniupnpc/CMakeFiles/libminiupnpc-static.dir/minissdpc.c.o
FAILED: source_subfolder/miniupnpc/CMakeFiles/libminiupnpc-static.dir/minissdpc.c.o
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -DMINIUPNPC_SET_SOCKET_TIMEOUT -DMINIUPNP_STATICLIB -D_BSD_SOURCE -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 -Isource_subfolder/miniupnpc -O3 -DNDEBUG  -arch arm64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.2.sdk -miphoneos-version-min=12.0 -fPIC -MD -MT source_subfolder/miniupnpc/CMakeFiles/libminiupnpc-static.dir/minissdpc.c.o -MF source_subfolder/miniupnpc/CMakeFiles/libminiupnpc-static.dir/minissdpc.c.o.d -o source_subfolder/miniupnpc/CMakeFiles/libminiupnpc-static.dir/minissdpc.c.o -c source_subfolder/miniupnpc/minissdpc.c
source_subfolder/miniupnpc/minissdpc.c:690:35: error: use of undeclared identifier 'IP_MULTICAST_TTL'
                if(setsockopt(sudp, IPPROTO_IP, IP_MULTICAST_TTL, &ttl, sizeof(ttl)) < 0)
                                                ^
source_subfolder/miniupnpc/minissdpc.c:733:20: error: use of undeclared identifier 'INADDR_NONE'
                                mc_if.s_addr = INADDR_NONE;
                                               ^
source_subfolder/miniupnpc/minissdpc.c:736:23: error: use of undeclared identifier 'INADDR_NONE'
                        if(mc_if.s_addr != INADDR_NONE)
                                           ^
source_subfolder/miniupnpc/minissdpc.c:739:37: error: use of undeclared identifier 'IP_MULTICAST_IF'
                                if(setsockopt(sudp, IPPROTO_IP, IP_MULTICAST_IF, (const char *)&mc_if, sizeof(mc_if)) < 0)
                                                                ^
source_subfolder/miniupnpc/minissdpc.c:749:18: error: variable has incomplete type 'struct ifreq'
                                struct ifreq ifr;
                                             ^
source_subfolder/miniupnpc/minissdpc.c:749:12: note: forward declaration of 'struct ifreq'
                                struct ifreq ifr;
                                       ^
source_subfolder/miniupnpc/minissdpc.c:751:40: error: use of undeclared identifier 'IFNAMSIZ'
                                strncpy(ifr.ifr_name, multicastif, IFNAMSIZ);
                                                                   ^
source_subfolder/miniupnpc/minissdpc.c:752:18: error: use of undeclared identifier 'IFNAMSIZ'
                                ifr.ifr_name[IFNAMSIZ-1] = '\0';
                                             ^
source_subfolder/miniupnpc/minissdpc.c:753:20: error: invalid application of 'sizeof' to an incomplete type 'struct ifreq'
                                if(ioctl(sudp, SIOCGIFADDR, &ifr, &ifrlen) < 0)
                                               ^~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.2.sdk/usr/include/sys/sockio.h:94:25: note: expanded from macro 'SIOCGIFADDR'
#define SIOCGIFADDR     _IOWR('i', 33, struct ifreq)    /* get ifnet address */
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.2.sdk/usr/include/sys/ioccom.h:97:53: note: expanded from macro '_IOWR'
#define _IOWR(g, n, t)    _IOC(IOC_INOUT,       (g), (n), sizeof(t))
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.2.sdk/usr/include/sys/ioccom.h:92:13: note: expanded from macro '_IOC'
        (inout | ((len & IOCPARM_MASK) << 16) | ((group) << 8) | (num))
                   ^~~
source_subfolder/miniupnpc/minissdpc.c:749:12: note: forward declaration of 'struct ifreq'
                                struct ifreq ifr;
                                       ^
source_subfolder/miniupnpc/minissdpc.c:775:37: error: use of undeclared identifier 'IP_MULTICAST_IF'
                                if(setsockopt(sudp, IPPROTO_IP, IP_MULTICAST_IF, (const char *)&mc_if, sizeof(mc_if)) < 0)
                                                                ^
9 errors generated.
[15/16] Building C object source_subfolder/miniupnpc/CMakeFiles/libminiupnpc-static.dir/miniwget.c.o
ninja: build stopped: subcommand failed.

</details>

CMAKE_SYSTEM_NAME is not Darwin for these hosts. I could repeat CMAKE_SYSTEM_NAME for all these OS, but APPLE variable avoids boilerplate.

+2 -2

1 comment

1 changed file

SpaceIm

pr closed time in 3 days

PullRequestReviewEvent

issue commentminiupnp/miniupnp

API documentation

https://github.com/miniupnp/miniupnp/blob/master/miniupnpc/include/upnpcommands.h#L65 https://github.com/miniupnp/miniupnp/blob/master/miniupnpc/include/miniupnpc.h#L44 etc.

Also https://github.com/miniupnp/miniupnp/blob/master/miniupnpc/man3/miniupnpc.3

also for the python module : https://github.com/miniupnp/miniupnp/blob/master/miniupnpc/src/miniupnpcmodule.c#L561

mrx23dot

comment created time in 7 days

issue commentminiupnp/miniupnp

Using gateway address

working from a different subnet is not always straightforward. Can you check if upnp.discover() does indeed discover your IGD at 192.168.0.1 ?

mrx23dot

comment created time in 7 days

pull request commentminiupnp/miniupnp

miniupnpd: Add check that port forwarding is not blocked by local or upstream router firewall

I'm still not convinced the proposed test are neither 100% correct nor really useful.

Firewall should not block the traffic coming from the WAN to the LAN and to the LAN to the WAN, but if you open a port mapping, there is no obligation that it should be open if coming from the LAN. In my opinion, the only way to perform a correct test would be from the WAN.

pali

comment created time in 10 days

issue commentminiupnp/miniupnp

miniupnp minor issue bug?

https://github.com/miniupnp/miniupnp/commit/3a87be33e797ba947b2b2a5f8d087f6c3ff4d93e might change the behavior on getExternalIpAddress

Salvora

comment created time in 11 days

startedbrouberol/marcel

started time in 13 days

issue commentminiupnp/miniupnp

pypi missing binary for windows

Only you have permission to publish into your repo https://pypi.org/project/miniupnpc/ "The user 'me' isn't allowed to upload to project 'miniupnpc'."

That is not my repo. I have no account on pypi.org. You should contact the listed maintainers.

mrx23dot

comment created time in 14 days

pull request commentRocketChat/Rocket.Chat

[FIX] import of avatar from LDAP when ;binary is used in attribute name

This PR has been made deprecated by 26db22bc7ab44be1eb7c9a05492b0b7adbdd70b0

see #23369

miniupnp

comment created time in 14 days

PR opened RocketChat/Rocket.Chat

[FIX] LDAP: uses thumbnailPhoto;binary and jpegPhoto;binary

In some LDAP directories, the jpegPhoto or thumbnailPhoto may have an additional ";binary" option. This is valid LDAP : https://tools.ietf.org/html/rfc2251#section-4.1.5.1

This patch adds support for this case.

see previous PR #17099

<!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->

<!-- Your Pull Request name should start with one of the following tags [NEW] For new features [IMPROVE] For an improvement (performance or little improvements) in existing features [FIX] For bug fixes that affect the end-user [BREAK] For pull requests including breaking changes Chore: For small tasks Doc: For documentation -->

<!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
  • I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules -->

Proposed changes (including videos or screenshots)

<!-- CHANGELOG --> In some LDAP directories, the jpegPhoto or thumbnailPhoto may have an additional ";binary" option. This is valid LDAP : https://tools.ietf.org/html/rfc2251#section-4.1.5.1

This patch adds support for this case.

<!-- END CHANGELOG -->

Issue(s)

<!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->

Steps to test or reproduce

<!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->

Further comments

<!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->

+8 -0

0 comment

1 changed file

pr created time in 14 days

create barnchminiupnp/Rocket.Chat

branch : jpegPhoto-binary-new

created branch time in 14 days

push eventminiupnp/Rocket.Chat

Diego Sampaio

commit sha f7700514e50287179b4a93f4eb76747dce83ac47

Merge branch 'master' into develop

view details

Robot LingoHub

commit sha 9389ae8d6d39b134613ef8d19b8bbb3f2e301704

Language update from LingoHub 🤖 Project Name: Rocket.Chat Project Link: https://translate.lingohub.com/rocketchat/dashboard/rocket-dot-chat User: Robot LingoHub Easy language translations with LingoHub 🚀

view details

Diego Sampaio

commit sha b98103c19955b8d5de7d00c1a43786e32b0bf59e

Fix variables

view details

Felipe Cecagno

commit sha d40fa74b44cb21dbf6616a22f31e0d17beb3cb0a

[FIX] Iframe flags for audio and video on the BigBlueButton integration (#20879) Fix iframe flags that prevent audio and video to be shared in a session

view details

Diego Sampaio

commit sha 791002413f803765d4d6a8613b18ee0bc9d373a3

[FIX] Add missing `unreads` field to `users.info` REST endpoint (#20905)

view details

yash-rajpal

commit sha cfab6c20fdae64d844ccac7227cc8ea328c8b6ae

[FIX] Stopping Jitsi reload (#20973) * removing dep from useMemo * Avoid missing dep in useMemo Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>

view details

yash-rajpal

commit sha b37feea7f91328abf13ef12c0e56f4054c6cda71

[IMPROVE] Close Call contextual bar after starting Jitsi call (#21004) Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>

view details

Martin Schoeler

commit sha e802fa59ce48fdee93a5ef56136b076acb213d87

[IMPROVE] Better new channel popover (#21018) * [IMPROVE] Better new channel popover * better naming * better export * Separate create room list item

view details

Douglas Fabris

commit sha 3901dcec3c17de6293014ad9d1fb28aded170d4f

[FIX] Missing spaces on attachment (#21020)

view details

yash-rajpal

commit sha 1cf3dd88ad044c33ce4fdf256d0a3a151343c42a

[FIX] Stopping Jitsi reload (#20973) * removing dep from useMemo * Avoid missing dep in useMemo Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>

view details

yash-rajpal

commit sha 1b47ebbb6f1c29fcd18dc256b2769901cb175081

[IMPROVE] Close Call contextual bar after starting Jitsi call (#21004) Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>

view details

Douglas Fabris

commit sha 08767c441b4e78b2f0066dd339409a91f78e5e6a

[FIX] Missing spaces on attachment (#21020)

view details

Diego Sampaio

commit sha f2817c056f9c063dd5f596446ef2e6c61634233b

Bump version to 3.12.1

view details

Kevin Aleman

commit sha 31552ca0093cbff518c29e3a8d1236fe564b9a2c

Chore: Remove `new Buffer` in favor of `Buffer.from` (#20918)

view details

Daniel Martinez

commit sha 26c79d37598967f9d3496c14d69deda733de4430

Chore: Add tests for Meteor methods (#20901)

view details

Diego Sampaio

commit sha 73ea7a1124cd5346c51205db3d0770a57e76eb4c

Add AWS region to CI

view details

Kevin Aleman

commit sha 04c008e8828785ee22e875229d7dc3d22ff7c67b

Improve: Increase testing coverage (#21015)

view details

Diego Sampaio

commit sha 978cd3a845b01a164e5b9fd7b82ad41d9a3ef4c8

Chore: Meteor update 2.1 (#21061)

view details

Martin Schoeler

commit sha 0298910e9dfa4093ab44403e5c23914b8c620af3

[FIX] Use the correct icons for DMs (#21125) * [FIX] Use the correct icons for DMs * Prefer `balloon` icon over `message` icon Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>

view details

Tiago Evangelista Pinto

commit sha 9611e2b62fe18aed88c732f2c20c9a16baff0e16

[FIX] Unexpected open or close visitor info (#21094) * fix unexpected open or close visitor info * fix lgtm bot warning Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat> Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat> Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com>

view details

push time in 14 days

issue commentminiupnp/miniupnp

pypi missing binary for windows

Only you have access to the appveyor

??? you mean the appveyor script ? https://github.com/miniupnp/miniupnp/blob/master/appveyor.yml

mrx23dot

comment created time in 14 days

issue closedminiupnp/miniupnp

pypi missing binary for windows

Please add pre-compiled binary for windows x64/x32 to pypi. Compiling on every client PC is impractical by pip installation.

closed time in 14 days

mrx23dot

issue commentminiupnp/miniupnp

pypi missing binary for windows

I'm neither a python developer, nor a Windows developer, so I'm not able to help you.

I'm accepting any Pull Request, but there have been a lot of people complaining the lack of precompiled python packages, and only a few offering help to build one.

mrx23dot

comment created time in 14 days

issue commentminiupnp/miniupnp

pypi missing binary for windows

@mrx23dot aren't packages available on https://ci.appveyor.com/project/miniupnp/miniupnp OK ? if not, why ?

mrx23dot

comment created time in 15 days

push eventminiupnp/miniupnp

Thomas Bernard

commit sha a933c76be4a697cc7edb7098756fcc5ff44a6891

Makefile.linux: fix install dependencies

view details

Thomas Bernard

commit sha 7634920f3cc79229638eb60fc97c4a1015e695a5

Makefile.linux_nft: fix DEPFLAGS and make install

view details

push time in 19 days

push eventminiupnp/miniupnp

Thomas Bernard

commit sha 5eecb80cd233114045b4164a1253cc81fdd625cf

minissdpd/Makefile: use DESTDIR / PREFIX in make install make it consistent with miniupnpc Makefile

view details

push time in 19 days

PR merged miniupnp/miniupnp

miniupnpc/CMakeLists.txt: fix install for headers miniupnpc

Install target fails as include files have moved

"build/miniupnpc-2.2.3/miniupnpc.h":
  No such file or directory.
FAILED: CMakeFiles/install.util 
cd build/miniupnpc-2.2.3/.x86_64-libreelec-linux-gnu && toolchain/bin/cmake -P cmake_install.cmake
ninja: build stopped: subcommand failed.
+10 -10

1 comment

1 changed file

heitbaum

pr closed time in 19 days

push eventminiupnp/miniupnp

heitbaum

commit sha f82b0563a72e33800f5918ead68c41bcda1fd4c1

miniupnpc/CMakeLists.txt: fix install for headers

view details

Thomas Bernard

commit sha edb8f84d57edd110f55df4bcd44f442dea090625

.gitlab-ci.yml: rename jobs to shorter names

view details

Thomas Bernard

commit sha b7186a76a0f891c31327b2ed3d262e4b8665ed49

.gitlab-ci.yml: test make install

view details

Thomas Bernard

commit sha c5e08bed57ede2f581ca27757eaea31feed76f94

github workflows: test make install

view details

push time in 19 days

pull request commentminiupnp/miniupnp

miniupnpc/CMakeLists.txt: fix install for headers

thank you

heitbaum

comment created time in 19 days

push eventminiupnp/miniupnp

Thomas Bernard

commit sha 8c243bde8343ff6f390c96dec395e629c4c9a0c1

.gitlab-ci: one before_script per job

view details

Thomas Bernard

commit sha a2c9bc29cb49029889ff43bfd1423f98e25e03b8

gitlab-ci.yml: iptables-dev => libip4tc-dev libip6tc-dev libiptc-dev libxtables-dev also add iproute2

view details

Thomas Bernard

commit sha 3f35ce505ed2a645ea435dbd08d114a4dfdf2c53

.gitlab-ci.yml: split miniupnpd job in two add " || exit 1" to each line

view details

push time in 20 days

push eventminiupnp/miniupnp

Thomas Bernard

commit sha 5d315359aa1a6bc7b253656094685575cb6c31ee

gitrev.mk: use gitlab-ci predefined variables

view details

Thomas Bernard

commit sha dc82d25cb1dc2575eb67c48a3929c2fd400817b4

Makefile.mingw: use CI_COMMIT_SHORT_SHA from gitlab-ci

view details

Thomas Bernard

commit sha c88178650e2551226a88cbc87084014781f81184

replace 'which' with 'command -v'

view details

Thomas Bernard

commit sha 6e16650bc28444e81c35bf2cbed7738f1a7fabf4

miniupnpd/configure: fix comparaison [ "$IPTABLES_143" -eq 1 ] doesn't work if $ITABLES_143 is empty using instead : [ "$IPTABLES_143" = "1" ]

view details

Thomas Bernard

commit sha d2f558f659da923144f591be418380a7ff8a8677

configure: use 'command -v' instead of 'which'

view details

Thomas Bernard

commit sha 881ba06bc192e53d6cfd3fbd449b68a452f07422

configure: warning when no libiptc pkg-config found

view details

push time in 20 days

PR merged miniupnp/miniupnp

Makefile: fix install rules to account for $(BUILD) miniupnpc

Fix missing references to $(BUILD) in the install rules, as well as incorrect shared library symlink name. Otherwise, the 'install' phase fails either being unable to find files:

make: *** No rule to make target 'miniupnpc.pc', needed by 'install'.  Stop.

or trying to create the symlink in the wrong subdirectory:

ln: failed to create symbolic link '/tmp/z/usr/lib/build/libminiupnpc.so': No such file or directory
+5 -5

1 comment

1 changed file

mgorny

pr closed time in 20 days

push eventminiupnp/miniupnp

Michał Górny

commit sha ed1dc4bb5cdc4a53963f3eb01089289e30acc5a3

Makefile: fix install rules to account for $(BUILD) Fix missing references to $(BUILD) in the install rules, as well as incorrect shared library symlink name. Otherwise, the 'install' phase fails either being unable to find files: make: *** No rule to make target 'miniupnpc.pc', needed by 'install'. Stop. or trying to create the symlink in the wrong subdirectory: ln: failed to create symbolic link '/tmp/z/usr/lib/build/libminiupnpc.so': No such file or directory

view details

push time in 20 days

pull request commentminiupnp/miniupnp

Makefile: fix install rules to account for $(BUILD)

@mgorny thank you !

mgorny

comment created time in 20 days

push eventminiupnp/miniupnp

Thomas Bernard

commit sha 36a65e3d841d4e85904fed690c0b755d5b380043

miniupnpc/Changelog.txt: VERSION 2.2.3

view details

push time in 21 days