profile
viewpoint
Microsoft microsoft Redmond, WA https://opensource.microsoft.com Open source, from Microsoft with love

issue closedmicrosoft/ApplicationInsights-aspnetcore

cloud_roleName Telemetry intializer declarative method not working as documented

I have been following this article for adding cloud_RoleName to my web-app (https://github.com/MicrosoftDocs/azure-docs/blob/master/articles/azure-monitor/app/app-map.md#net), I just tried this with a very simple ASP.net web-app. I created a class library for telemetry and referenced it with my Web-App and made sure Instrumentation Key is used. Now when I initialize the custom TELEMETRY class programmatically i.e. (Microsoft.ApplicationInsights.Extensibility.TelemetryConfiguration.Active.TelemetryInitializers.Add(new ExtendedIDTelemetryInitializer())) .. It works very well and no issues at all. Telemetry gets sent to my Azure App Insights Resource with my custom CLOUD_ROLENAME but samething if I try to add it declaratively i.e. adding the INITIALIZE code to ApplicationInsights.config file, it DOESNT WORK :( nothing is reported with my CUSTOM cloud_RoleName to Azure App insights, any help with this? I want to go the DECLARATIVE route instead of programmatic as I need to send this code to a third party product and they cant make changes to the STARTUP event to add it. Not sure why DECLRATIVE is Not working any help? my ApplicationInsights.config file looks like this . Any help? tried searching but doesn't help

closed time in 2 hours

ketaanhshah

issue commentmicrosoft/ApplicationInsights-aspnetcore

cloud_roleName Telemetry intializer declarative method not working as documented

I think it's mentioned in here: https://github.com/microsoft/ApplicationInsights-aspnetcore/issues/505 Closing as it is a duplicate feature request for this repo

ketaanhshah

comment created time in 2 hours

issue commentmicrosoft/TypeScript

Combine reducers with intersected type of unions causes tsc to crash

https://github.com/rebyul/tsmemalloc

Sorry this took so long, I had a deadline due last week and had to chug through without typing my reducers.

The linked repository isn't able to replicate the OOM issue that I am having, and I am unable to invest more time into creating a bigger project to trigger an OOM exception. It is somewhat close to how I have my reducers set up (multiple base level reducers with some nested reducers. The tsc diagnostics looks like this:

Files: 93 Lines: 66899 Nodes: 191573 Identifiers: 62754 Symbols: 99624 Types: 814246 Memory used: 856780K I/O read: 0.04s I/O write: 0.00s Parse time: 0.65s Bind time: 0.42s Check time: 14.61s Emit time: 0.00s Total time: 15.68s

I could feel the intellisense getting significantly slower after adding the IFormState interface with reference to the Formik library. I apologize for the lack of information I have provided.

You've got an intersection listed up there, not a union? Is that intentional?

I apologize, it is an intersection; I would have thought it should be a union but the combineReducers function gives compilation errors if its changed to a union.

Also, on my repo that is having the OOM issues, running tsc --diagnostics has the followering values:

Files: 6299 Lines: 164873 Nodes: NaN Identifiers: NaN Symbols: 417223 Types: 234298 Memory used: 592309K I/O read: 0.79s I/O write: 0.26s Parse time: 5.78s Bind time: 1.29s Check time: 18.34s Emit time: 2.44s Total time: 27.85s

There is a related issue on DefinitelyTyped https://github.com/DefinitelyTyped/DefinitelyTyped/issues/35514 which seems to be having similar issues.

rebyul

comment created time in 2 hours

issue openedmicrosoft/wil

WI_AreAllFlagsSet doesn't compile for C++/WinRT defined enum flags

If you want to deal with C++/WinRT's projected enum flags and using WI_AreAllFlagsSet, it doesn't compile. The reason is C++/WinRT defines its enum operator in global namespace but enum is defined in their own namespace. So ADL doesn't work, then WIL have several enum operators (for its own type) in wil::details or wil namespaces so it doesn't go hunting for global namespace.

The fix from WIL side would be stopping relying on enum operator and just cast it to underlying integral type, using WI_EnumValue, just like WI_IsAnyFlagSet does

created time in 2 hours

push eventmicrosoft/data-accelerator

Vijay Upadya

commit sha 53dd7ace44cb7964e5717bb6aca9065434e1124f

Maven artifacts for 1.1.0-SNAPSHOT

view details

push time in 2 hours

issue openedmicrosoft/ApplicationInsights-aspnetcore

cloud_roleName Telemetry intializer declarative method not working as documented

I have been following this article for adding cloud_RoleName to my web-app (https://github.com/MicrosoftDocs/azure-docs/blob/master/articles/azure-monitor/app/app-map.md#net), I just tried this with a very simple ASP.net web-app. I created a class library for telemetry and referenced it with my Web-App and made sure Instrumentation Key is used. Now when I initialize the custom TELEMETRY class programmatically i.e. (Microsoft.ApplicationInsights.Extensibility.TelemetryConfiguration.Active.TelemetryInitializers.Add(new ExtendedIDTelemetryInitializer())) .. It works very well and no issues at all. Telemetry gets sent to my Azure App Insights Resource with my custom CLOUD_ROLENAME but samething if I try to add it declaratively i.e. adding the INITIALIZE code to ApplicationInsights.config file, it DOESNT WORK :( nothing is reported with my CUSTOM cloud_RoleName to Azure App insights, any help with this? I want to go the DECLARATIVE route instead of programmatic as I need to send this code to a third party product and they cant make changes to the STARTUP event to add it. Not sure why DECLRATIVE is Not working any help? my ApplicationInsights.config file looks like this . Any help? tried searching but doesn't help

created time in 2 hours

startedmicrosoft/terminal

started time in 2 hours

startedmicrosoft/azure-pipelines-agent

started time in 2 hours

issue commentmicrosoft/vscode

Support environment variables when resolving values in settings

Is there a technical reason to keep this on hold for so long (I mean, besides prioritization)? Some arguments stated above:

  1. It was decided that some kind of name resolving feature was outside the scope of the configuration module which should always return the "truth", so a new service was created for that. But people are asking to resolve names in a consistent manner across different configuration sections in their settings files. It's not a question about architecture, it's a question about function. That answer sounds to me like "please go complain to the Resolving Service department". It's ok if you decided to have that department, but it's inconsequential for the question raised.

  2. The sync vs async argument. I don't think this is relevant, I'd say that nobody here would dare to ask for settings to be interactively entered while vscode is launching. It was suggested to leave interactive variables outside the scope of settings files, which is a very sensible position.

Besides that I'm unable to find another argument against introducing variables into settings files. Now, imagine someone opened a PR adding this functionality, imagine the code were acceptable, would it be rejected because 1 or 2 or another reason I'm honesty having a hard time to figure out, since this FR seems everything but unreasonable. Someone asked for a story: most of my dotfiles are full of ~/whatever paths, this is so common in Unix world that the request for a story for something like ${home}/whatever disconcerts me.

Don't mean to be harsh, just to understand you reasons.

OlsonDev

comment created time in 2 hours

startedmicrosoft/AttackSurfaceAnalyzer

started time in 2 hours

push eventmicrosoft/ApplicationInsights-dotnet

Liudmila Molkova

commit sha 5ff7b2220b6573cff06f5fe156734aabb37184f4

and make netstandard1.1 happy

view details

push time in 2 hours

startedmicrosoft/terminal

started time in 2 hours

startedmicrosoft/vscode-remote-release

started time in 2 hours

issue commentmicrosoft/vscode-remote-release

Can't connect to xxx: unreachable or not Linux x86_64

So you get the prompt "please enter your password:", then you enter the correct password, then it fails with the error message you showed? That's strange.

Can you share the full log from the "Remote - SSH" output channel?

Hi Roblourens, thanks for your reply! Might I ask how I can get the full log?

475651582

comment created time in 2 hours

startedmicrosoft/cpprestsdk

started time in 2 hours

fork Aulover/human-pose-estimation.pytorch

The project is an official implement of our ECCV2018 paper "Simple Baselines for Human Pose Estimation and Tracking(https://arxiv.org/abs/1804.06208)"

fork in 2 hours

startedmicrosoft/terminal

started time in 2 hours

startedmicrosoft/mssql-jdbc

started time in 2 hours

startedmicrosoft/Windows-universal-samples

started time in 2 hours

issue openedmicrosoft/azuredatastudio

Notebooks: Unable to edit another notebook when one is running.

Issue Type: <b>Bug</b>

Run cells in a notebook and try to open another notebook and edit a cell. It'll not let you edit.

Azure Data Studio version: azuredatastudio 1.7.0 (e1280022d69b651cfff04b30e830904575c8acda, 2019-05-08T00:55:40.928Z) OS version: Windows_NT x64 10.0.17763

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 x 3408)
GPU Status 2d_canvas: enabled<br>checker_imaging: disabled_off<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>native_gpu_memory_buffers: disabled_software<br>rasterization: enabled<br>surface_synchronization: enabled_on<br>video_decode: enabled<br>webgl: enabled<br>webgl2: enabled
Load (avg) undefined
Memory (System) 63.92GB (45.98GB free)
Process Argv C:\Users\makoripa.REDMOND\Desktop\HERO001 - Create AKS cluster and deploy BDC 3.ipynb
Screen Reader no
VM 0%

</details>Extensions: none <!-- generated by issue reporter -->

created time in 2 hours

issue commentmicrosoft/Partner-Smart-Office

No Reply Address is registered for the application

Is it possible to force it to https after it's been deployed? or will that require a redeploy?

ntaylor0909

comment created time in 2 hours

startedmicrosoft/wil

started time in 2 hours

startedmicrosoft/PowerToys

started time in 2 hours

startedmicrosoft/terminal

started time in 2 hours

startedmicrosoft/vscode

started time in 2 hours

startedmicrosoft/TypeScript

started time in 2 hours

issue commentmicrosoft/TypeScript

Support some non-structural (nominal) type matching

@eliseumds in fact, like it was demonstrated in https://github.com/microsoft/TypeScript/issues/364#issuecomment-355623349, TypeScript is flexible enough to let you define your own algebra for your own types and operations whatever they are (measured numbers that we are talking about here is just an example)

iislucas

comment created time in 2 hours

push eventmicrosoft/bond

Christopher Warrington

commit sha 62da781cb2e267c2ab34db5d561b615b568146c5

Use new `az acr repository delete --image` syntax (#976) The old syntax for deleting by a manifest no longer works with newer versions of the az CLI tool. This switches to the newer `--image repository@manifest` syntax.

view details

push time in 2 hours

PR merged microsoft/bond

Use new `az acr repository delete --image` syntax

The old syntax for deleting by a manifest no longer works with newer versions of the az CLI tool. This switches to the newer --image repository@manifest syntax.

This should fix the image cleanup job failures that we've been seeing.

+3 -3

0 comment

1 changed file

chwarr

pr closed time in 2 hours

startedmicrosoft/Deep3DFaceReconstruction

started time in 2 hours

PR opened microsoft/ChakraCore

Allow SAFE_RUN to correctly run and check results

Hi, I came across this shell function in test/native-tests/test_native.sh:

SAFE_RUN() {
    local SF_RETURN_VALUE=$($1 2>&1)

    if [[ $? != 0 ]]; then
        >&2 echo $SF_RETURN_VALUE
        exit 1
    fi
}

invoked as e.g.

SAFE_RUN `cd $TEST_PATH; ${CH_DIR} Platform.js > Makefile`

There are multiple issues that prevent it from living up to its name:

  1. The code to run is executed by the backticks before the function ever starts:
$ test_run() { true; }
$ test_run `ls /doesnotexist`
ls: cannot access '/doesnotexist': No such file or directory
  1. If the invocation is changed to pass the command directly, the invocation fails for metacharacters like ; and >. Here they are both treated as literal text:
$ test_run() { local var=$($1 >&2); echo "$var"; }
$ test_run "echo Hello; ls > filelist"
Hello; ls > filelist
  1. If passed a valid invocation, local masks all exit codes and returns success, even when the command fails:
$ test_run() { local foo=$($1); echo  "$1 returned $?"; }
$ test_run true
true returned 0
$ test_run false
false returned 0

The suggested commits fixes all these issues.

I was unable to verify the fix locally as the tests appeared to hang when run overnight with and without these fixes. I'm not quite sure how they're used, but there is some possibility that this commit uncovers failures that were previously hidden.

+8 -7

0 comment

1 changed file

pr created time in 2 hours

pull request commentmicrosoft/fhir-server

Updates package 'Microsoft.Extensions.Diagnostics.HealthChecks' to version '2.2.5'

@namadabu can you take a look at this update?

MicrosoftHealthService

comment created time in 2 hours

issue commentmicrosoft/Partner-Smart-Office

No Reply Address is registered for the application

Good catch, I will update the template in the future to force HTTPS. Glad you got it working!

Isaiah Williams


From: Trafalger1 notifications@github.com Sent: Monday, May 20, 2019 9:18:35 PM To: microsoft/Partner-Smart-Office Cc: Isaiah Williams; Mention Subject: Re: [microsoft/Partner-Smart-Office] No Reply Address is registered for the application (#77)

it worked...the redirect URL needed to be http NOT https:

i am in now i need to set it up for my CSP....

thank you for the help. I wonder why this isn't https tho..but at least for now I can test it out.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FPartner-Smart-Office%2Fissues%2F77%3Femail_source%3Dnotifications%26email_token%3DAFBHBXLZFKGVR4D6DSZIDOLPWNLXXA5CNFSM4HNRHV2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV2RWTY%23issuecomment-494213967&data=02|01||692474ffe316421c276e08d6dd92a146|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636940019165873820&sdata=zNoHs04fSGcNqT7DIV%2Fh2eviLjKxQPB9mObBnoQcT%2Fw%3D&reserved=0, or mute the threadhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBHBXIC5GELRQD5VFQLRCLPWNLXXANCNFSM4HNRHV2A&data=02|01||692474ffe316421c276e08d6dd92a146|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636940019165883831&sdata=D8qNaPoVo8dRu%2FrnMoOavG5lLDcSt1rwh4V4RwNG%2BWU%3D&reserved=0.

ntaylor0909

comment created time in 2 hours

Pull request review commentmicrosoft/data-accelerator

Add kafka input support for data processing

 object CommonProcessorFactory {         batchLog.warn(s"End batch ${batchTime}, output partition time:${outputPartitionTime}, namespace:${namespace}")          metrics ++ result-      } // end of processPaths+      }, // end of processPaths+      /*+      process a batch of ConsumerRecords from kafka+     */+      processConsumerRecord = (rdd: RDD[ConsumerRecord[String,String]], batchTime: Timestamp, batchInterval: Duration, outputPartitionTime: Timestamp) =>{+        processDataset(rdd+          .map(d=>{+            val value = d.value()+            if(value==null) throw new EngineException(s"null bytes from ConsumerRecord")+            //Capture key if present. Key can be null.+            val key = if(d.key!=null) Some("key"->d.key.toString) else None+            (+              value,+              Map.empty[String, String],// Properties+              Map[String, String](+                "offset"->d.offset().toString,+                "partition"->d.partition().toString,+                "serializedKeySize"->d.serializedKeySize().toString,+                "serializedValueSize"->d.serializedValueSize().toString,+                "timestamp"->d.timestamp().toString,+                "timestampType"->d.timestampType().toString,+                "topic"->d.topic()+              ) ++ key,+              FileInternal())+          })+          .toDF(+            ColumnName.RawObjectColumn,+            "Properties",+            "SystemProperties",

Updated

vijayupadya

comment created time in 2 hours

startedmicrosoft/TypeScript-React-Starter

started time in 2 hours

push eventmicrosoft/data-accelerator

Vijay Upadya

commit sha 5777940611abeba5e64e6e9a5d89b1aefd59f5d0

Define constants and convert return null to throwing exception.

view details

push time in 2 hours

issue commentmicrosoft/Partner-Smart-Office

No Reply Address is registered for the application

it worked...the redirect URL needed to be http NOT https:

i am in now i need to set it up for my CSP....

thank you for the help. I wonder why this isn't https tho..but at least for now I can test it out.

ntaylor0909

comment created time in 2 hours

Pull request review commentmicrosoft/knack

Command/Argument Preview Mechanism

 def execute(self, args):             del deprecate_kwargs['_get_message']             deprecations.append(ImplicitDeprecated(**deprecate_kwargs)) +        # TODO: search for implicit preview?

I see the class name below, so I'm guessing you mean differentiating behavior. However, I'm still not sure what would make something implicitly a preview. :)

tjprescott

comment created time in 2 hours

Pull request review commentmicrosoft/knack

Command/Argument Preview Mechanism

+# --------------------------------------------------------------------------------------------+# Copyright (c) Microsoft Corporation. All rights reserved.+# Licensed under the MIT License. See License.txt in the project root for license information.+# --------------------------------------------------------------------------------------------++from six import string_types as STRING_TYPES++from .util import ColorizedString++_PREVIEW_TAG = '[Preview]'

nit: my vote would be for lowercase on this, but it's a weak opinion.

tjprescott

comment created time in 2 hours

Pull request review commentmicrosoft/knack

Command/Argument Preview Mechanism

 def execute(self, args):             del deprecate_kwargs['_get_message']             deprecations.append(ImplicitDeprecated(**deprecate_kwargs)) +        # TODO: search for implicit preview?

Please clarify a little, what may constitute an implicit preview?

tjprescott

comment created time in 2 hours

push eventmicrosoft/fhir-server

John Stairs

commit sha bebc575c7f6d79ef12a86f8145a6eb54fb4886e0

Adds indexing for composite search parameters (#474)

view details

Brendan Kowitz

commit sha 4dfd356277d17161880e0bfd4dfb0e974e63efe4

Merge remote-tracking branch 'origin/master' into personal/bkowitz/r4-datalayer

view details

push time in 2 hours

fork buhongw7583c/azuredevopslabs

Learn how you can plan smartly, collaborate better, and ship faster with a set of modern development services with Azure DevOps.

https://www.azuredevopslabs.com

fork in 2 hours

startedmicrosoft/azuredevopslabs

started time in 2 hours

startedmicrosoft/terminal

started time in 2 hours

issue commentmicrosoft/Partner-Smart-Office

No Reply Address is registered for the application

Interesting ...

redirect_uri=http%3A%2F%2Fmyurlapp.azurewebsites.net%2Fsignin-oidc

ntaylor0909

comment created time in 2 hours

Pull request review commentmicrosoft/pai

Huibinb/webportal/metrics graph add from and to parameters

 import qs from 'querystring';  import {checkToken} from '../../../../user/user-auth/user-auth.component'; import config from '../../../../config/webportal.config';+// import {getDurationString, getHumanizedJobStateString} from "./util";

Remove if you don't need it anymore.

bweb2018

comment created time in 2 hours

Pull request review commentmicrosoft/pai

Huibinb/webportal/metrics graph add from and to parameters

 export async function fetchSshInfo() {   } } -export function getJobMetricsUrl() {-  return `${config.grafanaUri}/dashboard/db/joblevelmetrics?var-job=${namespace ? `${namespace}~${jobName}`: jobName}`;+export function getJobMetricsUrl(getHumanizedJobStateString , jobInfo) {+  let from = jobInfo.jobStatus.createdTime;+  let to = '';+  let status = getHumanizedJobStateString(jobInfo);

Same, use const for status.

bweb2018

comment created time in 2 hours

Pull request review commentmicrosoft/pai

Huibinb/webportal/metrics graph add from and to parameters

 export async function fetchSshInfo() {   } } -export function getJobMetricsUrl() {-  return `${config.grafanaUri}/dashboard/db/joblevelmetrics?var-job=${namespace ? `${namespace}~${jobName}`: jobName}`;+export function getJobMetricsUrl(getHumanizedJobStateString , jobInfo) {+  let from = jobInfo.jobStatus.createdTime;

Use const if you won't modify from.

bweb2018

comment created time in 2 hours

Pull request review commentmicrosoft/pai

Huibinb/webportal/metrics graph add from and to parameters

+{

Remove package-lock file.

bweb2018

comment created time in 3 hours

fork anjcGit/terminal

The new Windows Terminal, and the original Windows console host -- all in the same place!

fork in 2 hours

startedmicrosoft/vscode

started time in 2 hours

startedmicrosoft/terminal

started time in 2 hours

startedmicrosoft/terminal

started time in 2 hours

startedmicrosoft/recommenders

started time in 2 hours

startedmicrosoft/PowerToys

started time in 2 hours

fork 62theories/LightGBM

A fast, distributed, high performance gradient boosting (GBDT, GBRT, GBM or MART) framework based on decision tree algorithms, used for ranking, classification and many other machine learning tasks. It is under the umbrella of the DMTK(http://github.com/microsoft/dmtk) project of Microsoft.

fork in 2 hours

startedmicrosoft/terminal

started time in 2 hours

startedmicrosoft/human-pose-estimation.pytorch

started time in 2 hours

issue commentmicrosoft/Partner-Smart-Office

No Reply Address is registered for the application

Thank you for sharing that, you are getting a different error than what ntaylor0909 reported. The original error stated a reply URL was not present. Your error is because of mismatch. Since the expected value is not working, the quickest solution would be browse to your site. When you are redirect to the login.microsoftonline.com page, do not enter your credentials. Instead copy the address into Notepad, then extract the redirect_url value from the address. It will be URL encoded, that value decoded is what the reply URL should be.

In my environment it is https://partnertest.azurewebsites.net/signin-oidc. So, it will be interesting to see what you find.

Isaiah Williams


From: Trafalger1 notifications@github.com Sent: Monday, May 20, 2019 9:04 PM To: microsoft/Partner-Smart-Office Cc: Isaiah Williams; Mention Subject: Re: [microsoft/Partner-Smart-Office] No Reply Address is registered for the application (#77)

[image]https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F50831827%2F58063196-3399ec80-7b4b-11e9-8ae0-fca657368e28.png&data=02|01||6749a8358afa409973d908d6dd90a214|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636940010589064886&sdata=ENGuZlKn2BxielGrVvtZTpT7RNrTID9sgapdNe3DZfM%3D&reserved=0

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FPartner-Smart-Office%2Fissues%2F77%3Femail_source%3Dnotifications%26email_token%3DAFBHBXNCXGOZJZ3HIYFC7MLPWNKCDA5CNFSM4HNRHV2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV2RC4Q%23issuecomment-494211442&data=02|01||6749a8358afa409973d908d6dd90a214|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636940010589074897&sdata=2PteuD4DqlgWBojp6Yy04A8knwHfMYC8TXZZrCVvPRA%3D&reserved=0, or mute the threadhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBHBXMKTDA3JKUGNQCWBELPWNKCDANCNFSM4HNRHV2A&data=02|01||6749a8358afa409973d908d6dd90a214|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636940010589084902&sdata=PGD2%2Bb5H8UF4Pi%2FO%2B67gzzS4UHKGENSfuDMbCwqPajg%3D&reserved=0.

ntaylor0909

comment created time in 2 hours

issue commentmicrosoft/vscode-cpptools

The data type\identifier is both defined and undefined;

My project is embedded and has a large number of files. Unfortunately its commercial so its not easy to share the project. Anything I can do to help debug?

NikolaiTour

comment created time in 2 hours

startedmicrosoft/terminal

started time in 2 hours

startedmicrosoft/LightGBM

started time in 2 hours

pull request commentmicrosoft/knack

Command/Argument Preview Mechanism

Just out of curiosity, how easy would it be to tack on a hidden option? I'd love to have self-test stop telling me that it was going to be deleted soon if it's easy.

tjprescott

comment created time in 2 hours

startedmicrosoft/react-native-windows

started time in 2 hours

push eventmicrosoft/recommenders

bethz

commit sha 988ed9a4465fc8bf129616aa5bb613aee4d8790d

add Bill B.s items to delete

view details

push time in 2 hours

startedmicrosoft/terminal

started time in 3 hours

startedmicrosoft/tslib

started time in 3 hours

Pull request review commentmicrosoft/fhir-server

Removes Stu3 references from CosmosDb provider

 public sealed class ListedCapabilityStatement         public IList<ListedRestComponent> Rest { get; set; }          public IList<Code<PublicationStatus>> StatusElement { get; set; }++        public void TryAddRestInteraction(string resourceType, string value)+        {+            EnsureArg.IsNotNullOrEmpty(value, nameof(value));+            EnsureArg.IsTrue(Enum.TryParse<ResourceType>(resourceType, out var resource), nameof(resourceType));++            var interaction = value.GetValueByEnumLiteral<TypeRestfulInteraction>();++            this.TryAddRestInteraction(resource, interaction);+        }++        public void TryAddRestInteraction(string interaction)

systemInteraction

brendankowitz

comment created time in 3 hours

issue commentmicrosoft/vscode-java-debug

Wrong classpath at runtime when the maven project is in a folder

i tried to clone these two sample projects into a parent folder dmn-insurance, and open it in VS Code, there are many unresolved maven dependencies org.kie.x.

btw, it may be better to use a parent pom.xml to manage the modules when you open a parent folder with multiple maven projects in VS Code.

dmarrazzo

comment created time in 3 hours

issue commentmicrosoft/vscode-cpptools

The data type\identifier is both defined and undefined;

Yeah, I'm still not able to repro this issue. @michelleangela @Colengms Are any of you guys able to repro this? I was able to repro this a few months ago.

NikolaiTour

comment created time in 3 hours

Pull request review commentmicrosoft/ptvsd

Fix #1413: Stop on entry hangs the debugger

 # Licensed under the MIT License. See LICENSE in the project root # for license information. -import sys- import ptvsd.log-from ptvsd._local import run_module, run_file, run_main---# TODO: not needed?-DONT_DEBUG = []+import ptvsd.options+from ptvsd.__main__ import run_file, run_module, run_code -LOCALHOST = 'localhost'  RUNNERS = {-    'module': run_module,  # python -m spam-    'script': run_file,  # python spam.py-    'code': run_file,  # python -c 'print("spam")'-    None: run_file,  # catchall+    'module': run_module,+    'script': run_file,+    'code': run_code, } +# Not actually used, but VS will try to add entries to it.+DONT_DEBUG = [] -def debug(filename, port_num, debug_id, debug_options, run_as,-          _runners=RUNNERS, _extra=None, *args, **kwargs): +# A legacy entrypoint for Visual Studio, to allow older versions to work with new ptvsd.+# All new code should use the entrypoints in __main__ directly.+def debug(filename, port_num, debug_id, debug_options, run_as):     ptvsd.log.to_file()     ptvsd.log.info('debug{0!r}', (filename, port_num, debug_id, debug_options, run_as)) -    if _extra is None:-        _extra = sys.argv[1:]-    address = (LOCALHOST, port_num)     try:-        run = _runners[run_as]+        run = RUNNERS[run_as]     except KeyError:-        # TODO: fail?-        run = _runners[None]-    if _extra:-        args = _extra + list(args)-    kwargs.setdefault('singlesession', True)-    run(address, filename, *args, **kwargs)+        raise ValueError('run_as must be one of: {0!r}'.format(tuple(RUNNERS.keys()))) +    ptvsd.options.target_kind = 'file' if run_as == 'script' else run_as+    ptvsd.options.target = filename+    ptvsd.options.port = port_num+    ptvsd.options.client = True -def run(filename, port_num, run_as,-        *args, **kwargs):+    # debug_id is ignored because it has no meaning in DAP.+    # debug_options are ignored, because they will be passed later via DAP "launch" request. -    ptvsd.log.to_file()-    ptvsd.log.info('run{0!r}', (filename, port_num, run_as))+    run() -    address = (LOCALHOST, port_num)-    run_main(address, filename, run_as, *args, **kwargs)+# A legacy entrypoint for Visual Studio, to allow older versions to work with new ptvsd.+# All new code should use the entrypoints in __main__ directly.+#def run(filename, port_num, run_as):

I think it's not needed - can't find anywhere VS uses it. But I wanted to have a commit with the new version of it, so that if we find out later it was needed, it can be easily restored.

int19h

comment created time in 3 hours

startedmicrosoft/terminal

started time in 3 hours

fork jimersylee/terminal

The new Windows Terminal, and the original Windows console host -- all in the same place!

fork in 3 hours

startedmicrosoft/terminal

started time in 3 hours

pull request commentmicrosoft/pai

Huibinb/webportal/metrics graph add from and to parameters

Please sign the CLA first then fix lint errors.

bweb2018

comment created time in 3 hours

issue commentmicrosoft/TypeScript

Support some non-structural (nominal) type matching

Another interesting example of the benefit of nominal types (date.toDateString() vs date.toISOString()): https://twitter.com/WrocTypeScript/status/1032385714015559680

iislucas

comment created time in 3 hours

startedmicrosoft/TypeScript-Handbook

started time in 3 hours

PR closed microsoft/ApplicationInsights-dotnet

Reviewers
Server telemetry channel tests: downgrade AspNetCore to 2.0 to be compatible with netcoreapp2.0 target

SDL build complains about package version mismatch

Errors in D:\a\1\s\Test\ServerTelemetryChannel.Test\NetCore20.Tests\TelemetryChannel.netcoreapp20.Tests.csproj
    Package Microsoft.AspNetCore.Hosting 2.2.0 is not compatible with netcoreapp2.0 (.NETCoreApp,Version=v2.0). Package Microsoft.AspNetCore.Hosting 2.2.0 supports: netstandard2.0 (.NETStandard,Version=v2.0)
    Package Microsoft.AspNetCore.Hosting.Abstractions 2.2.0 is not compatible with netcoreapp2.0 (.NETCoreApp,Version=v2.0). Package Microsoft.AspNetCore.Hosting.Abstractions 2.2.0 supports: netstandard2.0 (.NETStandard,Version=v2.0)
    Package Microsoft.Extensions.DependencyInjection.Abstractions 2.2.0 is not compatible with netcoreapp2.0 (.NETCoreApp,Version=v2.0). Package Microsoft.Extensions.DependencyInjection.Abstractions 2.2.0 supports: netstandard2.0 (.NETStandard,Version=v2.0)
    Package Microsoft.AspNetCore.Server.Kestrel 2.2.0 is not compatible with netcoreapp2.0 (.NETCoreApp,Version=v2.0). Package Microsoft.AspNetCore.Server.Kestrel 2.2.0 supports: netstandard2.0 (.NETStandard,Version=v2.0)
    One or more packages are incompatible with .NETCoreApp,Version=v2.0.

https://mseng.visualstudio.com/AppInsights/_build/results?buildId=9520686&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b

fixing asp.net core version to match netcoreapp2.0

+5 -5

1 comment

1 changed file

lmolkova

pr closed time in 3 hours

delete branch microsoft/openenclave

delete branch : vsix-edge-modules

delete time in 3 hours

push eventmicrosoft/openenclave

Dave Thaler

commit sha 5ab7ef99fa151913ee8d1516447117fe02cf821f

Make VSExtension work for edge modules (#1806) * Make VSExtension work for edge modules Edge module projects only have x86 not Win32 platform by default Also, the VcpkgConfiguration property is needed to commpile any configuration other than 'Debug' and 'Release'

view details

push time in 3 hours

PR merged microsoft/openenclave

Reviewers
Make VSExtension work for edge modules trustzone

Edge module projects only have x64 not Win32 platform by default. Also, the VcpkgConfiguration property is needed to compile any configuration other than 'Debug' and 'Release'.

Signed-off-by: Dave Thaler dthaler@ntdev.microsoft.com

+35 -1

0 comment

1 changed file

dthaler

pr closed time in 3 hours

startedmicrosoft/MMdnn

started time in 3 hours

startedmicrosoft/terminal

started time in 3 hours

fork MingMingShi/terminal

The new Windows Terminal, and the original Windows console host -- all in the same place!

fork in 3 hours

startedmicrosoft/terminal

started time in 3 hours

issue commentmicrosoft/terminal

Render `tig` correctly

Wow, this was a terrible bug report. Here are some details: Windows: 10.0.18898 Build 18898 Terminal: 0.1.1361.0 Powershell Core: 6.2.0

I'm able to print some emojis: image

decriptor

comment created time in 3 hours

startedmicrosoft/terminal

started time in 3 hours

startedmicrosoft/SPTAG

started time in 3 hours

startedmicrosoft/PTVS

started time in 3 hours

issue commentmicrosoft/TypeScript

Support some non-structural (nominal) type matching

it's granted, nominals are broader than units of measure

nominals are a good thing where they apply, and there are a lot of use cases for them

but when it comes to numbers, instead of plain nominals you'd rather use units of measure

reasons are:

  • the only things nominals can do is to add a distinction to otherwise identical types
  • units of measure, on the other hand, can make certain sets of numbers distinct from other set of number AND give you a mechanism of conversion from one set to another

and this is what numbers are for and this is what they do

describing a problem with nominals is a poor choice when you can do it with units of measure WHEN IT COMES TO NUMBERS

iislucas

comment created time in 3 hours

issue commentmicrosoft/Partner-Smart-Office

No Reply Address is registered for the application

no joy @isaiahwilliams

ntaylor0909

comment created time in 3 hours

issue commentmicrosoft/pai

Worker node disappears without any error report.

@mzmssg What is the correct log path in the local filesystem?

GeoffreyChen777

comment created time in 3 hours

Pull request review commentmicrosoft/uf2-samdx1

pybadge and pygamer fixes; new boards; improved splashscreen display; merge from upstream

 void draw_drag() {     drawBar(52, 55, 8);     drawBar(107, 14, 4); -    print4(108, 5, 1, "D5");-    print(112, 40, 6, UF2_VERSION_BASE);+    // Center PRODUCT_NAME and UF2_VERSION_BASE.

OK, now I see what was going on with the print4 text writing. I thought I was fixing some casual centering code, but didn't know about the STM32 logos and bootloaders. I see that the BrainPad and the Meowbit both use "ARCADE-F4", and it's hardwired in their bootloaders.

Since our boards are multi-purpose, calling them "ARCADE-something" makes for some confusion for other uses. Would it be possible to get the boot drive name from the config data or somewhere like that? Then could this general message be made more specific when you download something? The written doc would also have to be made a little more general.

image

I do want to get our sources in sync as much as possible.

dhalbert

comment created time in 3 hours

startedmicrosoft/pxt-maker

started time in 3 hours

startedmicrosoft/TypeScript

started time in 3 hours

startedmicrosoft/PowerToys

started time in 3 hours

more