profile
viewpoint
Microsoft microsoft Redmond, WA https://opensource.microsoft.com Open source, from Microsoft with love

startedmicrosoft/DirectX-Specs

started time in a minute

issue openedmicrosoft/vscode-azure-iot-edge

Calling Direct Method issue with the auto-generated code on VSCode

This issue was filed incorrectly under https://github.com/Azure/azure-iot-sdk-csharp Moving it to the correct repository on behalf of @SONENU Original issue: https://github.com/Azure/azure-iot-sdk-csharp/issues/980


<!-- Hi there! thank you for discovering and submitting an issue!

Please use your Azure subscription if you need to share any information from your Azure subscription such as connection strings, service names (IoTHub, Provisioning), etc.

Need Support?

  • Have a feature request for SDKs? Please post it on User Voice to help us prioritize.
  • Have a technical question? Ask on Stack Overflow with tag “azure-iot-hub”
  • Need Support? Every customer with an active Azure subscription has access to support with guaranteed response time. Consider submitting a ticket and get assistance from Microsoft support team
  • Found a bug? Please help us fix it by thoroughly documenting it and filing an issue on GitHub (C, Java, .NET, Node.js, Python). -->
  • OS, version, SKU and CPU architecture used: <VERSION> <!-- Windows 10 Desktop x64, Ubuntu 15.04 x86, Windows 10 IoT Core arm32, etc. -->
  • Application's .NET Target Framework : <NETVERSION> <!-- See https://docs.microsoft.com/en-us/dotnet/standard/frameworks. E.g. netcoreapp2.1, net451, uap10.0, xamarin -->
  • Device: <DEVICETYPE> <!-- Laptop, Raspberry PI3, Android APIv25 etc. -->
  • SDK version used: <VERSION> <!-- Please include the NuGet package version for all involved components. -->

Description of the issue:

<!-- Please be as detailed as possible: which feature has a problem, how often does it fail, repro steps, etc. --> [Calling Direct Method Issue] After several days of investigation and effort. I've found that when I am implementing IoT Edge Module by command-line in VSCode, calling Direct Method failed with an auto-generated code as below on VSCode. I had to change the code the other way to make it run properly. What they are different and what's MS's opinion.

The environment we use currently and see some similar issues below. IoT Edge version 1.0.7.1: https://github.com/Azure/azure-iotedge/releases • Fixes ObjectDisposedException (that we've seen also in our logs so it might be good to update the deployments to this version already)

IoT SDK C# version 1.20.2: https://github.com/Azure/azure-iot-sdk-csharp/releases • It's probably better to have the SDK updated to the latest release and start fixing the version instead of using 1.* which automatically uses the latest version at build time, which means we are not in control of the version we will get during the build.

Github reported issues similar to what we're seeing: • Issue #551: https://github.com/Azure/azure-iot-sdk-csharp/issues/571 • Issue #646: https://github.com/Azure/iotedge/issues/646

Code sample exhibiting the issue:

<!-- Please remove any connection string or other private information! Consider adding a link to a https://gist.github.com/ simple repro. -->

class Program { static async Task Main(string[] args) {

        // Wait until the app unloads or is cancelled
        var cts = new CancellationTokenSource();
        AssemblyLoadContext.Default.Unloading += (ctx) => cts.Cancel();
        Console.CancelKeyPress += (sender, cpe) => cts.Cancel();
        //WhenCancelled(cts.Token).Wait();//Auto generated code when creating new module
        await WhenCancelled(cts.Token);//Success with this code
    }

Console log of the issue:

<!-- Please share logs as possible, that will help debugging. --> <!-- See https://github.com/Azure/azure-iot-sdk-csharp/tree/master/tools/CaptureLogs and https://github.com/dotnet/corefx/blob/master/Documentation/debugging/windows-instructions.md#traces -->

[DirectMethod] Failed to invoke Direct Method: Error: {"Message":"{"errorCode":504101,"trackingId":"8fb95f15eb734f5d92c292dc5fc29e17-G:19-TimeStamp:06/18/2019 10:07:22-G:11-TimeStamp:06/18/2019 10:07:22","message":"Timed out waiting for the response from device.","info":{},"timestampUtc":"2019-06-18T10:07:22.3918499Z"}","ExceptionMessage":""}

created time in a minute

issue commentmicrosoft/vscode-python

Add telemetry to determine if multiple files are used in the interactive window.

Of course we could always have a setting to allow a single or multiple to be used.

rchiodo

comment created time in a minute

PR merged microsoft/vscode

Recommend WSL when using wsl.exe as shell

Recommend Remote WSL when using wsl.exe as shell.

Can be discussed if we need to generalise this. But we already have Remote WSL knowledge e.g. in our windows code.sh script.

+56 -6

0 comment

4 changed files

aeschli

pr closed time in a minute

issue commentmicrosoft/vscode-postgresql

Persist password in a persistent store

PostgreSQL clients that are based upon libpq also lookup passwords from the pgpass file. Maybe its possible to lookup if passwords are defined at this location? https://www.postgresql.org/docs/current/libpq-pgpass.html

akamath46297

comment created time in a minute

push eventmicrosoft/WebTemplateStudio

ali-kha

commit sha 375a17ccf0c8648bb9a60f8865b1c64cfe1515c5

removed changes

view details

push time in a minute

startedmicrosoft/TailwindTraders

started time in a minute

Pull request review commentmicrosoft/terminal

Accessibility: Finalized Shared UIA Tree Model

 class RenderData final : public Microsoft::Console::Render::IRenderData     const bool IsGridLineDrawingAllowed() noexcept override;
 
     std::vector<Microsoft::Console::Types::Viewport> GetSelectionRects() noexcept override;
+    bool IsAreaSelected() const override;
+    void ClearSelection() override;

Yeah that's what I was thinking, but I'm also thinking that I'm tired of not shipping 0.3 because of accessibility so I'd rather have something work NOW and let him shuffle the functions around between 0.3 and 0.4 in a TODO.

carlos-zamora

comment created time in a minute

issue commentmicrosoft/vscode

Add DiagnosticTag.Deprecated

@jrieken I would be interested in helping out here with this and perhaps even #50972.

Without a lot of context, I assume this issue is specifically to add a new enum member here:

https://github.com/microsoft/vscode/blob/03e13189e7518414fbbad5324908fe3eeb572eae/src/vs/vscode.d.ts#L4274

I could open a PR that adds a Deprecated member, if that's the case.

KamasamaK

comment created time in 2 minutes

issue commentmicrosoft/vscode-python

Add telemetry to determine if multiple files are used in the interactive window.

The telemetry is not to determine if people would want separate state or not, it's whether or not we're going to mess up people who don't. How many people will be pissed if a run cell on a new file opens a new jupyter kernel.

rchiodo

comment created time in 2 minutes

issue closedmicrosoft/botframework-solutions

Provide a strategy for code owners of the various components in this repository

Currently the whole Bot Framework Solutions team is named code owners for the entire repository. This makes it difficult to keep track of the various changes throughout and ensure they are following the correct strategy rather than being approved simply because. Instead, we should dole out responsibilities for each team member on what components they should be the final gatekeeper of.

  • Solutions
  • Templates
  • Deployment scripts
  • Libraries
  • Docs

closed time in 2 minutes

ryanlengel

issue commentmicrosoft/AzureStorageExplorer

Updates are anoyingly frequent, please add background updating

Just curious, how often is an acceptable update frequency to you? We currently release updates approximately every two months, reduced from a monthly update frequency. Thanks.

popcatalin81

comment created time in 2 minutes

issue commentmicrosoft/azure-pipelines-agent

Hosted agent "lost communication with the server"

@alepauly Windows seems fine, I haven't seen one recently. I still see a lot of macOS failures. Nearly all my builds fail because at least one of the macOS jobs looses connection. Could someone figure out a cause for this?

letmaik

comment created time in 2 minutes

Pull request review commentmicrosoft/sqltoolsservice

Adding completion extension loading and execution logic

 public void InitializeService(ServiceHost serviceHost, SqlToolsContext context)          #region Request Handlers +        /// <summary>+        /// Completion extension load request callback+        /// </summary>+        /// <param name="param"></param>+        /// <param name="requestContext"></param>+        /// <returns></returns>+        internal async Task HandleCompletionExtLoadRequest(CompletionExtensionParams param, RequestContext<bool> requestContext)+        {+            try+            {+                var serviceProvider = ExtensionServiceProvider.Create(new Assembly[] { AssemblyLoadContext.Default.LoadFromAssemblyPath(param.Assembly) });

Actually I would like to use ServiceHostInstance.ServiceProvider, what's the API to add a new assembly? Create is a static API.

shengyfu

comment created time in 2 minutes

pull request commentmicrosoft/terminal

Added Escape Key to CharacterHandler so it can be handled instead of returned.

I agree with this! Let us merge #1974 first!

pi1024e

comment created time in 2 minutes

Pull request review commentmicrosoft/terminal

Accessibility: Finalized Shared UIA Tree Model

 void Terminal::SetBoxSelection(const bool isEnabled) noexcept 
 // Method Description:
 // - clear selection data and disable rendering it
-void Terminal::ClearSelection() noexcept
+void Terminal::ClearSelection()

nah leave it here given that you're planning on making a second pass at these verbs and such anyway in a TODO

carlos-zamora

comment created time in 2 minutes

PR opened microsoft/TypeScript

Handle scoped package names in typing installer

Fixes #32075

+114 -56

0 comment

4 changed files

pr created time in 2 minutes

issue openedmicrosoft/terminal

Feature Request

<!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨

I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:

  1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
  2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
  3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
  4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
  5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.

All good? Then proceed! -->

Summary of the new feature/enhancement

Several times a user may need a administrator cmd window for doing some task. But the current terminal design doesn't allow it. This terminal is beneficial for using multiple command line tools easily. If the new administrator tab is opened in the current window then it will help user to keep all the command tools in the same window.

Proposed technical implementation details (optional)

The proposed idea would allow user to access super user cmd/powershell/wsl shell easily. It can implemented in following ways,

  1. A right click on current tab allowing user to open admin window in new tab.
  2. A right click on the option in the dropdown list allow user to launch the prompt in administrator mode.
  3. A icon alongside the name in the dropdown list to launch list item in administrator mode.

If the new administrator tab is opened in the current window then it will help user to keep all the command tools in the same window.

created time in 2 minutes

PullRequestEvent

PR closed microsoft/ApplicationInsights-dotnet-logging

Reviewers
nupkg and symbols

https://github.com/microsoft/ApplicationInsights-Home/issues/370

+104 -116

0 comment

10 changed files

MS-TimothyMothra

pr closed time in 2 minutes

create barnchmicrosoft/TypeScript

branch : scopedPackageAquisition

created branch time in 2 minutes

issue closedmicrosoft/WSL

oh-my-zsh on WSL2 has unstable launching speed

  • Your Windows build number:
    10.0.18922.1000

  • What you're doing and what's happening: Installed oh-my-zsh, the launch speed of an Ubuntu terminal becomes unstable.

  • What's wrong / what should be happening instead: So after I upgrade Ubuntu instance to WSL-2, I found the launch speed of oh-my-zsh became even worse -- around 5 seconds.

Other options I have tried include install a new instance, launching zsh without oh-my-zsh.

With a new instance, launch speed was good (likely 1~2 seconds) at the beginning, but after one day of normal PC use (no heavy WSL use), it became slower and slower (around 5 seconds).

Launching zsh without oh-my-zsh is always as good as bash without any configurations.

Does this mean there is some bottleneck for reading all the configuration and resource files for oh-my-zsh?

  • Strace of the failing command, if applicable: (If some_command is failing, then run strace -o some_command.strace -f some_command some_args, and link the contents of some_command.strace in a gist here).

Not sure what to get, but I'll try when I got time.

EDIT: After one day I reinstalled oh-my-zsh, it took around 3s to load everything. I added a line in .zshrc so it can print timestamps while zsh is loading

setopt prompt_subst; zmodload zsh/datetime; PS4='+[$EPOCHREALTIME]%N:%i> '; set -x

So when I installed oh-my-zsh, I printed out the log and save it to a file named fast_log.txt, then I turned the printing off by commenting the line above in .zshrc. Today, when I found it got slow, I turn the printing on and grabbed the log three times when I tried to launch zsh three times. I saved them into slow_log.txt, slow_log_2.txt and slow_log_3.txt.

I also write a little script to compare fast and slow logs, it turned out there are a few steps in the slow log that take >0.1s more than those steps in the fast log.

They are:

8 0.1414494514465332 0.0013909339904785156 0.14284038543701172 /home/michaelht/.oh-my-zsh/oh-my-zsh.sh:13> [ '' '!=' true ']'
34 0.5684547424316406 0.046172142028808594 0.6146268844604492 handle_completion_insecurities:13> insecure_dirs=( )
276 0.2090909481048584 0.0011241436004638672 0.21021509170532227 grep-flag-available:1> echo
1456 0.35894012451171875 0.0007147789001464844 0.35965490341186523 /home/michaelht/.oh-my-zsh/lib/theme-and-appearance.zsh:32> ((  1  ))

The first column is a line number in fast_log.txt, second column is the time difference between fast_log and slow_log, third and forth are fast latency and slow latency for that step, last column is the traced step.

zsh logs are here: https://gist.github.com/MichaelTong/5626016120be35c250a2c1e0fdd7b449

closed time in 2 minutes

MichaelTong

issue commentmicrosoft/WSL

oh-my-zsh on WSL2 has unstable launching speed

After I upgrade to 18936 last week, this issue doesn't seem to happen again. I'll close this issue for now.

MichaelTong

comment created time in 2 minutes

issue commentmicrosoft/vscode

Some extensions are not loaded correctly when VS Code is launched from WSL

I'm seeing this for the Azure extensions with this in the log

image

There are quite a few errors fetching icons.

MichaelTong

comment created time in 2 minutes

issue commentmicrosoft/vscode-azureappservice

choose-repository

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

Ladiesoftheweb

comment created time in 2 minutes

issue closedmicrosoft/vscode-azureappservice

choose-repository

<!-- IMPORTANT: Please be sure to remove any private information before submitting. -->

Repro steps: <!-- TODO: Enter steps to reproduce issue -->

Action: appService.Deploy Error type: Conflict Error Message: There was a conflict. AlwaysOn cannot be set for this site as the plan does not allow it.

Version: 0.15.0 OS: win32 Product: Visual Studio Code - Insiders Product Version: 1.36.0-insider Language: en

<details> <summary>Call Stack</summary>

module.exports.Ts.l.pipeline extension.bundle.js:262:2544801
s extension.bundle.js:262:112563
s extension.bundle.js:157:26036
extension.bundle.js:157:27276extension.bundle.js:157:27276
o extension.bundle.js:208:7054
extension.bundle.js:157:24957extension.bundle.js:157:24957
$.module.exports.t.requestLibrarySink.t.headersOnly.t.streamedResponse.t.body.function.t.body.pipe.a [as _callback] extension.bundle.js:1:534414
$.module.exports.$.init.t._callback.t.callback.t.callback extension.bundle.js:238:5461
$.emit events.js:182:13
$.<anonymous> extension.bundle.js:238:18274
$.emit events.js:187:15
IncomingMessage.<anonymous> extension.bundle.js:238:17116
Object.onceWrapper events.js:273:13
IncomingMessage.emit events.js:187:15
endReadableNT _stream_readable.js:1092:12
process._tickCallback next_tick.js:63:19

</details>

closed time in 2 minutes

Ladiesoftheweb

Pull request review commentmicrosoft/terminal

Accessibility: Finalized Shared UIA Tree Model

 namespace Microsoft::Console::Interactivity::Win32         // then both endpoints will contain the same value.
         bool _degenerate;
 
-        static const Microsoft::Console::Types::Viewport& _getViewport();
-        static HWND _getWindowHandle();
-        static Microsoft::Console::Types::IConsoleWindow* const _getIConsoleWindow();
-        static SCREEN_INFORMATION& _getScreenInfo();
-        static TextBuffer& _getTextBuffer();
-        static const COORD _getScreenBufferCoords();
+        COORD _getScreenFontSize() const;
 
-        static const unsigned int _getTotalRows();
-        static const unsigned int _getRowWidth();
+        static const unsigned int _getTotalRows(Microsoft::Console::Render::IRenderData* pData);
+        static const unsigned int _getRowWidth(Microsoft::Console::Render::IRenderData* pData);
 
         static const unsigned int _getFirstScreenInfoRowIndex();
-        static const unsigned int _getLastScreenInfoRowIndex();
+        static const unsigned int _getLastScreenInfoRowIndex(Microsoft::Console::Render::IRenderData* pData);
 
         static const Column _getFirstColumnIndex();
-        static const Column _getLastColumnIndex();
+        static const Column _getLastColumnIndex(Microsoft::Console::Render::IRenderData* pData);
 
-        const unsigned int _rowCountInRange() const;
+        const unsigned int _rowCountInRange(Microsoft::Console::Render::IRenderData* pData) const;
 
-        static const TextBufferRow _endpointToTextBufferRow(const Endpoint endpoint);
-        static const ScreenInfoRow _textBufferRowToScreenInfoRow(const TextBufferRow row);
+        static const TextBufferRow _endpointToTextBufferRow(Microsoft::Console::Render::IRenderData* pData,
+                                                            const Endpoint endpoint);
+        static const ScreenInfoRow _textBufferRowToScreenInfoRow(Microsoft::Console::Render::IRenderData* pData,
+                                                                 const TextBufferRow row);
 
-        static const TextBufferRow _screenInfoRowToTextBufferRow(const ScreenInfoRow row);
-        static const Endpoint _textBufferRowToEndpoint(const TextBufferRow row);
+        static const TextBufferRow _screenInfoRowToTextBufferRow(Microsoft::Console::Render::IRenderData* pData,
+                                                                 const ScreenInfoRow row);
+        static const Endpoint _textBufferRowToEndpoint(Microsoft::Console::Render::IRenderData* pData, const TextBufferRow row);
 
-        static const ScreenInfoRow _endpointToScreenInfoRow(const Endpoint endpoint);
-        static const Endpoint _screenInfoRowToEndpoint(const ScreenInfoRow row);
+        static const ScreenInfoRow _endpointToScreenInfoRow(Microsoft::Console::Render::IRenderData* pData,
+                                                            const Endpoint endpoint);
+        static const Endpoint _screenInfoRowToEndpoint(Microsoft::Console::Render::IRenderData* pData,
+                                                       const ScreenInfoRow row);
 
-        static COORD _endpointToCoord(const Endpoint endpoint);
-        static Endpoint _coordToEndpoint(const COORD coord);
+        static COORD _endpointToCoord(Microsoft::Console::Render::IRenderData* pData,
+                                      const Endpoint endpoint);
+        static Endpoint _coordToEndpoint(Microsoft::Console::Render::IRenderData* pData,
+                                         const COORD coord);
 
-        static const Column _endpointToColumn(const Endpoint endpoint);
+        static const Column _endpointToColumn(Microsoft::Console::Render::IRenderData* pData,
+                                              const Endpoint endpoint);
 
-        static const Row _normalizeRow(const Row row);
+        static const Row _normalizeRow(Microsoft::Console::Render::IRenderData* pData, const Row row);
 
-        static const ViewportRow _screenInfoRowToViewportRow(const ScreenInfoRow row);
+        static const ViewportRow _screenInfoRowToViewportRow(Microsoft::Console::Render::IRenderData* pData,
+                                                             const ScreenInfoRow row);
         static const ViewportRow _screenInfoRowToViewportRow(const ScreenInfoRow row,
                                                              const SMALL_RECT viewport);
 
-        static const bool _isScreenInfoRowInViewport(const ScreenInfoRow row);
+        static const bool _isScreenInfoRowInViewport(Microsoft::Console::Render::IRenderData* pData,
+                                                     const ScreenInfoRow row);
         static const bool _isScreenInfoRowInViewport(const ScreenInfoRow row,
                                                      const SMALL_RECT viewport);
 
         static const unsigned int _getViewportHeight(const SMALL_RECT viewport);
         static const unsigned int _getViewportWidth(const SMALL_RECT viewport);
 
-        void _addScreenInfoRowBoundaries(const ScreenInfoRow screenInfoRow,
+        void _addScreenInfoRowBoundaries(Microsoft::Console::Render::IRenderData* pData,
+                                         const ScreenInfoRow screenInfoRow,
                                          _Inout_ std::vector<double>& coords) const;
 
-        static const int _compareScreenCoords(const ScreenInfoRow rowA,
+        static const int _compareScreenCoords(Microsoft::Console::Render::IRenderData* pData,
+                                              const ScreenInfoRow rowA,
                                               const Column colA,
                                               const ScreenInfoRow rowB,
                                               const Column colB);
 
-        static std::pair<Endpoint, Endpoint> _moveByCharacter(const int moveCount,
+        static std::pair<Endpoint, Endpoint> _moveByCharacter(Microsoft::Console::Render::IRenderData* pData,
+                                                              const int moveCount,
                                                               const MoveState moveState,
                                                               _Out_ int* const pAmountMoved);
 
-        static std::pair<Endpoint, Endpoint> _moveByCharacterForward(const int moveCount,
+        static std::pair<Endpoint, Endpoint> _moveByCharacterForward(Microsoft::Console::Render::IRenderData* pData,
+                                                                     const int moveCount,
                                                                      const MoveState moveState,
                                                                      _Out_ int* const pAmountMoved);
 
-        static std::pair<Endpoint, Endpoint> _moveByCharacterBackward(const int moveCount,
+        static std::pair<Endpoint, Endpoint> _moveByCharacterBackward(Microsoft::Console::Render::IRenderData* pData,
+                                                                      const int moveCount,
                                                                       const MoveState moveState,
                                                                       _Out_ int* const pAmountMoved);
 
-        static std::pair<Endpoint, Endpoint> _moveByLine(const int moveCount,
+        static std::pair<Endpoint, Endpoint> _moveByLine(Microsoft::Console::Render::IRenderData* pData,
+                                                         const int moveCount,
                                                          const MoveState moveState,
                                                          _Out_ int* const pAmountMoved);
 
-        static std::pair<Endpoint, Endpoint> _moveByDocument(const int moveCount,
+        static std::pair<Endpoint, Endpoint> _moveByDocument(Microsoft::Console::Render::IRenderData* pData,
+                                                             const int moveCount,
                                                              const MoveState moveState,
                                                              _Out_ int* const pAmountMoved);
 
         static std::tuple<Endpoint, Endpoint, bool>
-        _moveEndpointByUnitCharacter(const int moveCount,
+        _moveEndpointByUnitCharacter(Microsoft::Console::Render::IRenderData* pData,

Yeah, let's just take it as a follow-on exploration. I'm happy enough right now that this is something that is working.

carlos-zamora

comment created time in 3 minutes

Pull request review commentmicrosoft/terminal

Accessibility: Finalized Shared UIA Tree Model

 namespace Microsoft::Console::Render         virtual const bool IsGridLineDrawingAllowed() noexcept = 0;
 
         virtual std::vector<Microsoft::Console::Types::Viewport> GetSelectionRects() noexcept = 0;
+        virtual bool IsAreaSelected() const = 0;
+        virtual void ClearSelection() = 0;

Please just TODO it. I'd like to see it cleaned up but I am more desperate to see something working in this space.

carlos-zamora

comment created time in 3 minutes

Pull request review commentmicrosoft/vscode-docker

Create webhook on app service creation - based on the newer explorer

 export async function deployImageToAzure(context: IActionContext, node?: RemoteT      const site = nonNullProp(wizardContext, 'site');     const createdNewWebApp: string = `Successfully created web app "${site.name}": https://${site.defaultHostName}`;+    if (node instanceof AzureTagTreeItem) {+        let siteClient = new SiteClient(site, node.parent.parent.parent.root);+        let appUri: string = (await siteClient.getWebAppPublishCredential()).scmUri;+        await createWebhookForApp(node, wizardContext, appUri);+    } else if (node instanceof DockerHubTagTreeItem) {+        // point to dockerhub to create a webhook+        // http://cloud.docker.com/repository/docker/<registryName>/<repoName>/webHooks+        const dockerhubPrompt: string = "Copy web app endpoint and browse to dockerhub";

I'd follow this pattern: image

PrashanthCorp

comment created time in 3 minutes

issue openedmicrosoft/vscode-remote-release

feature request - allow me to open local file

Hi VSCode team,

My work involves working on code base on remote server but I have local txt files with tips and tricks. I want to be able to open both in single VSCode window. When I open a local file on window that is working on remote server, it simply opens new VSCode window rather than opening in same window.

This is undesirable behavior, I dont see the practicality of behavior and I am sure lots of developer who work on remote servers have local txt files with their own tips and tricks or commands saved.

I hope this will be fixed. By the way great work on this extenstion I was really looking for something like this for long time.

Thanks and Regards Naveen Rawat

created time in 3 minutes

delete branch microsoft/sarif-sdk

delete branch : users/lgolding/eslint-nits

delete time in 4 minutes

push eventmicrosoft/sarif-sdk

Larry Golding

commit sha 8a126c2c355415960b15466e2473130c79e86b25

Fix minor problems in ESLint formatter (#1573) - Bring `$schema` up to date. - Populate `result.ruleIndex` when metadata is available. - Populate `result.locations[i].physicalLocation.artifactLocation.index`. - Rule metadata `tags` should be `properties`. - The appropriate tool component URI here is `informationUri`, not `downloadUri`.

view details

push time in 4 minutes

PR merged microsoft/sarif-sdk

Reviewers
Fix minor problems in ESLint formatter
  • Bring $schema up to date.
  • Populate result.ruleIndex when metadata is available.
  • Populate result.locations[i].physicalLocation.artifactLocation.index.
  • Rule metadata tags should be properties.
  • The appropriate tool component URI here is informationUri, not downloadUri.
+147 -110

4 comments

4 changed files

lgolding

pr closed time in 4 minutes

issue commentmicrosoft/monaco-editor

Completion Suggestions are only available at start of a line.

@rcjsuen here is the project to created this issue. https://github.com/derau2/public

If you press CTRL-S at start of line intellisense works. If you type something prior to CTRL-S., such as "test " and then press CTRL-S you should receive "No suggestions" as in animated gif above

derau2

comment created time in 4 minutes

pull request commentmicrosoft/vcpkg

[minizip] Update CMakeLists.txt

This can produce inconsistencies. What if you install bzip2 on your own and then minizip? Minizip would catch bzip2 and enable the feature without your knowledge (and vcpkg’s). Then you could remove easily bzip2, leaving a broken minizip behind you. This feature requires a different approach imho

rknall

comment created time in 4 minutes

issue commentmicrosoft/TypeScript

Include module names in add-import fixIds

@amcasey is this fixed, then? Can the issue be closed?

amcasey

comment created time in 4 minutes

create barnchmicrosoft/ApplicationInsights-Java

branch : buildme/live-metrics-ikey

created branch time in 4 minutes

issue commentmicrosoft/AdaptiveCards

GIF support in images

Using this to be able to track everything in ProductBoard in one go. Will dup #2871 to this now.

productboard-ac

comment created time in 4 minutes

issue commentmicrosoft/dotnet

Application crashes in SerialStream.cs

We are using physical serial (COM port)

EK2017

comment created time in 5 minutes

issue commentmicrosoft/WinAppDriver

WinAppDriver fails to recognize the element visible in the Inspect.exe

The application is WinForms based.

I will try that and report back..

liannah

comment created time in 5 minutes

IssuesEvent

delete branch microsoft/uf2-linux

delete branch : 4p

delete time in 5 minutes

push eventmicrosoft/uf2-linux

Peli de Halleux

commit sha 2980c14ac63dca660cd9bfd0707bbf2fa0a41fb9

updated pinout to support 4 players (#4) * updated pinout to support 4 players * updated config testers

view details

push time in 5 minutes

PR merged microsoft/uf2-linux

updated pinout to support 4 players

Configured from https://github.com/microsoft/pxt-arcade/pull/1139

+29 -15

0 comment

2 changed files

pelikhan

pr closed time in 5 minutes

issue commentmicrosoft/onnxruntime

when built with flag --gen_doc, onnx and onnxruntime cannot be imported in the same python script

@shahasad can you please take a look? thanks.

xadupre

comment created time in 6 minutes

pull request commentmicrosoft/MixedRealityToolkit-Unity

Adding interactable diagrams.

Could you please add these diagrams somewhere in the Interactable's guide page? https://github.com/microsoft/MixedRealityToolkit-Unity/blob/mrtk_development/Documentation/README_Interactable.md

killerantz

comment created time in 6 minutes

startedmicrosoft/BusinessPlatformApps

started time in 6 minutes

PR opened microsoft/vscode-python

Reviewers
Cancel cells after an error is thrown.

For #6366

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • [x] Title summarizes what is changing
  • [x] Has a news entry file (remember to thank yourself!)
  • [ ] Appropriate comments and documentation strings in the code
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [x] Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.
+258 -92

0 comment

14 changed files

pr created time in 6 minutes

pull request commentmicrosoft/terminal

Added Escape Key to CharacterHandler so it can be handled instead of returned.

Agreed with the above. I don't want to take this on account of the fact that it's a grab bag of undiscussed things.

If it's updated/submitted with just the one concern at hand, I'm happy to review.

pi1024e

comment created time in 6 minutes

issue commentmicrosoft/dotnet

Application crashes in SerialStream.cs

Here are the stack traces: 0:022> !clrstack OS Thread Id: 0xbec (22) Child SP IP Call Site 1d36ed84 720c9ab5 [HelperMethodFrame: 1d36ed84] 1d36edf8 711977ba DomainNeutralILStubClass.IL_STUB_PInvoke(SECURITY_ATTRIBUTES, Boolean, Boolean, System.String) 1d36edfc 7114bb53 [InlinedCallFrame: 1d36edfc] Microsoft.Win32.Win32Native.CreateEvent(SECURITY_ATTRIBUTES, Boolean, Boolean, System.String) 1d36ee5c 7114bb53 System.Threading.EventWaitHandle..ctor(Boolean, System.Threading.EventResetMode, System.String) [f:\dd\ndp\clr\src\BCL\system\threading\eventwaithandle.cs @ 69] 1d36ee7c 7114baf4 System.Threading.ManualResetEvent..ctor(Boolean) [f:\dd\ndp\clr\src\BCL\system\threading\manualresetevent.cs @ 27] 1d36ee80 709f9a8b System.IO.Ports.SerialStream.BeginReadCore(Byte[], Int32, Int32, System.AsyncCallback, System.Object) [f:\dd\NDP\fx\src\sys\system\io\ports\SerialStream.cs @ 1437] 1d36eeac 709f940b System.IO.Ports.SerialStream.Read(Byte[], Int32, Int32, Int32) [f:\dd\NDP\fx\src\sys\system\io\ports\SerialStream.cs @ 1102] 1d36eed0 709f9397 System.IO.Ports.SerialStream.Read(Byte[], Int32, Int32) [f:\dd\NDP\fx\src\sys\system\io\ports\SerialStream.cs @ 1078] 1d36eee8 709f6cee System.IO.Ports.SerialPort.Read(Byte[], Int32, Int32) [f:\dd\NDP\fx\src\sys\system\io\ports\SerialPort.cs @ 890] 1d36ef0c 1aaab3e0 WSMBS.CTxRx.TxRxRTU(Byte[], Int32, Byte[], Int32) 1d36ef48 1aaab07e WSMBS.CTxRx.TxRx(Byte[], Int32, Byte[], Int32) 1d36ef68 1aaaaeea WSMBS.CModbus.ReadRegisters(Byte, UInt16, UInt16, UInt16, Int16[], Int32) 1d36efa0 1aaaada8 WSMBS.WSMBSControl.ReadHoldingRegisters(Byte, UInt16, UInt16, Int16[]) 1d36efb8 1aaaab8a ModbusLibrary.ModbusSerialCommunicator.ReadHoldingRegistersAsBytes(Byte, UInt16, UInt16) 1d36f048 1aaa9028 ModbusLibrary.ModbusDecoder.ReadSpecifiedTypes(ModbusLibrary.IModbusCommunicator, Byte, System.Collections.Generic.IEnumerable1, Boolean, System.Exception ByRef) 1d36f2d8 1aaa4577 ModbusLibrary.ModbusGenericDevice.QueryParameterGroup(System.Collections.Generic.IEnumerable1, Byte, Boolean) 1d36f3bc 1aaa3cd9 Device_Server.PPS.AbstractModbusDevice.QueryModbusParameters() 1d36f444 1aaa383e Device_Server.PPS.AbstractModbusDevice.timer_tick() 1d36f454 18e90a5e Device_Server.PPS.AbstractModbusDevice.threaded_timer_tick(System.Object) 1d36f46c 710d3e51 System.Threading.TimerQueueTimer.CallCallbackInContext(System.Object) [f:\dd\ndp\clr\src\BCL\system\threading\timer.cs @ 722] 1d36f470 7116bcd5 System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean) [f:\dd\ndp\clr\src\BCL\system\threading\executioncontext.cs @ 954] 1d36f4dc 7116bbe6 System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean) [f:\dd\ndp\clr\src\BCL\system\threading\executioncontext.cs @ 902] 1d36f4f0 710d3d57 System.Threading.TimerQueueTimer.CallCallback() [f:\dd\ndp\clr\src\BCL\system\threading\timer.cs @ 705] 1d36f524 710d3bde System.Threading.TimerQueueTimer.Fire() [f:\dd\ndp\clr\src\BCL\system\threading\timer.cs @ 662] 1d36f564 710d3e8a System.Threading.TimerQueue.FireQueuedTimerCompletion(System.Object) [f:\dd\ndp\clr\src\BCL\system\threading\timer.cs @ 436] 1d36f568 71149063 System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem() [f:\dd\ndp\clr\src\BCL\system\threading\threadpool.cs @ 1252] 1d36f57c 711487f2 System.Threading.ThreadPoolWorkQueue.Dispatch() [f:\dd\ndp\clr\src\BCL\system\threading\threadpool.cs @ 820] 1d36f5cc 7114865a System.Threading._ThreadPoolWaitCallback.PerformWaitCallback() [f:\dd\ndp\clr\src\BCL\system\threading\threadpool.cs @ 1161] 1d36f7f0 720beb16 [DebuggerU2MCatchHandlerFrame: 1d36f7f0]

0:022> !dumpstack OS Thread Id: 0xbec (22) Current frame: clr!ObjHeader::PassiveGetSyncBlock+0x1f ChildEBP RetAddr Caller, Callee 1d36ecb4 720c9aec clr!ObjHeader::GetSyncBlock+0x33, calling clr!ObjHeader::PassiveGetSyncBlock 1d36ece0 721f1c7a clr!WKS::GCHeap::Alloc+0x94, calling clr!WKS::CFinalize::RegisterForFinalization 1d36ed00 724045c6 clr!ObjHeader::SetAppDomainIndex+0x66, calling clr!ObjHeader::GetSyncBlock 1d36ed14 7210c546 clr!Object::SetAppDomain+0x26, calling clr!ObjHeader::SetAppDomainIndex 1d36ed24 7210c501 clr!AllocateObject+0xea, calling clr!Object::SetAppDomain 1d36ed60 720bf34f clr!HelperMethodFrame::Push+0x10, calling clr!GetThread 1d36ed68 720c7d95 clr!JIT_New+0x6b, calling clr!AllocateObject 1d36edb4 72179ab7 clr!DestroyAsyncPinningHandle+0x1b, calling clr!HndDestroyHandle 1d36edc8 720c7d65 clr!JIT_New+0x25, calling clr!LazyMachStateCaptureState 1d36edd4 72179b8a clr!FreeNativeOverlapped+0xc3, calling clr!_EH_epilog3 1d36edf0 711977ba (MethodDesc 70e0b3bc +0x66 DomainNeutralILStubClass.IL_STUB_PInvoke(SECURITY_ATTRIBUTES, Boolean, Boolean, System.String)), calling clr!JIT_New 1d36ee00 7111515b (MethodDesc 70ddfc54 +0x5b System.Collections.Concurrent.ConcurrentStack1[[System.__Canon, mscorlib]].Push(System.__Canon)), calling clr!COMInterlocked::CompareExchangeObject 1d36ee18 711045ee (MethodDesc 70eced28 +0x7e System.Threading.PinnableBufferCache.Free(System.Object)), calling (MethodDesc 70ddfc54 +0 System.Collections.Concurrent.ConcurrentStack1[[System.__Canon, mscorlib]].Push(System.__Canon)) 1d36ee4c 7114bb53 (MethodDesc 70df1d34 +0x53 System.Threading.EventWaitHandle..ctor(Boolean, System.Threading.EventResetMode, System.String)), calling 7103dec8 1d36ee6c 7114baf4 (MethodDesc 70df782c +0x14 System.Threading.ManualResetEvent..ctor(Boolean)), calling (MethodDesc 70df1d34 +0 System.Threading.EventWaitHandle..ctor(Boolean, System.Threading.EventResetMode, System.String)) 1d36ee78 709f9a8b (MethodDesc 703cc134 +0x4f System.IO.Ports.SerialStream.BeginReadCore(Byte[], Int32, Int32, System.AsyncCallback, System.Object)), calling 71043534 1d36ee94 709f940b (MethodDesc 703cc0ac +0x6b System.IO.Ports.SerialStream.Read(Byte[], Int32, Int32, Int32)), calling (MethodDesc 703cc134 +0 System.IO.Ports.SerialStream.BeginReadCore(Byte[], Int32, Int32, System.AsyncCallback, System.Object)) 1d36eebc 709f9397 (MethodDesc 703cc0a4 +0x23 System.IO.Ports.SerialStream.Read(Byte[], Int32, Int32)), calling (MethodDesc 703cc0ac +0 System.IO.Ports.SerialStream.Read(Byte[], Int32, Int32, Int32)) 1d36eed8 709f6cee (MethodDesc 703b019c +0xe6 System.IO.Ports.SerialPort.Read(Byte[], Int32, Int32)) 1d36eefc 1aaab3e0 (MethodDesc 1797e628 +0x318 WSMBS.CTxRx.TxRxRTU(Byte[], Int32, Byte[], Int32)), calling 704606fc 1d36ef34 1aaab07e (MethodDesc 1797e61c +0xb6 WSMBS.CTxRx.TxRx(Byte[], Int32, Byte[], Int32)), calling (MethodDesc 1797e628 +0 WSMBS.CTxRx.TxRxRTU(Byte[], Int32, Byte[], Int32)) 1d36ef54 1aaaaeea (MethodDesc 1797e6c4 +0x12a WSMBS.CModbus.ReadRegisters(Byte, UInt16, UInt16, UInt16, Int16[], Int32)), calling (MethodDesc 1797e61c +0 WSMBS.CTxRx.TxRx(Byte[], Int32, Byte[], Int32)) 1d36ef84 1aaaada8 (MethodDesc 1797df14 +0x28 WSMBS.WSMBSControl.ReadHoldingRegisters(Byte, UInt16, UInt16, Int16[])), calling (MethodDesc 1797e6c4 +0 WSMBS.CModbus.ReadRegisters(Byte, UInt16, UInt16, UInt16, Int16[], Int32)) 1d36efa4 1aaaab8a (MethodDesc 1797c2a4 +0xaa ModbusLibrary.ModbusSerialCommunicator.ReadHoldingRegistersAsBytes(Byte, UInt16, UInt16)), calling 1aaaa0a4 1d36f038 1aaa9028 (MethodDesc 19786654 +0x440 ModbusLibrary.ModbusDecoder.ReadSpecifiedTypes(ModbusLibrary.IModbusCommunicator, Byte, System.Collections.Generic.IEnumerable1<ModbusLibrary.ConfigurationMember>, Boolean, System.Exception ByRef)), calling 1979079a 1d36f2b4 1aaa7d9c (MethodDesc 19786eb8 +0x54 System.Linq.GroupedEnumerable3[[System.__Canon, mscorlib],[ModbusLibrary.ModbusGenericReadType, ModbusLibrary],[System.__Canon, mscorlib]].GetEnumerator()), calling (MethodDesc 19787d6c +0 System.Linq.Lookup2[[ModbusLibrary.ModbusGenericReadType, ModbusLibrary],[System.__Canon, mscorlib]].GetEnumerator()) 1d36f2c4 1aaa4577 (MethodDesc 1797c8bc +0x29f ModbusLibrary.ModbusGenericDevice.QueryParameterGroup(System.Collections.Generic.IEnumerable1<System.String>, Byte, Boolean)), calling (MethodDesc 19786654 +0 ModbusLibrary.ModbusDecoder.ReadSpecifiedTypes(ModbusLibrary.IModbusCommunicator, Byte, System.Collections.Generic.IEnumerable`1<ModbusLibrary.ConfigurationMember>, Boolean, System.Exception ByRef)) 1d36f3ac 1aaa3cd9 (MethodDesc 15cc04f4 +0xf9 Device_Server.PPS.AbstractModbusDevice.QueryModbusParameters()), calling 05029c86 1d36f43c 1aaa383e (MethodDesc 15cc04dc +0x86 Device_Server.PPS.AbstractModbusDevice.timer_tick()) 1d36f44c 18e90a5e (MethodDesc 15cc04c4 +0x8e Device_Server.PPS.AbstractModbusDevice.threaded_timer_tick(System.Object)), calling (MethodDesc 15cc04dc +0 Device_Server.PPS.AbstractModbusDevice.timer_tick()) 1d36f464 710d3e51 (MethodDesc 70ecf840 +0x31 System.Threading.TimerQueueTimer.CallCallbackInContext(System.Object)) 1d36f468 7116bcd5 (MethodDesc 70df1f14 +0xe5 System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)) 1d36f4cc 7116bbe6 (MethodDesc 70df1f08 +0x16 System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)), calling (MethodDesc 70df1f14 +0 System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)) 1d36f4e0 710d3d57 (MethodDesc 70de03b0 +0xa7 System.Threading.TimerQueueTimer.CallCallback()), calling (MethodDesc 70df1f08 +0 System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)) 1d36f51c 710d3bde (MethodDesc 70ecf828 +0xbe System.Threading.TimerQueueTimer.Fire()), calling (MethodDesc 70de03b0 +0 System.Threading.TimerQueueTimer.CallCallback()) 1d36f55c 710d3e8a (MethodDesc 70ecf900 +0x2a System.Threading.TimerQueue.FireQueuedTimerCompletion(System.Object)), calling (MethodDesc 70ecf828 +0 System.Threading.TimerQueueTimer.Fire()) 1d36f560 71149063 (MethodDesc 70de0330 +0x33 System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()) 1d36f574 711487f2 (MethodDesc 70ecf618 +0x192 System.Threading.ThreadPoolWorkQueue.Dispatch()), calling 05037562 1d36f5b4 710d3951 (MethodDesc 70de03c8 +0x21 System.Threading.TimerQueue.AppDomainTimerCallback()), calling (MethodDesc 70ecf8e8 +0 System.Threading.TimerQueue.FireNextTimers()) 1d36f5c4 7114865a (MethodDesc 70de0350 +0xa System.Threading._ThreadPoolWaitCallback.PerformWaitCallback()), calling (MethodDesc 70ecf618 +0 System.Threading.ThreadPoolWorkQueue.Dispatch()) 1d36f5c8 720beb16 clr!CallDescrWorkerInternal+0x34 1d36f5d4 720c6e84 clr!CallDescrWorkerWithHandler+0x6b, calling clr!CallDescrWorkerInternal 1d36f5e8 720c6e3d clr!CallDescrWorkerWithHandler+0x20, calling clr!_alloca_probe 1d36f628 720c82f4 clr!MethodDescCallSite::CallTargetWorker+0x16a, calling clr!CallDescrWorkerWithHandler 1d36f63c 720c8478 clr!ArgIteratorTemplate<ArgIteratorBase>::ComputeReturnFlags+0x1b, calling clr!MetaSig::GetReturnTypeNormalized 1d36f650 720c8284 clr!MethodDescCallSite::CallTargetWorker+0x87, calling clr!_alloca_probe_16 1d36f680 720c86f1 clr!MethodDescCallSite::MethodDescCallSite+0x50, calling clr!ArgIteratorTemplate<ArgIteratorBase>::ForceSigWalk 1d36f69c 72261273 clr!QueueUserWorkItemManagedCallback+0x23, calling clr!MethodDescCallSite::CallTargetWorker 1d36f71c 7225fdca clr!ManagedThreadBase_DispatchInner+0x71 1d36f730 7225fe34 clr!ManagedThreadBase_DispatchMiddle+0x7e, calling clr!ManagedThreadBase_DispatchInner 1d36f758 72260e76 clr!HillClimbing::Update+0x3a7, calling clr!HillClimbing::GetWaveComponent 1d36f78c 721ebc2b clr!HillClimbing::Update+0x783, calling clr!_ftol2_sse 1d36f7b8 720c1610 clr!Frame::Pop+0x8, calling clr!GetThread 1d36f7d4 7225ff01 clr!ManagedThreadBase_DispatchOuter+0x5b, calling clr!ManagedThreadBase_DispatchMiddle 1d36f804 7699ac89 KERNELBASE!WaitForSingleObjectEx+0x99, calling ntdll!NtWaitForSingleObject 1d36f830 7225ff6f clr!ManagedThreadBase_FullTransitionWithAD+0x2f, calling clr!ManagedThreadBase_DispatchOuter 1d36f854 72261201 clr!ManagedPerAppDomainTPCount::DispatchWorkItem+0x102, calling clr!ManagedThreadBase_FullTransitionWithAD 1d36f878 7226034d clr!CLRSemaphore::Wait+0xc0, calling KERNELBASE!WaitForSingleObjectEx 1d36f884 72260388 clr!CLRSemaphore::Wait+0x172, calling clr!_EH_epilog3 1d36f904 722602dd clr!ThreadpoolMgr::ExecuteWorkRequest+0x4f 1d36f91c 722600b9 clr!ThreadpoolMgr::WorkerThreadStart+0x3d3, calling clr!ThreadpoolMgr::ExecuteWorkRequest 1d36f94c 720c963b clr!EEHeapFree+0x3b, calling kernel32!HeapFreeStub 1d36f984 7210b601 clr!Thread::intermediateThreadProc+0x55 1d36fa14 7210b5e7 clr!Thread::intermediateThreadProc+0x3b, calling clr!_alloca_probe_16 1d36fa28 767f62c4 kernel32!BaseThreadInitThunk+0x24 1d36fa3c 77440609 ntdll!__RtlUserThreadStart+0x2f 1d36fa84 774405d4 ntdll!_RtlUserThreadStart+0x1b, calling ntdll!__RtlUserThreadStart

EK2017

comment created time in 6 minutes

issue closedmicrosoft/onnxruntime

Where can we find Windows debug symbols(pdb files) for released binaries

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

System information

  • ONNX Runtime version (you are using):

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

closed time in 7 minutes

ssgwos

startedmicrosoft/lain

started time in 7 minutes

issue commentmicrosoft/onnxruntime

Where can we find Windows debug symbols(pdb files) for released binaries

All our release builds are built with RelWithDebInfo and the pdb file is shipped with the packages (both nuget and zip packages). Nuget pkg can be found here https://www.nuget.org/packages/Microsoft.ML.OnnxRuntime/.

ssgwos

comment created time in 7 minutes

push eventmicrosoft/llvm-mctoll

Bharadwaj Yadavalli

commit sha eb71fedad2b19590ce08303f27ac96fce2d61929

[X86-64] Contributes support to raise a branch with the condition X86::COND_BE. [Test] Add assembly test source to verify the code.

view details

push time in 7 minutes

push eventmicrosoft/azuredatastudio

Ken Van Hyning

commit sha c6c3d92ae4275ac188f0e9090a0603d84874db3c

adding enum to azdata interface

view details

push time in 8 minutes

push eventmicrosoft/PowerStig

Jason Walker

commit sha 41586062b1d8de00c1c06e27414d24d450536f3c

Update test with function to filter stigData

view details

push time in 8 minutes

PR opened microsoft/vscode

Clear disposables in the clearInput method on Disposables

I saw this pull request on PR #75874, but not only has it not been merged, it has plenty of unresolved conflicts so I made a PR rebased on the most current version of the repository.

This Fixes #75532, and it clears the disposables during clearing text. The code has been refactored to allow this, as to prevent any issues or side effects from arising.

I hope this is useful!

+368 -378

0 comment

5 changed files

pr created time in 8 minutes

push eventmicrosoft/terminal

Steffen

commit sha fa5b9b06bd48fbcbea46019a98ca2945c97b2837

Fix for UTF-8 partials in function `ConhostConnection::_OutputThread`. (#1850) * Fix for UTF-8 partials in functions `ConhostConnection::_OutputThread` and `ApiRoutines::WriteConsoleOutputCharacterAImpl` The implementation needs to check whether or not the buffer ends with a partial character. If so, only convert the code points which are complete, and save the partial code units in a cache that gets prepended to the next chunk of text. * Utf8OutPipeReader class added * Unit Test added * use specific macros and WIL classes * avoid possible deadlock caused by unclosed pipe handle

view details

push time in 8 minutes

PR merged microsoft/terminal

Fix for UTF-8 partials in function `ConhostConnection::_OutputThread`.

<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->

Summary of the Pull Request

ConhostConnection::_OutputThread shall take care of partial UTF-8 characters generated while buffering the stream read.

<!-- Other than the issue solved, is this relevant to any other issues/existing PRs? -->

References

This PR may partially fix the occurrence of � characters as seen on screenshots in the following issues:
#386 #455 #666

<!-- Please review the items on the PR checklist before submitting-->

PR Checklist

  • [ ] Closes #xxx
  • [x] CLA signed. If not, go over here and sign the CLA
  • [x] Tests added/passed
  • [ ] Requires documentation to be updated
  • [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #386

<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->

Detailed Description of the Pull Request / Additional comments

Code points are represented by a sequence of 1 to 4 bytes in UTF-8. Whenever UTF-8 text is getting buffered, code points that consist of multiple bytes may get split at the buffer boundaries. The buffer gets converted into a string of wchar_t where those partials are invalid and make MultiByteToWideChar replacing them with U+FFFD characters. The implementation needs to check whether or not the buffer ends with a partial character. If so, only convert the code points which are complete, and save the partial code units in a cache that gets prepended to the next chunk of text.

Remark:
The PR includes the removal of the UTF-8 Byte Order Mark if it is present at the beginning of the stream read.

<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->

Validation Steps Performed

Corresponding file UTF8OutPipeReaderTests.cpp added to the Types.Unit.Tests project.

+325 -18

15 comments

7 changed files

german-one

pr closed time in 8 minutes

issue commentmicrosoft/vscode

I want the automated PHP tag opener

Hello there! I was showing open-source Atom text editor you to see how useful it is... Let try to decide which one is useful? Look at this screencast... bandicam2019-07-1621-11-26-930

alperendurmus

comment created time in 8 minutes

Pull request review commentmicrosoft/microsoft-ui-xaml

Miscellaneous TabView fixes

 winrt::DependencyObject TabView::ContainerFromIndex(int index)     }     return nullptr; }++void TabView::OnTabViewKeyDown(const winrt::IInspectable&, const winrt::KeyRoutedEventArgs& args)+{+    winrt::CoreVirtualKeyStates ctrlState = winrt::CoreWindow::GetForCurrentThread().GetKeyState(winrt::VirtualKey::Control);++    if (IsEnabled()+        && SelectedItem()+        && (ctrlState & winrt::CoreVirtualKeyStates::Down) == winrt::CoreVirtualKeyStates::Down)+    {+        winrt::VirtualKey key = args.Key();++        if (key == winrt::VirtualKey::F4)

That sounds better than what I have now, but do you have an example of this working? I tried setting it up, but my invoke method never gets called. It looks like this:

winrt::KeyboardAccelerator keyboardAccelerator; keyboardAccelerator.Key(winrt::VirtualKey::F4); keyboardAccelerator.Modifiers(winrt::VirtualKeyModifiers::Control); keyboardAccelerator.Invoked(winrt::auto_revoke, { this, &TabView::OnCtrlF4Invoked }); KeyboardAccelerators().Append(keyboardAccelerator);

teaP

comment created time in 9 minutes

issue commentmicrosoft/fhir-server

Upsert functionality doesn't return newly created resource

@hansenms your team created a really great architecture that encourages people to use this fhir server to expose their already existing databases with fhir endpoints.

so, let's look at following cases: case 1) someone uses MS FHIR server "as is", uses it automatically generated DB structure like Resource table, ResourceType table etc so, devs relies on ID's generation that's inside Microsoft.Health.Fhir.Core.Features.Resources.BaseResourceHandler.cs line 41:

if (string.IsNullOrEmpty(resource.Id))
            {
                resource.Id = **Guid.NewGuid().**ToString();
            }

there is nothing special here.

case 2) There is already some mature Healthcare organization. There is already some SQL database with tables Patient, Organization, CommunicationRequest etc there are already dozen of stored procedures etc etc so, it's impossible to use your cosmosdb workflow, or your implementation of SQL Server's workflow but, you developed a great architecture that allows to create any custom implementation of IFhirDataStore and inject it to MS FHIR server workflow by using DI. so, the fact is that people already extends your fhir server with their custom implementation of IFhirDataStore and they will do it in the future also.

from this point of view: a) your need to move assigning of "GUID id" from BaseResourceHandler.cs to concrete datastores:

  • Microsoft.Health.Fhir.SqlServer.Features.Storage.SqlServerFhirDataStore
  • Microsoft.Health.Fhir.CosmosDb.Features.Storage.CosmosFhirDataStore

b) existing Healthcare organization use own rules to assign IDs, they may be GUIDs, may be long, int, or some custom composite string key etc you really have no idea how id will be generated.

c) you store a fhir resource as "raw resource" in Resource table. But, existing old Healthcare organization could use the following workflow: fhir client-> fhir document(resource)-> ms fhir controller -> Custom implementation of IFhirDataStore -> SQL database.

and you have no idea what's going on inside "custom implementation". which IDs will be assigned. Which other properties will be modified. may be this custom impl. just takes original document -> parses it, extracts data, store these data in custom tables but with concrete fields/columns (id, name, address etc) , not as a "raw resource",

and then creates a custom fhir document(resource) by using some third-party library or own similar library and returns to ms fhir server's workflow not original but somehow created valid FHIR resource.

you can not rely on that FhirDataStore.UpsertAsync always return original document just with few properties modified. it may return completely new document with some properties from original document, some properties will be generated somehow in BE etc.

so, workaround above (with deserialization) will cover both cases:

  1. using standard ms fhir workflows (cosmosdb or storing in ms sql server as "raw resource")
  2. using some custom implementation of IFhirDataStore, where original document won't be "touched" but newly created document will be returned.

P.S. generally speaking, original resource should be "immutable".

devcs21

comment created time in 9 minutes

issue commentmicrosoft/recommenders

[FEATURE] Default random-seed to None

@miguelgfierro Our data splitter utils are still using a default seed argument 42. I think we should use None for default instead. What do you think?

loomlike

comment created time in 9 minutes

pull request commentmicrosoft/OpenAPI.NET

Serialize explode value properly on parameters with style "form"

I need to get a certificate updated before I can redeploy. Working on it.

mapitman

comment created time in 9 minutes

pull request commentmicrosoft/MixedRealityToolkit-Unity

Remove unused InteractionReceiver.cs

<samp> Azure Pipelines successfully started running 2 pipeline(s).<br>

</samp>

wiwei

comment created time in 9 minutes

PR opened microsoft/vscode-python

Reviewers
Fix ptvsd update install

For #6592

<!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ -->

  • [X] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • [X] Title summarizes what is changing
  • [X] Has a news entry file (remember to thank yourself!)
  • [X] Appropriate comments and documentation strings in the code
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.
+9 -8

0 comment

3 changed files

pr created time in 9 minutes

pull request commentmicrosoft/MixedRealityToolkit-Unity

Remove unused InteractionReceiver.cs

/azp run

wiwei

comment created time in 9 minutes

PR opened microsoft/MixedRealityToolkit-Unity

Reviewers
Remove unused InteractionReceiver.cs

https://github.com/microsoft/MixedRealityToolkit-Unity/issues/5139

See the issue for more background - this file was added a long time ago with the hopes that it would evolve into a more useful example for how to handle input. In its current state it doesn't work, and it doesn't have docs or any other references.

+0 -491

0 comment

1 changed file

pr created time in 9 minutes

push eventmicrosoft/onnxruntime

Raymond Yang

commit sha a203077dcd7268fd3b80840b145592c18eda107a

Relax timeout in CI system (#1394) * Relax timeout in CI system (temporary) * Relax timeout on TensorRT pipeline

view details

Changming Sun

commit sha d38badffdba37ad396af03849d245463ff302004

Disable mklml in Windows Build

view details

Changming Sun

commit sha 55e467338fa12a920055796a61e8a74b30a38e0e

Merge branch 'master' into snnn/sample1

view details

push time in 9 minutes

push eventmicrosoft/vscode

Logan Ramos

commit sha 3894d8be50ffe81dc15e5b95ea6648301c3d1c71

Bump vscode-telemetry-extractor to 1.4.1

view details

push time in 10 minutes

pull request commentmicrosoft/TypeScript

Private named instance fields

Some replies to comments that won't let me reply ((!) github doesn't seem to scale well to reviews of this size):

  1. You make a decent argument for putting isPrivateIdentifier in getLiteralTypeFromPropertyName. If we leave it there, then I think you should remove the one you just added. Sorry for making you go back and forth on that.
  2. any is by default a marker that the compiler should shut up. I would not try to issue an error on any.#foo in a class with no #foo. I'm afraid we'd end up with spurious errors in weird JS corner cases, if nothing else.
mheiber

comment created time in 10 minutes

fork exantrius/TypeScript-Node-Starter

A starter template for TypeScript and Node with a detailed README describing how to use the two together.

fork in 10 minutes

pull request commentmicrosoft/vscode-python

Fix executeInFileDir doesn't work when file is not in a workspace

Hi @bet4it , thank you for submitting this pull request! These changes caused some unit tests to fail though, could you please take a look and amend your PR?

👉 The failing tests are:

  • https://github.com/microsoft/vscode-python/blob/295f1f1b29fc974565ad9cd1d11d2e3535cc1130/src/test/terminals/codeExecution/terminalCodeExec.unit.test.ts#L199
  • https://github.com/microsoft/vscode-python/blob/295f1f1b29fc974565ad9cd1d11d2e3535cc1130/src/test/terminals/codeExecution/terminalCodeExec.unit.test.ts#L202

➡️ You can run them locally through VS Code by modifying the launch.json file and adding the test suite name to the grep params:

https://github.com/microsoft/vscode-python/blob/295f1f1b29fc974565ad9cd1d11d2e3535cc1130/.vscode/launch.json#L147

➡️ Or you can run them via the command line: npm run test:unittests -- --grep=<suite_name>.

Thank you again for your contribution!

bet4it

comment created time in 10 minutes

pull request commentmicrosoft/onnxruntime

Switch some of the linux pipelines to use the new data download script

<samp> Azure Pipelines successfully started running 22 pipeline(s).<br>

</samp>

snnn

comment created time in 10 minutes

startedmicrosoft/Quantum

started time in 10 minutes

startedmicrosoft/TypeScript-Node-Starter

started time in 10 minutes

issue openedmicrosoft/cobalt

Enable ARM_PROVIDER_STRICT flag to all deployments to prevent accidental deletes

Description

As a template maintainer/deployment operator, I'd like to avoid accidentally importing resources into terraform in order to reduce the likelihood of an accidental delete

Acceptance Criteria

Reference: [Done-Done Checklist] (https://github.com/Microsoft/code-with-engineering-playbook/blob/master/Engineering/BestPractices/DoneDone.md)

  • [ ] ARM_PROVIDER_STRICT is set to true for CI/CD pipeline in AZDO
  • [ ] ARM_PROVIDER_STRICT is set to true for local testing
  • [ ] ARM_PROVIDER_STRICT is set to true for all .env.template files

Also, here are a few points that need to be addressed:

  1. Constraint 1;
  2. Constraint 2;
  3. Constraint 3.

Resources

Technical Design Document Mockups

Tasks

Stories are intended to be completed in a single sprint; if task breakdown creates addition work then team should discuss promoting the Story to an Epic. Reference: [Minimal Valuable Slices] (https://github.com/Microsoft/code-with-engineering-playbook/blob/master/Engineering/BestPractices/MinimalSlices.md)

Reference: [How to Write Better Tasks] (http://agilebutpragmatic.blogspot.com/2012/04/splitting-story-into-tasks-how-to-write.html)

Assignee should break down work into tasks here

created time in 11 minutes

issue commentmicrosoft/MixedRealityToolkit-Unity

Remove InteractionReceiver since it is not being used by anything

I'm removing this, and given that it's broken, I don't think it's worth calling out in the changelog in GA.

For future folks if you're reading this and you WERE using this functionality, please reopen this issue (or a file a new one) with your use case.

Alexees

comment created time in 11 minutes

push eventmicrosoft/azuredatastudio

rchlkm

commit sha b78ff417639fbafdd00708b28a51cb84513a389b

Added telemetry code for visualizer recommendation popup and the updated UX language for popup

view details

push time in 11 minutes

push eventmicrosoft/WebTemplateStudio

Annie Liang

commit sha f6c6d9c8b87a4d19b734e1ccadd41aeedc136bd3

remove periods

view details

Annie Liang

commit sha b4cdedae68df118d5b8f2e519e9e4c0516b04a3f

Merge branch 'garage/t-anlian/card-change-css' of https://github.com/microsoft/WebTemplateStudio into garage/t-anlian/card-change-css

view details

push time in 11 minutes

Pull request review commentmicrosoft/VFSForGit

Move Enlistment Directory For Functional tests to ~/GVFS.FT

 if [ -z $CONFIGURATION ]; then   CONFIGURATION=Debug fi -sudo mkdir /GVFS.FT-sudo chown $USER /GVFS.FT-+sudo mkdir ~/GVFS.FT

-p will also create intermediate directories if they're missing and so the absence of -p could be a sanity check that the intermediate directories that we expect to be present are in fact present.

I could see that. Since this is pre-existing and outside the scope of my changes I'll leave it be.

jeschu1

comment created time in 11 minutes

pull request commentmicrosoft/TypeScript

Improve type checking and inference for Generators and Async Generators

This appears to be the root cause of https://github.com/palantir/tslint/issues/4784.

rbuckton

comment created time in 11 minutes

delete branch microsoft/vscode-edge-devtools

delete branch : user/jalissia/open-file-patch

delete time in 11 minutes

startedmicrosoft/UnitTestBoilerplateGenerator

started time in 12 minutes

create barnchmicrosoft/vscode-edge-devtools

branch : user/jalissia/source-map-settings

created branch time in 12 minutes

push eventmicrosoft/bistring

Tavian Barnes

commit sha 87ae33f227b18a2762cce522817bd17f4a39d128

docs: Add an intersphinx mapping for the Python standard library

view details

push time in 12 minutes

issue openedmicrosoft/vscode-python

"Export to different formats" in Plot window only saves a portion of plots

Environment data

  • VS Code version: 1.36.1 (user setup)
  • Extension version (available under the Extensions sidebar): 2019.6.24221 (9 July 2019)
  • OS and version: Windows_NT x64 10.0.17763
  • Python version (& distribution if applicable, e.g. Anaconda): Anaconda3
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
  • Relevant/affected Python packages and their versions: XXX
  • Jedi or Language Server? (i.e. what is "python.jediEnabled" set to; more info #3977): Language Server

Expected behaviour

Should save the image/plot correctly!

Actual behaviour

It saves only a portion of the actual image.It seems it only considers images to have a specific size only! and saves that size only!

Steps to reproduce:

  1. Run the Python Interactive window
  2. Plot or display an image in the interactive window
  3. Click on the 'Expand image' Icon on the left upper corner of the plot in the interactive window
  4. In the new window, click on "Export to different formats" and save as PNG image.

Here is an input example : image

and this is how it was saved : 1

created time in 12 minutes

pull request commentmicrosoft/onnxruntime

Switch some of the linux pipelines to use the new data download script

/azp run

snnn

comment created time in 12 minutes

push eventmicrosoft/onnxruntime

Changming Sun

commit sha d38badffdba37ad396af03849d245463ff302004

Disable mklml in Windows Build

view details

Changming Sun

commit sha 18e28c482a7a7d15348d064b084c9d5e529fa6de

Merge branch 'master' into snnn/tensorrt_testdata

view details

push time in 12 minutes

push eventmicrosoft/terminal

Leonard Hecker

commit sha 7067910862be0538a452d8e37f26d9b8d9922b45

Add a ControlKeyStates wrapper class (#1718) * Fixed a minor build warning * Removed an unimplemented method declaration * Added Microsoft::Terminal::Core::ControlKeyStates // This class will act as a safe wrapper for the ControlKeyState enum, // found in the NT console subsystem (<um/wincon.h>).

view details

push time in 12 minutes

PR merged microsoft/terminal

Reviewers
Add a ControlKeyStates wrapper class

Summary of the Pull Request

As a continuation to #1436 this PR adds a Microsoft::Terminal::Core::ControlKeyStates class which will act as a safe wrapper for the ControlKeyState enum, found in the NT console subsystem (<um/wincon.h>) and used throughout the older parts of this project.

<!-- Please review the items on the PR checklist before submitting-->

PR Checklist

  • [x] CLA signed. If not, go over here and sign the CLA
  • [ ] Tests added/passed
  • [x] Requires documentation to be updated
  • [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #1436

Detailed Description of the Pull Request / Additional comments

Feel free to reject, modify, adopt or otherwise use this code in any way or form. If you have comments I'll try my best of integrating them. The ControlKeyStates class I wrote is as good as I was able to think of one for now which is compatible to the rest of the code base. I think it should replace the KeyModifiers enum, but I'm a total C# noob and was afraid of doing so (my total C# experience is about 10h or so and I haven't even touched IDLs yet lol).

Validation Steps Performed

As with #1436 I tested all possible Alt/Ctrl/Shift/AltGr combinations on my german keyboard using PowerShell and wsl. Only AltGr+E (= €) on PowerShell failed to work, but I strongly assume that this is due to the ReadLine module or similar, as it works with wsl.

+162 -45

0 comment

9 changed files

lhecker

pr closed time in 13 minutes

push eventmicrosoft/onnxruntime

Changming Sun

commit sha d38badffdba37ad396af03849d245463ff302004

Disable mklml in Windows Build

view details

push time in 13 minutes

issue commentmicrosoft/thrifty

Support for Kotlin Multiplatform

Despite the wall of text, I want to stress that this is exciting work that I would like to see land in the project - the only questions are "how to", not "should we".

maxspencer

comment created time in 13 minutes

delete branch microsoft/onnxruntime

delete branch : snnn/disable_mklml

delete time in 13 minutes

PR merged microsoft/onnxruntime

Disable mklml in Windows Build

Description: Disable mklml in Windows CI build.

Motivation and Context

  • Why is this change required? What problem does it solve? One of our test often hangs in mklml.dll. We don't have the source and we can't fix the issue. Currently, the best way to unlock people is disabling mklml.

  • If it fixes an open issue, please link to the issue here.

+1 -1

3 comments

1 changed file

snnn

pr closed time in 13 minutes

PR opened microsoft/TypeScript

Use floating version for @types/node
+1 -1

0 comment

1 changed file

pr created time in 13 minutes

push eventmicrosoft/vscode-python

Kim-Adeline Miguel

commit sha f96bf83a57470712abebc49ae8f5ac619fccf6c7

Remove existing positional args when running a single test on pytest (#6537) * Make positional arg parsing more flexible * Add news file * Make tests pass * added tests for argumentsHelper.ts * Add tests for getPositionalArguments only * Remove comment * Increase coverage * Fix test * Fix typo

view details

Rich Chiodo

commit sha 17552267801b953c1bb0e22c6f3aaae27e78fb6a

Add support for debugging on a remote jupyter server (#6549) * First steps in remote support for debugging * Add comment to help mitigate mismatches * Change to local host for remote enable attach * Handle path mapping * Fix live share to attach * Fix guest debugging to not actually start the debugger * Add news entry * Fix localize test * Add remote test for debugging * Review feedback

view details

Rainer Dreyer

commit sha 26dc686af98259792f6f4e20abdde8a2671e06cc

Fixes pytest discovery: Not all pytest items have `own_markers` (#6514) Co-Authored-By: Eric Snow <ericsnowcurrently@gmail.com>

view details

Kim-Adeline Miguel

commit sha 245442325ff02a85dfbac2f2a4d1b649c0fa9f85

Add regex to dedent `else` and friends (#6497) * Dedent on elif|else * Add unit tests (will conflict with #4241) * More descriptive comment (same as f5daf78) * Move tests from extension to language config file * Add news file * Use regex we just introduced * Space is free * Update regexes and existing tests (so they pass) * Add support for open tuples and dictionaries * Shuffle and add tests * Typo + more descriptive key name * Updated news file after new changes * Apply suggestions from code review (first batch) Co-Authored-By: Eric Snow <ericsnowcurrently@gmail.com> * Update src/client/language/languageConfiguration.ts Co-Authored-By: Eric Snow <ericsnowcurrently@gmail.com> * Third batch of review fixes * Add some comments * Separate unit tests * More test simplification * Simplify return regex * Remove unnecessary tslint disable rule * pipeline is stuck

view details

Ian Huff

commit sha b8c2f20b0195893beff5e25a8147f50f9cc4f60b

Prompt to install ptvsd when needed (#6562)

view details

Joyce Er

commit sha d262ea9bd05dc76adefb91099b1b6d6f73e8c768

Fix sentence case and IPython stylization (#6567)

view details

Rich Chiodo

commit sha 4738d9dc1fc0a5f3e15ee0b287c9978fa8d3183a

Perf fixes for the interactive window (#6566) * Fix perf problems and escape issue with editor * Speed up ansi conversions Switch to jupyter algorithm for concating text Skip scrolling if coming too fast * Limit not just lines but also text chars * Fix functional test * Add news entries * Another news entry * Fix dataviewing and build error * Fix variable refresh * Go back to old /r code. Works better * Use throttle instead of debounce for scrolling. Want a minimum scroll * Get rid of unnecessary check * Remove requires * Use requre for lodash. Failing during normal build.

view details

Kim-Adeline Miguel

commit sha 8baea3fabebaafeb8fba3c501be49f58960113b5

Add pytest-xdist's -n to the list of supported options for pytest (#6565) * Add pytest-xdist's n to the supported options list * Better comment * Add some tests * Add some more tests

view details

Joyce Er

commit sha f2c1a57027652341f53f8a8fa6a8484b0aa1ef2d

Import get_ipython when there are line magics (#6575) * Import get_ipython when there are line magics * Add news entry

view details

Kim-Adeline Miguel

commit sha 97c06aa93db13d794d13c29f1e539d31438a1c8b

Merge ArgumentsHelper unit tests into one file (#6584) * Merge tests * Add news file

view details

Rich Chiodo

commit sha 2227fbbdb225446b56fb31be2f116e38629959ba

On linux, jupyter kernels may not reference full paths (#6586) * Fix when python path is not specified fully * Put back --user so ipykernel works again * Add news entry * Handle exceptions in fetching the path

view details

Joyce Er

commit sha 9a4c279c09c1fafc42b0e87a1e638aac4f5044a2

Dispose codewatcher when document is closed (#6589) * Delete codewatcher when text document is closed

view details

Rich Chiodo

commit sha 5e92f61146ca34ca8a2b2fbfe689a82094b9cfa4

Fix nightly functional tests failures for datascience (#6591) * Fix stack trace issues * Attempt to fix restart issues with restart kernel. * Add async dump for long running test * Fix loop for session * Try waiting longer for shutdown * Put async dump back the way it was before. * Use pypi to install ptvsd * Add more logging * More logging * More logging * Just run functional tests * Remote ready session work. Only wait for ready on restart. * Fix debugger tests. Try not shutting down during restart * More logging * Put off restart session * Add some more logging * More logging * More logging * Fix restart bug * More logging * Linter errors * Loop for idle for restart * Fix linter errors * Let ptvsd be installed * Update package-lock * Remove some logging * Put ptvsd back in the functional requirements. Installer isn't working * Remove some logging and put back full nightly * Remove some logging * Up timeout to 90 minutes

view details

Rich Chiodo

commit sha 295f1f1b29fc974565ad9cd1d11d2e3535cc1130

Fix pandas version parsing (#6600)

view details

Rich Chiodo

commit sha cb110cab2fe59e875efa1b01b65f36f48f2ed814

Merge from master

view details

Rich Chiodo

commit sha 7a55496bd312f238b66dd64fe4a632881e5f2113

Add support for canceling a bunch of run commands

view details

Rich Chiodo

commit sha c11b726e29e98c38f8892369d6c696e5a0edcea6

Add tests and fix run below

view details

push time in 13 minutes

push eventmicrosoft/sarif-sdk

Rusty Scrivens

commit sha f98f465beeb928c5d4f3af3cb01de25efc93c414

Updating dependency lodash in ESLint.formatter to patch a vulnerability (#1576)

view details

Larry Golding

commit sha 95d21312da80f9fc29898f3cb6b9f49de249f71f

Merge branch 'master' into users/lgolding/eslint-nits

view details

push time in 13 minutes

push eventmicrosoft/Orb

Gaurav Jagtiani

commit sha 6f768e1f4e16e02732db770eeb0b17651e003d4d

Update README.md

view details

push time in 13 minutes

more