profile
viewpoint

kiwix/kiwix-android 371

Kiwix for Android

kiwix/kiwix-android-custom 6

Necessary data/tools for the Android custom apps

mhutti1/android-storage-devices 3

Get a list of writable storage locations in android.

kiwix/test-gateway 2

[ARCHIVED] Automated test gateway for Kiwix for Android

mhutti1/chat 1

Simple Chat App

FindMySpot/ParkingWeb 0

Web Fronted for Parking

mhutti1/apps-android-wikipedia 0

The official Wikipedia Android app. This is a mirror from https://gerrit.wikimedia.org.

mhutti1/indy-sdk 0

Everything needed to build applications that interact with an Indy distributed identity ledger.

pull request commentkiwix/kiwix-android

fix: Restored position of articles on new launches

Why not have a switch in settings to turn on/off this behavior

s-ayush2903

comment created time in 10 minutes

issue commentkiwix/kiwix-android

Kiwix fails to restore state of previously opened article on new launches

@kelson42 Is the issue title fine or needs to be changed? I believe we can fix the "Start with Reader" problem in a new ticket, the trickier part was to restore the previous position of the article in new launches, with the merge of the linked PR we'll be good to go with it. And for "Start with Reader" I've planned of creating a new ticket and then writing a fix for it, I think the fix for it should be easy enough to write. I'm waiting for a response from your end, on the green check I'll create one and will work on it.

daniels234

comment created time in 5 hours

pull request commentkiwix/kiwix-android

fix: Saved position of articles on new launches

Ah, in the last commit I removed my experimental work that I forgot to commit on another branch as I started on 2567 weeks back and earlier was trying things out locally so today while writing the real changes for 2567 my stupid experiments inadvertently crept in, apologies for that.

s-ayush2903

comment created time in 6 hours

pull request commentkiwix/kiwix-android

fix: Saved position of articles on new launches

Codecov Report

Merging #2581 (d8b5f24) into develop (b0c0b08) will decrease coverage by 0.16%. The diff coverage is 15.78%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2581      +/-   ##
=============================================
- Coverage      39.05%   38.88%   -0.17%     
  Complexity        31       31              
=============================================
  Files            287      286       -1     
  Lines           7325     7357      +32     
  Branches         894      901       +7     
=============================================
  Hits            2861     2861              
- Misses          4168     4193      +25     
- Partials         296      303       +7     
Impacted Files Coverage Δ Complexity Δ
...bile/nav/destination/reader/KiwixReaderFragment.kt 33.08% <6.25%> (-3.28%) 0.00 <0.00> (ø)
...iwix/kiwixmobile/core/main/CoreReaderFragment.java 24.21% <66.66%> (-0.49%) 0.00 <0.00> (ø)
...ixmobile/core/main/CompatFindActionModeCallback.kt 20.00% <0.00%> (-0.29%) 0.00% <0.00%> (ø%)
...ix/kiwixmobile/custom/main/CustomReaderFragment.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...java/org/kiwix/kiwixmobile/core/main/FileReader.kt
...bile/custom/download/effects/FinishAndStartMain.kt
...ixmobile/custom/download/CustomDownloadActivity.kt
...ixmobile/custom/download/CustomDownloadFragment.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
.../custom/download/effects/NavigateToCustomReader.kt 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b0c0b08...c82f557. Read the comment docs.

s-ayush2903

comment created time in 6 hours

issue commentkiwix/kiwix-android

Kiwix fails to restore state of previously opened article on new launches

@kelson42 Is the issue title fine or needs to be changed?

daniels234

comment created time in 6 hours

PR opened kiwix/kiwix-android

fix: Saved position of articles on new launches

<!--

  • Add the issue number here.

  • If you haven't solved the issue completely use "Linked issue #{issue_number}.

  • After solving the issue completely change it to "Fixes #{issue_number}. --> Fixes #2567

<!-- Add here what changes were made in this issue and if possible provide links. -->

Added required methods and corrected the method for restoring state of previously opened article

<!-- If possible, please add relevant screenshots / GIFs -->

Visuals Watch right here: https://youtu.be/zY0oXgWxgfw

+41 -8

0 comment

3 changed files

pr created time in 6 hours

startedsignalapp/Signal-Android

started time in 15 hours

startedsignalapp/Signal-Desktop

started time in 15 hours

issue openedkiwix/kiwix-android

Suggestion search fails on cutting-edge Wikispecies custom app

A few hours ago I have released a new Wikispecies custom app: https://play.google.com/store/apps/details?id=org.kiwix.kiwixcustomwikispecies

Yesterday I failed because of #2578 but this has been fixed and I change the CI of the Kiwix Android Custom Apps to deal with the develop branch instead of the usual official release branch master. See: https://github.com/kiwix/kiwix-android-custom/commit/b73f0b5c07b8775d84238b8c217e7b267a83362e

First all seemed first OK and I have put the Wikispecies app in production. Unfortunately I missed an important regression. The problem is that what ever the suggestion I choose in the proposed suggestions, it always load the welcome page. Which make the search/suggestion system useless.

Would be great to identify quickly the problem so I can fix the production release of the Wikispecies custom app (and later updated other app with 3.4.3+ code base).

created time in 2 days

push eventkiwix/kiwix-android

Emmanuel Engelhart

commit sha 807b50025486bd5b4d6b2589bcafd711fbd12efe

Bump-up NDK version to 22.0.7026061

view details

Kelson

commit sha 36c29b2d20e295c785eade3831263357e0b8857c

Merge pull request #2579 from kiwix/ndk-22.0.7026061 Bump-up NDK version to 22.0.7026061

view details

translatewiki.net

commit sha 4830c64e547039cf6298c53eb1ea6e2d9dbe57c8

Localisation updates from https://translatewiki.net.

view details

push time in 2 days

pull request commentkiwix/kiwix-android

#1447 Can't open zim from external download

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

macgills

comment created time in 2 days

push eventkiwix/kiwix-build

ChrisLi

commit sha 41071d7c9b0f838c2e9cef6448d8a380a1b744f9

use brew list --formula (#468)

view details

push time in 2 days

delete branch kiwix/kiwix-build

delete branch : use_brew_list_formula

delete time in 2 days

PR merged kiwix/kiwix-build

Reviewers
Use brew ls --version

Home brew recently deprecated brew list, resulting in errors when determining if automake etc. exists:

(venv) chrisli@Chriss-Mac-Pro kiwix-build % kiwix-build --target-platform iOS_multi kiwix-lib
[INSTALL PACKAGES]
Error: Calling `brew list` to only list formulae is disabled! Use `brew list --formula` instead.
 - autoconf : NEEDED
Error: Calling `brew list` to only list formulae is disabled! Use `brew list --formula` instead.
 - automake : NEEDED
Error: Calling `brew list` to only list formulae is disabled! Use `brew list --formula` instead.
 - libtool : NEEDED
Error: Calling `brew list` to only list formulae is disabled! Use `brew list --formula` instead.
 - cmake : NEEDED

In this PR, I am updating the subprocess call used to determine if a certain brew formula is installed to brew ls --version

+1 -1

0 comment

1 changed file

automactic

pr closed time in 2 days

issue closedkiwix/kiwix-android

Kiwix (Android) loads significant amount of mobile data at startup

Hello,

I'm using Kiwix for Android, version 3.4.3, build 6230403. My phone is a Samsung Galaxy S10e running Android 10, latest patch level.

Bug report: When opening Kiwix, it loads approx. 9.4 MB of data before showing the dialog for the Zim selection. I.e. this happens without a Zim file opened. This is annyoing because I have used Kiwix in the past due to my limited amount of mobile data. I have 1024 MB of mobile data available every 30 days. So Kiwix "consumes" ~1% of my data each time I open the app. If Kiwix loads so much data on startup, the concept of an "offline" reader is broken. This renders Kiwix useless for this "data saving" scenario, and it it is better to use the online Wikipedia instead for a quick Wikipedia query. Of course one could turn of mobile data before opening Kiwix. But this isn't really comfortable.

I hope you an reproduce the bug. Thank you.

Best regards

Schmidt32

closed time in 2 days

Schmidt32

issue commentkiwix/kiwix-android

Kiwix (Android) loads significant amount of mobile data at startup

@Schmidt32 The bug has been fixed in 3.4.3. Considering that it has been released in December, you have been impacted by it in November.

Schmidt32

comment created time in 2 days

issue commentkiwix/kiwix-android

Kiwix (Android) loads significant amount of mobile data at startup

Ah, no worries @Schmidt32 thanks for the report and providing the dissection of the issue faced by you :+1: I think we can close it since it longer exists.

Schmidt32

comment created time in 2 days

pull request commentkiwix/kiwix-android

Bump-up NDK version to 22.0.7026061

Yeah, this is due to the flakiness of instrumentation tests on CIs, they run smooth locally but sometimes fail pointlessly in CIs, so retriggering 'em fixes(but not always)

kelson42

comment created time in 2 days

push eventkiwix/kiwix-android

Emmanuel Engelhart

commit sha 807b50025486bd5b4d6b2589bcafd711fbd12efe

Bump-up NDK version to 22.0.7026061

view details

Kelson

commit sha 36c29b2d20e295c785eade3831263357e0b8857c

Merge pull request #2579 from kiwix/ndk-22.0.7026061 Bump-up NDK version to 22.0.7026061

view details

push time in 2 days

delete branch kiwix/kiwix-android

delete branch : ndk-22.0.7026061

delete time in 2 days

PR merged kiwix/kiwix-android

Bump-up NDK version to 22.0.7026061

Might fix #2578

+3 -3

12 comments

3 changed files

kelson42

pr closed time in 2 days

issue closedkiwix/kiwix-android

[REGRESSION] Newly unable to build custom apps (based on master 3.4.3)

I tried today to release a new wikispecies custom app, but the CD failed, see: https://github.com/kiwix/kiwix-android-custom/runs/1700722782?check_suite_focus=true

I believe what went wrong is:

* What went wrong:
60 actionable tasks: 60 executed
Execution failed for task ':custom:stripWikispeciesReleaseDebugSymbols'.
> No version of NDK matched the requested version 21.3.6528147. Versions available locally: 22.0.7026061

closed time in 2 days

kelson42

pull request commentkiwix/kiwix-android

Bump-up NDK version to 22.0.7026061

Lokks like it was onky a temporary problem, just restarting the CI has solved the problem.

kelson42

comment created time in 2 days

issue commentkiwix/kiwix-android

Kiwix (Android) loads significant amount of mobile data at startup

That's weird: Now I cannot reproduce the problem anymore :-( I have manually turned of WiFi in my router, and it does not consume mobile data anymore.

I have initially detected the problem during a hospital stay (Nov 12-16) last year, and I've used Kiwix multiple times per day there, closing it each time after usage. I didn't have WiFi in the hospital (rather expensive), but it was enabled in the settings nonetheless. There I have found the issue with the mobile data usage because Kiwix has consumed much of my mobile data in the hospital unexpectedly. I cannot say which version I had at this time. But I have definitively updated all my apps before going to the hospital, i.e. on Nov 12 in the morning C.E.T.. So maybe it was a version before the current one 3.4.3?

I'm also sorry that I have wasted your time with that. Maybe I should have reported it earlier so that the conditions are the same. But this chance is gone now.

I have also updated my smartphone yesterday from Android 10 to Android 11. Maybe this could also have caused the correct funtioning now.

Again: I have to excuse myself for wasting your time. And I thank you for your effort for trying to solve this. But the issue was definitively there. Otherwise I wouldn't have spent so much time with this report and with answering in this thread.

Schmidt32

comment created time in 2 days

pull request commentkiwix/kiwix-android

Bump-up NDK version to 22.0.7026061

@s-ayush2903 great job! What was the issue?

kelson42

comment created time in 2 days

PR opened kiwix/kiwix-build

Use brew ls --version

Home brew recently deprecated brew list, resulting in errors when determining if automake etc. exists:

(venv) chrisli@Chriss-Mac-Pro kiwix-build % kiwix-build --target-platform iOS_multi kiwix-lib
[INSTALL PACKAGES]
Error: Calling `brew list` to only list formulae is disabled! Use `brew list --formula` instead.
 - autoconf : NEEDED
Error: Calling `brew list` to only list formulae is disabled! Use `brew list --formula` instead.
 - automake : NEEDED
Error: Calling `brew list` to only list formulae is disabled! Use `brew list --formula` instead.
 - libtool : NEEDED
Error: Calling `brew list` to only list formulae is disabled! Use `brew list --formula` instead.
 - cmake : NEEDED

In this PR, I am updating the subprocess call used to determine if a certain brew formula is installed to brew ls --version

+1 -1

0 comment

1 changed file

pr created time in 2 days

create barnchkiwix/kiwix-build

branch : use_brew_list_formula

created branch time in 2 days

delete branch kiwix/kiwix-build

delete branch : ios

delete time in 2 days

delete branch kiwix/kiwix-build

delete branch : modularization

delete time in 2 days

delete branch kiwix/kiwix-build

delete branch : use_brew_list_formula

delete time in 2 days

more