profile
viewpoint
Michael Dawson mhdawson ottawa, ontario Node.js collaborator and TSC member, IoT hacker at home.

ibmruntimes/v8ppc 91

Port of Google V8 javascript engine to PowerPC®

ibmruntimes/yieldable-json 82

Asynchronous JSON parser and stringify APIs that make use of generator patterns

ibmruntimes/node 71

This repository hosts the ports of Node.js for IBM platforms not yet upstreamed to the community (i.e. z/OS port). For community support for Linux On Z, Linux on P or AIX, please visit https://github.com/nodejs/help. Visit http://ibm.biz/nodejs-zos-support for z/OS support content, including how open PMRs and buy IBM Service and Support.

mhdawson/AlexaMqttBridge 69

Bridge between Amazon Alexa and Mqtt

ibmruntimes/v8z 40

Port of Google V8 JavaScript engine to z/OS. The Linux on Z port is maintained in the community: https://chromium.googlesource.com/v8/v8.git

mhdawson/arduino-esp8266 9

arduino-esp8266 based sensors

IBM/nodejs-in-the-cloud 5

Node.js in the Cloud tutorial

gireeshpunathil/report 4

diagnostic report lab material

ianwjhalliday/node 3

Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:

andrewlow/libuv 2

Cross-platform asychronous I/O

issue commentnodejs/node-v8

N-API test failure

Remaining thing that is not like ci would be the ccache. Next week I'll create a duplicate job that would only run on the same machine and validate it fails under CI, and if so then try to remove the part of the job which configures ccache.

targos

comment created time in 2 days

issue commentnodejs/node-v8

N-API test failure

Double check last failure was on https://ci.nodejs.org/job/node-test-commit-linux/nodes=ubuntu1804-64/37204/

targos

comment created time in 2 days

issue commentnodejs/node-v8

N-API test failure

Called set-compiler but not the ccache config still did not recreate, but not much seemed to be compiled either. Having said that it did not seem to have changed the compiler either

targos

comment created time in 2 days

issue commentnodejs/node-v8

N-API test failure

did not recreate with a make node followed by make test, so likely means that its related to config set by the CI job, for example compiler or something else

targos

comment created time in 2 days

issue commentnodejs/node-v8

N-API test failure

Compiling in directory: https://github.com/nodejs/node-v8.git

targos

comment created time in 2 days

issue commentnodejs/node

linux systems, it's hard to find the different installation method for node from project website. and you can not find it or link for it in readme file in case you use binary file to install.

This seems reasonable to me. Once you've done it you know what to do, but the first time I can see that it's not obvious.

ad22ad

comment created time in 2 days

issue commentnodejs/package-maintenance

Publishing Strategy for PkgJS packages

My preferences are (in order)

  1. just publish once under the pkgjs scope.
  2. just publish in global scope
  3. dual publish.
wesleytodd

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentopenjs-foundation/cross-project-council

[WIP] Proposal to remove the Growth Stage

 It is expected that incubating project will make an active effort to work throug  1. consensus within private mailing list to move into incubation process -## IV. Annual Review Process+## IV. Growth Plan++At Large project that are interested in reaching Impact Stage need to develop a growth plan to so do. This plan needs to be developed in collaboration with the CPC and approved by it.

I think in the discussions, the idea was that a Growth plan is not tied to wanting to reach Impact Stage, and that even Impact projects might want a Growth plan.

Maybe

Project that are interested in extra support/attention in order to grow in a certain area need to developer a plan to do so....

tobie

comment created time in 2 days

PullRequestReviewEvent

push eventnodejs/security-wg

Dominykas Blyžė

commit sha 03b379c01f05e8d60e94c3fa64e3356683fa5f23

Update .travis.yml (#688) Closes #684

view details

push time in 2 days

PR merged nodejs/security-wg

Update .travis.yml to use latest LTS

Closes #684

+1 -1

0 comment

1 changed file

dominykas

pr closed time in 2 days

issue closednodejs/security-wg

.travis.yml references an EOL node version

I was going through .travis.yml across the org to look for outdated Node.js versions and spotted this repo referencing 8.9.0. I figure it needs a bump?

Not sure what this is used for - is it meant to be testing in a single version? If so - might make sense to just change the version to lts/* or latest. If it's meant to test in multiple versions - it may be worth using one of the shared configs at https://github.com/nodejs/ci-config-travis to automatically include new versions?

Happy to PR, if needed.

closed time in 2 days

dominykas

push eventnodejs/next-10

Michael Dawson

commit sha 4f08b8142dc913537560b3df74e1ef98fabe43cd

doc: add minutes for meeting 17 Sep 2020 (#19) * doc: add minutes for meeting 17 Sep 2020

view details

push time in 2 days

PR merged nodejs/next-10

doc: add minutes for meeting 17 Sep 2020

Signed-off-by: Michael Dawson mdawson@devrus.com

+55 -0

1 comment

1 changed file

mhdawson

pr closed time in 2 days

PullRequestReviewEvent

pull request commentnodejs/node

doc: add compatibility/interop technical value

Tagged for the next-10 agenda.

GeoffreyBooth

comment created time in 2 days

PullRequestReviewEvent

pull request commentnodejs/node

doc: refactor the n-api matrix

This should probably land https://github.com/nodejs/node/pull/35319/files and then I can rebase this PR on top of it.

mhdawson

comment created time in 2 days

PR closed nodejs/node

doc: improve N-API string-to-native doc doc n-api

Mention null termination handling in the string size accounting and string truncation.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+9 -6

3 comments

1 changed file

gabrielschulhof

pr closed time in 2 days

pull request commentnodejs/node

doc: improve N-API string-to-native doc

Landed in b54dd8d91d45

gabrielschulhof

comment created time in 2 days

push eventnodejs/node

Gabriel Schulhof

commit sha b54dd8d91d451d54aea3b2148180d109ecd1897e

doc: improve N-API string-to-native doc Mention null termination handling in the string size accounting and string truncation. PR-URL: https://github.com/nodejs/node/pull/35322 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <midawson@redhat.com>

view details

push time in 2 days

pull request commentnodejs/node

doc: improve N-API string-to-native doc

Doc only so linters run on PR are enough, landing

gabrielschulhof

comment created time in 2 days

PullRequestReviewEvent

issue commentnodejs/admin

GitHub Secret for nodejs/docker-node

+1 to fast track

nschonni

comment created time in 2 days

PR closed nodejs/node

doc: avoid referring to C array size doc n-api

The size of arrays is measured in bytes in C, not in the number of elements. The napi_get_cb_info function takes the length of the array, that is, the number of elements it can contain, and not its size.

I am not 100% happy with calling it "length" since it still isn't entirely unambigious, so I'd be happy about suggestions.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+2 -2

3 comments

1 changed file

tniessen

pr closed time in 2 days

pull request commentnodejs/node

doc: avoid referring to C array size

Landed in 2089b5583513

tniessen

comment created time in 2 days

push eventnodejs/node

Tobias Nießen

commit sha 2089b558351341f4e257584590a8e65009b3af59

doc: avoid referring to C array size The size of arrays is measured in bytes in C, not in the number of elements. The napi_get_cb_info function takes the length of the array, that is, the number of elements it can contain, and not its size. PR-URL: https://github.com/nodejs/node/pull/35300 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

view details

push time in 2 days

pull request commentnodejs/node

doc: avoid referring to C array size

Doc only so linters that have run on PR are enough, landing.

tniessen

comment created time in 2 days

PR closed nodejs/node

doc: update napi_make_callback documentation author ready doc n-api

Calling napi_make_callback() with no async_context is not resulting in using the current async context instead an empty context (id 0) is used.

Using NULL is like using node::Makecallback without async_context which is deprecated since Node.js 10 (DEP0099).

fixes: #35188

+5 -3

5 comments

1 changed file

Flarna

pr closed time in 2 days

pull request commentnodejs/node

doc: update napi_make_callback documentation

Landed in 03c4ee91d003

Flarna

comment created time in 2 days

push eventnodejs/node

Gerhard Stoebich

commit sha 03c4ee91d003da2a6ff4c19b91c7c7dafa705a55

doc: update napi_make_callback documentation Calling napi_make_callback() with no async_context is not resulting in using the current async context instead an empty context (id 0) is used. Using NULL is like using node::Makecallback without async_context which is deprecated since Node.js 10 (DEP0099). PR-URL: https://github.com/nodejs/node/pull/35321 Fixes: https://github.com/nodejs/node/issues/35188 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

view details

push time in 2 days

issue closednodejs/node

napi_make_callback() with null async_context doesn't reuse current context

<!-- Thank you for reporting an issue.

This issue tracker is for bugs and issues found within Node.js core. If you require more general support please file an issue on our help repo. https://github.com/nodejs/help

Please fill in as much of the template below as you're able.

Version: output of node -v Platform: output of uname -a (UNIX), or version and 32 or 64-bit (Windows) Subsystem: if known, please specify affected core module name -->

  • Version: 14.10.1, 12.18.3, 10.22.0
  • Platform: all
  • Subsystem: napi, async_hooks

What steps will reproduce the bug?

Call back sync to javascript from native using napi_make_callback() with async_context set to NULL. The simplest way to reproduce this is to add following code in test/node-api/test_make_callback_recurse/test.js

const { executionAsyncId } = require("async_hooks")
const eId = executionAsyncId();
makeCallback("foo", common.mustCall(function() {
  assert.strictEqual(executionAsyncId(), eId); // executionAsyncId is 0 here
}));

According to docs I would expect the test to pass as they tell However NULL is also allowed, which indicates the current async context (if any) is to be used for the callback..

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior?

I would expect that the current async id is not changed.

What do you see instead?

async_id 0 is used

Additional information

I'm not sure here if the docs should be corrected or the implementation. Maybe we should even disallow to pass NULL to napi_make_callback().

Relevant place in source: https://github.com/nodejs/node/blob/9d12c14b19bc30baa4cf556a0b8281e76637f7db/src/node_api.cc#L732-L734

Please note also that the c++ NAPI wrapper uses NULL as default argument for MakeCallback (see https://github.com/nodejs/node-addon-api/blob/6562e6b0ab604fd55b9c2d0cf954c9ce93e4bdee/napi.h#L1056-L1065).

closed time in 2 days

Flarna

pull request commentnodejs/node

doc: update napi_make_callback documentation

Doc only so linters already run are good enough, landing

Flarna

comment created time in 2 days

issue commentnodejs/abi-stable-node

Blog post to discuss last few years of N-API

Thanks we missed talking about it in the meeting today, we can brainstorm next week or review content if people have already added.

mhdawson

comment created time in 2 days

issue commentnodejs/node-v8

N-API test failure

Using test-joyent-ubuntu1804-x64-1 on which we saw the failure recently to investigate

targos

comment created time in 2 days

issue commentnodeshift/oratrix

Investigate the possibility to have licenses information

As mentioned in the meeting I think we should see what is already in place/available within Red hat in terms of licence scanning before going to far on this. Otherwise something like that makes sense, although it may be more complicated as I think people use modifications of the licences so there may also need to be a way to allow specific licences (full text) as well

helio-frota

comment created time in 2 days

pull request commentnodejs/node

doc: refactor the n-api matrix

Talked it over with in the N-API team meeting today, seems like people were ok with the approach, removing out of draft.

mhdawson

comment created time in 2 days

push eventmhdawson/io.js

Michael Dawson

commit sha d12ec4625769bbd0a0e0b8e71d9e8a4d5d19503b

Update doc/api/n-api.md

view details

push time in 2 days

Pull request review commentnodejs/node

doc: refactor the n-api matrix

 listed as supporting a later version.     <th scope="col">1</th>     <th scope="col">2</th>     <th scope="col">3</th>-    <th scope="col">4</th>-    <th scope="col">5</th>-    <th scope="col">6</th>   </tr>   <tr>     <th scope="row">v6.x</th>     <td></td>     <td></td>     <td>v6.14.2*</td>-    <td></td>-    <td></td>-    <td></td>   </tr>   <tr>     <th scope="row">v8.x</th>     <td>v8.6.0**</td>     <td>v8.10.0*</td>     <td>v8.11.2</td>-    <td>v8.16.0</td>-    <td></td>-    <td></td>   </tr>   <tr>     <th scope="row">v9.x</th>     <td>v9.0.0*</td>     <td>v9.3.0*</td>     <td>v9.11.0*</td>+  </tr>+  <tr>+    <th scope="row">v10.x,v11.x,v12.x,v13.x,v14.x</th>
    <th scope="row">>= v10.x</th>
mhdawson

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentnodejs/node-addon-api

WIP: add safer unwrap

@DaAitch any chance you can rebase so we can move forward.

DaAitch

comment created time in 2 days

Pull request review commentnodejs/TSC

doc: add onboarding step for pkgjs org

 invalid and are superseded by the TSC Charter. * Change the new member's role in the GitHub `nodejs` organization to `Owner`. * Add them to the `@nodejs-private` org and with an `Owner` role. * Add them to the `@nodejs-private/security-tsc` team.+* Add them to the `@pkgjs` org and with an `Owner` role.

@ljharb , @Trott updated.

mhdawson

comment created time in 2 days

PullRequestReviewEvent

push eventmhdawson/TSC

Michael Dawson

commit sha 1244c521a8babea69c8a8a0d579236d20c6da079

Update ONBOARDING.md

view details

push time in 2 days

push eventmhdawson/TSC

Michael Dawson

commit sha 9248927a20399c6c5475eec06c8a704cf8ecfbc0

Update ONBOARDING.md

view details

push time in 2 days

Pull request review commentnodejs/TSC

doc: add onboarding step for pkgjs org

 invalid and are superseded by the TSC Charter. * Remove them from the `@nodejs-private/security-tsc` team. * Remove them from the `@nodejs-private` org unless they are members for a   reason other than TSC membership.+* Remove them from the `@pkgjs` org unless they are members for a
  • Remove them from the @pkgjs/node-tsc team
  • Remove them from the @pkgjs org unless they are members for a
mhdawson

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentnodejs/TSC

doc: add onboarding step for pkgjs org

 invalid and are superseded by the TSC Charter. * Change the new member's role in the GitHub `nodejs` organization to `Owner`. * Add them to the `@nodejs-private` org and with an `Owner` role. * Add them to the `@nodejs-private/security-tsc` team.+* Add them to the `@pkgjs` org and with an `Owner` role.
* Add them to the `@pkgjs` org and with an `Owner` role.
* Add them to the `@pkgjs/node-tsc` team.
mhdawson

comment created time in 2 days

PullRequestReviewEvent

pull request commentnodejs/TSC

doc: add onboarding step for pkgjs org

@Trott I had started with adding to a team, but since they also had to be added to the org, I ended up not doing that. Happy to have a team as well though if that helps clarify things.

mhdawson

comment created time in 2 days

pull request commentnodejs/node

[v10.x] n-api: create N-API version 7

@richardlau looks like we missed updating the matrix in master, opened https://github.com/nodejs/node/pull/35345 to discuss how we might do that. Given that we don't know the versions in advance, I think we've deferred backporting the matrix

gabrielschulhof

comment created time in 2 days

pull request commentnodejs/node

doc: refactor the n-api matrix

@nodejs/n-api

mhdawson

comment created time in 2 days

pull request commentnodejs/node

doc: refactor the n-api matrix

Marked as draft as I think we need to change the format of the table, and wanted to get some feedback on this approach.

mhdawson

comment created time in 2 days

PR opened nodejs/node

doc: refactor the n-api matrix
  • refactor the n-api matrix and add v7

Signed-off-by: Michael Dawson mdawson@devrus.com

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [X] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [X] documentation is changed or added
  • [X] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+20 -26

0 comment

1 changed file

pr created time in 2 days

create barnchmhdawson/io.js

branch : napi-matrix-refactor

created branch time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

issue closednodejs/TSC

Node.js Technical Steering Committee (TSC) Meeting 2020-09-24

Time

UTC Thu 24-Sep-2020 20:00 (08:00 PM):

Timezone Date/Time
US / Pacific Thu 24-Sep-2020 13:00 (01:00 PM)
US / Mountain Thu 24-Sep-2020 14:00 (02:00 PM)
US / Central Thu 24-Sep-2020 15:00 (03:00 PM)
US / Eastern Thu 24-Sep-2020 16:00 (04:00 PM)
EU / Western Thu 24-Sep-2020 21:00 (09:00 PM)
EU / Central Thu 24-Sep-2020 22:00 (10:00 PM)
EU / Eastern Thu 24-Sep-2020 23:00 (11:00 PM)
Moscow Thu 24-Sep-2020 23:00 (11:00 PM)
Chennai Fri 25-Sep-2020 01:30 (01:30 AM)
Hangzhou Fri 25-Sep-2020 04:00 (04:00 AM)
Tokyo Fri 25-Sep-2020 05:00 (05:00 AM)
Sydney Fri 25-Sep-2020 06:00 (06:00 AM)

Or in your local time:

  • https://www.timeanddate.com/worldclock/fixedtime.html?msg=Node.js+Foundation+Technical%20Steering%20Committee%20(TSC)+Meeting+2020-09-24&iso=20200924T2000
  • or https://www.wolframalpha.com/input/?i=08PM+UTC%2C+Sep+24%2C+2020+in+local+time

Links

Agenda

Extracted from tsc-agenda labelled issues and pull requests from the nodejs org prior to the meeting.

nodejs/node

  • punycode: runtime deprecation #35092
  • doc: change requirements for objection dismissal #35037
  • 2020-10-20, Version 15.0.0 (Current) #35014
  • doc: drop minimum waiting time as hard guideline #33879
  • Rename default branch from "master" to "main" or something similar #33864
  • module: CJS exports detection for modules with __esModule export #33416
  • fs: simplify copy operations and more cleanups #31038

nodejs/admin

  • Audit Google account access #389

Invited

  • Anatoli Papirovski @apapirovski (TSC)
  • Beth Griggs @BethGriggs (TSC)
  • Ruben Bridgewater @BridgeAR (TSC)
  • Сковорода Никита Андреевич @ChALkeR (TSC)
  • Colin Ihrig @cjihrig (TSC)
  • Shelley Vohr @codebytere (TSC)
  • Daniel Bevenius @danbev (TSC)
  • Franziska Hinkelmann @fhinkel (TSC)
  • Gabriel Schulhof @gabrielschulhof (TSC)
  • Gireesh Punathil @gireeshpunathil (TSC)
  • James Snell @jasnell (TSC)
  • Joyee Cheung @joyeecheung (TSC)
  • Mary Marchini @mmarchini (TSC)
  • Matteo Collina @mcollina (TSC)
  • Michael Dawson @mhdawson (TSC)
  • Myles Borins @MylesBorins (TSC)
  • Michaël Zasso @targos (TSC)
  • Tobias Nießen @tniessen (TSC)
  • Rich Trott @Trott (TSC)
  • Guy Bedford @guybedford (Guest)
  • Geoffrey Booth GeoffreyBooth (Guest)

Observers/Guests

Notes

The agenda comes from issues labelled with tsc-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.

Joining the meeting

Zoom link: https://zoom.us/j/611357642 Regular password

Public participation

We stream our conference call straight to YouTube so anyone can listen to it live, it should start playing at https://www.youtube.com/c/nodejs+foundation/live when we turn it on. There's usually a short cat-herding time at the start of the meeting and then occasionally we have some quick private business to attend to before we can start recording & streaming. So be patient and it should show up.

Many of us will be on IRC in #node-dev on Freenode if you'd like to interact, we have a Q/A session scheduled at the end of the meeting if you'd like us to discuss anything in particular. @nodejs/collaborators in particular if there's anything you need from the TSC that's not worth putting on as a separate agenda item, this is a good place for that.


Invitees

Please use the following emoji reactions in this post to indicate your availability.

  • :+1: - Attending
  • :-1: - Not attending
  • :confused: - Not sure yet

closed time in 3 days

mhdawson

issue commentnodejs/TSC

Node.js Technical Steering Committee (TSC) Meeting 2020-09-24

PR for minutes, https://github.com/nodejs/TSC/pull/932

mhdawson

comment created time in 3 days

PR opened nodejs/TSC

doc: add minutes for meeting 24 Sep 2020

Signed-off-by: Michael Dawson mdawson@devrus.com

+115 -0

0 comment

1 changed file

pr created time in 3 days

create barnchmhdawson/TSC

branch : meeting24Sep

created branch time in 3 days

issue commentnodejs/TSC

V8 currency and Node.js 15

I assume this would affect apple on arm as well ? Just want to understand so that we know what people/companies we might reach out to in respect to finding more people to help out on the arm platform.

targos

comment created time in 3 days

issue commentnodejs/TSC

Objection Override -> [#33879](https://github.com/nodejs/node/pull/33879)

@mmarchini I was looking to see if we have consensus as the target we set for objections has passed. I'm not sure if you think we should change the proposal to be put into https://github.com/nodejs/node/pull/33879 or if the details of the audit can be finalised agreed afterwards?

mhdawson

comment created time in 3 days

issue commentnodejs/TSC

Node.js Technical Steering Committee (TSC) Meeting 2020-09-24

@GeoffreyBooth see you don't have one there so sent to the one you have as Node.js collaborator. Let me know if you don't get it.

mhdawson

comment created time in 4 days

issue commentnodejs/TSC

Node.js Technical Steering Committee (TSC) Meeting 2020-09-24

@GeoffreyBooth will send you the password through email.

mhdawson

comment created time in 4 days

issue openednodejs/outreach

Node.js Outreach Meeting 2020-09-29

Time

UTC Tue 29-Sep-2020 16:00 (04:00 PM):

Timezone Date/Time
US / Pacific Tue 29-Sep-2020 09:00 (09:00 AM)
US / Mountain Tue 29-Sep-2020 10:00 (10:00 AM)
US / Central Tue 29-Sep-2020 11:00 (11:00 AM)
US / Eastern Tue 29-Sep-2020 12:00 (12:00 PM)
EU / Western Tue 29-Sep-2020 17:00 (05:00 PM)
EU / Central Tue 29-Sep-2020 18:00 (06:00 PM)
EU / Eastern Tue 29-Sep-2020 19:00 (07:00 PM)
Moscow Tue 29-Sep-2020 19:00 (07:00 PM)
Chennai Tue 29-Sep-2020 21:30 (09:30 PM)
Hangzhou Wed 30-Sep-2020 00:00 (12:00 AM)
Tokyo Wed 30-Sep-2020 01:00 (01:00 AM)
Sydney Wed 30-Sep-2020 02:00 (02:00 AM)

Or in your local time:

  • https://www.timeanddate.com/worldclock/fixedtime.html?msg=Node.js+Foundation+Outreach+Meeting+2020-09-29&iso=20200929T1600
  • or https://www.wolframalpha.com/input/?i=04PM+UTC%2C+Sep+29%2C+2020+in+local+time

Links

Agenda

Extracted from outreach-agenda labelled issues and pull requests from the nodejs org prior to the meeting.

Invited

  • Outreach Members: @nodejs/outreach

Observers/Guests

Feel free to follow along on the YouTube live stream, or attend meeting as a guest by calling in to Zoom, using the links below. If you will be attending as a guest, please comment on this issue to let us know you'll be joining.

Notes

The agenda comes from issues labelled with outreach-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.

Joining the meeting

  • Link for participants: https://zoom.us/j/526318636
  • For those who just want to watch: https://www.youtube.com/nodejs-foundation

created time in 4 days

issue openednodejs/build

Node.js Build WorkGroup Meeting 2020-09-29

Time

UTC Tue 29-Sep-2020 12:00 (12:00 PM):

Timezone Date/Time
US / Pacific Tue 29-Sep-2020 05:00 (05:00 AM)
US / Mountain Tue 29-Sep-2020 06:00 (06:00 AM)
US / Central Tue 29-Sep-2020 07:00 (07:00 AM)
US / Eastern Tue 29-Sep-2020 08:00 (08:00 AM)
EU / Western Tue 29-Sep-2020 13:00 (01:00 PM)
EU / Central Tue 29-Sep-2020 14:00 (02:00 PM)
EU / Eastern Tue 29-Sep-2020 15:00 (03:00 PM)
Moscow Tue 29-Sep-2020 15:00 (03:00 PM)
Chennai Tue 29-Sep-2020 17:30 (05:30 PM)
Hangzhou Tue 29-Sep-2020 20:00 (08:00 PM)
Tokyo Tue 29-Sep-2020 21:00 (09:00 PM)
Sydney Tue 29-Sep-2020 22:00 (10:00 PM)

Or in your local time:

  • https://www.timeanddate.com/worldclock/fixedtime.html?msg=Node.js+Foundation+Build%20WorkGroup+Meeting+2020-09-29&iso=20200929T1200
  • or https://www.wolframalpha.com/input/?i=12PM+UTC%2C+Sep+29%2C+2020+in+local+time

Links

Agenda

Extracted from build-agenda labelled issues and pull requests from the nodejs org prior to the meeting.

nodejs/build

  • Onboarding build/infra members #2426
  • Platform Requirements for 15.x #2423
  • Request to join @nodejs/build-infra #2418

Invited

  • Build team: @nodejs/build

Observers/Guests

Notes

The agenda comes from issues labelled with build-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.

Joining the meeting

  • link for participants: https://zoom.us/j/715960833
  • For those who just want to watch: We stream our conference call straight to YouTube so anyone can listen to it live, it should start playing at https://www.youtube.com/c/nodejs+foundation/live when we turn it on. There's usually a short cat-herding time at the start of the meeting and then occasionally we have some quick private business to attend to before we can start recording & streaming. So be patient and it should show up.
  • youtube admin page: https://www.youtube.com/my_live_events?filter=scheduled

created time in 4 days

issue commentnodejs/build

Windows authenticode certification expiry

On with chat support at Digicert, seems we still need the verification process to support. They need to call the public number for the foundation. Unfortunately there was no answer when I tried, so suggested the leave a message to have them call back. Will ping Brian to hopefully make sure they know the context.

rvagg

comment created time in 5 days

pull request commentnodejs/TSC

doc: add onboarding step for pkgjs org

Sent invites to all existing TSC members who were not already org owners of the pkgjs org.

mhdawson

comment created time in 5 days

PR opened nodejs/TSC

doc: add onboarding step for pkgjs org

Refs: https://github.com/nodejs/admin/issues/470

Signed-off-by: Michael Dawson mdawson@devrus.com

+3 -0

0 comment

1 changed file

pr created time in 5 days

create barnchmhdawson/TSC

branch : pkgjs-add

created branch time in 5 days

issue closednodejs/node-addon-examples

inconsistent Napi::HandleScopes

Based on the documentation, a Napi::HandleScope at the top-level of a method is superfluous ("The lifespan for the default scope is tied to the lifespan of the native method call. The result is that, by default, handles remain valid and the objects associated with these handles will be held live for the lifespan of the native method call."). A few examples however use Napi::HandleScope or Napi::EscapableHandleScope in situations where their purpose is unclear:

All four of these use a HandleScope in their Init function, yet none of the other examples do. The first three use one in a constructor, yet neither function-reference-demo nor object-wrap-demo uses one in theirs. 7_factory_wrap uses an EscapableHandleScope in its NewInstance but 8_passing_wrapped does not. async_pi_estimate uses a HandleScope in its OnOK method but napi-asyncworker-example does not.

Since I think the documentation is not terribly clear on when a HandleScope is required, it is especially important that the examples are consistent about their usage. If there's a good reason to use one in any of these examples, it should be adorned by a comment explaining why a HandleScope is used there.

closed time in 5 days

mvduin

issue commentnodejs/node-addon-examples

inconsistent Napi::HandleScopes

Resolved by https://github.com/nodejs/node-addon-examples/pull/144, closing

mvduin

comment created time in 5 days

pull request commentnodejs/node-addon-examples

Move code that is necessary to run out of assert()

@twoi ping

twoi

comment created time in 5 days

pull request commentnodejs/node-addon-examples

remove wrapper_ from napi_wrap examples

@gabrielschulhof ping?

gabrielschulhof

comment created time in 5 days

issue commentnodejs/node-addon-examples

is NAN still the name of the game

I think https://github.com/nodejs/node-addon-examples/pull/156 will address this. It echo's what is in the N-API documentation.

ORESoftware

comment created time in 5 days

PR closed nodejs/node-addon-examples

just a nitpickin thing

nitpicking all day everyday

+7 -0

1 comment

1 changed file

ORESoftware

pr closed time in 5 days

pull request commentnodejs/node-addon-examples

just a nitpickin thing

Resolved by https://github.com/nodejs/node-addon-examples/pull/156, closing

ORESoftware

comment created time in 5 days

PR opened nodejs/node-addon-examples

doc: clarify focus is on n-api

Clarify that examples are primarily maintained for N-API and node-addon-api.

Signed-off-by: Michael Dawson mdawson@devrus.com

+6 -1

0 comment

1 changed file

pr created time in 5 days

create barnchmhdawson/node-addon-examples

branch : guidance

created branch time in 5 days

pull request commentnodejs/node-addon-examples

Simplify early examples and update README for NAN 2

This is quite old, and we don't have involvement on the NAN side for the examples at this point so I'm going to close this PR. Please comment/reopen if you don't think that is the right thing to do.

dfabulich

comment created time in 5 days

PR closed nodejs/node-addon-examples

example of code coverage

This is a separate example that shows how to collect coverage of the c++ code. Since the purpose is to demonstrate a build technique (not a coding technique) I just used the nan API for simplicity.

This PR will likely need some refinement to fit well with this repository.

+191 -0

3 comments

7 changed files

drewfish

pr closed time in 5 days

pull request commentnodejs/node-addon-examples

example of code coverage

Its been quite some time since there has been progress on this PR, closing. Please re-open if there is new work planned.

drewfish

comment created time in 5 days

pull request commentnodejs/node-addon-examples

added method wraps, and added v8::string for nan::new methods

This is quite old, and we don't have involvement on the NAN side for the examples at this point so I'm going to close this PR. Please comment/reopen if you don't think that is the right thing to do.

winfinit

comment created time in 5 days

pull request commentnodejs/node-addon-examples

added method wraps in 5th example

This is quite old, and we don't have involvement on the NAN side for the examples at this point so I'm going to close this PR. Please comment/reopen if you don't think that is the right thing to do.

winfinit

comment created time in 5 days

PR closed nodejs/node-addon-examples

wrapped method with NAN_METHOD for 4th example

added NAN_METHOD wrapper around 4th example

+1 -1

1 comment

1 changed file

winfinit

pr closed time in 5 days

pull request commentnodejs/node-addon-examples

wrapped method with NAN_METHOD for 4th example

This is quite old, and we don't have involvement on the NAN side for the examples at this point so I'm going to close this PR. Please comment/reopen if you don't think that is the right thing to do.

winfinit

comment created time in 5 days

PR closed nodejs/node-addon-examples

wrapped method with nan, and changed argument type in init call

updated 3rd example with nan method wrapper, and changed arguments in init function.

it would be nice if we can change this example all together, to use init wrapper, because target argument depends on this condition in nan

#if NODE_MODULE_VERSION < IOJS_3_0_MODULE_VERSION
  typedef v8::Handle<v8::Object> ADDON_REGISTER_FUNCTION_ARGS_TYPE;
#else
  typedef v8::Local<v8::Object> ADDON_REGISTER_FUNCTION_ARGS_TYPE;
#endif

but that would mean that you won't be able to do this in javascript:

var addon = require('bindings')('addon');

addon(function(msg){
  console.log(msg); // 'hello world'
});

but instead would have to expose your method by name, which would lead to this:

addon.myMethodName(function(msg){
//...
});

but this type of example would be more portable in my opinion.

+10 -5

1 comment

1 changed file

winfinit

pr closed time in 5 days

pull request commentnodejs/node-addon-examples

wrapped method with nan, and changed argument type in init call

This is quite old, and we don't have involvement on the NAN side for the examples at this point so I'm going to close this PR. Please comment/reopen if you don't think that is the right thing to do.

winfinit

comment created time in 5 days

PR closed nodejs/node-addon-examples

added nan_method and nan_module_init wrappers

added NAN_MODULE_INIT and NAN_METHOD wrap for second example

+6 -4

1 comment

1 changed file

winfinit

pr closed time in 5 days

pull request commentnodejs/node-addon-examples

added nan_method and nan_module_init wrappers

This is quite old, and we don't have involvement on the NAN side for the examples at this point so I'm going to close this PR. Please comment/reopen if you don't think that is the right thing to do.

winfinit

comment created time in 5 days

PR closed nodejs/node-addon-examples

updated first example with object wrappers

added NAN_MODULE_INIT and NAN_METHOD wrap for first example

+7 -5

1 comment

1 changed file

winfinit

pr closed time in 5 days

pull request commentnodejs/node-addon-examples

updated first example with object wrappers

This is quite old, and we don't have involvement on the NAN side for the examples at this point so I'm going to close this PR. Please comment/reopen if you don't think that is the right thing to do.

winfinit

comment created time in 5 days

pull request commentnodejs/node-addon-examples

Added HelloWorld example as requested

@theAkito are you still planning to work on this?

Misery42

comment created time in 5 days

more