profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/mgred/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

mgred/asciidoctor-action 3

An Action to use the Asciidoctor CLI

mgred/anpro 0

Anpro - Annotation Processor

mgred/barecolor 0

A tiny JavaScript utility for printing colorful console messages.

mgred/commons 0

Simple functions shared among the sinon end user libraries

mgred/compass 0

The Jekyll theme for your personal landing page.

mgred/conf.h 0

conf.h files for dwm and st

issue commentsinonjs/referee

Allow assert.rejects to take only one argument

This should work:

const { assert, match } = require('@sinonjs/referee');

await assert.rejects(Promise.reject('nope'), match.string);
BryanDonovan

comment created time in 3 hours

issue commentsinonjs/referee

Allow assert.rejects to take only one argument

I'd love to do a PR, but my company requires me to get legal approval, etc., which would take a while. Regarding the matcher, I can't seem to get it to work. Do you have an example?

BryanDonovan

comment created time in 4 hours

issue commentsinonjs/referee

Allow assert.rejects to take only one argument

Regarding matchers, I think you can already pass something like match(/foo/) as the second argument.

BryanDonovan

comment created time in 4 hours

issue commentsinonjs/referee

Allow assert.rejects to take only one argument

Yes, I agree that the second argument should be optional, as stated in the docs. This is a bug.

Would you care to send a PR with a fix?

BryanDonovan

comment created time in 4 hours

issue openedsinonjs/referee

Allow assert.rejects to take only one argument

The assert.rejects function currently requires a second argument, which much be identical to what the target function rejected with. This can be difficult to determine in many cases. It would be great if the second argument was optional (for what it's worth, the docs say the second param is optional here, but maybe these aren't up to date: https://sinonjs.github.io/referee/#rejects). Here's an example (using mocha) of how I'd like this to work:

const {assert} = require('@sinonjs/referee');

async function thrower() {
    throw new Error('foo');
}

describe("assert.reject", () => {
    it("does not require a second argument", async () => {
        await assert.rejects(thrower());
    });
});

Or perhaps it could follow the same api as assert.match(). Then I could do something like:

await assert.rejects(thrower(), /foo/);

created time in 5 hours

startedoctoherd/cli

started time in 2 days

PublicEvent

startedvitejs/vite

started time in 7 days

startedgoogle/eleventy-high-performance-blog

started time in 10 days

startedJonnyBurger/remotion

started time in 16 days

startedhmans/three-elements

started time in 24 days

started11ty/eleventy-img

started time in a month

push eventsinonjs/commons

Morgan Roderick

commit sha 2bec9fa5b5f3a741926c4ff5ed9dbc098bb52375

Add missing commit hook

view details

push time in a month

PR merged sinonjs/commons

Add missing commit hook
+5 -0

1 comment

1 changed file

mroderick

pr closed time in a month

push eventsinonjs/samsam

Morgan Roderick

commit sha ca676e418f8599275b50323f2c0b14b4a67dc732

Add configuration for commit hook

view details

push time in a month

pull request commentsinonjs/commons

Add missing commit hook

Codecov Report

Merging #81 (f559ea4) into master (70f48d0) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #81   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines           81        81           
=========================================
  Hits            81        81           
Flag Coverage Δ
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 70f48d0...f559ea4. Read the comment docs.

mroderick

comment created time in a month

PR opened sinonjs/commons

Reviewers
Add missing commit hook
+5 -0

0 comment

1 changed file

pr created time in a month

pull request commentsinonjs/samsam

Add configuration for commit hook

Codecov Report

Merging #215 (b9dab93) into master (da45fde) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #215   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines          512       512           
=========================================
  Hits           512       512           
Flag Coverage Δ
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da45fde...b9dab93. Read the comment docs.

mroderick

comment created time in a month

PR opened sinonjs/samsam

Reviewers
Add configuration for commit hook

<!-- Summary - mandatory

give a concise (one or two short sentences) description of what what problem is being solved by this PR

Example: Fix issue #123456 by re-structuring the colour selection conditional in method paintBlue -->

<!-- (Problem in detail) - optional -->

Background

<!--

When relevant, give a more thorough description of what the problem the PR is trying to solve. Examples of good topics for this section are:

  • Link to an existing GitHub issue describing the problem
  • Describing the problem in greater detail than the TL;DR section above
  • How you discovered the issue, if it's not already described as an issue on GitHub
  • Discussion of different approaches to solving this problem and why you chose your proposed solution -->

<!-- (Solution in detail) - optional -->

Solution

<!--

When contributing code (and not just fixing typos, documentation and configuration), please describe why/how your solution works. This helps reviewers spot any mistakes in the implementation.

Example: "This solution works by adding a paintBlue() method" Then your reviewer might spot a mistake in the implementation, if paintBlue() uses the colour red. -->

<!-- mandatory -->

How to verify

  1. Check out this branch
  2. npm ci
  3. <your-steps-here>
+5 -0

0 comment

1 changed file

pr created time in a month

push eventsinonjs/commons

Morgan Roderick

commit sha 70f48d0c841862df8c4842f0d2ac5caea09c528c

Drop Node 8 And run tests in Node 14, the current LTS release

view details

push time in a month

PR merged sinonjs/commons

Drop Node 8

And run tests in Node 14, the current LTS release

+12 -12

1 comment

1 changed file

mroderick

pr closed time in a month

pull request commentsinonjs/commons

Drop Node 8

Codecov Report

Merging #80 (288bcc1) into master (7aa37d2) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #80   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines           81        81           
=========================================
  Hits            81        81           
Flag Coverage Δ
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7aa37d2...288bcc1. Read the comment docs.

mroderick

comment created time in a month

PR opened sinonjs/commons

Reviewers
Drop Node 8

And run tests in Node 14, the current LTS release

+12 -12

0 comment

1 changed file

pr created time in a month

push eventsinonjs/commons

Morgan Roderick

commit sha 7aa37d232694de0e9fc4a3b3fb457696798a4b91

Use prettier@2 And format the files

view details

push time in a month

PR merged sinonjs/commons

Use prettier@2

And format the files

+132 -111

1 comment

8 changed files

mroderick

pr closed time in a month

pull request commentsinonjs/commons

Use prettier@2

Codecov Report

Merging #79 (585bd27) into master (5d6a5b1) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #79   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines           81        81           
=========================================
  Hits            81        81           
Flag Coverage Δ
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d6a5b1...585bd27. Read the comment docs.

mroderick

comment created time in a month

PR opened sinonjs/commons

Reviewers
Use prettier@2

And format the files

+132 -111

0 comment

8 changed files

pr created time in a month

push eventsinonjs/referee

Morgan Roderick

commit sha 67539d90f3dca933b71125249be857a52d14cc08

Improve prettier integration And remove unused plugins

view details

Morgan Roderick

commit sha 52c58a546cfff423dac153e0f20b1052e0c0cdc1

Format files with prettier@2

view details

push time in a month

PR merged sinonjs/referee

Improve prettier integration

As done with https://github.com/sinonjs/sinon/pull/2324

+445 -406

2 comments

11 changed files

mroderick

pr closed time in a month

push eventsinonjs/samsam

Morgan Roderick

commit sha c69ec47e4dc56c7639662e4283b750c0a5a0b64d

Use prettier@2

view details

Morgan Roderick

commit sha a8a5a68584066b87a3d08cb9f97da7a298edba8e

Format files with prettier@2

view details

Morgan Roderick

commit sha da45fde24f791c19719cfa5280e87dff5584d3a4

Run prettier:check in CI

view details

push time in a month