profile
viewpoint
Matteo Collina mcollina @nearform In the clouds above Italy Technical Director @nearform, TSC member @nodejs, IoT Expert, Conference Speaker, Ph.D.

davidmarkclements/0x 1711

🔥 single-command flamegraph profiling 🔥

delvedor/find-my-way 598

A crazy fast HTTP router

davidmarkclements/v8-perf 246

Exploring v8 performance characteristics in Node across v8 versions 5.1, 5.8, 5.9, 6.0 and 6.1

davidmarkclements/fast-safe-stringify 185

Safely and quickly serialize JavaScript objects

davidmarkclements/overload-protection 150

Load detection and shedding capabilities for http, express, restify and koa

davidmarkclements/fast-redact 128

very fast object redaction

andreareginato/conference_site 24

A conference site that can be used for your next big event

davidmarkclements/proffer 11

Realtime V8 Tick Profiler

startedmicrosoft/playwright

started time in 2 hours

pull request commentmoscajs/aedes

fix: Memory leak on client.js 'connected' event #348

please wait for a bit

robertsLando

comment created time in 4 hours

issue commentfastify/fastify-compress

Fastify post requests

This module only works for routes, not for middlewares like postgraphile. Unfortunately there is no real solution for this atm.

You'll need to develop something like https://github.com/mshick/hapi-postgraphile on top of https://github.com/mcollina/fastify-gql

hengnee

comment created time in 4 hours

pull request commentmqttjs/MQTT.js

feature: add secureOptions to ISecureClientOptions for TLS

Please open this again. I rebased it out however CI was failing badly.

YoDaMa

comment created time in 4 hours

push eventmqttjs/MQTT.js

push time in 4 hours

push eventmqttjs/MQTT.js

Matteo Collina

commit sha 8187a82e06703e78818b11f123264789b9bf2acc

bumped v3.0.1

view details

push time in 5 hours

push eventmqttjs/MQTT.js

Matteo Collina

commit sha a42254aab81932d96c0fa9a003ee8b1add3eb238

fix linting

view details

push time in 5 hours

push eventmqttjs/MQTT.js

Yoseph Maguire

commit sha a31cdc2aa2c855fb376242d5e2f6a2363f43fc9a

feature: add secureOptions to ISecureClientOptions for TLS (#1029) * adding secureOptions * small o * secureContext * reword * adding a test

view details

push time in 5 hours

PR merged mqttjs/MQTT.js

feature: add secureOptions to ISecureClientOptions for TLS

This PR addresses adding secureOptions to ISecureClientOptions. This addition gives the interface the ability to accept secureOptions for TLS, including TLS version enforcement and cipher suite lists.

MQTT over TLS does not currently support adding TLS secureOptions on connect, so this is a new that improves our ability to control security on the MQTT client..

+30 -2

1 comment

2 changed files

YoDaMa

pr closed time in 5 hours

pull request commentmoscajs/aedes

fix: Memory leak on client.js 'connected' event #348

The code is ok, the test on the EventEmitter warning is missing

robertsLando

comment created time in 5 hours

push eventmoscajs/mosca

Daniel Lando

commit sha 17542ae861df1f11a6e066b693fb67beb9b81843

Unmaintained redirect to aedes

view details

Matteo Collina

commit sha 46945d696c3a9a8ce03ee215a8892cc0fa53e458

Merge pull request #811 from moscajs/robertsLando-patch-1 Unmaintained redirect to aedes

view details

push time in 6 hours

PR merged moscajs/mosca

Unmaintained redirect to aedes
+2 -0

0 comment

1 changed file

robertsLando

pr closed time in 6 hours

Pull request review commentmoscajs/aedes

fix: Memory leak on client.js 'connected' event #348

 function Client (broker, conn, req) {    this.connDetails = null +  // queue packets received before client fires 'connect' event. Prevents memory leaks on 'connect' event+  this.parser._queue = []++  this.on('connected', dequeue)
  this.once('connected', dequeue)
robertsLando

comment created time in 6 hours

Pull request review commentmoscajs/aedes

fix: Memory leak on client.js 'connected' event #348

 function Client (broker, conn, req) {    this.connDetails = null +  // queue packets received before client fires 'connect' event. Prevents memory leaks on 'connect' event+  this.parser._queue = []++  this.on('connected', dequeue)++  function dequeue () {+    var q = this.parser._queue+    for (var i = 0, len = q.length; i < len; i++) {+      handle(this, q[i], this._nextBatch)+    }++    this.parser._queue = null+  }

Please make this top-level, outside of this function.

robertsLando

comment created time in 6 hours

issue commentmoscajs/aedes

[feat] Extend Aedes tests against all mqemitter/persistences

Integration/black box test.

Start an external aedes broker and use MQTT.js to validate it works.

robertsLando

comment created time in 7 hours

issue commentmoscajs/aedes

[feat] Aedes as a standalone service

Done https://github.com/moscajs/aedes-cli

robertsLando

comment created time in 7 hours

create barnchmoscajs/aedes-cli

branch : master

created branch time in 7 hours

created repositorymoscajs/aedes-cli

created time in 7 hours

Pull request review commentmoscajs/aedes

fix: Memory leak on client.js 'connected' event #348

 function Client (broker, conn, req) {    this.connDetails = null +  // queue packets received before client fires 'connect' event. Prevents memory leaks on 'connect' event+  this.parser._queue = []++  this.on('connected', () => {+    while (this.parser._queue.length > 0) {+      handle(this, this.parser._queue.shift(), this._nextBatch)+    }

Instead of calling shift() just use a for(;;) loop and then assign this.parser._queue to null.

robertsLando

comment created time in 7 hours

Pull request review commentmoscajs/aedes

fix: Memory leak on client.js 'connected' event #348

 function Client (broker, conn, req) {    this.connDetails = null +  // queue packets received before client fires 'connect' event. Prevents memory leaks on 'connect' event+  this.parser._queue = []++  this.on('connected', () => {
  this.once('connected', () => {
robertsLando

comment created time in 7 hours

Pull request review commentmoscajs/aedes

fix: Memory leak on client.js 'connected' event #348

 function Client (broker, conn, req) {    this.connDetails = null +  // queue packets received before client fires 'connect' event. Prevents memory leaks on 'connect' event+  this.parser._queue = []++  this.on('connected', () => {+    while (this.parser._queue.length > 0) {+      handle(this, this.parser._queue.shift(), this._nextBatch)+    }+  })

Can you please use a top level function for this listener instead of a closure?

robertsLando

comment created time in 7 hours

delete branch fastify/fastify

delete branch : add-http2-session-timeout

delete time in 7 hours

push eventfastify/fastify

Matteo Collina

commit sha d0c976e82549488ecd27c17421cd3b51264468de

http2: handle graceful close (#2050) * http2: handle graceful close This commit adds an option http2SessionTimeout to be able to gracefully closing an http2 server. This is analogous to the 5000ms timeout of keepalive connections. * Added timeout event test

view details

push time in 7 hours

PR merged fastify/fastify

http2: handle graceful close semver-minor v2.x v3.x

This commit adds an option http2SessionTimeout to be able to gracefully closing an http2 server. This is analogous to the 5000ms timeout of keepalive connections.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Tip: npm run bench to compare branches interactively.

Contributors guide: https://github.com/fastify/fastify/blob/master/CONTRIBUTING.md -->

Checklist

  • [x] run npm run test and npm run benchmark
  • [x] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message and code follows Code of conduct
+120 -9

0 comment

8 changed files

mcollina

pr closed time in 7 hours

push eventfastify/fastify-accepts

Dmitrii

commit sha 8129b242d0a23c50ee373872c80d9c2f101b9898

add typescript typings (#54) * add typescript typings * extend fastify request with accepts typings * add compile test * remove obsolete after callback

view details

push time in 7 hours

PR merged fastify/fastify-accepts

add typescript typings

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Tip: npm run bench to compare branches interactively.

Contributors guide: https://github.com/fastify/fastify/blob/master/CONTRIBUTING.md -->

Checklist

  • [x] run npm run test and npm run benchmark
  • [x] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message and code follows Code of conduct
+125 -3

3 comments

4 changed files

dimonnwc3

pr closed time in 7 hours

pull request commentnodejs/node

stream: async iterator improvements

It seems this is consistently failing on ARM. @Trott can you take a look?

ronag

comment created time in 7 hours

pull request commentmoscajs/aedes

[WIP] Github actions for cross persistence/mqemitter tests #357

I don't think so. The current tests are too tied and this adds unnecessary complexity.

robertsLando

comment created time in 7 hours

issue commentmoscajs/aedes

[feat] Aedes as a standalone service

Can’t you? Il 23 gen 2020, 14:01 +0100, Daniel Lando notifications@github.com, ha scritto:

@mcollina Could you start another repo called aedes-cli? I think this is the best option — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

robertsLando

comment created time in 8 hours

pull request commentdavidmarkclements/fast-safe-stringify

Ads BigInt support

Seems good, thanks!

pixtron

comment created time in 8 hours

issue commentmoscajs/aedes

[feat] server side triggered subscriptions for clients

I think this is already there Il 23 gen 2020, 13:47 +0100, Daniel Lando notifications@github.com, ha scritto:

@mcollina Is this a feature that needs to be added? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

behrad

comment created time in 8 hours

issue closedmoscajs/aedes

Management methods

Implement more instance functions

  • aedes.instances(): returns current running brokers list
  • aedes.isConnected(clientId): returns if a clientId is currently connected to any aedes instance or not (all aedes instance can currently keep track of connected clientIds)

closed time in 8 hours

behrad

Pull request review commentfastify/fastify

http2: handle graceful close

 t.test('http/2 request while fastify closing - return503OnClosing: false', t =>     t.end()   }) })++// Skipped because there is likely a bug on Node 8.+t.test('http/2 closes successfully with async await', { skip: semver.lt(process.versions.node, '10.15.0') }, async t => {

done

mcollina

comment created time in 9 hours

push eventfastify/fastify

Matteo Collina

commit sha ef03dcba228c0795d1704b8709ded442f40ba4b3

Added timeout event test

view details

push time in 9 hours

issue commentmoscajs/aedes

instance.subscribe match $SYS topic

no clue

Il giorno gio 23 gen 2020 alle ore 12:26 Daniel Lando < notifications@github.com> ha scritto:

@mcollina https://github.com/mcollina Has this been fixed?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/moscajs/aedes/issues/221?email_source=notifications&email_token=AAAMXY7FOKAZM3U5LXRYUFDQ7F5GZA5CNFSM4GDEJ5KKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJXBWRA#issuecomment-577641284, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMXY6KFPTYQ3WCXDGFS3LQ7F5GZANCNFSM4GDEJ5KA .

nuhamind2

comment created time in 10 hours

issue commentmoscajs/aedes

Custom Error class and use enum to replace error message

sure thing, yes.

gnought

comment created time in 10 hours

issue closedmcollina/sonic-boom

missing source code of 0.7.6

Hi! In npm the last version is 0.7.6, but the last version in the repo is 0.7.5. can you push the source code?

closed time in 10 hours

jfgodoy

issue commentmcollina/sonic-boom

missing source code of 0.7.6

Pushed, sorry for this.

jfgodoy

comment created time in 10 hours

issue commentmcollina/sonic-boom

missing source code of 0.7.6

Thanks!

jfgodoy

comment created time in 10 hours

push eventmcollina/hyperid

Matteo Collina

commit sha eca6f803cf4af1886d0be12eda704c7f93b6e6bc

Updated benchmarks

view details

push time in 11 hours

push eventmcollina/sonic-boom

Matteo Collina

commit sha c241e88997597cf2bba08265e9b4404293f38830

Bumped v0.7.6

view details

push time in 11 hours

issue commentmoscajs/aedes

[feat] Extend Aedes tests against all mqemitter/persistences

yes, definitely!

Il giorno gio 23 gen 2020 alle ore 10:30 Daniel Lando < notifications@github.com> ha scritto:

Ignore my PR so. WIll wait you to start a different repo for them. I think the actions.yml code can be taken as a base for actions (or not) ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/moscajs/aedes/issues/357?email_source=notifications&email_token=AAAMXY27ZVP2UBSL2IXUZSTQ7FPS7A5CNFSM4KKIU4IKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJWXMVQ#issuecomment-577599062, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMXYYI6UIIT4L2FNREMPLQ7FPS7ANCNFSM4KKIU4IA .

robertsLando

comment created time in 12 hours

pull request commentmoscajs/aedes

[WIP] Github actions for cross persistence/mqemitter tests #357

Not a rewrite, new tests.

robertsLando

comment created time in 12 hours

issue commentnodejs/node

discussion: can http-parser be replaced with llhttp in LTS (10.x and 12.x)?

I'm +1 with a deprecation warning that includes the cutoff date and --insecure-http-parser.

sam-github

comment created time in 12 hours

issue commentmoscajs/aedes

[feat] Extend Aedes tests against all mqemitter/persistences

I would prefer a very different approach.

Having some tests that use mqtt.js to connect to Aedes and very some of the basic functionality. Most of the tests here are unit and they expect things to run single-process.

robertsLando

comment created time in 12 hours

pull request commentmoscajs/aedes

[WIP] Github actions for cross persistence/mqemitter tests #357

Most of the tests are unit. We need a new batch of tests that works treating aedes as a black box.

IMHO, I'd place them in another repo.

robertsLando

comment created time in 12 hours

issue commentmoscajs/aedes

[feat] Aedes as a standalone service

I would say so, Mosca is currently dead.

robertsLando

comment created time in 13 hours

pull request commentfastify/fastify

Validation and serialization

This should significantly improve our cold start time on serverless, definitely +1.

Eomm

comment created time in 13 hours

issue commentmcollina/autocannon

Request multipart/form-data

I would recommend to open new issues for bug reports.

mrbatista

comment created time in 13 hours

issue commentmoscajs/aedes

[feat] Aedes as a standalone service

Yes, that's what I was trying to say. Remove all code from Mosca and replace the internals with Aedes, adding a CLI and an Authorizer.

robertsLando

comment created time in 13 hours

pull request commentdavidmarkclements/fast-safe-stringify

Ads BigInt support

Can you post the benchmark results?

pixtron

comment created time in 13 hours

issue commentmcollina/undici

Perpetually attempts reconnecting on socket error

I think we should improve the API with a few caveats:

  1. a max number of retries for reconnects that will emit an error on the client itself, so we can potentially let the application do something.
  2. an offline event, so that the app can do something
  3. make the requests error after a timeout
doesdev

comment created time in 14 hours

pull request commentnodejs/node

events: add type check for event name

I’m +1 if it does not cause a perf regression to the eventemitter, http, and streams benchmarks.

Flarna

comment created time in 14 hours

issue commentpinojs/pino-elasticsearch

Question: index mapping creation

After getting to know ElasticSearch mappings, I would as well. Go ahead with the PR. Il 22 gen 2020, 22:02 +0100, Manuel Spigolon notifications@github.com, ha scritto:

I had the chance to understand better the case:

• the code I linked send the logs to elastic, it doesn't create the index • elastic, cause doesn't have the index of the day, create a new index with the default settings and it will index all the things

The logic I would apply in this module would be: if the user specified a custom mapping

• at startup create the index and ignore the error index already create • if the user define the %{DATE} index's name, schedule a timeout to create the next index (or "when the generated index name has changed, create it then continue logging")

Am I the only one that would like to apply a different mapping than the default? 🤔 😅 — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

Eomm

comment created time in a day

issue commentmcollina/undici

Perpetually attempts reconnecting on socket error

If you find the root cause, please send a PR!

doesdev

comment created time in a day

issue commentmoscajs/aedes

[feat] Aedes as a standalone service

My view of Mosca is to be “aedes standalone”, with a CLI and everything.

robertsLando

comment created time in a day

issue commentmoscajs/aedes

Project development status

Why this? What about to make mosca unmantained (like it is from 2018) and redirect users to use aedes instead?

Mosca provides an out-of-the-box experiece with all the dependencies. I'm also happy to mark that unmaintained. Moreover, we should also add some integration tests that are currently missing. In my original ideas those would live inside Mosca, but they can also live in another repo.

Here is the authorizer https://github.com/moscajs/mosca/blob/master/lib/authorizer.js and docs are in https://github.com/moscajs/mosca/wiki/Authentication-&-Authorization#using-moscas-standalone-authorizer-with-an-embedded-mosca.

robertsLando

comment created time in a day

issue closedfastify/fastify-cli

Security vulnerability in the chokidar@2 dependency chain

🐛 Bug Report

chokidar@2 depends on a vulnerable dependency as defined in https://app.snyk.io/org/mcollina/project/77093841-f46e-47c6-ae49-548b8c809106?utm_campaign=weekly_report&utm_source=Project&fromGitHubAuth=true.

Chokidar@3 requires Node 8 as a minimum version. I've already sent a PR to pino-colada to update it https://github.com/lrlna/pino-colada/pull/33.

Proposal

I propose we drop Node 6 and update chokidar@3 and release a new major. We can also update some other dependencies, and potentially drop Node 10 as well.

The other option is to do nothing, as chokidar should only be used during dev and it really as no risk - however there is no way to mark this as "safe" in npm audit.

(Lesson for ourselves, we should have shipped Fastify@2 without the support for Node 6 - my fault)

closed time in a day

mcollina

issue commentfastify/fastify-cli

Security vulnerability in the chokidar@2 dependency chain

Closing, our dependency tree is not vulnerable at all, the vuln database had the wrong range.

mcollina

comment created time in a day

issue commentjonschlinkert/kind-of

Security vulnerability backport to 3.x line.

Actually, it's already fixed.

mcollina

comment created time in a day

issue closedjonschlinkert/kind-of

Security vulnerability backport to 3.x line.

Chokidar@2 depends on this module in version 3.x. It would be great to release the security fix to this line, so that Chokidar@2 is not vulnerable anymore.

I think the security fix is https://github.com/jonschlinkert/kind-of/commit/975c13a7cfaf25d811475823824af3a9c04b0ba8. Is this the only thing?

I'm happy to do the PR to backport the change if you cut me a 3.x branch

closed time in a day

mcollina

issue commentjonschlinkert/kind-of

Security vulnerability backport to 3.x line.

Let me know once the db is updated.

mcollina

comment created time in a day

issue commentjonschlinkert/kind-of

Security vulnerability backport to 3.x line.

That dependency tree uses kind-of@3.2.2 and kind-of@5.1.0, so I think we should be good.

mcollina

comment created time in a day

issue commentmoscajs/aedes

Project development status

Would you like to craft one? From my point of view:

[ ] update Mosca so that is based on Aedes and mqemitter (this means a full rewrite of the codebase) [ ] use github action to test all the persistences / mqemitter on separate processes to avoid limits of the databases [ ] implement the authorizer. [ ] closing all issues and PRs that are outstanding

On top of this, we should work on adding MQTTv5 as a long term activity

robertsLando

comment created time in a day

issue commentjonschlinkert/kind-of

Security vulnerability backport to 3.x line.

@lirantal can you help?

mcollina

comment created time in a day

issue commentmoscajs/aedes

Project development status

Would you like to be added to the org?

robertsLando

comment created time in a day

issue commentfastify/fastify-cli

Security vulnerability in the chokidar@2 dependency chain

I've also asked the module to be updated so we do not have the security fix: https://github.com/jonschlinkert/kind-of/issues/33.

mcollina

comment created time in a day

issue openedjonschlinkert/kind-of

Security vulnerability backport to 3.x line.

Chokidar@2 depends on this module in version 3.x. It would be great to release the security fix to this line, so that Chokidar@2 is not vulnerable anymore.

I think the security fix is https://github.com/jonschlinkert/kind-of/commit/975c13a7cfaf25d811475823824af3a9c04b0ba8. Is this the only thing?

I'm happy to do the PR to backport the change if you cut me a 3.x branch

created time in a day

issue commentfastify/fastify-cli

Security vulnerability in the chokidar@2 dependency chain

Note that moving from pino-colada to pino-pretty as defined in #214 solves only part of the problem.

mcollina

comment created time in a day

issue openedfastify/fastify-cli

Security vulnerability in the chokidar@2 dependency chain

🐛 Bug Report

chokidar@2 depends on a vulnerable dependency as defined in https://app.snyk.io/org/mcollina/project/77093841-f46e-47c6-ae49-548b8c809106?utm_campaign=weekly_report&utm_source=Project&fromGitHubAuth=true.

Chokidar@3 requires Node 8 as a minimum version. I've already sent a PR to pino-colada to update it https://github.com/lrlna/pino-colada/pull/33.

Proposal

I propose we drop Node 6 and update chokidar@3 and release a new major. We can also update some other dependencies, and potentially drop Node 10 as well.

The other option is to do nothing, as chokidar should only be used during dev and it really as no risk - however there is no way to mark this as "safe" in npm audit.

(Lesson for ourselves, we should have shipped Fastify@2 without the support for Node 6 - my fault)

created time in a day

PR opened lrlna/pino-colada

Updated dependencies, drop old node support (8+ now)

chokidar@2 depends on a vulnerable dependency as defined in https://app.snyk.io/org/mcollina/project/77093841-f46e-47c6-ae49-548b8c809106?utm_campaign=weekly_report&utm_source=Project&fromGitHubAuth=true.

In the process of updating chokidar, I've updated most of the dependencies (minus Merry, as it does not log by default anymore) because I thought it was handy.

This change in semver-major as the minimum version of Node.js needed by chokidar is 8.

+32 -37

0 comment

3 changed files

pr created time in a day

create barnchmcollina/pino-colada

branch : update-deps

created branch time in a day

create barnchmcollina/pino-colada

branch : old-master

created branch time in a day

issue closedfastify/fastify-compress

brotli compress

Hello, then i use compress brotli content encoding in browser gz

closed time in a day

borodadada

issue commentfastify/fastify-compress

brotli compress

This module does not offer caching for compressed files, and it will compress the file each time it is read. Given that brotli provides better compression, I would expect that it takes longer to compress.

I would recommend to use nginx in front of your Node.js process, as it's an overall better solution for serving files.

borodadada

comment created time in a day

issue commentfastify/fastify-compress

brotli compress

It would work automatically on recent Node.js, see https://github.com/fastify/fastify-compress/blob/c99f2fab776f0b9139e33f2fdc374be57ef5c29c/index.js#L86.

Is this not working for you?

borodadada

comment created time in 2 days

issue closedfastify/fastify

static js files to gzip

Hello, i try use webpack comression, output gzip files.

link rel="preload" href="/dist/4.52e140b28097204e4353.chunk.js" as="script"

js files work, gzip not

image https://ibb.co/3c45HQM Webpack created two variants file, js and compressed sometimes size 1/3 from original, greate time economy

i think this is it 1 "The NginxHttpGzipStaticModule is enabled by adding gzip_static on; to the nginx.conf" 2 https://www.npmjs.com/package/express-static-gzip 3 https://github.com/koajs/static

This is server support? Not client?

how i can enable this?

closed time in 2 days

borodadada

issue commentfastify/fastify

static js files to gzip

compression is enable automatically with fastify-static if the browser supports it, you do no have to do anything.

borodadada

comment created time in 2 days

pull request commentnodejs/node

http: decode username and password before encoding

I think this PR should also change the docs: https://nodejs.org/api/url.html#url_url_username.

Technically this can be seen as a patch or semver-major change, and I'm uncertain between the two.

addaleax

comment created time in 2 days

created tagfastify/fastify-http-proxy

tagv3.0.0

Proxy your http requests to another server, with hooks.

created time in 2 days

release fastify/fastify-http-proxy

v3.0.0

released time in 2 days

push eventfastify/fastify-http-proxy

Matteo Collina

commit sha 4f0f207c7a3f2cdfbeb00c9b054a280b227b4b92

Bumped v3.0.0

view details

push time in 2 days

delete branch fastify/fastify-http-proxy

delete branch : update-deps

delete time in 2 days

push eventfastify/fastify-http-proxy

Matteo Collina

commit sha 8097d068f037531f85f7d938cf21634322f1421f

Updated deps, droppped Node 8 (#77)

view details

push time in 2 days

PR merged fastify/fastify-http-proxy

Updated deps, droppped Node 8

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Tip: npm run bench to compare branches interactively.

Contributors guide: https://github.com/fastify/fastify/blob/master/CONTRIBUTING.md -->

Checklist

  • [x] run npm run test and npm run benchmark
  • [x] tests and/or benchmarks are included
  • [x] commit message and code follows Code of conduct
+11 -50

2 comments

3 changed files

mcollina

pr closed time in 2 days

issue commentopenjs-foundation/cross-project-council

Kicking off an OpenJS Foundation project landscape

@brianwarner Fastify is missing. Where may I send a PR to?

brianwarner

comment created time in 2 days

issue commentpinojs/pino-elasticsearch

Question: index mapping creation

Would a flag to avoid adding the mapping be enough then?

Eomm

comment created time in 2 days

Pull request review commentfastify/fastify-accepts

add typescript typings

+import fastify from "fastify"+import accepts from "./"++const app = fastify()++app.register(accepts).after(() => {

there is no need to use after here.

dimonnwc3

comment created time in 2 days

issue commentfastify/fastify

static js files to gzip

I don't understand what you are trying to achieve and what is the problem.

If I understand correctly, using https://github.com/fastify/fastify-static should solve your problem.

borodadada

comment created time in 2 days

issue commentnodejs/node

discussion: can http-parser be replaced with llhttp in LTS (10.x and 12.x)?

Quick errata: 10.x will go EOL on April 2021, while 12.x will go EOL on April 2022.

From my experience in dealing with production system, this seems a very dangerous proposition for our backward compatibility story. Changing the http parser is a breaking change, and the TSC can decide to ship a breaking change in LTS if we think it is important.

I am +1 in removing http-parser from 12.x with the introduction of --insecure-http-parser, as it seems to have fixed most of the issues in the migration. Removing it from 12.x will shorten our support window by one year, and I think it'd be a good compromise.

I'm more conflicted about what to do with 10.x. Do --insecure-http-parser have the same quirks of http-parser? In case, can we consider shipping llhttp with --insecure-http-parser turned on in v10.x?

sam-github

comment created time in 2 days

push eventfastify/fastify

Alessandro Magionami

commit sha af8a6ac5fc88f92731280b74e69ae6fb4b10d666

docs: inject chainable methods (#1917) (#2043) * docs: inject chainable methods (#1917) * docs: code review changes (#1917)

view details

push time in 2 days

PR merged fastify/fastify

docs: inject chainable methods (#1917) documentation

Added a reference to chainable methods on 'inject' function based on the update of 'light-my-request'

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Tip: npm run bench to compare branches interactively.

Contributors guide: https://github.com/fastify/fastify/blob/master/CONTRIBUTING.md -->

Checklist

  • [x] run npm run test and npm run benchmark
  • [x] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message and code follows Code of conduct
+13 -0

5 comments

1 changed file

alemagio

pr closed time in 2 days

pull request commentfastify/fastify-http-proxy

Updated deps, droppped Node 8

I'll bump twice, it's just an integer. Il 21 gen 2020, 19:42 +0100, Manuel Spigolon notifications@github.com, ha scritto:

@Eomm approved this pull request. Should we wait fastify v3 for this major release or will bump twice? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

mcollina

comment created time in 2 days

issue commentmoscajs/aedes

Use reusify for client enqueue

I don't see how, there is very little state involved

robertsLando

comment created time in 2 days

startedyosuke-furukawa/node-jsonnet

started time in 2 days

Pull request review commentmoscajs/aedes

Updated Readme

 You can subscribe on the following `$SYS` topics to get client presence:  - `$SYS/+/disconnect/clients` - will inform about client disconnections. The payload will contain the `clientId` of the connected/disconnected client +## Plugins

ok

robertsLando

comment created time in 2 days

pull request commentfastify/fastify-http-proxy

Updated deps, droppped Node 8

yes! All of this solves some issues with http2 that it was not really possible to fix with the implementation that were in Node 8. Il 21 gen 2020, 13:26 +0100, James Sumners notifications@github.com, ha scritto:

@jsumners approved this pull request. LGTM This will be released as a new major, right? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

mcollina

comment created time in 2 days

startedantirez/disque-module

started time in 2 days

Pull request review commentmoscajs/aedes

Updated Readme

 You can subscribe on the following `$SYS` topics to get client presence:  - `$SYS/+/disconnect/clients` - will inform about client disconnections. The payload will contain the `clientId` of the connected/disconnected client +## Plugins
## Persistences
robertsLando

comment created time in 2 days

Pull request review commentmoscajs/aedes

Updated Readme

 You can subscribe on the following `$SYS` topics to get client presence:  - `$SYS/+/disconnect/clients` - will inform about client disconnections. The payload will contain the `clientId` of the connected/disconnected client +## Plugins++- [aedes-persistence](https://github.com/moscajs/aedes-persistence): In-memory implementation of an Aedes persistence+  - [aedes-persistence-mongodb](https://github.com/moscajs/aedes-persistence-mongodb): MongoDB persistence for Aedes+  - [aedes-persistence-redis](https://github.com/moscajs/aedes-persistence-redis): Redis persistence for Aedes+  - [aedes-persistence-level](https://github.com/moscajs/aedes-persistence-level): LevelDB persistence for Aedes+  - [aedes-persistence-nedb](https://github.com/ovhemert/aedes-persistence-nedb#readme): NeDB persistence for Aedes+- [aedes-logging](https://github.com/moscajs/aedes-logging): Logging module for Aedes, based on Pino+- [aedes-stats](https://github.com/moscajs/aedes-stats): Stats for Aedes

We should probably include links to the mqemitter equivalents as well.

robertsLando

comment created time in 2 days

more