profile
viewpoint

mbrubeck/android-completion 209

Bash completion for "adb" from the Google Android SDK

mbrubeck/agate 27

Very simple server for the Gemini hypertext protocol

mbrubeck/by_address 12

Rust wrapper type that implements hashing and comparison by pointer address

mbrubeck/c-repl 4

a C read-eval-print loop

mbrubeck/bugwd 2

Readable, memorable URLs to replace long bug numbers

mbrubeck/2048-AI 0

A simple AI for 2048

mbrubeck/actix 0

Actor framework for Rust

mbrubeck/advisory-db 0

Security advisory database for Rust crates published through crates.io

push eventmbrubeck/rust-smallvec

Matt Brubeck

commit sha 592fc5a0e8666f4b29ba7f49cbf027a7d525ba69

Add SmallVec::append method Fixes #236.

view details

push time in 7 days

push eventmbrubeck/rust-smallvec

Matt Brubeck

commit sha 2bd455ba088fdc3373788b54f9c501e1795d8ab9

Add SmallVec::append method Fixes #236.

view details

push time in 7 days

push eventmbrubeck/rust-smallvec

Matt Brubeck

commit sha db528547b67a9ac051e8af28536d5e975f187def

Add SmallVec::append method Fixes #236.

view details

push time in 8 days

PR opened servo/rust-smallvec

Add SmallVec::append method

Fixes #236.

Also adds PartialEq impls between SmallVec and slice, which is used in the tests here and should also be useful in user code.

+39 -0

0 comment

1 changed file

pr created time in 8 days

create barnchmbrubeck/rust-smallvec

branch : append

created branch time in 8 days

push eventmbrubeck/nix

Matt Brubeck

commit sha 8a9c5346868e2c4cc4899bf906325b5aa0169528

Update to cfg-if 1.0

view details

push time in 13 days

push eventmbrubeck/log

Matt Brubeck

commit sha 14335ec8890f957ade7dc82fcac4f3cbbfec3ece

Remove broken const_type_id feature The `const_type_id` feature was planned to stabilize in Rust 1.47, but this was reverted in: https://github.com/rust-lang/rust/pull/77083 This causes errors when building `log` with the `kv_unstable` feature on Rust 1.47 or later. This patch removes the use of this no-longer-stable feature in those Rust versions.

view details

Ashley Mannix

commit sha dec098261819771ae1f22cd85f306ec71f23fd85

remove dependency on reverted const type id

view details

Ashley Mannix

commit sha 7a42b0562f89c8598a9c7b7fcd7eefff0c9f8509

Merge pull request #419 from rust-lang/KodrAus-patch-1 remove dependency on reverted const type id

view details

Ashley Mannix

commit sha 14d7303f19185240f69b9fe696073e40c5299d73

Merge pull request #418 from mbrubeck/const Remove use of unstable const_type_id feature (fixes CI failures on 1.47+)

view details

Matt Brubeck

commit sha b6438b9b1191179e407552cf834df67f9dcd6466

Update to cfg-if 1.0

view details

push time in 13 days

PR opened rust-lang/log

Remove use of unstable const_type_id feature

The const_type_id feature was planned to stabilize in Rust 1.47, but this was reverted in rust-lang/rust#77083.

This causes errors when building log with the kv_unstable feature on Rust 1.47 or later. Because of this, the beta and nightly builds are currently broken in CI on master.

This patch simply removes the code that uses this feature because it is not clear if it will be stabilized in its current form. Alternately, the code could be kept around behind a second nightly-only Cargo feature if there are still plans to work on it. CC @KodrAus who added this code in #396.

+3 -119

0 comment

2 changed files

pr created time in 14 days

create barnchmbrubeck/log

branch : const

created branch time in 14 days

pull request commentrust-lang/log

Update to cfg-if 1.0

+cfg-if = ">=0.1.2, ~1"

This doesn't work as intended. When there are multiple requirements, Cargo will only allow versions that meet all of the requirements. So this is compatible with 1.0.0 (which matches both parts), but not with 0.1.2 (which matches only the first part):

$ cargo update -p cfg-if --precise 0.1.2
    Updating crates.io index
error: failed to select a version for the requirement `cfg-if = ">=0.1.2, ~1"`
candidate versions found which didn't match: 0.1.2

(Even if Cargo used “or” instead of “and” to combine the requirements, this would still be incorrect, because then it would allow versions like 2.0.0, which matches the first requirement but not the second.)

mbrubeck

comment created time in 14 days

issue commentservo/rust-smallvec

Implementing an append() method?

It should be straightforward to add an append method to SmallVec, and patches for this would be welcome. (Or I can implement it myself when I have time.)

For now, this code is equivalent to v1.append(v2):

v1.extend(v2.drain(..))

Or if you don't need to re-use v2 afterward, you can simply:

v1.extend(v2)
MonliH

comment created time in 15 days

PullRequestReviewEvent

Pull request review commentcloudflare/lol-html

Update to hashbrown 0.9

 impl TypedChildCounterMap {                     Some(next) => {                         v.current = next;                     },-                    None => return false+                    None => return true                 }             }-            true+            false         }).for_each(drop);

Switching to retain is a good idea for simplicity. However, this code still can't use the standard library HashMap on stable Rust, because it also uses uses raw_entry_mut.

mbrubeck

comment created time in 15 days

push eventmbrubeck/lol-html

Matt Brubeck

commit sha 66f4a02f6a64328a7a069b37582e869212915165

Use HashMap::retain instead of drain_filter

view details

push time in 15 days

push eventmbrubeck/rayon

Matt Brubeck

commit sha 9691328a5ae31ea88a54b7eb668959eb986d8d8e

Use Iterator::copied

view details

push time in 16 days

pull request commentrayon-rs/rayon

Update crossbeam dependencies (requires Rust 1.36)

It looks like this PR has confused bors. Does the bors.toml change need to land before the GitHub Actions changes?

mbrubeck

comment created time in 16 days

PR opened Stebalien/tempfile

Update to cfg-if 1.0

The version was bumped for alexcrichton/cfg-if#37, which removed some inconsistent syntax which has no effect on this crate. There are no other changes compared to the previous version.

+1 -1

0 comment

1 changed file

pr created time in 16 days

push eventmbrubeck/tempfile

Matt Brubeck

commit sha 5f896d2a08d0fd95d0c086ef2b0b9d8a632065a5

Upgrade to libc 0.2

view details

Steven Allen

commit sha cf8ad773872f2d4379a42375014280f38328e612

Merge pull request #16 from mbrubeck/libc0.2 Upgrade to libc 0.2

view details

Steven Allen

commit sha 2d918de825ede468f4e84c389b343b429621ddf1

Fix appveyor

view details

Steven Allen

commit sha 2e1b3d777ed131cee4617ced3566486c7573f7bf

Update kernel32 dep

view details

Steven Allen

commit sha 2f1e93b4965d93f9147fccccef99658cd48c61a7

bump to 1.1.2

view details

Steven Allen

commit sha e7e800a9a3e7ccc966d81158c78b33ac27babbf7

Cast to *const libc::c_char. Because libc >= 2.0 and std <= 1.5 disagree.

view details

Steven Allen

commit sha 421957707897d77f5c293e0045a12d3a656befee

bump to 1.1.3

view details

Steven Allen

commit sha 1eb81de7d5a1f1ef89820292fbed7b86ec9c43fe

Use libc O_CLOEXEC

view details

Steven Allen

commit sha 6df33e8a82e956433a43d63d6cf0f092c3d6dfa1

impl From for converting PersistError to NamedTempFile

view details

Steven Allen

commit sha ff177869d88814d7efd47820c112a8265adb903f

Add persist_noclobber. Allows persisting a named temporary file without clobbering an existing target.

view details

Sunrin SHIMURA (keen)

commit sha ddf3f710f4e28b43f53a5174a02745cc80629c68

Allow custom named temporary files

view details

Steven Allen

commit sha 3dbcaaecc1d5c8e9b566735ffc4f5ada1b0966ee

Named tempfile nits.

view details

Steven Allen

commit sha 34e42b9fdd931ad694900b0afd7c7553a4ac8dd0

Fix doctest on windows

view details

Steven Allen

commit sha c78a3119c03125c87b00c972e5cd9671bf912100

Version 2.0 Replace `TempFile` with a `tempfile()` function that returns normal `File` objects.

view details

Steven Allen

commit sha 762a64b9d6a5b1e29b94dda52520ffa70484ee4c

Fix appveyor

view details

Bastien Dejean

commit sha bfb7ec75e5aa9c22ffe6f3001e183b82c8d1d0f1

Fix example in README

view details

Steven Allen

commit sha d45b9f1cc55e4cd4cc91593e4b0575546c7b5475

Merge pull request #21 from baskerville/readme-example Fix example in README

view details

Cody P Schafer

commit sha 7db9ba77b7d08876418f1e87a7c8e7e62a8a0ec5

imp/unix: always cast cstr.as_ptr() to avoid issues with differing c_char types

view details

Steven Allen

commit sha 6ccc01e765f98e5c2f1175679555bfcd92e45433

Merge pull request #22 from jmesmon/cast-as-ptr imp/unix: always cast cstr.as_ptr() to avoid issues with differing c_char types

view details

Steven Allen

commit sha 1ee1117fac5a42d04c7eb712e4350b282b089abc

Add homepage link

view details

push time in 16 days

pull request commentrust-random/getrandom

Update to cfg-if 1.0

IIRC we also can use cfg-if = "1", which is a bit shorter.

Done.

mbrubeck

comment created time in 16 days

push eventmbrubeck/getrandom

Matt Brubeck

commit sha 93230d09311a45f4c07b6af1020da1c5dc7182c4

Update to cfg-if 1.0

view details

push time in 16 days

pull request commentnix-rust/nix

Update to cfg-if 1.0

The only change in this release is alexcrichton/cfg-if#37, which removes some syntax that was inconsistent with the standard cfg macro and attributes.

There's no urgent reason to update right away, but once everyone has updated to latest version, it will reduce the need for downstream crates to download and compile two different versions of cfg-if. It will also let users of this library automatically benefit from fixes in any future 1.x release of cfg-if.

mbrubeck

comment created time in 16 days

create barnchmbrubeck/rust-openssl

branch : deps

created branch time in 16 days

PR opened sfackler/rust-openssl

Update to cfg-if 1.0
+1 -1

0 comment

1 changed file

pr created time in 16 days

PR opened nix-rust/nix

Update to cfg-if 1.0
+1 -1

0 comment

1 changed file

pr created time in 16 days

create barnchmbrubeck/nix

branch : deps

created branch time in 16 days

fork mbrubeck/nix

Rust friendly bindings to *nix APIs

fork in 16 days

PR opened rust-random/getrandom

Update to cfg-if 1.0
+1 -1

0 comment

1 changed file

pr created time in 16 days

create barnchmbrubeck/getrandom

branch : deps

created branch time in 16 days

fork mbrubeck/getrandom

A small cross-platform library to securely get random data (entropy)

fork in 16 days

PR opened sebcrozet/instant

Update to cfg-if 1.0
+1 -1

0 comment

1 changed file

pr created time in 16 days

create barnchmbrubeck/instant

branch : deps

created branch time in 16 days

fork mbrubeck/instant

A std::time::Instant replacement that works on WASM too.

fork in 16 days

push eventmbrubeck/parking_lot

Amanieu d'Antras

commit sha 21c2c349e135b116dbfeb458c1f00a3afb17d2f5

Merge pull request #50 from mbrubeck/deps Update to smallvec 0.6

view details

Łukasz Neumann

commit sha 0f0f6ab58281471be348769ebd37b5d19451764a

Removed unnecessary feature gates

view details

Amanieu d'Antras

commit sha d45a7921f3c8271109ba4899ad0bcafada14da41

Merge pull request #51 from fuine/master Remove unnecessary feature gates

view details

Amanieu d'Antras

commit sha 4d6581e04967cf181548f738338e89985446d65c

Bump parking_lot_core version to 0.2.7

view details

Amanieu d'Antras

commit sha c7233a99ef27fb2779f0de3bea5dbbf075dd4cf2

Use libc::SYS_futex instead of our own definition

view details

Amanieu d'Antras

commit sha 9e20fec6b93145ffd40189be659563afaf6ebdd9

Bump parking_lot_core version to 0.2.8

view details

Malo Jaffré

commit sha fa6e0b4a56493ad65456b8d5daca3c731bdfe47b

Fix pulldown migration warnings in parking_lot_core Lists now require an empty line before them, and a link can no longer be split on multiple lines. See rust-lang/rust#44229.

view details

Malo Jaffré

commit sha 5b87185c34c3349dfa55512a9e9f2bc24494d943

Add an explicit type to silence a future compatibility warning requeue_threads` now requires an explicit type because of the `is_null` method call later in the code. See rust-lang/rust#46906

view details

Malo Jaffré

commit sha 54d79fa5e7f3b894f7fcb9be4a336aa5e4e26dcd

Bump parking_lot_core to 0.2.9

view details

Amanieu d'Antras

commit sha 9ab56489905e2af64bc358502ca22f8eec0e100b

Merge pull request #53 from MaloJaffre/master Fix future compatibilty warnings and bump version

view details

Amanieu d'Antras

commit sha ca31841ccffa1f9376a5aa7dedf2ff37682f2a4f

Clarify the documentation about Cargo features. Fixes #54

view details

Bastien Orivel

commit sha ff764afd5b9b877046c455baa1e8b6cc81f48739

Bump winapi to 0.3

view details

Amanieu d'Antras

commit sha 3ad33d277fe78b07d44a47a9327a991abf0aa60a

Merge pull request #55 from Eijebong/winapi Bump winapi to 0.3

view details

Amanieu d'Antras

commit sha 600b02a0acdda1a30d7ee8dca7ec1a51963894fc

Bump parking_lot_core version to 0.2.10

view details

Amanieu d'Antras

commit sha 03ad65df95260c142f3f9eb261cbed7d786ea210

Simply emulation layer for stable Rust

view details

Amanieu d'Antras

commit sha c8d0bd4920d2ba94cc58377636cbb94f1c79472a

Rustfmt

view details

messense

commit sha 3b940b5303c1282356dd40ae6dc2588f292e20fb

Upgrade to rand 0.4

view details

Amanieu d'Antras

commit sha a5c341de6f4555577be3483fc2e73898d7ef4da3

Merge pull request #57 from messense/feature/rand-0-4 Upgrade to rand 0.4

view details

Lakelezz

commit sha 870110cafd149ef9969e04f1ac9ba844e32adf80

Add `?Sized` on `Send`- and `Sync`-impl for `Mutex`.

view details

Lakelezz

commit sha e3fbfdf7ed3619903eabe8145fd6017e8f45d8fb

Add `?Sized` on `Send`- and `Sync`-impl for `ReentrantMutex`.

view details

push time in 16 days

PR opened Amanieu/parking_lot

Update to cfg-if 1.0
+1 -1

0 comment

1 changed file

pr created time in 16 days

create barnchmbrubeck/log

branch : deps

created branch time in 16 days

PR opened rust-lang/log

Update to cfg-if 1.0
+1 -1

0 comment

1 changed file

pr created time in 16 days

create barnchmbrubeck/flate2-rs

branch : deps

created branch time in 16 days

PR opened rust-lang/flate2-rs

Update to cfg-if 1.0
+1 -1

0 comment

1 changed file

pr created time in 16 days

push eventmbrubeck/rayon

Matt Brubeck

commit sha e81835c0741da899112930c5e8d79b4d7792be0d

Update crossbeam dependencies (requires Rust 1.36)

view details

push time in 16 days

PR opened rayon-rs/rayon

Update crossbeam dependencies (requires Rust 1.36)

Update to the latest versions of:

  • crossbeam-channel (0.5.0)
  • crossbeam-deque (0.8.0)
  • crossbeam-utils (0.8.0)

This increases the minimum Rust toolchain requirement from 1.31 to 1.36.

+11 -11

0 comment

6 changed files

pr created time in 16 days

create barnchmbrubeck/rayon

branch : deps

created branch time in 16 days

push eventservo/uluru

CYBAI

commit sha f6c33c11f43fb98954eba5e5e5551f348a8d68f1

Add quickcheck as dependency

view details

CYBAI

commit sha 5c8cdf99066e8c1210ef504c150d65556524b27c

Add new tests for touch, find and front with quickcheck

view details

Matt Brubeck

commit sha d41097bdc7c64301cd8ab66659d582dd2c5d5a22

Merge pull request #13 from CYBAI/quickcheck Use QuickCheck for test

view details

push time in 16 days

PR merged servo/uluru

Use QuickCheck for test

Current test cases are great enough though, I wonder if it's good to introduce quickcheck to have more randomness in the test cases.

Also, I added tests for front, find and touch in this PR.

(btw, I just noticed there's no CI for this repo 👀 maybe it's good to use GitHub Actions or Travis CI?)

+100 -0

3 comments

3 changed files

CYBAI

pr closed time in 16 days

pull request commentPistonDevelopers/glutin_window

Work in progress: Update to glutin 0.25

Thanks, that's interesting. I've rebased this branch, updated it to glutin 0.25 and winit 0.23, and tried using ControlFlow::Wait (though I'm not sure I'm using it correctly). My Mac program still uses too much CPU, though I'm still not sure where the fault lies for that. Help is still welcome.

mbrubeck

comment created time in 20 days

push eventmbrubeck/glutin_window

Matt Brubeck

commit sha 1a45c70abea73fab01813d2505b539415e306a3d

Update to glutin 0.25

view details

push time in 20 days

push eventmbrubeck/glutin_window

Sven Nilsen

commit sha cb9c23a7b67eac2a6cfde32547585e0ed4133df7

Published 0.64.0

view details

Sven Nilsen

commit sha 4bab988f7650a709574de6527fea1e09c4c17851

Merge pull request #181 from bvssvni/master Published 0.64.0

view details

Sven Nilsen

commit sha e2fdb0784ec5b1c563940da69eb70c843a0d4ef1

Published 0.65.0

view details

Sven Nilsen

commit sha f18e443cf20f7eddc3c9838dacd705ec0e3de826

Merge pull request #182 from bvssvni/master Published 0.65.0

view details

Sven Nilsen

commit sha fdd5657d69b852a142320dc27e66333b77096967

Published 0.66.0

view details

Sven Nilsen

commit sha 11dec73f245d38231de88b5905f5c6e13048156e

Merge pull request #184 from bvssvni/master Published 0.66.0

view details

adumbidiot

commit sha 4981f0a52a3f2394bc903530635557214f7c01ea

Add constructor for existing Glutin window

view details

Sven Nilsen

commit sha c08113c268c4cdb8ef37be729d4658870cdf41d2

Merge pull request #185 from adumbidiot/from-raw Add constructor for existing Glutin window

view details

Sven Nilsen

commit sha 95093635047b44f5a483b28795fa09d4dfa8922f

Published 0.67.0

view details

Sven Nilsen

commit sha 39478e0fe1020f16ca6e9dbf5b959190df96b9aa

Merge pull request #186 from bvssvni/master Published 0.67.0

view details

Matt Brubeck

commit sha e9b62a2c9516d6203b428a76def5652ce94c816c

Update to glutin 0.22

view details

push time in 20 days

pull request commentservo/uluru

Use QuickCheck for test

Thanks, this is very useful!

I'm not sure that every test needs to be a quickcheck test, though. For example, the new evict_all test doesn't really add any new coverage compared to the old one, since it only randomizes the stored values, which has no effect on the uluru code being tested.

For simplicity, could you keep the existing non-quickcheck tests, and use quickcheck only in new tests that benefit from the randomization?

CYBAI

comment created time in 20 days

pull request commentrust-lang/rust

Add PartialEq impls for Vec <-> slice

@bors retry

This was apparently a spurious failure caused by infrastructure problems. Not sure if I have appropriate permissions for this bors command; let's see...

mbrubeck

comment created time in 22 days

push eventmbrubeck/rust-ffmpeg-sys

Matt Brubeck

commit sha 4482b3758cd6a9790e5f9cf90498f5d9b83c17e7

Disable unused bindgen features This reduces compile time by disabling several unused dependencies.

view details

push time in a month

push eventmbrubeck/agate

Matt Brubeck

commit sha d13c98d614233f0b31d023db457abb640b7604fb

Update dependencies

view details

push time in a month

PR opened zmwangx/rust-ffmpeg-sys

Disable unused bindgen features

This reduces compile time by disabling several unused dependencies.

+1 -1

0 comment

1 changed file

pr created time in a month

create barnchmbrubeck/rust-ffmpeg-sys

branch : bindgen

created branch time in a month

fork mbrubeck/rust-ffmpeg-sys

FFmpeg bindings for Rust.

fork in a month

issue commentunicode-rs/unicode-segmentation

Typo in `/src/graphmeme.rs`

In mathematic and formal logic, iff means “if and only if.”

gastrodon

comment created time in a month

issue commentrust-lang/rust

Inlining of `let` should preserve borrowing soundness on "pure" left arguments

In any case, thank you for the feedback here, and I'll try to make sure it's tracked somewhere useful.

For future reference, if you choose, you can file issues on the rust-lang/rfcs repo without actually writing an RFC, for proposals like this. (Someone will eventually need to do the work of specifying and implementing the change, but it doesn't need to be the same person who opens the issue.)

jeapostrophe

comment created time in a month

push eventmbrubeck/agate

Matt Brubeck

commit sha 75a0d127a150f444223c93609bf0a47b07c4fe4f

Remove duplicated instructions

view details

push time in a month

issue closedmbrubeck/agate

Request: prebuilt binaries for Arm released on github

Hi, Matt. Thanks for your work on this package. I'm no developer and quite new on this gemini cosmos.

I tested the binary you released. Just to tell you, this is working fine on Arch Linux x64. From all the other gemini servers I tested, this one gave me the less frills.Clear and concise instructions on the Readme page. No problem with the SSL certificates.

I'm planning to make a package for Arch Linux x64. Both a Rust source package and a binary package (pulling from your binary release ).

Hope you can continue the good work, and releasing the binaries. I have a request though.

.... Agate.... should be quite efficient even when running on low-end hardware and serving many concurrent requests.

Exactly ! It was my guess also, and what attracted me to agate. I'm just dying to test this on my Raspberry Pi's (both arm7h and aarch64).

Very limited ressources for compiling. Could you also release binaries for the arm platform ? It would make it much easier for people who dont have, dont want to download the entire rust distribution to quickly try it out.

Thanks in advance

closed time in a month

m040601

push eventmbrubeck/agate

Matt Brubeck

commit sha 9b5ca7f1300a3680ca1539b21ddd7a5ce5864699

Version 1.2.2

view details

push time in a month

push eventmbrubeck/agate

Matt Brubeck

commit sha 74a941c4b3d1bd5612cd95dad3338e5c85a8ccb9

Version 1.2.2

view details

push time in a month

push eventmbrubeck/agate

Matt Brubeck

commit sha be0ef2bf80fe3d159453021d3fff2a027002c8bb

Version 1.2.2

view details

push time in a month

issue commentmbrubeck/agate

Request: prebuilt binaries for Arm released on github

Thanks a bunch for the interest! I've uploaded ARM binaries for the latest release:

https://github.com/mbrubeck/agate/releases/tag/v1.2.2

I have only a Raspberry Pi Zero for testing, so the aarch64 and armv7 binaries are currently untested. Please let me know if they work for you!

m040601

comment created time in a month

release mbrubeck/agate

v1.2.2

released time in a month

created tagmbrubeck/agate

tagv1.2.2

Very simple server for the Gemini hypertext protocol

created time in a month

push eventmbrubeck/agate

Matt Brubeck

commit sha 34fc4968aea027356e5e18f82175334e0f488ae7

Update dependencies

view details

push time in a month

issue commentrust-lang/rust

Type parameters on statics

Similar to https://github.com/rust-lang/rfcs/issues/2130

brendanzab

comment created time in a month

create barnchmbrubeck/workspace-build-dep

branch : master

created branch time in a month

created repositorymbrubeck/workspace-build-dep

created time in a month

push eventmbrubeck/rust

Oliver Scherer

commit sha dcc202723a10612061b3c55cdbad0c2d63f2b712

Apply suggestions from code review Co-authored-by: Wesley Wiser <wwiser@gmail.com>

view details

Joshua Nelson

commit sha d468a81a8a62131b5b88e3ca09512b8a08895274

Remove duplication in `fold_item`

view details

bors

commit sha 814d252417cec7cfca98d75db0b3d89555d6d676

Auto merge of #75562 - oli-obk:const_prop_no_aggregates, r=wesleywiser Check that we don't use `Rvalue::Aggregate` after the deaggregator fixes #75481 r? @wesleywiser cc @RalfJung (modified the validator)

view details

Guillaume Gomez

commit sha 3307ba8212a440e0f13a5dfdae57f2a24acdc025

Ignore code examples on given items where it doesn't make sense

view details

Guillaume Gomez

commit sha 6fb7e02a3688efa5f3eec4835ef9b5de50eb3c3c

Update rustdoc coverage UI test

view details

Lzu Tao

commit sha d97bbd3a2182f6199287601fed993d2d20e1f568

Suppress ty::Float in MIR comments of ty::Const Already covered by MIR constant comments

view details

Joshua Nelson

commit sha f5d784845801f2c6ec27857f0dff865f376f2ed1

Remove duplicate binding in match Co-authored-by: lzutao <taolzu@gmail.com>

view details

Josh Stone

commit sha f29f21285efd38574e5a36b24a36b21f233ee336

Rollup merge of #75672 - kofls:intradoc-fix, r=jyn514 Move to intra-doc links for task.rs and vec.rs Partial fix for #75080 links for [`get`], [`get_mut`] skipped due to #75643 link for [`copy_from_slice`] skipped due to #63351

view details

Josh Stone

commit sha ba104d291a40f5242c56b672763a1941ac23b52d

Rollup merge of #75702 - GuillaumeGomez:cleanup-e0759, r=pickfire Clean up E0759 explanation r? @Dylan-DPC cc @pickfire

view details

Josh Stone

commit sha 7ac126ec563cd1b987dd1aa49d4a3b9288c03771

Rollup merge of #75703 - tmiasko:stack-overflow-musl, r=cuviper Enable stack-overflow detection on musl for non-main threads

view details

Josh Stone

commit sha 6a3425eb08a1a53d3fd7581f824c3f1934fcf466

Rollup merge of #75710 - ThibsG:FixBadPrinting75447, r=oli-obk Fix bad printing of const-eval queries Fixes: #75447 r? @RalfJung cc @oli-obk

view details

Josh Stone

commit sha 02b2f73fc500e33dd29547579519a60156c2e6ab

Rollup merge of #75716 - tlively:upgrade-emscripten-1.39.20, r=cuviper Upgrade Emscripten on CI to 1.39.20 This Emscripten version was the first to be cut after the LLVM 11 release branch was created, so it should be the most compatible with LLVM 11. The old version we were using was incompatible with LLVM 11 because its wasm-ld did not understand all the relocations that LLVM 11 emits.

view details

Josh Stone

commit sha 16b9b9017a30006de624935a44a1df8c02673592

Rollup merge of #75731 - lzutao:mir-cmts-suppress-float-ty-const, r=oli-obk Suppress ty::Float in MIR comments of ty::Const Already covered by MIR constant comments

view details

Josh Stone

commit sha 6ac1523b23295ca1c87cc9b05ff3548807926595

Rollup merge of #75733 - pickfire:patch-3, r=matklad Remove duplicated alloc vec bench push_all_move push_all_move is the same as extend

view details

Josh Stone

commit sha 2a3f43de428c70e140c7882174855165b1724f5f

Rollup merge of #75743 - matklad:excl, r=davidtwco Rename rustc_lexer::TokenKind::Not to Bang All other tokens are named by the punctuation they use, rather than by semantics operation they stand for. `!` is the only exception to the rule, let's fix it.

view details

bors

commit sha 332369110919ac27c8a0bc0b21bf9d2f9fd9829d

Auto merge of #75747 - cuviper:rollup-icke90l, r=cuviper Rollup of 8 pull requests Successful merges: - #75672 (Move to intra-doc links for task.rs and vec.rs) - #75702 (Clean up E0759 explanation) - #75703 (Enable stack-overflow detection on musl for non-main threads) - #75710 (Fix bad printing of const-eval queries) - #75716 (Upgrade Emscripten on CI to 1.39.20 ) - #75731 (Suppress ty::Float in MIR comments of ty::Const) - #75733 (Remove duplicated alloc vec bench push_all_move) - #75743 (Rename rustc_lexer::TokenKind::Not to Bang) Failed merges: r? @ghost

view details

Matthew Jasper

commit sha 67fb5839df4c737911556f3c9967d632ae530a7c

Don't immediately error for cycles during normalization

view details

Guillaume Gomez

commit sha 631c80659dab1e6f0b335cd7862eddc341eff0ac

Remove "total" columns in --show-coverage output

view details

Guillaume Gomez

commit sha 9c254c18d6d32a15879cc7f57e3039b66a481340

Update how doc examples are counted

view details

Guillaume Gomez

commit sha d108bd53866aef2a3b76164352c095e898fe92db

Add documentation for --show-coverage option

view details

push time in 2 months

issue commentrust-lang/rust

Tracking issue for HashMap::drain_filter and HashSet::drain_filter (hash_drain_filter)

This is now implemented in nightly behind the unstable hash_drain_filter feature:

  • https://doc.rust-lang.org/nightly/std/collections/struct.HashMap.html#method.drain_filter
  • https://doc.rust-lang.org/nightly/std/collections/struct.HashSet.html#method.drain_filter
DutchGhost

comment created time in 2 months

pull request commentrust-lang/rust

Add drain_filter method to HashMap and HashSet

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

Rebased to resolve a merge conflict in libstd.natvis.

mbrubeck

comment created time in 2 months

push eventmbrubeck/rust

dylni

commit sha bb70e52f5f5ee25012193f9f4f4372702b97b20e

Add `slice::check_range`

view details

dylni

commit sha 202b242d87c30c2fe1475342f9b93a8dfc65cd17

Fix links

view details

dylni

commit sha ed02b90e9b76b9ce2e8e99a99dbadd96ab4dfb42

Fix links again

view details

The8472

commit sha 1316c786a08344c965a97b1b67c76a300a479eec

Workaround for copy_file_range spuriously returning EOPNOTSUPP when attemted on a NFS mount under RHEL/CentOS 7. The syscall is supposed to return ENOSYS in most cases but when calling it on NFS it may leak through EOPNOTSUPP even though that's supposed to be handled by the kernel and not returned to userspace. Since it returns ENOSYS in some cases anyway this will trip the HAS_COPY_FILE_RANGE detection anyway, so treat EOPNOTSUPP as if it were a ENOSYS. https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/7.8_release_notes/deprecated_functionality#the_literal_copy_file_range_literal_call_has_been_disabled_on_local_file_systems_and_in_nfs https://bugzilla.redhat.com/show_bug.cgi?id=1783554

view details

The8472

commit sha f0783632d315db90c0ca34d79d56207d132f3764

more concise error matching

view details

The8472

commit sha 4ddedd521418d67e845ecb43dc02c09b0af53022

perform copy_file_range until EOF is reached instead of basing things on file size This solves several problems - race conditions where a file is truncated while copying from it. if we blindly trusted the file size this would lead to an infinite loop - proc files appearing empty to copy_file_range but not to read/write https://github.com/coreutils/coreutils/commit/4b04a0c - copy_file_range returning 0 for some filesystems (overlay? bind mounts?) inside docker, again leading to an infinite loop

view details

dylni

commit sha d04e6b8de5fe6bbf203c534c35e6f55e8960ab46

Replace ad hoc implementations with `slice::check_range`

view details

Yuki Okushi

commit sha 18ad5a594ec4ee039897eb03d90dfeb117b4c6d6

Add a regression test for issue-72793

view details

Stein Somers

commit sha e5f9d7ff92f62cde3ef1b7301ac4ac3adab990d9

BTreeMap: introduce marker::ValMut and reserve marker::Mut for unique access

view details

dylni

commit sha d9e877fb98212a47dd425e145b8b3e4283e6b487

Add more information to safety comment

view details

Arkadiusz Piekarz

commit sha aa40c028fcb20a47fb214fea2899ff9a8ae88840

Unstable Book: add links to tracking issues for FFI features

view details

mental32

commit sha f03d0b38d6a33a64307d83f8ddd3df8ef57ca537

`impl Rc::new_cyclic`

view details

mental

commit sha 42fb27001e07e832cb40604c7daeaa6aada07675

typo Co-authored-by: Andrew Hickman <andrew.hickman1@sky.com>

view details

Ivan Tham

commit sha bb5e79cbd11dbb8aa91840108b67085e5d5d04f8

Link vec doc to & reference It is not always obvious that people could see the docs for `&` especially for beginners, it also helps learnability.

view details

Joshua Nelson

commit sha 1b1935452f26593d07fa17ccbe3308901dda891b

[WIP] Fix intra-doc links on pub re-exports This removes the incorrect error, but doesn't show the documentation anywhere.

view details

Ivan Tham

commit sha 20a68666d89a85e14021f656233a086e46ff8a34

Try removing [prim@reference]

view details

Joshua Nelson

commit sha e885f00f24aab657b3a9835818fc96e638e7fb21

Comment out test for generated docs until rustdoc changes its behavior around documenting re-exports

view details

Andy Russell

commit sha e0822ecdbc43a6128136661bb73fb6f3c3db2b4a

rustdoc: do not use plain summary for trait impls Fixes #38386. Fixes #48332. Fixes #49430. Fixes #62741. Fixes #73474.

view details

Andy Russell

commit sha 98232ece14bdd68aeac3d761039d9a7c88c30b3f

fix broken trait method links

view details

Joshua Nelson

commit sha d7150154fa5c35c0b570570f156ba3a5cc6dfb1d

Improve tests Now this actually tests the links are generated correctly

view details

push time in 2 months

pull request commentrust-lang/rust

Add drain_filter method to HashMap and HashSet

I think src/etc/natvis/libstd.natvis (Windows debuginfo) also needs to be updated.

This is now updated, though I don't have a Windows machine to test it on.

mbrubeck

comment created time in 2 months

push eventmbrubeck/rust

Matt Brubeck

commit sha 1eae5d32500deaa20da276c4117672d361d6b92a

Implement HashSet in terms of hashbrown::HashSet

view details

Matt Brubeck

commit sha d1dd7fcf8b2f1647904708f1fdd81c09eb653627

Add HashMap::drain_filter and HashSet::drain_filter Implements #59618.

view details

Matt Brubeck

commit sha 4bbd823198c127e71a70a6992abbd915f298173a

Tests for HashMap/HashSet::drain_filter

view details

push time in 2 months

pull request commentrust-lang/rust

Add drain_filter method to HashMap and HashSet

You might want to double-check if the representation change affected the debuginfo providers and tests.

Thanks for the tip! I updated this branch to fix to debuginfo providers for both gdb and lldb.

mbrubeck

comment created time in 2 months

Pull request review commentasync-rs/async-tls

finer-grained dependencies on futures crates

 travis-ci = { repository = "async-std/async-tls" } appveyor = { repository = "async-std/async-tls" }  [dependencies]-futures = "0.3.4"+futures-io = "0.3.5"+futures-util = "0.3.5"

Done.

mbrubeck

comment created time in 2 months

PullRequestReviewEvent

push eventmbrubeck/async-tls

Matt Brubeck

commit sha 5df4a09a0c37a9e231c4db0f82e6aba33b78b3aa

Use finer-grained dependencies on futures crates

view details

push time in 2 months

pull request commentservo/rust-smallvec

Implement Array for all sizes <= 32

@bors-servo r+

Thanks!

thomcc

comment created time in 2 months

push eventservo/rust-smallvec

Matt Brubeck

commit sha 158e0cf7c42fe06bc97744408a569c4c7a224ecc

Revert "Add cargo fmt to travis build config" This reverts commit b3fada197faabbc4bb0022ab4f9ccafca2c17497.

view details

push time in 2 months

push eventmbrubeck/rust

Matt Brubeck

commit sha f6dafd0728d3c917116d1ccfa48c99f3f3092afb

Implement HashSet in terms of hashbrown::HashSet

view details

Matt Brubeck

commit sha 4d7ea92e05041775a0a8355aa7b482ef9d2027eb

Add HashMap::drain_filter and HashSet::drain_filter Implements #59618.

view details

Matt Brubeck

commit sha c589c4100e91f523ed01526196c38a53223050af

Tests for HashMap/HashSet::drain_filter

view details

push time in 2 months

push eventmbrubeck/rust

Matt Brubeck

commit sha 3b74283262c3718725aa7bd68c305e18737aba37

Implement HashSet in terms of hashbrown::HashSet

view details

Matt Brubeck

commit sha 085078d79a0f3acfe0b27d5357bef6bd077a2742

Add HashMap::drain_filter and HashSet::drain_filter Implements #59618.

view details

Matt Brubeck

commit sha 60750d63f6fa527a82c54af8a5e8e89982e405c0

Tests for HashMap/HashSet::drain_filter

view details

push time in 2 months

issue commentrust-lang/rfcs

Map::retain

There was some incomplete work on BTreeMap/BTreeSet::retain at rust-lang/rust#66747.

Gankra

comment created time in 2 months

issue commentrust-lang/rust

Add drain_filter for BinaryHeap

All but two of the methods originally requested here have since been implemented. I'm splitting this issue so that we have one ticket for per method. This ticket is for BinaryHeap::drain_filter.

BTreeMap/BTreeSet::drain_filter are tracked at #70530. BinaryHeap::retain is tracked at #71503. BTreeMap/BTreeSet::retain are part of rust-lang/rfcs#1338.

RalfJung

comment created time in 2 months

push eventmbrubeck/rust

Matt Brubeck

commit sha 40dacbd049f6d00405cde5554d4c2c2014d3a00b

Implement HashSet in terms of hashbrown::HashSet

view details

Matt Brubeck

commit sha 089ad70645f9d291ef449aa691b211988346c05d

Add HashMap::drain_filter and HashSet::drain_filter Implements #59618.

view details

Matt Brubeck

commit sha b4bbae3b1e96d5bb10296b2ac4ec858498e5c6f5

Tests for HashMap/HashSet::drain_filter

view details

push time in 2 months

push eventmbrubeck/rust

Matt Brubeck

commit sha 881f3548a15bcbc7d5f99db67f56430581277186

Update debuginfo providers for new HashSet

view details

push time in 2 months

push eventmbrubeck/rust

Matt Brubeck

commit sha 7796e07ca9d6bf25fe20a4b80cfb59aa0c15d65e

Implement HashSet in terms of hashbrown::HashSet

view details

Matt Brubeck

commit sha d18045826c0df4fd9e9f6e3e9781c45625fed0da

Add HashMap::drain_filter and HashSet::drain_filter Implements #59618.

view details

Matt Brubeck

commit sha 4e048401d4f733b706f8f7a729f2ac62521d1a5c

Tests for HashMap/HashSet::drain_filter

view details

push time in 2 months

push eventmbrubeck/rust

Matt Brubeck

commit sha dd2793eede3d2be865dae7a90bffeb18af7e03bf

Implement HashSet in terms of hashbrown::HashSet

view details

Matt Brubeck

commit sha f18fd185b79ca72107f0ed7030414124dc3206b3

Add HashMap::drain_filter and HashSet::drain_filter Implements #59618.

view details

Matt Brubeck

commit sha aeaddab2323080b675841ab4f8eb702dbea09b58

Tests for HashMap/HashSet::drain_filter

view details

push time in 2 months

PR opened rust-lang/rust

Reviewers
Add drain_filter method to HashMap and HashSet

Add HashMap::drain_filter and HashSet::drain_filter, implementing part of rust-lang/rfcs#2140. These new methods are unstable. The tracking issue is #59618.

The added iterators behave the same as BTreeMap::drain_filter and BTreeSet::drain_filter, except their iteration order is arbitrary. The unit tests are adapted from alloc::collections::btree.

This branch rewrites HashSet to be a wrapper around hashbrown::HashSet rather than std::collections::HashMap. (Both are themselves wrappers around hashbrown::HashMap, so the in-memory representation is the same either way.) This lets std re-use more iterator code from hashbrown. Without this change, we would need to duplicate much more code to implement HashSet::drain_filter.

This branch also updates the hashbrown crate to version 0.9.0. Aside from changes related to the DrainFilter iterators, this version only changes features that are not used in libstd or rustc. And it updates indexmap to version 1.6.0, whose only change is compatibility with hashbrown 0.9.0.

+481 -69

0 comment

6 changed files

pr created time in 2 months

push eventmbrubeck/rust

Matt Brubeck

commit sha 79e54a56a040d132111a95888d27e590e1a6d231

Add HashMap::drain_filter and HashSet::drain_filter Implements #59618.

view details

Matt Brubeck

commit sha dd3987104bbc8f2b74167d95fe700fd502d3a228

Tests for HashMap/HashSet::drain_filter

view details

push time in 2 months

push eventmbrubeck/rust

Matt Brubeck

commit sha a046413879806958aa809858bb45a088a7e0c43d

Tests for HashMap/HashSet::drain_filter

view details

push time in 2 months

push eventmbrubeck/rust

Matt Brubeck

commit sha 590efd33ebbfefd60845f93f18f35e1c593a2299

Tests for HashMap/HashSet::drain_filter

view details

push time in 2 months

push eventmbrubeck/rust

Matt Brubeck

commit sha 0c1cb274a457c514191ef1e1b3daabf75e9a3072

Update to hashbrown 0.9

view details

Matt Brubeck

commit sha 6f42e00b83d8e5ec183085cc53618e51aa05205a

Implement HashSet in terms of hashbrown::HashSet

view details

Matt Brubeck

commit sha 5363b4239a174ddf5ca07487142a95a5ef05ab15

Add HashMap::drain_filter and HashSet::drain_filter

view details

push time in 2 months

pull request commentbluss/indexmap

Update to hashbrown 0.9

Bumped the minor version.

mbrubeck

comment created time in 2 months

push eventmbrubeck/indexmap

Matt Brubeck

commit sha 083f5a762c24a6b17efbf0fd1bfb9011744949b6

Version 1.6.0

view details

push time in 2 months

pull request commentCAD97/sorbus

Update to hashbrown 0.9

Applied your comment fix.

mbrubeck

comment created time in 2 months

push eventmbrubeck/sorbus

Matt Brubeck

commit sha 2898bad417ebfa47f412cc4224b8e4d7bc0bd95f

Update comment about drain_filter Co-authored-by: Christopher Durham <cad97@cad97.com>

view details

push time in 2 months

PR opened tomaka/redshirt

Update to hashbrown 0.9

The behavior of drain_filter has changed in this release:

https://github.com/rust-lang/hashbrown/issues/186

+16 -37

0 comment

8 changed files

pr created time in 2 months

create barnchmbrubeck/redshirt

branch : deps

created branch time in 2 months

fork mbrubeck/redshirt

🧑‍🔬 Operating system

fork in 2 months

PR opened JulianKnodt/satsuma

Update to hashbrown 0.9

The behavior of drain_filter has changed in this release:

https://github.com/rust-lang/hashbrown/issues/186

+4 -4

0 comment

2 changed files

pr created time in 2 months

more